> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-boun...@ffmpeg.org> On Behalf Of Andreas
> Rheinhardt
> Sent: Tuesday, 10 August 2021 17:33
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v5 1/2] libavutil/log: Add capability
> to prefix loglines with current time or current date+time
>
> Soft Works:
> > Signed-off-by: softworkz <softwo...@hotmail.com>
> > ---
> > doc/APIchanges | 3 +++
> > libavutil/log.c | 35 ++++++++++++++++++++++++++++++-----
> > libavutil/log.h | 10 ++++++++++
> > libavutil/version.h | 2 +-
> > 4 files changed, 44 insertions(+), 6 deletions(-)
> >
> > diff --git a/libavutil/log.c b/libavutil/log.c
> > index 66defa9c42..34af1da60c 100644
> > --- a/libavutil/log.c
> > +++ b/libavutil/log.c
> > static void format_line(void *avcl, int level, const char *fmt, va_list
> vl,
> > - AVBPrint part[4], int *print_prefix, int
> type[2])
> > + AVBPrint part[5], int *print_prefix, int
> type[2])
> > {
> > - AVClass* avc = avcl ? *(AVClass **) avcl : NULL;
> > + AVClass *avc = avcl ? *(AVClass **) avcl : NULL;
> > av_bprint_init(part+0, 0, AV_BPRINT_SIZE_AUTOMATIC);
> > av_bprint_init(part+1, 0, AV_BPRINT_SIZE_AUTOMATIC);
> > av_bprint_init(part+2, 0, AV_BPRINT_SIZE_AUTOMATIC);
> > av_bprint_init(part+3, 0, 65536);
> > + av_bprint_init(part+4, 0, AV_BPRINT_SIZE_AUTOMATIC);
> >
> > if(type) type[0] = type[1] = AV_CLASS_CATEGORY_NA + 16;
> > if (*print_prefix && avc) {
> > if (avc->parent_log_context_offset) {
> > - AVClass** parent = *(AVClass ***) (((uint8_t *) avcl) +
> > + AVClass **parent = *(AVClass ***) (((uint8_t *) avcl) +
>
> Nicolas wanted you to not add new code with the * not attached to the
> variable; he did not ask you to change existing code in the same patch.
> Spurious changes are frowned upon, as they impair reviewability.
Updated. Time's too precious to start arguing about such things...
softworkz
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
