[FFmpeg-devel] [PATCH 1/8] lavfi/dnn: Add Async Execution Mechanism and Documentation

2021-07-30 Thread Shubhanshu Saxena
This commit adds an async execution mechanism for common use in the TensorFlow and Native backends. This commit also adds the documentation of typedefs and functions in the async module for common use in DNN backends. Signed-off-by: Shubhanshu Saxena --- libavfilter/dnn/dnn_backend_common.c | 53

[FFmpeg-devel] [PATCH 3/8] lavfi/dnn_backend_tf: TFInferRequest Execution and Documentation

2021-07-30 Thread Shubhanshu Saxena
This commit adds a function for execution of TFInferRequest and documentation for functions related to TFInferRequest. Signed-off-by: Shubhanshu Saxena --- libavfilter/dnn/dnn_backend_tf.c | 45 1 file changed, 45 insertions(+) diff --git a/libavfilter/dnn/dnn_b

[FFmpeg-devel] [PATCH 5/8] lavfi/dnn_backend_tf: Error Handling for execute_model_tf

2021-07-30 Thread Shubhanshu Saxena
This patch adds error handling for cases where the execute_model_tf fails, clears the used memory in the TFRequestItem and finally pushes it back to the request queue. Signed-off-by: Shubhanshu Saxena --- libavfilter/dnn/dnn_backend_tf.c | 52 ++-- 1 file changed, 36

[FFmpeg-devel] [PATCH 2/8] lavfi/dnn: Common Function to Get Async Result in DNN Backends

2021-07-30 Thread Shubhanshu Saxena
This commits refactors the get async result function for common use in all three backends. Signed-off-by: Shubhanshu Saxena --- libavfilter/dnn/dnn_backend_common.c | 20 libavfilter/dnn/dnn_backend_common.h | 15 +++ libavfilter/dnn/dnn_backend_openvino.c |

[FFmpeg-devel] [PATCH 6/8] lavfi/dnn_backend_tf: Add TF_Status to TFRequestItem

2021-07-30 Thread Shubhanshu Saxena
Since requests are running in parallel, there is inconsistency in the status of the execution. To resolve it, we avoid using mutex as it would result in single TF_Session running at a time. So add TF_Status to the TFRequestItem Signed-off-by: Shubhanshu Saxena --- libavfilter/dnn/dnn_backend_tf.

[FFmpeg-devel] [PATCH 4/8] lavfi/dnn: Async Support for TensorFlow Backend

2021-07-30 Thread Shubhanshu Saxena
This commit enables async execution in the TensorFlow backend and adds function to flush extra frames. The async execution mechanism executes the TFInferRequests on a detached thread. The following is the comparison of this mechanism with the existing sync mechanism on TensorFlow C API 2.5 GPU var

[FFmpeg-devel] [PATCH 8/8] lavfi/dnn_backend_tf: Error Handling for tf_create_inference_request

2021-07-30 Thread Shubhanshu Saxena
This commit includes the check for the case when the newly created TFInferRequest is NULL. Signed-off-by: Shubhanshu Saxena --- libavfilter/dnn/dnn_backend_tf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c index 9c9686

[FFmpeg-devel] [PATCH 7/8] lavfi/dnn: Extract Common Parts from get_output functions

2021-07-30 Thread Shubhanshu Saxena
The frame allocation and filling the TaskItem with execution parameters is common in the three backends. This commit shifts this logic to dnn_backend_common. Signed-off-by: Shubhanshu Saxena --- libavfilter/dnn/dnn_backend_common.c | 26 + libavfilter/dnn/dnn_backend_common.h | 1

Re: [FFmpeg-devel] [PATCH v3] ffmpeg_opt: restore documented stream selection behaviour

2021-07-30 Thread Gyan Doshi
Plan to push tomorrow. On 2021-07-29 10:14, Gyan Doshi wrote: 11d3b03fcb added consideration of default stream disposition for audio and video when choosing the 'best' stream among all the inputs. This can lead to video streams with lower resolution or audio streams with fewer channels being sel

Re: [FFmpeg-devel] [PATCH 2/2 v2] avformat/movenc: parse h264 packets to build Sync Sample and Recovery Point tables

2021-07-30 Thread James Almer
On 7/29/2021 9:49 PM, Andreas Rheinhardt wrote: James Almer: Since we can't blindly trust the keyframe flag in packets and assume its contents are a valid Sync Sample, do some basic bitstream parsing to build the Sync Sample table in addition to a Random Access Recovery Point table. Suggested-b

Re: [FFmpeg-devel] [PATCH] libsvtav1: pass color description info

2021-07-30 Thread Christopher Degawa
On Fri, Jul 30, 2021 at 4:48 AM Jan Ekström wrote: > On Fri, Jul 23, 2021 at 5:02 AM Christopher Degawa > wrote: > > +#ifndef SVTAV1_MAKE_VERSION > > +#define SVTAV1_MAKE_VERSION(x,y,z) ((x) << 16 | (y) << 8 | z) > > +#endif > > + > > +#ifndef SVTAV1_CURR_VERSION > > +#define SVTAV1_CURR_VERSION

Re: [FFmpeg-devel] [PATCH 2/2] avformat/movenc: parse h264 packets to build Sync Sample and Recovery Point tables

2021-07-30 Thread James Almer
On 7/30/2021 8:33 AM, Michael Niedermayer wrote: On Thu, Jul 29, 2021 at 03:09:03PM -0300, James Almer wrote: On 7/29/2021 2:58 PM, Michael Niedermayer wrote: On Tue, Jul 27, 2021 at 10:08:20AM -0300, James Almer wrote: Since we can't blindly trust the keyframe flag in packets and assume its c

Re: [FFmpeg-devel] [PATCH] avcodec/argo: Check for end of input in decode_alcd()

2021-07-30 Thread Michael Niedermayer
On Fri, Jul 30, 2021 at 08:44:03AM +0200, Paul B Mahol wrote: > On Fri, Jul 30, 2021 at 12:16 AM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > > > Andreas Rheinhardt: > > > Michael Niedermayer: > > >> Fixes: reading over the end > > >> Fixes: > > 36346/clusterfuzz-testcase-minimi

Re: [FFmpeg-devel] [PATCH v2] avcodec/noise_bsf: add expr support

2021-07-30 Thread Gyan Doshi
On 2021-07-30 09:15, Gyan Doshi wrote: On 2021-07-30 00:00, Andreas Rheinhardt wrote: Gyan Doshi: ---   doc/bitstream_filters.texi |  64 ---   libavcodec/noise_bsf.c | 161 +   tests/fate/matroska.mak    |   2 +-   3 files changed, 199 in

Re: [FFmpeg-devel] [PATCH 2/2] avformat/movenc: parse h264 packets to build Sync Sample and Recovery Point tables

2021-07-30 Thread Michael Niedermayer
On Thu, Jul 29, 2021 at 03:09:03PM -0300, James Almer wrote: > On 7/29/2021 2:58 PM, Michael Niedermayer wrote: > > On Tue, Jul 27, 2021 at 10:08:20AM -0300, James Almer wrote: > > > Since we can't blindly trust the keyframe flag in packets and assume its > > > contents are a valid Sync Sample, do

Re: [FFmpeg-devel] [PATCH 5/5] lavf/avio: remove support for proto, , opt, val, , syntax.

2021-07-30 Thread Nicolas George
Andreas Rheinhardt (12021-07-29): > The latter statement is not true: This is public API; anyone can have > used it for any purpose. Your 2/5 adds a replacement for using it with > dvd2concat, but there are other usages, too; e.g. concatenating several > subfile files (each with its own start and e

Re: [FFmpeg-devel] [PATCH] libsvtav1: pass color description info

2021-07-30 Thread Jan Ekström
On Fri, Jul 23, 2021 at 5:02 AM Christopher Degawa wrote: > > these fields are only available past svt-av1 0.8.7 > > Signed-off-by: Christopher Degawa > --- > libavcodec/libsvtav1.c | 20 > 1 file changed, 20 insertions(+) > > diff --git a/libavcodec/libsvtav1.c b/libavcodec

Re: [FFmpeg-devel] Fwd: Re: [PATCH] mxfdec.c: prefer metadata from Footer

2021-07-30 Thread Tomas Härdin
tor 2021-07-29 klockan 22:17 +0200 skrev Marton Balint: > On Fri, 23 Jul 2021, emco...@ffastrans.com wrote: > > > Am 2021-07-04 20:31, schrieb emco...@ffastrans.com: > > > Am 2021-07-04 20:28, schrieb emco...@ffastrans.com: > > > > Am 2021-07-04 17:28, schrieb Marton Balint: > > > > > On Sat, 3 Ju

Re: [FFmpeg-devel] libavformat/rtsp.c: fix RTSP not setup the UDP stream in SDP

2021-07-30 Thread zhilizhao(赵志立)
> On Jul 30, 2021, at 4:36 PM, Chiu, Yung-Hsiang wrote: > > Thanks for your review. > > I don't have any standards or formal documents mentioned the proto > 'udp' in SDP should be uppercase. > > The only document I google for the video server 'orbit2x' is shown below > https://developer.samsu

Re: [FFmpeg-devel] libavformat/rtsp.c: fix RTSP not setup the UDP stream in SDP

2021-07-30 Thread Chiu, Yung-Hsiang
Thanks for your review. I don't have any standards or formal documents mentioned the proto 'udp' in SDP should be uppercase. The only document I google for the video server 'orbit2x' is shown below https://developer.samsung.com/smarttv/develop/legacy-platform-library/art00071/index.html#sdp-suppo

Re: [FFmpeg-devel] [PATCH v2 1/2] qsvdec: add support for HW_DEVICE_CTX method

2021-07-30 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Haihao Xiang > Sent: Thursday, 29 July 2021 09:04 > To: ffmpeg-devel@ffmpeg.org > Cc: Haihao Xiang > Subject: [FFmpeg-devel] [PATCH v2 1/2] qsvdec: add support for > HW_DEVICE_CTX method > > This allows user set hw_device_ctx in

Re: [FFmpeg-devel] [PATCH] avcodec/argo: Check for end of input in decode_alcd()

2021-07-30 Thread Paul B Mahol
On Fri, Jul 30, 2021 at 12:16 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Andreas Rheinhardt: > > Michael Niedermayer: > >> Fixes: reading over the end > >> Fixes: > 36346/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ARGO_fuzzer-5366943107383296 > >> > >> Found-by: contin