tor 2021-07-29 klockan 22:17 +0200 skrev Marton Balint: > On Fri, 23 Jul 2021, emco...@ffastrans.com wrote: > > > Am 2021-07-04 20:31, schrieb emco...@ffastrans.com: > > > Am 2021-07-04 20:28, schrieb emco...@ffastrans.com: > > > > Am 2021-07-04 17:28, schrieb Marton Balint: > > > > > On Sat, 3 Jul 2021, Tomas Härdin wrote: > > > > > > > > > > > lör 2021-07-03 klockan 15:13 +0200 skrev emco...@ffastrans.com: > > > > > > > Unfortunately the wetransfer link for the fate samples expired, > > > > > > > so > > > > > > > i thought it might be a good idea to resend it as link to gdrive: > > > > > > > > > https://drive.google.com/file/d/1yXTdS9RfOsduzg49vBLEshdmIzdaVQfd/view?usp=sharing > > > > > > > Also attached the 2 patches: 1 from cus for mxfdec.c and one from > > > > > > > myself for the corresponding fate samples. > > > > > > > After applying the mxfdec.c patch, fate will pass with the > > > > > > > currently existing tests but the files in the zip must be > > > > > > > uploaded > > > > > > > to the fate suite before applying my corresponding patch of > > > > > > > course > > > > > > > (otherwise the files don't exist). > > > > > > > > > > > > > > It would be cool if someone found the time and wants to apply > > > > > > > this. > > > > > > > > > > > > The patch works (except for the samples not being in FATE) > > > > > > > > > > Actually I found one file where the packetization behaviour changes, > > > > > because after the patch a fake index is generated based of the now > > > > > recognized duration: > > > > > > > > > > samples/MXF/freemxf/freeMXF-mxf-dv-1.mxf > > > > > > > > > > but I guess the file is wrong because clip wrapped UL is used when > > > > > the > > > > > file seems frame wrapped instead? > > > > > > > > Nice finding! I can confirm this, it is actually clip wrapped looking > > > > at the mxf dump from bmx. These samples are pretty outdated anyway :D > > > > Unfortunately i don't have enough insight on the internals yet on the > > > > topic about adding/freeing/deleting metadata sets :-( > > > > > > FRAME Wrapped it is, not clip wrapped :rolleyes: > > > _______________________________________________ > > > ffmpeg-devel mailing list > > > ffmpeg-devel@ffmpeg.org > > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > > > To unsubscribe, visit link above, or email > > > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > > > > Anything left that needs investigation/correction on this one? ...it > > looks to be a very nice addition so far. > > I was waiting for some comments from Tomas, to see if he has a preference, > but I guess I will apply in a few days if no further comments are > received.
I don't have much more to add. We don't have to support every broken file, and this patch beings us more in line with what's correct, as far as I can tell. /Tomas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
