Re: [FFmpeg-devel] [PATCH 1/9] cbs_av1: fix incorrect data type

2021-07-01 Thread Wang, Fei W
On Thu, 2021-07-01 at 09:41 -0300, James Almer wrote: > On 6/17/2021 3:10 AM, Fei Wang wrote: > > shifted_order_hints is computed by data with int plus data with > > int. > > Switch to int8_t may lose its precision. > > > > Signed-off-by: Fei Wang > > --- > > libavcodec/cbs_av1_syntax_template.

[FFmpeg-devel] Speech Recognition Filter Idea

2021-07-01 Thread Harry Muscle
I'm thinking of developing a speech recognition audio filter for ffmpeg. The idea would be that this filter would search for specific words or phrases and then apply another filter on those words. For example you could increase the volume whenever a certain word is encountered. Or you could mute

Re: [FFmpeg-devel] [PATCH 2/3] {configure, avcodec/libx264}: remove separate x264_csp_bgr check

2021-07-01 Thread Jan Ekström
On Fri, Jul 2, 2021 at 1:09 AM James Almer wrote: > > On 7/1/2021 6:54 PM, Jan Ekström wrote: > > We already require X264_BUILD >= 118, which includes an unconditional > > definition of X264_CSP_BGR in itself, thus making this check > > effectively always true. > > --- > > configure|

Re: [FFmpeg-devel] [PATCH 2/3] {configure, avcodec/libx264}: remove separate x264_csp_bgr check

2021-07-01 Thread James Almer
On 7/1/2021 6:54 PM, Jan Ekström wrote: We already require X264_BUILD >= 118, which includes an unconditional definition of X264_CSP_BGR in itself, thus making this check effectively always true. --- configure| 3 --- libavcodec/libx264.c | 7 +-- 2 files changed, 1 insertion(

Re: [FFmpeg-devel] [PATCH 0/3] libx264 configure check clean-up, removal of libx264rgb

2021-07-01 Thread Jan Ekström
On Fri, Jul 2, 2021 at 12:54 AM Jan Ekström wrote: > > Done in three separate change sets, as this way if the last change > is deemed too controversial, the earlier changes should be applicable > by themselves. > > - The first change fixes libx264rgb enablement without having x264.h > in the sys

[FFmpeg-devel] [PATCH 1/3] configure: move x264_csp_bgr check under general libx264 checks

2021-07-01 Thread Jan Ekström
This makes the libx264rgb check work when pkg-config is utilized and x264.h is not part of the standard include path (as is often with cross-compilation, or when you just have a custom prefix in general in f.ex. your home directory). The X264_BUILD >= 118 required by configure since 2011 should ha

[FFmpeg-devel] [PATCH 3/3] avcodec/libx264: remove separate libx264rgb RGB wrapper

2021-07-01 Thread Jan Ekström
No other encoder wrapper in libavcodec is split like this, and with RGB input this currently does not lead to 4:2:0 (which would be generally supported in most hardware and software implementations), but rather 4:4:4. The libx262 encoder definition was not touched, as it already has 4:4:4 YCbCr de

[FFmpeg-devel] [PATCH 2/3] {configure, avcodec/libx264}: remove separate x264_csp_bgr check

2021-07-01 Thread Jan Ekström
We already require X264_BUILD >= 118, which includes an unconditional definition of X264_CSP_BGR in itself, thus making this check effectively always true. --- configure| 3 --- libavcodec/libx264.c | 7 +-- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/configure b/

[FFmpeg-devel] [PATCH 0/3] libx264 configure check clean-up, removal of libx264rgb

2021-07-01 Thread Jan Ekström
Done in three separate change sets, as this way if the last change is deemed too controversial, the earlier changes should be applicable by themselves. - The first change fixes libx264rgb enablement without having x264.h in the system default include path, such as with custom prefixes. - The se

Re: [FFmpeg-devel] [PATCH] libswscale: Make sws_init_context thread safe.

2021-07-01 Thread Michael Niedermayer
On Wed, Apr 28, 2021 at 11:51:23AM +0200, Peter Lundblad wrote: > Call ff_sws_rgb2rgb_init via ff_thread_once instead of checking one of the > variables it updates. > --- > libswscale/utils.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/libswscale/utils.c b/libsw

Re: [FFmpeg-devel] [PATCH 1/3] avformat/flv: add support for h265 streams

2021-07-01 Thread libav
On 2021-07-01 12:58, Derek Buitenhuis wrote: On 7/1/2021 5:25 PM, Thomas Volkert wrote: I was also about to prepare a discussion mail against this patch set. We shouldn't fuzzy the spec. So.. +1 for skipping this patch set. Hard NAK from me as well. We've rejected essentially this same thing

Re: [FFmpeg-devel] [PATCH] configure: Fix some unsafe shell practices

2021-07-01 Thread libav
On 2021-07-01 14:20, Leo Izen wrote: This commit fixes some unsafe shell pratcies in ./configure, particularly those that involve variable expansions on possibly unsanitized data in unsafe ways. This commit corrects this behavior in a small number of locations. --- configure | 16 ---

Re: [FFmpeg-devel] [PATCH 1/3] avformat/flv: add support for h265 streams

2021-07-01 Thread Martin Storsjö
On Thu, 1 Jul 2021, Jan Ekström wrote: On Thu, Jul 1, 2021 at 5:16 PM James Almer wrote: From: Matthieu Patou Suggested-by: ffm...@fb.com Signed-off-by: James Almer --- For the record, if Big Companies such as FB or Bilibili want to keep on dragging FLV/RTMP around I recommend: 1. Creat

[FFmpeg-devel] [PATCH] configure: Fix some unsafe shell practices

2021-07-01 Thread Leo Izen
This commit fixes some unsafe shell pratcies in ./configure, particularly those that involve variable expansions on possibly unsanitized data in unsafe ways. This commit corrects this behavior in a small number of locations. --- configure | 16 1 file changed, 8 insertions(+), 8 d

Re: [FFmpeg-devel] [PATCH 1/3] avformat/flv: add support for h265 streams

2021-07-01 Thread Jan Ekström
On Thu, Jul 1, 2021 at 5:16 PM James Almer wrote: > > From: Matthieu Patou > > Suggested-by: ffm...@fb.com > Signed-off-by: James Almer > --- For the record, if Big Companies such as FB or Bilibili want to keep on dragging FLV/RTMP around I recommend: 1. Create something like https://datatrack

Re: [FFmpeg-devel] [PATCH 1/3] avformat/flv: add support for h265 streams

2021-07-01 Thread Derek Buitenhuis
On 7/1/2021 5:25 PM, Thomas Volkert wrote: > I was also about to prepare a discussion mail against this patch set. We > shouldn't fuzzy the spec. > > So.. +1 for skipping this patch set. Hard NAK from me as well. We've rejected essentially this same thing several times, and the reasonign has not

Re: [FFmpeg-devel] [PATCH 1/3] avformat/flv: add support for h265 streams

2021-07-01 Thread RADSL
On 7/1/2021 9:23 AM, Jean-Baptiste Kempf wrote: On Thu, 1 Jul 2021, at 18:15, James Almer wrote: Is there an official source for these numbers? Apparently no. Neither does REALH263 or MPEG4 as far as i can see. But if there are files out there that can be demuxed with this change, as long as

Re: [FFmpeg-devel] [PATCH 1/3] avformat/flv: add support for h265 streams

2021-07-01 Thread James Almer
On 7/1/2021 1:25 PM, Thomas Volkert wrote: On 01.07.2021 18:15, James Almer wrote: On 7/1/2021 11:41 AM, James Almer wrote: On 7/1/2021 11:27 AM, Andreas Rheinhardt wrote: James Almer: From: Matthieu Patou Suggested-by: ffm...@fb.com Signed-off-by: James Almer ---   libavformat/flv.h   

Re: [FFmpeg-devel] [PATCH 1/3] avformat/flv: add support for h265 streams

2021-07-01 Thread Thomas Volkert
On 01.07.2021 18:15, James Almer wrote: > On 7/1/2021 11:41 AM, James Almer wrote: >> On 7/1/2021 11:27 AM, Andreas Rheinhardt wrote: >>> James Almer: From: Matthieu Patou Suggested-by: ffm...@fb.com Signed-off-by: James Almer ---   libavformat/flv.h    |  1 +

Re: [FFmpeg-devel] [PATCH 1/3] avformat/flv: add support for h265 streams

2021-07-01 Thread Jean-Baptiste Kempf
On Thu, 1 Jul 2021, at 18:15, James Almer wrote: > >> Is there an official source for these numbers? > > > > Apparently no. Neither does REALH263 or MPEG4 as far as i can see. But > > if there are files out there that can be demuxed with this change, as > > long as we don't support creating them

Re: [FFmpeg-devel] [PATCH 1/3] avformat/flv: add support for h265 streams

2021-07-01 Thread James Almer
On 7/1/2021 1:21 PM, RADSL wrote: On 7/1/2021 9:15 AM, James Almer wrote: On 7/1/2021 11:41 AM, James Almer wrote: On 7/1/2021 11:27 AM, Andreas Rheinhardt wrote: James Almer: From: Matthieu Patou Suggested-by: ffm...@fb.com Signed-off-by: James Almer ---   libavformat/flv.h    |  1 +   l

Re: [FFmpeg-devel] [PATCH 1/3] avformat/flv: add support for h265 streams

2021-07-01 Thread RADSL
On 7/1/2021 9:15 AM, James Almer wrote: On 7/1/2021 11:41 AM, James Almer wrote: On 7/1/2021 11:27 AM, Andreas Rheinhardt wrote: James Almer: From: Matthieu Patou Suggested-by: ffm...@fb.com Signed-off-by: James Almer ---   libavformat/flv.h    |  1 +   libavformat/flvdec.c | 14 ++

Re: [FFmpeg-devel] [PATCH 1/3] avformat/flv: add support for h265 streams

2021-07-01 Thread James Almer
On 7/1/2021 11:41 AM, James Almer wrote: On 7/1/2021 11:27 AM, Andreas Rheinhardt wrote: James Almer: From: Matthieu Patou Suggested-by: ffm...@fb.com Signed-off-by: James Almer ---   libavformat/flv.h    |  1 +   libavformat/flvdec.c | 14 --   2 files changed, 13 insertions(+),

Re: [FFmpeg-devel] [PATCH 1/3] avformat/flv: add support for h265 streams

2021-07-01 Thread James Almer
On 7/1/2021 11:27 AM, Andreas Rheinhardt wrote: James Almer: From: Matthieu Patou Suggested-by: ffm...@fb.com Signed-off-by: James Almer --- libavformat/flv.h| 1 + libavformat/flvdec.c | 14 -- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/libavformat/f

Re: [FFmpeg-devel] request to remove certain mention of e-book on trac wiki page

2021-07-01 Thread Gyan Doshi
On 2021-07-01 17:04, Andreas Rheinhardt wrote: Paul B Mahol: I here hereby request that certain e-book is removed from wiki page of FFmpeg. Reason is it uses derogatory text to criticize some FFmpeg components. Details please: What ebook? What derogatory text? We shouldn't entertain this.

Re: [FFmpeg-devel] [PATCH v3] avformat: add a concat protocol that takes a line break delimited list of resources

2021-07-01 Thread Nicolas George
James Almer (12021-06-29): > Suggested-by: ffm...@fb.com > Signed-off-by: James Almer > --- > Now using the standard quoting and escaping syntax. > > doc/protocols.texi | 32 > libavformat/Makefile| 1 + > libavformat/concat.c| 109 +++

Re: [FFmpeg-devel] [PATCH 1/3] avformat/flv: add support for h265 streams

2021-07-01 Thread Andreas Rheinhardt
James Almer: > From: Matthieu Patou > > Suggested-by: ffm...@fb.com > Signed-off-by: James Almer > --- > libavformat/flv.h| 1 + > libavformat/flvdec.c | 14 -- > 2 files changed, 13 insertions(+), 2 deletions(-) > > diff --git a/libavformat/flv.h b/libavformat/flv.h > index 3

[FFmpeg-devel] [PATCH 3/3] avformat/flv: add support for opus streams

2021-07-01 Thread James Almer
From: Matthieu Patou Suggested-by: ffm...@fb.com Signed-off-by: James Almer --- libavformat/flv.h| 6 -- libavformat/flvdec.c | 11 +-- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/libavformat/flv.h b/libavformat/flv.h index 29bb36f7f6..6f3cad04e1 100644 ---

Re: [FFmpeg-devel] request to remove certain mention of e-book on trac wiki page

2021-07-01 Thread James Almer
On 6/26/2021 9:53 AM, Paul B Mahol wrote: I here hereby request that certain e-book is removed from wiki page of FFmpeg. Reason is it uses derogatory text to criticize some FFmpeg components. The wiki is open for editing, so if you think that ebook should not be there, then remove it and stat

[FFmpeg-devel] [PATCH 2/3] avformat/flv: add support for vp8 and vp9 streams

2021-07-01 Thread James Almer
From: Matthieu Patou Suggested-by: ffm...@fb.com Signed-off-by: James Almer --- libavformat/flv.h| 2 ++ libavformat/flvdec.c | 17 +++-- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/libavformat/flv.h b/libavformat/flv.h index 7a026d3217..29bb36f7f6 100644 --

[FFmpeg-devel] [PATCH 1/3] avformat/flv: add support for h265 streams

2021-07-01 Thread James Almer
From: Matthieu Patou Suggested-by: ffm...@fb.com Signed-off-by: James Almer --- libavformat/flv.h| 1 + libavformat/flvdec.c | 14 -- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/libavformat/flv.h b/libavformat/flv.h index 3571b90279..7a026d3217 100644 --- a/

Re: [FFmpeg-devel] [PATCH 3/9] avcodec/av1dec: support setup shear process

2021-07-01 Thread James Almer
On 6/17/2021 3:10 AM, Fei Wang wrote: Defined in spec 7.11.3.6/7.11.3.7. Signed-off-by: Fei Wang --- libavcodec/av1dec.c | 97 + libavcodec/av1dec.h | 1 + 2 files changed, 98 insertions(+) diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c

Re: [FFmpeg-devel] [PATCH 1/9] cbs_av1: fix incorrect data type

2021-07-01 Thread James Almer
On 6/17/2021 3:10 AM, Fei Wang wrote: shifted_order_hints is computed by data with int plus data with int. Switch to int8_t may lose its precision. Signed-off-by: Fei Wang --- libavcodec/cbs_av1_syntax_template.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/

Re: [FFmpeg-devel] request to remove certain mention of e-book on trac wiki page

2021-07-01 Thread Andreas Rheinhardt
Paul B Mahol: > I here hereby request that certain e-book is removed from wiki page of > FFmpeg. > > Reason is it uses derogatory text to criticize some FFmpeg components. Details please: What ebook? What derogatory text? - Andreas ___ ffmpeg-devel mai

Re: [FFmpeg-devel] [PATCH 1/9] cbs_av1: fix incorrect data type

2021-07-01 Thread Wang, Fei W
On Mon, 2021-06-21 at 09:38 +0800, Fei.Wang wrote: > On Thu, 2021-06-17 at 14:10 +0800, Fei Wang wrote: > > shifted_order_hints is computed by data with int plus data with > > int. > > Switch to int8_t may lose its precision. > > > > Signed-off-by: Fei Wang > > --- > > libavcodec/cbs_av1_syntax_