Re: [FFmpeg-devel] [PATCH 1/2] tls_openssl: Improve quality of printed error messages, pass IO error codes through

2021-03-30 Thread Martin Storsjö
On Fri, 26 Mar 2021, Martin Storsjö wrote: Print every error in the stack, if more than one, and don't print bogus errors if there's none logged within OpenSSL. Retain the underlying IO error code, print an error message out of it, and pass the error code on to the caller. --- libavformat/tls_o

Re: [FFmpeg-devel] [PATCH v3] lavfi/qsvvpp: support async depth

2021-03-30 Thread Wang, Fei W
On Wed, 2021-03-31 at 10:07 +0800, Fei Wang wrote: > Async depth will allow qsv filter cache few frames, and avoid force > switch and end filter task frame by frame. This change will improve > performance for some multi-task case, for example 1:N transcode( > decode + vpp + encode) with all QSV plu

[FFmpeg-devel] [PATCH v3] lavfi/qsvvpp: support async depth

2021-03-30 Thread Fei Wang
Async depth will allow qsv filter cache few frames, and avoid force switch and end filter task frame by frame. This change will improve performance for some multi-task case, for example 1:N transcode( decode + vpp + encode) with all QSV plugins. Performance data test on my Coffee Lake Desktop(i7-8

Re: [FFmpeg-devel] [PATCH 1/2] avutil/common: Add FF_PTR_ADD()

2021-03-30 Thread Michael Niedermayer
On Mon, Mar 29, 2021 at 12:19:57PM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2021-03-15 09:47:43) > > Suggested-by: Andreas Rheinhardt > > Signed-off-by: Michael Niedermayer > > --- > > libavutil/common.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/libavutil

Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffprobe: Add missing dispositions

2021-03-30 Thread Andreas Rheinhardt
Marton Balint: > > > On Tue, 30 Mar 2021, Andreas Rheinhardt wrote: > >> Andreas Rheinhardt: >>> Signed-off-by: Andreas Rheinhardt >>> --- > >>> diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c >>> index 11e3cbd6c2..38462e1ff3 100644 >>> --- a/fftools/ffprobe.c >>> +++ b/fftools/ffprobe.c >>

[FFmpeg-devel] [PATCH] avcodec/mjpegenc: Remove dependency of AMV encoder on mjpegenc_huffman

2021-03-30 Thread Andreas Rheinhardt
Using optimal Huffman tables is not supported for AMV and always disabled by ff_mpv_encode_init(); therefore one the AMV encoder without compiling mjpegenc_huffman if one adds the necessary compile-time checks. Signed-off-by: Andreas Rheinhardt --- libavcodec/Makefile | 3 +-- libavcodec/mjpeg

[FFmpeg-devel] [PATCH v2] libsvtav1: Add logical_processors option

2021-03-30 Thread Christopher Degawa
From: Christopher Degawa Used as a thread count multiplier with a max of the logical cores available Signed-off-by: Christopher Degawa --- doc/encoders.texi | 3 +++ libavcodec/libsvtav1.c | 7 +++ 2 files changed, 10 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi i

[FFmpeg-devel] [PATCH] avcodec/mjpegenc: Fix segfault when freeing incomplete context

2021-03-30 Thread Andreas Rheinhardt
When allocating the MJpegContext fails (or if the dimensions run afoul of the 65500x65500 limit), an attempt to free a subbuffer of said context leads to a segfault in ff_mjpeg_encode_close(). Seems to be a regression since 467d9e27e0cb2bf74f41dc832f2f8d191ba58ec9. Signed-off-by: Andreas Rheinhard

Re: [FFmpeg-devel] [PATCH v2] libsvtav1: Add logical_processors option

2021-03-30 Thread Christopher Degawa
On Tue, Mar 30, 2021 at 4:53 PM Jan Ekström wrote: > > @@ -218,6 +220,8 @@ static int > config_enc_params(EbSvtAv1EncConfiguration *param, > > param->tile_columns = svt_enc->tile_columns; > > param->tile_rows= svt_enc->tile_rows; > > > > +param->logical_processors = svt_enc->log

Re: [FFmpeg-devel] [PATCH v2] libsvtav1: Add logical_processors option

2021-03-30 Thread Jan Ekström
On Sat, Feb 20, 2021 at 3:20 AM Christopher Degawa wrote: > > From: Christopher Degawa > > Used for limiting the size of memory buffers and threads for a target > logical processor count, but does not set thread affinity or limit the > amount of threads used, although thread affinities can be con

Re: [FFmpeg-devel] [PATCH] mov: Skip computing SAR from invalid display matrix elements

2021-03-30 Thread Carl Eugen Hoyos
Am Di., 30. März 2021 um 19:24 Uhr schrieb Vittorio Giovara : > > Hello, > I was debugging an issue with a video file containing an invalid > display matrix, probably produced by a non conforming software. > > The content of the matrix is: > :0 65536 0 > 0001

Re: [FFmpeg-devel] [PATCH] avformat/rtpdec: Fix prft wallclock time.

2021-03-30 Thread Carl Eugen Hoyos
Am Di., 30. März 2021 um 17:02 Uhr schrieb James Almer : > > On 3/25/2021 1:46 AM, Alok Priyadarshi wrote: > > Timestamp difference is available in media timebase (1/90K) where as > > rtcp time is in the default microseconds timebase. This patch fixes > > the calculated prft wallclock time by resca

Re: [FFmpeg-devel] [PATCH 5/6] pngdec: fix and simplify apng reference handling

2021-03-30 Thread Michael Niedermayer
On Tue, Mar 30, 2021 at 02:30:08PM -0300, James Almer wrote: > On 3/30/2021 5:56 AM, Michael Niedermayer wrote: > > On Tue, Feb 16, 2021 at 09:24:15PM +0100, Anton Khirnov wrote: > > > Current code is very confused and confusing. It uses two different > > > reference frames - "previous" and "last"

Re: [FFmpeg-devel] [PATCH] avcodec/dv_profile: PAL DV files with dsf flag 0 - detect via pal flag and buf_size

2021-03-30 Thread Marton Balint
On Tue, 30 Mar 2021, Mark Plomer wrote: ping ;-) Applied, thanks. Marton Am 18.03.21 um 21:55 schrieb Marton Balint: It looks good to me, I will apply in a couple of days if nobody comments until then. Also Cc'd Dave, as he got probably the most experience with dv. Regards, Marton _

Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffprobe: Add missing dispositions

2021-03-30 Thread Marton Balint
On Tue, 30 Mar 2021, Andreas Rheinhardt wrote: Andreas Rheinhardt: Signed-off-by: Andreas Rheinhardt --- diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index 11e3cbd6c2..38462e1ff3 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@ -2770,6 +2770,11 @@ static int show_stream(Wri

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/cfhd: More strictly check tag order and multiplicity

2021-03-30 Thread Paul B Mahol
Please share files privately, do not apply non fix for this issue. Give up with such this non-solution. On Tue, Mar 30, 2021 at 6:49 PM Michael Niedermayer wrote: > On Sun, Dec 20, 2020 at 10:15:24PM +0100, Michael Niedermayer wrote: > > This is based on the encoder and a small number of CFHD s

Re: [FFmpeg-devel] [PATCH 5/6] pngdec: fix and simplify apng reference handling

2021-03-30 Thread James Almer
On 3/30/2021 5:56 AM, Michael Niedermayer wrote: On Tue, Feb 16, 2021 at 09:24:15PM +0100, Anton Khirnov wrote: Current code is very confused and confusing. It uses two different reference frames - "previous" and "last" - when only one is really necessary. It also confuses the two, leading to in

[FFmpeg-devel] [PATCH] mov: Skip computing SAR from invalid display matrix elements

2021-03-30 Thread Vittorio Giovara
Hello, I was debugging an issue with a video file containing an invalid display matrix, probably produced by a non conforming software. The content of the matrix is: :0 65536 0 0001: -1 0 0 0002:0 0 10

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/cfhd: More strictly check tag order and multiplicity

2021-03-30 Thread Michael Niedermayer
On Sun, Dec 20, 2020 at 10:15:24PM +0100, Michael Niedermayer wrote: > This is based on the encoder and a small number of CFHD sample files > It should make the decoder more robust against crafted input. > Due to the lack of a proper specification it is possible that this > may be too strict and ma

Re: [FFmpeg-devel] Question about FFmpeg's threading architecture

2021-03-30 Thread Alireza Heidar-Barghi
On Thursday, March 25, 2021, 09:43:05 AM EDT, Alireza Heidar-Barghi wrote: Hi everyone, Kieran, thank you for your reply.  I already had a look at that document. I need something more detailed about FFmpeg's threading architecture such as:  1. What threading model is used in FFmpeg (

Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffprobe: Add missing dispositions

2021-03-30 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > fftools/ffprobe.c | 5 + > .../ref/fate/concat-demuxer-extended-lavf-mxf | 2 +- > .../fate/concat-demuxer-extended-lavf-mxf_d10 | 2 +- > .../ref/fate/concat-demuxer-simple1-lavf-mxf | 4 ++-- >

Re: [FFmpeg-devel] [PATCH] lavc/tiff: Fix build failure due to always_inline

2021-03-30 Thread Pavel Koshevoy
On Tue, Mar 30, 2021 at 2:26 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Pavel Koshevoy: > > Fixes: > > src/libavcodec/tiff.c: In function ‘tiff_unpack_strip’: > > src/libavcodec/tiff.c:280: error: ‘always_inline’ function could not be > inlined in call to ‘dng_blit’: the func

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/tiff: Avoid forward declarations

2021-03-30 Thread Pavel Koshevoy
On Tue, Mar 30, 2021 at 2:11 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > In this case it also fixes a potential for compilation failures: > Not all compilers can handle the case in which a function with > a forward declaration declared with an attribute to always inline it > i

Re: [FFmpeg-devel] [PATCH] avformat/rtpdec: Fix prft wallclock time.

2021-03-30 Thread James Almer
On 3/25/2021 1:46 AM, Alok Priyadarshi wrote: Timestamp difference is available in media timebase (1/90K) where as rtcp time is in the default microseconds timebase. This patch fixes the calculated prft wallclock time by rescaling the timestamp delta to the microseconds timebase. --- libavforma

Re: [FFmpeg-devel] [PATCH] avformat/rtpdec: Fix prft wallclock time.

2021-03-30 Thread Alok Priyadarshi
Ping. Could someone please review this patch. Thanks. On Thu, Mar 25, 2021, 6:40 AM Alok Priyadarshi wrote: > In effect the patch does replace that one line. But it also adds the steps > to illustrate how the wallclock is calculated. Adding all the calculations > in a single line will make it to

Re: [FFmpeg-devel] [PATCH] avformat: add apic to AVStream

2021-03-30 Thread James Almer
On 3/29/2021 10:46 AM, James Almer wrote: On 3/29/2021 10:20 AM, Nicolas George wrote: James Almer (12021-03-29): Can this be done? id3v2 attached pics for many formats are handled by the generic demux code in avformat_open_input() and not by the actual demuxer. And in demuxers like asf, it s

Re: [FFmpeg-devel] [PATCH 1/4] avformat: Add and use helper function to add attachment streams

2021-03-30 Thread James Almer
On 3/30/2021 10:45 AM, Andreas Rheinhardt wrote: James Almer: On 3/29/2021 5:42 AM, Andreas Rheinhardt wrote: All instances of adding attached pictures to a stream or adding a stream and an attached packet to said stream have several things in common like setting the index and flags of the pack

Re: [FFmpeg-devel] [PATCH 1/4] avformat: Add and use helper function to add attachment streams

2021-03-30 Thread Andreas Rheinhardt
James Almer: > On 3/29/2021 5:42 AM, Andreas Rheinhardt wrote: >> All instances of adding attached pictures to a stream or adding >> a stream and an attached packet to said stream have several things >> in common like setting the index and flags of the packet, setting >> the stream disposition etc.

Re: [FFmpeg-devel] [PATCH 4/4] avformat/asf: Use ff_add_attached_pic() to read attached pics

2021-03-30 Thread Andreas Rheinhardt
James Almer: > On 3/29/2021 5:45 AM, Andreas Rheinhardt wrote: >> Also removes a stack packet. >> >> Signed-off-by: Andreas Rheinhardt >> --- >>   libavformat/asf.c | 17 +++-- >>   1 file changed, 3 insertions(+), 14 deletions(-) >> >> diff --git a/libavformat/asf.c b/libavformat/asf.c

Re: [FFmpeg-devel] [PATCH 4/4] avformat/asf: Use ff_add_attached_pic() to read attached pics

2021-03-30 Thread James Almer
On 3/29/2021 5:45 AM, Andreas Rheinhardt wrote: Also removes a stack packet. Signed-off-by: Andreas Rheinhardt --- libavformat/asf.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/libavformat/asf.c b/libavformat/asf.c index 204355abab..cef0f9f646 10064

Re: [FFmpeg-devel] [PATCH 1/4] avformat: Add and use helper function to add attachment streams

2021-03-30 Thread James Almer
On 3/29/2021 5:42 AM, Andreas Rheinhardt wrote: All instances of adding attached pictures to a stream or adding a stream and an attached packet to said stream have several things in common like setting the index and flags of the packet, setting the stream disposition etc. This commit therefore fa

[FFmpeg-devel] [PATCH v3 5/5] mips: Fix potential illegal instruction error.

2021-03-30 Thread Shiyou Yin
MSA2 optimizations are attached to MSA macros in generic_macros_msa.h. It's difficult to do runtime check for them. Remove this part of code can make it more robust. H264 1080p decoding: 5.13x==>5.12x. --- configure | 7 +-- libavutil/mips/generic_macros_msa.h | 37 -

[FFmpeg-devel] [PATCH v3 4/5] avcodec/mips: Refine ff_h264_h_lpf_luma_inter_msa

2021-03-30 Thread Shiyou Yin
From: gxw Using mask to avoid judgment, H264 4K decoding speed improved about 0.1fps tested on 3A4000 Signed-off-by: Shiyou Yin --- libavcodec/mips/h264dsp_msa.c | 465 -- 1 file changed, 171 insertions(+), 294 deletions(-) diff --git a/libavcodec/mips/

[FFmpeg-devel] [PATCH v3 3/5] avcodec/mips: Optimize function ff_h264_loop_filter_strength_msa.

2021-03-30 Thread Shiyou Yin
From: gxw Speed of decoding H264 1080P: 5.05x ==> 5.13x Signed-off-by: Shiyou Yin --- libavcodec/mips/Makefile| 3 +- libavcodec/mips/h264_deblock_msa.c | 153 libavcodec/mips/h264dsp_init_mips.c | 2 + libavcodec/mips/h264dsp_mips.h |

[FFmpeg-devel] [PATCH v3 2/5] avcodec/mips: Refine get_cabac_inline_mips.

2021-03-30 Thread Shiyou Yin
1. Refined function get_cabac_inline_mips. 2. Optimize function get_cabac_bypass and get_cabac_bypass_sign. Speed of decoding h264: 4.89x ==> 5.05x(tested on 3A4000). --- libavcodec/mips/cabac.h | 131 +--- 1 file changed, 102 insertions(+), 29 deletion

[FFmpeg-devel] [mips] Optimize H264 decoding for MIPS platform.

2021-03-30 Thread Shiyou Yin
v2: Fixed a build error in [PATCH 2/5]. v3: add patch 4/5. [PATCH v3 1/5] avcodec/mips: Restore the initialization sequence of [PATCH v3 2/5] avcodec/mips: Refine get_cabac_inline_mips. [PATCH v3 3/5] avcodec/mips: Optimize function ff_h264_loop_filter_strength_msa. [PATCH v3 4/5] avcodec/mips: Re

[FFmpeg-devel] [PATCH v3 1/5] avcodec/mips: Restore the initialization sequence of MSA and MMI in ff_h264chroma_init_mips.

2021-03-30 Thread Shiyou Yin
The MSA optimization has been refined in commit 93218c2 and ce0a52e. It is better than MMI version now. Speed of decoding H264: 4.83x ==> 4.89x (tested on 3A4000). --- libavcodec/mips/h264chroma_init_mips.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/li

Re: [FFmpeg-devel] [PATCH v2] examples/decode_video: flush parser to fix missing frame

2021-03-30 Thread zhilizhao(赵志立)
Ping. I have got multiple users report about the issue when they use the example as a tutorial. > On Oct 12, 2020, at 12:47 AM, Zhao Zhili wrote: > > Ping for review. > >> On Sep 24, 2020, at 2:01 AM, Zhao Zhili wrote: >> >> To reproduce, run decode_video with a single frame sample. No fram

[FFmpeg-devel] [PATCH 4/5] avcodec/lscrdec: Check length in decode_idat()

2021-03-30 Thread Michael Niedermayer
Fixes: out of array access Fixes: 32264/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LSCR_fuzzer-6684504010915840 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/lscrdec.c | 4 1 fil

[FFmpeg-devel] [PATCH 5/5] avcodec/pnm_parser: Check image size addition for overflow

2021-03-30 Thread Michael Niedermayer
Fixes: assertion failure Fixes: out of array access Fixes: 32664/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PGMYUV_fuzzer-6533642202513408.fuzz Fixes: 32669/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PGMYUV_fuzzer-6001928875147264 Found-by: continuous fuzzing process https://githu

[FFmpeg-devel] [PATCH 2/5] avformat/imx: Check palette chunk size

2021-03-30 Thread Michael Niedermayer
Fixes: out of array write Fixes: 32116/clusterfuzz-testcase-minimized-ffmpeg_dem_SIMBIOSIS_IMX_fuzzer-6702533894602752 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/imx.c | 2 ++ 1 file cha

[FFmpeg-devel] [PATCH 3/5] tools/target_dem_fuzzer: Fix packet leak

2021-03-30 Thread Michael Niedermayer
Fixes: 32121/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-4512973109460992 Signed-off-by: Michael Niedermayer --- tools/target_dem_fuzzer.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tools/target_dem_fuzzer.c b/tools/target_dem_fuzzer.c index af1840b35

[FFmpeg-devel] [PATCH 1/5] avcodec/h265_metadata_bsf: Check nb_units before accessing the first in h265_metadata_update_fragment()

2021-03-30 Thread Michael Niedermayer
Fixes: null pointer dereference Fixes: 32113/clusterfuzz-testcase-minimized-ffmpeg_BSF_HEVC_METADATA_fuzzer-4803262287052800 Same as 0c48c332eeb2866d9353125f701e099c48889463 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michae

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/ttmlenc: add initial support for regions and styles

2021-03-30 Thread Andreas Rheinhardt
Jan Ekström: > From: Jan Ekström > > Attempts to utilize the TTML cell resolution as a mapping to the > reference resolution, and maps font size to cell size. Additionally > sets the display and text alignment according to the ASS alignment > number. > > Signed-off-by: Jan Ekström > --- > liba

[FFmpeg-devel] [PATCH 1/2] avcodec/exr: Check oe in huf_decode() before use

2021-03-30 Thread Michael Niedermayer
Fixes: out of array access Fixes: 31386/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EXR_fuzzer-5773234709594112 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/exr.c | 7 ++- 1 file

[FFmpeg-devel] [PATCH 2/2] avformat/rmdec: use larger intermediate type for audio_framesize * sub_packet_h check

2021-03-30 Thread Michael Niedermayer
Fixes: signed integer overflow: 65535 * 65535 cannot be represented in type 'int' Fixes: 31406/clusterfuzz-testcase-minimized-ffmpeg_dem_IVR_fuzzer-5024692843970560 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niederm

Re: [FFmpeg-devel] [PATCH 5/6] pngdec: fix and simplify apng reference handling

2021-03-30 Thread Michael Niedermayer
On Tue, Mar 30, 2021 at 10:56:13AM +0200, Michael Niedermayer wrote: > On Tue, Feb 16, 2021 at 09:24:15PM +0100, Anton Khirnov wrote: > > Current code is very confused and confusing. It uses two different > > reference frames - "previous" and "last" - when only one is really > > necessary. It also

Re: [FFmpeg-devel] [PATCH 2/4] avformat/ttmlenc: enable writing out additional header values

2021-03-30 Thread Andreas Rheinhardt
Jan Ekström: > From: Jan Ekström > > This way the encoder may pass on the following values to the muxer: > 1) Additional root "tt" element attributes, such as the subtitle >canvas reference size. > 2) Anything before the body element of the document, such as regions >in the head element,

Re: [FFmpeg-devel] [PATCH 5/6] pngdec: fix and simplify apng reference handling

2021-03-30 Thread Michael Niedermayer
On Tue, Feb 16, 2021 at 09:24:15PM +0100, Anton Khirnov wrote: > Current code is very confused and confusing. It uses two different > reference frames - "previous" and "last" - when only one is really > necessary. It also confuses the two, leading to incorrect output with > APNG_DISPOSE_OP_PREVIOUS

[FFmpeg-devel] [PATCH 2/4] avformat/ttmlenc: enable writing out additional header values

2021-03-30 Thread Jan Ekström
From: Jan Ekström This way the encoder may pass on the following values to the muxer: 1) Additional root "tt" element attributes, such as the subtitle canvas reference size. 2) Anything before the body element of the document, such as regions in the head element, which can configure styles.

[FFmpeg-devel] [PATCH 0/4] Initial region (styling) support for TTML

2021-03-30 Thread Jan Ekström
Now sets alignment, font size, font family and the region's position and size according to the ASS styles passed to the encoder. Regions are relatively important in TTML, since the spec-defined default region is in raster location (similar to the default with HTML) - it starts from the top left cor

[FFmpeg-devel] [PATCH 4/4] avcodec/ttmlenc: add support for region positioning and sizing

2021-03-30 Thread Jan Ekström
From: Jan Ekström The ASS margins are utilized to generate percentual values, as the usage of cell-based sizing and offsetting seems to be not too well supported by renderers. Signed-off-by: Jan Ekström --- libavcodec/ttmlenc.c | 41 -- tests/ref/fate/

[FFmpeg-devel] [PATCH 1/4] avcodec/ttmlenc: split header writing into its own function

2021-03-30 Thread Jan Ekström
From: Jan Ekström Signed-off-by: Jan Ekström --- libavcodec/ttmlenc.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/libavcodec/ttmlenc.c b/libavcodec/ttmlenc.c index 3972b4368c..e3c155fdd1 100644 --- a/libavcodec/ttmlenc.c +++ b/libavcodec/ttml

[FFmpeg-devel] [PATCH 3/4] avcodec/ttmlenc: add initial support for regions and styles

2021-03-30 Thread Jan Ekström
From: Jan Ekström Attempts to utilize the TTML cell resolution as a mapping to the reference resolution, and maps font size to cell size. Additionally sets the display and text alignment according to the ASS alignment number. Signed-off-by: Jan Ekström --- libavcodec/ttmlenc.c | 257

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/ttmlenc: add support for region positioning and sizing

2021-03-30 Thread Jan Ekström
On Tue, Mar 30, 2021 at 11:23 AM Jan Ekström wrote: > > +if (style->margin_l < 0 || style->margin_r < 0 || style->margin_v < 0) { > +av_log(avctx, AV_LOG_ERROR, > + "One or more negative margin values in subtitle style: " > + "left: %d, right: %d, vertical:

Re: [FFmpeg-devel] [PATCH] lavc/tiff: Fix build failure due to always_inline

2021-03-30 Thread Andreas Rheinhardt
Pavel Koshevoy: > Fixes: > src/libavcodec/tiff.c: In function ‘tiff_unpack_strip’: > src/libavcodec/tiff.c:280: error: ‘always_inline’ function could not be > inlined in call to ‘dng_blit’: the function body must appear before caller > src/libavcodec/tiff.c:720: error: called from here > --- > li

[FFmpeg-devel] [PATCH 1/2] avcodec/tiff: Avoid forward declarations

2021-03-30 Thread Andreas Rheinhardt
In this case it also fixes a potential for compilation failures: Not all compilers can handle the case in which a function with a forward declaration declared with an attribute to always inline it is called before the function body appears. Signed-off-by: Andreas Rheinhardt --- This is of course

[FFmpeg-devel] [PATCH 2/2] avcodec/tiff: Don't use separate temporary buffer for fax

2021-03-30 Thread Andreas Rheinhardt
Also don't unnecessarily copy the input data around if it needn't be reversed; and remove a redundant memset -- av_fast_padded_malloc() already does this for us. Signed-off-by: Andreas Rheinhardt --- libavcodec/tiff.c | 28 ++-- 1 file changed, 6 insertions(+), 22 deletio

Re: [FFmpeg-devel] [PATCH] avcodec/dv_profile: PAL DV files with dsf flag 0 - detect via pal flag and buf_size

2021-03-30 Thread Mark Plomer
ping ;-) Am 18.03.21 um 21:55 schrieb Marton Balint: It looks good to me, I will apply in a couple of days if nobody comments until then. Also Cc'd Dave, as he got probably the most experience with dv. Regards, Marton ___ ffmpeg-devel mailing list