[FFmpeg-devel] [PATCH] avformat/s337m: Use av_get_packet() to read packet

2021-03-19 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/s337m.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/libavformat/s337m.c b/libavformat/s337m.c index 9e3c8ed1ba..9d1b52eb61 100644 --- a/libavformat/s337m.c +++ b/libavformat/s337m.c @@ -147,7 +147,6 @@ static

Re: [FFmpeg-devel] FFmpeg 4.4

2021-03-19 Thread Michael Niedermayer
On Fri, Mar 19, 2021 at 05:07:00PM +0100, Michael Niedermayer wrote: > On Wed, Mar 17, 2021 at 04:23:50PM -0300, James Almer wrote: > > On 3/13/2021 8:29 AM, Michael Niedermayer wrote: > > > On Wed, Mar 10, 2021 at 10:06:49AM -0300, James Almer wrote: > > > > On 3/10/2021 7:37 AM, Michael Niedermay

Re: [FFmpeg-devel] [PATCH] avcodec/mpeg4videoenc: Check extradata malloc()

2021-03-19 Thread Michael Niedermayer
On Fri, Mar 19, 2021 at 05:04:31PM +0100, Michael Niedermayer wrote: > Fixes: Null pointer dereference > Fixes: any mpeg4 testcase which fails the malloc at that exact spot > > Found-by: Rafael Dutra > Signed-off-by: Michael Niedermayer > --- > libavcodec/mpeg4videoenc.c | 2 ++ > 1 file change

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/speedhq: Width < 8 is not supported

2021-03-19 Thread Michael Niedermayer
On Wed, Mar 17, 2021 at 01:40:51PM +0100, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 31733/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SPEEDHQ_fuzzer-4704307963363328 > Fixes: > 31736/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SPEEDHQ_fuzzer-6190960292790272 >

Re: [FFmpeg-devel] [PATCH v1] avformat/rtsp: RTP support buffer_size&pkt_size option

2021-03-19 Thread Marton Balint
On Wed, 10 Mar 2021, Marton Balint wrote: On Tue, 9 Mar 2021, gaojiang...@live.com wrote: From: Jiangjie Gao And forward it to udp. issue: https://trac.ffmpeg.org/ticket/7517 Could you add the buffer_size option to the documentation of the RTP protocol? Did it, and applied. Thanks,

Re: [FFmpeg-devel] Patch for ticket #9151

2021-03-19 Thread Marton Balint
On Fri, 19 Mar 2021, Dominic Mayers wrote: Here is the updated patch in attachment. Thanks, will apply. Regards, Marton Dominic On 3/19/21 5:05 AM, Moritz Barsnick wrote: Hi Dominic, On Thu, Mar 18, 2021 at 16:15:59 -0400, Dominic Mayers wrote: Hello, Ticket #9151 Applies to: ffmpe

Re: [FFmpeg-devel] [PATCH 1/2] avformat/libsrt: fix setsockopt() typo

2021-03-19 Thread Marton Balint
On Tue, 16 Mar 2021, myp...@gmail.com wrote: On Mon, Mar 15, 2021 at 5:06 PM Zhao Zhili wrote: --- libavformat/libsrt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/libsrt.c b/libavformat/libsrt.c index 233e9096fa..ac865c5658 100644 --- a/libavformat/libs

Re: [FFmpeg-devel] [PATCH v3] avformat/http, tls: honor http_proxy command line variable for HTTPS

2021-03-19 Thread Marton Balint
On Sun, 14 Mar 2021, Moritz Barsnick wrote: On Sun, Aug 23, 2020 at 22:50:18 +0300, Martin Storsjö wrote: > On Fri, Aug 21, 2020 at 12:19:06 +0300, Martin Storsjö wrote: > > LGTM, with one small nit: > [...] > > > {"listen", "Listen for incoming connections", offsetof(pstruct, o

Re: [FFmpeg-devel] Guided Filter Project | GSoC 2021

2021-03-19 Thread Piyush Chauhan
> > 15 Mar 2021, 07:14, Steven Liu : Hi Piyushi Chanuhan, > > 1st. You could try understand these rules under the link: > https://summerofcode.withgoogle.com/get-started/ > > 2nd. And understand Guided Filter Calculation: > For example: http://kaiminghe.com/eccv10/ > > 3rd. And try to implement a

Re: [FFmpeg-devel] [PATCH] added parameter to dash encoder for start available time

2021-03-19 Thread Jerome Berclaz
Hi all, Thanks for the comments on my patch. I should have given more explanations, but this is my first time using git-send-email and I wasn't able to add text to the patch. The reason for the patch occurred while trying to live stream a Dash feed with low latency. I did not use a timeline, henc

Re: [FFmpeg-devel] git server issues

2021-03-19 Thread Gyan Doshi
On 2021-03-20 00:37, Helmut K. C. Tessarek wrote: Just got the following error, even though I can ping source.ffmpeg.org: Unexpected error: fatal: unable to connect to source.ffmpeg.org: source.ffmpeg.org[0: 213.36.253.5]: errno=Network is unreachable error: Could not fetch origin Reproduc

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/pthread_frame: Only attempt to close decoders which have allocated private data

2021-03-19 Thread Andreas Rheinhardt
Michael Niedermayer: > On Fri, Mar 19, 2021 at 04:39:59PM +0100, Andreas Rheinhardt wrote: >> Michael Niedermayer: >>> Fixes: Null pointer dereference >>> Fixes: ff_h264_remove_all_refs.mp4 >>> >>> Found-by: Rafael Dutra >>> Tested-by: Rafael Dutra >>> Signed-off-by: Michael Niedermayer >>> ---

[FFmpeg-devel] git server issues

2021-03-19 Thread Helmut K. C. Tessarek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Just got the following error, even though I can ping source.ffmpeg.org: Unexpected error: fatal: unable to connect to source.ffmpeg.org: source.ffmpeg.org[0: 213.36.253.5]: errno=Network is unreachable error: Could not fetch origin Any ideas? Che

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/pthread_frame: Only attempt to close decoders which have allocated private data

2021-03-19 Thread Michael Niedermayer
On Fri, Mar 19, 2021 at 04:39:59PM +0100, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: Null pointer dereference > > Fixes: ff_h264_remove_all_refs.mp4 > > > > Found-by: Rafael Dutra > > Tested-by: Rafael Dutra > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/pthread

Re: [FFmpeg-devel] [PATCH] videotoolboxenc: enable constant quality with -q:v on Apple Silicon Macs and use b-frames für HEVC and H264 and b-pyramid for HEVC.

2021-03-19 Thread Rick Kern
On Fri, Jan 22, 2021 at 3:28 PM wrote: > From: Simone Karin Lehmann > > Signed-off-by: Simone Karin Lehmann > Applied > --- > libavcodec/videotoolboxenc.c | 54 > 1 file changed, 42 insertions(+), 12 deletions(-) > > diff --git a/libavcodec/videotoolboxen

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: Add support for HEVC with Alpha.

2021-03-19 Thread Rick Kern
On Tue, Mar 16, 2021 at 5:59 AM wrote: > Greetings, > > Thank you for your help in advance. > Unfortunately, my patch, which add support the "HEVC with alpha" profile > to the videotoolbox encoder, has not been reviewed for nearly three weeks. > Would it be possible to give me why nobody has revi

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: move AVCodecParameters related functions from util.c to a new file

2021-03-19 Thread James Almer
On 3/17/2021 10:56 AM, James Almer wrote: Signed-off-by: James Almer --- libavcodec/Makefile| 1 + libavcodec/codec_par.c | 202 + libavcodec/utils.c | 173 --- 3 files changed, 203 insertions(+), 173 deletion

[FFmpeg-devel] [PATCH] libavdevice/gdigrab: fix capture window title contain non-ASCII chars

2021-03-19 Thread 1160386205
From: He Yang <1160386...@qq.com> Signed-off-by: He Yang <1160386...@qq.com> --- libavdevice/gdigrab.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/libavdevice/gdigrab.c b/libavdevice/gdigrab.c index 9b2c55fe90..ff4055c925 100644 --- a/libavdevice/gdigr

Re: [FFmpeg-devel] [PATCH] avformat/utils: Preserve AV_PKT_FLAG_CORRUPT

2021-03-19 Thread Michael Niedermayer
On Fri, Mar 19, 2021 at 09:02:44AM -0600, Pavel Koshevoy wrote: > On Fri, Mar 19, 2021 at 7:58 AM Michael Niedermayer > wrote: > > > On Wed, Mar 17, 2021 at 06:19:26PM -0600, Pavel Koshevoy wrote: > > > Preserve AV_PKT_FLAG_CORRUPT so the caller can decide whether to drop > > > the packet. > > >

[FFmpeg-devel] [PATCH] avformat/s337m: Use and test Dolby-E-parser

2021-03-19 Thread Andreas Rheinhardt
This makes av_read_frame() return packets with proper timestamps. As a result, seeking now works in combination with streamcopy. A FATE-test for this has been added. Signed-off-by: Andreas Rheinhardt --- libavformat/s337m.c| 1 + tests/fate/demux.mak | 3 +++ tests/ref/fate/s337m

Re: [FFmpeg-devel] FFmpeg 4.4

2021-03-19 Thread Michael Niedermayer
On Wed, Mar 17, 2021 at 04:23:50PM -0300, James Almer wrote: > On 3/13/2021 8:29 AM, Michael Niedermayer wrote: > > On Wed, Mar 10, 2021 at 10:06:49AM -0300, James Almer wrote: > > > On 3/10/2021 7:37 AM, Michael Niedermayer wrote: > > > > On Tue, Mar 09, 2021 at 05:55:55PM -0300, James Almer wrote

[FFmpeg-devel] [PATCH] avcodec/mpeg4videoenc: Check extradata malloc()

2021-03-19 Thread Michael Niedermayer
Fixes: Null pointer dereference Fixes: any mpeg4 testcase which fails the malloc at that exact spot Found-by: Rafael Dutra Signed-off-by: Michael Niedermayer --- libavcodec/mpeg4videoenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/mpeg4videoenc.c b/libavcodec/mpeg4videoen

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/pthread_frame: Only attempt to close decoders which have allocated private data

2021-03-19 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: Null pointer dereference > Fixes: ff_h264_remove_all_refs.mp4 > > Found-by: Rafael Dutra > Tested-by: Rafael Dutra > Signed-off-by: Michael Niedermayer > --- > libavcodec/pthread_frame.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib

Re: [FFmpeg-devel] [PATCH v2 02/18] avformat/utils: Always leave parse_pkt in blank state, avoid resetting

2021-03-19 Thread James Almer
On 3/19/2021 11:47 AM, Andreas Rheinhardt wrote: Always leaving said packet in a blank state after having used it allows to avoid having to reset it before one uses it; and it also allows to use it in more places than just in parse_packets() here. Reviewed-by: James Almer Signed-off-by: Andreas

[FFmpeg-devel] [PATCH 1/2] avcodec/aacpsy: Check model_priv_data before dereferencing in psy_3gpp_end()

2021-03-19 Thread Michael Niedermayer
Fixes: null pointer dereference Fixes: av_freep.mp4 Found-by: Rafael Dutra Tested-by: Rafael Dutra Signed-off-by: Michael Niedermayer --- libavcodec/aacpsy.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/aacpsy.c b/libavcodec/aacpsy.c index fca692cb15..482113

[FFmpeg-devel] [PATCH 2/2] avcodec/pthread_frame: Only attempt to close decoders which have allocated private data

2021-03-19 Thread Michael Niedermayer
Fixes: Null pointer dereference Fixes: ff_h264_remove_all_refs.mp4 Found-by: Rafael Dutra Tested-by: Rafael Dutra Signed-off-by: Michael Niedermayer --- libavcodec/pthread_frame.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/pthread_frame.c b/libavcodec/pthrea

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/mpegpicture: Keep ff_mpeg_framesize_alloc() failure state consistent

2021-03-19 Thread Michael Niedermayer
On Thu, Mar 18, 2021 at 09:57:11PM +0100, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: null pointer dereference > > Fixes: ff_put_pixels16_sse2.mp4 > > > > Found-by: Rafael Dutra > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/mpegpicture.c | 5 - > > 1 file cha

Re: [FFmpeg-devel] [PATCH] avformat/utils: Preserve AV_PKT_FLAG_CORRUPT

2021-03-19 Thread Pavel Koshevoy
On Fri, Mar 19, 2021 at 7:58 AM Michael Niedermayer wrote: > On Wed, Mar 17, 2021 at 06:19:26PM -0600, Pavel Koshevoy wrote: > > Preserve AV_PKT_FLAG_CORRUPT so the caller can decide whether to drop > > the packet. > > --- > > libavformat/utils.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 d

[FFmpeg-devel] [PATCH] avcodec/parser: Don't return pointer to stack buffer

2021-03-19 Thread Andreas Rheinhardt
When flushing, the parser receives a dummy buffer with padding that lives on the stack of av_parser_parse2(). Certain parsers (e.g. Dolby E) only analyze the input, but don't repack it. When flushing, such parsers return a pointer to the stack buffer and a size of 0. And this is also what av_parser

[FFmpeg-devel] [PATCH v2 02/18] avformat/utils: Always leave parse_pkt in blank state, avoid resetting

2021-03-19 Thread Andreas Rheinhardt
Always leaving said packet in a blank state after having used it allows to avoid having to reset it before one uses it; and it also allows to use it in more places than just in parse_packets() here. Reviewed-by: James Almer Signed-off-by: Andreas Rheinhardt --- Indeed an improvement. Thanks. l

Re: [FFmpeg-devel] Patch for ticket #9151

2021-03-19 Thread Dominic Mayers
Here is the updated patch in attachment. Dominic On 3/19/21 5:05 AM, Moritz Barsnick wrote: > Hi Dominic, > > On Thu, Mar 18, 2021 at 16:15:59 -0400, Dominic Mayers wrote: >> Hello, >> >> Ticket #9151 >> Applies to: >> >> ffmpeg version N-101612-gda12d600ea Copyright (c) 2000-2021 the FFmpeg >>

Re: [FFmpeg-devel] [PATCH 02/18] avformat/utils: Always leave parse_pkt in blank state, avoid resetting

2021-03-19 Thread James Almer
On 3/19/2021 2:58 AM, Andreas Rheinhardt wrote: Always leaving said packet in a blank state after having used it allows to avoid having to reset it before one uses it; and it also allows to use it in more places than just in parse_packets() here. Signed-off-by: Andreas Rheinhardt --- libavfor

Re: [FFmpeg-devel] [PATCH] avformat/utils: Preserve AV_PKT_FLAG_CORRUPT

2021-03-19 Thread Michael Niedermayer
On Wed, Mar 17, 2021 at 06:19:26PM -0600, Pavel Koshevoy wrote: > Preserve AV_PKT_FLAG_CORRUPT so the caller can decide whether to drop > the packet. > --- > libavformat/utils.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavformat/utils.c b/libavformat/utils.c >

Re: [FFmpeg-devel] [PATCH] avformat/utils: Preserve AV_PKT_FLAG_CORRUPT

2021-03-19 Thread Michael Niedermayer
On Thu, Mar 18, 2021 at 02:57:59PM -0600, Pavel Koshevoy wrote: > On Thu, Mar 18, 2021 at 2:51 PM Marton Balint wrote: > > > > > > > On Wed, 17 Mar 2021, Pavel Koshevoy wrote: > > > > > Preserve AV_PKT_FLAG_CORRUPT so the caller can decide whether to drop > > > the packet. > > > > LGTM, but Micha

[FFmpeg-devel] [PATCH] vf_v360: fix (i)flat_range for fisheye projection

2021-03-19 Thread Daniel Playfair Cal
This changes the iflat_range and flat_range values for the fisheye projection so that they indicate the maximum angle between an observed point and the center (direction the camera is facing). This matches the meaning of those variables in the flat projection. Signed-off-by: Daniel Playfair Cal -

[FFmpeg-devel] [PATCH] vf_v360: fix (i)flat_range for fisheye projection

2021-03-19 Thread Daniel Playfair Cal
This changes the iflat_range and flat_range values for the fisheye projection so that they indicate the maximum angle between an observed point and the center (direction the camera is facing). This matches the meaning of those variables in the flat projection. Signed-off-by: Daniel Playfair Cal -

[FFmpeg-devel] [PATCH v2] vf_v360: fix visibility test for fisheye projection

2021-03-19 Thread Daniel Playfair Cal
Previously the visibility test referred to a circle in the input. This changes it so that it refers accurately to the entire area in the input. Signed-off-by: Daniel Playfair Cal --- This version avoids using double literals libavfilter/vf_v360.c | 2 +- 1 file changed, 1 insertion(+), 1 deleti

Re: [FFmpeg-devel] [PATCH] vf_v360: fix visibility test for fisheye projection

2021-03-19 Thread Moritz Barsnick
On Fri, Mar 19, 2021 at 20:42:04 +1100, Daniel Playfair Cal wrote: > -const int visible = hypotf(uf, vf) <= 0.5f; > +const int visible = -0.5 < uf && uf < 0.5 && -0.5 < vf && vf < 0.5; Please avoid double constants in float expressions, they propagate the whole calculation to a double. I.e

[FFmpeg-devel] [PATCH] vf_v360: fix fov_from_hfov for fisheye projection

2021-03-19 Thread Daniel Playfair Cal
This was previously incorrect, so that passing only id_fov or d_fov resulted in incorrect transformation. Signed-off-by: Daniel Playfair Cal --- libavfilter/vf_v360.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_v360.c b/libavfilter/vf_v360.c index 944

[FFmpeg-devel] [PATCH] vf_v360: fix fov_from_hfov for fisheye projection

2021-03-19 Thread Daniel Playfair Cal
This was previously incorrect, so that passing only id_fov or d_fov resulted in incorrect transformation. Signed-off-by: Daniel Playfair Cal --- libavfilter/vf_v360.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_v360.c b/libavfilter/vf_v360.c index 944

[FFmpeg-devel] [PATCH] vf_v360: fix (i)flat_range for fisheye projection

2021-03-19 Thread Daniel Playfair Cal
This changes the iflat_range and flat_range values for the fisheye projection so that they indicate the maximum angle between an observed point and the center (direction the camera is facing). This matches the meaning of those variables in the flat projection. Signed-off-by: Daniel Playfair Cal -

[FFmpeg-devel] [PATCH] vf_v360: stop doubling width for fisheye projection

2021-03-19 Thread Daniel Playfair Cal
This resulted in the default aspect ratio being doubled relative to most input formats like flat/rectilinear. After this patch the default aspect ratio is the same as a rectilinear input. Signed-off-by: Daniel Playfair Cal --- libavfilter/vf_v360.c | 4 ++-- 1 file changed, 2 insertions(+), 2 de

[FFmpeg-devel] [PATCH] vf_v360: fix visibility test for fisheye projection

2021-03-19 Thread Daniel Playfair Cal
Previously the visibility test referred to a circle in the input. This changes it so that it refers accurately to the entire area in the input. Signed-off-by: Daniel Playfair Cal --- libavfilter/vf_v360.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_v360.c b

Re: [FFmpeg-devel] Patch for ticket #9151

2021-03-19 Thread Moritz Barsnick
Hi Dominic, On Thu, Mar 18, 2021 at 16:15:59 -0400, Dominic Mayers wrote: > Hello, > > Ticket #9151 > Applies to: > > ffmpeg version N-101612-gda12d600ea Copyright (c) 2000-2021 the FFmpeg > developers > built with gcc 9 (Ubuntu 9.3.0-17ubuntu1~20.04) > > Compiled ffmpeg to include libtesseract

[FFmpeg-devel] [PATCH v4] avcodec: add Actimagine VX video decoder

2021-03-19 Thread Florian Nouwt
Signed-off-by: Florian Nouwt --- * fixed style issues * ff_h264_cavlc_data_init_vlc now only uses ff_thread_once if the vx decoder is enabled * made tables static which are not used outside h264_cavlc_data.c --- Changelog |1 + configure |1