> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Andreas Rheinhardt
> Sent: 2021年3月11日 5:55
> To: ffmpeg-devel@ffmpeg.org
> Cc: Andreas Rheinhardt
> Subject: [FFmpeg-devel] [PATCH 21/23]
> dnn/dnn_backend_native_layer_conv2d: Don't pretend convolution can fail
>
> It can't; the
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Andreas Rheinhardt
> Sent: 2021年3月11日 5:55
> To: ffmpeg-devel@ffmpeg.org
> Cc: Andreas Rheinhardt
> Subject: [FFmpeg-devel] [PATCH 20/23]
> dnn/dnn_backend_native_layer_conv2d: Check thread creation for errors
>
> Fixes Coverity
> -Original Message-
> From: ffmpeg-devel On Behalf Of Xu,
> Guangxin
> Sent: Tuesday, March 9, 2021 5:13 PM
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/h264_slice: don't copy frame
> data during error concealment
>
> W
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Andreas Rheinhardt
> Sent: 2021年3月11日 5:55
> To: ffmpeg-devel@ffmpeg.org
> Cc: Andreas Rheinhardt
> Subject: [FFmpeg-devel] [PATCH 19/23]
> dnn/dnn_backend_native_layer_conv2d: Check allocation
>
> Signed-off-by: Andreas Rheinhar
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Andreas Rheinhardt
> Sent: 2021年3月11日 5:55
> To: ffmpeg-devel@ffmpeg.org
> Cc: Andreas Rheinhardt
> Subject: [FFmpeg-devel] [PATCH 18/23]
> dnn/dnn_backend_native_layer_conv2d: Avoid separate, unchecked
> allocations
>
> Signed-o
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Andreas Rheinhardt
> Sent: 2021年3月11日 5:55
> To: ffmpeg-devel@ffmpeg.org
> Cc: Andreas Rheinhardt
> Subject: [FFmpeg-devel] [PATCH 17/23]
> dnn/dnn_backend_native_layer_conv2d: Fix memleak on error
>
> If an error happens when pr
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Soft Works
> Sent: Thursday, February 25, 2021 8:50 PM
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Cc: Artem Galin
> Subject: Re: [FFmpeg-devel] [PATCH v7 3/8] libavutil/hwcontext_qsv:
> enabling d3d11va
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Andreas Rheinhardt
> Sent: 2021年3月11日 5:55
> To: ffmpeg-devel@ffmpeg.org
> Cc: Andreas Rheinhardt
> Subject: [FFmpeg-devel] [PATCH 16/23]
> dnn/dnn_backend_native_layer_conv2d: Avoid allocation when
> single-threaded
>
> Also fix
From: "Chen,Wenbin"
MSDK vc1 and av1 sometimes output frame into the same suface, but
ffmpeg-qsv assume the surface will be used only once, so it will
unref the frame when it receives the outpur surface. Now change
it to unref frame according to queue count.
Signed-off-by Wenbin Chen
---
libav
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Andreas Rheinhardt
> Sent: 2021年3月11日 5:55
> To: ffmpeg-devel@ffmpeg.org
> Cc: Andreas Rheinhardt
> Subject: [FFmpeg-devel] [PATCH 15/23]
> dnn/dnn_backend_native_layer_conv2d: Join two arrays, avoid allocation
>
> Fixes Coverity
> 2021年3月11日 上午5:43，li...@edman007.com 写道：
>
> From: Ed Martin
>
> open_url_keepalive() unsets the options when it uses them, this
> includes the offsets for the Range: header. When using the HLS
> tag #EXT-X-BYTERANGE along with multiple files, the range options
> must be preserved after open
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Andreas Rheinhardt
> Sent: 2021年3月11日 5:55
> To: ffmpeg-devel@ffmpeg.org
> Cc: Andreas Rheinhardt
> Subject: [FFmpeg-devel] [PATCH 14/23]
> dnn/dnn_backend_native_layer_conv2d: Fix memleak on realloc failure
>
> Signed-off-by: An
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Andreas Rheinhardt
> Sent: 2021年3月11日 5:55
> To: ffmpeg-devel@ffmpeg.org
> Cc: Andreas Rheinhardt
> Subject: [FFmpeg-devel] [PATCH 13/23] dnn/dnn_backend_native: Fix typo in
> log message
>
> Signed-off-by: Andreas Rheinhardt
>
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Andreas Rheinhardt
> Sent: 2021年3月11日 5:55
> To: ffmpeg-devel@ffmpeg.org
> Cc: Andreas Rheinhardt
> Subject: [FFmpeg-devel] [PATCH 12/23] dnn/dnn_backend_native: Don't use
> asserts for checks
>
> asserts should not be used inste
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Andreas Rheinhardt
> Sent: 2021年3月11日 5:55
> To: ffmpeg-devel@ffmpeg.org
> Cc: Andreas Rheinhardt
> Subject: [FFmpeg-devel] [PATCH 11/23] dnn/dnn_backend_native: Fix leak in
> case parsing options fails
>
> Signed-off-by: Andreas
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Andreas Rheinhardt
> Sent: 2021年3月11日 5:55
> To: ffmpeg-devel@ffmpeg.org
> Cc: Andreas Rheinhardt
> Subject: [FFmpeg-devel] [PATCH 10/23] dnn/dnn_backend_native: Avoid
> allocation for checking file magic
>
> Signed-off-by: Andre
On Wed, Mar 10, 2021 at 7:49 PM Andreas Rheinhardt
wrote:
> Beginning with version 3.0, libiLBC switched the types of some parts
> of their public API to size_t and renamed some types; the old names
> continue to work as typedefs, but are deprecated. It furthermore
> added version macros.
>
> This
From: Christopher Degawa
Used for limiting the size of memory buffers and threads for a target
logical processor count, but does not set thread affinity or the total
amount of threads used, although thread affinities can be controlled
with an additional parameters, it is prefered to add them unti
Andreas Rheinhardt:
> force_one_stream() does not write anything.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> Is it it actually intended that the mp2 muxer does not use
> force_one_stream at all? And is it intended that force_one_stream
> does only check codec_type and not the actual codec?
> A
Beginning with version 3.0, libiLBC switched the types of some parts
of their public API to size_t and renamed some types; the old names
continue to work as typedefs, but are deprecated. It furthermore
added version macros.
This commit uses said version macro to use the new types when using
newer
libsvtav1 internally changed cqp to be crf while enable-tp-la is on,
which is on by default, and uses the same variables as cqp
Signed-off-by: Christopher Degawa
---
doc/encoders.texi | 14 +-
libavcodec/libsvtav1.c | 15 +--
2 files changed, 26 insertions(+), 3 dele
On 3/10/2021 2:48 PM, Marton Balint wrote:
On Tue, 9 Mar 2021, Stephen Hutchinson wrote:
On 3/9/2021 3:47 PM, Michael Niedermayer wrote:
Hi all
I will branch release/4.4 soon
then like always leave some time for testing, bugfixes, ... and then
make FFmeg 4.4 from release/4.4, its too long
avs_is_color_space provides a generic way of checking whether the
video is RGB, and has been available through AVSC_API since 2.6.
This means that GetProcAddress doesn't have to run on every frame.
---
libavformat/avisynth.c | 27 +--
1 file changed, 5 insertions(+), 22 del
It can't; these are just remnants of commit
3c7cad69f233252e5178f7732baa0da950d74bbd which let the worker threads
do the reallocation.
Signed-off-by: Andreas Rheinhardt
---
libavfilter/dnn/dnn_backend_native_layer_conv2d.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/lib
Signed-off-by: Andreas Rheinhardt
---
Why does DNN actually not use the ordinary error codes?
libavfilter/dnn/dnn_backend_native_layer_conv2d.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libavfilter/dnn/dnn_backend_native_layer_conv2d.c
b/libavfilter/dnn/dnn_backend_native_layer_conv
Fixes Coverity issue #1473533.
Signed-off-by: Andreas Rheinhardt
---
libavfilter/dnn/dnn_backend_native_layer_conv2d.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/libavfilter/dnn/dnn_backend_native_layer_conv2d.c
b/libavfilter/dnn/dnn_backend_native_layer_
Signed-off-by: Andreas Rheinhardt
---
.../dnn/dnn_backend_native_layer_conv2d.c| 16 ++--
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/libavfilter/dnn/dnn_backend_native_layer_conv2d.c
b/libavfilter/dnn/dnn_backend_native_layer_conv2d.c
index c2073a02de..94a
If an error happens when preparing the output data buffer, an already
allocated array would leak. Fix this by postponing its allocation.
Also zero-allocate the allocated array for safety.
Fixes Coverity issue #1473531.
Signed-off-by: Andreas Rheinhardt
---
libavfilter/dnn/dnn_backend_native_lay
Also fixes a memleak in single-threaded mode when an error happens
in preparing the output data buffer; and also removes an unchecked
allocation.
Signed-off-by: Andreas Rheinhardt
---
.../dnn/dnn_backend_native_layer_conv2d.c | 18 +-
1 file changed, 9 insertions(+), 9 delet
Fixes Coverity ticket #1322342.
Signed-off-by: Andreas Rheinhardt
---
It seems to me that this temporary buffer is actually unneeded: One just
needs to use the new frame as destination for blending and then
overwrite the new frame's data outside the processed rectangle with the
data from the old
Fixes Coverity issue #1473507.
Signed-off-by: Andreas Rheinhardt
---
libavfilter/dnn/dnn_backend_native_layer_conv2d.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/libavfilter/dnn/dnn_backend_native_layer_conv2d.c
b/libavfilter/dnn/dnn_backend_native_layer_conv
Fixes Coverity issue #1473568.
Signed-off-by: Andreas Rheinhardt
---
.../dnn/dnn_backend_native_layer_mathbinary.c | 23 +--
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/libavfilter/dnn/dnn_backend_native_layer_mathbinary.c
b/libavfilter/dnn/dnn_backend_native
Signed-off-by: Andreas Rheinhardt
---
libavfilter/dnn/dnn_backend_native_layer_conv2d.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/libavfilter/dnn/dnn_backend_native_layer_conv2d.c
b/libavfilter/dnn/dnn_backend_native_layer_conv2d.c
index b5c2c394ef..2b83896da9 100
Signed-off-by: Andreas Rheinhardt
---
libavfilter/dnn/dnn_backend_native.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavfilter/dnn/dnn_backend_native.c
b/libavfilter/dnn/dnn_backend_native.c
index b3c41af94e..0f26febb5d 100644
--- a/libavfilter/dnn/dnn_backend_native.
asserts should not be used instead of ordinary input checks.
Yet the native DNN backend did it: get_input_native() asserted that
the first dimension was one, despite this value coming directly from
the input file without having been sanitized.
Signed-off-by: Andreas Rheinhardt
---
get_input_nativ
Signed-off-by: Andreas Rheinhardt
---
libavfilter/dnn/dnn_backend_native.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavfilter/dnn/dnn_backend_native.c
b/libavfilter/dnn/dnn_backend_native.c
index 5336cd765a..fd1f9e299d 100644
--- a/libavfilter/dnn/dnn_backend_native.
Signed-off-by: Andreas Rheinhardt
---
libavfilter/dnn/dnn_backend_native.c | 21 +
1 file changed, 5 insertions(+), 16 deletions(-)
diff --git a/libavfilter/dnn/dnn_backend_native.c
b/libavfilter/dnn/dnn_backend_native.c
index 3bc253c1ad..5336cd765a 100644
--- a/libavfilter/
From: Ed Martin
Hey, I'm testing some HLS stuff, found a bug when using byteranges with
multiple files, it seems that the byteranges are ignored and this causes all
sorts of problems reading the wrong bytes from the files
For reference, this is the URL I've been testing with:
https://dev.edman00
From: Ed Martin
open_url_keepalive() unsets the options when it uses them, this
includes the offsets for the Range: header. When using the HLS
tag #EXT-X-BYTERANGE along with multiple files, the range options
must be preserved after open_url_keepalive() returns EOF so that
the new file can be ope
---
doc/dev_community/community.md | 2 +-
doc/dev_community/resolution_process.md | 91 +
2 files changed, 92 insertions(+), 1 deletion(-)
create mode 100644 doc/dev_community/resolution_process.md
diff --git a/doc/dev_community/community.md b/doc/dev_community
On 3/10/2021 6:28 PM, Andreas Rheinhardt wrote:
James Almer:
On 3/10/2021 4:38 PM, Michael Niedermayer wrote:
On Sat, Mar 06, 2021 at 04:42:35PM -0300, James Almer wrote:
Signed-off-by: James Almer
---
Changes since v2 is the addition of the buffer_size_t typedef to
reduce the
amount of ifdef
James Almer:
> On 3/10/2021 4:38 PM, Michael Niedermayer wrote:
>> On Sat, Mar 06, 2021 at 04:42:35PM -0300, James Almer wrote:
>>> Signed-off-by: James Almer
>>> ---
>>> Changes since v2 is the addition of the buffer_size_t typedef to
>>> reduce the
>>> amount of ifdeffery required to adapt our c
On 3/10/2021 5:22 PM, Michael Niedermayer wrote:
On Sat, Mar 06, 2021 at 06:45:57PM -0300, James Almer wrote:
On 3/6/2021 6:35 PM, Michael Niedermayer wrote:
On Fri, Mar 05, 2021 at 01:33:36PM -0300, James Almer wrote:
Signed-off-by: James Almer
---
doc/examples/vaapi_encode.c | 16 +++
On 3/10/2021 4:38 PM, Michael Niedermayer wrote:
On Sat, Mar 06, 2021 at 04:42:35PM -0300, James Almer wrote:
Signed-off-by: James Almer
---
Changes since v2 is the addition of the buffer_size_t typedef to reduce the
amount of ifdeffery required to adapt our code.
doc/APIchanges
On 3/10/2021 5:18 PM, Michael Niedermayer wrote:
On Mon, Feb 22, 2021 at 07:27:34PM -0300, James Almer wrote:
On 2/21/2021 6:04 PM, James Almer wrote:
On 2/21/2021 5:29 PM, Mark Thompson wrote:
On 21/02/2021 20:00, James Almer wrote:
On 2/21/2021 4:13 PM, Mark Thompson wrote:
On 21/02/2021 1
On 3/10/2021 2:48 PM, Marton Balint wrote:
On Tue, 9 Mar 2021, Stephen Hutchinson wrote:
On 3/9/2021 3:47 PM, Michael Niedermayer wrote:
Hi all
I will branch release/4.4 soon
then like always leave some time for testing, bugfixes, ... and then
make FFmeg 4.4 from release/4.4, its too long s
On 3/10/2021 2:48 PM, Marton Balint wrote:
On Tue, 9 Mar 2021, Stephen Hutchinson wrote:
On 3/9/2021 3:47 PM, Michael Niedermayer wrote:
Hi all
I will branch release/4.4 soon
then like always leave some time for testing, bugfixes, ... and then
make FFmeg 4.4 from release/4.4, its too long s
Hello folks,
The results of the voting on the TC rules can be found here:
https://vote.ffmpeg.org/cgi-bin/civs/results.pl?id=E_f41036c4eb321ba1
The vote is positive one at 23 vs 1 on a 24-voting-population.
(The GA is composed of 40 persons.)
The rules mentioned here are therefore valid:
https:/
On Tue, 9 Mar 2021, gaojiang...@live.com wrote:
From: Jiangjie Gao
And forward it to udp.
issue: https://trac.ffmpeg.org/ticket/7517
Could you add the buffer_size option to the documentation of the
RTP protocol?
Thanks,
Marton
Signed-off-by: Jiangjie Gao
---
libavformat/rtsp.c | 5 +
On Sat, Mar 06, 2021 at 06:45:57PM -0300, James Almer wrote:
> On 3/6/2021 6:35 PM, Michael Niedermayer wrote:
> > On Fri, Mar 05, 2021 at 01:33:36PM -0300, James Almer wrote:
> > > Signed-off-by: James Almer
> > > ---
> > > doc/examples/vaapi_encode.c | 16
> > > 1 file change
On Mon, Feb 22, 2021 at 07:27:34PM -0300, James Almer wrote:
> On 2/21/2021 6:04 PM, James Almer wrote:
> > On 2/21/2021 5:29 PM, Mark Thompson wrote:
> > > On 21/02/2021 20:00, James Almer wrote:
> > > > On 2/21/2021 4:13 PM, Mark Thompson wrote:
> > > > > On 21/02/2021 17:35, James Almer wrote:
>
On Mon, 8 Mar 2021, Ivan J. wrote:
Bump for review.
Will apply the series.
Thanks,
Marton
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-dev
On Tue, 9 Mar 2021, Stephen Hutchinson wrote:
On 3/9/2021 3:47 PM, Michael Niedermayer wrote:
Hi all
I will branch release/4.4 soon
then like always leave some time for testing, bugfixes, ... and then
make FFmeg 4.4 from release/4.4, its too long since 4.3
These three AviSynth demuxer patc
On Sat, Mar 06, 2021 at 04:42:35PM -0300, James Almer wrote:
> Signed-off-by: James Almer
> ---
> Changes since v2 is the addition of the buffer_size_t typedef to reduce the
> amount of ifdeffery required to adapt our code.
>
> doc/APIchanges | 4
> libavutil/buffer.c
On Sat, 6 Mar 2021, Marton Balint wrote:
On Mon, 1 Mar 2021, Marton Balint wrote:
Otherwise we might return 1-2 samples per packet if av_read_frame() call
rate is
only sligthly less than the stream sample rate.
Ping for this and the rest of the series. Note that the approach in
this p
On 3/10/2021 10:52 AM, Andreas Rheinhardt wrote:
James Almer:
On 3/10/2021 9:03 AM, Anton Khirnov wrote:
---
libavcodec/decode.c | 8 +++-
libavcodec/decode.h | 6 --
libavcodec/utils.c | 6 --
3 files changed, 7 insertions(+), 13 deletions(-)
diff --git a/libavcodec/deco
On Mon, 8 Mar 2021, Michael Niedermayer wrote:
On Mon, Mar 08, 2021 at 09:56:38PM +0100, Marton Balint wrote:
On Sun, 7 Mar 2021, Michael Niedermayer wrote:
On Wed, Mar 03, 2021 at 11:27:22PM +0100, Marton Balint wrote:
If the window is resized it was possible that xpos pointed outside t
Signed-off-by: Michael Niedermayer
---
doc/APIchanges | 48
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git a/doc/APIchanges b/doc/APIchanges
index 4027d599e7..eeecc102e8 100644
--- a/doc/APIchanges
+++ b/doc/APIchanges
@@ -15,87 +15,
while there fix style issue
On Wed, Mar 10, 2021 at 7:30 PM Michael Niedermayer
wrote:
> Fixes: Timeout
> Fixes:
> 31257/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FOURXM_fuzzer-5150866229297152
>
> Found-by: continuous fuzzing process
> https://github.com/google/oss-fuzz/tree/master/proj
Fixes: Timeout
Fixes:
31257/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FOURXM_fuzzer-5150866229297152
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer
---
libavcodec/4xm.c | 4 ++--
1 file changed, 2 i
> You should restrict the line length here, just for consistency with the
> rest of this document. (It doesn't affect the formatting of the output
> documents, obviously.)
>
What would be a good line length for the docs to aim for? 75?
> > +unsigned logical_processors;
>
> The libsvtav1 API d
On 10/03/2021 17:24, Michael Niedermayer wrote:
> what does the muxer exactly do ?
I provided an explanation of what is happening during the broken muxing
in my original email, as well as a sample, and a text dump of the boxes.
Please see those.
Can you please actually fully read my emails and s
On Wed, Mar 10, 2021 at 00:12:34 -0600, Christopher Degawa wrote:
> +@item logical_processors
> +Number of logical processors to run the encoder on, threads are managed by
> the OS scheduler.
> +Used for limiting the size of memory buffers and threads for a target
> logical processor count.
> +Do
On Wed, Mar 10, 2021 at 03:29:46PM +, Derek Buitenhuis wrote:
> On 08/03/2021 17:29, Michael Niedermayer wrote:
> > I would try to detect the specific abberant muxer based on the input.
> > Then have custom code in the demuxer which is based on reverse engnenering
> > the
> > issue to do a b
I have no idea how nobody, including myself, noticed this.
Signed-off-by: Derek Buitenhuis
---
libavcodec/gif.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/libavcodec/gif.c b/libavcodec/gif.c
index 938bc0e928..cafd93e190 100644
--- a/libavcodec/gif.c
+++ b/libavcodec/gi
Am 10.03.21 um 09:25 schrieb Zane van Iperen:
> Before you do, just give it a crack locally.
>
> I couldn't get the cloned version of the site to look identical to what's
> already published (something to do with incorrect CSS symlinks iirc). It's
> probably fine, but for something like this I'd
Signed-off-by: James Almer
---
libavutil/frame.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libavutil/frame.c b/libavutil/frame.c
index eab51b6a32..ec79d053e1 100644
--- a/libavutil/frame.c
+++ b/libavutil/frame.c
@@ -800,6 +800,8 @@ int av_frame_copy(AVFrame *dst, const AVFrame *src)
Files with the "dash" major brand are guaranteed to only have a single
initialization range for the whole file. We can check this and stop
appropriately - which is useful, as the existing check to see if the
offset reaches the end of the file is not sufficient. For example,
YouTube creates valid se
On 08/03/2021 17:29, Michael Niedermayer wrote:
> I would try to detect the specific abberant muxer based on the input.
> Then have custom code in the demuxer which is based on reverse engnenering
> the
> issue to do a best effort to recover as much as is possible. And also print a
> big
> war
On 3/10/2021 9:03 AM, Anton Khirnov wrote:
avcodec_open2() is massive, splitting it makes it more readable.
Also, add a missing error code to ticks_per_frame sanity check.
---
libavcodec/encode.c | 157 +
libavcodec/encode.h | 6 ++
libavcodec/utils.
On Mon, Mar 08, 2021 at 10:12:38AM +0100, Matthieu Bouron wrote:
> On Wed, Feb 17, 2021 at 04:51:09PM +0100, sfan5 wrote:
> >
>
> > From 22ebde779f61fb030633a881ef320264ea446b6b Mon Sep 17 00:00:00 2001
> > From: sfan5
> > Date: Thu, 11 Feb 2021 20:48:54 +0100
> > Subject: [PATCH 2/2] avcodec/me
On Mon, Mar 08, 2021 at 11:36:00PM -0300, James Almer wrote:
> In addition to the fact that av_image_copy() cannot handle hardware pixel
> formats, h->short_ref[0]->f may not even be writable at this point.
>
> Based on a patch by Hendrik Leppkes.
>
> Signed-off-by: James Almer
> ---
> This is a
James Almer:
> On 3/10/2021 9:03 AM, Anton Khirnov wrote:
>> ---
>> libavcodec/decode.c | 8 +++-
>> libavcodec/decode.h | 6 --
>> libavcodec/utils.c | 6 --
>> 3 files changed, 7 insertions(+), 13 deletions(-)
>>
>> diff --git a/libavcodec/decode.c b/libavcodec/decode.c
>> index
On 3/10/2021 9:03 AM, Anton Khirnov wrote:
---
libavcodec/decode.c | 8 +++-
libavcodec/decode.h | 6 --
libavcodec/utils.c | 6 --
3 files changed, 7 insertions(+), 13 deletions(-)
diff --git a/libavcodec/decode.c b/libavcodec/decode.c
index e5a301ec58..d25b15e95a 100644
--- a
On Mon, Mar 08, 2021 at 10:11:58AM +0100, Matthieu Bouron wrote:
> On Wed, Feb 17, 2021 at 04:50:00PM +0100, sfan5 wrote:
> > Hi,
> >
> > while looking into mediacodec for unrelated reasons I saw some room for
> > improvement.
> >
> > Therefore, here's a series with two small patches.
> >
>
> >
On 3/10/2021 7:37 AM, Michael Niedermayer wrote:
On Tue, Mar 09, 2021 at 05:55:55PM -0300, James Almer wrote:
On 3/9/2021 5:47 PM, Michael Niedermayer wrote:
Hi all
I will branch release/4.4 soon
then like always leave some time for testing, bugfixes, ... and then
make FFmeg 4.4 from release/4
Anton Khirnov:
> ---
> libavcodec/utils.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/libavcodec/utils.c b/libavcodec/utils.c
> index 2545d9234c..e0f6234bd7 100644
> --- a/libavcodec/utils.c
> +++ b/libavcodec/utils.c
> @@ -530,7 +530,7 @@ static int64_t get_bit
Anton Khirnov:
> The only potentially unsafe operation is the codec-specific init
> function.
> ---
> libavcodec/utils.c | 7 ++-
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/libavcodec/utils.c b/libavcodec/utils.c
> index e0f6234bd7..952adb5277 100644
> --- a/libavcodec
The only potentially unsafe operation is the codec-specific init
function.
---
libavcodec/utils.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/libavcodec/utils.c b/libavcodec/utils.c
index e0f6234bd7..952adb5277 100644
--- a/libavcodec/utils.c
+++ b/libavcodec/utils.c
---
libavcodec/utils.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libavcodec/utils.c b/libavcodec/utils.c
index 2545d9234c..e0f6234bd7 100644
--- a/libavcodec/utils.c
+++ b/libavcodec/utils.c
@@ -530,7 +530,7 @@ static int64_t get_bit_rate(AVCodecContext *ctx)
}
---
libavcodec/encode.c | 246 ++--
1 file changed, 123 insertions(+), 123 deletions(-)
diff --git a/libavcodec/encode.c b/libavcodec/encode.c
index bbf03d62fc..6c15f37806 100644
--- a/libavcodec/encode.c
+++ b/libavcodec/encode.c
@@ -465,157 +465,157 @@ in
It is unnecessary and misleading, as those are static functions.
---
libavcodec/utils.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/libavcodec/utils.c b/libavcodec/utils.c
index 918cb1b4d1..2545d9234c 100644
--- a/libavcodec/utils.c
+++ b/libavcodec/utils.c
@@
---
libavcodec/decode.c | 8 +++-
libavcodec/decode.h | 6 --
libavcodec/utils.c | 6 --
3 files changed, 7 insertions(+), 13 deletions(-)
diff --git a/libavcodec/decode.c b/libavcodec/decode.c
index e5a301ec58..d25b15e95a 100644
--- a/libavcodec/decode.c
+++ b/libavcodec/decode.c
@@
avcodec_open2() is massive, splitting it makes it more readable.
Also, add a missing error code to ticks_per_frame sanity check.
---
libavcodec/encode.c | 157 +
libavcodec/encode.h | 6 ++
libavcodec/utils.c | 166 +--
---
libavcodec/decode.c | 41
libavcodec/decode.h | 6 ++
libavcodec/utils.c | 46 +
3 files changed, 52 insertions(+), 41 deletions(-)
diff --git a/libavcodec/decode.c b/libavcodec/decode.c
index 082188195
On Tue, Mar 09, 2021 at 05:55:55PM -0300, James Almer wrote:
> On 3/9/2021 5:47 PM, Michael Niedermayer wrote:
> > Hi all
> >
> > I will branch release/4.4 soon
> > then like always leave some time for testing, bugfixes, ... and then
> > make FFmeg 4.4 from release/4.4, its too long since 4.3
> >
lgtm
On Wed, Mar 10, 2021 at 2:06 AM Andreas Rheinhardt <
andreas.rheinha...@gmail.com> wrote:
> Fixes Coverity issue #1473546.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavfilter/vf_nnedi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavfilter/vf_nnedi.c b/
Unused since 8843607f495c95c1e67a3ce3d6f15dca6e252439.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/cbs_h264.h | 10 --
libavcodec/cbs_h265.h | 9 -
2 files changed, 19 deletions(-)
diff --git a/libavcodec/cbs_h264.h b/libavcodec/cbs_h264.h
index 9eb97eae24..5a8641a333 1006
This seems all very reasonable.
Most of these suggestions are easily fixed, but I am struggling to find
the best approach to avoiding those global function pointers.
The approach of storing these in some kind of context, as mentioned in
the referenced message looks like the best solution. Am I ri
Michael Niedermayer wrote:
>I will branch release/4.4 soon
>then like always leave some time for testing, bugfixes, ... and then
>make FFmeg 4.4 from release/4.4, its too long since 4.3
Good news! Thank you very much indeed! Reto
___
ffmpeg-devel mail
Before you do, just give it a crack locally.
I couldn't get the cloned version of the site to look identical to what's already published (something to do with
incorrect CSS symlinks iirc). It's probably fine, but for something like this I'd rather err on the side of caution.
Zane
On 8/3/21 1
91 matches
Mail list logo
