Re: [FFmpeg-devel] make: *** [ffbuild/common.mak:67: libavfilter/vf_nnedi.o] Error 1

2021-01-19 Thread Hongyi Zhao
On Wed, Jan 20, 2021 at 11:32 AM James Almer wrote: > > On 1/20/2021 12:29 AM, Hongyi Zhao wrote: > > On Wed, Jan 20, 2021 at 10:52 AM James Almer wrote: > >> > >> On 1/19/2021 11:24 PM, Hongyi Zhao wrote: > >>> On Wed, Jan 20, 2021 at 12:19 AM Derek Buitenhuis > >>> wrote: > > On 19/0

Re: [FFmpeg-devel] make: *** [ffbuild/common.mak:67: libavfilter/vf_nnedi.o] Error 1

2021-01-19 Thread James Almer
On 1/20/2021 12:29 AM, Hongyi Zhao wrote: On Wed, Jan 20, 2021 at 10:52 AM James Almer wrote: On 1/19/2021 11:24 PM, Hongyi Zhao wrote: On Wed, Jan 20, 2021 at 12:19 AM Derek Buitenhuis wrote: On 19/01/2021 09:21, Hongyi Zhao wrote: libavfilter/vf_nnedi.c: At top level: libavfilter/vf_nne

Re: [FFmpeg-devel] make: *** [ffbuild/common.mak:67: libavfilter/vf_nnedi.o] Error 1

2021-01-19 Thread Hongyi Zhao
On Wed, Jan 20, 2021 at 10:52 AM James Almer wrote: > > On 1/19/2021 11:24 PM, Hongyi Zhao wrote: > > On Wed, Jan 20, 2021 at 12:19 AM Derek Buitenhuis > > wrote: > >> > >> On 19/01/2021 09:21, Hongyi Zhao wrote: > >>> libavfilter/vf_nnedi.c: At top level: > >>> libavfilter/vf_nnedi.c:819:13: err

Re: [FFmpeg-devel] [PATCH] libavformat: add librist protocol

2021-01-19 Thread Sergio M. Ammirata, Ph.D.
Hello Paul, In the librist_read function, you must call the new API called rist_receiver_data_block_free to free the buffer when you are done using it. I am not sure if ffmpeg supports a custom callback for freeing a buffer. If it does, you could actually use the rist buffer as a reference as lon

Re: [FFmpeg-devel] make: *** [ffbuild/common.mak:67: libavfilter/vf_nnedi.o] Error 1

2021-01-19 Thread James Almer
On 1/19/2021 11:24 PM, Hongyi Zhao wrote: On Wed, Jan 20, 2021 at 12:19 AM Derek Buitenhuis wrote: On 19/01/2021 09:21, Hongyi Zhao wrote: libavfilter/vf_nnedi.c: At top level: libavfilter/vf_nnedi.c:819:13: error: conflicting types for ‘read’ 819 | static void read(float *dst, size_t n, c

Re: [FFmpeg-devel] make: *** [ffbuild/common.mak:67: libavfilter/vf_nnedi.o] Error 1

2021-01-19 Thread Hongyi Zhao
On Wed, Jan 20, 2021 at 12:19 AM Derek Buitenhuis wrote: > > On 19/01/2021 09:21, Hongyi Zhao wrote: > > libavfilter/vf_nnedi.c: At top level: > > libavfilter/vf_nnedi.c:819:13: error: conflicting types for ‘read’ > > 819 | static void read(float *dst, size_t n, const float **data) > > I thought

Re: [FFmpeg-devel] [PATCH] libavdevice: Add KMS/DRM output device

2021-01-19 Thread Marton Balint
On Tue, 19 Jan 2021, Anton Khirnov wrote: Quoting Mark Thompson (2021-01-19 00:37:09) On 16/01/2021 22:12, Nicolas Caramelli wrote: > This patch adds KMS/DRM output device for rendering a video stream > using KMS/DRM dumb buffer. > The proposed implementation is very basic, only bgr0 pixel fo

[FFmpeg-devel] [PATCH 2/3] avformat/paf: Do not zero allocated tables which are immedeately filled

2021-01-19 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavformat/paf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/paf.c b/libavformat/paf.c index 9587111643..bcd6213a45 100644 --- a/libavformat/paf.c +++ b/libavformat/paf.c @@ -149,11 +149,11 @@ static int read_header

[FFmpeg-devel] [PATCH 3/3] avformat/paf: Check for EOF before allocation in read_header()

2021-01-19 Thread Michael Niedermayer
Fixes: OOM Fixes: 26584/clusterfuzz-testcase-minimized-ffmpeg_dem_PAF_fuzzer-5172661183053824 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/paf.c | 4 1 file changed, 4 insertions(+)

Re: [FFmpeg-devel] [PATCH 1/4] avformat/asfdec_o: Check size vs. offset in detect_unknown_subobject()

2021-01-19 Thread Michael Niedermayer
On Tue, Jan 12, 2021 at 10:51:13PM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: 2314885530818453566 + 7503032301549264928 > cannot be represented in type 'long' > Fixes: > 26639/clusterfuzz-testcase-minimized-ffmpeg_dem_ASF_O_fuzzer-6024222100684800 > > Alternatively this

[FFmpeg-devel] [PATCH 1/3] avformat/asfdec_o: Check for EOF in asf_read_marker()

2021-01-19 Thread Michael Niedermayer
Fixes: Timeout Fixes: 26460/clusterfuzz-testcase-minimized-ffmpeg_dem_ASF_O_fuzzer-5710884393189376 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/asfdec_o.c | 3 +++ 1 file changed, 3 inser

Re: [FFmpeg-devel] [PATCH v4 3/3] avformat/mxfenc: prefer to use the configured metadta

2021-01-19 Thread Marton Balint
On Tue, 19 Jan 2021, Tobias Rapp wrote: On 18.01.2021 23:53, Tomas Härdin wrote: lör 2021-01-16 klockan 08:43 +0800 skrev lance.lmw...@gmail.com: On Fri, Jan 15, 2021 at 09:43:58PM +0100, Marton Balint wrote: On Fri, 15 Jan 2021, Tomas Härdin wrote: Again, why? If you have a company that

Re: [FFmpeg-devel] [PATCH v2 07/13] cbs: Implement common parts of cbs-based bitstream filters separately

2021-01-19 Thread Mark Thompson
On 19/01/2021 03:07, James Almer wrote: On 1/18/2021 7:44 PM, Mark Thompson wrote: +#define BSF_ELEMENT_OPTIONS_PIR(name, help, field, unit_name) \ You could reuse name instead of also passing unit_name. The only bsf where it differs is h264_metadata with display_orientation vs disp_or, and c

Re: [FFmpeg-devel] [PATCH] libavdevice: Add KMS/DRM output device

2021-01-19 Thread Mark Thompson
On 19/01/2021 19:04, Nicolas George wrote: Anton Khirnov (12021-01-19): (Note that I would argue against adding more general display output devices which are already present, like fb and xv, because they are of essentially no value to libavdevice users. Removing legacy code is harder, though.)

Re: [FFmpeg-devel] [PATCH] libavdevice: Add KMS/DRM output device

2021-01-19 Thread James Almer
On 1/19/2021 4:04 PM, Nicolas George wrote: Anton Khirnov (12021-01-19): (Note that I would argue against adding more general display output devices which are already present, like fb and xv, because they are of essentially no value to libavdevice users. Removing legacy code is harder, though.)

Re: [FFmpeg-devel] [PATCH 2/3] libavformat/hls: add support for SAMPLE-AES decryption in HLS demuxer

2021-01-19 Thread James Almer
On 1/18/2021 2:39 PM, Nachiket Tarate wrote: +typedef struct AVParserContext { +const uint8_t *buf_in; +const uint8_t *buf_end; +uint8_t *buf_out; +int next_start_code_length; +} AVParserContext; The AV prefix in structs names should not be used for an in

Re: [FFmpeg-devel] [PATCH 1/3] libavcodec/adts_header: add frame_length field and avpriv function to parse AAC ADTS header

2021-01-19 Thread James Almer
On 1/18/2021 2:39 PM, Nachiket Tarate wrote: These will be used by HLS demuxer in case of SAMPLE-AES encryption/decryption. Signed-off-by: Nachiket Tarate --- libavcodec/adts_header.c | 1 + libavcodec/adts_header.h | 1 + libavcodec/adts_parser.c | 29 - liba

Re: [FFmpeg-devel] [PATCH] libavdevice: Add KMS/DRM output device

2021-01-19 Thread Nicolas George
Anton Khirnov (12021-01-19): > > (Note that I would argue against adding more general display output > > devices which are already present, like fb and xv, because they are > > of essentially no value to libavdevice users. Removing legacy code > > is harder, though.) > > +1 > > IMO libavdevice o

Re: [FFmpeg-devel] [PATCH] libavdevice: Add KMS/DRM output device

2021-01-19 Thread Nicolas Caramelli
I appreciate to directly experiment ffmpeg without X11 or SDL dependencies, just using the ffmpeg binary. This is especially true when I work on embedded systems and I use it a lot. Even though the fbdev output device is available, the Linux Framebuffer is often considered obsolete in favor of KMS

Re: [FFmpeg-devel] [PATCH 4/7] avformat/nistspheredec: Check bits_per_coded_sample and channels

2021-01-19 Thread Michael Niedermayer
On Mon, Jan 18, 2021 at 09:06:10PM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2021-01-17 00:07:26) > > Fixes: signed integer overflow: 80 * 92233009 cannot be represented in type > > 'int' > > Fixes: > > 26910/clusterfuzz-testcase-minimized-ffmpeg_dem_NISTSPHERE_fuzzer-66691006549

Re: [FFmpeg-devel] [PATCH] [RFC][v2] Tech Resolution Process

2021-01-19 Thread Paul B Mahol
On Tue, Jan 19, 2021 at 5:26 PM Nicolas George wrote: > Ronald S. Bultje (12021-01-18): > > I agree "involved" should be constrained to just be one of the two > parties > > bringing this up to the TC. And yes this can be gamed, everything can. > It's > > meant to prevent extreme cases, not make t

Re: [FFmpeg-devel] [PATCH] [RFC][v2] Tech Resolution Process

2021-01-19 Thread Nicolas George
Ronald S. Bultje (12021-01-18): > I agree "involved" should be constrained to just be one of the two parties > bringing this up to the TC. And yes this can be gamed, everything can. It's > meant to prevent extreme cases, not make the world a perfect place. We > can't do that with rules alone. I ag

Re: [FFmpeg-devel] make: *** [ffbuild/common.mak:67: libavfilter/vf_nnedi.o] Error 1

2021-01-19 Thread Derek Buitenhuis
On 19/01/2021 09:21, Hongyi Zhao wrote: > libavfilter/vf_nnedi.c: At top level: > libavfilter/vf_nnedi.c:819:13: error: conflicting types for ‘read’ > 819 | static void read(float *dst, size_t n, const float **data) I thought this might happen when I saw it go in. We shouldn't be naming functio

Re: [FFmpeg-devel] [PATCH] libavdevice: Add KMS/DRM output device

2021-01-19 Thread John Cox
On Mon, 18 Jan 2021 23:37:09 +, you wrote: >On 16/01/2021 22:12, Nicolas Caramelli wrote: >> This patch adds KMS/DRM output device for rendering a video stream >> using KMS/DRM dumb buffer. >> The proposed implementation is very basic, only bgr0 pixel format is >> currently supported (the most

[FFmpeg-devel] [PATCH] libavformat: add librist protocol

2021-01-19 Thread Paul B Mahol
This work is sponsored by Open Broadcast Systems. Signed-off-by: Paul B Mahol --- configure | 5 + doc/protocols.texi | 32 + libavformat/Makefile| 1 + libavformat/librist.c | 250 libavformat/protocols.c | 1 + 5 file

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/flashsv2enc: factorize updating block dimensions

2021-01-19 Thread Anton Khirnov
Quoting Marton Balint (2021-01-18 21:53:30) > > > On Mon, 18 Jan 2021, Anton Khirnov wrote: > > > Quoting Marton Balint (2021-01-10 02:20:45) > >> Signed-off-by: Marton Balint > >> --- > >> libavcodec/flashsv2enc.c | 76 +--- > >> 1 file changed, 32 insertio

Re: [FFmpeg-devel] [PATCH] libavdevice: Add KMS/DRM output device

2021-01-19 Thread Anton Khirnov
Quoting Mark Thompson (2021-01-19 00:37:09) > On 16/01/2021 22:12, Nicolas Caramelli wrote: > > This patch adds KMS/DRM output device for rendering a video stream > > using KMS/DRM dumb buffer. > > The proposed implementation is very basic, only bgr0 pixel format is > > currently supported (the mos

Re: [FFmpeg-devel] [PATCH] avformat/dhav: Fix incorrect non-DHAV chunk skipping logic

2021-01-19 Thread Idan Freiberg
Oh i didn't notice that. Thanks. On Mon, Jan 18, 2021 at 8:22 PM Paul B Mahol wrote: > Isn't this applied already? > > On Mon, Jan 18, 2021 at 6:46 PM Idan Freiberg wrote: > > > Can one of the maintainers review the patch please? > > > > בתאריך יום ד׳, 13 בינו׳ 2021 ב-14:35 מאת Idan Freiberg >

[FFmpeg-devel] make: *** [ffbuild/common.mak:67: libavfilter/vf_nnedi.o] Error 1

2021-01-19 Thread Hongyi Zhao
On Ubuntu 20.10, I try to compile the latest git master version of ffmpeg as below: # In the needed prerequisites and execute the following command: $ sudo apt-get build-dep ffmpeg $ git clone https://git.ffmpeg.org/ffmpeg.git ffmpeg.git $ cd ffmpeg.git $ ./configure --enable-rpath--enable-gp