Re: [FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-11-05 Thread Steven Liu
> 2020年11月6日 上午2:29,Bohan Li 写道: > > Another ping :) I think maybe you should fix JEEB’s review comment, then will get responses comments. Not only apply a middle version. > > Bohan > > On Fri, Oct 30, 2020 at 2:43 PM Bohan Li wrote: > >> Gentle ping :) >> >> Bohan >> >> On Tue, Oct 27,

Re: [FFmpeg-devel] [PATCH v4 0/5] AMV muxing and adpcm_ima_amv encoding support

2020-11-05 Thread Zane van Iperen
On 5/11/20 11:48 pm, Zane van Iperen wrote: Adds support for encoding to adpcm_ima_amv and muxing to AMV. Things to note: - AMV is a hard-coded (and broken) subset of AVI. It's not worth sullying the existing AVI muxer with its filth. - The muxer is extremely pedantic about its streams, this

Re: [FFmpeg-devel] [PATCH 1/7] [RFC] Revert "avcodec/adpcm_swf: support decoding multiple fixed-sized blocks at once"

2020-11-05 Thread Zane van Iperen
On 6/11/20 9:11 am, Michael Niedermayer wrote: The reverted code split at block_align boundaries, but there was already code which splits at a hardcoded 4096 sample boundary. reverting this seemed like the easiest fix but this is a RFC in case another solution is preferred This breaks play

Re: [FFmpeg-devel] [PATCH] dxva2: add AV1 decode support

2020-11-05 Thread Mark Thompson
On 05/11/2020 15:53, Hendrik Leppkes wrote: --- Changelog | 1 + configure | 7 + libavcodec/Makefile| 2 + libavcodec/av1dec.c| 25 +- libavcodec/dxva2.c | 10 +- libavcodec/dxva2_av1.c | 504 + libavco

Re: [FFmpeg-devel] [PATCH 3/3] hwcontext_vaapi: Use PRIME_2 memory type for modifiers.

2020-11-05 Thread Mark Thompson
On 03/11/2020 23:17, Bas Nieuwenhuizen wrote: This way we can pass explicit modifiers in. Sometimes the modifier matters for the number of memory planes that libva accepts, in particular when dealing with driver-compressed textures. Furthermore the driver might not actually be able to determine t

Re: [FFmpeg-devel] [PATCH 2/3] kmsgrab: Do not require the modifier to stay constant.

2020-11-05 Thread Mark Thompson
On 04/11/2020 00:26, Bas Nieuwenhuizen wrote: On Wed, Nov 4, 2020 at 1:09 AM Mark Thompson wrote: On 03/11/2020 23:17, Bas Nieuwenhuizen wrote: As we get a new set of objects each frame anyway, we do not gain anything by keeping the modifier constant. This helps with capturing when switching

Re: [FFmpeg-devel] [PATCH 4/7] avformat/au: cleanup on EOF return in au_read_annotation()

2020-11-05 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: memleak > Fixes: > 26841/clusterfuzz-testcase-minimized-ffmpeg_dem_AU_fuzzer-5174166309044224 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavformat/au.c |

[FFmpeg-devel] [PATCH 3/7] avformat/av1dec: check size before addition in probing

2020-11-05 Thread Michael Niedermayer
Fixes: signed integer overflow: 175 + 2147483571 cannot be represented in type 'int' Fixes: 26833/clusterfuzz-testcase-minimized-ffmpeg_dem_IMAGE2_fuzzer-5969501214212096 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael N

[FFmpeg-devel] [PATCH 1/7] [RFC] Revert "avcodec/adpcm_swf: support decoding multiple fixed-sized blocks at once"

2020-11-05 Thread Michael Niedermayer
The reverted code split at block_align boundaries, but there was already code which splits at a hardcoded 4096 sample boundary. reverting this seemed like the easiest fix but this is a RFC in case another solution is preferred Fixes: out of array write Fixes: 26821/clusterfuzz-testcase-minimize

[FFmpeg-devel] [PATCH 6/7] avcodec/h264idct_template: Fix integer overflow in ff_h264_chroma422_dc_dequant_idct()

2020-11-05 Thread Michael Niedermayer
Fixes: signed integer overflow: -2105540608 - 2105540608 cannot be represented in type 'int' Fixes: 26870/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_H264_fuzzer-5656647567147008 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off

[FFmpeg-devel] [PATCH 7/7] avcodec/tiff: Disallow striped and tiled tiffs except for DNG

2020-11-05 Thread Michael Niedermayer
strips + tiles is not allowed in TIFF DNG uses a separate codepath Regression since da5b3d002862d1e105002a6dc1567e6551860896. Fixes: NULL pointer dereference Fixes: poc1 Found-by: 1vanChen of NSFOCUS Security Team Signed-off-by: Michael Niedermayer --- libavcodec/tiff.c | 7 +-- 1 file cha

[FFmpeg-devel] [PATCH 5/7] avformat/dsfdec: Check block_align more completely

2020-11-05 Thread Michael Niedermayer
Fixes: infinite loop Fixes: 26865/clusterfuzz-testcase-minimized-ffmpeg_dem_DSF_fuzzer-5649473830912000 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/dsfdec.c | 4 ++-- 1 file changed, 2 in

[FFmpeg-devel] [PATCH 4/7] avformat/au: cleanup on EOF return in au_read_annotation()

2020-11-05 Thread Michael Niedermayer
Fixes: memleak Fixes: 26841/clusterfuzz-testcase-minimized-ffmpeg_dem_AU_fuzzer-5174166309044224 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/au.c | 5 - 1 file changed, 4 insertions(+

[FFmpeg-devel] [PATCH 2/7] avformat/realtextdec: read_ts() in 64bits

2020-11-05 Thread Michael Niedermayer
Fixes: signed integer overflow: 46671062 * 100 cannot be represented in type 'int' Fixes: 26826/clusterfuzz-testcase-minimized-ffmpeg_dem_REALTEXT_fuzzer-5644062910316544 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael N

[FFmpeg-devel] [PATCH] aviobuf: Increase the default SHORT_SEEK_THRESHOLD to 32 KB

2020-11-05 Thread Martin Storsjö
The previous threshold, 4 KB, maybe was reasonable when it was set (in 2010), but in today's settings and with typical network speeds and data sizes, it's pretty small. 32 KB probably is a more reasonable default now, regardless of input. This changes the test references for two seek tests. When

Re: [FFmpeg-devel] [PATCH v2] avformat/nut: Store display matrix side data

2020-11-05 Thread Matthias Neugebauer
Am 04.11.2020 um 19:24 schrieb Michael Niedermayer : > > Is this FFmpeg specific or why is the X- prefix preferred over adding > this to nut.txt ? > > thx No, side data such as the display matrix is commonly used in other formats and outside of FFmpeg. Having it in the NUT spec is probably bette

Re: [FFmpeg-devel] [PATCH] dxva2: add AV1 decode support

2020-11-05 Thread Hendrik Leppkes
On Thu, Nov 5, 2020 at 7:12 PM James Almer wrote: > > > > That depends on the behavior of av1dec. Are all tile groups guaranteed > > to be available at the same time, so that I can simply save pointers > > to them, and copy them into the final buffer later? > > Not currently, in theory, but can be

Re: [FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-11-05 Thread Bohan Li
Another ping :) Bohan On Fri, Oct 30, 2020 at 2:43 PM Bohan Li wrote: > Gentle ping :) > > Bohan > > On Tue, Oct 27, 2020 at 4:13 PM Bohan Li wrote: > >> Hi Jan, >> >> Thanks for the suggestion! I believe that is a good idea. I am not super >> familiar with this part, though, so will probably

Re: [FFmpeg-devel] [PATCH] dxva2: add AV1 decode support

2020-11-05 Thread James Almer
On 11/5/2020 1:55 PM, Hendrik Leppkes wrote: On Thu, Nov 5, 2020 at 5:45 PM James Almer wrote: +pp->coding.reference_frame_update = !(frame_header->show_existing_frame == 1 && frame_header->frame_type == AV1_FRAME_KEY); hwaccel->start_frame() is not called for frame_header->show_ex

Re: [FFmpeg-devel] [PATCH] dxva2: add AV1 decode support

2020-11-05 Thread Hendrik Leppkes
On Thu, Nov 5, 2020 at 5:45 PM James Almer wrote: > > +pp->coding.reference_frame_update = > > !(frame_header->show_existing_frame == 1 && frame_header->frame_type == > > AV1_FRAME_KEY); > > hwaccel->start_frame() is not called for > frame_header->show_existing_frame == 1 frames (Those

Re: [FFmpeg-devel] [PATCH] dxva2: add AV1 decode support

2020-11-05 Thread James Almer
On 11/5/2020 12:53 PM, Hendrik Leppkes wrote: --- Changelog | 1 + configure | 7 + libavcodec/Makefile| 2 + libavcodec/av1dec.c| 25 +- libavcodec/dxva2.c | 10 +- libavcodec/dxva2_av1.c | 504 + libav

Re: [FFmpeg-devel] [PATCH] dxva2: add AV1 decode support

2020-11-05 Thread Hendrik Leppkes
On Thu, Nov 5, 2020 at 4:54 PM Hendrik Leppkes wrote: > > --- > Changelog | 1 + > configure | 7 + > libavcodec/Makefile| 2 + > libavcodec/av1dec.c| 25 +- > libavcodec/dxva2.c | 10 +- > libavcodec/dxva2_av1.c | 504

[FFmpeg-devel] [PATCH] dxva2: add AV1 decode support

2020-11-05 Thread Hendrik Leppkes
--- Changelog | 1 + configure | 7 + libavcodec/Makefile| 2 + libavcodec/av1dec.c| 25 +- libavcodec/dxva2.c | 10 +- libavcodec/dxva2_av1.c | 504 + libavcodec/hwaccels.h | 3 + libavcodec/version.h | 2

Re: [FFmpeg-devel] [PATCH] [v4] Add support for playing Audible AAXC (.aaxc) files

2020-11-05 Thread Paul B Mahol
Next time apply without [PATCH v4] in main log On Mon, Nov 2, 2020 at 3:19 PM Vesselin Bontchev < vesselin.bontc...@yandex.com> wrote: > The AAXC container format is the same as the (already supported) Audible > AAX format but it uses a different encryption scheme. > > Note: audible_key and audib

[FFmpeg-devel] [PATCH v4 5/5] avformat: add amv muxer

2020-11-05 Thread Zane van Iperen
AMV is a hard-coded (and broken) subset of AVI. It's not worth sullying the existing AVI muxer with its filth. Fixes ticket #747. Signed-off-by: Zane van Iperen --- MAINTAINERS | 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/amvenc.c | 4

[FFmpeg-devel] [PATCH v4 4/5] avcodec: add adpcm_ima_amv encoder

2020-11-05 Thread Zane van Iperen
Fixes ticket #747. Signed-off-by: Zane van Iperen --- doc/general_contents.texi | 2 +- libavcodec/adpcmenc.c | 58 ++- libavcodec/allcodecs.c| 1 + libavcodec/utils.c| 1 + 4 files changed, 60 insertions(+), 2 deletions(-) diff --git a/doc

[FFmpeg-devel] [PATCH v4 3/5] avcodec/adpcm_ima_amv: document header format

2020-11-05 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavcodec/adpcm.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index 80ce5b8518..6001a2a4c8 100644 --- a/libavcodec/adpcm.c +++ b/libavcodec/adpcm.c @@ -1693,6 +1693,16 @@ static int adpcm_decode_frame(

[FFmpeg-devel] [PATCH v4 0/5] AMV muxing and adpcm_ima_amv encoding support

2020-11-05 Thread Zane van Iperen
Adds support for encoding to adpcm_ima_amv and muxing to AMV. Things to note: - AMV is a hard-coded (and broken) subset of AVI. It's not worth sullying the existing AVI muxer with its filth. - The muxer is extremely pedantic about its streams, this is to not break certain software players. - T

[FFmpeg-devel] [PATCH v4 1/5] avcodec/adpcm_ima_amv: restrict to 1 channel

2020-11-05 Thread Zane van Iperen
The format doesn't allow for anything else. Signed-off-by: Zane van Iperen --- libavcodec/adpcm.c | 5 - libavcodec/utils.c | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index 701b125c47..d34fd6c6e1 100644 --- a/libavcodec/adpc

[FFmpeg-devel] [PATCH v4 2/5] avcodec/adpcm_ima_amv: use coded sample count

2020-11-05 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavcodec/adpcm.c | 19 ++- tests/ref/fate/adpcm-ima-amv | 312 +-- 2 files changed, 174 insertions(+), 157 deletions(-) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index d34fd6c6e1..80ce5b8518 100644 --- a/l

Re: [FFmpeg-devel] [PATCH] avfilter: add adenorm filter

2020-11-05 Thread Paul B Mahol
Will apply with silly doc error fixed. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] avfilter/af_asoftclip: add oversampling support

2020-11-05 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- configure | 1 + doc/filters.texi | 3 ++ libavfilter/af_asoftclip.c | 106 ++--- 3 files changed, 103 insertions(+), 7 deletions(-) diff --git a/configure b/configure index 8a9e9b3cd7..2f02d7f5c8 1007