Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_qsv: add 10-bit RGB support for QSV

2020-08-09 Thread Hendrik Leppkes
On Mon, Aug 10, 2020 at 6:07 AM Linjie Fu wrote: > > On Mon, Aug 10, 2020 at 4:31 AM Mark Thompson wrote: > > > > On 09/08/2020 06:11, Linjie Fu wrote: > > > After adding a copy pass through path inside MSDK, x2rgb10 is now > > > available as an output of VPP. > > > > > > Command line for CSC: >

Re: [FFmpeg-devel] [PATCH v3 1/2] dxva: wait until D3D11 buffer copies are done before submitting them

2020-08-09 Thread Steve Lhomme
On 2020-08-08 8:24, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of Steve Lhomme Sent: Saturday, August 8, 2020 7:10 AM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH v3 1/2] dxva: wait until D3D11 buffer copies are done before submitting them [.

Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_qsv: add 10-bit RGB support for QSV

2020-08-09 Thread Linjie Fu
On Mon, Aug 10, 2020 at 4:31 AM Mark Thompson wrote: > > On 09/08/2020 06:11, Linjie Fu wrote: > > After adding a copy pass through path inside MSDK, x2rgb10 is now > > available as an output of VPP. > > > > Command line for CSC: > > ffmpeg -hwaccel qsv -v verbose -c:v hevc_qsv -i > > p010.h2

Re: [FFmpeg-devel] [PATCH] doc/encoders: Add all options for JPEG2000 encoder

2020-08-09 Thread Gautam Ramakrishnan
On Mon, Aug 10, 2020 at 12:07 AM Gyan Doshi wrote: > > > > On 09-08-2020 11:13 pm, gautamr...@gmail.com wrote: > > From: Gautam Ramakrishnan > > > > This patch updates the documentation by adding all options > > for JPEG2000 encoder. > > --- > > doc/encoders.texi | 20 > >

[FFmpeg-devel] [PATCH 3/3] avformat/mlvdec: Only store dimensions after having validated them

2020-08-09 Thread Andreas Rheinhardt
Otherwise it might happen that invalid dimensions are used when reading a video packet; this might lead to undefined overflow. Signed-off-by: Andreas Rheinhardt --- libavformat/mlvdec.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/libavformat/mlvdec.c

[FFmpeg-devel] [PATCH 2/3] avformat/mlvdec: Don't leak open AVIOContexts on error

2020-08-09 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/mlvdec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/mlvdec.c b/libavformat/mlvdec.c index 7c7ced7f76..50913fa685 100644 --- a/libavformat/mlvdec.c +++ b/libavformat/mlvdec.c @@ -52,6 +52,8 @@ typedef struct { uint64_t

[FFmpeg-devel] [PATCH 1/3] avformat/mlvdec: Check for existence of AVIOContext before using it

2020-08-09 Thread Andreas Rheinhardt
The mlv demuxer supports input split into multiple files; if invalid data is encountered when parsing one of the subsequent files, that file is closed. But at this point some index entries belonging to this file might already have been added. In this case, the read_packet function might try to use

[FFmpeg-devel] [PATCH v3 3/5] avformat/argo_asf: add version_major and version_minor options

2020-08-09 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavformat/argo_asf.c | 47 +++--- 1 file changed, 44 insertions(+), 3 deletions(-) diff --git a/libavformat/argo_asf.c b/libavformat/argo_asf.c index bb69b01ff4..d25a5de37f 100644 --- a/libavformat/argo_asf.c +++ b/libavfor

[FFmpeg-devel] [PATCH v3 4/5] avformat/argo_asf: add name option

2020-08-09 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavformat/argo_asf.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/libavformat/argo_asf.c b/libavformat/argo_asf.c index d25a5de37f..577b9d9c01 100644 --- a/libavformat/argo_asf.c +++ b/libavformat/argo_asf.c @@ -68,6 +68,7

[FFmpeg-devel] [PATCH v3 1/5] avformat/argo_asf: add games to version list

2020-08-09 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavformat/argo_asf.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/argo_asf.c b/libavformat/argo_asf.c index 671b7482f9..94d3ae3e09 100644 --- a/libavformat/argo_asf.c +++ b/libavformat/argo_asf.c @@ -87,9 +87,12 @@ static

[FFmpeg-devel] [PATCH v3 2/5] avformat/argo_asf: don't check file version

2020-08-09 Thread Zane van Iperen
It has no bearing on structure. Determined by looking at the ASF files from several Argonaut games: - FX Fighter, - Croc, - Croc 2, - The Emperor's New Groove, and - Disney's Aladdin in Nasira's Revenge The only versions that appear are 1.1, 1.2, and 2.1, and their structure is identical

[FFmpeg-devel] [PATCH v3 5/5] avformat/argo_asf: strip file extension from name

2020-08-09 Thread Zane van Iperen
Only when the user hasn't manually specified one. Matches the original files more closely. Signed-off-by: Zane van Iperen --- libavformat/argo_asf.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/libavformat/argo_asf.c b/libavformat/argo_asf.c index 577

Re: [FFmpeg-devel] [PATCH] avcodec/options: Add options for inputing HDR10-related metadata

2020-08-09 Thread Kenny McClive
Thanks, Andreas. When I fix it, do I submit a patch for this patch or a whole new patch with the combined changes? Thanks, Kenny > On Aug 9, 2020, at 4:00 AM, Andreas Rheinhardt > wrote: > > Kenny McClive: >> Hi, >> >> Would someone be willing to help me with this? This is the first patch

Re: [FFmpeg-devel] [PATCH 1/4] kmsgrab: Refactor and clean error cases

2020-08-09 Thread Mark Thompson
On 05/07/2020 16:49, Mark Thompson wrote: --- libavdevice/kmsgrab.c | 151 ++ 1 file changed, 93 insertions(+), 58 deletions(-) Thanks to Lynne on IRC for looking at this set. Applied with some minor fixups to error logging. - Mark __

Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_qsv: add 10-bit RGB support for QSV

2020-08-09 Thread Mark Thompson
On 09/08/2020 06:11, Linjie Fu wrote: After adding a copy pass through path inside MSDK, x2rgb10 is now available as an output of VPP. Command line for CSC: ffmpeg -hwaccel qsv -v verbose -c:v hevc_qsv -i p010.h265 -vf scale_qsv=format=x2rgb10,hwdownload,format=x2rgb10 -vframes 1 out.y

Re: [FFmpeg-devel] [PATCH] avcodec/options: Add options for inputing HDR10-related metadata

2020-08-09 Thread Andreas Rheinhardt
Kenny McClive: > Thanks, Andreas. When I fix it, do I submit a patch for this patch or a whole > new patch with the combined changes? > The latter. - Andreas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmp

Re: [FFmpeg-devel] [PATCH v2 1/4] avformat/argo_asf: don't check or probe file version

2020-08-09 Thread Alexander Strasser
Am 9. August 2020 14:33:26 MESZ schrieb Zane van Iperen : >On Sun, 9 Aug 2020 09:29:16 +0200 >"Paul B Mahol" wrote: > >> >> This is really bad practice. >> > >Usually I'd agree. However (and I've just checked this) all file >versions are identical. > >Since this is an Argonaut Games format, I

Re: [FFmpeg-devel] [PATCH] doc/encoders: Add all options for JPEG2000 encoder

2020-08-09 Thread Gyan Doshi
On 09-08-2020 11:13 pm, gautamr...@gmail.com wrote: From: Gautam Ramakrishnan This patch updates the documentation by adding all options for JPEG2000 encoder. --- doc/encoders.texi | 20 1 file changed, 20 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.te

[FFmpeg-devel] [PATCH] doc/encoders: Add all options for JPEG2000 encoder

2020-08-09 Thread gautamramk
From: Gautam Ramakrishnan This patch updates the documentation by adding all options for JPEG2000 encoder. --- doc/encoders.texi | 20 1 file changed, 20 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index de0472e225..aaac026709 100644 --- a/doc/encoders.

Re: [FFmpeg-devel] [PATCH 2/2] lavf/dump: hide a few deprecation warnings.

2020-08-09 Thread Andreas Rheinhardt
Nicolas George: > Nicolas George (12019-12-08): >> Signed-off-by: Nicolas George >> --- >> libavformat/dump.c | 6 ++ >> 1 file changed, 6 insertions(+) >> > Ping? Will apply next time I think about it if nobody objects. > > Regards, > Too late. See 202e06870eb4bbc4636aff5f461c1a0654ec2435.

Re: [FFmpeg-devel] [PATCH] avcodec/cfhd: prepare for SIMD addition

2020-08-09 Thread Paul B Mahol
On 8/9/20, Paul B Mahol wrote: > Hi, > > patch attached. > Fixed patch attached. 0001-avcodec-cfhd-prepare-for-SIMD-addition.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpe

Re: [FFmpeg-devel] [PATCH] avcodec/cfhd: prepare for SIMD addition

2020-08-09 Thread Paul B Mahol
On 8/9/20, James Almer wrote: > On 8/9/2020 1:57 PM, Paul B Mahol wrote: >> Hi, >> >> patch attached. > > [...] > >> libavcodec/Makefile | 2 +- >> libavcodec/cfhd.c | 60 +++- >> libavcodec/cfhd.h | 3 ++ >> libavcodec/cfhddsp.c| 62 +

Re: [FFmpeg-devel] [PATCH] avcodec/cfhd: prepare for SIMD addition

2020-08-09 Thread James Almer
On 8/9/2020 1:57 PM, Paul B Mahol wrote: > Hi, > > patch attached. [...] > libavcodec/Makefile | 2 +- > libavcodec/cfhd.c | 60 +++- > libavcodec/cfhd.h | 3 ++ > libavcodec/cfhddsp.c| 62 ++ > libavcodec

[FFmpeg-devel] [PATCH] avcodec/cfhd: prepare for SIMD addition

2020-08-09 Thread Paul B Mahol
Hi, patch attached. 0001-avcodec-cfhd-prepare-for-SIMD-addition.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-dev

Re: [FFmpeg-devel] [PATCH 21/21] avfilter/af_aformat: Add uninit function

2020-08-09 Thread Nicolas George
Andreas Rheinhardt (12020-08-09): > Fixes memleaks in case init fails (e.g. because of invalid parameters > like 'aformat=sample_fmts=s16:cl=wtf') or also if query_formats is never > called. > > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/af_aformat.c | 16 +++- > 1 file ch

Re: [FFmpeg-devel] [PATCH 19/21] avfilter: Remove redundant ff_formats/channel_layouts_unref()

2020-08-09 Thread Nicolas George
Andreas Rheinhardt (12020-08-09): > ff_add_format() and ff_add_channel_layout() already unref the list upon > error. > > Signed-off-by: Andreas Rheinhardt > --- > These ff_formats/channel_layouts_unref() also didn't do anything before > this patchset, as none of these lists has any owner. LGTM,

Re: [FFmpeg-devel] [PATCH 20/21] avfilter/avfiltergraph: Remove unused macro parameter

2020-08-09 Thread Nicolas George
Andreas Rheinhardt (12020-08-09): > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/avfiltergraph.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Ok, of course. Thanks. Regards, -- Nicolas George signature.asc Description: PGP signature __

[FFmpeg-devel] [PATCH V7 2/2] FATE/dnn: add unit test for dnn avgpool layer

2020-08-09 Thread Ting Fu
'make fate-dnn-layer-avgpool' to run the test Signed-off-by: Ting Fu --- tests/dnn/.gitignore | 1 + tests/dnn/Makefile | 1 + tests/dnn/dnn-layer-avgpool-test.c | 197 + tests/fate/dnn.mak | 5 + 4 files changed, 20

Re: [FFmpeg-devel] [PATCH 10/21] avfilter/af_amix: Don't needlessly reallocate table

2020-08-09 Thread Paul B Mahol
LGTM On 8/9/20, Andreas Rheinhardt wrote: > Replace using ff_add_format() repeatedly by a single call to > ff_make_format_list(). (Right now this also fixes a memleak: If the > first ff_add_format() succeeds and a subsequent call fails, the list > leaks.) > > Signed-off-by: Andreas Rheinhardt >

[FFmpeg-devel] [PATCH V7 1/2] dnn/native: add native support for avg_pool

2020-08-09 Thread Ting Fu
Not support pooling strides in channel dimension yet. Signed-off-by: Ting Fu --- libavfilter/dnn/Makefile | 1 + libavfilter/dnn/dnn_backend_native.h | 2 + .../dnn/dnn_backend_native_layer_avgpool.c| 141 ++ .../dnn/dnn_backend_native_layer_

[FFmpeg-devel] [PATCH 16/21] avfilter/af_channelmap: Fix double-free of AVFilterChannelLayouts on error

2020-08-09 Thread Andreas Rheinhardt
The query_formats function of the channelmap filter tries to allocate a list of channel layouts which on success are attached to more permanent objects (an AVFilterLink) for storage afterwards. If attaching succeeds, the link becomes one of the common owners (in this case, the only owner) of the li

[FFmpeg-devel] [PATCH 20/21] avfilter/avfiltergraph: Remove unused macro parameter

2020-08-09 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/avfiltergraph.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavfilter/avfiltergraph.c b/libavfilter/avfiltergraph.c index a149f8fb6d..681c519ef0 100644 --- a/libavfilter/avfiltergraph.c +++ b/libavfilter/avfiltergra

[FFmpeg-devel] [PATCH 21/21] avfilter/af_aformat: Add uninit function

2020-08-09 Thread Andreas Rheinhardt
Fixes memleaks in case init fails (e.g. because of invalid parameters like 'aformat=sample_fmts=s16:cl=wtf') or also if query_formats is never called. Signed-off-by: Andreas Rheinhardt --- libavfilter/af_aformat.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git

[FFmpeg-devel] [PATCH 19/21] avfilter: Remove redundant ff_formats/channel_layouts_unref()

2020-08-09 Thread Andreas Rheinhardt
ff_add_format() and ff_add_channel_layout() already unref the list upon error. Signed-off-by: Andreas Rheinhardt --- These ff_formats/channel_layouts_unref() also didn't do anything before this patchset, as none of these lists has any owner. libavfilter/af_aformat.c | 9 - libavfi

[FFmpeg-devel] [PATCH 15/21] avfilter/vf_alphamerge: Fix double-free of AVFilterFormats on error

2020-08-09 Thread Andreas Rheinhardt
The query_formats function of the alphamerge filter tries to allocate two lists of formats which on success are attached to more permanent objects (AVFilterLinks) for storage afterwards. If attaching a list to an AVFilterLink succeeds, the link becomes one of the owners of the list. Yet if attachin

[FFmpeg-devel] [PATCH 14/21] avfilter/vf_overlay: Fix double-free of AVFilterFormats on error

2020-08-09 Thread Andreas Rheinhardt
The query_formats function of the overlay filter tries to allocate two lists (only one in a special case) of formats which on success are attached to more permanent objects (AVFilterLinks) for storage afterwards. If attaching a list to an AVFilterLink succeeds, it is in turn owned by the AVFilterLi

[FFmpeg-devel] [PATCH 18/21] avfilter/vf_hwdownload: Fix leak of formats list upon error

2020-08-09 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_hwdownload.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_hwdownload.c b/libavfilter/vf_hwdownload.c index 33af30cf40..ce10b60e59 100644 --- a/libavfilter/vf_hwdownload.c +++ b/libavfilter/vf_hwdown

[FFmpeg-devel] [PATCH 13/21] avfilter/vf_remap: Fix double-free of AVFilterFormats on error

2020-08-09 Thread Andreas Rheinhardt
The query_formats function of the remap filter tries to allocate two lists of formats which on success are attached to more permanent objects (AVFilterLinks) for storage afterwards. If attaching a list to an AVFilterLink succeeds, it is in turn owned by the AVFilterLink (or more exactly, the AVFilt

[FFmpeg-devel] [PATCH 17/21] avfilter/formats: Fix double frees and memleaks on error

2020-08-09 Thread Andreas Rheinhardt
The formats API deals with lists of channel layouts, sample rates, pixel formats and sample formats. These lists are refcounted in a way in which the list structure itself contains pointers to all of its owners. Furthermore, it is possible for a list to be not owned by anyone yet; this status is te

[FFmpeg-devel] [PATCH 12/21] avfilter/vf_showpalette: Fix double-free of AVFilterFormats on error

2020-08-09 Thread Andreas Rheinhardt
The query_formats function of the showpalette filter tries to allocate two lists of formats which on success are attached to more permanent objects (AVFilterLinks) for storage afterwards. If attaching a list to an AVFilterLink succeeds, the link becomes one (in this case the only one) of the owners

[FFmpeg-devel] [PATCH 08/21] avfilter/vf_paletteuse: Fix leaks of AVFilterFormats on error

2020-08-09 Thread Andreas Rheinhardt
The paletteuse's query_formats function allocated three AVFilterFormats before storing them permanently. If allocating one of them failed, the three AVFilterFormats structures would be freed with av_freep() which does not free separately allocated subelements (namely the formats array) which leak.

[FFmpeg-devel] [PATCH 11/21] avfilter/af_amix: Fix double-free of AVFilterChannelLayouts on error

2020-08-09 Thread Andreas Rheinhardt
The query_formats function of the amix filter tries to allocate a list of channel layouts which are attached to more permanent objects (an AVFilter's links) for storage afterwards on success. If attaching a list to a link succeeds, the link becomes one of the common owners of the list. Yet if a lis

[FFmpeg-devel] [PATCH 07/21] avfilter/af_afir: Fix leak of AVFilterChannelLayout in case of error

2020-08-09 Thread Andreas Rheinhardt
If an error happens between the allocation of an AVFilterChannelLayout and its usage (which involves attaching said object to a more permanent object), the channel layout array leaks. This can simply be fixed by making sure that nothing is between the allocation and the aforementioned usage. Fixes

[FFmpeg-devel] [PATCH 10/21] avfilter/af_amix: Don't needlessly reallocate table

2020-08-09 Thread Andreas Rheinhardt
Replace using ff_add_format() repeatedly by a single call to ff_make_format_list(). (Right now this also fixes a memleak: If the first ff_add_format() succeeds and a subsequent call fails, the list leaks.) Signed-off-by: Andreas Rheinhardt --- libavfilter/af_amix.c | 12 ++-- 1 file chan

[FFmpeg-devel] [PATCH 09/21] avfilter/vf_vpp_qsv: Fix leak of AVFilterFormats on error

2020-08-09 Thread Andreas Rheinhardt
The vpp_qsv's query_formats function allocated two AVFilterFormats, before storing them permanently. If storing the first of them fails, the function simply returns and the second leaks. This has been fixed by only allocating the second AVFilterFormats structure after the first one has been success

Re: [FFmpeg-devel] [PATCH] avcodec/cfhd: add 3d transform support

2020-08-09 Thread Reto Kromer
Kieran Kunhya wrote: >On Thu, 6 Aug 2020 at 17:28, Paul B Mahol >wrote: > >> patches attached. >> > >Seems ok if tested on various samples. Tested with a few samples only, LGTM. Best regards, Reto ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 4/6] avformat/argo_asf: add version_major and version_minor options

2020-08-09 Thread Alexander Strasser
Am 8. August 2020 14:52:02 MESZ schrieb Zane van Iperen : >On Sat, 08 Aug 2020 13:05:28 +0200 >"Alexander Strasser" wrote: > >> >@@ -296,8 +298,7 @@ static int argo_asf_write_header(AVFormatContext >> >*s) >> > ArgoASFContext *ctx = s->priv_data; >> > >> > ctx->fhdr.magic

Re: [FFmpeg-devel] [PATCH] lavc/avpacket: forward av_buffer_realloc() error code.

2020-08-09 Thread James Almer
On 1/4/2020 4:00 PM, Nicolas George wrote: > Fix CID 1457229. > > Signed-off-by: Nicolas George > --- > libavcodec/avpacket.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c > index 858f827a0a..4da832c53c 100644 > ---

Re: [FFmpeg-devel] [PATCH] lavf/tee: pass options to protocol.

2020-08-09 Thread Nicolas George
Marvin Scholz (12020-08-09): > I think I already wrote this back when the patch was proposed, > but I tested it and it works fine. > I dont think it can cause any issues in other cases either, > so LGTM. Sorry, I fumbled my mailbox search, I had already applied this. Regards, -- Nicolas Georg

Re: [FFmpeg-devel] [PATCH] libavcodec/j2kenc: Support for all Progression orders

2020-08-09 Thread Michael Niedermayer
On Thu, Aug 06, 2020 at 11:09:32PM +0530, gautamr...@gmail.com wrote: > From: Gautam Ramakrishnan > > This patch allows for selecting the progression order > in the j2k encoder. However, all components and resolution > levels will use the same progression order and will not > feature the use of p

Re: [FFmpeg-devel] [PATCH] avcodec/cfhd: small cleanups

2020-08-09 Thread Kieran Kunhya
On Sun, 9 Aug 2020 at 13:20, Paul B Mahol wrote: > Hi, > > patches attached. > Ok ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ff

Re: [FFmpeg-devel] [PATCH] lavf/tee: pass options to protocol.

2020-08-09 Thread Marvin Scholz
On 9 Aug 2020, at 13:06, Nicolas George wrote: > Nicolas George (12020-06-02): >> Fix trac ticket #8705. >> >> Signed-off-by: Nicolas George >> --- >> libavformat/tee.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> >> Not tested, I have no icecast server at hand. I will ask the

Re: [FFmpeg-devel] [PATCH 2/2] lavc/ratecontrol: Fix error logging for parsing and evaluation of rc_eq

2020-08-09 Thread Michael Niedermayer
On Sun, Aug 09, 2020 at 02:24:34PM +0200, Alexander Strasser wrote: > > > Am 9. August 2020 12:56:53 MESZ schrieb Michael Niedermayer > : > >On Fri, Aug 07, 2020 at 11:26:58PM +0200, Alexander Strasser wrote: > >> Don't pass a potential NULL pointer to av_log, instead use a default > >> in the r

Re: [FFmpeg-devel] [PATCH 1/2] lavc/snowenc: Expose an option to set the rc_eq expression

2020-08-09 Thread Michael Niedermayer
On Fri, Aug 07, 2020 at 11:26:17PM +0200, Alexander Strasser wrote: > Snow uses the ratecontrol module, but does not expose a way to set > the rc_eq expression. The default expression, set in the ratecontrol > module, will always be used. > > Make it possible to set rc_eq by adding an AVOption to

Re: [FFmpeg-devel] [PATCH] web/documentation: Updated list of FFmpeg books

2020-08-09 Thread FFmpegQuickHacks
Hi, The original patch is archived at: http://ffmpeg.org/pipermail/ffmpeg-devel/2020-May/262634.html Here it is again: --- src/documentation | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/documentation b/src/documentation index 060ef06..f6d5535 100644 ---

Re: [FFmpeg-devel] [PATCH v2 1/4] avformat/argo_asf: don't check or probe file version

2020-08-09 Thread Zane van Iperen
On Sun, 9 Aug 2020 09:29:16 +0200 "Paul B Mahol" wrote: > > This is really bad practice. > Usually I'd agree. However (and I've just checked this) all file versions are identical. Since this is an Argonaut Games format, I checked the version of all the ASF files in their most recent games. Th

Re: [FFmpeg-devel] [PATCH] lavf/tee: pass options to protocol.

2020-08-09 Thread Paul B Mahol
On 8/9/20, Nicolas George wrote: > Nicolas George (12020-06-02): >> Fix trac ticket #8705. >> >> Signed-off-by: Nicolas George >> --- >> libavformat/tee.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> >> Not tested, I have no icecast server at hand. I will ask the reporter to >>

Re: [FFmpeg-devel] [PATCH 2/2] lavc/ratecontrol: Fix error logging for parsing and evaluation of rc_eq

2020-08-09 Thread Alexander Strasser
Am 9. August 2020 12:56:53 MESZ schrieb Michael Niedermayer : >On Fri, Aug 07, 2020 at 11:26:58PM +0200, Alexander Strasser wrote: >> Don't pass a potential NULL pointer to av_log, instead use a default >> in the rc_eq AVOption definitions. Now the context variable always >> holds a string; even

Re: [FFmpeg-devel] [PATCH] web/documentation: Updated list of FFmpeg books

2020-08-09 Thread FFmpegQuickHacks
Hi, It has been three months after I submitted this patch. (In the meantime, FFmpeg.org released a new version and updated the website without requiring any patches.) Lou Logan says somebody else needs to support the patch. Please let me know if anything further needs to be done before it can

[FFmpeg-devel] [PATCH] avcodec/cfhd: small cleanups

2020-08-09 Thread Paul B Mahol
Hi, patches attached. 0001-avcodec-cfhd-check-if-band-encoding-is-valid.patch Description: Binary data 0002-avcodec-cfhd-reindent.patch Description: Binary data 0003-avcodec-cfhd-use-init_get_bits8.patch Description: Binary data 0004-avcodec-cfhd-read-prescale-table-tag.patch Description:

Re: [FFmpeg-devel] [PATCH] lavc/avpacket: forward av_buffer_realloc() error code.

2020-08-09 Thread Nicolas George
Nicolas George (12020-08-09): > Ping? Will apply next time I think about it if nobody objects and it > still applies. Sorry, I missed Andreas comment in another mailbox. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpe

Re: [FFmpeg-devel] [PATCH] lavu/buffer: forward av_buffer_realloc() error code.

2020-08-09 Thread Nicolas George
Nicolas George (12020-01-04): > From 8ef49a7c86e108ed9e6981d482ae892e6f62c0f5 Mon Sep 17 00:00:00 2001 > From: Nicolas George > Date: Sat, 4 Jan 2020 19:52:08 +0100 > Subject: [PATCH 1/2] lavu/buffer: forward av_buffer_realloc() error code. > > Fix CID 1457235. > > Signed-off-by: Nicolas George

Re: [FFmpeg-devel] [PATCH] lavc/avpacket: forward av_buffer_realloc() error code.

2020-08-09 Thread Nicolas George
Nicolas George (12020-01-04): > Fix CID 1457229. > > Signed-off-by: Nicolas George > --- > libavcodec/avpacket.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) Ping? Will apply next time I think about it if nobody objects and it still applies. Regards, -- Nicolas George s

Re: [FFmpeg-devel] [PATCH] lavu/avstring: deprecate av_d2str().

2020-08-09 Thread Nicolas George
Nicolas George (12019-12-27): > James Almer (12019-12-26): > > I guess we'll bumping in the coming months (it's been a long while since > > the last time, and some cleaning is in order), so might as well make > > this < 58 so we don't have to postpone it later. > > Ok, locally changed to 58. I ne

Re: [FFmpeg-devel] [PATCH v2] doc/developer: origin of tables should be documented.

2020-08-09 Thread Nicolas George
Zane van Iperen (12020-08-09): > I'm apprehensive about this, especially in the case of > reverse-engineered tables. It should definitely be encouraged, but not > necessarily hard-required. > > If you explicitly say "Reverse Engineered from so-and-so", that seems > essentially like putting a targe

Re: [FFmpeg-devel] [PATCH v2] doc/developer: origin of tables should be documented.

2020-08-09 Thread Nicolas George
Alexander Strasser (12020-08-09): > >> Andreas: > > I'm sure the following was addressed at me. Yes, sorry to both of you. > IMHO we don't actually need ideology for this matter. I hope so. > At least the aspect Mark mentioned below. > > In general I think it could be worded a bit clearer and

Re: [FFmpeg-devel] [PATCH v2] doc/developer: origin of tables should be documented.

2020-08-09 Thread Alexander Strasser
Hi Nicolas! Am 8. August 2020 23:26:02 MESZ schrieb Mark Thompson : >On 08/08/2020 18:57, Nicolas George wrote: [...] >> Andreas: I'm sure the following was addressed at me. >>> Not sure I agree with your definition of Libre Software and your >exact >> >> I was more trying to express the d

Re: [FFmpeg-devel] [PATCH] lavf/tee: pass options to protocol.

2020-08-09 Thread Nicolas George
Nicolas George (12020-06-02): > Fix trac ticket #8705. > > Signed-off-by: Nicolas George > --- > libavformat/tee.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > Not tested, I have no icecast server at hand. I will ask the reporter to > test. Ping? Will apply next time I think

Re: [FFmpeg-devel] [PATCH 2/2] lavf/dump: hide a few deprecation warnings.

2020-08-09 Thread Nicolas George
Nicolas George (12019-12-08): > Signed-off-by: Nicolas George > --- > libavformat/dump.c | 6 ++ > 1 file changed, 6 insertions(+) > Ping? Will apply next time I think about it if nobody objects. Regards, -- Nicolas George signature.asc Description: PGP signature _

Re: [FFmpeg-devel] [PATCH] fate: remove "-v 0" from ffprobe tests.

2020-08-09 Thread Nicolas George
Nicolas George (12016-05-05): > The FATE scripts separate stdout from stderr. > Having a first idea about what went wrong in the log file > is more convenient. > > Signed-off-by: Nicolas George > --- > tests/fate-run.sh | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) Pi

[FFmpeg-devel] [PATCH 2/2] lavfi/avf_concat: check input timestamp.

2020-08-09 Thread Nicolas George
If an input has an undefined timestamp, the computation for silence at stitches can overflow. Partial fix for trac ticket #8843. Signed-off-by: Nicolas George --- libavfilter/avf_concat.c | 4 1 file changed, 4 insertions(+) "Partial fix" means it does not segfault and exits with an erro

Re: [FFmpeg-devel] [PATCH 2/2] lavc/ratecontrol: Fix error logging for parsing and evaluation of rc_eq

2020-08-09 Thread Michael Niedermayer
On Fri, Aug 07, 2020 at 11:26:58PM +0200, Alexander Strasser wrote: > Don't pass a potential NULL pointer to av_log, instead use a default > in the rc_eq AVOption definitions. Now the context variable always > holds a string; even if it's the default expression. > > Note this also fixes the evalua

[FFmpeg-devel] [PATCH 1/2] lavfi/avf_concat: add some doxy.

2020-08-09 Thread Nicolas George
The semantic of delta_pts is not obvious. Signed-off-by: Nicolas George --- libavfilter/avf_concat.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/libavfilter/avf_concat.c b/libavfilter/avf_concat.c index 28bd5407ad..246628498a 100644 --- a/libavfilter/avf_concat.c +++ b/li

Re: [FFmpeg-devel] [PATCH] avcodec/options: Add options for inputing HDR10-related metadata

2020-08-09 Thread Andreas Rheinhardt
Kenny McClive: > Hi, > > Would someone be willing to help me with this? This is the first patch I’ve > submitted. Patchwork shows that two tests are failing. However, when I run > “make fate” locally, I don’t see any failures. Is there some other make or > configure command that I can run t

Re: [FFmpeg-devel] [PATCH v2 1/4] avformat/argo_asf: don't check or probe file version

2020-08-09 Thread Paul B Mahol
This is really bad practice. On 8/8/20, Zane van Iperen wrote: > All files I've seen are identical, irregardless of version. > Until shown otherwise, assume unknown ones are too. > > Signed-off-by: Zane van Iperen > --- > libavformat/argo_asf.c | 37 +++-- > 1 fi