Re: [FFmpeg-devel] [PATCH] avcodec/adpcmenc: remove forward declaration

On Sun, 21. Jun 07:07, lance.lmw...@gmail.com wrote: > On Sat, Jun 20, 2020 at 02:34:10PM -0400, Andriy Gelman wrote: > > From: Andriy Gelman > > > > Signed-off-by: Andriy Gelman > > --- > > libavcodec/adpcmenc.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/libavcodec/adpcme

Re: [FFmpeg-devel] [PATCH] avcodec/adpcmenc: remove forward declaration

On Sat, Jun 20, 2020 at 02:34:10PM -0400, Andriy Gelman wrote: > From: Andriy Gelman > > Signed-off-by: Andriy Gelman > --- > libavcodec/adpcmenc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/libavcodec/adpcmenc.c b/libavcodec/adpcmenc.c > index 1fe1aef6f5..1e94ef4047 100644 > --

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: fix no warning message if no input signal detected

On Sat, Jun 20, 2020 at 08:39:00PM +0200, Marton Balint wrote: > > > On Sat, 20 Jun 2020, lance.lmw...@gmail.com wrote: > > > On Sat, Jun 20, 2020 at 01:31:43AM +0200, Marton Balint wrote: > > > > > > > > > On Sat, 20 Jun 2020, lance.lmw...@gmail.com wrote: > > > > > > > On Fri, Jun 19, 2020

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/mpeg12dec: do not discard older a53 captions

On Sat, Jun 20, 2020 at 01:44:28PM -0300, James Almer wrote: > > ffmpeg | branch: master | Paul B Mahol > > | Sat Jun 20 15:02:48 > > 2020 +0200| [29ea4e1b3c511de0a406722bcfffa11604745451] | committer: Paul B > > Mahol > > > > avcodec/mpeg12dec:

Re: [FFmpeg-devel] [PATCH] avformat: AMQP: add option delivery_mode

That's OK for me -- Florian LEVIS Le sam. 20 juin 2020 à 20:56, Andriy Gelman a écrit : > On Sat, 20. Jun 19:16, Levis Florian wrote: > > Signed-off-by: Levis Florian > > --- > > doc/protocols.texi| 15 +++ > > libavformat/libamqp.c | 6 +- > > 2 files changed, 20 insert

Re: [FFmpeg-devel] [PATCH v1 3/4] lavf/avs3dec: add raw avs3 demuxer

On Sat, Jun 20, 2020 at 09:45:51AM +0800, hwr...@126.com wrote: > From: hwren > > Signed-off-by: hbj > Signed-off-by: hwren > --- > libavformat/Makefile | 1 + > libavformat/allformats.c | 1 + > libavformat/avs3dec.c| 79 > > 3 files

[FFmpeg-devel] [PATCH] avcodec/adpcmenc: remove forward declaration

From: Andriy Gelman Signed-off-by: Andriy Gelman --- libavcodec/adpcmenc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/adpcmenc.c b/libavcodec/adpcmenc.c index 1fe1aef6f5..1e94ef4047 100644 --- a/libavcodec/adpcmenc.c +++ b/libavcodec/adpcmenc.c @@ -58,8 +58,6 @@ typedef str

Re: [FFmpeg-devel] [PATCH] avformat: AMQP: add option delivery_mode

On Sat, 20. Jun 19:16, Levis Florian wrote: > Signed-off-by: Levis Florian > --- > doc/protocols.texi| 15 +++ > libavformat/libamqp.c | 6 +- > 2 files changed, 20 insertions(+), 1 deletion(-) > > diff --git a/doc/protocols.texi b/doc/protocols.texi > index 7aa758541c..2e15

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: fix no warning message if no input signal detected

On Sat, 20 Jun 2020, lance.lmw...@gmail.com wrote: On Sat, Jun 20, 2020 at 01:31:43AM +0200, Marton Balint wrote: On Sat, 20 Jun 2020, lance.lmw...@gmail.com wrote: > On Fri, Jun 19, 2020 at 10:46:33PM +0200, Marton Balint wrote: > > > > > > On Fri, 19 Jun 2020, Limin Wang wrote: > > >

Re: [FFmpeg-devel] About SAMPLE-AES encryption for m3u8

On 20/06/2020 19:17, Eran Kornblau wrote: No, that is incorrect, KEYFORMAT="com.apple.streamingkeydelivery" means Apple FairPlay DRM. In this case, the skd contains the keyId which, as the name suggests, is an identifier representing the encryption key, but it is not the key itself. The key can

Re: [FFmpeg-devel] About SAMPLE-AES encryption for m3u8

> Been trying to figure out how to decrypt SAMPLE-AES and eventually hit an > issue with my lack of understanding how H264 and ffmpeg work. > > Example > > https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fd3iki3eydrtvsa.cloudfront.net%2FChernobyl_20200618213021%2FHLS%2FChernobyl

Re: [FFmpeg-devel] query on pixel formats

On Sat, 20 Jun 2020 at 18:59, Gautam Ramakrishnan wrote: > On Thu, Jun 18, 2020 at 3:06 AM Carl Eugen Hoyos > wrote: > > > > Am Mi., 17. Juni 2020 um 23:30 Uhr schrieb Carl Eugen Hoyos > > : > > > > > (A wild guess is that gray8 has to be added to RGB_PIXEL_FORMATS) > > > > If this is the issue,

Re: [FFmpeg-devel] [PATCH] avutil: Add NV61 pixel format and enable IO support for NV16 and NV61 pixel formats

NV16 is an interleaved 4:2:2 8-bit format. There was some internal NV16 support prior to this patch but the pixel format was not publicly accessible. --- libavutil/version.h | 2 +- libswscale/input.c | 1 + libswscale/output.c | 6

Re: [FFmpeg-devel] query on pixel formats

On Thu, Jun 18, 2020 at 3:06 AM Carl Eugen Hoyos wrote: > > Am Mi., 17. Juni 2020 um 23:30 Uhr schrieb Carl Eugen Hoyos > : > > > (A wild guess is that gray8 has to be added to RGB_PIXEL_FORMATS) > > If this is the issue, GRAY_PIXEL_FORMATS have to be added to > yuv_pix_fmts[] > > Carl Eugen > ___

[FFmpeg-devel] About SAMPLE-AES encryption for m3u8

Been trying to figure out how to decrypt SAMPLE-AES and eventually hit an issue with my lack of understanding how H264 and ffmpeg work. Example https://d3iki3eydrtvsa.cloudfront.net/Chernobyl_20200618213021/HLS/Chernobyl_20200618213021_360.m3u8 (might be georestricted) This is what it looks l

[FFmpeg-devel] [PATCH]lavfi/subtitles: Fix subtitles default for ass option shaping

Hi! Attached patch fixes ticket #8738 (and #3165) for me. Please comment, Carl Eugen From bfec36f899629a14521646f785d736fcb4c6aee0 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sat, 20 Jun 2020 19:25:30 +0200 Subject: [PATCH] lavfi/subtitles: Fix the default value for the ass option sha

[FFmpeg-devel] [PATCH] avformat: AMQP: add option delivery_mode

Signed-off-by: Levis Florian --- doc/protocols.texi| 15 +++ libavformat/libamqp.c | 6 +- 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/doc/protocols.texi b/doc/protocols.texi index 7aa758541c..2e15925eeb 100644 --- a/doc/protocols.texi +++ b/doc/protocols.t

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/mpeg12dec: do not discard older a53 captions

> ffmpeg | branch: master | Paul B Mahol > | Sat Jun 20 15:02:48 > 2020 +0200| [29ea4e1b3c511de0a406722bcfffa11604745451] | committer: Paul B > Mahol > > avcodec/mpeg12dec: do not discard older a53 captions > > Fixes #6105. > > >/http://git.vide

Re: [FFmpeg-devel] [PATCH] avformat: AMQP: add option delivery_mode

On Sat, 20. Jun 12:28, Florian Levis wrote: > (re-sending, forgot list, sorry Andriy for double sending) > > Hi Andriy, > > > Is the goal of the non-persistent option to reduce disk io, or something > else? > > I ran a quick test to look at disk io, but didn't see a difference. > > TL;DR > -> it

Re: [FFmpeg-devel] [PATCH] avutil/timecode: fix sscanf format string with garbage at the end

On Sat, Jun 20, 2020 at 05:35:23PM +0200, Nicolas George wrote: > lance.lmw...@gmail.com (12020-06-20): > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavutil/timecode.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > I doubt this was actually tested. I'm te

Re: [FFmpeg-devel] [PATCH] avutil/timecode: fix sscanf format string with garbage at the end

lance.lmw...@gmail.com (12020-06-20): > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavutil/timecode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I doubt this was actually tested. Regards, -- Nicolas George signature.asc Description: PGP signature _

[FFmpeg-devel] [PATCH] avutil/timecode: fix sscanf format string with garbage at the end

From: Limin Wang Signed-off-by: Limin Wang --- libavutil/timecode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/timecode.c b/libavutil/timecode.c index 60077ba..1facc41 100644 --- a/libavutil/timecode.c +++ b/libavutil/timecode.c @@ -196,7 +196,7 @@ int av_time

Re: [FFmpeg-devel] [PATCH 3/4] avutil/timecode: add function av_timecode_get_smpte_by_tc_string()

On Sat, Jun 20, 2020 at 02:51:59PM +0200, Nicolas George wrote: > lance.lmw...@gmail.com (12020-06-20): > > av_timecode_init_from_string() will initialize the AVTimecode structure, > > it'll do more functions, if don't duplicate the code. I can do like below: > > 1. use av_timecode_init_from_string

[FFmpeg-devel] [PATCH v2 1/2] API: add AV_PKT_DATA_S12M_TIMECODE to AVPacketSideDataType

From: Limin Wang Signed-off-by: Limin Wang --- doc/APIchanges| 3 +++ libavcodec/avpacket.c | 1 + libavcodec/decode.c | 1 + libavcodec/packet.h | 8 libavcodec/version.h | 2 +- libavformat/dump.c| 22 ++ 6 files changed, 36 insertions(+), 1

[FFmpeg-devel] [PATCH v2 2/2] avdevice/decklink_dec: export timecode with s12m side data

From: Limin Wang Signed-off-by: Limin Wang --- libavdevice/decklink_dec.cpp | 16 1 file changed, 16 insertions(+) diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp index 82106aa..c8064ae 100644 --- a/libavdevice/decklink_dec.cpp +++ b/libavdevice/deckli

Re: [FFmpeg-devel] [PATCH 4/5] lavf/matroskaenc: mux WebVTT using standard (non-WebM) formatting

> On Jun 20, 2020, at 04:12, Andreas Rheinhardt > wrote: > > rcombs: >> --- >> libavformat/matroskaenc.c | 30 -- >> 1 file changed, 24 insertions(+), 6 deletions(-) >> >> diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c >> index 63d6b50e6a..94e6cc

Re: [FFmpeg-devel] [PATCH 3/5] lavf/matroskadec: support standard (non-WebM) WebVTT formatting

Nicolas George: > Andreas Rheinhardt (12020-06-20): >> Unfortunately all pointer arithmetic involving NULL is undefined >> behaviour in C, even NULL + 0. > > I am pretty sure the UB is not there, and that NULL+0 is valid. Do you > have the reference? > C99, 6.5.6 (the part about additive operator

Re: [FFmpeg-devel] [PATCH 3/4] avutil/timecode: add function av_timecode_get_smpte_by_tc_string()

lance.lmw...@gmail.com (12020-06-20): > av_timecode_init_from_string() will initialize the AVTimecode structure, > it'll do more functions, if don't duplicate the code. I can do like below: > 1. use av_timecode_init_from_string() to init the tc > 2. use av_timecode_get_smpte_from_framenum() to get

Re: [FFmpeg-devel] [PATCH 3/4] avutil/timecode: add function av_timecode_get_smpte_by_tc_string()

On Sat, Jun 20, 2020 at 02:28:39PM +0200, Nicolas George wrote: > lance.lmw...@gmail.com (12020-06-20): > > No, different function, if I can use it, then I'll use it. > > Duplicating parsing code is a big no. av_timecode_init_from_string() will initialize the AVTimecode structure, it'll do more fu

Re: [FFmpeg-devel] [PATCH 1/4] avfilter/vf_drawtext: add option to draw timecode in S12M side data

lance.lmw...@gmail.com (12020-06-20): > Thanks for the suggestion, I have changed to use metadata to display the > timecode without > any change to vf_drawtext.c. So please ignore the patch, I'll submit > timecode metadata > patchset for h264/hevc later. If you are sure it is a good idea to do

Re: [FFmpeg-devel] [PATCH 1/4] avfilter/vf_drawtext: add option to draw timecode in S12M side data

On Fri, Jun 19, 2020 at 04:45:34PM +0200, Nicolas George wrote: > lance.lmw...@gmail.com (12020-06-19): > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > doc/filters.texi | 4 > > libavfilter/vf_drawtext.c | 19 +++ > > 2 files changed, 23 inserti

Re: [FFmpeg-devel] [PATCH 3/4] avutil/timecode: add function av_timecode_get_smpte_by_tc_string()

lance.lmw...@gmail.com (12020-06-20): > No, different function, if I can use it, then I'll use it. Duplicating parsing code is a big no. > do you have a broken string for my condition, I'm glad to test and fix it? Any valid string with anything appended at the end. Regards, -- Nicolas Georg

Re: [FFmpeg-devel] [PATCH] doc/encoders: fix the misleading usage of profile

On Sat, Jun 20, 2020 at 10:18:58AM +0530, Gyan Doshi wrote: > > On 20-06-2020 06:33 am, lance.lmw...@gmail.com wrote: > > On Sat, Jun 20, 2020 at 07:29:11AM +0800, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > > > users are getting mislead by the integer, although profile > > > ca

Re: [FFmpeg-devel] [PATCH] avformat: AMQP: add option delivery_mode

(re-sending, forgot list, sorry Andriy for double sending) Hi Andriy, > Is the goal of the non-persistent option to reduce disk io, or something else? > I ran a quick test to look at disk io, but didn't see a difference. TL;DR -> it have effect on the broker (ex: RabbitMQ) -> it should not have

Re: [FFmpeg-devel] [PATCH 3/5] lavf/matroskadec: support standard (non-WebM) WebVTT formatting

Andreas Rheinhardt (12020-06-20): > Unfortunately all pointer arithmetic involving NULL is undefined > behaviour in C, even NULL + 0. I am pretty sure the UB is not there, and that NULL+0 is valid. Do you have the reference? Anyway, even if it is valid, it is not good style, I agree on that. Reg

Re: [FFmpeg-devel] [PATCH 1/5] lavf: matroska subtitle muxer

rcombs (12020-06-17): > --- > configure | 1 + > libavformat/allformats.c | 1 + > libavformat/matroskaenc.c | 30 ++ > libavformat/version.h | 4 ++-- > 4 files changed, 34 insertions(+), 2 deletions(-) Please take into account the comments tha

[FFmpeg-devel] [PATCH v4 3/6] avcodec: add adpcm_ima_apm encoder

Signed-off-by: Zane van Iperen --- doc/general.texi | 2 +- libavcodec/Makefile| 1 + libavcodec/adpcmenc.c | 34 -- libavcodec/allcodecs.c | 1 + libavcodec/utils.c | 1 + 5 files changed, 36 insertions(+), 3 deletions(-) diff --git a/doc/gener

[FFmpeg-devel] [PATCH v4 6/6] avcodec/adpcmenc: cleanup trellis checks

Signed-off-by: Zane van Iperen --- libavcodec/adpcmenc.c | 35 ++- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/libavcodec/adpcmenc.c b/libavcodec/adpcmenc.c index e15fcc5768..0242a52756 100644 --- a/libavcodec/adpcmenc.c +++ b/libavcodec/adpcmen

[FFmpeg-devel] [PATCH v4 5/6] fate: add adpcm_ima_apm encoding test

Signed-off-by: Zane van Iperen --- tests/fate/acodec.mak | 2 ++ tests/ref/acodec/adpcm-ima_apm | 4 2 files changed, 6 insertions(+) create mode 100644 tests/ref/acodec/adpcm-ima_apm diff --git a/tests/fate/acodec.mak b/tests/fate/acodec.mak index bb6bfe5ada..197b6ed7c0 100644 --

[FFmpeg-devel] [PATCH v4 4/6] avformat: add apm muxer

Signed-off-by: Zane van Iperen --- Changelog| 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/apm.c| 110 ++- 4 files changed, 111 insertions(+), 2 deletions(-) diff --git a/Changelog b/Changelog i

[FFmpeg-devel] [PATCH v4 2/6] avformat/apm: use new extradata format

Signed-off-by: Zane van Iperen --- libavformat/Makefile | 2 +- libavformat/apm.c| 130 +++ 2 files changed, 70 insertions(+), 62 deletions(-) diff --git a/libavformat/Makefile b/libavformat/Makefile index 26af859a28..a4113fe644 100644 --- a/libavfor

[FFmpeg-devel] [PATCH v4 0/6] adpcm_ima_apm encoder + apm muxer

Add support for encoding adpcm_ima_apm and muxing to apm. v4: - fix rebase issues v3: [4][5][6] * Support both extradata formats - fixes FATE failure + preserves compatibility * EINVAL->ERANGE v2: [1][2][3] * fix mixed declarations and code * remove unused variable * fix array initialisation

[FFmpeg-devel] [PATCH v4 1/6] avcodec/adpcm_ima_apm: support new extradata format

Signed-off-by: Zane van Iperen --- libavcodec/adpcm.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index 79c5d625d1..4de4a23289 100644 --- a/libavcodec/adpcm.c +++ b/libavcodec/adpcm.c @@ -162,11 +162,18 @@ static a

Re: [FFmpeg-devel] [PATCH 2/5] lavf/webvtt: preserve comments

rcombs: > --- > libavcodec/avpacket.c | 1 + > libavcodec/packet.h | 6 ++ > libavformat/webvttdec.c | 25 ++--- > libavformat/webvttenc.c | 10 -- > 4 files changed, 37 insertions(+), 5 deletions(-) > > diff --git a/libavcodec/avpacket.c b/libavcodec/avpac

Re: [FFmpeg-devel] [PATCH 4/5] lavf/matroskaenc: mux WebVTT using standard (non-WebM) formatting

rcombs: > --- > libavformat/matroskaenc.c | 30 -- > 1 file changed, 24 insertions(+), 6 deletions(-) > > diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c > index 63d6b50e6a..94e6cc542a 100644 > --- a/libavformat/matroskaenc.c > +++ b/libavformat/matr

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/ccaption_dec: allow selection of second field captions

On 6/20/20, Michael Niedermayer wrote: > On Fri, Jun 19, 2020 at 04:26:49PM +0200, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/ccaption_dec.c | 15 --- >> 1 file changed, 12 insertions(+), 3 deletions(-) > > this appears to make the output of the following

[FFmpeg-devel] [PATCH] avformat/webvttdec: Accept \r as newline

After parsing the end timestamp of a WebVTT cue block, the current code skips everything after the start of the timestamp that is not a \t, ' ' or \n and treats what is next as the start of a WebVTT cue settings list. Yet if there is no such list, but a single \r, this will skip a part of the cue p

Re: [FFmpeg-devel] [PATCH 3/5] lavf/matroskadec: support standard (non-WebM) WebVTT formatting

rcombs: > Fixes ticket #5641 > --- > libavformat/matroska.c| 11 ++-- > libavformat/matroskadec.c | 111 -- > 2 files changed, 77 insertions(+), 45 deletions(-) > > diff --git a/libavformat/matroska.c b/libavformat/matroska.c > index 7c56aba403..962fa496f4