Re: [FFmpeg-devel] [PATCH] libavformat/mov: restore use of mfra time as dts

2020-04-08 Thread Gyan Doshi
On 06-04-2020 11:12 pm, John Stebbins wrote: This was inadvertantly removed in 4a9d32baca --- libavformat/mov.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 16a40debc7..eee98fb69c 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @

Re: [FFmpeg-devel] 回复: [EXT] Re: [PATCH] avcodec/v4l2_buffers: don't prevent enqueue capture buffer to driver

2020-04-08 Thread Andriy Gelman
On Thu, 09. Apr 02:14, Ming Qian wrote: > Did you try increasing the -num_capture_buffers option? It may solve your > problem. > 1. We can't increase the num_capture_buffers indefinitely. > 2. There is a ring buffer in driver, so the number of frames who is stored in > the ring buffer may be a la

Re: [FFmpeg-devel] 回复: [EXT] Re: [PATCH] avcodec/v4l2_buffers: don't prevent enqueue capture buffer to driver

2020-04-08 Thread Ming Qian
Did you try increasing the -num_capture_buffers option? It may solve your problem. 1. We can't increase the num_capture_buffers indefinitely. 2. There is a ring buffer in driver, so the number of frames who is stored in the ring buffer may be a large value, This depends on the speed of the input

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/v4l2_context: Use av_freep

2020-04-08 Thread Andriy Gelman
On Mon, 06. Apr 09:37, Andreas Rheinhardt wrote: > Andriy Gelman: > > From: Andriy Gelman > > > > Signed-off-by: Andriy Gelman > > --- > > libavcodec/v4l2_context.c | 6 ++ > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/libavcodec/v4l2_context.c b/libavcodec/v4l2_

[FFmpeg-devel] [PATCH v1] avformat/hlsenc: return media_url directly if failed to get seperator

2020-04-08 Thread lance . lmwang
From: Limin Wang Fix ticket: 8606 Signed-off-by: Limin Wang --- libavformat/hlsenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index a29b2625e4..e34833fd89 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -1251,6 +1251,8 @@

Re: [FFmpeg-devel] 回复: [EXT] Re: [PATCH] avcodec/v4l2_buffers: don't prevent enqueue capture buffer to driver

2020-04-08 Thread Andriy Gelman
On Tue, 17. Mar 10:28, Ming Qian wrote: > Yes, I have meet some hang issue on nxp's imx platform. > On nxp's imx platform, there is a stream buffer in the v4l2 decoder driver. > So driver may cache some frames in driver, if without this patch, after the > draining is set to 1, the v4l2 capture buf

Re: [FFmpeg-devel] [PATCH v4] avcodec/v4l2_m2m: handle the v4l2 eos event

2020-04-08 Thread Andriy Gelman
On Wed, 01. Apr 10:38, Ming Qian wrote: > when the last frame of capture is dequeueed, > driver may send this V4L2_EVENT_EOS event, > If this event is received, then the capture buffers have been flushed and > avcodec_receive_packet()/avcodec_receive_frame() can return AVERROR_EOF. > Otherwise, the

Re: [FFmpeg-devel] [PATCH v2 3/7] avformat/hlsenc: Check some unchecked allocations

2020-04-08 Thread Steven Liu
> 2020年2月28日 下午5:53,Andreas Rheinhardt 写道: > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/hlsenc.c | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index a281c379f0..18f40ff3ed 100644 > --- a/libavfo

Re: [FFmpeg-devel] [PATCH 10/23] lavc/movtextdec: allow setting subtitle frame dimensions

2020-04-08 Thread John Stebbins
On Wed, 2020-04-08 at 10:31 -0700, Philip Langdale wrote: > On Mon, 6 Apr 2020 11:52:05 -0600 > John Stebbins wrote: > > > Font sizes are relative to the subtitle frame dimensions. If the > > expected frame dimensions are not known, the font sizes will most > > likely be incorrect. > > --- > > l

Re: [FFmpeg-devel] [PATCH] avfilter/vf_drawtext: only test available exceptions

2020-04-08 Thread Carl Eugen Hoyos
Am Di., 7. Apr. 2020 um 02:46 Uhr schrieb Rosen Penev : > > soft float systems do not define these macros under musl. > > Fixes: Ticket7102 > > Signed-off-by: Rosen Penev > --- > libavfilter/vf_drawtext.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavfilter/vf_drawtext.c b/libav

[FFmpeg-devel] [PATCH 2/2] avcodec/bsf: add av_bsf_join() to chain bitstream filters

2020-04-08 Thread Marton Balint
Signed-off-by: Marton Balint --- doc/APIchanges | 3 +++ libavcodec/avcodec.h | 19 libavcodec/bsf.c | 62 libavcodec/version.h | 2 +- 4 files changed, 85 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b

[FFmpeg-devel] [PATCH 1/2] avcodec/bsf: use simplified algorithm for bsf_list chained filtering

2020-04-08 Thread Marton Balint
Based on the one in ffmpeg.c and it is not using an extra flush_idx variable. Signed-off-by: Marton Balint --- libavcodec/bsf.c | 64 ++-- 1 file changed, 25 insertions(+), 39 deletions(-) diff --git a/libavcodec/bsf.c b/libavcodec/bsf.c index

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: adapt to the new internal encode API

2020-04-08 Thread Marton Balint
On Wed, 8 Apr 2020, Philip Langdale wrote: On Wed, 8 Apr 2020 14:58:36 -0300 James Almer wrote: Signed-off-by: James Almer --- This removes the encode2() implementation as it'll never be used if a receive_packet() one exists, and the flush() implementation since according to Anton Khirnov

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: adapt to the new internal encode API

2020-04-08 Thread Philip Langdale
On Wed, 8 Apr 2020 14:58:36 -0300 James Almer wrote: > Signed-off-by: James Almer > --- > This removes the encode2() implementation as it'll never be used if a > receive_packet() one exists, and the flush() implementation since > according to Anton Khirnov avcodec_flush_buffers() is not meant t

Re: [FFmpeg-devel] [PATCH 1/8] fftools/ffmpeg: also flush encoders which have a variable frame size

2020-04-08 Thread Marton Balint
On Sat, 28 Mar 2020, Marton Balint wrote: Signed-off-by: Marton Balint --- fftools/ffmpeg.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index aaaf241314..6cc3c5a14d 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -1913,9 +1913,6 @@ static v

[FFmpeg-devel] [PATCH v3 7/7] avformat/hlsenc: Cosmetics

2020-04-08 Thread Andreas Rheinhardt
Mainly includes reindentation and returning directly (i.e. without a goto fail when possible). Signed-off-by: Andreas Rheinhardt --- This new version was made necessary by 99ebb033. The rest of the patchset still applies. libavformat/hlsenc.c | 129 +-- 1

Re: [FFmpeg-devel] [PATCH] avformat/segment: always use interleaved writes for formats with custom interleaving

2020-04-08 Thread Marton Balint
On Tue, 7 Apr 2020, Marton Balint wrote: On Wed, 1 Apr 2020, Marton Balint wrote: Signed-off-by: Marton Balint --- libavformat/segment.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/segment.c b/libavformat/segment.c index 2a838c7da7..60b72b7d15 100644 -

Re: [FFmpeg-devel] movtext decode/encode improvements

2020-04-08 Thread Philip Langdale
On Tue, 7 Apr 2020 14:38:52 + John Stebbins wrote: > > After checking carefully, patches 10 and 23 are as I want them. Sizes > are relative to 288 when using override APIs, but are relative to > PlayResY when processing the script. > > On the other hand, patch 20 needs a fix. If the cancel

Re: [FFmpeg-devel] [PATCH 22/23] lavc/movtextenc: add font name handling

2020-04-08 Thread Philip Langdale
On Mon, 6 Apr 2020 11:52:17 -0600 John Stebbins wrote: > Initializes the mov text sample description from the ASS header and > creates an mov font table from the fonts available in the ASS Styles. > --- > libavcodec/ass_split.c | 5 + > libavcodec/ass_split.h | 8 ++ > libavcodec/movtexten

Re: [FFmpeg-devel] [PATCH 23/23] lavc/movtextenc: add option to scale fontsize with height

2020-04-08 Thread Philip Langdale
On Mon, 6 Apr 2020 11:52:18 -0600 John Stebbins wrote: > If the video dimensions are different than the ASS play_res then the > font sizes need to be adjusted to get the same apparent render size. > --- > libavcodec/movtextenc.c | 30 +- > 1 file changed, 29 insertion

Re: [FFmpeg-devel] [PATCH 21/23] lavc/movtextenc: simplify initialization of new style record

2020-04-08 Thread Philip Langdale
On Mon, 6 Apr 2020 11:52:16 -0600 John Stebbins wrote: > --- > libavcodec/movtextenc.c | 13 - > 1 file changed, 4 insertions(+), 9 deletions(-) > > diff --git a/libavcodec/movtextenc.c b/libavcodec/movtextenc.c > index 2e65489c4d..167dffee6a 100644 > --- a/libavcodec/movtextenc.c >

Re: [FFmpeg-devel] [PATCH 20/23] lavc/movtextenc: handle cancel overrides callback

2020-04-08 Thread Philip Langdale
On Tue, 7 Apr 2020 09:00:34 -0600 John Stebbins wrote: > --- > libavcodec/movtextenc.c | 43 > - 1 file changed, 34 > insertions(+), 9 deletions(-) > > diff --git a/libavcodec/movtextenc.c b/libavcodec/movtextenc.c > index 9e657c9635..2d3c416407 100644 > -

Re: [FFmpeg-devel] [PATCH 19/23] lavc/movtextenc: add font size tag handling

2020-04-08 Thread Philip Langdale
On Mon, 6 Apr 2020 11:52:14 -0600 John Stebbins wrote: > --- > libavcodec/movtextenc.c | 39 ++- > 1 file changed, 30 insertions(+), 9 deletions(-) > > diff --git a/libavcodec/movtextenc.c b/libavcodec/movtextenc.c > index e82393dde7..9e657c9635 100644 > ---

Re: [FFmpeg-devel] [PATCH 18/23] lavc/movtextenc: add alpha tag handling

2020-04-08 Thread Philip Langdale
On Mon, 6 Apr 2020 11:52:13 -0600 John Stebbins wrote: > --- > libavcodec/movtextenc.c | 25 - > 1 file changed, 24 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/movtextenc.c b/libavcodec/movtextenc.c > index 090536b887..e82393dde7 100644 > --- a/libavcodec/mo

Re: [FFmpeg-devel] [PATCH 17/23] lavc/movtextenc: add color tag handling

2020-04-08 Thread Philip Langdale
On Mon, 6 Apr 2020 11:52:12 -0600 John Stebbins wrote: > --- > libavcodec/movtextenc.c | 28 > 1 file changed, 24 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/movtextenc.c b/libavcodec/movtextenc.c > index 4e7d55efcb..090536b887 100644 > --- a/libavcode

Re: [FFmpeg-devel] [PATCH 16/23] lavc/movtextenc: init style record from ASS dialog style

2020-04-08 Thread Philip Langdale
On Mon, 6 Apr 2020 11:52:11 -0600 John Stebbins wrote: > --- > libavcodec/movtextenc.c | 60 > ++--- 1 file changed, 50 > insertions(+), 10 deletions(-) > > diff --git a/libavcodec/movtextenc.c b/libavcodec/movtextenc.c > index d389111419..4e7d55efcb 100644 >

[FFmpeg-devel] [PATCH] avcodec: add MV30 decoder

2020-04-08 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 7 + libavcodec/mv30.c | 749 libavformat/riff.c | 1 + 6 files changed, 760 inserti

[FFmpeg-devel] [PATCH] avcodec/nvenc: adapt to the new internal encode API

2020-04-08 Thread James Almer
Signed-off-by: James Almer --- This removes the encode2() implementation as it'll never be used if a receive_packet() one exists, and the flush() implementation since according to Anton Khirnov avcodec_flush_buffers() is not meant to be used with encoders, where its behavior is undefined. libavc

Re: [FFmpeg-devel] [PATCH 5/5] avformat/mpeg: Don't use unintialized value

2020-04-08 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Andreas Rheinhardt: >> Michael Niedermayer: >>> On Sun, Jan 19, 2020 at 02:43:00PM +, Andreas Rheinhardt wrote: Michael Niedermayer: > On Tue, Oct 22, 2019 at 03:16:45PM +0200, Andreas Rheinhardt wrote: >> vobsub_read_packet() didn't check whether an index in

Re: [FFmpeg-devel] [PATCH 12/14] avformat/matroskasem: reorder some EbmlSyntax elements

2020-04-08 Thread Andreas Rheinhardt
Steve Lhomme: > From: Steve Lhomme > > So it's easier to match with the XSLT ordering which has limited possibilities > (15 max criteria for all the syntax tables). > I don't know XSLT at all, but this already raises alarm bells: If this is so restricted, then this whole approach might be a non-

Re: [FFmpeg-devel] [PATCH 11/23] lavc/ass_split: fix parsing utf8 scripts

2020-04-08 Thread Philip Langdale
On Mon, 6 Apr 2020 12:35:32 -0600 John Stebbins wrote: > The [Script Info] section was skipped if starts with UTF8 BOM > --- > libavcodec/ass_split.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/ass_split.c b/libavcodec/ass_split.c > index 67da7c6d84..c2c388d9f0 100644

Re: [FFmpeg-devel] [PATCH 10/23] lavc/movtextdec: allow setting subtitle frame dimensions

2020-04-08 Thread Philip Langdale
On Mon, 6 Apr 2020 11:52:05 -0600 John Stebbins wrote: > Font sizes are relative to the subtitle frame dimensions. If the > expected frame dimensions are not known, the font sizes will most > likely be incorrect. > --- > libavcodec/ass.c| 30 +++--- > libavcodec/a

Re: [FFmpeg-devel] [PATCH v14] libavcodec/jpeg2000dec.c: Add support for PPT marker

2020-04-08 Thread Michael Niedermayer
On Tue, Apr 07, 2020 at 10:27:13PM +0530, gautamr...@gmail.com wrote: > From: Gautam Ramakrishnan > > This patch adds functional changes to support the > PPT marker. This patch fixes bug ticket #4610. > --- > libavcodec/jpeg2000dec.c | 91 +++- > 1 file change

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: Disable copy_ts on timestamp wraparound

2020-04-08 Thread Gyan Doshi
On 05-04-2020 01:51 am, Michael Niedermayer wrote: On Fri, May 03, 2019 at 05:36:07PM +0200, Michael Niedermayer wrote: This allows handling more than 26.5h of mpeg* input Fixes: Ticket 7876 Signed-off-by: Michael Niedermayer --- fftools/ffmpeg.c | 13 - 1 file changed, 12 ins

Re: [FFmpeg-devel] [PATCH 11/14] avformat/matroskasem: reorder EbmlSyntax tables

2020-04-08 Thread Andreas Rheinhardt
Steve Lhomme: > From: Steve Lhomme > > So they are sorted by their EBML path, in reverse order so we don't extra > declarations. A parent and a child reference each other (in most instances), so I don't see how you would avoid forward declarations at all. (If the forward declarations were avoida

Re: [FFmpeg-devel] [PATCH 10/14] avformat/matroskadec: move the elements semantic in a separate file

2020-04-08 Thread Andreas Rheinhardt
Steve Lhomme: > From: Steve Lhomme > > So the file can be generated from the Matroska Schema. > > The EbmlSyntax structures are not shared between files. > matroska_segments and matroska_cluster_enter also have their size predefined. > > No functional changes. > --- > libavformat/Makefile

Re: [FFmpeg-devel] [PATCH v1 1/4] avformat/hlsenc: remove the first slash of the relative path line in the master m3u8 file

2020-04-08 Thread Steven Liu
> 2020年3月29日 下午4:20,Steven Liu 写道: > > >> 2020年3月26日 下午9:56,lance.lmw...@gmail.com 写道: >> >> From: Limin Wang >> >> Please testing with the following command: >> ./ffmpeg -y -i input.mkv \ >> -b:v:0 5250k -c:v h264 -pix_fmt yuv420p -profile:v main -level 4.1 \ >> -b:a:0 256k \ >> -c:a mp2 -

Re: [FFmpeg-devel] [PATCH v1 1/4] avformat/hlsenc: remove the first slash of the relative path line in the master m3u8 file

2020-04-08 Thread Steven Liu
> 2020年3月29日 下午4:20,Steven Liu 写道: > > >> 2020年3月26日 下午9:56,lance.lmw...@gmail.com 写道: >> >> From: Limin Wang >> >> Please testing with the following command: >> ./ffmpeg -y -i input.mkv \ >> -b:v:0 5250k -c:v h264 -pix_fmt yuv420p -profile:v main -level 4.1 \ >> -b:a:0 256k \ >> -c:a mp2 -

Re: [FFmpeg-devel] [PATCH v1 4/4] avformat/hlsenc: use av_asprintf()

2020-04-08 Thread Steven Liu
> 2020年3月29日 下午4:32,Steven Liu 写道: > > >> 2020年3月26日 下午9:57,lance.lmw...@gmail.com 写道: >> >> From: Limin Wang >> >> Signed-off-by: Limin Wang >> --- >> libavformat/hlsenc.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/libavformat/hlsenc.c b/libavformat/hls

Re: [FFmpeg-devel] [PATCH v1 4/4] avformat/hlsenc: use av_asprintf()

2020-04-08 Thread Steven Liu
> 2020年4月8日 下午10:48,Nicolas George 写道: > > Steven Liu (12020-04-08): >> I cannot get the mean of BPrint where should or when should use it, maybe >> you can introduce it, >> I always think BPrint is used to instead of av_[a]sprintf, >> because I saw mkver submit 3 patches to modify from snpri

Re: [FFmpeg-devel] [PATCH 2/3] avformat/hlsenc: Use AVBPrint to avoid allocations of strings

2020-04-08 Thread Nicolas George
Andreas Rheinhardt (12020-04-08): > when deleting old segments. Your commit message got wrapped. ;-) I do not maintain this part of the code. The use of BPrint seems ok, not changing the semantic. > > Signed-off-by: Andreas Rheinhardt > --- > Further todos for this function: > 1. Allocating vt

Re: [FFmpeg-devel] [PATCH v1 4/4] avformat/hlsenc: use av_asprintf()

2020-04-08 Thread Nicolas George
Steven Liu (12020-04-08): > I cannot get the mean of BPrint where should or when should use it, maybe you > can introduce it, > I always think BPrint is used to instead of av_[a]sprintf, > because I saw mkver submit 3 patches to modify from snprintf to BPrint BPrint brings three benefits: - It

Re: [FFmpeg-devel] [PATCH v2] avformat/dashdec: add attribute lang for audio and subtitle streams

2020-04-08 Thread Steven Liu
> 2020年3月31日 下午8:20,Steven Liu 写道: > > There should have language in the metadata of streams which show to user > > Signed-off-by: Steven Liu > --- > libavformat/dashdec.c | 49 +++ > 1 file changed, 45 insertions(+), 4 deletions(-) > > diff --git a/lib

Re: [FFmpeg-devel] [PATCH v1 4/4] avformat/hlsenc: use av_asprintf()

2020-04-08 Thread Andreas Rheinhardt
Steven Liu: > > >> 2020年3月26日 下午9:57,lance.lmw...@gmail.com 写道: >> >> From: Limin Wang >> >> Signed-off-by: Limin Wang >> --- >> libavformat/hlsenc.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c >> index d7b9c0e20a..69

Re: [FFmpeg-devel] [PATCH v1 4/4] avformat/hlsenc: use av_asprintf()

2020-04-08 Thread Steven Liu
> 2020年4月8日 下午10:32,Nicolas George 写道: > > Steven Liu (12020-04-08): >> As mkver suggestion, perhaps use bprint is better, is it? > > It does not seem like a situation where BPrint is beneficial. I cannot get the mean of BPrint where should or when should use it, maybe you can introduce it,

Re: [FFmpeg-devel] why ffmpeg not work

2020-04-08 Thread Dennis Mungai
On Wed, 8 Apr 2020, 12:51 Nicolas George, wrote: > Dennis Mungai (12020-04-08): > > This should do: > > No, it won't do. This question belongs to ffmpeg-user, not ffmpeg-devel. > > Regards, > > -- > Nicolas George > To the OP: Please move your question to the ffmpeg-user mailing list and the t

Re: [FFmpeg-devel] [PATCH v1 4/4] avformat/hlsenc: use av_asprintf()

2020-04-08 Thread Nicolas George
Steven Liu (12020-04-08): > As mkver suggestion, perhaps use bprint is better, is it? It does not seem like a situation where BPrint is beneficial. Other filename handling functions in this HLS code would, though. Regards, -- Nicolas George signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH v1 4/4] avformat/hlsenc: use av_asprintf()

2020-04-08 Thread Steven Liu
> 2020年3月26日 下午9:57,lance.lmw...@gmail.com 写道: > > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavformat/hlsenc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index d7b9c0e20a..694dab42dd 100644 > --- a/

Re: [FFmpeg-devel] [PATCH 1/3] avformat/hlsenc: Fix memleak when deleting old segments

2020-04-08 Thread Steven Liu
> 2020年4月8日 下午9:35,Andreas Rheinhardt 写道: > > From: Andreas Rheinhardt > Date: Wed, 8 Apr 2020 13:14:17 +0200 > Subject: [PATCH 2/3] avformat/hlsenc: Use AVBPrint to avoid allocations of > strings > > when deleting old segments. > > Signed-off-by: Andreas Rheinhardt > --- > Further todos fo

Re: [FFmpeg-devel] [PATCH 2/3] avformat/hlsenc: Use AVBPrint to avoid allocations of strings

2020-04-08 Thread Steven Liu
> 2020年4月8日 下午9:48,Andreas Rheinhardt 写道: > > when deleting old segments. > > Signed-off-by: Andreas Rheinhardt > --- > Further todos for this function: > 1. Allocating vtt_dirname_r in order to get vtt_dirname is actually a > waste. One would need a dirname to AVBPrint function to avoid it.

Re: [FFmpeg-devel] [PATCH 1/3] avformat/hlsenc: Fix memleak when deleting old segments

2020-04-08 Thread Steven Liu
> 2020年4月8日 下午9:35,Andreas Rheinhardt 写道: > > if the directory name of the segments contains "%v". > > This memleak is caused by masking the pointer that will eventually > be freed by a variable of the same name in a smaller scope. > Therefore the pointer that gets freed is always NULL when it

Re: [FFmpeg-devel] [PATCH 3/3] avformat/hlsenc: Factor out deleting files from deleting segments

2020-04-08 Thread Steven Liu
> 2020年4月8日 下午9:35,Andreas Rheinhardt 写道: > > Removes code duplication. > > Signed-off-by: Andreas Rheinhardt > --- > This will make hls_delete_old_segments() return 1 when io_open fails and > IO errors are ignored, but the only caller of hls_delete_old_segments() > (namely hls_append_segment

Re: [FFmpeg-devel] [PATCH v2 2/3] avfilter/vf_mix: Check sscanf() return value

2020-04-08 Thread Limin Wang
On Sun, Mar 29, 2020 at 11:18:11AM +0200, Nicolas George wrote: > Limin Wang (12020-03-29): > > OK, update the patch to print a message and return error. > > Thanks. I have no objection to that new version, but I do not maintain > that code. ping for the patchset for merge. > > Regards, > > --

Re: [FFmpeg-devel] [PATCH v1] avfilter/src_movie: Fix the loop function of dynamic logo

2020-04-08 Thread Limin Wang
ping this patch for review. On Tue, Mar 17, 2020 at 06:55:00PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > The following command will attempt to create the input and overlay test > sequence for you. > ./ffmpeg -f lavfi -i color=white:duration=100:r=25:size=1280x720 input.mkv

Re: [FFmpeg-devel] [PATCH v9 3/4] avfilter/vf_showinfo: display H.26[45] user data unregistered sei message

2020-04-08 Thread Limin Wang
ping this patch for merge, it'll dump the metadata and don't change API. On Tue, Mar 17, 2020 at 06:54:08PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavfilter/vf_showinfo.c | 37 + > 1 file changed, 37

[FFmpeg-devel] [PATCH 2/3] avformat/hlsenc: Use AVBPrint to avoid allocations of strings

2020-04-08 Thread Andreas Rheinhardt
when deleting old segments. Signed-off-by: Andreas Rheinhardt --- Further todos for this function: 1. Allocating vtt_dirname_r in order to get vtt_dirname is actually a waste. One would need a dirname to AVBPrint function to avoid it. 2. replace_*_data_in_filename already work with AVBPrints inte

Re: [FFmpeg-devel] [PATCH 1/3] avcodec.h: split AVPacket API into its own header

2020-04-08 Thread James Almer
On 4/8/2020 4:42 AM, Anton Khirnov wrote: > --- > doc/APIchanges| 3 + > libavcodec/Makefile | 1 + > libavcodec/avcodec.h | 688 +--- > libavcodec/avpacket.c | 3 +- > libavcodec/packet.h | 713 ++ > li

[FFmpeg-devel] [PATCH 1/3] avformat/hlsenc: Fix memleak when deleting old segments

2020-04-08 Thread Andreas Rheinhardt
if the directory name of the segments contains "%v". This memleak is caused by masking the pointer that will eventually be freed by a variable of the same name in a smaller scope. Therefore the pointer that gets freed is always NULL when it is freed and the allocated data leaks. Signed-off-by: An

[FFmpeg-devel] [PATCH 3/3] avformat/hlsenc: Factor out deleting files from deleting segments

2020-04-08 Thread Andreas Rheinhardt
Removes code duplication. Signed-off-by: Andreas Rheinhardt --- This will make hls_delete_old_segments() return 1 when io_open fails and IO errors are ignored, but the only caller of hls_delete_old_segments() (namely hls_append_segment()) doesn't care. libavformat/hlsenc.c | 52

[FFmpeg-devel] [PATCH 1/3] avformat/hlsenc: Fix memleak when deleting old segments

2020-04-08 Thread Andreas Rheinhardt
From: Andreas Rheinhardt Date: Wed, 8 Apr 2020 13:14:17 +0200 Subject: [PATCH 2/3] avformat/hlsenc: Use AVBPrint to avoid allocations of strings when deleting old segments. Signed-off-by: Andreas Rheinhardt --- Further todos for this function: 1. Allocating vtt_dirname_r in order to get vtt_di

Re: [FFmpeg-devel] [PATCH 3/3] avcodec.h: split AVCodecDescriptor API into its own header

2020-04-08 Thread James Almer
On 4/8/2020 4:42 AM, Anton Khirnov wrote: > --- > doc/APIchanges | 3 +- > libavcodec/avcodec.h| 92 + > libavcodec/codec_desc.c | 4 +- > libavcodec/codec_desc.h | 128 > 4 files changed, 134 insertions(+), 93

Re: [FFmpeg-devel] [PATCH 2/3] avcodec.h: split codec IDs into their own header

2020-04-08 Thread James Almer
On 4/8/2020 4:42 AM, Anton Khirnov wrote: > --- > doc/APIchanges| 3 +- > libavcodec/Makefile | 1 + > libavcodec/avcodec.h | 529 +-- > libavcodec/codec_id.h | 560 ++ > 4 files changed, 564 insertions(+),

Re: [FFmpeg-devel] [PATCH v2] avformat/dashenc: remove the arbitrary restrictions for filename

2020-04-08 Thread Nicolas George
Andreas Rheinhardt (12020-04-08): > You are commenting on an outdated version of this patch (and saying much > the same as I did). Current version is [1]. I made the same comment as you on the same patch as you because I had not seen your comment at the time I sent. Regards, -- Nicolas George

Re: [FFmpeg-devel] [PATCH v2] avformat/dashenc: remove the arbitrary restrictions for filename

2020-04-08 Thread Andreas Rheinhardt
Nicolas George: > lance.lmw...@gmail.com (12020-04-08): >> From: Limin Wang >> >> Signed-off-by: Limin Wang >> --- >> libavformat/dashenc.c | 28 >> 1 file changed, 12 insertions(+), 16 deletions(-) >> >> diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c >>

Re: [FFmpeg-devel] why ffmpeg not work

2020-04-08 Thread Nicolas George
Dennis Mungai (12020-04-08): > This should do: No, it won't do. This question belongs to ffmpeg-user, not ffmpeg-devel. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https

Re: [FFmpeg-devel] avformat/libsrt: Change latency option to milliseconds

2020-04-08 Thread Nicolas George
Maxim Sharabayko (12020-04-08): > You say the ffmpeg's SRT latency option should stay in microseconds. > A motivation for this is to avoid confusion and mismatch between ffmpeg > versions, isn't it? > If so, then what if an additional option "latencyms" would be introduced, and > "latency" option

Re: [FFmpeg-devel] [PATCH 00/10] Patch set for the enhancement of libopenh264 encoder

2020-04-08 Thread Fu, Linjie
> From: Fu, Linjie > Sent: Monday, April 6, 2020 19:15 > To: ffmpeg-devel@ffmpeg.org > Cc: Fu, Linjie > Subject: [PATCH 00/10] Patch set for the enhancement of libopenh264 > encoder > > Docs will be provided later. > > Linjie Fu (10): > lavc/libopenh264enc: Add default qmin/qmax support >

Re: [FFmpeg-devel] [PATCH v2] avformat/dashenc: remove the arbitrary restrictions for filename

2020-04-08 Thread Nicolas George
lance.lmw...@gmail.com (12020-04-08): > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavformat/dashenc.c | 28 > 1 file changed, 12 insertions(+), 16 deletions(-) > > diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c > index 94d4639..f80f6f2 10

Re: [FFmpeg-devel] why ffmpeg not work

2020-04-08 Thread Dennis Mungai
On Wed, 8 Apr 2020 at 11:41, 陈军 wrote: > Hi : > when i use this command > ffmpeg -hwaccel cuda -hwaccel_output_format cuda -extra_hw_frames 2 > -threads 2 -i 333_111017.JPG -pix_fmt yuv420p -f hevc 1.h265 -y >but i get this error: >Impossible to convert between the formats suppor

[FFmpeg-devel] why ffmpeg not work

2020-04-08 Thread 陈军
Hi : when i use this command ffmpeg -hwaccel cuda -hwaccel_output_format cuda -extra_hw_frames 2 -threads 2 -i 333_111017.JPG -pix_fmt yuv420p -f hevc 1.h265 -y but i get this error: Impossible to convert between the formats supported by the filter 'Parsed_null_0' and the filter 'a

Re: [FFmpeg-devel] [PATCH] avformat/libsrt: Change latency option to milliseconds

2020-04-08 Thread Limin Wang
On Wed, Apr 08, 2020 at 09:34:45AM +0200, pkv wrote: > > Le 08/04/2020 à 3:45 am, Limin Wang a écrit : > >On Wed, Apr 08, 2020 at 02:16:23AM +0200, pkv wrote: > >>Hi > >> > >>Le 08/04/2020 à 12:33 am, Limin Wang a écrit : > >>>On Tue, Apr 07, 2020 at 08:25:44PM +0200, pkv wrote: > Hi > >

Re: [FFmpeg-devel] [PATCH] avformat/libsrt: Change latency option to milliseconds

2020-04-08 Thread Jack Waller
On Wed, Apr 8, 2020 at 3:34 PM pkv wrote: > > Le 08/04/2020 à 3:45 am, Limin Wang a écrit : > > On Wed, Apr 08, 2020 at 02:16:23AM +0200, pkv wrote: > >> Hi > >> > >> Le 08/04/2020 à 12:33 am, Limin Wang a écrit : > >>> On Tue, Apr 07, 2020 at 08:25:44PM +0200, pkv wrote: > Hi > >

Re: [FFmpeg-devel] [PATCH v1 1/3] doc/protocols: clarify timeout and latency unit of measurement for SRT

2020-04-08 Thread Limin Wang
ping the patchset. On Tue, Mar 31, 2020 at 10:08:06PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > doc/protocols.texi | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/doc/protocols.texi b/doc/protocols.texi

[FFmpeg-devel] [PATCH 3/3] avcodec.h: split AVCodecDescriptor API into its own header

2020-04-08 Thread Anton Khirnov
--- doc/APIchanges | 3 +- libavcodec/avcodec.h| 92 + libavcodec/codec_desc.c | 4 +- libavcodec/codec_desc.h | 128 4 files changed, 134 insertions(+), 93 deletions(-) create mode 100644 libavcodec/codec_desc

[FFmpeg-devel] [PATCH 1/3] avcodec.h: split AVPacket API into its own header

2020-04-08 Thread Anton Khirnov
--- doc/APIchanges| 3 + libavcodec/Makefile | 1 + libavcodec/avcodec.h | 688 +--- libavcodec/avpacket.c | 3 +- libavcodec/packet.h | 713 ++ libavcodec/version.h | 4 +- 6 files changed, 722 inser

[FFmpeg-devel] [PATCH 2/3] avcodec.h: split codec IDs into their own header

2020-04-08 Thread Anton Khirnov
--- doc/APIchanges| 3 +- libavcodec/Makefile | 1 + libavcodec/avcodec.h | 529 +-- libavcodec/codec_id.h | 560 ++ 4 files changed, 564 insertions(+), 529 deletions(-) create mode 100644 libavcodec/codec_

[FFmpeg-devel] [PATCH v2] avformat/libsrt: Document latency options unit

2020-04-08 Thread pkv
Hi following comments I've removed the change of latency option type to AV_OPT_TYPE_DURATION and restricted the patch to documentation changes. Regards From 059d84df37b6aa6b53d9d8b92b77cd9099760441 Mon Sep 17 00:00:00 2001 From: pkv Date: Tue, 7 Apr 2020 18:08:22 +0200 Subject: [PATCH] avfor

Re: [FFmpeg-devel] [PATCH] avformat/libsrt: Change latency option to milliseconds

2020-04-08 Thread pkv
Le 08/04/2020 à 3:45 am, Limin Wang a écrit : On Wed, Apr 08, 2020 at 02:16:23AM +0200, pkv wrote: Hi Le 08/04/2020 à 12:33 am, Limin Wang a écrit : On Tue, Apr 07, 2020 at 08:25:44PM +0200, pkv wrote: Hi new patch for latency option following the comments from N. George. I recall I had su

Re: [FFmpeg-devel] [PATCH] avformat/libsrt: Change latency option to milliseconds

2020-04-08 Thread Hendrik Leppkes
On Wed, Apr 8, 2020 at 3:46 AM Limin Wang wrote: > > On Wed, Apr 08, 2020 at 02:16:23AM +0200, pkv wrote: > > Hi > > > > Le 08/04/2020 à 12:33 am, Limin Wang a écrit : > > >On Tue, Apr 07, 2020 at 08:25:44PM +0200, pkv wrote: > > >>Hi > > >> > > >>new patch for latency option following the comment

Re: [FFmpeg-devel] [PATCH 02/14] avformat/assdec: Remove unnecessary header

2020-04-08 Thread Andreas Rheinhardt
Andreas Rheinhardt: > libavcodec/internal.h has been included since 36e61e24/67286fa9 for > avpriv_bprint_to_extradata(). The latter function has been replaced > by ff_bprint_to_codecpar_extradata() in 6f69f7a8, making the header > superfluous. > > Signed-off-by: Andreas Rheinhardt > --- > libav