Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: remove MAX_TRACKS limit

2020-04-03 Thread Andreas Rheinhardt
Jan Chren (rindeal): > RnJvbSA0M2U0Yjk2OTVhNDM0MjExMmIxMTE3ZGI2NTI2YmFmYTFmOWRhYjNlIE1vbiBTZXAgMTcg > MDA6MDA6MDAgMjAwMQpGcm9tOiBKYW4gQ2hyZW4gKHJpbmRlYWwpIDxkZXYucmluZGVhbEBnbWFp > bC5jb20+CkRhdGU6IFRodSwgMSBBcHIgMjAyMCAwMDowMDowMCArMDAwMApTdWJqZWN0OiBbUEFU > Q0hdIGF2Zm9ybWF0L21hdHJvc2thZW5jOiByZW1

Re: [FFmpeg-devel] [PATCH]lavf, lavfi: Remove uses of sizeof(char)

2020-04-03 Thread Andreas Rheinhardt
Carl Eugen Hoyos: > Hi! > > Attached patch removes uses of sizeof(char) from libavfilter and libavformat. > > Please comment, Carl Eugen > The commit message is misleading: Actually C is based around sizeof(char) = 1. From the semantics of the sizeof operator: "When applied to an operand that ha

[FFmpeg-devel] [PATCH v1] avformat/movenc: cosmetics

2020-04-03 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/movenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 6db09b7..7140ad3 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -2711,7 +2711,7 @@ static in

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: add matroska subtitle muxer (.mks)

2020-04-03 Thread Steven Liu
> 2020年4月4日 上午9:37,Jan Chren (rindeal) 写道: > > RnJvbSBlYWE5ZjI2ODU0MzY3MjVlMTllYjk0ZTdmMmQwMTc0YmE1NmI3NDI5IE1vbiBTZXAgMTcg > MDA6MDA6MDAgMjAwMQpGcm9tOiBKYW4gQ2hyZW4gKHJpbmRlYWwpIDxkZXYucmluZGVhbEBnbWFp > bC5jb20+CkRhdGU6IFRodSwgMSBBcHIgMjAyMCAwMDowMDowMCArMDAwMApTdWJqZWN0OiBbUEFU > Q0hdIGF2Zm9

[FFmpeg-devel] [PATCH] avformat/matroskaenc: remove MAX_TRACKS limit

2020-04-03 Thread Jan Chren (rindeal)
RnJvbSA0M2U0Yjk2OTVhNDM0MjExMmIxMTE3ZGI2NTI2YmFmYTFmOWRhYjNlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYW4gQ2hyZW4gKHJpbmRlYWwpIDxkZXYucmluZGVhbEBnbWFp bC5jb20+CkRhdGU6IFRodSwgMSBBcHIgMjAyMCAwMDowMDowMCArMDAwMApTdWJqZWN0OiBbUEFU Q0hdIGF2Zm9ybWF0L21hdHJvc2thZW5jOiByZW1vdmUgTUFYX1RSQUNLUyBsaW1pdAoK

[FFmpeg-devel] [PATCH] avformat/matroskaenc: add matroska subtitle muxer (.mks)

2020-04-03 Thread Jan Chren (rindeal)
RnJvbSBlYWE5ZjI2ODU0MzY3MjVlMTllYjk0ZTdmMmQwMTc0YmE1NmI3NDI5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYW4gQ2hyZW4gKHJpbmRlYWwpIDxkZXYucmluZGVhbEBnbWFp bC5jb20+CkRhdGU6IFRodSwgMSBBcHIgMjAyMCAwMDowMDowMCArMDAwMApTdWJqZWN0OiBbUEFU Q0hdIGF2Zm9ybWF0L21hdHJvc2thZW5jOiBhZGQgbWF0cm9za2Egc3VidGl0bGUgbXV4

Re: [FFmpeg-devel] [PATCH v1] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

2020-04-03 Thread Limin Wang
On Fri, Apr 03, 2020 at 11:23:59PM +0200, Michael Niedermayer wrote: > On Fri, Apr 03, 2020 at 11:05:59PM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavformat/mux.c| 16 > > tests/ref/fate/binsub-movtextenc

Re: [FFmpeg-devel] [PATCH v1] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

2020-04-03 Thread Limin Wang
On Fri, Apr 03, 2020 at 05:19:08PM +0200, Andreas Rheinhardt wrote: > lance.lmw...@gmail.com: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavformat/mux.c| 16 > > tests/ref/fate/binsub-movtextenc | 2 +- > > tests/ref/fate/movenc| 5

[FFmpeg-devel] [PATCH v3 2/2] avcodec/mpeg12enc: Support mpeg2 encoder profile with const options

2020-04-03 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- doc/encoders.texi | 8 libavcodec/mpeg12enc.c | 22 +- libavcodec/mpegvideo.h | 1 + 3 files changed, 26 insertions(+), 5 deletions(-) diff --git a/doc/encoders.texi b/doc/encoders.texi index e23b6b3..5022b94 10

Re: [FFmpeg-devel] [PATCH v1 2/2] avcodec/mpeg12enc: Support mpeg2 encoder profile with const options

2020-04-03 Thread Limin Wang
On Fri, Apr 03, 2020 at 03:47:09PM +, Fu, Linjie wrote: > > From: ffmpeg-devel On Behalf Of > > Limin Wang > > Sent: Friday, April 3, 2020 22:55 > > To: ffmpeg-devel@ffmpeg.org > > Subject: Re: [FFmpeg-devel] [PATCH v1 2/2] avcodec/mpeg12enc: Support > > mpeg2 encoder profile with const option

Re: [FFmpeg-devel] [PATCH v10 3/3] libavcodec/jpeg2000dec.c: Fix indentation

2020-04-03 Thread Michael Niedermayer
On Fri, Apr 03, 2020 at 11:57:58PM +0530, gautamr...@gmail.com wrote: > From: Gautam Ramakrishnan > > --- > libavcodec/jpeg2000dec.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC78

Re: [FFmpeg-devel] [PATCH v10 2/3] libavcodec/jpeg2000dec.c: Handle non EOC streams

2020-04-03 Thread Michael Niedermayer
On Fri, Apr 03, 2020 at 11:57:57PM +0530, gautamr...@gmail.com wrote: > From: Gautam Ramakrishnan > > This patch allows decoding of j2k streams which do > not have an EOC marker. > --- > libavcodec/jpeg2000dec.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) will apply thx [.

Re: [FFmpeg-devel] [PATCH v10 1/3] libavcodec/jpeg2000dec.c: Add support for PPT marker

2020-04-03 Thread Michael Niedermayer
On Fri, Apr 03, 2020 at 11:57:56PM +0530, gautamr...@gmail.com wrote: > From: Gautam Ramakrishnan > > This patch adds functional changes to support the > PPT marker. > --- > libavcodec/jpeg2000dec.c | 88 > 1 file changed, 79 insertions(+), 9 deletions(-)

[FFmpeg-devel] [PATCH]lavf, lavfi: Remove uses of sizeof(char)

2020-04-03 Thread Carl Eugen Hoyos
Hi! Attached patch removes uses of sizeof(char) from libavfilter and libavformat. Please comment, Carl Eugen From eb8c99ab8b714b8699adfb252723ee66f00cd00f Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sat, 4 Apr 2020 01:30:14 +0200 Subject: [PATCH] lavf, lavfi: Remove uses of sizeof(char

[FFmpeg-devel] [PATCH]lavu/mem: Make alloc array functions more similar to av_malloc

2020-04-03 Thread Carl Eugen Hoyos
Hi! Attached patch makes the alloc array functions more similar to av_malloc, depending on max_alloc_size instead of INT_MAX. Allows a work-around for ticket #7140 Please comment, Carl Eugen From 7ae240a9f7885130251031aba5d0764b11947fec Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sat,

Re: [FFmpeg-devel] [PATCH]lavfi/telecine: Mark telecined frames as interlaced

2020-04-03 Thread Carl Eugen Hoyos
Am Sa., 4. Apr. 2020 um 00:40 Uhr schrieb James Almer : > > On 4/3/2020 6:37 PM, Carl Eugen Hoyos wrote: > > Am Fr., 3. Apr. 2020 um 23:19 Uhr schrieb Carl Eugen Hoyos > > : > > > >> Attached patch marks actually telecined frames as interlaced, > >> other frames as progressive. > > > > New patch w

Re: [FFmpeg-devel] [PATCH]lavfi/telecine: Mark telecined frames as interlaced

2020-04-03 Thread James Almer
On 4/3/2020 6:37 PM, Carl Eugen Hoyos wrote: > Am Fr., 3. Apr. 2020 um 23:19 Uhr schrieb Carl Eugen Hoyos > : > >> Attached patch marks actually telecined frames as interlaced, >> other frames as progressive. > > New patch with changes to fate attached. > > Please comment, Carl Eugen Those yad

Re: [FFmpeg-devel] [inline assembly compliance] Issues and patches

2020-04-03 Thread Michael Niedermayer
On Fri, Apr 03, 2020 at 10:41:58PM +0200, FRÉDÉRIC RECOULES wrote: > Dear developpers, > > > > we are academic researchers working in automated program analysis. > We are currently interested in checking compliance of inline asm chunks > as found in C programs. > > While benchmarking our to

[FFmpeg-devel] [PATCH] avcodec/amfenc: adapt to the new internal encode API

2020-04-03 Thread James Almer
Signed-off-by: James Almer --- libavcodec/amfenc.c | 45 libavcodec/amfenc.h | 2 ++ libavcodec/amfenc_h264.c | 1 - libavcodec/amfenc_hevc.c | 1 - 4 files changed, 25 insertions(+), 24 deletions(-) diff --git a/libavcodec/amfenc.c b/libavco

Re: [FFmpeg-devel] [PATCH]lavfi/telecine: Mark telecined frames as interlaced

2020-04-03 Thread Carl Eugen Hoyos
Am Fr., 3. Apr. 2020 um 23:19 Uhr schrieb Carl Eugen Hoyos : > Attached patch marks actually telecined frames as interlaced, > other frames as progressive. New patch with changes to fate attached. Please comment, Carl Eugen From 97f3bba7b4f4f4bf4bbb69376daeb45e3386ba62 Mon Sep 17 00:00:00 2001 F

Re: [FFmpeg-devel] [inline assembly compliance] Issues and patches

2020-04-03 Thread Kieran Kunhya
On Fri, 3 Apr 2020 at 22:07, Carl Eugen Hoyos wrote: > Am Fr., 3. Apr. 2020 um 22:42 Uhr schrieb FRÉDÉRIC RECOULES > : > > > we are academic researchers working in automated program analysis. > > We are currently interested in checking compliance of inline asm chunks > > as found in C programs. >

Re: [FFmpeg-devel] [PATCH v1] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

2020-04-03 Thread Michael Niedermayer
On Fri, Apr 03, 2020 at 11:05:59PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavformat/mux.c| 16 > tests/ref/fate/binsub-movtextenc | 2 +- > tests/ref/fate/movenc| 50 +++ > tests/r

[FFmpeg-devel] [PATCH]lavfi/telecine: Mark telecined frames as interlaced

2020-04-03 Thread Carl Eugen Hoyos
Hi! Attached patch marks actually telecined frames as interlaced, other frames as progressive. Please comment, Carl Eugen From 97f3bba7b4f4f4bf4bbb69376daeb45e3386ba62 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Fri, 3 Apr 2020 23:04:15 +0200 Subject: [PATCH] lavfi/telecine: Mark telec

[FFmpeg-devel] [PATCH v2 2/2] avcodec/libaomenc.c: Add super-resolution options to libaom wrapper

2020-04-03 Thread Wang Cao
Signed-off-by: Wang Cao --- doc/encoders.texi | 39 +++ libavcodec/libaomenc.c | 47 ++ libavcodec/version.h | 2 +- 3 files changed, 87 insertions(+), 1 deletion(-) diff --git a/doc/encoders.texi b/doc/encoders.texi

Re: [FFmpeg-devel] [inline assembly compliance] Issues and patches

2020-04-03 Thread Carl Eugen Hoyos
Am Fr., 3. Apr. 2020 um 22:42 Uhr schrieb FRÉDÉRIC RECOULES : > we are academic researchers working in automated program analysis. > We are currently interested in checking compliance of inline asm chunks > as found in C programs. > > While benchmarking our tool and technique, we found a number of

[FFmpeg-devel] [PATCH v2 1/2] avcodec/libaomenc.c: Add a libaom command-line option 'tune'

2020-04-03 Thread Wang Cao
Signed-off-by: Wang Cao --- doc/encoders.texi | 9 + libavcodec/libaomenc.c | 7 +++ libavcodec/version.h | 2 +- 3 files changed, 17 insertions(+), 1 deletion(-) diff --git a/doc/encoders.texi b/doc/encoders.texi index e23b6b32fe..18bfe8f2eb 100644 --- a/doc/encoders.texi +++

[FFmpeg-devel] [inline assembly compliance] Issues and patches

2020-04-03 Thread FRÉDÉRIC RECOULES
Dear developpers, we are academic researchers working in automated program analysis. We are currently interested in checking compliance of inline asm chunks as found in C programs. While benchmarking our tool and technique, we found a number of issues in FFMPEG. We report them to you, as w

Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec/libaomenc.c: Add super-resolution options to libaom wrapper

2020-04-03 Thread Wang Cao
On Wed, Mar 18, 2020 at 6:38 AM James Zern wrote: > Hi, > > On Thu, Mar 5, 2020 at 6:20 PM Wang Cao wrote: > > > > Signed-off-by: Wang Cao > > --- > > The changes are made according to the code review > > - Bump the MICRO version > > - Use enum for Super resolution mode consts. The original enu

Re: [FFmpeg-devel] [PATCH]configure: Filter -Wl, linker flags out for msvc compilation

2020-04-03 Thread Carl Eugen Hoyos
Am Mi., 1. Apr. 2020 um 16:59 Uhr schrieb Carl Eugen Hoyos : > Attached patch silences a few warnings when compiling with cl.exe or > clang-cl.exe. > Or are there any working options? I will push this if there are no objections. Carl Eugen ___ ffmpeg-d

Re: [FFmpeg-devel] [PATCH]lavc/aacdec_template: Only warn once about unusual 7.1 encoding

2020-04-03 Thread Carl Eugen Hoyos
Am Fr., 27. März 2020 um 22:38 Uhr schrieb Carl Eugen Hoyos : > > Am Fr., 27. März 2020 um 19:00 Uhr schrieb Carl Eugen Hoyos > : > > > Attached patch reduces warnings when decoding a file with 7.1(wide) > > aac encoding. > > New patch attached that does not lead to new crashes. Ping. Carl Eugen

Re: [FFmpeg-devel] [RFC, PATCH]lavu/log: Do not change the terminal background colour

2020-04-03 Thread Carl Eugen Hoyos
Am So., 29. März 2020 um 17:19 Uhr schrieb Carl Eugen Hoyos : > Attached patch fixes ticket #8587, not sure if we want this or not, > but I do not consider the missing encircled / blinking effect (that is > not used by our command line tools) an issue. Ping. Carl Eugen __

Re: [FFmpeg-devel] [PATCH]qsv: Fix format specifiers for int variables

2020-04-03 Thread Carl Eugen Hoyos
Am Mi., 1. Apr. 2020 um 16:55 Uhr schrieb Carl Eugen Hoyos : > Attached patches fix three wrong format specifiers, the variables are > all of type int but the specifier PRId16 is used. Will push them tomorrow. Carl Eugen ___ ffmpeg-devel mailing list f

[FFmpeg-devel] [PATCH v10 1/3] libavcodec/jpeg2000dec.c: Add support for PPT marker

2020-04-03 Thread gautamramk
From: Gautam Ramakrishnan This patch adds functional changes to support the PPT marker. --- libavcodec/jpeg2000dec.c | 88 1 file changed, 79 insertions(+), 9 deletions(-) diff --git a/libavcodec/jpeg2000dec.c b/libavcodec/jpeg2000dec.c index 7103cd6ceb.

[FFmpeg-devel] [PATCH v10 3/3] libavcodec/jpeg2000dec.c: Fix indentation

2020-04-03 Thread gautamramk
From: Gautam Ramakrishnan --- libavcodec/jpeg2000dec.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/jpeg2000dec.c b/libavcodec/jpeg2000dec.c index 32a09c6d5c..36a9e9858a 100644 --- a/libavcodec/jpeg2000dec.c +++ b/libavcodec/jpeg2000dec.c @@ -13

[FFmpeg-devel] [PATCH v10 2/3] libavcodec/jpeg2000dec.c: Handle non EOC streams

2020-04-03 Thread gautamramk
From: Gautam Ramakrishnan This patch allows decoding of j2k streams which do not have an EOC marker. --- libavcodec/jpeg2000dec.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavcodec/jpeg2000dec.c b/libavcodec/jpeg2000dec.c index 02905b9e49..32a09c6d5c 100644 --

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: use a buffer pool for PES payloads

2020-04-03 Thread James Almer
On 4/2/2020 4:54 PM, Marton Balint wrote: > > > On Thu, 2 Apr 2020, James Almer wrote: > >> On 4/2/2020 3:49 PM, Marton Balint wrote: >>> >>> >>> On Thu, 2 Apr 2020, James Almer wrote: >>> On 4/2/2020 3:27 PM, Marton Balint wrote: > > > On Thu, 2 Apr 2020, Marton Balint wrote: >

Re: [FFmpeg-devel] [PATCH 02/14] avformat/matroska: clean the structure formatting

2020-04-03 Thread Andreas Rheinhardt
Steve Lhomme: > On 2020-03-25 23:24, Andreas Rheinhardt wrote: >> Steve Lhomme: >>> From: Steve Lhomme >>> >>> Always use a comma at the end, order elements by value. >>> --- >>>   libavformat/matroska.h | 4 ++-- >>>   1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/libavforma

Re: [FFmpeg-devel] [PATCH 03/14] avformat/matroska: use more consistent spacing in enums

2020-04-03 Thread Andreas Rheinhardt
Steve Lhomme: > From: Steve Lhomme > > --- > libavformat/matroska.h | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/libavformat/matroska.h b/libavformat/matroska.h > index e177cd027f..5520e9ce8f 100644 > --- a/libavformat/matroska.h > +++ b/libavforma

[FFmpeg-devel] [PATCH] ffplay: flush correct stream after stats update

2020-04-03 Thread Gyan Doshi
Stats and logs are written to stderr, not stdout. --- fftools/ffplay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 416ebbf7df..1beec54293 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@ -1736,7 +1736,7 @@ display:

Re: [FFmpeg-devel] [PATCH] ffplay: always show stats at all log levels if requested by user

2020-04-03 Thread Gyan Doshi
On 03-04-2020 09:26 pm, Marton Balint wrote: On Fri, 3 Apr 2020, Gyan Doshi wrote: Since 3b491c5a500, stats would be hidden if loglevel was lower than info, even if -stats was set. Please mention ticket #6962. Revised patch sent. I'll change the flush target in a separate patch as it's

[FFmpeg-devel] [PATCH v2] ffplay: always show stats at all log levels if requested by user

2020-04-03 Thread Gyan Doshi
Since 3b491c5a500, stats would be hidden if loglevel was lower than info, even if -stats was set. Fixes #6962 --- doc/ffplay.texi | 5 +++-- fftools/ffplay.c | 36 2 files changed, 27 insertions(+), 14 deletions(-) diff --git a/doc/ffplay.texi b/doc/ffplay.

Re: [FFmpeg-devel] [PATCH v1 2/2] avcodec/mpeg12enc: Support mpeg2 encoder profile with const options

2020-04-03 Thread Hendrik Leppkes
On Fri, Apr 3, 2020 at 5:47 PM Fu, Linjie wrote: > > > From: ffmpeg-devel On Behalf Of > > Limin Wang > > Sent: Friday, April 3, 2020 22:55 > > To: ffmpeg-devel@ffmpeg.org > > Subject: Re: [FFmpeg-devel] [PATCH v1 2/2] avcodec/mpeg12enc: Support > > mpeg2 encoder profile with const options > > >

Re: [FFmpeg-devel] [PATCH] ffplay: always show stats at all log levels if requested by user

2020-04-03 Thread Marton Balint
On Fri, 3 Apr 2020, Gyan Doshi wrote: Since 3b491c5a500, stats would be hidden if loglevel was lower than info, even if -stats was set. Please mention ticket #6962. --- fftools/ffplay.c | 36 1 file changed, 24 insertions(+), 12 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH v1 2/2] avcodec/mpeg12enc: Support mpeg2 encoder profile with const options

2020-04-03 Thread Fu, Linjie
> From: ffmpeg-devel On Behalf Of > Limin Wang > Sent: Friday, April 3, 2020 22:55 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v1 2/2] avcodec/mpeg12enc: Support > mpeg2 encoder profile with const options > > On Fri, Apr 03, 2020 at 04:25:15PM +0200, Hendrik Leppkes wrote:

Re: [FFmpeg-devel] [PATCH v1 2/2] avcodec/mpeg12enc: Support mpeg2 encoder profile with const options

2020-04-03 Thread Limin Wang
On Fri, Apr 03, 2020 at 04:25:15PM +0200, Hendrik Leppkes wrote: > On Fri, Apr 3, 2020 at 3:12 PM wrote: > > > > From: Limin Wang > > > > make setting profile more user friendly > > > > Please make sure API users can still set it through avctx->profile, > otherwise this would be an API break. R

Re: [FFmpeg-devel] [PATCH v1] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

2020-04-03 Thread Andreas Rheinhardt
lance.lmw...@gmail.com: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavformat/mux.c| 16 > tests/ref/fate/binsub-movtextenc | 2 +- > tests/ref/fate/movenc| 50 +++ > tests/ref/fate/sub2video | 86 > ++

[FFmpeg-devel] [PATCH 08/10] lavc/libopenh264enc: add profile high option support

2020-04-03 Thread Linjie Fu
Add support for PRO_HIGH/PRO_BASELINE in SVC Encoding extention mode, which determined by iEntropyCodingModeFlag in ParamTranscode(). Signed-off-by: Linjie Fu --- libavcodec/libopenh264enc.c | 32 +++

[FFmpeg-devel] [PATCH 07/10] lavc/libopenh264enc: separate svc_encode_init() into several functions

2020-04-03 Thread Linjie Fu
Separate the initialization procedure into different functions. Make it more readable and easier to be extended. Signed-off-by: Linjie Fu --- libavcodec/libopenh264enc.c | 283 +++- 1 file changed, 174 insertions(+), 109 deletions(-) diff --git a/libavco

[FFmpeg-devel] [PATCH 10/10] lavc/libopenh264enc: replace cabac option with coder

2020-04-03 Thread Linjie Fu
Change the default option to -1 and allow the default cabac to be decided by profile. Signed-off-by: Linjie Fu --- libavcodec/libopenh264enc.c | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/libavcodec/libopenh264enc.c b/libavcodec/libopenh264enc

[FFmpeg-devel] [PATCH 09/10] lavc/libopenh264enc: allow specifying the profile through AVCodecContext

2020-04-03 Thread Linjie Fu
Signed-off-by: Linjie Fu --- libavcodec/libopenh264enc.c | 16 1 file changed, 16 insertions(+) diff --git a/libavcodec/libopenh264enc.c b/libavcodec/libopenh264enc.c index d331cfd..70ded55 100644 --- a/libavcodec/libopenh264enc.c +++ b/libavcodec/libopenh264enc.c @@ -111,6 +111

[FFmpeg-devel] [PATCH 05/10] lavc/libopenh264enc: prompt slice number changing according to cpus

2020-04-03 Thread Linjie Fu
Libopenh264enc would set the slice according to the number of cpu cores if uiSliceNum equals to 0 (auto) in SM_FIXEDSLCNUM_SLICE mode. Prompt a warning for user to catch this. Signed-off-by: Linjie Fu --- libavcodec/libopenh264enc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavco

[FFmpeg-devel] [PATCH 04/10] lavc/libopenh264enc: add bit rate control select support

2020-04-03 Thread Linjie Fu
RC_BITRATE_MODE: set BITS_EXCEEDED to iCurrentBitsLevel and allows QP adjust in RcCalculatePictureQp(). RC_BUFFERBASED_MODE: use buffer status to adjust the video quality. RC_TIMESTAMP_MODE: bit rate control based on timestamp. Default to use RC_QUALITY_MODE. Signed-off-by: Linj

[FFmpeg-devel] [PATCH 06/10] lavc/libopenh264enc: set slice_mode option to deprecated

2020-04-03 Thread Linjie Fu
"slice mode" seems to be unnecessary since it could be determined by -slices/max_nal_size. default:SM_FIXEDSLCNUM_SLICE mode with cpu-number slices. -slices N: SM_FIXEDSLCNUM_SLICE mode with N slices. -max_nal_size: SM_SIZELIMITED_SLICE mode with limited size slices. This could be r

[FFmpeg-devel] [PATCH 02/10] lavc/libopenh264enc: fix the if-else coding style

2020-04-03 Thread Linjie Fu
Signed-off-by: Linjie Fu --- libavcodec/libopenh264enc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavcodec/libopenh264enc.c b/libavcodec/libopenh264enc.c index 364926f..c7ae5b1 100644 --- a/libavcodec/libopenh264enc.c +++ b/libavcodec/libopenh264enc.c @@ -202,8 +

[FFmpeg-devel] [PATCH 03/10] lavc/libopenh264enc: add default gop size and bit rate

2020-04-03 Thread Linjie Fu
Signed-off-by: Linjie Fu --- libavcodec/libopenh264enc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/libopenh264enc.c b/libavcodec/libopenh264enc.c index c7ae5b1..3ff5be7 100644 --- a/libavcodec/libopenh264enc.c +++ b/libavcodec/libopenh264enc.c @@ -335,6 +335,8 @@ static int

[FFmpeg-devel] [PATCH 01/10] lavc/libopenh264enc: Add default qmin/qmax support

2020-04-03 Thread Linjie Fu
Set default QP range to (1, 51) instead of (2, 32). QP = 0 is not well supported currently in libopenh264. If iMaxQp/iMinQp equals 0, the QP range would be changed unexpectedly inside libopenh264 with a warning: Warning:Change QP Range from(0,51) to (12,42) [1]

[FFmpeg-devel] [PATCH 00/10] Patch set for the enhancement of libopenh264 encoder

2020-04-03 Thread Linjie Fu
Docs will be provided later. Linjie Fu (10): lavc/libopenh264enc: Add default qmin/qmax support [v2] fix the av_clip logic for iMinQp. lavc/libopenh264enc: fix the if-else coding style lavc/libopenh264enc: add default gop size and bit rate lavc/libopenh264enc: add bit rate control sele

[FFmpeg-devel] [PATCH v2 2/2] avcodec/mpeg12enc: Support mpeg2 encoder profile with const options

2020-04-03 Thread lance . lmwang
From: Limin Wang make setting profile more user friendly Signed-off-by: Limin Wang --- doc/encoders.texi | 8 libavcodec/mpeg12enc.c | 22 +- libavcodec/mpegvideo.h | 1 + 3 files changed, 26 insertions(+), 5 deletions(-) diff --git a/doc/encoders.texi b/do

Re: [FFmpeg-devel] [PATCH v1] fftools/ffmpeg: set AV_PKT_FLAG_KEY for the subtitle packet

2020-04-03 Thread Limin Wang
On Fri, Mar 27, 2020 at 01:47:10AM +0100, Michael Niedermayer wrote: > On Thu, Mar 26, 2020 at 10:47:37AM +0100, Anton Khirnov wrote: > > Quoting Andreas Rheinhardt (2020-03-20 17:51:41) > > > Jan Ekström: > > > > On Fri, Mar 20, 2020 at 5:45 PM wrote: > > > >> > > > >> From: Limin Wang > > > >>

[FFmpeg-devel] [PATCH v1] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

2020-04-03 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/mux.c| 16 tests/ref/fate/binsub-movtextenc | 2 +- tests/ref/fate/movenc| 50 +++ tests/ref/fate/sub2video | 86 4 files changed

Re: [FFmpeg-devel] [PATCH 1/3] avformat/ilbc: Don't reimplement ff_raw_write_packet

2020-04-03 Thread Michael Niedermayer
On Thu, Apr 02, 2020 at 07:17:38PM +0200, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/ilbc.c | 9 ++--- > 1 file changed, 2 insertions(+), 7 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Avoid

Re: [FFmpeg-devel] [PATCH 3/3] avformat/dss: Remove unnecessary allocation

2020-04-03 Thread Michael Niedermayer
On Thu, Apr 02, 2020 at 07:17:40PM +0200, Andreas Rheinhardt wrote: > Put a buffer with a known fixed size into the demuxer's context instead > of allocating it separately. This also allows to remove the demuxer's > read_close()-function. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat

Re: [FFmpeg-devel] [PATCH v1 2/2] avcodec/mpeg12enc: Support mpeg2 encoder profile with const options

2020-04-03 Thread Hendrik Leppkes
On Fri, Apr 3, 2020 at 3:12 PM wrote: > > From: Limin Wang > > make setting profile more user friendly > Please make sure API users can still set it through avctx->profile, otherwise this would be an API break. - Hendrik ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH v1] avformat/concat: priv_data should be freed internally

2020-04-03 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/concat.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/concat.c b/libavformat/concat.c index ea3bc1dfde..cfe14760eb 100644 --- a/libavformat/concat.c +++ b/libavformat/concat.c @@ -75,7 +75,6 @@ static av_cold int conca

[FFmpeg-devel] [PATCH v1 2/2] avcodec/mpeg12enc: Support mpeg2 encoder profile with const options

2020-04-03 Thread lance . lmwang
From: Limin Wang make setting profile more user friendly Signed-off-by: Limin Wang --- doc/encoders.texi | 8 libavcodec/mpeg12enc.c | 19 ++- libavcodec/mpegvideo.h | 1 + 3 files changed, 23 insertions(+), 5 deletions(-) diff --git a/doc/encoders.texi b/doc/e

[FFmpeg-devel] [PATCH v1 1/2] avcodec/mpeg12enc: Use FF_PROFILE_MPEG2_xxx macros

2020-04-03 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/mpeg12enc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/mpeg12enc.c b/libavcodec/mpeg12enc.c index b460e78a59..643ba8165a 100644 --- a/libavcodec/mpeg12enc.c +++ b/libavcodec/mpeg12enc.c @@ -162

[FFmpeg-devel] [PATCH] ffplay: always show stats at all log levels if requested by user

2020-04-03 Thread Gyan Doshi
Since 3b491c5a500, stats would be hidden if loglevel was lower than info, even if -stats was set. --- fftools/ffplay.c | 36 1 file changed, 24 insertions(+), 12 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 2ed4b22d3e..d529c60e81 100644

Re: [FFmpeg-devel] [PATCH 7/7] lavc/libopenh264enc: separate svc_encode_init() into several functions

2020-04-03 Thread Fu, Linjie
> From: ffmpeg-devel On Behalf Of Fu, > Linjie > Sent: Tuesday, March 31, 2020 23:59 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 7/7] lavc/libopenh264enc: separate > svc_encode_init() into several functions > > > From: ffmpeg-devel On

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/matroskaenc: Don't fail if reserved Cues space doesn't suffice

2020-04-03 Thread Andreas Rheinhardt
Andreas Rheinhardt: > When the user opted to write the Cues at the beginning, the Cues were > simply written without checking in advance whether enough space has been > reserved for them. If it wasn't enough, the data following the space > reserved for the Cues was simply overwritten, corrupting th

Re: [FFmpeg-devel] [PATCH] fate/matroska: Add test for updating CodecPrivate from packet sidedata

2020-04-03 Thread Andreas Rheinhardt
Andreas Rheinhardt: > containing updated extradata, in this case a new FLAC streaminfo. > Furthermore, it also tests that the Matroska muxer is able to preserve > uncommon channel layouts by adding Vorbis comments to the CodecPrivate. > > Signed-off-by: Andreas Rheinhardt > --- > This is in parti

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hnm: Only keep and parse what is needed later

2020-04-03 Thread Andreas Rheinhardt
Paul B Mahol: > ok if fate passed and it is covered. > > On 3/21/20, Andreas Rheinhardt wrote: >> The hnm demuxer's context struct contained lots of fields that are >> write-only variables or that are not used outside of parsing the header >> and that can therefore be replaced by local variables

Re: [FFmpeg-devel] [PATCH v6 0/2] Pro Pinball Series Soundbank demuxer + decoder.

2020-04-03 Thread Zane van Iperen
On Sun, 29 Mar 2020 17:18:08 + "Zane van Iperen" wrote: > Adds support for the soundbank files used by the Pro Pinball series > of games. > > Please CC for review. > > v6: > - fix tools/probetest failure > > v5: > - add probe function > - add flag #define's > > v4: > - fix adpcm i

[FFmpeg-devel] [PATCH 1/1] libavformat/rtsp: Pass protocol options for udp multicast

2020-04-03 Thread Wolfgang Haupt
Protocol options like buffer_size need to be passed to the underlying transport implementation for udp multicasts as well. --- libavformat/rtsp.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index a69484d78b..dbf626eb13 100644 ---