Re: [FFmpeg-devel] [PATCH 1/2] avformat/aviobuf: Remove AVIOInternal and one level of indirection

2020-01-29 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Andreas Rheinhardt: >> On Mon, Jan 6, 2020 at 3:51 PM Andreas Rheinhardt < >> andreas.rheinha...@gmail.com> wrote: >> >>> In the Libav commit cae448cf, the opaque of every AVIOContext opened >>> by ffio_fdopen() (which is used internally by avio_open() and avio_open2()) >>> ch

Re: [FFmpeg-devel] Fix undefined behavior in ff_configure_buffers_for_index()

2020-01-29 Thread Michael Niedermayer
On Wed, Jan 29, 2020 at 03:25:32PM -0800, Dale Curtis wrote: > On Wed, Jan 29, 2020 at 4:55 AM Michael Niedermayer > wrote: > > > simpler solution, and also behaves arithmetically more correct when the > > overflow happens in the othert direction: > > > > av_assert0(time_tolerance >= 0); > > > >

Re: [FFmpeg-devel] [PATCH] avformat/mov: update extensions

2020-01-29 Thread Gyan Doshi
On 30-01-2020 07:37 am, Carl Eugen Hoyos wrote: Am Mi., 29. Jan. 2020 um 05:56 Uhr schrieb Gyan : On 29-01-2020 05:52 am, Carl Eugen Hoyos wrote: Am Mo., 27. Jan. 2020 um 18:07 Uhr schrieb Gyan : As I mentioned, the benefit is for cli users able to specify `-f ext` as well as `-h demuxer=

Re: [FFmpeg-devel] [PATCH] ac3enc: drop a global variable

2020-01-29 Thread Kieran Kunhya
Sent from my mobile device On Wed, 29 Jan 2020, 15:35 Anton Khirnov, wrote: > Log the warning message once per encoder instance instead. > --- > libavcodec/ac3enc.c | 5 ++--- > libavcodec/ac3enc.h | 2 ++ > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/ac3enc.c b

Re: [FFmpeg-devel] [PATCH] avformat/mov: update extensions

2020-01-29 Thread Carl Eugen Hoyos
Am Mi., 29. Jan. 2020 um 05:56 Uhr schrieb Gyan : > > > > On 29-01-2020 05:52 am, Carl Eugen Hoyos wrote: > > Am Mo., 27. Jan. 2020 um 18:07 Uhr schrieb Gyan : > > > >> As I mentioned, the benefit is for cli users able to specify `-f ext` > >> as well as `-h demuxer=ext` > > I cannot reproduce this

Re: [FFmpeg-devel] [PATCH] fate/filter-video.mak: do not use bit-exact check for dnn_processing

2020-01-29 Thread Carl Eugen Hoyos
Am Mi., 29. Jan. 2020 um 04:41 Uhr schrieb Pedro Arthur : > > Em ter., 28 de jan. de 2020 às 21:20, Carl Eugen Hoyos > escreveu: > > > > Am Mi., 22. Jan. 2020 um 13:09 Uhr schrieb Martin Storsjö > > : > > > > > If it takes time to get the test to that point, I would suggest reverting > > > the ex

Re: [FFmpeg-devel] [PATCH] avfilter: add xfade filter

2020-01-29 Thread Lou Logan
On Sun, Jan 26, 2020, at 4:46 AM, Paul B Mahol wrote: > +@item wipeleft > +@item wiperight > +@item wipeup > +@item wipedown Nice filter, but you're missing the best wipe of them all: starwipe. > +@item slideleft > +@item slideright > +@item slideup > +@item slidedown > +@end table > +Default tra

[FFmpeg-devel] [PATCH 4/6] avutil/common: warn about possible move of the data pointer after the last 0 byte in GET_UTF8

2020-01-29 Thread Marton Balint
Signed-off-by: Marton Balint --- libavutil/common.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavutil/common.h b/libavutil/common.h index e6f076a13c..142ff9abe7 100644 --- a/libavutil/common.h +++ b/libavutil/common.h @@ -373,7 +373,9 @@ static av_always_inline av_c

[FFmpeg-devel] [PATCH 3/6] avutil/common: put ERROR statements into separate code blocks in GET_UTF8/16

2020-01-29 Thread Marton Balint
Signed-off-by: Marton Balint --- libavutil/common.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavutil/common.h b/libavutil/common.h index 02671190a6..e6f076a13c 100644 --- a/libavutil/common.h +++ b/libavutil/common.h @@ -387,11 +387,11 @@ static av_always_inline

[FFmpeg-devel] [PATCH 5/6] avfilter/vf_drawtext: use replacement chars for invalid UTF8 sequences

2020-01-29 Thread Marton Balint
continue is explicitly disallowed for GET_UTF8, so let's fix that as well. Fixes crash with invalid UTF8 sequences. Signed-off-by: Marton Balint --- libavfilter/vf_drawtext.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_drawtext.c b/libavfilter/vf_d

[FFmpeg-devel] [PATCH 6/6] avfilter/vf_drawtext: do not overread text if the last UTF8 sequence is invalid

2020-01-29 Thread Marton Balint
Signed-off-by: Marton Balint --- libavfilter/vf_drawtext.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_drawtext.c b/libavfilter/vf_drawtext.c index ed10175af0..b58556e0f1 100644 --- a/libavfilter/vf_drawtext.c +++ b/libavfilter/vf_drawtext.c @@ -1225,7

[FFmpeg-devel] [PATCH 2/6] avutil/common: add parenthesis around GET_16BIT in GET_UTF16

2020-01-29 Thread Marton Balint
Signed-off-by: Marton Balint --- libavutil/common.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavutil/common.h b/libavutil/common.h index 5568754bb9..02671190a6 100644 --- a/libavutil/common.h +++ b/libavutil/common.h @@ -408,11 +408,11 @@ static av_always_inline a

[FFmpeg-devel] [PATCH 1/6] avutil/common: use unsigned int in GET_UTF8

2020-01-29 Thread Marton Balint
Right shift of signed value is impelentation defined. Signed-off-by: Marton Balint --- libavutil/common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/common.h b/libavutil/common.h index f09f0b486b..5568754bb9 100644 --- a/libavutil/common.h +++ b/libavutil/commo

Re: [FFmpeg-devel] Fix undefined behavior in ff_configure_buffers_for_index()

2020-01-29 Thread Dale Curtis
On Wed, Jan 29, 2020 at 4:55 AM Michael Niedermayer wrote: > simpler solution, and also behaves arithmetically more correct when the > overflow happens in the othert direction: > > av_assert0(time_tolerance >= 0); > > if (e2_pts < e1_pts || e2_pts - (uint64_t)e1_pts < time_tolerance) > Does that

[FFmpeg-devel] [PATCH 2/3] tools/target_dec_fuzzer: Adjust threshold for screenpresso

2020-01-29 Thread Michael Niedermayer
Fixes: Timeout (332 -> 21 sec) Fixes: 20280/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SCREENPRESSO_fuzzer-6238663432470528 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.

[FFmpeg-devel] [PATCH 1/3] avcodec/screenpresso: Optimize sum_delta_flipped()

2020-01-29 Thread Michael Niedermayer
553 -> 332 sec Testcase: 20280/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SCREENPRESSO_fuzzer-6238663432470528 Signed-off-by: Michael Niedermayer --- libavcodec/screenpresso.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/screenpresso.c b/libavcodec/sc

[FFmpeg-devel] [PATCH 3/3] avcodec/x86/diracdsp: Fix incorrect src addressing in dequant_subband_32()

2020-01-29 Thread Michael Niedermayer
Fixes: Segfault (not reproducable with asm, which made this hard to debug) Fixes: decoding errors Fixes: 19854/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DIRAC_fuzzer-5729372837511168 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signe

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/amfenc_hevc.c: Fix constant QP settings for I, P

2020-01-29 Thread Kravchenko, Alexander
> 28 янв. 2020 г., в 19:53, OvchinnikovDmitrii > написал(а): > > --- > libavcodec/amfenc_hevc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/amfenc_hevc.c b/libavcodec/amfenc_hevc.c > index 7c9a33ab33..8b4d289fac 100644 > --- a/libavcodec/amfenc_hevc.c

Re: [FFmpeg-devel] [PATCH 5/5] avformat/mov: correct to representative names for mov.c

2020-01-29 Thread Derek Buitenhuis
On 28/01/2020 08:07, Hendrik Leppkes wrote: > These names are strictly speaking part of the ABI, and I'm sure that > some applications will use them to identify a format - I know that I > do, for example. To chime in: I do too. I thought it was considered ABI. Further, as far as I know, these are

[FFmpeg-devel] [PATCH] avfilter/vf_geq: use per-thread AVExpr for expression evaluation

2020-01-29 Thread Marton Balint
There was no consensus about separating AVExprState from AVExpr so here is a minimal patch using the existing AVExpr to fix ticket #7528. Signed-off-by: Marton Balint --- doc/filters.texi | 5 + libavfilter/vf_geq.c | 26 +++--- 2 files changed, 20 insertions(+), 11

Re: [FFmpeg-devel] [PATCH 3/3] avfilter/vf_geq: fix multiple assignments of ptr in slice_geq_filter

2020-01-29 Thread Marton Balint
On Sun, 29 Dec 2019, Michael Niedermayer wrote: On Sat, Dec 28, 2019 at 03:46:25PM +0100, Marton Balint wrote: Fixes Coverity CID 1427183. Signed-off-by: Marton Balint --- libavfilter/vf_geq.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) LGTM I forgot about this, n

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add an AVCodecContext flag to export PRFT side data on demand

2020-01-29 Thread Anton Khirnov
Quoting James Almer (2020-01-29 17:05:52) > On 1/29/2020 12:12 PM, Anton Khirnov wrote: > > > > I wonder if we couldn't figure out a better place for this toggle. > > flags/flags2 are currently a hot mess of everything and the kitchensink > > squashed together. Perhaps we could add a new field for

[FFmpeg-devel] [PATCH] sbcdec: do not unnecessarily set frame properties

2020-01-29 Thread Anton Khirnov
Decoders are supposed to export stream properties in AVCodecContext, the AVFrame properties are set from those in ff_get_buffer(). --- libavcodec/sbcdec.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavcodec/sbcdec.c b/libavcodec/sbcdec.c index d8ea6855fe..2ebde466

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add an AVCodecContext flag to export PRFT side data on demand

2020-01-29 Thread James Almer
On 1/29/2020 12:12 PM, Anton Khirnov wrote: > Quoting James Almer (2020-01-23 21:25:34) >> Signed-off-by: James Almer >> --- >> doc/APIchanges | 3 +++ >> doc/codecs.texi| 2 ++ >> libavcodec/avcodec.h | 8 +++- >> libavcodec/options_table.h | 1 + >> libavcodec/

Re: [FFmpeg-devel] [PATCH 1/5] avformat/format: add av_find_input_format2

2020-01-29 Thread Gyan
On 29-01-2020 03:10 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2020-01-28 08:44:42) Identifies demuxer by extension if search by short name fails. --- libavformat/avformat.h | 7 +++ libavformat/format.c | 14 +- libavformat/version.h | 2 +- 3 files changed, 21 ins

[FFmpeg-devel] [PATCH] ac3enc: drop a global variable

2020-01-29 Thread Anton Khirnov
Log the warning message once per encoder instance instead. --- libavcodec/ac3enc.c | 5 ++--- libavcodec/ac3enc.h | 2 ++ 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/libavcodec/ac3enc.c b/libavcodec/ac3enc.c index 25318f8631..7ce17db067 100644 --- a/libavcodec/ac3enc.c +++ b/lib

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add an AVCodecContext flag to export PRFT side data on demand

2020-01-29 Thread Anton Khirnov
Quoting James Almer (2020-01-23 21:25:34) > Signed-off-by: James Almer > --- > doc/APIchanges | 3 +++ > doc/codecs.texi| 2 ++ > libavcodec/avcodec.h | 8 +++- > libavcodec/options_table.h | 1 + > libavcodec/version.h | 2 +- > 5 files changed, 14 inserti

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add an AVCodecContext flag to export PRFT side data on demand

2020-01-29 Thread James Almer
On 1/23/2020 5:25 PM, James Almer wrote: > Signed-off-by: James Almer > --- > doc/APIchanges | 3 +++ > doc/codecs.texi| 2 ++ > libavcodec/avcodec.h | 8 +++- > libavcodec/options_table.h | 1 + > libavcodec/version.h | 2 +- > 5 files changed, 14 insertio

[FFmpeg-devel] [PATCH] lavc/ac3dec: disable DRC by default

2020-01-29 Thread rcombs
This issue has been argued before, with the status quo being preserved under the logic that the spec says this parameter is supposed to default to 1, and that we should follow the spec. The spec was misguided, and thus so was blindly following it. The (E-)AC3 DRC architecture is a clever optimizat

Re: [FFmpeg-devel] [PATCH]lavf/nut: Explicitely add tags for NV12 and NV21

2020-01-29 Thread Paul B Mahol
On 1/29/20, Michael Niedermayer wrote: > On Wed, Jan 29, 2020 at 01:44:52AM +0100, Carl Eugen Hoyos wrote: >> Hi! >> >> Mentioned tags are already used in nut by fate. >> >> Please comment, Carl Eugen > >> nut.c |3 +++ >> 1 file changed, 3 insertions(+) >> ae60da7cb36c94b7cab3bd17f02bd9403c8

Re: [FFmpeg-devel] [PATCH 1/2] tools/target_dec_fuzzer: Sort threshold list alphabetically

2020-01-29 Thread Michael Niedermayer
On Sun, Jan 26, 2020 at 12:56:25AM +0100, Michael Niedermayer wrote: > This also removes the comments as they are hard to maintain > together with sorted lists > > Signed-off-by: Michael Niedermayer > --- > tools/target_dec_fuzzer.c | 54 ++- > 1 file changed,

Re: [FFmpeg-devel] [PATCH]lavf/nut: Explicitely add tags for NV12 and NV21

2020-01-29 Thread Michael Niedermayer
On Wed, Jan 29, 2020 at 01:44:52AM +0100, Carl Eugen Hoyos wrote: > Hi! > > Mentioned tags are already used in nut by fate. > > Please comment, Carl Eugen > nut.c |3 +++ > 1 file changed, 3 insertions(+) > ae60da7cb36c94b7cab3bd17f02bd9403c8d2ff8 > 0001-lavf-nut-Explicitely-add-NV12-NV21

[FFmpeg-devel] [PATCH] Support for Frame Duplication(Doubling/Tripling) by FFmpeg's HEVC Decoder by parsing the picture_struct SEI

2020-01-29 Thread Praveen Kumar
Hi, Re-submitting the patch. This patch has the implementation for supporting frame-duplication (doubling/ tripling) by FFmpeg's HEVC decoder based on the picture_structure SEI value present in the encoded video. picture_structure value of 7 implies doubling and 8 implies tripling. The value of

Re: [FFmpeg-devel] Why this is happening? CUDA ERROR OUT OF MEMORY

2020-01-29 Thread Dennis Mungai
On Wed, 29 Jan 2020, 15:13 Rodrigo Dal Ri, wrote: > Hi guys, > > I am using ffmpeg to transcode some live channels, but I'm having a > recurring problem. > All the time I get a CUDA out of memory error( attached print ), even > though the video card has nothing to process. > I build my ffmpeg fol

Re: [FFmpeg-devel] Fix undefined behavior in ff_configure_buffers_for_index()

2020-01-29 Thread Michael Niedermayer
On Tue, Jan 28, 2020 at 04:52:16PM -0800, Dale Curtis wrote: > When e2_pts == INT64_MIN and e1_pts >= 0 the calculation of > e2_pts - e1_pts will overflow an int64_t. So instead check > for overflow and default to |time_tolerance| if the value > is too large for an int64_t. > > Signed-off-by: Dale

[FFmpeg-devel] Why this is happening? CUDA ERROR OUT OF MEMORY

2020-01-29 Thread Rodrigo Dal Ri
Hi guys, I am using ffmpeg to transcode some live channels, but I'm having a recurring problem. All the time I get a CUDA out of memory error( attached print ), even though the video card has nothing to process. I build my ffmpeg following the NVIDIA FFmpeg Transcoding Guide ( https://devblo

Re: [FFmpeg-devel] [PATCH 2/2] tools/target_dec_fuzzer: Add threshold for IFF_ILBM

2020-01-29 Thread Michael Niedermayer
On Wed, Jan 29, 2020 at 07:48:54AM +1100, Peter Ross wrote: > On Thu, Jan 23, 2020 at 12:36:39AM +0100, Michael Niedermayer wrote: > > Fixes: Timeout (32 -> 1sec) > > Fixes: > > 20138/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IFF_ILBM_fuzzer-5634665251864576 > > > > Found-by: continuous f

Re: [FFmpeg-devel] [PATCH v4] avfilter/vf_zoompan: fix shaking when zooming

2020-01-29 Thread Robert Deibel
On 29.01.20 11:49, Paul B Mahol wrote: On 1/29/20, Robert Deibel wrote: - -av_opt_set_int(s->sws, "srcw", w, 0); -av_opt_set_int(s->sws, "srch", h, 0); +av_opt_set_int(s->sws, "srcw", crop_w, 0); +av_opt_set_int(s->sws, "srch", crop_h, 0); Is this really needed? av_opt

Re: [FFmpeg-devel] [PATCH 1/2] avutil/log: Add av_log_once() for printing a message just once per instance

2020-01-29 Thread Michael Niedermayer
On Tue, Jan 28, 2020 at 07:38:45PM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2020-01-24 13:04:08) > > On Tue, Jan 21, 2020 at 07:44:46PM +0100, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2020-01-21 15:43:48) > > > > On Tue, Jan 21, 2020 at 12:24:50PM +0100, Anton Khirn

Re: [FFmpeg-devel] [PATCH v4] avfilter/vf_zoompan: fix shaking when zooming

2020-01-29 Thread Paul B Mahol
On 1/29/20, Robert Deibel wrote: > Fix shaking of image when zoom is applied by the zoompan filter. > Resolves ticket https://trac.ffmpeg.org/ticket/4298 > --- > Fixed a typo/bug where dy was dx. Removed request for oversized frame from > filter, instead allocate > internal frame and copy contents

[FFmpeg-devel] [PATCH v4] avfilter/vf_zoompan: fix shaking when zooming

2020-01-29 Thread Robert Deibel
Fix shaking of image when zoom is applied by the zoompan filter. Resolves ticket https://trac.ffmpeg.org/ticket/4298 --- Fixed a typo/bug where dy was dx. Removed request for oversized frame from filter, instead allocate internal frame and copy contents to out frame once dimensions are correct.

Re: [FFmpeg-devel] [PATCH 1/5] avformat/format: add av_find_input_format2

2020-01-29 Thread Anton Khirnov
Quoting Gyan Doshi (2020-01-28 08:44:42) > Identifies demuxer by extension if search by short name fails. > --- > libavformat/avformat.h | 7 +++ > libavformat/format.c | 14 +- > libavformat/version.h | 2 +- > 3 files changed, 21 insertions(+), 2 deletions(-) > > diff --git

[FFmpeg-devel] [PATCH] avformat/tty: add probe function

2020-01-29 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/tty.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/libavformat/tty.c b/libavformat/tty.c index 8d48f2c45c..60f7e9f87e 100644 --- a/libavformat/tty.c +++ b/libavformat/tty.c @@ -34,6 +34,13 @@ #include "inter

Re: [FFmpeg-devel] [PATCH 02/13] lavc/ass: add support for configuring default style via AVOptions

2020-01-29 Thread Moritz Barsnick
On Tue, Jan 28, 2020 at 22:42:33 -0600, rcombs wrote: > > You're inverting the "leftmost" 8 bits of c? Can't you just make this > > return (c ^ 0xff00); > > ? Even inline, or just a macro? (Or perhaps I'm missing something, and > > (255 - a) is not always the same as (a ^ 0xff). > > These are

Re: [FFmpeg-devel] [PATCH] avfilter: add xfade filter

2020-01-29 Thread Paul B Mahol
Will apply with some small improvements. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] Fixing rare dshow input crash

2020-01-29 Thread Paul B Mahol
Please incorporate this change in previous bigger patch. It is ready for merge. On 1/29/20, Roger Pack wrote: > Good catch. > Or maybe this? > > diff --git a/libavdevice/dshow.c b/libavdevice/dshow.c > index d7f5bd7..96e4374 100644 > --- a/libavdevice/dshow.c > +++ b/libavdevice/dshow.c > @@ -453

Re: [FFmpeg-devel] [PATCH] Fixing rare dshow input crash

2020-01-29 Thread Roger Pack
Good catch. Or maybe this? diff --git a/libavdevice/dshow.c b/libavdevice/dshow.c index d7f5bd7..96e4374 100644 --- a/libavdevice/dshow.c +++ b/libavdevice/dshow.c @@ -453,6 +453,7 @@ next: if (type->pbFormat) CoTaskMemFree(type->pbFormat); CoTaskMemFree(type); +