Quoting James Almer (2020-01-29 17:05:52)
> On 1/29/2020 12:12 PM, Anton Khirnov wrote:
> >
> > I wonder if we couldn't figure out a better place for this toggle.
> > flags/flags2 are currently a hot mess of everything and the kitchensink
> > squashed together. Perhaps we could add a new field for "flags to
> > indicate to the codec that it should export this optional kind of
> > metadata". It might make things clearer and better organized. Just a
> > random thought though - feel free to ignore me.
>
> I added it to flags2 since that one also has the export_mvs option to
> export one specific kind of frame side data, but yeah, both flags and
> flags2 are a dumping ground of options and it's hardly intuitive.
>
> What field name,
export_metadata? (the word 'metadata' is now a bit overloaded though)
export_opt_data? ('opt' could be somewhat misleading)
> define prefix
AVCODEC_EXPORT_FOO
possibly AVCODEC_EXPORT_METADATA_FOO (or whatever we choose from above,
but that's getting too long)
> and options.h names do you suggest?
matching the field name in AVCodecContext?
For the flags, the same you used in original patch.
> Should it cover both packets (encoders) and frames (decoders)?
Yes.
> And should we move existing flags like export_mvs to it, deprecating
> the existing ones?
What others are there? I'd say probably yes.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
