Re: [FFmpeg-devel] [PATCH] Changelog: Fix typo of comments

2019-12-21 Thread Lou Logan
On Fri, Dec 20, 2019, at 9:33 PM, Steven Liu wrote: > Signed-off-by: Steven Liu > --- > Changelog | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) LGTM. No need to send patches for trivial typos like this if you prefer, but I understand many here are not native English speakers.

Re: [FFmpeg-devel] [PATCH] avformat/hls: propagate icy to child AVIOContexts

2019-12-21 Thread Liu Steven
> 在 2019年12月21日,下午7:02,Marvin Scholz 写道: > > On 17 Dec 2019, at 1:17, Marvin Scholz wrote: > >> When the user decides they do not want to to send the Icy-MetaData >> header, this should be respected for all requests, not just the first >> one. >> >> Fix #5578 >> --- >> libavformat/hls.c | 2 +

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: propagate icy to child AVIOContexts

2019-12-21 Thread Liu Steven
> 在 2019年12月21日,下午7:03,Marvin Scholz 写道: > > On 17 Dec 2019, at 1:45, Marvin Scholz wrote: > >> When the user decides they do not want to to send the Icy-MetaData >> header, this should be respected for all requests, not just the first >> one. >> >> Fix #5578 >> --- >> libavformat/dashdec.c |

Re: [FFmpeg-devel] [PATCH] nvenc: implement flush to help allow an encoder to be re-used

2019-12-21 Thread Philip Langdale
On Fri, 20 Dec 2019 16:07:18 -0800 Josh Allmann wrote: > One concern I had was about the long-term stability of this behavior. > Right now, it works, but perhaps only coincidentally? Being flushable > and resumable like this isn't explicitly part of the "contract" for > nvenc, as far as I can see

Re: [FFmpeg-devel] Append to fmp4

2019-12-21 Thread Daniel Oberhoff
> Am 19.12.2019 um 22:46 schrieb Jun Li : > > On Thu, Dec 19, 2019 at 4:00 AM Daniel Oberhoff < > danieloberh...@googlemail.com> wrote: > >> Hello. >> >> I have been diving deep into the mp4 spec to understand fragmented mp4. >> From what I understand using moof atoms it is possible, given str

Re: [FFmpeg-devel] [PATCH] avfilter/vf_fade: add support for gbrp/gbrap formats

2019-12-21 Thread Paul B Mahol
will apply ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] Fix spelling in ID3v1 genres and extend the list of Winamp extensions.

2019-12-21 Thread Michael Niedermayer
On Sat, Dec 21, 2019 at 09:07:40AM +0100, Ulrich Spörlein wrote: > Source: https://en.wikipedia.org/wiki/List_of_ID3v1_Genres and taglib. Please use a more "primary" source than wikipedia thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I know you won't b

Re: [FFmpeg-devel] [PATCH] avcodec/hevcdec: keep closed captions in sync between multiple thread contexts

2019-12-21 Thread James Almer
On 12/20/2019 10:59 PM, Limin Wang wrote: > On Fri, Dec 20, 2019 at 02:05:42PM -0300, James Almer wrote: >> Based on h264 code. >> >> Signed-off-by: James Almer >> --- >> libavcodec/hevcdec.c | 7 +++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/libavcodec/hevcdec.c b/libavcodec/hevc

[FFmpeg-devel] [PATCH 14/15] avformat/dashenc: add an option to write a Latency element

2019-12-21 Thread James Almer
Allows to set an intended target latency while streaming that clients can use to measure when using low latency mode. Signed-off-by: James Almer --- libavformat/dashenc.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/libavformat/dashenc.c b/libav

[FFmpeg-devel] [PATCH 03/15] avformat/dashenc: allow splitting fragments following P-Frame reordering

2019-12-21 Thread James Almer
Currently implemented by using the pic_type value from AV_PKT_DATA_QUALITY_STATS packet side data. Signed-off-by: James Almer --- libavformat/dashenc.c | 45 +-- 1 file changed, 43 insertions(+), 2 deletions(-) diff --git a/libavformat/dashenc.c b/libavfo

[FFmpeg-devel] [PATCH 11/15] avformat/movenc: add a flag to enable CMAF compatability

2019-12-21 Thread James Almer
Sets some required constrains and reports compatibility with the relevant compatible brand. Signed-off-by: James Almer --- libavformat/movenc.c | 25 +++-- libavformat/movenc.h | 1 + 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/libavformat/movenc.c b/liba

[FFmpeg-devel] [PATCH 13/15] dashenc: support setting arbitrary HTTP protocol options

2019-12-21 Thread James Almer
From: Anton Khirnov Signed-off-by: James Almer --- libavformat/dashenc.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index a09652495d..18b5fe0b70 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -163,6 +163,7 @@ typedef

[FFmpeg-devel] [PATCH 09/15] avformat/dashenc: add an option to enable low latency Dash manifest

2019-12-21 Thread James Almer
In combination with the streaming option it constrains the value of a few elements, to prevet clients from buffering too much data before starting presentation. Signed-off-by: James Almer --- libavformat/dashenc.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff -

[FFmpeg-devel] [PATCH 15/15] avformat/dashenc: document the new options

2019-12-21 Thread James Almer
Signed-off-by: James Almer --- doc/muxers.texi | 25 ++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index 5d7ff1ab3b..ff9264c2c5 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -236,8 +236,10 @@ This is a deprecated

[FFmpeg-devel] [PATCH 12/15] avformat/dashenc: allow setting custom movflags using format_options

2019-12-21 Thread James Almer
Signed-off-by: James Almer --- libavformat/dashenc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index bddbfd1ec0..a09652495d 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -1443,12 +1443,12 @@ static i

[FFmpeg-devel] [PATCH 10/15] avformat/dashenc: implement DVB-DASH profile

2019-12-21 Thread James Almer
Add new required elements and constrain presence and values for existing ones based on the spec. Signed-off-by: James Almer --- libavformat/dashenc.c | 77 --- 1 file changed, 73 insertions(+), 4 deletions(-) diff --git a/libavformat/dashenc.c b/libavform

[FFmpeg-devel] [PATCH 07/15] avformat/movenc: use AVProducerReferenceTime side data to write the prft atom

2019-12-21 Thread James Almer
If not available, set flags to 24 (bits 4 and 5), to signal the wallclock value is read at the time of writing the atom. Signed-off-by: James Almer --- libavformat/movenc.c | 18 -- libavformat/movenc.h | 1 + 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/libav

[FFmpeg-devel] [PATCH 08/15] avformat/dashenc: Write a Producer Reference Time element

2019-12-21 Thread James Almer
Signed-off-by: James Almer --- libavformat/dashenc.c | 53 --- 1 file changed, 45 insertions(+), 8 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 82941eb459..baed933d6a 100644 --- a/libavformat/dashenc.c +++ b/libavformat/das

[FFmpeg-devel] [PATCH 04/15] avcodec: add a Producer Reference Time AVPacketSideData type

2019-12-21 Thread James Almer
Signed-off-by: James Almer --- libavcodec/avcodec.h | 10 ++ libavcodec/avpacket.c | 22 ++ libavcodec/internal.h | 2 ++ 3 files changed, 34 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 119b32dc1f..4b0e7c0853 100644 --- a/libavcodec/

[FFmpeg-devel] [PATCH 05/15] avcodec/libx264: export Producer Reference Time as packet side data

2019-12-21 Thread James Almer
Taken from Wallclock at the time the frame is submitted to the encoder. Signed-off-by: James Almer --- libavcodec/libx264.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index bfd91bb900..846b78c319 100644 ---

[FFmpeg-devel] [PATCH 02/15] avformat/dashenc: allow setting fragment durations

2019-12-21 Thread James Almer
Implemented as as a frag_duration muxer option and key=value entry in the adaptation_sets muxer option. It has the same syntax as the seg_duration option. A new frag_type option is also introduced to select the kind of fragmentation. Signed-off-by: James Almer --- libavformat/dashenc.c | 84

[FFmpeg-devel] [PATCH 01/15] avformat/dashenc: allow setting segment durations per AdaptationSet

2019-12-21 Thread James Almer
Implemented as as a seg_duration key=value entry in the adaptation_sets muxer option. It has the same syntax as the global seg_duration option, and has precedence over it if set. Signed-off-by: James Almer --- libavformat/dashenc.c | 49 ++- 1 file changed

[FFmpeg-devel] [PATCH 06/15] avformat/utils: make ff_ntp_time() accept a timestamp as input argument

2019-12-21 Thread James Almer
Will be needed by the next patch. Signed-off-by: James Almer --- libavformat/internal.h | 2 +- libavformat/movenc.c | 2 +- libavformat/rtpenc.c | 8 libavformat/rtpenc.h | 1 + libavformat/utils.c| 4 ++-- 5 files changed, 9 insertions(+), 8 deletions(-) diff --git a/libavf

Re: [FFmpeg-devel] [PATCH] avfilter/image2: Add source file path and basename to each packet side data.

2019-12-21 Thread Alexandre Heitor Schmidt
> In the commit msg, > >> libavformat/img2dec.c: Modify image2 demuxer to make available >> two special metadata entries called lavf.image2dec.source_basename >> and lavf.image2dec.source_basename, which represents, respectively, >> the complete path to the source image for the current frame and >

Re: [FFmpeg-devel] [PATCH] avfilter/image2: Add source file path and basename to each packet side data.

2019-12-21 Thread Gyan
On 21-12-2019 10:00 pm, Alexandre Heitor Schmidt wrote: I fixed it again. Some {} weren't escaped by the "@" character, thus causing this error. The new patch follows attached. In the commit msg, libavformat/img2dec.c: Modify image2 demuxer to make available two special metadata entries

Re: [FFmpeg-devel] [PATCH] avfilter/image2: Add source file path and basename to each packet side data.

2019-12-21 Thread Alexandre Heitor Schmidt
Sorry, Nicolas. I'm new here. I'll keep the mails short for sure. Hopefully my next submissions won't take this long to process, as now I know more about how the entire thing works. Even reading the docs regarding patch submissions (which I did), there are things that I had to learn by trial &

Re: [FFmpeg-devel] [PATCH] avfilter/image2: Add source file path and basename to each packet side data.

2019-12-21 Thread Nicolas George
Alexandre Heitor Schmidt (12019-12-21): > I fixed it again. Some {} weren't escaped by the "@" character, thus causing > this error. How did this happen? Did you not build ffmpeg completely (and run FATE) before sending the patch? Also, could you please trim your mails? >250 lines of quote for ju

Re: [FFmpeg-devel] [PATCH] avfilter/image2: Add source file path and basename to each packet side data.

2019-12-21 Thread Alexandre Heitor Schmidt
On 19/12/2019 16:46, Michael Niedermayer wrote: > On Tue, Dec 17, 2019 at 02:30:39PM +, Alexandre Heitor Schmidt wrote: >> On 17/12/2019 00:35, Marton Balint wrote: >>> On Mon, 16 Dec 2019, Alexandre Heitor Schmidt wrote: This is the second time I'm submiting this patch, now modified to b

Re: [FFmpeg-devel] [PATCH] avfilter/image2: Add source file path and basename to each packet side data.

2019-12-21 Thread Alexandre Heitor Schmidt
On 19/12/2019 16:46, Michael Niedermayer wrote: > On Tue, Dec 17, 2019 at 02:30:39PM +, Alexandre Heitor Schmidt wrote: >> On 17/12/2019 00:35, Marton Balint wrote: >>> On Mon, 16 Dec 2019, Alexandre Heitor Schmidt wrote: This is the second time I'm submiting this patch, now modified to b

Re: [FFmpeg-devel] [PATCH 1/3] avformat/movenc: write the major brand also as the first compatible brand

2019-12-21 Thread James Almer
On 12/9/2019 6:07 PM, James Almer wrote: > On 12/3/2019 5:00 PM, James Almer wrote: >> On 12/3/2019 5:19 AM, Michael Niedermayer wrote: >>> On Mon, Dec 02, 2019 at 01:18:36PM -0300, James Almer wrote: Signed-off-by: James Almer --- >>> This is meant to be squashed with patch 2/3, ot

Re: [FFmpeg-devel] AVWriter API

2019-12-21 Thread Nicolas George
Paul B Mahol (12019-12-21): > I doubt that is very good idea or conclusion. If you have technical or practical thoughts about my proposal, please share them in reply to the first message. -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@f

Re: [FFmpeg-devel] AVWriter API

2019-12-21 Thread Paul B Mahol
On 12/21/19, Nicolas George wrote: > Nicolas George (12019-12-08): >> [ TL;DR: a lightweight oo API for functions that need to return a >> string, designed to be as convenient as possible. ] > > Judging on the lack of reaction to this mail, there seems to be no > strong feeling against this. I the

Re: [FFmpeg-devel] [PATCH][DISCUSS] nvenc: Add encoder flush API.

2019-12-21 Thread Dennis Mungai
On Sat, 21 Dec 2019 at 07:12, Philip Langdale wrote: > > On Fri, 20 Dec 2019 19:12:00 -0500 > Dennis Mungai wrote: > > > On Fri, 20 Dec 2019 at 19:03, Josh Allmann > > > > For CLI usage, does this affect the behavior of the global output > > option > > > > -flush_packets 1 > > > > When the NVENC

Re: [FFmpeg-devel] AVWriter API

2019-12-21 Thread Nicolas George
Nicolas George (12019-12-08): > [ TL;DR: a lightweight oo API for functions that need to return a > string, designed to be as convenient as possible. ] Judging on the lack of reaction to this mail, there seems to be no strong feeling against this. I therefore intend to move ahead. Regards, --

Re: [FFmpeg-devel] [PATCH 4/7] avformat/icecast: Use AV_DICT_DONT_STRDUP_VAL to save an av_strdup

2019-12-21 Thread Michael Niedermayer
On Fri, Dec 20, 2019 at 09:32:34AM +0100, Marvin Scholz wrote: > On 10 Nov 2019, at 5:07, Andreas Rheinhardt wrote: > > >This will probably also fix CID 1452559, a false positive where Coverity > >claims a double-free occurs, because it thinks that av_dict_set() frees > >its key and value argument

Re: [FFmpeg-devel] [PATCH v2 1/7] fftools/ffmpeg: Fix forward CPB props in to out

2019-12-21 Thread Michael Niedermayer
On Thu, Dec 19, 2019 at 05:43:21PM +0100, Nicolas Gaullier wrote: > CPB side_data is copied when stream-copying (see > init_output_stream_streamcopy()), > but it shall not be copied when the stream is decoded. > --- > fftools/ffmpeg.c | 2 ++ > 1 file changed, 2 insertions(+) will apply thx [.

Re: [FFmpeg-devel] [PATCH] avformat/hls: propagate icy to child AVIOContexts

2019-12-21 Thread Marvin Scholz
On 17 Dec 2019, at 1:17, Marvin Scholz wrote: When the user decides they do not want to to send the Icy-MetaData header, this should be respected for all requests, not just the first one. Fix #5578 --- libavformat/hls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavf

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: propagate icy to child AVIOContexts

2019-12-21 Thread Marvin Scholz
On 17 Dec 2019, at 1:45, Marvin Scholz wrote: When the user decides they do not want to to send the Icy-MetaData header, this should be respected for all requests, not just the first one. Fix #5578 --- libavformat/dashdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/li

[FFmpeg-devel] [PATCH] Fix spelling in ID3v1 genres and extend the list of Winamp extensions.

2019-12-21 Thread Ulrich Spörlein
Source: https://en.wikipedia.org/wiki/List_of_ID3v1_Genres and taglib. Further patches to harmonize the spelling have been sent to taglib and libid3tag. --- Note that neither taglib nor libid3tag use the typos for Psychedelic or A cappella. Preserving these typos is IMHO not worth it, spec be damn