> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Carl Eugen Hoyos
> Sent: Wednesday, December 11, 2019 18:19
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH] lavc/hevc_cabac: fix cbf_cb and cbf_cr
> for transform depth 4
>
>
On Wed, Dec 11, 2019 at 11:33 PM Zhao Zhili wrote:
>
> Ping for review, thanks!
>
> > On Dec 4, 2019, at 6:57 PM, quinkbl...@foxmail.com wrote:
> >
> > From: Zhao Zhili
> >
> > ---
> > patch v4: update doc
> >
> > doc/filters.texi| 8
> > libavfilter/buffersrc.c | 14
On 2019/12/11 下午10:19, Andriy Gelman wrote:
On Wed, 11. Dec 09:01, _ FgoDt wrote:
did someone review the patch?
发件人: _ FgoDt
发送时间: 2019年11月15日 15:03
收件人: ffmpeg-devel@ffmpeg.org
抄送: _ FgoDt
主题: [PATCH 1/1] add without_captureblt option for libavdevice/gdigra
Hi James,
> I see now, this is during demuxing. I was thinking about muxing.
> I can reproduce what you mean with TrueHD which has sync frames every
> 128 or so frames. Despite the mp4 and matroska files having the sync
> frames correctly marked, lavf tags every frame as key.
>
> A general approac
From: Xinpeng Sun
It performs HDR(High Dynamic Range) to SDR(Standard Dynamic Range) conversion
with tone-mapping. It only supports HDR10 as input temporarily.
An example command to use this filter with vaapi codecs:
FFMPEG -hwaccel vaapi -vaapi_device /dev/dri/renderD128 -hwaccel_output_format
On Wed, Dec 11, 2019 at 11:58 PM Michael Niedermayer
wrote:
> On Wed, Dec 11, 2019 at 10:50:54PM +0100, Andreas Rheinhardt wrote:
> > On Wed, Dec 11, 2019 at 10:38 PM James Almer wrote:
> >
> > > On 12/11/2019 6:03 PM, Michael Niedermayer wrote:
> > > > Its unclear if shortening these NAL units
The IVF muxer autoinserts the av1_metadata filter unconditionally, which is
not desirable for these tests.
Signed-off-by: James Almer
---
tests/fate/cbs.mak | 6 +++---
tests/ref/fate/cbs-av1-av1-1-b10-23-film_grain-50 | 2 +-
tests/ref/fate/cbs-av1-av1-1-b8-02-a
On 12/11/2019 9:33 PM, Michael Niedermayer wrote:
> On Thu, Dec 12, 2019 at 12:15:14AM +0100, Michael Niedermayer wrote:
>> On Wed, Dec 11, 2019 at 07:00:06PM -0300, James Almer wrote:
>>> Taking into account the code
>>>
>>> fb(2, ar_coeff_lag);
>>> num_pos_luma = 2 * current->ar_coeff_lag * (curr
On Thu, Dec 12, 2019 at 12:15:14AM +0100, Michael Niedermayer wrote:
> On Wed, Dec 11, 2019 at 07:00:06PM -0300, James Almer wrote:
> > Taking into account the code
> >
> > fb(2, ar_coeff_lag);
> > num_pos_luma = 2 * current->ar_coeff_lag * (current->ar_coeff_lag + 1);
> > if (current->num_y_point
> -Original Message-
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of
> Guo, Yejun
> Sent: Thursday, November 28, 2019 4:44 PM
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH 4/4] fate/filter-video: add two tests for
> dnn_p
On Wed, Dec 11, 2019 at 10:50 PM Andreas Rheinhardt <
andreas.rheinha...@gmail.com> wrote:
> On Wed, Dec 11, 2019 at 10:38 PM James Almer wrote:
>
>> On 12/11/2019 6:03 PM, Michael Niedermayer wrote:
>> > Its unclear if shortening these NAL units would have no effect on them
>> >
>> > Fixes: asse
On Wed, Dec 11, 2019 at 07:00:06PM -0300, James Almer wrote:
> Taking into account the code
>
> fb(2, ar_coeff_lag);
> num_pos_luma = 2 * current->ar_coeff_lag * (current->ar_coeff_lag + 1);
> if (current->num_y_points)
> num_pos_chroma = num_pos_luma + 1;
> else
> num_pos_chroma = num_pos
On Wed, Dec 11, 2019 at 10:50:54PM +0100, Andreas Rheinhardt wrote:
> On Wed, Dec 11, 2019 at 10:38 PM James Almer wrote:
>
> > On 12/11/2019 6:03 PM, Michael Niedermayer wrote:
> > > Its unclear if shortening these NAL units would have no effect on them
> > >
> > > Fixes: assertion failure
> > >
Hi,
On Wed, Dec 11, 2019 at 5:00 PM James Almer wrote:
> Taking into account the code
>
> fb(2, ar_coeff_lag);
> num_pos_luma = 2 * current->ar_coeff_lag * (current->ar_coeff_lag + 1);
> if (current->num_y_points)
> num_pos_chroma = num_pos_luma + 1;
> else
> num_pos_chroma = num_pos_lum
Taking into account the code
fb(2, ar_coeff_lag);
num_pos_luma = 2 * current->ar_coeff_lag * (current->ar_coeff_lag + 1);
if (current->num_y_points)
num_pos_chroma = num_pos_luma + 1;
else
num_pos_chroma = num_pos_luma;
Max value for ar_coeff_lag is 3 (two bits), for num_pos_luma 24, and
On Wed, Dec 11, 2019 at 10:38 PM James Almer wrote:
> On 12/11/2019 6:03 PM, Michael Niedermayer wrote:
> > Its unclear if shortening these NAL units would have no effect on them
> >
> > Fixes: assertion failure
> > Fixes:
> 19286/clusterfuzz-testcase-minimized-ffmpeg_BSF_H264_REDUNDANT_PPS_fuzze
On 12/11/2019 6:03 PM, Michael Niedermayer wrote:
> "It is a requirement of bitstream conformance that num_y_points is less than
> or equal to 14."
>
> Fixes: index 24 out of bounds for type 'uint8_t [24]'
> Fixes:
> 19282/clusterfuzz-testcase-minimized-ffmpeg_BSF_AV1_FRAME_MERGE_fuzzer-57474248
On 12/11/2019 6:03 PM, Michael Niedermayer wrote:
> Its unclear if shortening these NAL units would have no effect on them
>
> Fixes: assertion failure
> Fixes:
> 19286/clusterfuzz-testcase-minimized-ffmpeg_BSF_H264_REDUNDANT_PPS_fuzzer-5707990724509696
>
> Found-by: continuous fuzzing process
"It is a requirement of bitstream conformance that num_y_points is less than or
equal to 14."
Fixes: index 24 out of bounds for type 'uint8_t [24]'
Fixes:
19282/clusterfuzz-testcase-minimized-ffmpeg_BSF_AV1_FRAME_MERGE_fuzzer-5747424845103104
Found-by: continuous fuzzing process
https://github
Its unclear if shortening these NAL units would have no effect on them
Fixes: assertion failure
Fixes:
19286/clusterfuzz-testcase-minimized-ffmpeg_BSF_H264_REDUNDANT_PPS_fuzzer-5707990724509696
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
S
Fixes: Timeout(35sec -> 4sec)
Fixes:
19289/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RASC_fuzzer-5676526398078976
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer
---
tools/target_dec_fuzzer.c | 1 +
On 12/10/2019 10:54 PM, Fei Wang wrote:
> rename enable_intraintra_compound to enable_interintra_compound,
> which keep same as AV1 sepc(v1.0.0-errata1).
>
> Signed-off-by: Fei Wang
> ---
> libavcodec/cbs_av1.h | 2 +-
> libavcodec/cbs_av1_syntax_template.c | 4 ++--
> libavforma
On 12/11/2019 7:15 AM, Tsuchiya, Yuki (SHES) wrote:
> Hello James,
>
> On 2019/12/10 22:30, "James Almer" wrote:
>
> >> diff --git a/libavformat/utils.c b/libavformat/utils.c
> >> index 8196442dd1..70f9e23d8c 100644
> >> --- a/libavformat/utils.c
> >> +++ b/libavformat/utils.c
>
On 12/11/2019 1:37 PM, Gyan wrote:
> A few typos:
>
> (in commit title)
> OpenSLL --> OpenSSL
>
> On 11-12-2019 09:45 pm, James Almer wrote:
>> They have been removed altogheter without a compat implementatino, and
>> are
> altogheter --> altogether
>
> implementatino --> implementation
Amended
A few typos:
(in commit title)
OpenSLL --> OpenSSL
On 11-12-2019 09:45 pm, James Almer wrote:
They have been removed altogheter without a compat implementatino, and are
altogheter --> altogether
implementatino --> implementation
Gyan
___
ffmpeg-dev
They have been removed altogheter without a compat implementatino, and are
either no-ops or return NULL.
This fixes compiler warnings about checks always evaluating to false, and leaks
of allocated mutexes.
Signed-off-by: James Almer
---
libavformat/tls_openssl.c | 6 +++---
1 file changed, 3 in
On Tue, Dec 10, 2019 at 02:41:43AM +0100, Andreas Rheinhardt wrote:
> The packet a demuxer receives is freshly initialized, hence it is
> unnecessary to reset any flags on them (as none are set), yet apc did
> this.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavformat/apc.c | 1 -
> 1 file
Ping for review, thanks!
> On Dec 4, 2019, at 6:57 PM, quinkbl...@foxmail.com wrote:
>
> From: Zhao Zhili
>
> ---
> patch v4: update doc
>
> doc/filters.texi| 8
> libavfilter/buffersrc.c | 14 --
> libavfilter/version.h | 5 -
> 3 files changed, 20 insertions
On Mon, Dec 09, 2019 at 12:52:45PM +0100, Andreas Rheinhardt wrote:
> On Mon, Dec 9, 2019 at 2:54 AM James Almer wrote:
>
> > On 12/8/2019 6:31 PM, Michael Niedermayer wrote:
> > > This allows writing empty slices
> >
> > Are empty slices valid in mpeg2 to begin with? Or is that the result of
> >
From: Limin Wang
Signed-off-by: Limin Wang
---
libavcodec/cbs_h2645.c | 93 ++
libavcodec/cbs_h265.h | 25 ++
2 files changed, 118 insertions(+)
diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c
index 5f71d80..2fc957d 1006
From: Limin Wang
Signed-off-by: Limin Wang
---
doc/bitstream_filters.texi | 8 ++
libavcodec/h265_metadata_bsf.c | 65 +-
2 files changed, 72 insertions(+), 1 deletion(-)
diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi
index
On Tue, Dec 10, 2019 at 11:12 PM Andriy Gelman
wrote:
> On Mon, 09. Dec 23:25, Andreas Rheinhardt wrote:
> > While CBS itself uses size_t for sizes, it relies on other APIs that use
> > int for their sizes; in particular, AVBuffer uses int for their size
> > parameters and so does GetBitContext w
On Sun, Dec 01, 2019 at 11:26:47PM +0100, Michael Niedermayer wrote:
> Fixes: out of array read
> Fixes:
> 19129/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_V210_fuzzer-5068171023482880
> Maybe fixes:
> 19130/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_V210_fuzzer-5637264407527424
>
On Wed, Dec 11, 2019 at 11:21:14AM +0200, Martin Storsjö wrote:
> As the values generated by av_bmg_get can be arbitrarily large
> (only the stddev is specified), we can't use a fixed tolerance.
>
> This matches what was done for test_vector_dmul_scalar in
> 38f966bdb.
>
> This fixes the floa
Am Mi., 11. Dez. 2019 um 13:21 Uhr schrieb Martin Storsjö :
>
> This fixes compilation with old mingw.org toolchains, which has got
> much fewer errno.h entries.
> ---
> There's still a couple fate instances that use mingw.org headers/libs,
> and this is the only detail that currently stops them fr
Am Mi., 11. Dez. 2019 um 12:14 Uhr schrieb Andreas Rheinhardt
:
>
> When an incomplete header is encountered, apng_read_header would under
> certain circumstances only return the return value of the last
> successfull call. So override this by returning AVERROR(EIO) manually.
What does this fix /
Am Mi., 11. Dez. 2019 um 14:30 Uhr schrieb Moritz Barsnick :
>
> On Wed, Dec 11, 2019 at 16:52:17 +0800, Linjie Fu wrote:
> > Subject: lavf/zf_zscale: remove unused code
> ^ vf_
While there, change "lavf" to lavfi or avfilter
Carl Eugen
On Wed, 11 Dec 2019, James Almer wrote:
On 12/11/2019 4:43 AM, Martin Storsjö wrote:
The tremolo filter uses floating point internally, and uses
multiplication factors derived from sin(fmod()), neither of
which is bitexact for use with framecrc.
This fixes running this test with mingw/x86_32 b
On Wed, 11. Dec 09:01, _ FgoDt wrote:
> did someone review the patch?
>
>
> 发件人: _ FgoDt
> 发送时间: 2019年11月15日 15:03
> 收件人: ffmpeg-devel@ffmpeg.org
> 抄送: _ FgoDt
> 主题: [PATCH 1/1] add without_captureblt option for libavdevice/gdigrab.c, when
> useing the bitblt f
On 12/11/2019 4:43 AM, Martin Storsjö wrote:
> The tremolo filter uses floating point internally, and uses
> multiplication factors derived from sin(fmod()), neither of
> which is bitexact for use with framecrc.
>
> This fixes running this test with mingw/x86_32 binaries when run
> in wine on linu
On Wed, Dec 11, 2019 at 16:52:17 +0800, Linjie Fu wrote:
> Subject: lavf/zf_zscale: remove unused code
^ vf_
;-)
Moritz
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscrib
This fixes compilation with old mingw.org toolchains, which has got
much fewer errno.h entries.
---
There's still a couple fate instances that use mingw.org headers/libs,
and this is the only detail that currently stops them from building.
---
libavformat/network.h | 3 +++
1 file changed, 3 inser
For this particular function, it's only required to return nonzero,
but use the common AVERROR() pattern for consistency.
---
libavformat/rtsp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
index 859defa592..cd6fc32a29 100644
--- a/lib
These functions already free it themselves before they allocate the new
extradata.
Signed-off-by: Andreas Rheinhardt
---
Resending because I got the commit title wrong: There is no
ff_allocate_extradata.
libavformat/avidec.c | 2 --
libavformat/cafdec.c | 7 ++-
libavformat/conc
Signed-off-by: Andreas Rheinhardt
---
Resending because of a merge conflict due to the other change.
libavformat/apngdec.c | 31 ---
1 file changed, 12 insertions(+), 19 deletions(-)
diff --git a/libavformat/apngdec.c b/libavformat/apngdec.c
index 65332c3fc5..424b450
Am Mi., 11. Dez. 2019 um 09:57 Uhr schrieb Linjie Fu :
>
> The max transform depth is 5(from 0 to 4), so we need 5 cabac states for
> cbf_cb and cbf_cr.
>
> See Table 9-4 for details.
Does this change the output of a file?
If yes, please provide it / implement a fate test.
Carl Eugen
When an incomplete header is encountered, apng_read_header would under
certain circumstances only return the return value of the last
successfull call. So override this by returning AVERROR(EIO) manually.
Signed-off-by: Andreas Rheinhardt
---
libavformat/apngdec.c | 2 ++
1 file changed, 2 inser
On Wed, 11 Dec 2019, Carl Eugen Hoyos wrote:
Am Mi., 11. Dez. 2019 um 09:39 Uhr schrieb Martin Storsjö :
When testing on a memory limited system, these tests consume a
significant amount of memory and can often fail if testing by running
multiple processes in parallel.
---
Adjusted to use ALLY
On 11-12-2019 11:45 am, Gyan wrote:
On 10-12-2019 07:30 pm, Gyan wrote:
Regards,
Gyan
Will push soon.
Pushed as 78676ee8f81269937afdcaa2d9bb7bf77f53c1ba
Gyan
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/lis
Am Mi., 11. Dez. 2019 um 09:39 Uhr schrieb Martin Storsjö :
>
> When testing on a memory limited system, these tests consume a
> significant amount of memory and can often fail if testing by running
> multiple processes in parallel.
> ---
> Adjusted to use ALLYES instead of a -yes-yes construct.
>
Hello James,
On 2019/12/10 22:30, "James Almer" wrote:
>> diff --git a/libavformat/utils.c b/libavformat/utils.c
>> index 8196442dd1..70f9e23d8c 100644
>> --- a/libavformat/utils.c
>> +++ b/libavformat/utils.c
>> @@ -1021,7 +1021,8 @@ static int is_intra_only(enum AVCodecID
As the values generated by av_bmg_get can be arbitrarily large
(only the stddev is specified), we can't use a fixed tolerance.
This matches what was done for test_vector_dmul_scalar in
38f966bdb.
This fixes the float_dsp checkasm test for some seeds, when built
with clang for mingw/x86_32.
--
As the values generated by av_bmg_get can be arbitrarily large
(only the stddev is specified), we can't use a fixed tolerance.
Calculate a dynamic tolerance (like in float_dsp from 38f966bdb),
based on the individual steps of the calculation.
This fixes running this test with certain seeds, wh
Signed-off-by: Linjie Fu
---
libavfilter/vf_zscale.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/libavfilter/vf_zscale.c b/libavfilter/vf_zscale.c
index db2dd17..bd5825f 100644
--- a/libavfilter/vf_zscale.c
+++ b/libavfilter/vf_zscale.c
@@ -287,13 +287,6 @@ static int config_props(A
did someone review the patch?
发件人: _ FgoDt
发送时间: 2019年11月15日 15:03
收件人: ffmpeg-devel@ffmpeg.org
抄送: _ FgoDt
主题: [PATCH 1/1] add without_captureblt option for libavdevice/gdigrab.c, when
useing the bitblt function with CAPTUREBLT it caused the mouse cursor flick
Introduced since 4b4a02b8.
Signed-off-by: Linjie Fu
---
libavcodec/utils.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/libavcodec/utils.c b/libavcodec/utils.c
index 75e7035..8a49234 100644
--- a/libavcodec/utils.c
+++ b/libavcodec/utils.c
@@ -654,12 +654,12 @
The max transform depth is 5(from 0 to 4), so we need 5 cabac states for
cbf_cb and cbf_cr.
See Table 9-4 for details.
Signed-off-by: Xu Guangxin
Signed-off-by: Linjie Fu
---
libavcodec/hevc_cabac.c | 42 +-
1 file changed, 21 insertions(+), 21 deletions
Signed-off-by: Linjie Fu
---
libavcodec/mips/h264pred_init_mips.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/libavcodec/mips/h264pred_init_mips.c
b/libavcodec/mips/h264pred_init_mips.c
index 63637b8..e537ad8 100644
--- a/libavcodec/mips/h264pred_init_mips.c
+++ b/libavcodec/mips/h264p
Fix overflow for coeff -32768 in function ADD_RES_SSE_16_32_8 with no
performance drop.(SSE2/AVX/AVX2)
./checkasm --test=hevc_add_res --bench
Mainline:
- hevc_add_res.add_residual [OK]
hevc_add_res_32x32_8_sse2: 127.5
hevc_add_res_32x32_8_avx: 127.0
hevc_add_res_32x32_8_avx2: 86.5
Fix overflow for coeff -32768 in function ADD_RES_SSE_8_8 with
no performance drop.
./checkasm --test=hevc_add_res --bench
Mainline:
- hevc_add_res.add_residual [OK]
hevc_add_res_8x8_8_sse2: 15.5
Add overflow test case:
- hevc_add_res.add_residual [FAILED]
After:
- hevc_add_res.add_re
Fix overflow for coeff -32768 in function ADD_RES_MMX_4_8 with no
performance drop.
./checkasm --test=hevc_add_res --bench
Mainline:
- hevc_add_res.add_residual [OK]
hevc_add_res_4x4_8_mmxext: 15.5
Add overflow test case:
- hevc_add_res.add_residual [FAILED]
After:
- hevc_add_res.add_
Add overflow test for hevc_add_res when int16_t coeff = -32768.
The result of C is good, while ASM is not.
To verify:
make fate-checkasm-hevc_add_res
ffmpeg/tests/checkasm/checkasm --test=hevc_add_res
./checkasm --test=hevc_add_res
checkasm: using random seed 679391863
MMXEXT:
hevc_ad
When testing on a memory limited system, these tests consume a
significant amount of memory and can often fail if testing by running
multiple processes in parallel.
---
Adjusted to use ALLYES instead of a -yes-yes construct.
Also moved the 2k tests to the same option.
---
configure |
On Wed, Dec 11, 2019 at 6:00 AM Andreas Rheinhardt
wrote:
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavformat/mov.c | 11 ---
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/libavformat/mov.c b/libavformat/mov.c
> index 7553a7fdfc..733f4e4a34 100644
> --- a/libav
> -Original Message-
> From: ffmpeg-devel On Behalf Of Max
> Dmitrichenko
> Sent: Wednesday, November 20, 2019 3:04 PM
> To: FFmpeg development discussions and patches
> Cc: Li, Zhong
> Subject: Re: [FFmpeg-devel] [PATCH, v2] lavc/vaapi_encode: grow packet if
> vaMapBuffer returns multip
65 matches
Mail list logo
