On Thu, Dec 12, 2019 at 12:15:14AM +0100, Michael Niedermayer wrote: > On Wed, Dec 11, 2019 at 07:00:06PM -0300, James Almer wrote: > > Taking into account the code > > > > fb(2, ar_coeff_lag); > > num_pos_luma = 2 * current->ar_coeff_lag * (current->ar_coeff_lag + 1); > > if (current->num_y_points) > > num_pos_chroma = num_pos_luma + 1; > > else > > num_pos_chroma = num_pos_luma; > > > > Max value for ar_coeff_lag is 3 (two bits), for num_pos_luma 24, and for > > num_pos_chroma 25. > > > > Both ar_coeffs_cb_plus_128 and ar_coeffs_cr_plus_128 may have up to > > num_pos_chroma values. > > > > Signed-off-by: James Almer <jamr...@gmail.com> > > --- > > libavcodec/cbs_av1.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > LGTM and i should have realized this when i looked at the fuzzer case
This needs a update to fate though --- ./tests/ref/fate/cbs-av1-av1-1-b8-23-film_grain-50 2019-12-11 15:53:24.616370434 +0100 +++ tests/data/fate/cbs-av1-av1-1-b8-23-film_grain-50 2019-12-12 01:25:39.813093782 +0100 @@ -1 +1 @@ -93e578da4b2bdb70ce0a92262da930ec +2556d6d30469c647c6262130d8eb0531 --- ./tests/ref/fate/cbs-av1-av1-1-b10-23-film_grain-50 2019-12-11 15:53:24.616370434 +0100 +++ tests/data/fate/cbs-av1-av1-1-b10-23-film_grain-50 2019-12-12 01:25:39.825093782 +0100 @@ -1 +1 @@ -5fe6622ac6cb22dd10dfbe9e70e82d4e +aaddbf87bdf9b5ac4b1ab4fe802c410b TEST wmav1-encode Test cbs-av1-av1-1-b8-23-film_grain-50 failed. Look at tests/data/fate/cbs-av1-av1-1-b8-23-film_grain-50.err for details. make: *** [fate-cbs-av1-av1-1-b8-23-film_grain-50] Error 1 Test cbs-av1-av1-1-b10-23-film_grain-50 failed. Look at tests/data/fate/cbs-av1-av1-1-b10-23-film_grain-50.err for details. make: *** [fate-cbs-av1-av1-1-b10-23-film_grain-50] Error 1 Thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB You can kill me, but you cannot change the truth.
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
