Re: [FFmpeg-devel] FFmpeg 4.2

2019-08-03 Thread Michael Niedermayer
On Sun, Jul 21, 2019 at 07:11:40PM +0200, Michael Niedermayer wrote: > On Mon, May 20, 2019 at 08:39:45PM +0200, Michael Niedermayer wrote: > > Hi > > > > Its quite some time since 4.1 so its probably getting time to branch > > 4.2. > > > > If there are any bugs you want fixed in 4.2 its probably

[FFmpeg-devel] [PATCH] avformat/assenc: Don't truncate lines to 4095 characters

2019-08-03 Thread Tellow Krinkle
Fixes #6390 Sample file for new test: https://gist.githubusercontent.com/tellowkrinkle/d6a6e328f892dbbacc000ad9c3890644/raw/4f68e56b1f0fab594aae040723722af4f5161a02/longline.ass Signed-off-by: Tellow Krinkle --- libavformat/assenc.c | 4 +++- tests/fate/subtitles.mak | 4 2 files chan

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/atrac9dec: Check grad_range[1] more tightly

2019-08-03 Thread Lynne
Aug 4, 2019, 12:16 AM by mich...@niedermayer.cc: > Alternatively the array could be made bigger but the extra values > would not be read without other changes. > > Fixes: Out of array access > Fixes: > 15658/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ATRAC9_fuzzer-5738260074070016 > > Foun

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/atrac9dec: Replace impossible conditions by assert

2019-08-03 Thread Lynne
Aug 4, 2019, 12:16 AM by mich...@niedermayer.cc: > Signed-off-by: Michael Niedermayer > --- > libavcodec/atrac9dec.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libavcodec/atrac9dec.c b/libavcodec/atrac9dec.c > index 2e23ea44e8..491e889788 100644 > --- a/libavcodec

[FFmpeg-devel] [PATCH 2/3] avcodec/atrac9dec: Replace impossible conditions by assert

2019-08-03 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/atrac9dec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/atrac9dec.c b/libavcodec/atrac9dec.c index 2e23ea44e8..491e889788 100644 --- a/libavcodec/atrac9dec.c +++ b/libavcodec/atrac9dec.c @@ -124,8 +124,7 @@ sta

[FFmpeg-devel] [PATCH 3/3] avcodec/atrac9dec: Check grad_range[1] more tightly

2019-08-03 Thread Michael Niedermayer
Alternatively the array could be made bigger but the extra values would not be read without other changes. Fixes: Out of array access Fixes: 15658/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ATRAC9_fuzzer-5738260074070016 Found-by: continuous fuzzing process https://github.com/google/oss-

[FFmpeg-devel] [PATCH 1/3] avcodec/bink: Add many end of input checks

2019-08-03 Thread Michael Niedermayer
Fixes: Timeout (83sec -> 15sec) Fixes: 15595/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BINK_fuzzer-5689153263501312 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/bink.c | 52

Re: [FFmpeg-devel] [PATCH] avformat/mpegenc - reject unsupported audio streams

2019-08-03 Thread Carl Eugen Hoyos
> Am 19.07.2019 um 12:44 schrieb Gyan : > > > >> On 17-07-2019 02:23 PM, Carl Eugen Hoyos wrote: >> >> >>> Am 08.07.2019 um 14:05 schrieb Gyan : >>> >>> >>> On 25-04-2019 01:48 PM, Gyan wrote: > On 25-04-2019 01:23 PM, Ali KIZIL wrote: > > There are also Dolb

Re: [FFmpeg-devel] [PATCH] avcodec/encode: only allow undersized audio frames if they are the last

2019-08-03 Thread Marton Balint
On Sat, 3 Aug 2019, Lynne wrote: Aug 3, 2019, 9:40 PM by c...@passwd.hu: Otherwise the user might get a silence padded frame in the beginning or in the middle of the encoding. Some other bug uncovered this: ./ffmpeg -loglevel verbose -y -f data -i /dev/zero \ -filter_complex "nullsrc=s=60x

Re: [FFmpeg-devel] [PATCH] avcodec/encode: only allow undersized audio frames if they are the last

2019-08-03 Thread Lynne
Aug 3, 2019, 9:40 PM by c...@passwd.hu: > Otherwise the user might get a silence padded frame in the beginning or in the > middle of the encoding. > > Some other bug uncovered this: > > ./ffmpeg -loglevel verbose -y -f data -i /dev/zero \ > -filter_complex "nullsrc=s=60x60:d=10[v0];sine=d=10[a]" \

[FFmpeg-devel] [PATCH] avcodec/encode: only allow undersized audio frames if they are the last

2019-08-03 Thread Marton Balint
Otherwise the user might get a silence padded frame in the beginning or in the middle of the encoding. Some other bug uncovered this: ./ffmpeg -loglevel verbose -y -f data -i /dev/zero \ -filter_complex "nullsrc=s=60x60:d=10[v0];sine=d=10[a]" \ -map '[v0]' -c:v:0 rawvideo \ -map '[a]' -c:a:0 mp2

Re: [FFmpeg-devel] [PATCH] Extract QP from h264 encoded videos

2019-08-03 Thread Michael Niedermayer
On Thu, Aug 01, 2019 at 04:48:32PM -0700, Juan De León wrote: > Fixed > > design doc: > https://docs.google.com/document/d/1WClt3EqhjwdGXhEw386O0wfn3IBQ1Ib-_5emVM1gbnA/edit?usp=sharing > > Signed-off-by: Juan De León > --- > libavutil/Makefile | 2 + > libavutil/frame.h

Re: [FFmpeg-devel] [PATCH] Extract QP from h264 encoded videos

2019-08-03 Thread Michael Niedermayer
On Mon, Jul 29, 2019 at 11:12:34AM -0700, Juan De León wrote: > Here is the second patch, I sent the first one twice accidentaly. > First patch is libavutil, this patch is libavcodec. > > Signed-off-by: Juan De León > --- > libavcodec/avcodec.h | 1 + > libavcodec/h264dec.c | 44 ++

Re: [FFmpeg-devel] [PATCH] Extract QP from h264 encoded videos

2019-08-03 Thread Michael Niedermayer
On Thu, Aug 01, 2019 at 04:48:32PM -0700, Juan De León wrote: > Fixed That would end in the commit message which is probably unintended > > design doc: > https://docs.google.com/document/d/1WClt3EqhjwdGXhEw386O0wfn3IBQ1Ib-_5emVM1gbnA/edit?usp=sharing > > Signed-off-by: Juan De León > --- >

Re: [FFmpeg-devel] [PATCHv2 1/4] avformat/mpegtsenc: fix incorrect PCR selection with multiple programs

2019-08-03 Thread Andriy Gelman
On Sat, 03. Aug 10:19, Marton Balint wrote: > The MPEG-TS muxer had a serious bug related to the use of multiple programs: > in that case, the PCR pid selection was incomplete for all services except > one. > This patch solves this problem and selects a stream to become PCR for each > service, pre

[FFmpeg-devel] [RFC] samples.ffmpeg.org

2019-08-03 Thread Michael Niedermayer
Hi all It seems we do not have a list of people volunteering to do uploads to samples. And no place to send such requests to except here, where they sometimes get ignored. Also i do NOT volunteer to do these uploads. I think i never did volunteer but if i did i withdraw that now. I think my time

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/hnm4video: Forward errors of decode_interframe_v4()

2019-08-03 Thread Michael Niedermayer
On Sat, Aug 03, 2019 at 04:09:27PM +0200, Tomas Härdin wrote: > lör 2019-08-03 klockan 01:49 +0200 skrev Michael Niedermayer: > > Fixes: Timeout (108sec -> 160ms) > > Fixes: > > 15570/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HNM4_VIDEO_fuzzer-5085482213441536 > > > > Found-by: continuous

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/hnm4video: Optimize postprocess_current_frame()

2019-08-03 Thread Michael Niedermayer
On Sat, Aug 03, 2019 at 04:07:22PM +0200, Tomas Härdin wrote: > lör 2019-08-03 klockan 01:49 +0200 skrev Michael Niedermayer: > > -uint32_t x, y, src_x, src_y; > > +uint32_t x, y, src_y; > > +int width = hnm->width; > > > > for (y = 0; y < hnm->height; y++) { > > +uint8_t

Re: [FFmpeg-devel] [PATCH 7/7] avformat/dashenc: fix writting the AV1 codec string in mp4 mode

2019-08-03 Thread James Almer
On 8/2/2019 11:13 AM, James Almer wrote: > On 7/30/2019 5:19 PM, James Almer wrote: >> From https://aomediacodec.github.io/av1-isobmff/#codecsparam, the parameters >> sample entry 4CC, profile, level, tier, and bitDepth are all mandatory >> fields. >> All the other fields are optional, mutually in

Re: [FFmpeg-devel] [PATCH] avformat/mpegenc - reject unsupported audio streams

2019-08-03 Thread Gyan
On 19-07-2019 04:14 PM, Gyan wrote: On 17-07-2019 02:23 PM, Carl Eugen Hoyos wrote: Am 08.07.2019 um 14:05 schrieb Gyan : On 25-04-2019 01:48 PM, Gyan wrote: On 25-04-2019 01:23 PM, Ali KIZIL wrote: There are also Dolby Codecs (ac3 & eac3). Will it also throw error for these cod

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/interplayvideo: Avoid ff_get_buffer() during init

2019-08-03 Thread Michael Niedermayer
On Thu, Jul 11, 2019 at 11:49:38PM +0200, Michael Niedermayer wrote: > This is unneeded for interplay video > > Fixes: memleak > Fixes: > 15562/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_INTERPLAY_VIDEO_fuzzer-5162268645392384 > > Found-by: continuous fuzzing process > https://github.com

Re: [FFmpeg-devel] [PATCH 2/4] avformat/vividas: Check that value from ffio_read_varlen() does not overflow

2019-08-03 Thread Michael Niedermayer
On Sun, Jul 21, 2019 at 12:08:54AM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: -1241665686 + -1340629419 cannot be > represented in type 'int' > Fixes: > 15922/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5692826442006528 > > Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [PATCH 1/4] avformat/vividas: forward errors from track_header()

2019-08-03 Thread Michael Niedermayer
On Sun, Jul 21, 2019 at 12:08:53AM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavformat/vividas.c | 12 > 1 file changed, 8 insertions(+), 4 deletions(-) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0F

Re: [FFmpeg-devel] [PATCH 4/6] avformat/vividas: Check if extradata was read successfully

2019-08-03 Thread Michael Niedermayer
On Sat, Jul 13, 2019 at 10:25:04PM +0200, Michael Niedermayer wrote: > Fixes: OOM > Fixes: > 15575/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5654666781655040 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Mich

Re: [FFmpeg-devel] [PATCH 6/6] avcodec/clearvideo: fix invalid shift in tile size check

2019-08-03 Thread Michael Niedermayer
On Sat, Jul 13, 2019 at 10:25:06PM +0200, Michael Niedermayer wrote: > Fixes: left shift of 1 by 31 places cannot be represented in type 'int' > Fixes: > 15631/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CLEARVIDEO_fuzzer-5690110605000704 > > Found-by: continuous fuzzing process > https://

Re: [FFmpeg-devel] [PATCH 3/6] avformat/vividas: Check buffer size before allocation

2019-08-03 Thread Michael Niedermayer
On Sat, Jul 13, 2019 at 10:25:03PM +0200, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 15365/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5716153105645568 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Sig

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/hnm4video: Forward errors of decode_interframe_v4()

2019-08-03 Thread Tomas Härdin
lör 2019-08-03 klockan 01:49 +0200 skrev Michael Niedermayer: > Fixes: Timeout (108sec -> 160ms) > Fixes: > 15570/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HNM4_VIDEO_fuzzer-5085482213441536 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/project

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/hnm4video: Optimize postprocess_current_frame()

2019-08-03 Thread Tomas Härdin
lör 2019-08-03 klockan 01:49 +0200 skrev Michael Niedermayer: > -uint32_t x, y, src_x, src_y; > +uint32_t x, y, src_y; > +int width = hnm->width; > > for (y = 0; y < hnm->height; y++) { > +uint8_t *dst = hnm->processed + y * width; > +const uint8_t *src = hnm->cur

Re: [FFmpeg-devel] [PATCH 2/3] avformat: Support s337m in mxf/wav/w64

2019-08-03 Thread Tomas Härdin
tor 2019-08-01 klockan 16:34 + skrev Gaullier Nicolas: > > > > MXF has a UL registered for Dolby-E: > > I also notice this UL is already in mxf.c, but added commented out > > by Baptiste back in 2006.. > There are two ways for signalling dolby-E in MXF : channel status IF > using an AES3 descri

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/vp8: do vp7_fade_frame() later

2019-08-03 Thread Michael Niedermayer
On Sat, Aug 03, 2019 at 11:44:06AM +1000, Peter Ross wrote: > On Fri, Aug 02, 2019 at 07:19:11PM +0200, Michael Niedermayer wrote: > > On Fri, Aug 02, 2019 at 10:46:04PM +1000, Peter Ross wrote: > > > On Thu, Aug 01, 2019 at 11:44:39PM +0200, Michael Niedermayer wrote: > > > > Fixes: Timeout (100se

[FFmpeg-devel] [PATCH] avcodec/dirac_parser: Fix overflow in dts

2019-08-03 Thread Michael Niedermayer
Fixes: signed integer overflow: -2147483648 - 1 cannot be represented in type 'int' Fixes: 15568/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DIRAC_fuzzer-5634719611355136 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Mic

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/pictordec: Optimize picmemset() for single plane full lines

2019-08-03 Thread Michael Niedermayer
On Sat, Aug 03, 2019 at 12:43:32PM +1000, Peter Ross wrote: > On Sat, Aug 03, 2019 at 01:49:54AM +0200, Michael Niedermayer wrote: > > Fixes: Timeout (72sec -> 1sec) > > Fixes: > > 15512/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PICTOR_fuzzer-5663942342344704 > > > > Found-by: continuous

Re: [FFmpeg-devel] [PATCH] avcodec/vp3: Check that theora is theora

2019-08-03 Thread Michael Niedermayer
On Wed, Jul 24, 2019 at 02:40:08PM +0200, Michael Niedermayer wrote: > Theora is forced to be non zero if it is zero and a sample > is asked for, as suggested by reimar > > Fixes: Timeout (2min -> 600ms) > Fixes: > 15366/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_THEORA_fuzzer-573784993824

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/vp3: Check for end of input in vp4_unpack_vlcs()

2019-08-03 Thread Michael Niedermayer
On Sat, Aug 03, 2019 at 11:45:17AM +1000, Peter Ross wrote: > On Sat, Aug 03, 2019 at 01:49:52AM +0200, Michael Niedermayer wrote: > > Fixes: Timeout (too long -> 1sec) > > Fixes: > > 15232/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP3_fuzzer-5769583086010368 > > > > Found-by: continuous

[FFmpeg-devel] [PATCHv2 1/4] avformat/mpegtsenc: fix incorrect PCR selection with multiple programs

2019-08-03 Thread Marton Balint
The MPEG-TS muxer had a serious bug related to the use of multiple programs: in that case, the PCR pid selection was incomplete for all services except one. This patch solves this problem and selects a stream to become PCR for each service, preferably the video stream. This patch also moves pcr ca