On Sat, Aug 03, 2019 at 11:44:06AM +1000, Peter Ross wrote: > On Fri, Aug 02, 2019 at 07:19:11PM +0200, Michael Niedermayer wrote: > > On Fri, Aug 02, 2019 at 10:46:04PM +1000, Peter Ross wrote: > > > On Thu, Aug 01, 2019 at 11:44:39PM +0200, Michael Niedermayer wrote: > > > > Fixes: Timeout (100sec -> 5sec) > > > > Fixes: > > > > 15073/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP7_fuzzer-5649257362620416 > > > > > > > > Untested as none of the vp7 samples i found executes this codepath > > > > > > see attached. its all i can find :( > > > > iam not sure iam making a mistake but these 2 files dont seem to execute > > it > > you are right michael. the samples attached have alpha/beta fade bits, but > they are both set to zero, therefore fade() is never called. > > i dug up my old vp7-dev branch, and found alpha/beta were forced to > specifically > test the fade path with those samples. e.g.: > > int alpha = (int8_t) vp8_rac_get_uint(c, 8) + 1; > int beta = (int8_t) vp8_rac_get_uint(c, 8) + 1; > > all my other vp7 samples stop before the alpha/beta frame bits.
ok, tested with same "+1" ill push my change as that seems the most that can be reasonable be done. maybe we should ask for a sample if this codepath executes ? > > > also, this sample has alpha/beta set to non-zero, but was generated through > fuzzing and produces no video. > https://trac.ffmpeg.org/attachment/ticket/3501/vp7_1_f.avi > > cheers, > > -- Peter > (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) Thanks! [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The real ebay dictionary, page 1 "Used only once" - "Some unspecified defect prevented a second use" "In good condition" - "Can be repaird by experienced expert" "As is" - "You wouldnt want it even if you were payed for it, if you knew ..."
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
