Re: [FFmpeg-devel] [PATCH] avfilter/vf_unsharp: enable slice threading

2019-05-09 Thread Song, Ruiling
> -Original Message- > From: Song, Ruiling > Sent: Thursday, May 9, 2019 3:43 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Song, Ruiling > Subject: [PATCH] avfilter/vf_unsharp: enable slice threading > > Signed-off-by: Ruiling Song > --- > libavfilter/unsharp.h| 4 +- > libavfilter/vf_un

Re: [FFmpeg-devel] [PATCH] swscale: Add support for NV24 and NV42

2019-05-09 Thread Lauri Kasanen
On Thu, 9 May 2019 22:59:12 -0700 Philip Langdale wrote: > I don't think this is terribly useful, as the only thing out there that > can even handle NV24 content is VDPAU and the only time you have to > deal with it is when doing VDPAU OpenGL interop where swscale is > irrelevant. In the other c

[FFmpeg-devel] [PATCH] swscale: Add support for NV24 and NV42

2019-05-09 Thread Philip Langdale
I don't think this is terribly useful, as the only thing out there that can even handle NV24 content is VDPAU and the only time you have to deal with it is when doing VDPAU OpenGL interop where swscale is irrelevant. In the other cases you can use YV24 (YUV444P). But anyway, I was asked to do this

[FFmpeg-devel] [PATCH v12 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-05-09 Thread Jing Sun
Signed-off-by: Zhengxu Huang Signed-off-by: Hassene Tmar Signed-off-by: Jun Zhao Signed-off-by: Jing Sun --- configure| 4 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/libsvt_hevc.c | 518 +++ lib

Re: [FFmpeg-devel] [PATCH v12 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-05-09 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Sun, Jing A > Sent: Friday, May 10, 2019 1:30 PM > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH v12 1/2] lavc/svt_hevc: add libsvt hevc > encoder wrapper > > -Original Message

Re: [FFmpeg-devel] [PATCH v12 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-05-09 Thread Sun, Jing A
-Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Li, Zhong Sent: Friday, May 10, 2019 1:23 PM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v12 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper >The better

Re: [FFmpeg-devel] [PATCH v12 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-05-09 Thread Li, Zhong
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of James Almer > Sent: Friday, May 10, 2019 12:05 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v12 1/2] lavc/svt_hevc: add libsvt hevc > encoder wrapper > > >You used av_

Re: [FFmpeg-devel] [PATCH v12 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-05-09 Thread Sun, Jing A
-Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of James Almer Sent: Friday, May 10, 2019 12:05 PM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH v12 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper >You used av_mallocz() to all

[FFmpeg-devel] [PATCH v12 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-05-09 Thread Jing Sun
Signed-off-by: Zhengxu Huang Signed-off-by: Hassene Tmar Signed-off-by: Jun Zhao Signed-off-by: Jing Sun --- configure| 4 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/libsvt_hevc.c | 517 +++ lib

Re: [FFmpeg-devel] [PATCH v12 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-05-09 Thread James Almer
On 5/10/2019 1:41 AM, Jing Sun wrote: > +if (avctx->flags & AV_CODEC_FLAG_GLOBAL_HEADER) { > +EB_BUFFERHEADERTYPE *header_ptr = NULL; > + > +svt_ret = EbH265EncStreamHeader(svt_enc->svt_handle, &header_ptr); > +if (svt_ret != EB_ErrorNone) { > +av_log(avctx,

[FFmpeg-devel] [PATCH v12 2/2] doc: Add libsvt_hevc encoder docs

2019-05-09 Thread Jing Sun
Add docs for libsvt_hevc encoder in encoders.texi and general.texi Signed-off-by: Jun Zhao Signed-off-by: Zhengxu Huang Signed-off-by: Hassene Tmar Signed-off-by: Jing Sun --- doc/encoders.texi | 141 ++ doc/general.texi | 8 2 files

[FFmpeg-devel] [PATCH v12 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-05-09 Thread Jing Sun
Signed-off-by: Zhengxu Huang Signed-off-by: Hassene Tmar Signed-off-by: Jun Zhao Signed-off-by: Jing Sun --- configure| 4 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/libsvt_hevc.c | 518 +++ lib

[FFmpeg-devel] [PATCH] avcodec/arbc: Skip tiles in fill_tileX() which are completely outside

2019-05-09 Thread Michael Niedermayer
Fixes: signed integer overflow: 2052526848 + 147237888 cannot be represented in type 'int' Fixes: 14441/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ARBC_fuzzer-5717632944177152 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-b

Re: [FFmpeg-devel] movie Filter reload Option

2019-05-09 Thread TalkVideo
This command pretty much works for me: /usr/local/bin/ffmpeg -loglevel 40 -re -y -i Input.flv -c:v libx264 -x264-params "nal-hrd=vbr" -filter_complex "copy[in2]; movie=overlay.flv,setpts=N/FRAME_RATE/TB,scale=640:360[tmp2]; [tmp2]loop=3:60:1[tmp3]; [in2][tmp3]overlay=70:100:shortest=0:repe

[FFmpeg-devel] [PATCH v2] fix issues with transparent crop. (see https://trac.ffmpeg.org/ticket/7890)

2019-05-09 Thread Bjorn Roche
From: Jacob Graff Resolves issues with some transparent gifs. see https://trac.ffmpeg.org/ticket/7890 contribution by Jacob Graff --- libavcodec/gif.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/gif.c b/libavcodec/gif.c index 94c8b1af49..d7768b44

Re: [FFmpeg-devel] [PATCH] avcodec/scpr: check remaining data after decode

2019-05-09 Thread Michael Niedermayer
On Thu, Apr 25, 2019 at 11:34:49PM +0200, Michael Niedermayer wrote: > Fixes Timeout (29sec -> 14sec) > Fixes: > 13713/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SCPR_fuzzer-5756778069884928 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects

Re: [FFmpeg-devel] [PATCH] avcodec/pafvideo: Check input space for decode_0() before slow operations

2019-05-09 Thread Michael Niedermayer
On Tue, Apr 30, 2019 at 01:29:10AM +0200, Michael Niedermayer wrote: > Fixes: Timeout (11sec -> 2sec) > Fixes: > 14403/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PAF_VIDEO_fuzzer-5697465698746368 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/pro

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/prosumer: Only memset(0) what is needed.

2019-05-09 Thread Michael Niedermayer
On Wed, May 01, 2019 at 09:40:06PM +0200, Michael Niedermayer wrote: > Fixes: Timeout (11sec -> 0.08sec) > Fixes: > 14406/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PROSUMER_fuzzer-5151210148986880 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/p

[FFmpeg-devel] [PATCH 4/4] kmsgrab: Set AVDRMFrameDescriptor.format

2019-05-09 Thread Jonas Karlman
Signed-off-by: Jonas Karlman --- libavdevice/kmsgrab.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavdevice/kmsgrab.c b/libavdevice/kmsgrab.c index d0de774871..1ebc30ea92 100644 --- a/libavdevice/kmsgrab.c +++ b/libavdevice/kmsgrab.c @@ -162,6 +162,7 @@ static int kmsgrab_read_packet(A

[FFmpeg-devel] [PATCH 3/4] rkmppdec: Set AVDRMFrameDescriptor.format

2019-05-09 Thread Jonas Karlman
Signed-off-by: Jonas Karlman --- libavcodec/rkmppdec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/rkmppdec.c b/libavcodec/rkmppdec.c index 143d05bd51..3ea64d867e 100644 --- a/libavcodec/rkmppdec.c +++ b/libavcodec/rkmppdec.c @@ -419,6 +419,7 @@ static int rkmpp_retrieve_frame(

[FFmpeg-devel] [PATCH 1/4] hwcontext_drm: Add AVDRMFrameDescriptor.format field

2019-05-09 Thread Jonas Karlman
A AVDRMFrameDescriptor for a NV12 frame may be described in a single layer descriptor with multiple planes, (AVDRMFrameDescriptor) { .nb_layers = 1, .layers[0] = { .format = DRM_FORMAT_NV12, .nb_planes= 2, .planes[0] = { .object_index =

[FFmpeg-devel] [PATCH 2/4] hwcontext_vaapi: Set AVDRMFrameDescriptor.format in map_from

2019-05-09 Thread Jonas Karlman
Signed-off-by: Jonas Karlman --- libavutil/hwcontext_vaapi.c | 38 + 1 file changed, 38 insertions(+) diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c index 8624369bb9..d55eccbdcf 100644 --- a/libavutil/hwcontext_vaapi.c +++ b/libavutil/h

[FFmpeg-devel] [PATCH 0/4] Add AVDRMFrameDescriptor.format field

2019-05-09 Thread Jonas Karlman
Hello, When a multi-layer AVDRMFrameDescriptor is used to describe a frame the overall frame format is missing and applications need to deduce the frame DRM_FORMAT_* based on sw_format or the layers format. This patchset adds a AVDRMFrameDescriptor.format field to remove any ambiguity of what fra

Re: [FFmpeg-devel] [PATCH]lavf/utils: Do not read "@" without ":" as user name separator

2019-05-09 Thread Nicolas George
Carl Eugen Hoyos (12019-05-05): > I apparently missed the part of the rfc where a slash is > forbidden for the password. https://tools.ietf.org/html/rfc3986 userinfo= *( unreserved / pct-encoded / sub-delims / ":" ) unreserved = ALPHA / DIGIT / "-" / "." / "_" / "~" sub-del

[FFmpeg-devel] [PATCH] avcodec/cbs: add missing comment about AV1 specific CodedBitstreamUnitType definition

2019-05-09 Thread James Almer
Signed-off-by: James Almer --- libavcodec/cbs.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/cbs.h b/libavcodec/cbs.h index 967dcd1468..65b3fe4fe9 100644 --- a/libavcodec/cbs.h +++ b/libavcodec/cbs.h @@ -45,6 +45,7 @@ struct CodedBitstreamType; /** * The codec-specific type o

[FFmpeg-devel] [PATCH v4] lavf/h264: add support for h264 video from Arecont camera, fixes ticket #5154

2019-05-09 Thread Shivam Goyal
The patch is for ticket #5154. Support for h264 stream from Arecont Camera, The video contains a http header at several places in the stream, which makes it not possible to demux, the structure of the http header is- --fbdr Content-Type: video/H.264I ETag: Channel=1 ( there are two CR+LF ch

Re: [FFmpeg-devel] [PATCH] fix issues with transparent crop. (see https://trac.ffmpeg.org/ticket/7890)

2019-05-09 Thread Carl Eugen Hoyos
> Am 09.05.2019 um 18:23 schrieb Bjorn Roche : > > This patch should be attributed to Jacob Graff . Then please resend with the correct attribution. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo

Re: [FFmpeg-devel] [PATCH] fix issues with transparent crop. (see https://trac.ffmpeg.org/ticket/7890)

2019-05-09 Thread Bjorn Roche
This patch should be attributed to Jacob Graff . On Thu, May 9, 2019 at 10:37 AM Bjorn Roche wrote: > From: Bjorn Roche > > --- > libavcodec/gif.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/libavcodec/gif.c b/libavcodec/gif.c > index 94c8b1af49..d7768

Re: [FFmpeg-devel] [PATCH v3] Fix sdp size check on fmtp integer parameters

2019-05-09 Thread Olivier MAIGNIAL
Hello, Just a reminder about this patch :) On Fri, Apr 19, 2019 at 3:00 PM Olivier Maignial wrote: > RFC-4566 do not give any limit of size on interger parameters given in > fmtp line. > By reading some more RFCs it is possible to find examples where some > integers parameters are greater than 3

Re: [FFmpeg-devel] [PATCH 1/3] lavf/cover_rect: Fix logic check issue

2019-05-09 Thread Michael Niedermayer
On Thu, May 09, 2019 at 01:32:26AM +0800, Jun Zhao wrote: > From: Jun Zhao > > Fix logic check issue #6741 > > Signed-off-by: Jun Zhao > --- > libavfilter/vf_cover_rect.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B

Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/matroskadec: Check parents remaining length

2019-05-09 Thread Andreas Rheinhardt
Michael Niedermayer: > On Sun, Feb 17, 2019 at 09:53:03AM +, Steve Lhomme wrote: >> ffmpeg | branch: master | Steve Lhomme | Wed Feb 13 >> 13:20:45 2019 +0100| [9326117bf63b04a466d9e787224e56ba8cdbb215] | committer: >> Michael Niedermayer >> >> avformat/matroskadec: Check parents remaining l

Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/matroskadec: Check parents remaining length

2019-05-09 Thread Michael Niedermayer
On Sun, Feb 17, 2019 at 09:53:03AM +, Steve Lhomme wrote: > ffmpeg | branch: master | Steve Lhomme | Wed Feb 13 > 13:20:45 2019 +0100| [9326117bf63b04a466d9e787224e56ba8cdbb215] | committer: > Michael Niedermayer > > avformat/matroskadec: Check parents remaining length > > This was found t

Re: [FFmpeg-devel] [PATCH v2 2/2] fftools/ffmpeg: Add stream metadata from first frame's metadata

2019-05-09 Thread Paul B Mahol
On 5/9/19, Nicolas George wrote: > Paul B Mahol (12019-05-09): >> Merging of what filters? > > transpose and rotate when it is an integer quarter of turns. But > apparently they are already merged. > >> Your reasoning is illogical. > > Your reasoning is absent. > Give mathematical proof.

Re: [FFmpeg-devel] [DECISION] scaletempo filter

2019-05-09 Thread Paul B Mahol
On 5/9/19, Nicolas George wrote: > Paul B Mahol (12019-05-09): >> Also atempo does not do pitch adjustments. > > Pitch and speed adjustments are the same thing. Give mathematical proof. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpe

[FFmpeg-devel] [PATCH] fix issues with transparent crop. (see https://trac.ffmpeg.org/ticket/7890)

2019-05-09 Thread Bjorn Roche
From: Bjorn Roche --- libavcodec/gif.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/gif.c b/libavcodec/gif.c index 94c8b1af49..d7768b4426 100644 --- a/libavcodec/gif.c +++ b/libavcodec/gif.c @@ -136,7 +136,7 @@ static void gif_crop_translucent(AVCod

Re: [FFmpeg-devel] [DECISION] scaletempo filter

2019-05-09 Thread Nicolas George
Paul B Mahol (12019-05-09): > Also atempo does not do pitch adjustments. Pitch and speed adjustments are the same thing. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg

Re: [FFmpeg-devel] [PATCH v2 2/2] fftools/ffmpeg: Add stream metadata from first frame's metadata

2019-05-09 Thread Nicolas George
Paul B Mahol (12019-05-09): > Merging of what filters? transpose and rotate when it is an integer quarter of turns. But apparently they are already merged. > Your reasoning is illogical. Your reasoning is absent. -- Nicolas George signature.asc Description: PGP signature __

Re: [FFmpeg-devel] [PATCH] libavfilter: Add multiple padding methods in FFmpeg dnn native mode.

2019-05-09 Thread xwmeng
> -原始邮件- > 发件人: "Guo, Yejun" > 发送时间: 2019-05-09 09:52:46 (星期四) > 收件人: "FFmpeg development discussions and patches" > 抄送: > 主题: Re: [FFmpeg-devel] [PATCH] libavfilter: Add multiple padding methods in > FFmpeg dnn native mode. > > > > > -Original Message- > > From: ffmpeg-de

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: Disable copy_ts on timestamp wraparound

2019-05-09 Thread Aleksey Skripka
Greetings! > On 3 May 2019, at 18:36, Michael Niedermayer wrote: > > This allows handling more than 26.5h of mpeg* input > > Fixes: Ticket 7876 > not sure how this correlated, but facing my '26.5 hours problem' i found next: running on plain ts-file is ok: ./ffmpeg -copyts -i 27hours.ts -c c

Re: [FFmpeg-devel] [DECISION] scaletempo filter

2019-05-09 Thread Paul B Mahol
On 5/9/19, Paul B Mahol wrote: > On 5/9/19, Nicolas George wrote: >> Paul B Mahol (12019-05-09): >>> I got into possession of code that is better than atempo for very >>> small scale factors (0.5). >>> >>> So I gonna write new filter which would also be able to change both >>> tempo and pitch at

Re: [FFmpeg-devel] [PATCH v2 2/2] fftools/ffmpeg: Add stream metadata from first frame's metadata

2019-05-09 Thread Paul B Mahol
On 5/9/19, Nicolas George wrote: > Jun Li (12019-05-09): >> I see transpose filter and vflip/hvlip filter, but could not find >> "transform". > > I do not think I suggested a filter with that name exists. > >> are you suggesting creating a new one achieve both transpose and flip, or >> modify tra

Re: [FFmpeg-devel] [DECISION] scaletempo filter

2019-05-09 Thread Paul B Mahol
On 5/9/19, Nicolas George wrote: > Paul B Mahol (12019-05-09): >> I got into possession of code that is better than atempo for very >> small scale factors (0.5). >> >> So I gonna write new filter which would also be able to change both >> tempo and pitch at same time. > > My requirements stay the

Re: [FFmpeg-devel] [DECISION] scaletempo filter

2019-05-09 Thread Nicolas George
Paul B Mahol (12019-05-09): > I got into possession of code that is better than atempo for very > small scale factors (0.5). > > So I gonna write new filter which would also be able to change both > tempo and pitch at same time. My requirements stay the same: If it does the same thing, then it b

Re: [FFmpeg-devel] [PATCH v2 2/2] fftools/ffmpeg: Add stream metadata from first frame's metadata

2019-05-09 Thread Nicolas George
Jun Li (12019-05-09): > I see transpose filter and vflip/hvlip filter, but could not find > "transform". I do not think I suggested a filter with that name exists. > are you suggesting creating a new one achieve both transpose and flip, or > modify transpose to support flip ? You will also need

Re: [FFmpeg-devel] [PATCH v2 2/2] fftools/ffmpeg: Add stream metadata from first frame's metadata

2019-05-09 Thread Jun Li
On Thu, May 9, 2019 at 2:29 AM Nicolas George wrote: > Jun Li (12019-05-09): > > The image's exif ("orientation") info is kept inside of frame metadata, > > maybe the filter can directly read from frame, instead of re-config > > the stream level metadata ? > > That is exactly what I was suggestin

Re: [FFmpeg-devel] [PATCH v3] lavf/h264: add support for h264 video from Arecont camera, fixes ticket #5154

2019-05-09 Thread Shivam Goyal
On 09-05-2019 15:00, Moritz Barsnick wrote: > On Thu, May 09, 2019 at 07:28:20 +0530, Shivam Goyal wrote: +//Extra to > find the http header > +size = 2 * ARECONT_H264_MIME_SIZE + RAW_PACKET_SIZE; > +data = av_malloc(size); > + > +if (av_new_packet(pkt, size) < 0) > +retur

Re: [FFmpeg-devel] [PATCH v3] lavf/h264: add support for h264 video from Arecont camera, fixes ticket #5154

2019-05-09 Thread Moritz Barsnick
On Thu, May 09, 2019 at 07:28:20 +0530, Shivam Goyal wrote: > >> +//Extra to find the http header > >> +size = 2 * ARECONT_H264_MIME_SIZE + RAW_PACKET_SIZE; > >> +data = av_malloc(size); > >> + > >> +if (av_new_packet(pkt, size) < 0) > >> +return AVERROR(ENOMEM); > > > > mem

Re: [FFmpeg-devel] [PATCH v2 2/2] fftools/ffmpeg: Add stream metadata from first frame's metadata

2019-05-09 Thread Nicolas George
Jun Li (12019-05-09): > The image's exif ("orientation") info is kept inside of frame metadata, > maybe the filter can directly read from frame, instead of re-config > the stream level metadata ? That is exactly what I was suggesting. Regards, -- Nicolas George signature.asc Description: PG

Re: [FFmpeg-devel] [PATCH v2 2/2] fftools/ffmpeg: Add stream metadata from first frame's metadata

2019-05-09 Thread Jun Li
On Thu, May 9, 2019 at 1:52 AM Nicolas George wrote: > Jun Li (12019-05-06): > > I agree with it that the patch can't solve the case that "not all frames > > have the same orientation". > > The only way I can think of (correct me if I am wrong) is a filter that > > dynamic do tranformation per fr

Re: [FFmpeg-devel] [PATCH 2/3] tools/crypto_bench: check malloc fail before using it

2019-05-09 Thread myp...@gmail.com
On Thu, May 9, 2019 at 4:53 PM Nicolas George wrote: > > Jun Zhao (12019-05-09): > > From: Jun Zhao > > > > Need to check malloc fail before using it, so adjust the location > > in the code. > > > > Signed-off-by: Jun Zhao > > --- > > tools/crypto_bench.c |8 +--- > > 1 files changed, 5

Re: [FFmpeg-devel] [PATCH 3/3] tools/crypto_bench: update the comment about build command

2019-05-09 Thread myp...@gmail.com
On Thu, May 9, 2019 at 4:55 PM Nicolas George wrote: > > Jun Zhao (12019-05-09): > > From: Jun Zhao > > > > commit cd62f9d557f missing the comment about build > > > > Signed-off-by: Jun Zhao > > --- > > tools/crypto_bench.c |2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > LGT

Re: [FFmpeg-devel] [PATCH] avfilter/avf_aphasemeter: Add out-of-phase and mono detection

2019-05-09 Thread Marc-Antoine ARNAUD
Few remarks: - For performances you have to align your data in the structure AudioPhaseMeterContext: don't mix float, float array and bool. Put bool at the end to align memory access. - Use complete name and it's not a setter: set_meta, name it add_metadata. - use inline functions for these functio

Re: [FFmpeg-devel] [PATCH] avfilter/avf_aphasemeter: Add out-of-phase and mono detection

2019-05-09 Thread Paul B Mahol
On 5/9/19, Romane Lafon wrote: > This patch extends aphasemeter filter to display metadata for out-of-phase > or mono sequences of stereo streams. > Displays start, end and duration as for silencedetect filter. > We do not do: true/false thing. Use 1/0. __

[FFmpeg-devel] [PATCH v1] lavf/mov: Fix timestamp rescale on sidx atom

2019-05-09 Thread Jun Li
Fix #5090 Fix the timestamp rescale issue, from sidx timebase to stream's timebase. --- libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 78f692872b..d058855e6c 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@

Re: [FFmpeg-devel] [PATCH 3/3] tools/crypto_bench: update the comment about build command

2019-05-09 Thread Nicolas George
Jun Zhao (12019-05-09): > From: Jun Zhao > > commit cd62f9d557f missing the comment about build > > Signed-off-by: Jun Zhao > --- > tools/crypto_bench.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) LGTM. Regards, -- Nicolas George signature.asc Description: PGP signatu

Re: [FFmpeg-devel] [PATCH 2/3] tools/crypto_bench: check malloc fail before using it

2019-05-09 Thread Nicolas George
Jun Zhao (12019-05-09): > From: Jun Zhao > > Need to check malloc fail before using it, so adjust the location > in the code. > > Signed-off-by: Jun Zhao > --- > tools/crypto_bench.c |8 +--- > 1 files changed, 5 insertions(+), 3 deletions(-) Ok. Regards, -- Nicolas George sign

Re: [FFmpeg-devel] [PATCH v2 2/2] fftools/ffmpeg: Add stream metadata from first frame's metadata

2019-05-09 Thread Nicolas George
Jun Li (12019-05-06): > I agree with it that the patch can't solve the case that "not all frames > have the same orientation". > The only way I can think of (correct me if I am wrong) is a filter that > dynamic do tranformation per frame. > > From a technical perspective, this kind of media is abs

[FFmpeg-devel] [PATCH] avfilter/avf_aphasemeter: Add out-of-phase and mono detection

2019-05-09 Thread Romane Lafon
This patch extends aphasemeter filter to display metadata for out-of-phase or mono sequences of stereo streams. Displays start, end and duration as for silencedetect filter. From 763cd15c156be8ef7c577519e57bf14990adcf69 Mon Sep 17 00:00:00 2001 From: Romane Lafon Date: Wed, 8 May 2019 17:59:29 +02

Re: [FFmpeg-devel] movie Filter reload Option

2019-05-09 Thread TalkVideo
On Wed, May 08, 2019 at 07:26:16PM -0400, talkvi...@talkvideo.net wrote: > Please see this (very Short) thread for background. It is > incorporated here. > > http://ffmpeg.org/pipermail/ffmpeg-devel/2019-May/243721.html > > The drawtext Filter has a reload Option, and when I use overlay > with a