Re: [FFmpeg-devel] [PATCH 1/2] avcodec/videotoolboxenc: fix undefined behavior with rc_max_rate=0

On Fri, Jul 6, 2018, at 09:21, Kári Helgason wrote: > Sorry for jumping in with a slightly OT question, > > Am I understanding correctly that you have noticed that when using kVTCompre > ssionPropertyKey_DataRateLimits you will sometimes get random garbage from > the encoder in the output callbac

[FFmpeg-devel] [PATCH 2/2] lavc/hevc_ps: use skip_bits instead of get_bits when skip bits.

use skip_bits when want to skip some bits. Signed-off-by: Jun Zhao --- libavcodec/hevc_ps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/hevc_ps.c b/libavcodec/hevc_ps.c index bc5406b..278b928 100644 --- a/libavcodec/hevc_ps.c +++ b/libavcodec/hevc_ps.c @@ -1679

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/videotoolboxenc: fix undefined behavior with rc_max_rate=0

On Thu, Jul 5, 2018, at 20:49, Aman Gupta wrote: > On Wed, Jul 4, 2018 at 3:05 AM Thomas Guillem wrote: > > > On macOS, a zero rc_max_rate cause an error from > > VTSessionSetProperty(kVTCompressionPropertyKey_DataRateLimits). > > > > on iOS (depending on device/version), a zero rc_max_rate cau

[FFmpeg-devel] [PATCH 1/2] lavc/hevc_ps: Refine sps_range_extension parse.

Signed-off-by: Jun Zhao --- libavcodec/hevc_ps.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavcodec/hevc_ps.c b/libavcodec/hevc_ps.c index bca3abb..bc5406b 100644 --- a/libavcodec/hevc_ps.c +++ b/libavcodec/hevc_ps.c @@ -1094,11 +1094,9 @@ int ff_hevc_parse_sps(H

Re: [FFmpeg-devel] [PATCH] avfilter/setpts: add FR shorthand for FRAME_RATE

Plan to push tonight if no objections. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Use channel count if channel layout is undefined

On Fri, Jul 06, 2018 at 03:15:58PM +0100, Marcin Gorzel wrote: > Rematrixing supports up to 64 channels but there is only a limited number of > channel layouts defined. Currently, in/out channel count is obtained from the > channel layout so if the channel layout is undefined (e.g. for 9, 10, 11

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Check input sample count

On Fri, Jul 06, 2018 at 02:24:45PM -0700, Baptiste Coudurier wrote: > Hi Michael, > > On Fri, Jul 6, 2018 at 2:09 PM, Michael Niedermayer > wrote: > > > Fixes: division by 0 > > Fixes: fpe_movenc.c_199_1.wav > > Fixes: fpe_movenc.c_199_2.wav > > Fixes: fpe_movenc.c_199_3.wav > > Fixes: fpe_moven

Re: [FFmpeg-devel] [PATCH] lavf/mxfdec: only call mxf_free_metadataset when ctx_size is != 0, otherwise ctx == mxf

On Fri, Jul 06, 2018 at 12:08:07PM -0700, Baptiste Coudurier wrote: > --- > libavformat/mxfdec.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) should be ok thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Many things microsoft did are stup

[FFmpeg-devel] [PATCH] avcodec/aacenc: report channel layout by name

Possibly useful in the error case. Signed-off-by: Moritz Barsnick --- libavcodec/aacenc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/aacenc.c b/libavcodec/aacenc.c index 6d94c76905..4d0abb107f 100644 --- a/libavcodec/aacenc.c +++ b/libavcodec/aacenc.c @@

Re: [FFmpeg-devel] [PATCH v2] lavf/mxfdec: demux s436m as eia608 subtitle track

Hi Derek, On Wed, Jul 4, 2018 at 3:54 PM, Derek Buitenhuis wrote: > On 04/07/2018 23:05, Baptiste Coudurier wrote: > > +if (length < 0) > > +return AVERROR_INVALIDDATA; > > + > > +int array_count = avio_rb32(s->pb); > > +int array_elem_size = avio_rb32(s->pb);

Re: [FFmpeg-devel] [PATCH v3 3/3] aadec: fix seeking in mp3 content

On Fri, Jul 06, 2018 at 10:49:46AM +0200, Karsten Otto wrote: > > > Am 04.07.2018 um 23:54 schrieb Michael Niedermayer : > > > > Signierter PGP-Teil > > On Wed, Jul 04, 2018 at 09:32:32AM +0200, Karsten Otto wrote: > >> > >>> Am 04.07.2018 um 03:26 schrieb Michael Niedermayer > >>> : > >>> > >

Re: [FFmpeg-devel] [PATCH v2] lavf/mxfdec: demux s436m as eia608 subtitle track

Hi Michael, On Thu, Jul 5, 2018 at 5:23 PM, Michael Niedermayer wrote: > On Wed, Jul 04, 2018 at 03:05:58PM -0700, Baptiste Coudurier wrote: > > --- > > libavformat/mxfdec.c | 103 +++ > > 1 file changed, 103 insertions(+) > > This crashes with > > ./ffmp

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Check input sample count

Hi Michael, On Fri, Jul 6, 2018 at 2:09 PM, Michael Niedermayer wrote: > Fixes: division by 0 > Fixes: fpe_movenc.c_199_1.wav > Fixes: fpe_movenc.c_199_2.wav > Fixes: fpe_movenc.c_199_3.wav > Fixes: fpe_movenc.c_199_4.wav > Fixes: fpe_movenc.c_199_5.wav > Fixes: fpe_movenc.c_199_6.wav > Fixes: f

[FFmpeg-devel] [PATCH] avformat/movenc: Check input sample count

Fixes: division by 0 Fixes: fpe_movenc.c_199_1.wav Fixes: fpe_movenc.c_199_2.wav Fixes: fpe_movenc.c_199_3.wav Fixes: fpe_movenc.c_199_4.wav Fixes: fpe_movenc.c_199_5.wav Fixes: fpe_movenc.c_199_6.wav Fixes: fpe_movenc.c_199_7.wav Found-by: #CHEN HONGXU# Signed-off-by: Michael Niedermayer --- l

[FFmpeg-devel] [PATCH] lavf/mxfdec: only call mxf_free_metadataset when ctx_size is != 0, otherwise ctx == mxf

--- libavformat/mxfdec.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index c7f90b29f2..819e4dfeb9 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -2711,7 +2711,8 @@ static int mxf_read_local_tags(MXFContext *m

Re: [FFmpeg-devel] [PATCH 01/12] avformat/mxfenc: automatically update descriptors klv size

2018-07-04 20:35 GMT+02:00, Baptiste Coudurier : > --- > libavformat/mxfenc.c | 80 +--- > 1 file changed, 39 insertions(+), 41 deletions(-) Does any of the patches fix ticket #6693? Thank you, Carl Eugen ___ ffm

[FFmpeg-devel] [PATCH 1/2] avcodec/dvbsub_parser: Do not discard data

May fix: oss fuzz issue 9220 Signed-off-by: Michael Niedermayer --- libavcodec/dvbsub_parser.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/libavcodec/dvbsub_parser.c b/libavcodec/dvbsub_parser.c index e77b9655cc..8ced3c4c34 100644 --- a/libavcodec/dvbsub_

[FFmpeg-devel] [PATCH 2/2] avcodec/mjpegdec: Check for odd progressive RGB

Fixes: out of array access Fixes: 9225/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JPEGLS_fuzzer-5684770334834688 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/mjpegdec.c | 4 1 f

[FFmpeg-devel] [PATCH] Use channel count if channel layout is undefined

Rematrixing supports up to 64 channels but there is only a limited number of channel layouts defined. Currently, in/out channel count is obtained from the channel layout so if the channel layout is undefined (e.g. for 9, 10, 11 channels etc.) the in/out channel count will be 0 and the rematrixin

Re: [FFmpeg-devel] [RFC] New build system

> A newbie question - how would cross-compiling for a target of Win10x64 work, > in say ubuntu still eg per zeranoe's method, or rdp's at > https://github.com/rdp/ffmpeg-windows-build-helpers ? meson has excellent support for cross compilation, you can find more info on this at

Re: [FFmpeg-devel] [RFC] New build system

On 07/06/2018 12:46 PM, Tobias Rapp wrote: > > What are the dependencies besides Meson and Python v3 itself? Meson has no hard dependency apart from python3, if the default backend (ninja) is used, then ninja must indeed also be present on the system. > Is using Ninja mandatory for building or ca

Re: [FFmpeg-devel] [RFC] New build system

> -Original Message- > From: ffmpeg-devel On Behalf Of Tobias Rapp > Sent: Friday, July 6, 2018 8:16 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [RFC] New build system > > On 04.07.2018 16:36, Mathieu Duponchelle wrote: > > [...] > > > > If there are any other questions

Re: [FFmpeg-devel] [RFC] New build system

On 04.07.2018 16:36, Mathieu Duponchelle wrote: [...] If there are any other questions related to meson or the FFmpeg meson port please feel free to ask and I'll do my best to answer them. What are the dependencies besides Meson and Python v3 itself? Is using Ninja mandatory for building or c

[FFmpeg-devel] [PATCH 2/2] avcodec/vp8_parser: Do not leave data/size uninitialized

This is identical to what the VP9 parser does Fixes: 9215/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LIBVPX_VP8_fuzzer-5768227253649408 Fixes: out of memory access This may also fix oss fuzz issue 9212 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/p

[FFmpeg-devel] [PATCH 1/2] tools/target_dec_fuzzer: set parser codec id to avoid assertion failure

Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/target_dec_fuzzer.c b/tools/target_dec_fuzzer.c index 3146bf2c1a..a94d5e6a92 100644 --- a/tools/target_dec_fuzzer.c +++ b/tools/target_dec_fuzzer.c @@ -193,6 +193,7 @@ int LL

[FFmpeg-devel] [PATCH] fate: allow temp files for passed test to be kept

From 18351747e460d52939d54bdf20364e4156852034 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Fri, 6 Jul 2018 14:53:33 +0530 Subject: [PATCH] fate: allow temp files for passed test to be kept Set make variable KEEP to non-zero value to preserve temp files when a test has passed. Helpful in diagn

Re: [FFmpeg-devel] [PATCH 1/6] avformat/mms: Add missing chunksize check

On Tue, Jul 03, 2018 at 11:05:25PM +0200, Michael Niedermayer wrote: > Fixes: out of array read > Fixes: mms-crash-01b6c5d85f9d9f40f4e879896103e9f5b222816a > > Found-by: Paul Ch > Signed-off-by: Michael Niedermayer > --- > libavformat/mms.c | 6 ++ > 1 file changed, 6 insertions(+) will ap

Re: [FFmpeg-devel] [PATCH v3 3/3] aadec: fix seeking in mp3 content

> Am 04.07.2018 um 23:54 schrieb Michael Niedermayer : > > Signierter PGP-Teil > On Wed, Jul 04, 2018 at 09:32:32AM +0200, Karsten Otto wrote: >> >>> Am 04.07.2018 um 03:26 schrieb Michael Niedermayer : >>> >>> Signierter PGP-Teil >>> On Tue, Jul 03, 2018 at 10:25:36PM +0200, Karsten Otto wrote

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/videotoolboxenc: fix undefined behavior with rc_max_rate=0

Sorry for jumping in with a slightly OT question, Am I understanding correctly that you have noticed that when using kVTCompre ssionPropertyKey_DataRateLimits you will sometimes get random garbage from the encoder in the output callback? How frequently does this happen, and can you reproduce it r

Re: [FFmpeg-devel] [PATCH] lavfi/minterpolate: fix blending calc issue.

myp...@gmail.com 于2018年7月4日周三 下午3:05写道： > > On Wed, Jun 27, 2018 at 5:52 PM Jun Zhao wrote: > > > > the right blending calc is: > > (alpha * Frame_2 + (MAX - alpha) * Frame_1 + 512) >> 10 > > > > Signed-off-by: Jun Zhao > > --- > > libavfilter/vf_minterpolate.c | 4 ++-- > > 1 file changed, 2 i