On Fri, Jul 06, 2018 at 03:15:58PM +0100, Marcin Gorzel wrote: > Rematrixing supports up to 64 channels but there is only a limited number of > channel layouts defined. Currently, in/out channel count is obtained from the > channel layout so if the channel layout is undefined (e.g. for 9, 10, 11 > channels etc.) the in/out channel count will be 0 and the rematrixing will > fail. This change adds a check if the channel layout is non-zero, and if not, > prefers to use the in|out_ch_count instead. This seems to be related to > ticket #6790. > --- > libswresample/rematrix.c | 18 ++++++++++++------ > libswresample/x86/rematrix_init.c | 8 ++++++-- > 2 files changed, 18 insertions(+), 8 deletions(-)
Iam not completely sure what this is trying to do exactly but the commit message inadequently describes it. #6790 is already fixed, the commit message doesnt explain how its related also the FFMIN is wrong. If the user provided a value outside the supported range the code must have failed with an error already or something is not working correctly. How can the bug this fixes be reproduced ? Thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I know you won't believe me, but the highest form of Human Excellence is to question oneself and others. -- Socrates
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
