Re: [FFmpeg-devel] [PATCH] ffmpeg: add return value check to suppress the build warning.

is it necessary to check AVERROR_EOF? On Thu, Nov 23, 2017 at 1:14 PM, Jun Zhao wrote: > > > On 2017/11/23 11:00, Carl Eugen Hoyos wrote: > > 2017-11-20 10:07 GMT+01:00 刘歧 : > > > >> diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c > >> index babd85f7bc..0c16e75ab0 100644 > >> --- a/fftools/ffmp

Re: [FFmpeg-devel] [PATCH] ffmpeg: add return value check to suppress the build warning.

On 2017/11/23 11:00, Carl Eugen Hoyos wrote: > 2017-11-20 10:07 GMT+01:00 刘歧 : > >> diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c >> index babd85f7bc..0c16e75ab0 100644 >> --- a/fftools/ffmpeg.c >> +++ b/fftools/ffmpeg.c >> @@ -220,13 +220,18 @@ static void sub2video_push_ref(InputStream *ist,

[FFmpeg-devel] [PATCH] avformat/hlsenc: Added option to add EXT-X-INDEPENDENT-SEGMENTS tag

--- doc/muxers.texi | 4 libavformat/hlsenc.c | 14 ++ 2 files changed, 18 insertions(+) diff --git a/doc/muxers.texi b/doc/muxers.texi index 0bb8ad2..9d9ca31 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -737,6 +737,10 @@ The file specified by @code{hls_key_info_fi

Re: [FFmpeg-devel] [PATCH 1/2] avocdec/ttaenc: buffer packets directly

On 11/20/2017 5:44 PM, James Almer wrote: > This is a bit more robust in case of OOM. > > Signed-off-by: James Almer > --- > libavformat/ttaenc.c | 42 +- > 1 file changed, 33 insertions(+), 9 deletions(-) > > diff --git a/libavformat/ttaenc.c b/libavform

[FFmpeg-devel] [PATCH 2/3] avcodec/libx264:setting profile and level in avcodec context

From: Vishwanath Dixit Signed-off-by: Karthick J --- libavcodec/libx264.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index 9c67c91..eeafe31 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -454,6

[FFmpeg-devel] [PATCH 3/3] avformat/hlsenc:addition of CODECS attribute in the master playlist

From: Vishwanath Dixit Signed-off-by: Karthick J --- libavformat/hlsenc.c | 67 +++- 1 file changed, 66 insertions(+), 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 9fed6a3..32246c4 100644 --- a/libavformat/hlsenc.c

[FFmpeg-devel] [PATCH 1/3] avformat/hlsenc:addition of #EXT-X-MEDIA tag and AUDIO attribute

From: Vishwanath Dixit Signed-off-by: Karthick J --- doc/muxers.texi | 12 ++ libavformat/hlsenc.c | 63 ++-- 2 files changed, 73 insertions(+), 2 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index 0bb8ad2..60b2eb4 100

Re: [FFmpeg-devel] [PATCH] ffmpeg: add return value check to suppress the build warning.

2017-11-20 10:07 GMT+01:00 刘歧 : > diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c > index babd85f7bc..0c16e75ab0 100644 > --- a/fftools/ffmpeg.c > +++ b/fftools/ffmpeg.c > @@ -220,13 +220,18 @@ static void sub2video_push_ref(InputStream *ist, > int64_t pts) > { > AVFrame *frame = ist->sub2

Re: [FFmpeg-devel] avcodec/hapdec : use gray8 for HapAlphaOnly decoding instead of RGB0

2017-11-16 23:41 GMT+01:00 Martin Vignali : > Hello, > > Following previous discussion > patch in attach change pix_fmt for hap alpha only decoding to use gray8 > instead of RGB0 Looks like what you suggested. Thank you, Carl Eugen ___ ffmpeg-devel mail

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/dashenc: Option to generate hls playlist as well

On 11/22/17, 9:06 PM, "Michael Niedermayer" wrote: >On Wed, Nov 22, 2017 at 02:50:12PM +0530, Karthick J wrote: >> >> +static void get_hls_playlist_name(char *playlist_name, const char >> *base_url, int id) { >> +if (base_url) >> +sprintf(playlist_name, "%smedia_%d.m3u8", base_ur

[FFmpeg-devel] [PATCH v3 2/2] avformat/dashenc: Option to generate hls playlist as well

This is to take full advantage of Common Media Application Format. Now server can generate one content and serve both HLS and DASH players. --- doc/muxers.texi | 3 ++ libavformat/dashenc.c | 103 -- 2 files changed, 102 insertions(+), 4 dele

Re: [FFmpeg-devel] [PATCH] Download dash content with byte range info

2017-11-23 6:58 GMT+08:00 Colin NG : > --- > libavformat/dashdec.c | 38 -- > 1 file changed, 32 insertions(+), 6 deletions(-) > > diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c > index 0e3afd2..3798649 100644 > --- a/libavformat/dashdec.c > +++ b/li

Re: [FFmpeg-devel] [Patch] Fix for ticket 6658 (Dash demuxer segfault)

2017-11-23 9:16 GMT+08:00 Colin NG : > Clean up coding style. > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index 3798649..7e7a

Re: [FFmpeg-devel] [PATCH] libavcodec/opus: Add NULL pointer check for incoming data; avoid segfault

2017-11-23 2:02 GMT+01:00 Rostislav Pehlivanov : > On 23 November 2017 at 00:53, Colin NG wrote: > >> --- >> Fix for ticket 7674 6764 > I actually found out about this bug while working on it a few days ago but > wanted to wait until I got the opus_rc and some opusenc_psy improvements > fully do

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-11-23 1:30 GMT+01:00 John Stebbins : > On 11/22/2017 02:36 PM, Carl Eugen Hoyos wrote: >> 2017-08-24 0:39 GMT+02:00 Dale Curtis : >> >>> -sc->ctts_data[ctts_count].count= count; >>> -sc->ctts_data[ctts_count].duration = duration; >>> -ctts_count++; >>> +/* E

[FFmpeg-devel] [Patch] Fix for ticket 6658 (Dash demuxer segfault)

Clean up coding style. diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index 3798649..7e7ae52 100644 --- a/libavformat/dashdec.c +++ b/libavformat/dashdec.c @@ -148,6 +148,11 @@ static uint64_t get_current_time_in_sec(void) return av_gettime() / 100; } +static char *ishttp(c

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

On Wed, 22 Nov 2017, Mark Thompson wrote: On 22/11/17 22:53, Philip Langdale wrote: On Wed, 22 Nov 2017 23:36:23 +0100 Timo Rothenpieler wrote: I'd like to look through it again and test a bit more (will try to do so tomorrow, certainly by the end of the week), but I think it should be rea

Re: [FFmpeg-devel] [PATCH] libavcodec/opus: Add NULL pointer check for incoming data; avoid segfault

On 23 November 2017 at 00:53, Colin NG wrote: > --- > Fix for ticket 7674 > > libavcodec/opus_pvq.c | 16 +--- > 1 file changed, 13 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/opus_pvq.c b/libavcodec/opus_pvq.c > index f98b85d..02ccd69 100644 > --- a/libavcodec/opus_pvq

[FFmpeg-devel] [PATCH] libavcodec/opus: Add NULL pointer check for incoming data; avoid segfault

--- Fix for ticket 7674 libavcodec/opus_pvq.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/libavcodec/opus_pvq.c b/libavcodec/opus_pvq.c index f98b85d..02ccd69 100644 --- a/libavcodec/opus_pvq.c +++ b/libavcodec/opus_pvq.c @@ -504,6 +504,9 @@ static av_alw

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

On 11/22/2017 02:36 PM, Carl Eugen Hoyos wrote: > 2017-08-24 0:39 GMT+02:00 Dale Curtis : > >> -sc->ctts_data[ctts_count].count= count; >> -sc->ctts_data[ctts_count].duration = duration; >> -ctts_count++; >> +/* Expand entries such that we have a 1-1 mapping with

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

On 22/11/17 22:53, Philip Langdale wrote: > On Wed, 22 Nov 2017 23:36:23 +0100 > Timo Rothenpieler wrote: > I'd like to look through it again and test a bit more (will try to do so tomorrow, certainly by the end of the week), but I think it should be ready to commit with the extern

Re: [FFmpeg-devel] [PATCH] Refactor Developer Docs, update dev list section

2017-11-23 0:39 GMT+01:00 Derek Buitenhuis : > On 11/22/2017 11:34 PM, Carl Eugen Hoyos wrote: >> Please understand I am against removing the paragraph from the >> documentation because I believe it is a good idea if developers >> are subscribed to -cvslog. > > Perhaps it can be reworded a bit to s

Re: [FFmpeg-devel] [PATCH] Refactor Developer Docs, update dev list section

On 11/22/2017 11:34 PM, Carl Eugen Hoyos wrote: > Please understand I am against removing the paragraph from the > documentation because I believe it is a good idea if developers > are subscribed to -cvslog. Perhaps it can be reworded a bit to say it's encouraged for the cited reasons, but not man

Re: [FFmpeg-devel] [PATCH 00/15] OpenCL infrastructure, filters

2017-11-23 0:26 GMT+01:00 Mark Thompson : > On 22/11/17 00:59, Carl Eugen Hoyos wrote: >> 2017-11-22 1:30 GMT+01:00 Mark Thompson : >>> On 14/11/17 19:47, Mark Thompson wrote: Changes since the last time this was posted: * Add unsharp filter (to replace existing unsharp). * Remove ol

Re: [FFmpeg-devel] [PATCH] Refactor Developer Docs, update dev list section

2017-11-22 15:03 GMT+01:00 Derek Buitenhuis : > On 11/21/2017 11:40 PM, Carl Eugen Hoyos wrote: >> I am against removing this paragraph. > > He specifically asked if it was required of new developers to subscribe > to this list, in a separate thread, earlier[1]. Paul explicitly said it > was *not*

Re: [FFmpeg-devel] [PATCH 00/15] OpenCL infrastructure, filters

On 22/11/17 00:59, Carl Eugen Hoyos wrote: > 2017-11-22 1:30 GMT+01:00 Mark Thompson : >> On 14/11/17 19:47, Mark Thompson wrote: >>> Changes since the last time this was posted: >>> * Add unsharp filter (to replace existing unsharp). >>> * Remove old experimental API. >>> * Miscellaneous fixes. >>

Re: [FFmpeg-devel] Fix for ticket #6764

2017-11-23 0:24 GMT+01:00 Colin NG : > Add NULL pointer check for incoming audio data. Please commit locally and attach the patch file produced with git format-patch Indentation looks wrong here, consider using tools/patcheck (this may be my mistake tough). Carl Eugen ___

[FFmpeg-devel] Fix for ticket #6764

Add NULL pointer check for incoming audio data. diff --git a/libavcodec/opus_pvq.c b/libavcodec/opus_pvq.c index f98b85d..f1dbc5d 100644 --- a/libavcodec/opus_pvq.c +++ b/libavcodec/opus_pvq.c @@ -504,6 +504,9 @@ static av_always_inline uint32_t quant_band_template(CeltPVQ *pvq, CeltFrame *f,

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Timo Rothenpieler > Sent: November 22, 2017 5:36 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD > GPUs based on AMF SDK > > Am 17.11.20

Re: [FFmpeg-devel] [PATCH] avformat/avienc: fix fields-per-frame value for interlaced video streams

On 11/22/2017 10:52 PM, Carl Eugen Hoyos wrote: > start_line = fields * (i ^ (par->field_order == AV_FIELD_BB || > par->field_order == AV_FIELD_BT)); > > Which are imo less ugly. Can't agree. It's needlessly less readable bit fiddling. - Derek ___ ffm

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/sbrdsp_fixed: Fix integer overflow

On Wed, Nov 22, 2017 at 11:38 PM, Carl Eugen Hoyos wrote: > 2017-11-22 21:00 GMT+01:00 Michael Niedermayer : > >> diff --git a/libavcodec/sbrdsp_fixed.c b/libavcodec/sbrdsp_fixed.c >> index a0ef6859f1..0db932a105 100644 >> --- a/libavcodec/sbrdsp_fixed.c >> +++ b/libavcodec/sbrdsp_fixed.c >> @@ -1

[FFmpeg-devel] [PATCH] Download dash content with byte range info

--- libavformat/dashdec.c | 38 -- 1 file changed, 32 insertions(+), 6 deletions(-) diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index 0e3afd2..3798649 100644 --- a/libavformat/dashdec.c +++ b/libavformat/dashdec.c @@ -522,6 +522,24 @@ static enum

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

On Wed, 22 Nov 2017 23:36:23 +0100 Timo Rothenpieler wrote: > >> I'd like to look through it again and test a bit more (will try to > >> do so tomorrow, certainly by the end of the week), but I think it > >> should be ready to commit with the external header removed. > > > > Are you planning t

Re: [FFmpeg-devel] [PATCH] avformat/avienc: fix fields-per-frame value for interlaced video streams

2017-11-22 16:41 GMT+01:00 Tobias Rapp : > Writes one set of field framing information for progressive streams and > two sets for interlaced streams. Fixes ticket #6383. > > Unfortunately the OpenDML v1.02 document is not very specific what value > to use for start_line when frame data is not comin

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/sbrdsp_fixed: Fix integer overflow

2017-11-22 21:00 GMT+01:00 Michael Niedermayer : > diff --git a/libavcodec/sbrdsp_fixed.c b/libavcodec/sbrdsp_fixed.c > index a0ef6859f1..0db932a105 100644 > --- a/libavcodec/sbrdsp_fixed.c > +++ b/libavcodec/sbrdsp_fixed.c > @@ -133,7 +133,7 @@ static av_always_inline SoftFloat autocorr_calc(int6

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-08-24 0:39 GMT+02:00 Dale Curtis : > -sc->ctts_data[ctts_count].count= count; > -sc->ctts_data[ctts_count].duration = duration; > -ctts_count++; > +/* Expand entries such that we have a 1-1 mapping with samples. */ > +for (j = 0; j < count; j++) > +

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

I'd like to look through it again and test a bit more (will try to do so tomorrow, certainly by the end of the week), but I think it should be ready to commit with the external header removed. Are you planning to remove Nvidia headers as well? No, I am very much against this. And others have a

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

Am 17.11.2017 um 06:07 schrieb mmironov: From 454aad17fea28e8e4c5abb904341181271971bfc Mon Sep 17 00:00:00 2001 From: mmironov Date: Tue, 14 Nov 2017 17:54:24 -0500 Subject: [PATCH] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK Signed-off-by: mmironov --- Changelog

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

Am 17.11.2017 um 06:07 schrieb mmironov: From 454aad17fea28e8e4c5abb904341181271971bfc Mon Sep 17 00:00:00 2001 From: mmironov Date: Tue, 14 Nov 2017 17:54:24 -0500 Subject: [PATCH] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK Signed-off-by: mmironov --- Changelog

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: fix last packet timestamps

On Wed, 22 Nov 2017, Derek Buitenhuis wrote: On 11/22/2017 1:10 AM, Marton Balint wrote: Fixes the packet timestamps of the last packet, which was unset, or guessed by compute_pkt_fields. ffprobe -fflags nofillin -show_packets tests/data/lavf/lavf.mxf -select_streams v Signed-off-by: Marto

Re: [FFmpeg-devel] [PATCH] libavformat/mov: Replace duplicate stream_nb check by assert

On 11/22/2017 8:09 PM, Michael Niedermayer wrote: > not much, no > its a non static function tough > i can remove the check completely if thats preferred ? I guess leave it since it's non-static. LGTM. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] libavformat/mov: Replace duplicate stream_nb check by assert

On Wed, Nov 22, 2017 at 02:09:46PM +, Derek Buitenhuis wrote: > On 11/22/2017 12:04 PM, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/mov.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > If it's a duplicate check, is there even a g

Re: [FFmpeg-devel] [PATCH] Add FAQs about running in background (rev 2)

On 2017-11-22 08:54, Michael Niedermayer wrote: On Wed, Nov 15, 2017 at 12:43:30AM -0800, Jim DeLaHunt wrote: Add two FAQs about running FFmpeg in the background. The first explains the use of the -nostdin option in a straightforward way. Text revised based on review. The second FAQ starts fro

[FFmpeg-devel] [PATCH 1/2] avcodec/kgv1dec: Check that there is enough input for maximum RLE compression

Fixes: Timeout Fixes: 4271/clusterfuzz-testcase-4676667768307712 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/kgv1dec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/kgv1

[FFmpeg-devel] [PATCH 2/2] avcodec/sbrdsp_fixed: Fix integer overflow

Fixes: signed integer overflow: 2147483598 + 64 cannot be represented in type 'int' Fixes: 4337/clusterfuzz-testcase-minimized-6192658616680448 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/

Re: [FFmpeg-devel] [avformat] Prevent undefined shift with wrap_bits > 63.

On Tue, Nov 21, 2017 at 7:05 PM, Michael Niedermayer wrote: > > I dont think wrap_bits can/should be > 64 or do i miss something ? > Good point, this seems true with the current code. > > maybe a av_assert* for that would be better. > Done; used av_assert2(). wrap_bits_v5.patch Description:

[FFmpeg-devel] [vorbis] 1 << 31 > int32_t::max(), so use 1u << 31 instead.

vorbis_fix_v1.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [DEVEL][PATCH 2/2] ffmpeg: fix ticket 6706

sorry wrong patch, discard previous for this one ! From 532b13fb2a174af0b91a0b08984cbdb8d5027392 Mon Sep 17 00:00:00 2001 From: pkviet Date: Sat, 18 Nov 2017 00:26:50 +0100 Subject: [PATCH 2/2] ffmpeg: fix ticket 6706 Fix regression with channel_layout option which is not passed correctly from

Re: [FFmpeg-devel] avcodec/x86/exrdsp : use ymm constant for pb_80 instead of vbroadcasti128

On 11/21/2017 6:09 PM, Martin Vignali wrote: > Hello, > > After patch by James Almer > (pb_80 now fit an ymm) > > The two mode (SSE, AVX2) for constant loading can be remove > > speed seems to be similar to me > > Martin LGTM. ___ ffmpeg-devel mailin

Re: [FFmpeg-devel] [PATCH] Add FAQs about running in background (rev 2)

On Wed, Nov 15, 2017 at 12:43:30AM -0800, Jim DeLaHunt wrote: > Add two FAQs about running FFmpeg in the background. > The first explains the use of the -nostdin option in > a straightforward way. Text revised based on review. > > The second FAQ starts from a confusing error message, > and leads t

Re: [FFmpeg-devel] [PATCH] avfilter: slice processing for geq

On Wed, Nov 22, 2017 at 10:24:30AM +, Marc-Antoine ARNAUD wrote: > New patch version which fixe the last remark. > > > Le ven. 10 nov. 2017 à 00:47, Michael Niedermayer > a écrit : > > > On Thu, Nov 09, 2017 at 10:22:23AM +, Marc-Antoine ARNAUD wrote: > > > Please find the merged patch

Re: [FFmpeg-devel] [PATCH 1/3] Revert "udp: fix compilation when HAVE_PTHREAD_CANCEL isnt defined"

On 11/22/17, Derek Buitenhuis wrote: > This was an mplayer-specific hack. > > This reverts commit a4f94f24b4f153c30bbcaa700bedfb2b3a581e5e. > --- > Near as I can tell, this is a hack added to deal with the fact that the > terrible mplayer build system cannibalized FFmpeg's, and failed at it. > > T

Re: [FFmpeg-devel] [PATCH] avformat/avienc: fix fields-per-frame value for interlaced video streams

On 11/22/2017 3:41 PM, Tobias Rapp wrote: > Writes one set of field framing information for progressive streams and > two sets for interlaced streams. Fixes ticket #6383. > > Unfortunately the OpenDML v1.02 document is not very specific what value > to use for start_line when frame data is not com

[FFmpeg-devel] [PATCH] avformat/avienc: fix fields-per-frame value for interlaced video streams

Writes one set of field framing information for progressive streams and two sets for interlaced streams. Fixes ticket #6383. Unfortunately the OpenDML v1.02 document is not very specific what value to use for start_line when frame data is not coming from a capturing device, so this is just using 0

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/dashenc: Option to generate hls playlist as well

On Wed, Nov 22, 2017 at 02:50:12PM +0530, Karthick J wrote: > This is to take full advantage of Common Media Application Format. > Now server can generate one content and serve both HLS and DASH players. > --- > doc/muxers.texi | 3 ++ > libavformat/dashenc.c | 102 > +

[FFmpeg-devel] [PATCH 2/3] udp: Check the port number provided by av_url_split as per docs

Signed-off-by: Derek Buitenhuis --- libavformat/udp.c | 8 1 file changed, 8 insertions(+) diff --git a/libavformat/udp.c b/libavformat/udp.c index 0dde035..7bbd282 100644 --- a/libavformat/udp.c +++ b/libavformat/udp.c @@ -443,6 +443,10 @@ int ff_udp_set_remote_url(URLContext *h, const

[FFmpeg-devel] [PATCH 3/3] udp: Actually fail when we're missing required options, like the "warning" says.

Signed-off-by: Derek Buitenhuis --- There was no reasoning in the commit that added this, so maybe someone on the list has some insights. --- libavformat/udp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/udp.c b/libavformat/udp.c index 7bbd282..6319655 1006

[FFmpeg-devel] [PATCH 1/3] Revert "udp: fix compilation when HAVE_PTHREAD_CANCEL isnt defined"

This was an mplayer-specific hack. This reverts commit a4f94f24b4f153c30bbcaa700bedfb2b3a581e5e. --- Near as I can tell, this is a hack added to deal with the fact that the terrible mplayer build system cannibalized FFmpeg's, and failed at it. There's no reason this should be in FFmpeg, if that i

[FFmpeg-devel] [PATCH 0/3][RFC] Random UDP bits

Bits that I saw when I was reviewing the OpenSRT code. Derek Buitenhuis (3): Revert "udp: fix compilation when HAVE_PTHREAD_CANCEL isnt defined" udp: Check the port number provided by av_url_split as per docs udp: Actually fail when we're missing required options, like the "warning" says

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: November 21, 2017 7:40 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD > GPUs based on AMF SDK > > On 21/11/17 23:

Re: [FFmpeg-devel] [PATCH] avfilter: slice processing for geq

On 11/22/2017 2:38 PM, Marc-Antoine ARNAUD wrote: > It made sense, but this commit don't touch this part of the code. > It can made more sense to add an another path to "prevent bad memory > allocation in geq filter". What do you think ? Ah, you are correct. A 2nd patch would be nice, yes, but don

Re: [FFmpeg-devel] [PATCH] avfilter: slice processing for geq

It made sense, but this commit don't touch this part of the code. It can made more sense to add an another path to "prevent bad memory allocation in geq filter". What do you think ? Regards, Le mer. 22 nov. 2017 à 15:19, Derek Buitenhuis a écrit : > On 11/22/2017 10:24 AM, Marc-Antoine ARNAUD w

Re: [FFmpeg-devel] [PATCH] avfilter: slice processing for geq

On 11/22/2017 10:24 AM, Marc-Antoine ARNAUD wrote: > New patch version which fixe the last remark. [...] > +char depth_string[8]; > +snprintf(depth_string, sizeof(depth_string), "%d", (1 1); > +geq->expr_str[A] = av_strdup(depth_string); Missing return value c

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: fix last packet timestamps

On 11/22/2017 1:10 AM, Marton Balint wrote: > Fixes the packet timestamps of the last packet, which was unset, or guessed by > compute_pkt_fields. > > ffprobe -fflags nofillin -show_packets tests/data/lavf/lavf.mxf > -select_streams v > > Signed-off-by: Marton Balint > --- > libavformat/mxfdec

Re: [FFmpeg-devel] [PATCH 3/4] avformat/movenc: force colr atom for uncompressed yuv in mov

On 11/22/2017 1:33 PM, Kevin Wheatley wrote: > The guess work comes from this list: > > https://developer.apple.com/library/content/technotes/tn2162/_index.html#//apple_ref/doc/uid/DTS40013070-CH1-TNTAG10-SAMPLE__COLR__SETTINGS It's a mistake to conflate resolutions with the standards listed ther

Re: [FFmpeg-devel] [PATCH] libavformat/mov: Replace duplicate stream_nb check by assert

On 11/22/2017 12:04 PM, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavformat/mov.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) If it's a duplicate check, is there even a gain from using an assert? - Derek _

Re: [FFmpeg-devel] [PATCH] Refactor Developer Docs, update dev list section

On 11/21/2017 11:40 PM, Carl Eugen Hoyos wrote: > I am against removing this paragraph. He specifically asked if it was required of new developers to subscribe to this list, in a separate thread, earlier[1]. Paul explicitly said it was *not* required[2], Timo said no discussion happens on the list

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/hevcdsp: Add NEON optimization for qpel weighted mode

> On 22 Nov 2017, at 20:26, Michael Niedermayer wrote: > > On Wed, Nov 22, 2017 at 07:12:01PM +0800, Shengbin Meng wrote: >> From: Meng Wang >> >> Signed-off-by: Meng Wang >> --- >> libavcodec/arm/hevcdsp_init_neon.c | 66 + >> libavcodec/arm/hevcdsp_qpel_neon.S | 509 >> +++

[FFmpeg-devel] [PATCH v2 4/5] avcodec/hevcdsp: Use pre-load (pld) to optimize data loading

From: Meng Wang Signed-off-by: Meng Wang --- libavcodec/arm/hevcdsp_epel_neon.S | 10 ++ libavcodec/arm/hevcdsp_qpel_neon.S | 24 2 files changed, 30 insertions(+), 4 deletions(-) diff --git a/libavcodec/arm/hevcdsp_epel_neon.S b/libavcodec/arm/hevcdsp_epel_ne

[FFmpeg-devel] [PATCH v2 5/5] avcodec/hevcdsp: Add NEON optimization for sao

From: Meng Wang Signed-off-by: Meng Wang --- libavcodec/arm/Makefile| 3 +- libavcodec/arm/hevcdsp_init_neon.c | 62 + libavcodec/arm/hevcdsp_sao_neon.S | 181 + 3 files changed, 245 insertions(+), 1 deletion(-) create mode 100644

[FFmpeg-devel] [PATCH v2 3/5] avcodec/hevcdsp: Add NEON optimization for whole-pixel interpolation

New code is written for qpel; and then code for qpel is reused for epel, because whole-pixel interpolation in qpel and epel are identical. Signed-off-by: Shengbin Meng --- libavcodec/arm/hevcdsp_init_neon.c | 107 ++ libavcodec/arm/hevcdsp_qpel_neon.S | 177 ++

[FFmpeg-devel] [PATCH v2 2/5] avcodec/hevcdsp: Add NEON optimization for epel

From: Meng Wang Signed-off-by: Meng Wang --- libavcodec/arm/Makefile|3 +- libavcodec/arm/hevcdsp_epel_neon.S | 2068 libavcodec/arm/hevcdsp_init_neon.c | 458 3 files changed, 2528 insertions(+), 1 deletion(-) create mode 100644 l

[FFmpeg-devel] [PATCH v2 1/5] avcodec/hevcdsp: Add NEON optimization for qpel weighted mode

From: Meng Wang Signed-off-by: Meng Wang --- libavcodec/arm/hevcdsp_init_neon.c | 67 + libavcodec/arm/hevcdsp_qpel_neon.S | 509 + 2 files changed, 576 insertions(+) diff --git a/libavcodec/arm/hevcdsp_init_neon.c b/libavcodec/arm/hevcdsp_init_neon.c

Re: [FFmpeg-devel] [PATCH 3/4] avformat/movenc: force colr atom for uncompressed yuv in mov

The guess work comes from this list: https://developer.apple.com/library/content/technotes/tn2162/_index.html#//apple_ref/doc/uid/DTS40013070-CH1-TNTAG10-SAMPLE__COLR__SETTINGS and I agree is the source of a lot of chaos, but it is what several tools have done in the absence of any specified valu

[FFmpeg-devel] [DEVEL][PATCH 2/2] ffmpeg: fix ticket 6706

From 532b13fb2a174af0b91a0b08984cbdb8d5027392 Mon Sep 17 00:00:00 2001 From: pkviet Date: Sat, 18 Nov 2017 00:26:50 +0100 Subject: [PATCH 2/2] ffmpeg: fix ticket 6706 Fix regression with channel_layout option which is not passed correctly from output streams to filters when the channel layout i

[FFmpeg-devel] [DEVEL][PATCH 1/2] ffmpeg: parse duplicate option

Le 19/11/2017 à 8:28 PM, Michael Niedermayer a écrit : On Sun, Nov 19, 2017 at 11:01:37AM +0100, pkv.stream wrote: [...] @@ -3674,6 +3697,10 @@ const OptionDef options[] = { { "channel_layout", OPT_AUDIO | HAS_ARG | OPT_EXPERT | OPT_PERFILE | OPT_INPUT | OPT_OUT

Re: [FFmpeg-devel] [PATCH] fix bug in af_pan channel coefficient parser

On 21.11.2017 20:01, Michael Niedermayer wrote: On Tue, Nov 21, 2017 at 02:24:23PM +0100, Tobias Rapp wrote: On 20.11.2017 22:15, Michael Niedermayer wrote: On Mon, Nov 20, 2017 at 05:14:15PM +0100, Nicolas George wrote: Tobias Rapp (2017-11-20): Would it be OK to backport the fix into releas

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Guess video codec delay based on PTS while parsing MOV header.

On Wed, Nov 22, 2017 at 01:21:45PM +0530, Sasi Inguva wrote: > I was just shooting for a heuristic which works for most of the cases. I do not think a heuristic is a good idea. Its not very hard to compute this exactly. You just reorder using a 16 entry buffer and keep track of what the largest si

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/hevcdsp: Add NEON optimization for qpel weighted mode

On Wed, Nov 22, 2017 at 07:12:01PM +0800, Shengbin Meng wrote: > From: Meng Wang > > Signed-off-by: Meng Wang > --- > libavcodec/arm/hevcdsp_init_neon.c | 66 + > libavcodec/arm/hevcdsp_qpel_neon.S | 509 > + > 2 files changed, 575 insertions(+) > > di

Re: [FFmpeg-devel] [mov] Increment stsd_count while processing stsd data; avoids leaks.

On Tue, Nov 21, 2017 at 03:42:40PM -0800, Dale Curtis wrote: > In the event of ff_mov_read_stsd_entries() failure, sc->stsd_count > is not updated, even if the function allocates extradata memory. > Instead update the sc->stsd_count as entries are parsed so that > mov_read_close() can do the right

[FFmpeg-devel] [PATCH] libavformat/mov: Replace duplicate stream_nb check by assert

Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 9e876efc8c..6940dfc7d5 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -2437,8 +2437,7 @@ int ff_mov_read_stsd_entri

[FFmpeg-devel] [PATCH 6/6] avcodec/hevcdsp: Add NEON optimization for idct16x16

From: Meng Wang Signed-off-by: Meng Wang --- libavcodec/arm/hevcdsp_idct_neon.S | 241 + libavcodec/arm/hevcdsp_init_neon.c | 2 + 2 files changed, 243 insertions(+) diff --git a/libavcodec/arm/hevcdsp_idct_neon.S b/libavcodec/arm/hevcdsp_idct_neon.S inde

[FFmpeg-devel] [PATCH 2/6] avcodec/hevcdsp: Add NEON optimization for epel

From: Meng Wang Signed-off-by: Meng Wang --- libavcodec/arm/Makefile|3 +- libavcodec/arm/hevcdsp_epel_neon.S | 2068 libavcodec/arm/hevcdsp_init_neon.c | 459 3 files changed, 2529 insertions(+), 1 deletion(-) create mode 100644 l

[FFmpeg-devel] [PATCH 4/6] avcodec/hevcdsp: Use pre-load (pld) to optimize data loading

From: Meng Wang Signed-off-by: Meng Wang --- libavcodec/arm/hevcdsp_epel_neon.S | 10 ++ libavcodec/arm/hevcdsp_qpel_neon.S | 24 2 files changed, 30 insertions(+), 4 deletions(-) diff --git a/libavcodec/arm/hevcdsp_epel_neon.S b/libavcodec/arm/hevcdsp_epel_ne

[FFmpeg-devel] [PATCH 3/6] avcodec/hevcdsp: Add NEON optimization for whole-pixel interpolation

New code is written for qpel; and then code for qpel is reused for epel, because whole-pixel interpolation in qpel and epel are identical. Signed-off-by: Shengbin Meng --- libavcodec/arm/hevcdsp_init_neon.c | 106 ++ libavcodec/arm/hevcdsp_qpel_neon.S | 177 ++

[FFmpeg-devel] [PATCH 5/6] avcodec/hevcdsp: Add NEON optimization for sao

From: Meng Wang Signed-off-by: Meng Wang --- libavcodec/arm/Makefile| 3 +- libavcodec/arm/hevcdsp_init_neon.c | 62 + libavcodec/arm/hevcdsp_sao_neon.S | 181 + 3 files changed, 245 insertions(+), 1 deletion(-) create mode 100644

[FFmpeg-devel] [PATCH 0/6] Optimize HEVC decoding on ARM (32bit) platform

Our tests show that CPU clocks are reduced for each module: ~48% for qpel weight ~17% for epel ~71% for sao edge mode ~48% for sao band mode ~60% for idct of 16x16 block And overall decoding speeds up by 20~30% (increase of FPS). We also compared the decoding results to make sure they are the same

[FFmpeg-devel] [PATCH 1/6] avcodec/hevcdsp: Add NEON optimization for qpel weighted mode

From: Meng Wang Signed-off-by: Meng Wang --- libavcodec/arm/hevcdsp_init_neon.c | 66 + libavcodec/arm/hevcdsp_qpel_neon.S | 509 + 2 files changed, 575 insertions(+) diff --git a/libavcodec/arm/hevcdsp_init_neon.c b/libavcodec/arm/hevcdsp_init_neon.c

Re: [FFmpeg-devel] [PATCH] avfilter: slice processing for geq

New patch version which fixe the last remark. Le ven. 10 nov. 2017 à 00:47, Michael Niedermayer a écrit : > On Thu, Nov 09, 2017 at 10:22:23AM +, Marc-Antoine ARNAUD wrote: > > Please find the merged patch in attachement. > > > > Thanks > > > > Le mer. 8 nov. 2017 à 17:12, Paul B Mahol a é

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: Modularized playlist creation to allow reuse

>On 11/22/17, 2:18 PM, "Hendrik Leppkes" wrote: >>On Wed, Nov 22, 2017 at 9:35 AM, Jeyapal, Karthick >>wrote: >>>On 11/22/17, 1:47 PM, "刘歧" wrote: […] >>> move the APIs to an C source file, and use ff_ prefix, refer to: >>> https://ffmpeg.org/developer.html#toc-Naming-conventions >> Thanks fo

[FFmpeg-devel] [PATCH v2 2/2] avformat/dashenc: Option to generate hls playlist as well

This is to take full advantage of Common Media Application Format. Now server can generate one content and serve both HLS and DASH players. --- doc/muxers.texi | 3 ++ libavformat/dashenc.c | 102 -- 2 files changed, 101 insertions(+), 4 dele

[FFmpeg-devel] [PATCH v2 1/2] avformat/hlsenc: Modularized playlist creation to allow reuse

--- libavformat/hlsenc.c | 237 +++ libavformat/hlsenc.h | 67 +++ 2 files changed, 193 insertions(+), 111 deletions(-) create mode 100644 libavformat/hlsenc.h diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 3c47ced..d5b

Re: [FFmpeg-devel] [PATCH] Add FAQs about running in background (rev 2)

Ping. This patch responds to review comments, and there have been no further comments for a week. Could someone commit it please? Thanks,   —Jim DeLaHunt On 2017-11-15 00:43, Jim DeLaHunt wrote: Add two FAQs about running FFmpeg in the background. The first explains the use of the -nostdi

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: Modularized playlist creation to allow reuse

On Wed, Nov 22, 2017 at 9:35 AM, Jeyapal, Karthick wrote: >>On 11/22/17, 1:47 PM, "刘歧" wrote: >> >>> 在 2017年11月22日，14:53，Karthick J 写道： >>> >>> --- >>> libavformat/hlsenc.c | 130 +++--- >>> libavformat/hlsenc.h | 158 >>> ++

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: Modularized playlist creation to allow reuse

>On 11/22/17, 1:47 PM, "刘歧" wrote: > >> 在 2017年11月22日，14:53，Karthick J 写道： >> >> --- >> libavformat/hlsenc.c | 130 +++--- >> libavformat/hlsenc.h | 158 >> +++ >> 2 files changed, 177 insertions(+), 111 deletions

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: Minor fix in setting http options for master playlist

> 在 2017年11月22日，16:08，Karthick J 写道： > > --- > libavformat/hlsenc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index 3c47ced..525605b 100644 > --- a/libavformat/hlsenc.c > +++ b/libavformat/hlsenc.c > @@ -1089,8 +1089,

Re: [FFmpeg-devel] [PATCH 1/1] avformat/dashenc: Associate mpd extension with dash muxer

> 在 2017年11月22日，16:20，Karthick J 写道： > > --- > libavformat/dashenc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c > index 201668a..0fee3cd 100644 > --- a/libavformat/dashenc.c > +++ b/libavformat/dashenc.c > @@ -1219,6 +1219,7 @@ static c

[FFmpeg-devel] [PATCH 1/1] avformat/dashenc: Associate mpd extension with dash muxer

--- libavformat/dashenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 201668a..0fee3cd 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -1219,6 +1219,7 @@ static const AVClass dash_class = { AVOutputFormat ff_dash_muxer

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: Modularized playlist creation to allow reuse

> 在 2017年11月22日，14:53，Karthick J 写道： > > --- > libavformat/hlsenc.c | 130 +++--- > libavformat/hlsenc.h | 158 +++ > 2 files changed, 177 insertions(+), 111 deletions(-) > create mode 100644 libavformat/hlsenc.h >

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hlsenc: Refactor an inconsistent variable name

> 在 2017年11月22日，16:08，Karthick J 写道： > > --- > libavformat/hlsenc.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index 525605b..611cc99 100644 > --- a/libavformat/hlsenc.c > +++ b/libavformat/hlsenc.c >

  1   2   >