Re: [FFmpeg-devel] [PATCH 3/3] avcodec/webp: add support for ICCP chunks

2017-07-25 Thread Rostislav Pehlivanov
On 26 July 2017 at 05:31, James Almer wrote: > Export the raw data as ICC Profile frame side data. > > Signed-off-by: James Almer > --- > libavcodec/webp.c | 26 -- > 1 file changed, 24 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/webp.c b/libavcodec/webp.c

Re: [FFmpeg-devel] [PATCH 2/3] ffprobe: add support for ICC Profile frame side data

2017-07-25 Thread Rostislav Pehlivanov
On 26 July 2017 at 05:31, James Almer wrote: > Print the name metadata entry and the buffer size. > > Signed-off-by: James Almer > --- > ffprobe.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/ffprobe.c b/ffprobe.c > index 3d9f795d2e..b4947df6e0 100644 > --- a/ffprobe.c > +++ b/

Re: [FFmpeg-devel] [PATCH 1/3] avutil/frame: add ICC Profile to av_frame_side_data_name

2017-07-25 Thread Rostislav Pehlivanov
On 26 July 2017 at 05:31, James Almer wrote: > Signed-off-by: James Almer > --- > libavutil/frame.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavutil/frame.c b/libavutil/frame.c > index 24d5d5f184..f01b4d7b64 100644 > --- a/libavutil/frame.c > +++ b/libavutil/frame.c > @@ -778,

[FFmpeg-devel] [PATCH 2/3] ffprobe: add support for ICC Profile frame side data

2017-07-25 Thread James Almer
Print the name metadata entry and the buffer size. Signed-off-by: James Almer --- ffprobe.c | 5 + 1 file changed, 5 insertions(+) diff --git a/ffprobe.c b/ffprobe.c index 3d9f795d2e..b4947df6e0 100644 --- a/ffprobe.c +++ b/ffprobe.c @@ -2190,6 +2190,11 @@ static void show_frame(WriterConte

[FFmpeg-devel] [PATCH 1/3] avutil/frame: add ICC Profile to av_frame_side_data_name

2017-07-25 Thread James Almer
Signed-off-by: James Almer --- libavutil/frame.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index 24d5d5f184..f01b4d7b64 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -778,6 +778,7 @@ const char *av_frame_side_data_name(enum AVFrameSideD

[FFmpeg-devel] [PATCH 3/3] avcodec/webp: add support for ICCP chunks

2017-07-25 Thread James Almer
Export the raw data as ICC Profile frame side data. Signed-off-by: James Almer --- libavcodec/webp.c | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/libavcodec/webp.c b/libavcodec/webp.c index a0d4d1812d..efa864a6f1 100644 --- a/libavcodec/webp.c +

Re: [FFmpeg-devel] [PATCH V6] examples/hw_decode: Add a HWAccel decoding example.

2017-07-25 Thread Steven Liu
2017-07-26 9:27 GMT+08:00 Jun Zhao : > V6: fix memory leak issue when get EAGAIN/EOF for avcodec_receive_frame. > V5: remove qsv/cuda in the example and Mark have test dxva2|d3d11va, >videotoolbox might work as well. > V4: fix potential memory leak issue base on Steven Liu's review. > V3: re-wo

Re: [FFmpeg-devel] [PATCH] doc/examples/encode_video: add qsv encoder support

2017-07-25 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Nicolas George > Sent: Friday, July 21, 2017 3:52 PM > To: FFmpeg development discussions and patches > > Cc: Li, Zhong ; s...@jkqxz.net; Zhao, Jun > ; nfx...@googlemail.com > Subject: Re: [FFmpeg-devel] [PATCH] doc/examp

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/vorbisenc: Apply dynamic frame lengths

2017-07-25 Thread Tyler Jones
On Wed, Jul 26, 2017 at 01:01:00AM +0100, Rostislav Pehlivanov wrote: > On 12 July 2017 at 23:18, Tyler Jones wrote: > > > > > diff --git a/libavcodec/vorbis.c b/libavcodec/vorbis.c > > index 399020e..8befab8 100644 > > --- a/libavcodec/vorbis.c > > +++ b/libavcodec/vorbis.c > > @@ -59,7 +59,7 @@

[FFmpeg-devel] [PATCH V6] examples/hw_decode: Add a HWAccel decoding example.

2017-07-25 Thread Jun Zhao
V6: fix memory leak issue when get EAGAIN/EOF for avcodec_receive_frame. V5: remove qsv/cuda in the example and Mark have test dxva2|d3d11va, videotoolbox might work as well. V4: fix potential memory leak issue base on Steven Liu's review. V3: re-work to support the other hwaccels, rename from

[FFmpeg-devel] [PATCH] avcodec/dnxhddec: Move mb height check out of non hr branch

2017-07-25 Thread Michael Niedermayer
Fixes: out of array access Fixes: poc.dnxhd Found-by: Bingchang, Liu@VARAS of IIE Signed-off-by: Michael Niedermayer --- libavcodec/dnxhddec.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavcodec/dnxhddec.c b/libavcodec/dnxhddec.c index 40d41f9bf1..f46e41a456 10

[FFmpeg-devel] [PATCH] avutil/frame: allow only one element per type in frame side data

2017-07-25 Thread James Almer
Same rationale as with packet side data, it was never meant to do otherwise as av_frame_get_side_data returns the first entry it finds of a given type. Based on code from libavformat's av_stream_add_side_data(). Signed-off-by: James Almer --- libavutil/frame.c | 14 ++ 1 file change

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/vorbisenc: Apply dynamic frame lengths

2017-07-25 Thread Rostislav Pehlivanov
On 12 July 2017 at 23:18, Tyler Jones wrote: > Additional codebooks are added for shorter 128-sample frames. Changes in > codeword generation are made to handle valid values of 0 that prepend some > codebooks, otherwise books are classified incorrectly and cause unreadable > streams. > > A second

Re: [FFmpeg-devel] [PATCH V2 1/2] avcodec/vorbisenc: Add pre-echo detection

2017-07-25 Thread Rostislav Pehlivanov
On 17 July 2017 at 16:17, Tyler Jones wrote: > The encoder will attempt to determine the existence of transient > signals by applying a 4th order highpass filter to remove dominant > low frequency waveforms. Frames are then split up into blocks > where the variance is calculated and compared with

Re: [FFmpeg-devel] [PATCH] avcodec/rdft: reorder calculation

2017-07-25 Thread Muhammad Faiz
On Sat, Jul 22, 2017 at 6:57 AM, Muhammad Faiz wrote: > old: > 165188 decicycles in rdft, 65536 runs, 0 skips > 165865 decicycles in irdft, 65536 runs, 0 skips > new: > 142487 decicycles in rdft, 65536 runs, 0 skips > 141498 decicycles in irdft, 65536 runs, 0 skip

Re: [FFmpeg-devel] [PATCH] libavcodec/mips: Optimize avc idct 4x4 for msa

2017-07-25 Thread Michael Niedermayer
On Mon, Jul 24, 2017 at 05:20:26PM +, Manojkumar Bhosale wrote: > LGTM applied thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Avoid a single point of failure, be that a person or equipment. signature.asc Description: Digital signature ___

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-07-25 Thread Michael Niedermayer
On Mon, Jul 24, 2017 at 02:32:41PM -0700, Dale Curtis wrote: > On Thu, Jul 20, 2017 at 5:00 AM, Michael Niedermayer > wrote: > > > Hi > > > > On Wed, Jul 19, 2017 at 07:30:01PM -0700, Dale Curtis wrote: > > > Thanks will take a look. Is this test not part of fate? make fate passed > > > > no, we

Re: [FFmpeg-devel] [RFC]libswscale: Sanitize isRGBinInt() and isBGRinInt()

2017-07-25 Thread Michael Niedermayer
On Mon, Jul 24, 2017 at 08:00:51PM +0200, Carl Eugen Hoyos wrote: > Hi! > > Attached is a PoC for a code simplification that imo makes a logic in > libswscale easier to read and also fixes the Big Endian fate failure. > If this approach is preferred, I will try to fix the five affected asm > funct

Re: [FFmpeg-devel] [PATCH 1/2] lavu/frame: add new side data type for ICC profiles

2017-07-25 Thread Rostislav Pehlivanov
On 22 July 2017 at 21:17, Rostislav Pehlivanov wrote: > > > On 21 July 2017 at 14:36, Nicolas George wrote: > >> Le tridi 3 thermidor, an CCXXV, Derek Buitenhuis a écrit : >> > +1 on exposing it as side data; it's consistent with previous APIs and >> doesn't >> >> I will not oppose further; I do

Re: [FFmpeg-devel] [PATCH 2/2] pngdec: decode and expose iCCP chunks as side data

2017-07-25 Thread Rostislav Pehlivanov
On 25 July 2017 at 17:33, Rostislav Pehlivanov wrote: > > > On 23 July 2017 at 13:36, Michael Niedermayer > wrote: > >> On Sat, Jul 22, 2017 at 09:15:53PM +0100, Rostislav Pehlivanov wrote: >> > On 21 July 2017 at 14:11, Michael Niedermayer >> > wrote: >> > >> > > On Thu, Jul 20, 2017 at 09:46:

Re: [FFmpeg-devel] 3dlut filter: some .cube LUTs not working

2017-07-25 Thread Clément Bœsch
On Tue, Jul 25, 2017 at 09:58:39AM +0200, Felix Müller wrote: > The popular DELUTS SLOG2 set is not working with ffmpeg's 3dlut filter. > It simply states that this filter can not be used with it. > > I have attached one of those LUTs for testing purposes. > Works for me. You probably have the b

Re: [FFmpeg-devel] [PATCH 1/4] Move lavd/v4l2-common.* to lavc

2017-07-25 Thread Jorge Ramirez
On 07/25/2017 08:09 PM, Michael Niedermayer wrote: On Mon, Jul 24, 2017 at 09:08:46PM +0200, Jorge Ramirez-Ortiz wrote: From: Alexis Ballier In preparation to support the integation of the V4L2 API for encoding and decoding, move v4l2 related files to libavcodec. Signed-off-by: Alexis Ballier

Re: [FFmpeg-devel] [PATCH 1/4] Move lavd/v4l2-common.* to lavc

2017-07-25 Thread Michael Niedermayer
On Mon, Jul 24, 2017 at 09:08:46PM +0200, Jorge Ramirez-Ortiz wrote: > From: Alexis Ballier > > In preparation to support the integation of the V4L2 API for encoding > and decoding, move v4l2 related files to libavcodec. > > Signed-off-by: Alexis Ballier > Reviewed-by: Jorge Ramirez-Ortiz > --

[FFmpeg-devel] 3dlut filter: some .cube LUTs not working

2017-07-25 Thread Felix Müller
The popular DELUTS SLOG2 set is not working with ffmpeg's 3dlut filter. It simply states that this filter can not be used with it. I have attached one of those LUTs for testing purposes. regards Felix Mueller # Copyright: (C) Copyright 2017 James Miller # Created by: James Miller, www.DeLuts.co

Re: [FFmpeg-devel] [PATCH 2/2] pngdec: decode and expose iCCP chunks as side data

2017-07-25 Thread Rostislav Pehlivanov
On 23 July 2017 at 13:36, Michael Niedermayer wrote: > On Sat, Jul 22, 2017 at 09:15:53PM +0100, Rostislav Pehlivanov wrote: > > On 21 July 2017 at 14:11, Michael Niedermayer > > wrote: > > > > > On Thu, Jul 20, 2017 at 09:46:22PM +0100, Rostislav Pehlivanov wrote: > > > > Signed-off-by: Rostisl

Re: [FFmpeg-devel] [Patch] Auto Insert of hwupload_cuda filter

2017-07-25 Thread Nicolas George
Le septidi 7 thermidor, an CCXXV, Yogender Gupta a écrit : > This email message is for the sole use of the intended recipient(s) and may > contain > confidential information. Any unauthorized review, use, disclosure or > distribution > is prohibited. If you are not the intended recipient, pleas

[FFmpeg-devel] [Patch] Auto Insert of hwupload_cuda filter

2017-07-25 Thread Yogender Gupta
Currently combining CPU and CUDA filters requires insertion of hwupload and download filters. I am trying to simply this by auto insertion of these filters. This patch is for hwupload_cuda, but I want to do this for hwdownload as well. The attached patch automatically inserts hwupload_cuda filt

[FFmpeg-devel] [PATCH v3] fate: add tests for some video source filters

2017-07-25 Thread Tobias Rapp
Adds FATE tests for the previously untested allrgb, allyuv, rgbtestsrc, smptebars, smptehdbars and yuvtestsrc filters. Also adds a test for testsrc2 filter with rgb+alpha. Signed-off-by: Tobias Rapp --- tests/fate/filter-video.mak| 24 ++ tests/ref/fate/filter-allrgb

Re: [FFmpeg-devel] [PATCH] avcodec/aac: add 960/120 MDCT window

2017-07-25 Thread Hendrik Leppkes
2017-07-25 9:46 GMT+02:00 Paul B Mahol : > On 7/16/17, Paul B Mahol wrote: >> Signed-off-by: Rostislav Pehlivanov >> Signed-off-by: Alex Converse >> Signed-off-by: Paul B Mahol >> --- >> Changelog | 1 + >> libavcodec/aac.h | 3 + >> libavcodec/aacdec_templ

Re: [FFmpeg-devel] [Patch] nvenc : Add P016 support

2017-07-25 Thread Yogender Gupta
>> I can push, but to answer Timo's question: I did not add P016 to nvenc >> because it is technically not correct to pass 12bit content through a 10bit >> surface - that will lead to truncation, rather than dithering. If you are >> telling us that nvenc supports 12bit >> input and will correctl

Re: [FFmpeg-devel] [PATCH] avcodec/aac: add 960/120 MDCT window

2017-07-25 Thread Paul B Mahol
On 7/16/17, Paul B Mahol wrote: > Signed-off-by: Rostislav Pehlivanov > Signed-off-by: Alex Converse > Signed-off-by: Paul B Mahol > --- > Changelog | 1 + > libavcodec/aac.h | 3 + > libavcodec/aacdec_template.c | 126 > +++

Re: [FFmpeg-devel] [PATCH] lavfi/testsrc2: fix completely transparent alpha.

2017-07-25 Thread Nicolas George
Le septidi 7 thermidor, an CCXXV, Carl Eugen Hoyos a écrit : > I thought that one of my suggestions (alpha_value = y * 255 / height) > would play nice with memset(). Yes, indeed, a vertical gradient would play nicer. I keep it in mind for the future. > I am ok with everything that improves the cu

Re: [FFmpeg-devel] [PATCH] lavfi/testsrc2: fix completely transparent alpha.

2017-07-25 Thread Carl Eugen Hoyos
2017-07-24 13:02 GMT+02:00 Nicolas George : > Le sextidi 6 thermidor, an CCXXV, Carl Eugen Hoyos a écrit : >> > Oh, you mean a gradient on the alpha channel. It is not really possible >> > without making the code more complex and I think significantly slower. >> >> > A coarse gradient between the d

Re: [FFmpeg-devel] [PATCH] avformat/oggparsecelt: Do not re-allocate os->private

2017-07-25 Thread Nicolas George
Le septidi 7 thermidor, an CCXXV, Michael Niedermayer a écrit : > Fixes: double free > Fixes: clusterfuzz-testcase-minimized-5080550145785856 > > Found-by: ClusterFuzz > Signed-off-by: Michael Niedermayer > --- > libavformat/oggparsecelt.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 dele