Re: [FFmpeg-devel] [PATCH V2] examples/vaapi_dec: Add a VA-API hwaccel decoding example

2017-07-16 Thread Jun Zhao
On 2017/7/11 15:58, wm4 wrote: > On Tue, 11 Jul 2017 12:06:10 +0800 > Jun Zhao wrote: > >> From 0e4d230ae4c98949a962c6bbdad31d216b54bb6a Mon Sep 17 00:00:00 2001 >> From: Jun Zhao >> Date: Tue, 21 Mar 2017 11:04:41 +0800 >> Subject: [V2] examples/vaapi_dec: Add a VA-API hwaccel decoding exampl

Re: [FFmpeg-devel] [PATCH] avcodec: add MagicYUV encoder

2017-07-16 Thread James Almer
On 7/14/2017 11:30 AM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 2 +- > libavcodec/magicyuvenc.c | 482 > +++ > 3 files changed, 484 insertions(+), 1 deletion(-) > creat

Re: [FFmpeg-devel] [PATCH] avfilter/vf_overlay: fix alpha blending when main source has an alpha channel

2017-07-16 Thread Peter Große
On Sun, 16 Jul 2017 18:33:33 +0200 Paul B Mahol wrote: > > how can one reproduce this bug? ffmpeg -i fate-suite/mfx/track_01_v02.mxf -filter_complex \ "movie=fate-suite/png1/lena-rgba.png[logo];[v:0][logo]overlay" -an -vframes 1 out.png In this example files from the fate suite are used. The

Re: [FFmpeg-devel] [PATCH] webmdashenc: Fix memory leak

2017-07-16 Thread Ronald S. Bultje
Hi, On Sun, Jul 16, 2017 at 8:45 AM, Derek Buitenhuis < derek.buitenh...@gmail.com> wrote: > On 7/14/2017 3:38 PM, Derek Buitenhuis wrote: > > Signed-off-by: Derek Buitenhuis > > --- > > libavformat/webmdashenc.c | 38 ++ > > 1 file changed, 30 insertions(+),

[FFmpeg-devel] [PATCH] avcodec/aac: add 960/120 MDCT window

2017-07-16 Thread Paul B Mahol
Signed-off-by: Rostislav Pehlivanov Signed-off-by: Alex Converse Signed-off-by: Paul B Mahol --- Changelog | 1 + libavcodec/aac.h | 3 + libavcodec/aacdec_template.c | 126 +++--- libavcodec/aacsbr_template.c | 3 +-

Re: [FFmpeg-devel] [PATCH] Add FITS Encoder

2017-07-16 Thread Reimar Döffinger
On 16.07.2017, at 15:08, Nicolas George wrote: > L'octidi 28 messidor, an CCXXV, Derek Buitenhuis a écrit : >> Why is there no decoder? > > Because the decoder is in a separate patch, and the demuxer in yet > another. And none of them can proceed until Paras Chadha starts deciding > what is cons

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

2017-07-16 Thread Ashish Pratap Singh
thanks. On Sun, Jul 16, 2017 at 9:38 PM, Matt Oliver wrote: > On 17 July 2017 at 01:12, Derek Buitenhuis > wrote: > > > On 7/16/2017 3:15 PM, Matt Oliver wrote: > > > Im getting the same error. The patch had an error in it as this line is > > > wrong: > > > +vmaf_filter_deps="libvmaf" > > > > >

Re: [FFmpeg-devel] [PATCH] Add FITS Encoder

2017-07-16 Thread Reimar Döffinger
On 16.07.2017, at 14:31, Paras Chadha wrote: > +static int write_keyword_value(uint8_t **bytestream, const char * keyword, > int value) > +{ > +int len, ret; > +uint8_t * header = * bytestream; > +len = strlen(keyword); > + > +memcpy(header, keyword, len); > +memset(header + l

Re: [FFmpeg-devel] [PATCH] Add FITS Demuxer

2017-07-16 Thread Paras Chadha
On Sun, Jul 16, 2017 at 10:06 PM, Paul B Mahol wrote: > Can you give link to file which holds more than one FITS image? > Yes, here is the file: https://fits.gsfc.nasa.gov/samples/EUVEngc4151imgx. fits > ___ > ffmpeg-devel mailing list > ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Add FITS Demuxer

2017-07-16 Thread Paul B Mahol
Can you give link to file which holds more than one FITS image? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_overlay: fix alpha blending when main source has an alpha channel

2017-07-16 Thread Paul B Mahol
On 7/15/17, Peter Grosse wrote: > Use alpha value from alpha channel instead of selected component channel. > > Signed-off-by: Peter Grosse > --- > libavfilter/vf_overlay.c | 16 ++-- > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/libavfilter/vf_overlay.c b/libav

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

2017-07-16 Thread Matt Oliver
On 17 July 2017 at 01:12, Derek Buitenhuis wrote: > On 7/16/2017 3:15 PM, Matt Oliver wrote: > > Im getting the same error. The patch had an error in it as this line is > > wrong: > > +vmaf_filter_deps="libvmaf" > > > > It should be: > > +libvmaf_filter_deps="libvmaf" > > > > As the filter is reg

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

2017-07-16 Thread Derek Buitenhuis
On 7/16/2017 4:33 PM, Ashish Pratap Singh wrote: > Hi, sorry for that. > I will open a pull request soon (to libvmaf) for the pkg-config file. Thanks! - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpe

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

2017-07-16 Thread Ashish Pratap Singh
On Sun, Jul 16, 2017 at 6:19 PM, Derek Buitenhuis < derek.buitenh...@gmail.com> wrote: > On 7/16/2017 1:29 PM, Ronald S. Bultje wrote: > > Pushed. > > > > Ronald > > I am going to quote myself here, because it was never address, was not even > replied to, and is outright incorrect on some OSes: >

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

2017-07-16 Thread Ashish Pratap Singh
On Sun, Jul 16, 2017 at 5:59 PM, Ronald S. Bultje wrote: > Hi, > > On Sat, Jul 15, 2017 at 12:42 PM, Ashish Singh > wrote: > >> This one changes the previous vmaf patch to libvmaf to keep it separate >> from the >> native implementation of vmaf inside ffmpeg later. >> >> Signed-off-by: Ashish Si

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

2017-07-16 Thread Derek Buitenhuis
On 7/16/2017 3:15 PM, Matt Oliver wrote: > Im getting the same error. The patch had an error in it as this line is > wrong: > +vmaf_filter_deps="libvmaf" > > It should be: > +libvmaf_filter_deps="libvmaf" > > As the filter is registered as libvmaf_filter not vmaf_filter in > allfilters.cpp I've

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

2017-07-16 Thread Moritz Barsnick
On Mon, Jul 17, 2017 at 00:15:19 +1000, Matt Oliver wrote: > Currently this is breaking for me until this gets fixed It's breaking for most everyone, fate is red with "error compiling": http://fate.ffmpeg.org/?sort=descdate E.g. http://fate.ffmpeg.org/log.cgi?time=20170716125737&log=compile&slot=

Re: [FFmpeg-devel] [PATCH] Add FITS Encoder

2017-07-16 Thread Paras Chadha
On Sun, Jul 16, 2017 at 6:29 PM, Derek Buitenhuis < derek.buitenh...@gmail.com> wrote: > On 7/16/2017 1:31 PM, Paras Chadha wrote: > > Signed-off-by: Paras Chadha > > --- > > doc/general.texi | 2 + > > libavcodec/Makefile| 1 + > > libavcodec/allcodecs.c | 1 + > > libavcodec/fi

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

2017-07-16 Thread Matt Oliver
On 16 July 2017 at 23:01, Henrik Gramner wrote: > `./configure && make` results in "libavfilter/vf_libvmaf.c:29:21: > fatal error: libvmaf.h: No such file or directory". > > I don't have libvmaf installed, but it configures it as enabled and > detects it as installed anyway. Im getting the same

Re: [FFmpeg-devel] [PATCH] Add FITS Demuxer

2017-07-16 Thread Paras Chadha
On Fri, Jul 14, 2017 at 11:15 PM, Nicolas George wrote: > Le tridi 23 messidor, an CCXXV, Paras Chadha a écrit : > > Hi, I have attached the dump of a FITS File containing 5 images and 4 > > binary table xtensions. The dump is taken using fdump utility. Please > take > > a look. > > Thanks for th

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

2017-07-16 Thread Derek Buitenhuis
On 7/16/2017 2:35 PM, Ronald S. Bultje wrote: > I tested on OSX and it works fine. I'm OK with pkg-config, but since > libvmaf doesn't currently have one, we cannot rely on it. It will work fine (but link to libstdc++ unnecessarily) if you have build libvmaf as a shared library, but it will fail a

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

2017-07-16 Thread Ronald S. Bultje
Hi, On Sun, Jul 16, 2017 at 8:49 AM, Derek Buitenhuis < derek.buitenh...@gmail.com> wrote: > On 7/16/2017 1:29 PM, Ronald S. Bultje wrote: > > Pushed. > > > > Ronald > > I am going to quote myself here, because it was never address, was not even > replied to, and is outright incorrect on some OSe

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

2017-07-16 Thread Henrik Gramner
`./configure && make` results in "libavfilter/vf_libvmaf.c:29:21: fatal error: libvmaf.h: No such file or directory". I don't have libvmaf installed, but it configures it as enabled and detects it as installed anyway. ___ ffmpeg-devel mailing list ffmpeg

Re: [FFmpeg-devel] [PATCH] Add FITS Encoder

2017-07-16 Thread Nicolas George
L'octidi 28 messidor, an CCXXV, Derek Buitenhuis a écrit : > Why is there no decoder? Because the decoder is in a separate patch, and the demuxer in yet another. And none of them can proceed until Paras Chadha starts deciding what is considered part of the codec and what is considered part of the

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

2017-07-16 Thread Nicolas George
L'octidi 28 messidor, an CCXXV, Derek Buitenhuis a écrit : > Students should learn to reply to reviews instead of sending new patches > with no changelog and having them pushed anyway. Hear, hear. But a small correction: "students should learn" -> "mentors should teach". Regards, -- Nicolas

Re: [FFmpeg-devel] [PATCH] Add FITS Encoder

2017-07-16 Thread Derek Buitenhuis
On 7/16/2017 1:31 PM, Paras Chadha wrote: > Signed-off-by: Paras Chadha > --- > doc/general.texi | 2 + > libavcodec/Makefile| 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/fitsenc.c | 238 > + > libavformat/img2enc.c | 1 +

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

2017-07-16 Thread Derek Buitenhuis
On 7/16/2017 1:49 PM, Derek Buitenhuis wrote: > Students should learn to reply to reviews instead of sending new patches > with no changelog and having them pushed anyway. Furthermore: Missing a version bump. - Derek ___ ffmpeg-devel mailing list ffmpeg

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

2017-07-16 Thread Derek Buitenhuis
On 7/16/2017 1:29 PM, Ronald S. Bultje wrote: > Pushed. > > Ronald I am going to quote myself here, because it was never address, was not even replied to, and is outright incorrect on some OSes: >> +enabled libvmaf && { check_lib libvmaf "libvmaf.h" "compute_vmaf" >> -lvmaf -lstdc++ -

Re: [FFmpeg-devel] [PATCH] webmdashenc: Fix memory leak

2017-07-16 Thread Derek Buitenhuis
On 7/14/2017 3:38 PM, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > libavformat/webmdashenc.c | 38 ++ > 1 file changed, 30 insertions(+), 8 deletions(-) Pushing today, unless there are objections. - Derek _

[FFmpeg-devel] [PATCH] Add FITS Encoder

2017-07-16 Thread Paras Chadha
Signed-off-by: Paras Chadha --- doc/general.texi | 2 + libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 + libavcodec/fitsenc.c | 238 + libavformat/img2enc.c | 1 + 5 files changed, 243 insertions(+) create mode 100644 li

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

2017-07-16 Thread Ronald S. Bultje
Hi, On Sat, Jul 15, 2017 at 12:42 PM, Ashish Singh wrote: > This one changes the previous vmaf patch to libvmaf to keep it separate > from the > native implementation of vmaf inside ffmpeg later. > > Signed-off-by: Ashish Singh > --- > Changelog| 1 + > configure

Re: [FFmpeg-devel] [PATCH] Add FITS Encoder

2017-07-16 Thread Paras Chadha
On Sat, Jul 15, 2017 at 12:13 PM, Reimar Döffinger wrote: > On 14.07.2017, at 19:04, Paras Chadha wrote: > > > +if (bitpix == 16) { > > +for (j = 0; j < avctx->width; j++) { > > +bytestream2_put_be16(&pbc, AV_RB16(ptr) - bzero); > > +