Re: [FFmpeg-devel] [PATCH] avutil/threadmessage: fix error return in case of av_fifo_alloc failure

2017-07-13 Thread Michael Niedermayer
On Wed, Jul 12, 2017 at 08:47:43PM +0200, Nicolas George wrote: > Le quartidi 24 messidor, an CCXXV, Александр Слободенюк a écrit : > > "ret" variable didn't change from 0. > > > From c97362039a106f94dfae46dafc9d06204cdcd1cb Mon Sep 17 00:00:00 2001 > > From: Aleksandr Slobodeniuk > > Date: Wed,

[FFmpeg-devel] [PATCH] avcodec/aacdec_template: Fix undefined integer overflow in apply_tns()

2017-07-13 Thread Michael Niedermayer
Fixes: runtime error: signed integer overflow: -2147483648 - 1202286525 cannot be represented in type 'int' Fixes: 2071/clusterfuzz-testcase-minimized-6036414271586304 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niede

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vorbisenc: Add pre-echo detection

2017-07-13 Thread Michael Niedermayer
On Wed, Jul 12, 2017 at 04:18:06PM -0600, Tyler Jones wrote: [...] > +av_cold int psy_vorbis_init(VorbisPsyContext *vpctx, int sample_rate, > +int channels, int blocks) non static functions needs a prefix in this case ff_ [...] -- Michael GnuPG fingerprint: 9F

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/aacdec_template: Fix undefined integer overflow in apply_tns()

2017-07-13 Thread Michael Niedermayer
On Wed, Jul 12, 2017 at 01:54:28PM +, Kieran Kunhya wrote: > > > > I actually would request a short note explaining the SUINTFLOAT type usage. > > Something like: > > +typedef unsignedSUINTFLOAT; // Equivalent to INTFLOAT, > > Used as temporal cast to avoid undefined sign overflow o

Re: [FFmpeg-devel] [PATCH] Add prefetch for mips

2017-07-13 Thread Michael Niedermayer
On Wed, Jul 12, 2017 at 12:07:21PM +, Manojkumar Bhosale wrote: > LGTM will apply if it builds and doesnt worsen fate thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If you drop bombs on a foreign country and kill a hundred thousand innocent people, exp

Re: [FFmpeg-devel] [PATCH] checkasm: add a g722dsp test

2017-07-13 Thread James Almer
On 7/10/2017 4:09 PM, James Almer wrote: > On 7/5/2017 4:44 PM, James Almer wrote: > > Ping for this and other checkasm test patches. > Pushed. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] checkasm: add hybrid_analysis_ileave and hybrid_synthesis_deint tests to aacpsdsp

2017-07-13 Thread James Almer
On 7/6/2017 8:47 PM, James Almer wrote: > Signed-off-by: James Almer > --- > tests/checkasm/aacpsdsp.c | 82 > +++ > 1 file changed, 82 insertions(+) Pushed. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg

Re: [FFmpeg-devel] [PATCH] x86/vf_limiter: make limiter functions work on x86_32

2017-07-13 Thread James Almer
On 7/12/2017 10:49 PM, James Almer wrote: > Signed-off-by: James Almer > --- > libavfilter/x86/vf_limiter.asm| 28 > libavfilter/x86/vf_limiter_init.c | 4 ++-- > 2 files changed, 14 insertions(+), 18 deletions(-) Pushed. ___

Re: [FFmpeg-devel] [PATCH 1/1] This change adds an encoder for Camera metadata motion. This is a type of sensor data associated with video, such as GPS, acceleration, gyro, and camera orientation. It

2017-07-13 Thread wm4
On Thu, 13 Jul 2017 12:05:15 -0700 "Louis O'Bryan" wrote: > On Thu, Jul 13, 2017 at 1:34 AM, wm4 wrote: > > > On Wed, 12 Jul 2017 22:42:36 +0200 > > Hendrik Leppkes wrote: > > > > > On Wed, Jul 12, 2017 at 8:31 PM, Louis O'Bryan > > > wrote: > > > > On Wed, Jul 12, 2017 at 9:16 AM, Louis

Re: [FFmpeg-devel] [PATCH 1/1] This change adds an encoder for Camera metadata motion. This is a type of sensor data associated with video, such as GPS, acceleration, gyro, and camera orientation. It

2017-07-13 Thread Louis O'Bryan
On Thu, Jul 13, 2017 at 1:34 AM, wm4 wrote: > On Wed, 12 Jul 2017 22:42:36 +0200 > Hendrik Leppkes wrote: > > > On Wed, Jul 12, 2017 at 8:31 PM, Louis O'Bryan > > wrote: > > > On Wed, Jul 12, 2017 at 9:16 AM, Louis O'Bryan > wrote: > > > > > >> On Wed, Jul 12, 2017 at 12:50 AM, wm4 wrote: > >

Re: [FFmpeg-devel] [PATCH] Add FITS Demuxer

2017-07-13 Thread Paras Chadha
On Tue, Jul 11, 2017 at 3:41 PM, Nicolas George wrote: > Le decadi 20 messidor, an CCXXV, Reimar Döffinger a écrit : > > I don't think that's a correct description then. > > First, the format is made to change and be extended, so what is > > true now might not stay true. > > But also the images c

Re: [FFmpeg-devel] [PATCH] opusenc: use float_dsp for transient mdcts

2017-07-13 Thread Rostislav Pehlivanov
On 12 July 2017 at 04:51, Rostislav Pehlivanov wrote: > vector_fmul_reverse requires padding the window at the front > > Signed-off-by: Rostislav Pehlivanov > --- > libavcodec/opus_celt.h | 4 ++-- > libavcodec/opusenc.c | 8 +++- > libavcodec/opustab.c | 8 ++-- > libavcodec/opusta

Re: [FFmpeg-devel] [PATCH] avfilter: add motion filter

2017-07-13 Thread Reimar Döffinger
On 13.07.2017, at 16:49, Derek Buitenhuis wrote: > On 7/13/2017 3:11 PM, wm4 wrote: >> We definitely use some C99 constructs in FFmpeg, but normally we don't >> use stdbool.h. > > Yeah, but we disallow others (like VLAs), so, yeah. I think it's more of a case of "there is no really convincing u

Re: [FFmpeg-devel] Question on the “decode_failed” logic in ffmpeg.c:

2017-07-13 Thread Reimar Döffinger
On 13.07.2017, at 14:10, "Geek.Song" wrote: > On Wed, Jul 12, 2017 at 1:50 PM, Steven Liu wrote: >> 2017-07-12 12:32 GMT+08:00 Geek.Song : >>> In ffmpeg.c: >>> // >>> // @ static int process_input_packet(InputStream *ist, const AVPacket >>> *pkt, int no_eof) >>> // >>> if (ret < 0) { >>>

Re: [FFmpeg-devel] [PATCH] avfilter: add motion filter

2017-07-13 Thread Derek Buitenhuis
On 7/13/2017 3:11 PM, wm4 wrote: > We definitely use some C99 constructs in FFmpeg, but normally we don't > use stdbool.h. Yeah, but we disallow others (like VLAs), so, yeah. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.or

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/vorbisenc: Apply dynamic frame lengths

2017-07-13 Thread Tyler Jones
On Thu, Jul 13, 2017 at 03:50:13PM +0200, Moritz Barsnick wrote: > On Wed, Jul 12, 2017 at 16:18:20 -0600, Tyler Jones wrote: > > -int window_len = 1 << (venc->log2_blocksize[1] - 1); > > -float n = (float)(1 << venc->log2_blocksize[1]) / 4.0; > > +int prev_size, curr_size, next_size, b

Re: [FFmpeg-devel] Question on the “decode_failed” logic in ffmpeg.c:

2017-07-13 Thread Steven Liu
2017-07-13 21:37 GMT+08:00 Steven Liu : > 2017-07-13 20:10 GMT+08:00 Geek.Song : >> On Wed, Jul 12, 2017 at 1:50 PM, Steven Liu wrote: >>> 2017-07-12 12:32 GMT+08:00 Geek.Song : In ffmpeg.c: // // @ static int process_input_packet(InputStream *ist, const AVPacket *pkt, int no_e

Re: [FFmpeg-devel] [PATCH] avfilter: add motion filter

2017-07-13 Thread wm4
On Thu, 13 Jul 2017 14:04:45 +0100 Derek Buitenhuis wrote: > Quick scan / review follows. > > > +#include > > Do we allow C99 bool in FFmpeg? I thought we didn't. We definitely use some C99 constructs in FFmpeg, but normally we don't use stdbool.h. __

Re: [FFmpeg-devel] [PATCH] avfilter: add motion filter

2017-07-13 Thread Moritz Barsnick
On Thu, Jul 13, 2017 at 15:34:26 +0200, Nicolas George wrote: > > +static inline double get_motion_avg(double motion_sum, uint64_t nb_frames) > > +{ > > +return motion_sum / nb_frames; > > +} > > Is it really useful as a separate function? It's the same style as in all the previous filters su

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/vorbisenc: Apply dynamic frame lengths

2017-07-13 Thread Moritz Barsnick
On Wed, Jul 12, 2017 at 16:18:20 -0600, Tyler Jones wrote: > -int window_len = 1 << (venc->log2_blocksize[1] - 1); > -float n = (float)(1 << venc->log2_blocksize[1]) / 4.0; > +int prev_size, curr_size, next_size, bound; > +float scale = 1. / (float) (1 << venc->log2_blocksize[blockf

Re: [FFmpeg-devel] Question on the “decode_failed” logic in ffmpeg.c:

2017-07-13 Thread Steven Liu
2017-07-13 20:10 GMT+08:00 Geek.Song : > On Wed, Jul 12, 2017 at 1:50 PM, Steven Liu wrote: >> 2017-07-12 12:32 GMT+08:00 Geek.Song : >>> In ffmpeg.c: >>> // >>> // @ static int process_input_packet(InputStream *ist, const AVPacket >>> *pkt, int no_eof) >>> // >>> if (ret < 0) { >>> i

Re: [FFmpeg-devel] [PATCH] movenc:adds keywords metadata

2017-07-13 Thread Kieran O Leary
Thanks Derek/Michael! -Kieran. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter: add motion filter

2017-07-13 Thread Nicolas George
Hi. Thanks for the patch. See comments below. Le quintidi 25 messidor, an CCXXV, Ashish Singh a écrit : > Hi, this is motion filter, one of the component filters of VMAF. > It takes two videos as input. > Run it using: ffmpeg -i main -i ref -lavfi motion -f null - > Currently it outputs the averag

Re: [FFmpeg-devel] [PATCH] avfilter: add motion filter

2017-07-13 Thread Derek Buitenhuis
Quick scan / review follows. > +#include Do we allow C99 bool in FFmpeg? I thought we didn't. > +#define FORCE_INLINE __attribute__((always_inline)) > +#define RESTRICT __restrict av_restrict av_always_inline > +static inline int floorn(int n, int m) > +{ > +return n - n % m; > +} > + > +

Re: [FFmpeg-devel] [PATCH] movenc:adds keywords metadata

2017-07-13 Thread Derek Buitenhuis
On 7/11/2017 8:01 PM, Kieran O Leary wrote: > Thanks for taking a look. Pushed. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Question on the “decode_failed” logic in ffmpeg.c:

2017-07-13 Thread Geek.Song
On Wed, Jul 12, 2017 at 1:50 PM, Steven Liu wrote: > 2017-07-12 12:32 GMT+08:00 Geek.Song : >> In ffmpeg.c: >> // >> // @ static int process_input_packet(InputStream *ist, const AVPacket >> *pkt, int no_eof) >> // >> if (ret < 0) { >> if (decode_failed) { >> av_log(NUL

Re: [FFmpeg-devel] [PATCH] configure: use pkg-config for libgme, if available

2017-07-13 Thread wm4
On Wed, 12 Jul 2017 12:19:42 +0100 Ricardo Constantino wrote: > On 12 July 2017 at 08:43, wm4 wrote: > > On Tue, 11 Jul 2017 21:56:21 +0100 > > Ricardo Constantino wrote: > > > >> On 6 July 2017 at 23:16, Ricardo Constantino wrote: > >> > On 23 June 2017 at 17:08, wm4 wrote: > >> >> On

Re: [FFmpeg-devel] [PATCH] libavformat/fifo: Fix initialization of underlying AVFormatContext

2017-07-13 Thread Jan Sebechlebsky
On 07/06/2017 11:54 PM, Jan Sebechlebsky wrote: On 07/06/2017 04:28 PM, wm4 wrote: On Thu, 6 Jul 2017 16:16:12 +0200 Jan Sebechlebsky wrote: On 07/06/2017 01:15 PM, wm4 wrote: On Thu, 6 Jul 2017 13:05:14 +0200 sebechlebsky...@gmail.com wrote: For what reason? For example RTSP muxer att

[FFmpeg-devel] [PATCH 1/3] avcodec/get_bits: add cached bitstream reader

2017-07-13 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/get_bits.h | 263 +- libavcodec/golomb.h | 151 + 2 files changed, 388 insertions(+), 26 deletions(-) diff --git a/libavcodec/get_bits.h b/libavcodec/get_bits.h index c530015.

Re: [FFmpeg-devel] [PATCH 1/1] This change adds an encoder for Camera metadata motion. This is a type of sensor data associated with video, such as GPS, acceleration, gyro, and camera orientation. It

2017-07-13 Thread wm4
On Wed, 12 Jul 2017 22:42:36 +0200 Hendrik Leppkes wrote: > On Wed, Jul 12, 2017 at 8:31 PM, Louis O'Bryan > wrote: > > On Wed, Jul 12, 2017 at 9:16 AM, Louis O'Bryan wrote: > > > >> On Wed, Jul 12, 2017 at 12:50 AM, wm4 wrote: > >> > >>> On Tue, 11 Jul 2017 16:17:33 -0700 > >>> "Louis O'B

[FFmpeg-devel] [PATCH] avfilter: add motion filter

2017-07-13 Thread Ashish Singh
Hi, this is motion filter, one of the component filters of VMAF. It takes two videos as input. Run it using: ffmpeg -i main -i ref -lavfi motion -f null - Currently it outputs the average motion score over all frames. --- Changelog | 1 + doc/filters.texi | 19 +++ lib