Make it thread-safe and avoid redundant initialization.
Signed-off-by: Muhammad Faiz
---
libavcodec/fft_template.c | 81 +--
1 file changed, 71 insertions(+), 10 deletions(-)
diff --git a/libavcodec/fft_template.c b/libavcodec/fft_template.c
index 647
2017-07-04 11:24 GMT+08:00 Steven Liu :
> when use fmp4 segment type in hls and use codec copy,
> there have an error message.
> error message:
>[mp4 @ 0x25df020] Tag avc1 incompatible with output codec id '28'
> ([33][0][0][0])
>[hls @ 0x2615c80] Some of the provided format options in '(n
Here another file chptr1.gdv, 0,5 Mb long:
https://drive.google.com/file/d/0B8VpSH5prLMrT1pFejhQV2tQWWs/view?usp=sharing
2017-07-05 7:06 GMT+05:00 Michael Niedermayer :
> On Tue, Jul 04, 2017 at 11:41:33PM +0500, Azamat Hackimov wrote:
> > FATE checks commit sent. Here reference files -
> > https
On Wed, Jul 05, 2017 at 01:15:39AM +0200, Hendrik Leppkes wrote:
> On Tue, Jul 4, 2017 at 10:53 PM, Derek Buitenhuis
> wrote:
> > On 7/4/2017 9:33 PM, Michael Niedermayer wrote:
> >> Fixes: out of array access
> >> Fixes: 2451/clusterfuzz-testcase-minimized-4781613957251072
> >>
> >> Found-by: con
On Tue, Jul 04, 2017 at 11:41:33PM +0500, Azamat Hackimov wrote:
> FATE checks commit sent. Here reference files -
> https://drive.google.com/open?id=0B8VpSH5prLMrVHppWDBPaG1aTVk
>
> ace.gdv - without audio stream
> gremlogo.gdv - with audio stream
this is with 2mb a bit big, is there a smaller
On 6/30/2017 4:29 AM, Paul B Mahol wrote:
> On 6/30/17, James Almer wrote:
>> Signed-off-by: James Almer
>> ---
>> libavcodec/x86/utvideodsp.asm| 20 ++--
>> libavcodec/x86/utvideodsp_init.c | 2 +-
>> 2 files changed, 15 insertions(+), 7 deletions(-)
>>
>
> ok if tested.
On 7/4/2017 10:45 PM, Michael Niedermayer wrote:
> On Tue, Jul 04, 2017 at 03:15:56PM -0300, James Almer wrote:
>> On 7/4/2017 2:31 PM, Michael Niedermayer wrote:
>>> On Mon, Jul 03, 2017 at 02:32:28PM +0200, Matthieu Bouron wrote:
On Fri, Jun 30, 2017 at 05:16:37PM +0200, Matthieu Bouron wrot
On Tue, Jul 04, 2017 at 03:15:56PM -0300, James Almer wrote:
> On 7/4/2017 2:31 PM, Michael Niedermayer wrote:
> > On Mon, Jul 03, 2017 at 02:32:28PM +0200, Matthieu Bouron wrote:
> >> On Fri, Jun 30, 2017 at 05:16:37PM +0200, Matthieu Bouron wrote:
> >>> On Fri, Jun 30, 2017 at 03:55:52PM +0200, M
Hi,
On Tue, Jul 4, 2017 at 6:07 PM, James Almer wrote:
> On 7/4/2017 6:41 PM, Ronald S. Bultje wrote:
> > Hi,
> >
> > On Tue, Jul 4, 2017 at 5:29 PM, James Almer wrote:
> >
> >> On 7/3/2017 1:38 PM, Ashish Singh wrote:
> >>> +{"disable avx", "Disables avx for computing vmaf.",
> >> OFFSET(
On 7/5/2017 12:15 AM, Hendrik Leppkes wrote:
> The patch seems fine to me, mid-stream extradata should be populated
> to avctx when its used by a frame, not when its parsed.
> The export during parsing should only be done on codec open so initial
> values are populated to the context right away.
M
On Tue, Jul 4, 2017 at 10:53 PM, Derek Buitenhuis
wrote:
> On 7/4/2017 9:33 PM, Michael Niedermayer wrote:
>> Fixes: out of array access
>> Fixes: 2451/clusterfuzz-testcase-minimized-4781613957251072
>>
>> Found-by: continuous fuzzing process
>> https://github.com/google/oss-fuzz/tree/master/proj
On 04.07.2017, at 14:03, Ricardo Constantino wrote:
> On 4 July 2017 at 07:54, Reimar Döffinger wrote:
>> On 30.06.2017, at 20:06, Ricardo Constantino wrote:
>>
>>> libvorbis comes with pkg-config files since at least v1.0.1, way back
>>> in 2003.
>>>
>>> The extra check is needed for shared
On 7/4/2017 11:09 PM, Michael Niedermayer wrote:
> do you have some testcases that you are concerned about ?
> can you add them to fate ?
I can make some and test tomorrow morning if you're fine with waiting half a
day.
- Derek
___
ffmpeg-devel mailing
On Tue, Jul 04, 2017 at 09:53:00PM +0100, Derek Buitenhuis wrote:
> On 7/4/2017 9:33 PM, Michael Niedermayer wrote:
> > Fixes: out of array access
> > Fixes: 2451/clusterfuzz-testcase-minimized-4781613957251072
> >
> > Found-by: continuous fuzzing process
> > https://github.com/google/oss-fuzz/tr
On 7/4/2017 6:41 PM, Ronald S. Bultje wrote:
> Hi,
>
> On Tue, Jul 4, 2017 at 5:29 PM, James Almer wrote:
>
>> On 7/3/2017 1:38 PM, Ashish Singh wrote:
>>> +{"disable avx", "Disables avx for computing vmaf.",
>> OFFSET(disable_avx), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, FLAGS},
>>
>> Remove thi
On Tue, Jun 27, 2017 at 02:33:22PM +0200, Michael Niedermayer wrote:
> Fixes: runtime error: left shift of 1 by 31 places cannot be represented in
> type 'int'
> Fixes: 2377/clusterfuzz-testcase-minimized-6108505935183872
>
> Found-by: continuous fuzzing process
> https://github.com/google/oss-f
Hi,
On Tue, Jul 4, 2017 at 5:29 PM, James Almer wrote:
> On 7/3/2017 1:38 PM, Ashish Singh wrote:
> > +{"disable avx", "Disables avx for computing vmaf.",
> OFFSET(disable_avx), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, FLAGS},
>
> Remove this option, and check for the AVX cpuflag instead.
>
> That
On 7/3/2017 1:38 PM, Ashish Singh wrote:
> Added vmaf section in doc/filters.texi and Changelog.
>
> ---
> Changelog| 1 +
> configure| 5 +
> doc/filters.texi | 33
> libavfilter/Makefile | 1 +
> libavfilter/allfilters.c | 1 +
> libavfi
Hi,
On Tue, Jul 4, 2017 at 11:21 AM, Derek Buitenhuis <
derek.buitenh...@gmail.com> wrote:
> At a glace am I correct in thinking that all this locking around calls is
> because
> libvmaf is not thread-safe?
vmaf's interface is pull-based.
Ronald
___
On 7/4/2017 9:33 PM, Michael Niedermayer wrote:
> Fixes: out of array access
> Fixes: 2451/clusterfuzz-testcase-minimized-4781613957251072
>
> Found-by: continuous fuzzing process
> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer
> ---
> libav
Fixes: out of array access
Fixes: 2451/clusterfuzz-testcase-minimized-4781613957251072
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer
---
libavcodec/hevcdec.c | 8
1 file changed, 4 insertions(+), 4
On 7/4/2017 4:58 PM, Derek Buitenhuis wrote:
> I guess 'unchanged output' is as good of a result as any, for now...
Pushed patches 0.5 and 1.
Any comments on the other four?
- Derek
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.or
On 7/4/17, Ricardo Constantino wrote:
> libvorbis comes with pkg-config files since at least v1.0.1, way back in
> 2003.
>
> We need the two checks for vorbis and vorbisenc because we use functions
> from
> both and Xiph considers them separate libraries.
>
> The check is inverted (vorbis first th
On 7/4/17, Thilo Borgmann wrote:
> Am 02.07.17 um 16:17 schrieb Paul B Mahol:
>> On 7/2/17, Thilo Borgmann wrote:
>>> Am 01.07.17 um 22:23 schrieb Paul B Mahol:
This is native layout of this codec.
>>>
>>> From where is that definition?
>>
>> See how samples are stored in raw buffers.
>
> Th
Am 02.07.17 um 16:17 schrieb Paul B Mahol:
> On 7/2/17, Thilo Borgmann wrote:
>> Am 01.07.17 um 22:23 schrieb Paul B Mahol:
>>> This is native layout of this codec.
>>
>> From where is that definition?
>
> See how samples are stored in raw buffers.
The raw buffers are our own construct and as su
Am 04.07.17 um 09:40 schrieb Paul B Mahol:
> On 7/3/17, Thilo Borgmann wrote:
>> Am 02.07.17 um 19:45 schrieb Paul B Mahol:
>>> On 6/11/16, Thilo Borgmann wrote:
Hi,
> Am 09.06.2016 um 03:33 schrieb Michael Niedermayer
> :
>
> Fixes: Ticket5297
>
> Needs rev
FATE checks commit sent. Here reference files -
https://drive.google.com/open?id=0B8VpSH5prLMrVHppWDBPaG1aTVk
ace.gdv - without audio stream
gremlogo.gdv - with audio stream
Both files taken from Realms of the Haunting game.
2017-07-04 16:10 GMT+05:00 Michael Niedermayer :
> On Mon, Jul 03, 201
Two files to check - with and without audio stream.
---
tests/Makefile | 1 +
tests/fate/gdv.mak | 8 ++
tests/ref/fate/gdv-nosound | 26
tests/ref/fate/gdv-sound | 351 +
4 files changed, 386 insertions(+)
create mode 10
On 04.07.2017, at 10:42, wm4 wrote:
> Not really comfortable with the current patch. Why does it even touch
> the compat_decode_partial_size handling path?
Because that is the code that gets utterly confused by 0-size packets and
breaks everything.
For ac3 what happens is that after the first 0-
On 7/4/2017 2:31 PM, Michael Niedermayer wrote:
> On Mon, Jul 03, 2017 at 02:32:28PM +0200, Matthieu Bouron wrote:
>> On Fri, Jun 30, 2017 at 05:16:37PM +0200, Matthieu Bouron wrote:
>>> On Fri, Jun 30, 2017 at 03:55:52PM +0200, Michael Niedermayer wrote:
On Thu, Jun 29, 2017 at 10:53:06PM -03
libvorbis comes with pkg-config files since at least v1.0.1, way back in 2003.
We need the two checks for vorbis and vorbisenc because we use functions from
both and Xiph considers them separate libraries.
The check is inverted (vorbis first then vorbisenc) because add_extralibs()
prepends to EXT
On Mon, Jul 03, 2017 at 02:32:28PM +0200, Matthieu Bouron wrote:
> On Fri, Jun 30, 2017 at 05:16:37PM +0200, Matthieu Bouron wrote:
> > On Fri, Jun 30, 2017 at 03:55:52PM +0200, Michael Niedermayer wrote:
> > > On Thu, Jun 29, 2017 at 10:53:06PM -0300, James Almer wrote:
> > > > On 6/29/2017 10:14
On Tue, Jul 4, 2017 at 10:20 PM, Nicolas George wrote:
> Le sextidi 16 messidor, an CCXXV, Paras Chadha a écrit :
> > There is no global header.
> >
> > Basically FITS files can have multiple images.
>
>
> Thanks for all the details. When there are several images, they are all
> one after the ot
Le sextidi 16 messidor, an CCXXV, Paras Chadha a écrit :
> There is no global header.
>
> Basically FITS files can have multiple images.
Thanks for all the details. When there are several images, they are all
one after the other?
If so, then I really think you should stop the demuxer and integr
On Tue, Jul 4, 2017 at 2:51 PM, Nicolas George wrote:
> Le quartidi 14 messidor, an CCXXV, Paras Chadha a écrit :
> > Filled buf with 0 to prevent overfow
> > Also added checks for integer overflow
> >
> > Signed-off-by: Paras Chadha
> > ---
> > libavformat/Makefile | 1 +
> > libavformat
On Tue, Jul 4, 2017 at 4:12 AM, Reimar Döffinger
wrote:
>
> > +static int64_t find_size(AVIOContext * pb, FITSContext * fits)
> > +{
> > +int bitpix, naxis, dim_no, i, naxisn[999], groups=0;
> > +int64_t header_size = 0, data_size=0, ret, pcount=0, gcount=1, d;
> > +char buf[81], c;
>
On Tue, Jul 4, 2017 at 2:57 PM, Nicolas George wrote:
> Le quartidi 14 messidor, an CCXXV, Paras Chadha a écrit :
> > Made all the changes suggested
> > Added a new function which reads a header FITS line safely. It also
> makes it more modular
> > Added an option for the user to enter the value
On 7/4/2017 12:57 PM, Derek Buitenhuis wrote:
> On 7/4/2017 4:31 PM, Hendrik Leppkes wrote:
>> "dtsc" appears to be the base DTS codec, according to
>> http://www.mp4ra.org/codecs.html
>> "mp4a" only applies to codecs defined in the official MP4 specification.
>
> Oh, I missed that.
>
> Still not
On 7/4/2017 4:52 PM, James Almer wrote:
> According to mp4ra.org, DTS core should have a dtsc codec tag. The rest
> are for the extensions. A quick test changing mp4a to dtsc on top of
> your patchset resulted in a wildly different output file, among other
> reasons because the esds box isn't writt
On 7/4/2017 4:31 PM, Hendrik Leppkes wrote:
> "dtsc" appears to be the base DTS codec, according to
> http://www.mp4ra.org/codecs.html
> "mp4a" only applies to codecs defined in the official MP4 specification.
Oh, I missed that.
Still not sure if we need to handle the extra layered stuff inside m
On 7/4/2017 12:09 PM, Derek Buitenhuis wrote:
> On 7/3/2017 3:00 AM, James Almer wrote:
>> Doesn't DTS have a bunch of unique tags? The ones listed in
>> ff_codec_movaudio_tags and http://www.mp4ra.org/codecs.html
>
> It looks like those only cover DTS extensions, which we all
> mark s AV_CODEC_ID
On Tue, Jul 04, 2017 at 05:24:45PM +0200, Matthieu Bouron wrote:
> On Tue, Jul 04, 2017 at 12:31:59PM +0200, Michael Niedermayer wrote:
> > On Mon, Jul 03, 2017 at 02:02:24PM +0200, Matthieu Bouron wrote:
> > > ---
> > >
> > > The following patch makes lavf/utils only update stream duration only i
On Tue, Jul 4, 2017 at 5:09 PM, Derek Buitenhuis
wrote:
> On 7/3/2017 3:00 AM, James Almer wrote:
>> Doesn't DTS have a bunch of unique tags? The ones listed in
>> ff_codec_movaudio_tags and http://www.mp4ra.org/codecs.html
>
> It looks like those only cover DTS extensions, which we all
> mark s A
On Tue, Jul 04, 2017 at 12:31:59PM +0200, Michael Niedermayer wrote:
> On Mon, Jul 03, 2017 at 02:02:24PM +0200, Matthieu Bouron wrote:
> > ---
> >
> > The following patch makes lavf/utils only update stream duration only if it
> > is
> > not set or 0 in fill_all_stream_timings (which is called b
On 7/3/2017 5:38 PM, Ashish Singh wrote:
> +enabled libvmaf && { check_lib libvmaf "libvmaf.h" "compute_vmaf"
> -lvmaf -lstdc++ -lpthread -lm ||
> + die "ERROR: libvmaf must be installed"; }
This won't work on, for example, OS X, which uses libc++ instead o
On 7/3/2017 3:00 AM, James Almer wrote:
> Doesn't DTS have a bunch of unique tags? The ones listed in
> ff_codec_movaudio_tags and http://www.mp4ra.org/codecs.html
It looks like those only cover DTS extensions, which we all
mark s AV_CODEC_ID_DTS. Is the DTS base layer 'mp4a'? I don't
have a sourc
On 7/4/2017 9:19 AM, Moritz Barsnick wrote:
> A user confirms that this patchset helps them play ffmpeg created HEVC
> videos in (a newer) Mac OS X's QT Player:
> http://ffmpeg.org/pipermail/ffmpeg-user/2017-July/036527.html
Great. Will send new version of patch 1 today.
- Derek
_
- This patch contains the changes to interface the Turing codec
(http://turingcodec.org/) with ffmpeg. The patch was modified to address the
comments in the review as follows:
- Added a pkg-config file to list all dependencies required by libturing.
This should address the issue pointed out by
On Mon, Jun 05, 2017 at 06:55:21AM -0400, Kevin Mark wrote:
> The scale2ref filter will now maintain the DAR of the main input and
> not the DAR of the reference input. This previous behavior was deemed
> counterintuitive for most (all?) use-cases.
>
> Before:
> scale2ref=iw/4:ow/mdar
> in w:320
On 4 July 2017 at 07:54, Reimar Döffinger wrote:
> On 30.06.2017, at 20:06, Ricardo Constantino wrote:
>
>> libvorbis comes with pkg-config files since at least v1.0.1, way back
>> in 2003.
>>
>> The extra check is needed for shared builds, as the pkg-config file
>> for vorbisenc doesn't include
On Thu, 29 Jun 2017 14:06:21 +
Saverio Blasi wrote:
> - This patch contains the changes to interface the Turing codec
> (http://turingcodec.org/) with ffmpeg. The patch was modified to address the
> comments in the review as follows:
> - Added a pkg-config file to list all dependencies re
On Mon, Jul 03, 2017 at 01:10:55AM +0500, Azamat H. Hackimov wrote:
> Added 2 byte skipping if there no sound present, that fixes playback
> files without sound stream.
> ---
> libavformat/gdv.c | 2 ++
> 1 file changed, 2 insertions(+)
can you share a sample ?
and also add a fate test with some
On Mon, Jul 03, 2017 at 02:02:24PM +0200, Matthieu Bouron wrote:
> ---
>
> The following patch makes lavf/utils only update stream duration only if it is
> not set or 0 in fill_all_stream_timings (which is called by
> avformat_find_stream_info).
>
> In the context of mov demuxing, the patch makes
On Mon, Jul 03, 2017 at 22:08:12 +0530, Ashish Singh wrote:
> Added vmaf section in doc/filters.texi and Changelog.
Thanks for that.
> +This filter takes in input two input videos, the first input is
Input input? ;-) "This filter takes two input videos" should suffice.
> +Currently it requires
Le sextidi 16 messidor, an CCXXV, Nicolas George a écrit :
> If you change that into "a handful of kilo-octets", then for a project
> like FFmpeg (which is not a monster like a Gui toolkit but neither meant
> for embedded systems with tiny limits) I agree.
>
> But "a handful bytes", I consider the
Le sextidi 16 messidor, an CCXXV, Reimar Döffinger a écrit :
> From a security standpoint, I believe any array and anything that is
> more than a handful bytes ideally should not be on the stack, if the
> added complexity is minimal.
If you change that into "a handful of kilo-octets", then for a p
Le quartidi 14 messidor, an CCXXV, Paras Chadha a écrit :
> Made all the changes suggested
> Added a new function which reads a header FITS line safely. It also makes it
> more modular
> Added an option for the user to enter the value to be used in place of BLANK
> pixels
> Refactored code using
Le quartidi 14 messidor, an CCXXV, Paras Chadha a écrit :
> Filled buf with 0 to prevent overfow
> Also added checks for integer overflow
>
> Signed-off-by: Paras Chadha
> ---
> libavformat/Makefile | 1 +
> libavformat/allformats.c | 1 +
> libavformat/fitsdec.c| 224
>
On Tue, 4 Jul 2017 00:03:19 +0200
Reimar Döffinger wrote:
> On 03.07.2017, at 21:07, wm4 wrote:
>
> > On Mon, 3 Jul 2017 20:57:21 +0200
> > Reimar Döffinger wrote:
> >
> >> The old API did that just fine, and if we provide
> >> a compatibility layer it should at least be compatible.
> >> F
On Tue, 4 Jul 2017 08:42:56 +0200
Reimar Döffinger wrote:
> On 04.07.2017, at 00:51, Nicolas George wrote:
>
> > Hi. Nice to see you back.
> >
> > Le sextidi 16 messidor, an CCXXV, Reimar Döffinger a écrit :
> >> This is more than 4kB of data on the stack.
> >> Large stack arrays have a huge
On Tue, 4 Jul 2017 10:59:17 +0800
Steven Liu wrote:
> Hello? What about this support? This is a very interesting function :D
Currently it's discussed what the DRM hwframes API should look like.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http
On Wed, Jun 28, 2017 at 16:41:57 +0100, Derek Buitenhuis wrote:
> Apple software and devices requrie hvc1. This patchset was originally
> sent to Libav for this same purpose.
A user confirms that this patchset helps them play ffmpeg created HEVC
videos in (a newer) Mac OS X's QT Player:
http://ffm
On 03.07.2017 18:01, Ashish Singh wrote:
Added ansnr section in doc/filters.texi and changelog and fixed issues.
---
Changelog| 1 +
doc/filters.texi | 24 +++
libavfilter/Makefile | 1 +
libavfilter/allfilters.c | 1 +
libavfilter/ansnr.h | 29
lib
On 7/3/17, Thilo Borgmann wrote:
> Am 02.07.17 um 19:45 schrieb Paul B Mahol:
>> On 6/11/16, Thilo Borgmann wrote:
>>>
>>> Hi,
>>>
Am 09.06.2016 um 03:33 schrieb Michael Niedermayer
:
Fixes: Ticket5297
Needs review by maintainer / author to check that this is ok and
Signed-off-by: Paul B Mahol
---
doc/filters.texi | 17 +++
libavfilter/Makefile | 1 +
libavfilter/allfilters.c | 1 +
libavfilter/limiter.h | 33 ++
libavfilter/vf_limiter.c | 228 ++
libavf
On 28.06.2017, at 10:52, Timo Rothenpieler wrote:
> Am 27.06.2017 um 21:47 schrieb Michael Niedermayer:
>> 0.5% faster loop
>>
>> Signed-off-by: Michael Niedermayer
>> ---
>> libavcodec/utvideodec.c | 6 --
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/libavcodec/utv
66 matches
Mail list logo
