Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-04-30 Thread Muhammad Faiz
On Mon, May 1, 2017 at 12:06 AM, Nicolas George wrote: > Le primidi 11 floréal, an CCXXV, Muhammad Faiz a écrit : >> Are you working on these? Because currently I'm not. > > There is nothing to work on yet: the message you answer to is raising a > question about the global design of the internal A

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-04-30 Thread Muhammad Faiz
On Mon, May 1, 2017 at 12:16 AM, wm4 wrote: > On Sun, 30 Apr 2017 23:55:02 +0700 > Muhammad Faiz wrote: > >> On Thu, Apr 27, 2017 at 3:51 PM, Nicolas George wrote: >> > L'octidi 8 floréal, an CCXXV, Michael Niedermayer a écrit : >> >> I agree >> >> in fact i added such a flag in 2011 >> >> (4d3

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/options: do a more thorough clean up in avcodec_copy_context()

2017-04-30 Thread James Almer
On 4/30/2017 11:10 PM, Michael Niedermayer wrote: > On Sun, Apr 30, 2017 at 10:07:17AM -0700, Aaron Levinson wrote: >> On 4/26/2017 12:47 PM, James Almer wrote: >>> On 4/26/2017 2:46 AM, Aaron Levinson wrote: On 4/24/2017 3:47 PM, James Almer wrote: > Free coded_frame, coded_side_data and

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/options: do a more thorough clean up in avcodec_copy_context()

2017-04-30 Thread Michael Niedermayer
On Sun, Apr 30, 2017 at 10:07:17AM -0700, Aaron Levinson wrote: > On 4/26/2017 12:47 PM, James Almer wrote: > >On 4/26/2017 2:46 AM, Aaron Levinson wrote: > >>On 4/24/2017 3:47 PM, James Almer wrote: > >>>Free coded_frame, coded_side_data and unref hw_device_ctx to prevent > >>>potential leaks. > >

Re: [FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-04-30 Thread Muhammad Faiz
On Mon, May 1, 2017 at 5:02 AM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi| 7 + > libavfilter/Makefile| 1 + > libavfilter/af_afirfilter.c | 411 > > libavfilter/allfilters.c| 1 + > 4 fi

[FFmpeg-devel] [PATCH v2] avcodec/decode: do not treat discarded frames as eof when draining

2017-04-30 Thread Muhammad Faiz
Fix fate failures: make fate-mov THREADS=32 Signed-off-by: Muhammad Faiz --- libavcodec/decode.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index edfae55..e330f14 100644 --- a/libavcodec/decode.c +++ b/libavcodec/deco

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: add support for writing Content Light Level elements

2017-04-30 Thread James Almer
On 4/25/2017 4:15 PM, James Almer wrote: > Signed-off-by: James Almer > --- > libavformat/matroskaenc.c | 15 +-- > 1 file changed, 13 insertions(+), 2 deletions(-) Pushed. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: export Content Light Level metadata

2017-04-30 Thread James Almer
On 4/25/2017 3:10 PM, James Almer wrote: > Based on a patch by Hendrik Leppkes > > Signed-off-by: James Almer > --- > libavformat/matroskadec.c | 15 +++ > 1 file changed, 15 insertions(+) Pushed. ___ ffmpeg-devel mailing list ffmpeg-devel

[FFmpeg-devel] [PATCH] avfilter: add arbitrary audio FIR filter

2017-04-30 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi| 7 + libavfilter/Makefile| 1 + libavfilter/af_afirfilter.c | 411 libavfilter/allfilters.c| 1 + 4 files changed, 420 insertions(+) create mode 100644 libavfilter/af_afir

[FFmpeg-devel] [PATCH v2 3/7] hevc_parser: use ff_h2645_packet_split() to parse NAL units

2017-04-30 Thread James Almer
This simplifies the code considerably. Signed-off-by: James Almer --- libavcodec/hevc_parser.c | 50 ++-- 1 file changed, 10 insertions(+), 40 deletions(-) diff --git a/libavcodec/hevc_parser.c b/libavcodec/hevc_parser.c index f82f9fdf5e..ac7a1ed78b 1

[FFmpeg-devel] [PATCH 6/7] hevc_parser: remove HEVCContext usage

2017-04-30 Thread James Almer
This gets rid of the duplicate, limited parser. Signed-off-by: James Almer --- libavcodec/hevc_parser.c | 176 +-- 1 file changed, 32 insertions(+), 144 deletions(-) diff --git a/libavcodec/hevc_parser.c b/libavcodec/hevc_parser.c index 501cbc3498..ab

[FFmpeg-devel] [PATCH 7/7] doc/libav_merge: remove line about ADVANCED_PARSER

2017-04-30 Thread James Almer
It's been dealt with. Signed-off-by: James Almer --- doc/libav-merge.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/doc/libav-merge.txt b/doc/libav-merge.txt index 6f052ec2eb..da9e2757f5 100644 --- a/doc/libav-merge.txt +++ b/doc/libav-merge.txt @@ -105,7 +105,6 @@ Collateral damage that

[FFmpeg-devel] [PATCH 5/7] hevcdec: move SliceHeader struct definition to hevc_ps

2017-04-30 Thread James Almer
Signed-off-by: James Almer --- libavcodec/hevc_ps.h | 83 libavcodec/hevcdec.h | 83 2 files changed, 83 insertions(+), 83 deletions(-) diff --git a/libavcodec/hevc_ps.h b/libavcodec/hevc_ps

[FFmpeg-devel] [PATCH 4/7] hevcdec: remove HEVCContext usage from ff_hevc_compute_poc()

2017-04-30 Thread James Almer
Move it to hevc_ps as well. This is in preparation for a following patch. Signed-off-by: James Almer --- libavcodec/hevc_parser.c | 2 +- libavcodec/hevc_ps.c | 23 +++ libavcodec/hevc_ps.h | 5 + libavcodec/hevc_refs.c | 23 --- libavcodec

[FFmpeg-devel] [PATCH v2 2/7] hevcdec: move SEI message parsing into a separate header

2017-04-30 Thread James Almer
It doesn't depend on hevcdec anymore. Signed-off-by: James Almer --- libavcodec/hevc_sei.c | 54 ++ libavcodec/hevc_sei.h | 125 ++ libavcodec/hevcdec.h | 66 +- 3 files changed, 140 insertions(+), 105

[FFmpeg-devel] [PATCH 0/7] Removing HEVCContext depencencies

2017-04-30 Thread James Almer
$subject James Almer (7): hevcdec: remove HEVCContext usage from hevc_sei hevcdec: move SEI message parsing into a separate header hevc_parser: use ff_h2645_packet_split() to parse NAL units hevcdec: remove HEVCContext usage from ff_hevc_compute_poc() hevcdec: move SliceHeader struct def

[FFmpeg-devel] [PATCH v2 1/7] hevcdec: remove HEVCContext usage from hevc_sei

2017-04-30 Thread James Almer
Based on the H264 SEI implementation. Signed-off-by: James Almer --- libavcodec/hevc_parser.c | 9 +-- libavcodec/hevc_refs.c | 4 +- libavcodec/hevc_sei.c| 154 +++ libavcodec/hevcdec.c | 90 +-- libavcodec/hevcd

Re: [FFmpeg-devel] [PATCH] avcodec/decode: do not treat discarded frames as eof when draining

2017-04-30 Thread Michael Niedermayer
On Sun, Apr 30, 2017 at 02:04:33PM +0700, Muhammad Faiz wrote: > Fix fate failures: > make fate-mov THREADS=32 > > Signed-off-by: Muhammad Faiz > --- > libavcodec/decode.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) breaks (infinit loop it seems) ./ffmpeg_g -i ~/tick

Re: [FFmpeg-devel] [PATCH] This fixes ISO date formatissue when manifest created by this muxer is not playable in most players. This ensures compatibility with dash standard. Tested on many players (d

2017-04-30 Thread Aaron Levinson
On 4/26/2017 4:27 AM, mfojtak wrote: --- libavformat/dashenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 6232c70..fe1d6c2 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -433,7 +433,7 @@ static void f

[FFmpeg-devel] [PATCH] libavformat/http: Ignore expired cookies

2017-04-30 Thread Micah Galizia
Signed-off-by: Micah Galizia --- libavformat/http.c | 213 +++-- 1 file changed, 156 insertions(+), 57 deletions(-) diff --git a/libavformat/http.c b/libavformat/http.c index 293a8a7204..d06103ab6d 100644 --- a/libavformat/http.c +++ b/libavformat/

Re: [FFmpeg-devel] [PATCH] Ignore expired cookies

2017-04-30 Thread Micah Galizia
Hi, This version fixes the cstr leak and explicitly frees tmp when allocating cookies fails. Freeing tmp also means we don't need to free *cookies when ret is less than zero. I've also formatted the name properly, so it'll show up as a new thread. Thanks in advance. ___

[FFmpeg-devel] [PATCH] hevc_parser: use ff_h2645_packet_split() to parse NAL units

2017-04-30 Thread James Almer
This simplifies the code considerably. --- libavcodec/hevc_parser.c | 50 ++-- 1 file changed, 10 insertions(+), 40 deletions(-) diff --git a/libavcodec/hevc_parser.c b/libavcodec/hevc_parser.c index 310428d0ff..5b9cd87d88 100644 --- a/libavcodec/hevc_p

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-04-30 Thread wm4
On Sun, 30 Apr 2017 23:55:02 +0700 Muhammad Faiz wrote: > On Thu, Apr 27, 2017 at 3:51 PM, Nicolas George wrote: > > L'octidi 8 floréal, an CCXXV, Michael Niedermayer a écrit : > >> I agree > >> in fact i added such a flag in 2011 > >> (4d34b6c1a1254850e39a36f08f4d2730092a54db) > >> within th

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/options: do a more thorough clean up in avcodec_copy_context()

2017-04-30 Thread Aaron Levinson
On 4/26/2017 12:47 PM, James Almer wrote: On 4/26/2017 2:46 AM, Aaron Levinson wrote: On 4/24/2017 3:47 PM, James Almer wrote: Free coded_frame, coded_side_data and unref hw_device_ctx to prevent potential leaks. Signed-off-by: James Almer --- libavcodec/options.c | 15 +++ 1 fil

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-04-30 Thread Nicolas George
Le primidi 11 floréal, an CCXXV, Muhammad Faiz a écrit : > Are you working on these? Because currently I'm not. There is nothing to work on yet: the message you answer to is raising a question about the global design of the internal API. That question needs an answer before any work can be done, a

Re: [FFmpeg-devel] [PATCH v2] avcodec/pthread_frame, decode: allow errors to happen on draining

2017-04-30 Thread Nicolas George
Le primidi 11 floréal, an CCXXV, James Almer a écrit : > I don't think there's any explicit written rule about it, but in any > case, both Ronald and wm4 had given him the ok for the patch he pushed, > so waiting 24 hours after that is fine. > > It could have waited a bit mainly because it's delic

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-04-30 Thread Muhammad Faiz
On Thu, Apr 27, 2017 at 3:51 PM, Nicolas George wrote: > L'octidi 8 floréal, an CCXXV, Michael Niedermayer a écrit : >> I agree >> in fact i added such a flag in 2011 >> (4d34b6c1a1254850e39a36f08f4d2730092a54db) >> within the API of that time to avfilter > > It was not a bad idea, but it should

Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec/options: factorize avcodec_copy_context() cleanup code

2017-04-30 Thread James Almer
On 4/24/2017 7:47 PM, James Almer wrote: > Signed-off-by: James Almer > --- > No changes since last version. > > libavcodec/options.c | 30 +++--- > 1 file changed, 15 insertions(+), 15 deletions(-) Ping for patchset. ___ ffmpe

Re: [FFmpeg-devel] [PATCH] avcodec/decode: do not treat discarded frames as eof when draining

2017-04-30 Thread Muhammad Faiz
On Sun, Apr 30, 2017 at 8:31 PM, wm4 wrote: > On Sun, 30 Apr 2017 14:04:33 +0700 > Muhammad Faiz wrote: > >> Fix fate failures: >> make fate-mov THREADS=32 >> >> Signed-off-by: Muhammad Faiz >> --- >> libavcodec/decode.c | 12 ++-- >> 1 file changed, 6 insertions(+), 6 deletions(-) >>

Re: [FFmpeg-devel] [PATCH v2] avcodec/pthread_frame, decode: allow errors to happen on draining

2017-04-30 Thread James Almer
On 4/30/2017 12:46 PM, Nicolas George wrote: > Le primidi 11 floréal, an CCXXV, Muhammad Faiz a écrit : >> I'm sorry for pushing it too quickly. I refer on >> https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2017-March/208718.html. > > This is wrong, do not take it into account. > > No objections

Re: [FFmpeg-devel] [PATCH v2] avcodec/pthread_frame, decode: allow errors to happen on draining

2017-04-30 Thread Nicolas George
Le primidi 11 floréal, an CCXXV, Muhammad Faiz a écrit : > I'm sorry for pushing it too quickly. I refer on > https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2017-March/208718.html. This is wrong, do not take it into account. No objections after one ping and a few days means the patch is OK. Anyt

Re: [FFmpeg-devel] [PATCH v2] avcodec/pthread_frame, decode: allow errors to happen on draining

2017-04-30 Thread Muhammad Faiz
On Sun, Apr 30, 2017 at 8:27 PM, wm4 wrote: > On Sun, 30 Apr 2017 06:09:18 +0700 > Muhammad Faiz wrote: > >> On Sat, Apr 29, 2017 at 6:18 AM, Muhammad Faiz wrote: >> > On Sat, Apr 29, 2017 at 6:01 AM, Michael Niedermayer >> > wrote: >> >> On Fri, Apr 28, 2017 at 11:23:10PM +0700, Muhammad Faiz

[FFmpeg-devel] [PATCH 2/2] hevcdec: move SEI message parsing into a separate header

2017-04-30 Thread James Almer
It doesn't depend on hevcdec anymore. Signed-off-by: James Almer --- libavcodec/hevc_sei.c | 54 ++ libavcodec/hevc_sei.h | 125 ++ libavcodec/hevcdec.h | 66 +- 3 files changed, 140 insertions(+), 105

[FFmpeg-devel] [PATCH 1/2] hevcdec: remove HEVCContext usage from hevc_sei

2017-04-30 Thread James Almer
Signed-off-by: James Almer --- libavcodec/hevc_parser.c | 9 +-- libavcodec/hevc_refs.c | 4 +- libavcodec/hevc_sei.c| 154 +++ libavcodec/hevcdec.c | 90 +-- libavcodec/hevcdec.h | 95 +---

Re: [FFmpeg-devel] Match source video timestamp

2017-04-30 Thread Eran Kornblau
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Carl > Eugen Hoyos > Sent: Sunday, April 30, 2017 2:18 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] Match source video timestamp > > 2017-04-30 13:09 GMT+0

Re: [FFmpeg-devel] libavcodec/exr : fix piz uncompress on big endian

2017-04-30 Thread Martin Vignali
> > Tested-by: michael on qemu mips > > Ping for apply this patch (and the two fate tests) Martin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/decode: do not treat discarded frames as eof when draining

2017-04-30 Thread wm4
On Sun, 30 Apr 2017 14:04:33 +0700 Muhammad Faiz wrote: > Fix fate failures: > make fate-mov THREADS=32 > > Signed-off-by: Muhammad Faiz > --- > libavcodec/decode.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/libavcodec/decode.c b/libavcodec/decode.

Re: [FFmpeg-devel] [PATCH v2] avcodec/pthread_frame, decode: allow errors to happen on draining

2017-04-30 Thread wm4
On Sun, 30 Apr 2017 06:09:18 +0700 Muhammad Faiz wrote: > On Sat, Apr 29, 2017 at 6:18 AM, Muhammad Faiz wrote: > > On Sat, Apr 29, 2017 at 6:01 AM, Michael Niedermayer > > wrote: > >> On Fri, Apr 28, 2017 at 11:23:10PM +0700, Muhammad Faiz wrote: > >>> On Fri, Apr 28, 2017 at 5:55 PM, Rona

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_h265: Suppress the "above array bounds" warning.

2017-04-30 Thread Mark Thompson
On 26/04/17 07:44, Jun Zhao wrote: > From f3678e0ceb691b6df5957a2c3d26d4f0d91d4ff5 Mon Sep 17 00:00:00 2001 > From: Jun Zhao > Date: Wed, 26 Apr 2017 14:00:56 +0800 > Subject: [PATCH] lavc/vaapi_encode_h265: Suppress the "above array bounds" > warning. > MIME-Version: 1.0 > Content-Type: text/pla

[FFmpeg-devel] [PATCH] hevc: Fix scaling list prediction delta for the 32x32 inter matrix

2017-04-30 Thread Mark Thompson
Fixes ticket #6356. --- This was broken in 627c044f50da3046809314f7cc742b8a10cf26a1, which changed the array index of the 32x32 inter matrix but missed this case. Sample at - with this change the output for that sample matches the reference decoder. libav

Re: [FFmpeg-devel] Match source video timestamp

2017-04-30 Thread Nicolas George
Le primidi 11 floréal, an CCXXV, Eran Kornblau a écrit : > Ping, re-attaching the same patch Hi. Thanks for the bug report and patch. I do not know the issue well enough to address the core validity in principle, but I have a few design comments that will need to be addressed. > Subject: [PATCH]

Re: [FFmpeg-devel] [PATCH v9] - Added Turing codec interface for ffmpeg

2017-04-30 Thread Carl Eugen Hoyos
2017-04-28 17:18 GMT+02:00 Saverio Blasi : > The patch applies nicely to my local ffmpeg repository. Please confirm that tools/patcheck does not report any issues (trailing whitespace cannot be committed to our repository). > This e-mail (and any attachments) is confidential Please do not top-p

Re: [FFmpeg-devel] Match source video timestamp

2017-04-30 Thread Carl Eugen Hoyos
2017-04-30 13:09 GMT+02:00 Eran Kornblau : >> I'm trying to transcode some video file (MP4/h264 baseline vfr/AAC) >> with ffmpeg, and I would like to have the frame timestamps in the >> transcoded file perfectly match the source video. Why does this not work with -copyts? Carl Eugen

Re: [FFmpeg-devel] Match source video timestamp

2017-04-30 Thread Eran Kornblau
Ping, re-attaching the same patch Eran -Original Message- From: Eran Kornblau Sent: Sunday, April 23, 2017 12:32 PM To: 'FFmpeg development discussions and patches' Subject: RE: Match source video timestamp > Hi all, > > I'm trying to transcode some video file (MP4/h264 baseline vfr/A

[FFmpeg-devel] [PATCH] avcodec/decode: do not treat discarded frames as eof when draining

2017-04-30 Thread Muhammad Faiz
Fix fate failures: make fate-mov THREADS=32 Signed-off-by: Muhammad Faiz --- libavcodec/decode.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index edfae55..6ec423b 100644 --- a/libavcodec/decode.c +++ b/libavcodec/d

Re: [FFmpeg-devel] [PATCH] avfilter/decode: do not treat discarded frames as eof when draining

2017-04-30 Thread Muhammad Faiz
On Sun, Apr 30, 2017 at 12:50 PM, Muhammad Faiz wrote: > Fix fate failures: > make fate-mov THREADS=32 > > Signed-off-by: Muhammad Faiz > --- > libavcodec/decode.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/libavcodec/decode.c b/libavcodec/decode.c >