[FFmpeg-devel] [PATCH 4/6] avformat/matroska: use av_stereo3d_alloc2()

2016-12-10 Thread James Almer
Signed-off-by: James Almer --- libavformat/matroska.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/matroska.c b/libavformat/matroska.c index f3e1be7..259e50f 100644 --- a/libavformat/matroska.c +++ b/libavformat/matroska.c @@ -151,9 +151,10 @@ const char *

[FFmpeg-devel] [PATCH 3/6] avutil/stereo3d: add av_stereo3d_alloc2()

2016-12-10 Thread James Almer
Also deprecate av_stereo3d_alloc(). This new alloc function optionally returns the size of the AVStereo3D struct. Signed-off-by: James Almer --- libavutil/stereo3d.c | 12 libavutil/stereo3d.h | 14 ++ 2 files changed, 26 insertions(+) diff --git a/libavutil/stereo3d.c

[FFmpeg-devel] [PATCH 5/6] avformat/mov: use av_stereo3d_alloc2()

2016-12-10 Thread James Almer
Signed-off-by: James Almer --- libavformat/isom.h | 1 + libavformat/mov.c | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/libavformat/isom.h b/libavformat/isom.h index 0fd9eb0..70c2af1 100644 --- a/libavformat/isom.h +++ b/libavformat/isom.h @@ -181,6 +181,7 @@ typede

[FFmpeg-devel] [PATCH 6/6] avcodec/mjpegdec: use av_stereo3d_alloc2()

2016-12-10 Thread James Almer
Signed-off-by: James Almer --- libavcodec/mjpegdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c index 742e07c..b0a6e00 100644 --- a/libavcodec/mjpegdec.c +++ b/libavcodec/mjpegdec.c @@ -1783,7 +1783,7 @@ static int mjpeg_decod

[FFmpeg-devel] [PATCH 2/6] avformat/matroskadec: use mastering display metadata's own alloc function

2016-12-10 Thread James Almer
Signed-off-by: James Almer --- libavformat/matroskadec.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 58731aa..493d63f 100644 --- a/libavformat/matroskadec.c +++ b/libavformat/matroskadec.c @@ -186

[FFmpeg-devel] [PATCH 1/6] avutil/mastering_display_metadata: add av_mastering_display_metadata_alloc2()

2016-12-10 Thread James Almer
Also deprecate av_mastering_display_metadata_alloc(). This new alloc function optionally returns the size of the AVMasteringDisplayMetadata struct. Signed-off-by: James Almer --- libavutil/mastering_display_metadata.c | 12 libavutil/mastering_display_metadata.h | 17 +

Re: [FFmpeg-devel] [PATCH] news: add entry about stricter configure behavior

2016-12-10 Thread Ronald S. Bultje
Hi, On Sat, Dec 10, 2016 at 7:17 PM, Carl Eugen Hoyos wrote: > 2016-12-10 23:59 GMT+01:00 James Almer : > > >>> Again, I'm against this. This is not news entry worthy. > >> > >> Then please revert the configure change: > >> This is (by far) the biggest change in configure behaviour since > forev

Re: [FFmpeg-devel] [PATCH] avcodec: Require avoptions for the user to set max_pixels.

2016-12-10 Thread James Almer
On 12/10/2016 9:23 PM, Michael Niedermayer wrote: > On Sat, Dec 10, 2016 at 08:31:57PM -0300, James Almer wrote: >> On 12/10/2016 7:01 PM, Michael Niedermayer wrote: >>> When we will backport this, it will be inevitably in a different location >>> in AVCodecContext in each release and master. 3.0,

Re: [FFmpeg-devel] [PATCH 1/2] avformat/matroskadec: allocate Colour related fields only if the file contains the relevant master

2016-12-10 Thread James Almer
On 12/8/2016 6:31 PM, James Almer wrote: > Ping for patchset. > Pushed. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec: Require avoptions for the user to set max_pixels.

2016-12-10 Thread Michael Niedermayer
On Sat, Dec 10, 2016 at 08:31:57PM -0300, James Almer wrote: > On 12/10/2016 7:01 PM, Michael Niedermayer wrote: > > When we will backport this, it will be inevitably in a different location > > in AVCodecContext in each release and master. 3.0, 3.1, 3.2 and master > > use the same soname though an

Re: [FFmpeg-devel] [PATCH] avcodec: Require avoptions for the user to set max_pixels.

2016-12-10 Thread Michael Niedermayer
On Sat, Dec 10, 2016 at 08:31:57PM -0300, James Almer wrote: > On 12/10/2016 7:01 PM, Michael Niedermayer wrote: > > When we will backport this, it will be inevitably in a different location > > in AVCodecContext in each release and master. 3.0, 3.1, 3.2 and master > > use the same soname though an

Re: [FFmpeg-devel] [PATCH] news: add entry about stricter configure behavior

2016-12-10 Thread Carl Eugen Hoyos
2016-12-10 23:59 GMT+01:00 James Almer : >>> Again, I'm against this. This is not news entry worthy. >> >> Then please revert the configure change: >> This is (by far) the biggest change in configure behaviour since forever, >> this has to be communicated and this was the condition for the patch.

Re: [FFmpeg-devel] [PATCH] news: add entry about stricter configure behavior

2016-12-10 Thread Carl Eugen Hoyos
2016-12-10 23:37 GMT+01:00 Hendrik Leppkes : >>> simple behavior changes in git master should not >>> be posted as their own news entries. >> >> Of course! >> But this is not a "simple" change but the biggest change in >> configure behaviour in the last decade. >> > > Not really, it just makes all

Re: [FFmpeg-devel] [PATCH] avcodec: Require avoptions for the user to set max_pixels.

2016-12-10 Thread James Almer
On 12/10/2016 7:01 PM, Michael Niedermayer wrote: > When we will backport this, it will be inevitably in a different location > in AVCodecContext in each release and master. 3.0, 3.1, 3.2 and master > use the same soname though and must have a binary compatible interface. > It thus can only saftely

Re: [FFmpeg-devel] [PATCH] ffplay: fix sws_scale possible out of bounds array access

2016-12-10 Thread Michael Niedermayer
On Sat, Dec 10, 2016 at 11:39:25PM +0100, Marton Balint wrote: > > On Sat, 10 Dec 2016, Michael Niedermayer wrote: > > >On Sat, Dec 10, 2016 at 01:06:59PM +0100, Marton Balint wrote: > >>As I used simple RGBA formats for subtitles and for the video texture if > >>avfilter is disabled I kind of as

Re: [FFmpeg-devel] [PATCH] news: add entry about stricter configure behavior

2016-12-10 Thread James Almer
On 12/10/2016 7:27 PM, Carl Eugen Hoyos wrote: > 2016-12-10 23:24 GMT+01:00 James Almer : >> On 12/10/2016 7:22 PM, Carl Eugen Hoyos wrote: >>> 2016-12-10 19:47 GMT+01:00 Andreas Cadhalpun >>> : Suggested-by: Carl Eugen Hoyos Signed-off-by: Andreas Cadhalpun --- src/index |

Re: [FFmpeg-devel] [PATCH] news: add entry about stricter configure behavior

2016-12-10 Thread Marton Balint
On Sat, 10 Dec 2016, James Almer wrote: On 12/10/2016 7:22 PM, Carl Eugen Hoyos wrote: 2016-12-10 19:47 GMT+01:00 Andreas Cadhalpun : Suggested-by: Carl Eugen Hoyos Signed-off-by: Andreas Cadhalpun --- src/index | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/index b/src/ind

Re: [FFmpeg-devel] [PATCH] news: add entry about stricter configure behavior

2016-12-10 Thread James Almer
On 12/10/2016 7:34 PM, Carl Eugen Hoyos wrote: > 2016-12-10 23:32 GMT+01:00 Hendrik Leppkes : >> On Sat, Dec 10, 2016 at 11:24 PM, James Almer wrote: >>> On 12/10/2016 7:22 PM, Carl Eugen Hoyos wrote: 2016-12-10 19:47 GMT+01:00 Andreas Cadhalpun : > Suggested-by: Carl Eugen Hoyos >

Re: [FFmpeg-devel] [PATCH] news: add entry about stricter configure behavior

2016-12-10 Thread Carl Eugen Hoyos
2016-12-10 23:24 GMT+01:00 James Almer : > On 12/10/2016 7:22 PM, Carl Eugen Hoyos wrote: >> 2016-12-10 19:47 GMT+01:00 Andreas Cadhalpun >> : >>> Suggested-by: Carl Eugen Hoyos >>> Signed-off-by: Andreas Cadhalpun >>> --- >>> src/index | 7 +++ >>> 1 file changed, 7 insertions(+) >>> >>> d

Re: [FFmpeg-devel] [PATCH] ffplay: fix sws_scale possible out of bounds array access

2016-12-10 Thread Marton Balint
On Sat, 10 Dec 2016, Michael Niedermayer wrote: On Sat, Dec 10, 2016 at 01:06:59PM +0100, Marton Balint wrote: As I used simple RGBA formats for subtitles and for the video texture if avfilter is disabled I kind of assumed that sws_scale won't access data pointers and strides above index 0, bu

Re: [FFmpeg-devel] [PATCH] news: add entry about stricter configure behavior

2016-12-10 Thread Hendrik Leppkes
On Sat, Dec 10, 2016 at 11:34 PM, Carl Eugen Hoyos wrote: > 2016-12-10 23:32 GMT+01:00 Hendrik Leppkes : >> On Sat, Dec 10, 2016 at 11:24 PM, James Almer wrote: >>> On 12/10/2016 7:22 PM, Carl Eugen Hoyos wrote: 2016-12-10 19:47 GMT+01:00 Andreas Cadhalpun : > Suggested-by: Carl Eu

Re: [FFmpeg-devel] [PATCH] avformat/options_table: Set the default maximum number of streams to 100

2016-12-10 Thread Ronald S. Bultje
Hi, On Sat, Dec 10, 2016 at 5:24 PM, Carl Eugen Hoyos wrote: > 2016-12-10 14:07 GMT+01:00 Ronald S. Bultje : > > Hi, > > > > On Sat, Dec 10, 2016 at 7:11 AM, Carl Eugen Hoyos > > wrote: > > > >> 2016-12-09 12:56 GMT+01:00 Ronald S. Bultje : > >> > >> > On IRC, we discussed at what values OOM st

Re: [FFmpeg-devel] [PATCH] news: add entry about stricter configure behavior

2016-12-10 Thread Carl Eugen Hoyos
2016-12-10 23:32 GMT+01:00 Hendrik Leppkes : > On Sat, Dec 10, 2016 at 11:24 PM, James Almer wrote: >> On 12/10/2016 7:22 PM, Carl Eugen Hoyos wrote: >>> 2016-12-10 19:47 GMT+01:00 Andreas Cadhalpun >>> : Suggested-by: Carl Eugen Hoyos Signed-off-by: Andreas Cadhalpun --- s

Re: [FFmpeg-devel] [PATCH] news: add entry about stricter configure behavior

2016-12-10 Thread Hendrik Leppkes
On Sat, Dec 10, 2016 at 11:24 PM, James Almer wrote: > On 12/10/2016 7:22 PM, Carl Eugen Hoyos wrote: >> 2016-12-10 19:47 GMT+01:00 Andreas Cadhalpun >> : >>> Suggested-by: Carl Eugen Hoyos >>> Signed-off-by: Andreas Cadhalpun >>> --- >>> src/index | 7 +++ >>> 1 file changed, 7 insertions

Re: [FFmpeg-devel] [PATCH] avformat/options_table: Set the default maximum number of streams to 100

2016-12-10 Thread Carl Eugen Hoyos
2016-12-10 14:07 GMT+01:00 Ronald S. Bultje : > Hi, > > On Sat, Dec 10, 2016 at 7:11 AM, Carl Eugen Hoyos > wrote: > >> 2016-12-09 12:56 GMT+01:00 Ronald S. Bultje : >> >> > On IRC, we discussed at what values OOM start occurring, which >> > seems to be around 30k-60k >> >> This is not true, why d

Re: [FFmpeg-devel] [PATCH] news: add entry about stricter configure behavior

2016-12-10 Thread James Almer
On 12/10/2016 7:22 PM, Carl Eugen Hoyos wrote: > 2016-12-10 19:47 GMT+01:00 Andreas Cadhalpun > : >> Suggested-by: Carl Eugen Hoyos >> Signed-off-by: Andreas Cadhalpun >> --- >> src/index | 7 +++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/src/index b/src/index >> index c203676..

Re: [FFmpeg-devel] [PATCH] news: add entry about stricter configure behavior

2016-12-10 Thread Carl Eugen Hoyos
2016-12-10 19:47 GMT+01:00 Andreas Cadhalpun : > Suggested-by: Carl Eugen Hoyos > Signed-off-by: Andreas Cadhalpun > --- > src/index | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/src/index b/src/index > index c203676..8f533f5 100644 > --- a/src/index > +++ b/src/index > @@ -37,

[FFmpeg-devel] [PATCH] avcodec: Require avoptions for the user to set max_pixels.

2016-12-10 Thread Michael Niedermayer
When we will backport this, it will be inevitably in a different location in AVCodecContext in each release and master. 3.0, 3.1, 3.2 and master use the same soname though and must have a binary compatible interface. It thus can only saftely be accessed through AVOptions It may be enough to requir

Re: [FFmpeg-devel] [PATCH] avutil/tests: run the cpu_init.c test conditionally on HAVE_THREADS

2016-12-10 Thread James Almer
On 12/6/2016 4:00 PM, Wan-Teh Chang wrote: > Also declare the main() function with void arguments because argc and > argv are unused. > > These changes are suggested by Diego Biurrun and James Almer. > > Signed-off-by: Wan-Teh Chang > --- > libavutil/Makefile | 2 +- > libavutil/tests/c

Re: [FFmpeg-devel] [PATCH] Support limiting the number of pixels per image

2016-12-10 Thread Michael Niedermayer
On Fri, Dec 09, 2016 at 08:47:00PM +0100, Paul B Mahol wrote: > On 12/9/16, Michael Niedermayer wrote: > > Adds av_image_check_size2() with max_pixels and pix_fmt parameters. > > pix_fmt is unused and is added to avoid a 2nd API change later > > > > The old function uses AVOptions to obtain the ma

Re: [FFmpeg-devel] [PATCH] Support limiting the number of pixels per image

2016-12-10 Thread Michael Niedermayer
On Sat, Dec 10, 2016 at 01:33:59PM +0100, Andreas Cadhalpun wrote: > On 09.12.2016 20:31, Michael Niedermayer wrote: > > Adds av_image_check_size2() with max_pixels and pix_fmt parameters. > > pix_fmt is unused and is added to avoid a 2nd API change later > > > > The old function uses AVOptions to

Re: [FFmpeg-devel] [PATCH] Support limiting the number of pixels per image

2016-12-10 Thread Michael Niedermayer
On Sat, Dec 10, 2016 at 12:20:01PM +0100, wm4 wrote: > On Fri, 9 Dec 2016 20:31:40 +0100 > Michael Niedermayer wrote: > > > Adds av_image_check_size2() with max_pixels and pix_fmt parameters. > > pix_fmt is unused and is added to avoid a 2nd API change later > > > > The old function uses AVOpti

Re: [FFmpeg-devel] [PATCH] news: add entry about stricter configure behavior

2016-12-10 Thread Ronald S. Bultje
Hi, On Sat, Dec 10, 2016 at 1:53 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > On 10.12.2016 19:49, James Almer wrote: > > On 12/10/2016 3:47 PM, Andreas Cadhalpun wrote: > >> Suggested-by: Carl Eugen Hoyos > >> Signed-off-by: Andreas Cadhalpun > >> --- > >> src/index | 7

Re: [FFmpeg-devel] [PATCH] ffplay: fix sws_scale possible out of bounds array access

2016-12-10 Thread Michael Niedermayer
On Sat, Dec 10, 2016 at 01:06:59PM +0100, Marton Balint wrote: > As I used simple RGBA formats for subtitles and for the video texture if > avfilter is disabled I kind of assumed that sws_scale won't access data > pointers and strides above index 0, but apparently that is not the case. > > Fixes C

Re: [FFmpeg-devel] [PATCH] avformat/options_table: Set the default maximum number of streams to 100

2016-12-10 Thread Michael Niedermayer
On Fri, Dec 09, 2016 at 06:56:53AM -0500, Ronald S. Bultje wrote: > Hi, > > On Thu, Dec 8, 2016 at 7:03 PM, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com> wrote: > > > On 08.12.2016 22:59, Carl Eugen Hoyos wrote: > > > 2016-12-08 18:37 GMT+01:00 Michael Niedermayer : > > > > > >> -{"max_

[FFmpeg-devel] [PATCH 2/2] avformat/utils: Print verbose error message if stream count exceeds max_streams

2016-12-10 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavformat/utils.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 9e979a7c79..897352924d 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -4217,8 +4217,11 @@ AVStream *avf

[FFmpeg-devel] [PATCH 1/2] avformat/options_table: Set the default maximum number of streams to 1000

2016-12-10 Thread Michael Niedermayer
Fixes CVE-2016-9561 Suggested-by: Andreas Cadhalpun Signed-off-by: Michael Niedermayer --- libavformat/options_table.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/options_table.h b/libavformat/options_table.h index d5448e503f..a537dda95e 100644 --- a/libavfor

Re: [FFmpeg-devel] [PATCH] news: add entry about stricter configure behavior

2016-12-10 Thread Andreas Cadhalpun
On 10.12.2016 19:49, James Almer wrote: > On 12/10/2016 3:47 PM, Andreas Cadhalpun wrote: >> Suggested-by: Carl Eugen Hoyos >> Signed-off-by: Andreas Cadhalpun >> --- >> src/index | 7 +++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/src/index b/src/index >> index c203676..8f533f5 1

Re: [FFmpeg-devel] [PATCH] news: add entry about stricter configure behavior

2016-12-10 Thread James Almer
On 12/10/2016 3:47 PM, Andreas Cadhalpun wrote: > Suggested-by: Carl Eugen Hoyos > Signed-off-by: Andreas Cadhalpun > --- > src/index | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/src/index b/src/index > index c203676..8f533f5 100644 > --- a/src/index > +++ b/src/index > @@ -3

[FFmpeg-devel] [PATCH] news: add entry about stricter configure behavior

2016-12-10 Thread Andreas Cadhalpun
Suggested-by: Carl Eugen Hoyos Signed-off-by: Andreas Cadhalpun --- src/index | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/index b/src/index index c203676..8f533f5 100644 --- a/src/index +++ b/src/index @@ -37,6 +37,13 @@ News + December 10th, 2016, stricter configu

Re: [FFmpeg-devel] [PATCH 3/3] configure: fail if autodetect-libraries are requested but not found

2016-12-10 Thread Andreas Cadhalpun
On 03.12.2016 01:25, Michael Niedermayer wrote: > On Fri, Dec 02, 2016 at 11:24:12PM +0100, Andreas Cadhalpun wrote: >> On 02.12.2016 19:20, Michael Niedermayer wrote: >>> iam ok with the patch if other are and its tested >> >> I've tested for all AUTODETECT_LIBS that enabling the when configure >>

Re: [FFmpeg-devel] [PATCH] opt: check image size when setting it

2016-12-10 Thread Andreas Cadhalpun
On 10.12.2016 18:40, Hendrik Leppkes wrote: > On Sat, Dec 10, 2016 at 6:20 PM, Andreas Cadhalpun > wrote: >> On 10.12.2016 17:29, Hendrik Leppkes wrote: >>> On Sat, Dec 10, 2016 at 4:55 PM, Andreas Cadhalpun >>> wrote: If that is done, the hard limit in av_image_check_size should check for >

Re: [FFmpeg-devel] [PATCH] opt: check image size when setting it

2016-12-10 Thread Hendrik Leppkes
On Sat, Dec 10, 2016 at 6:20 PM, Andreas Cadhalpun wrote: > On 10.12.2016 17:29, Hendrik Leppkes wrote: >> On Sat, Dec 10, 2016 at 4:55 PM, Andreas Cadhalpun >> wrote: >>> If that is done, the hard limit in av_image_check_size should check for >>> the maximum allowed value of any pixel format. >>

Re: [FFmpeg-devel] [PATCH] opt: check image size when setting it

2016-12-10 Thread Andreas Cadhalpun
On 10.12.2016 17:29, Hendrik Leppkes wrote: > On Sat, Dec 10, 2016 at 4:55 PM, Andreas Cadhalpun > wrote: >> If that is done, the hard limit in av_image_check_size should check for >> the maximum allowed value of any pixel format. >> But a check here is needed to make sure that width * height does

Re: [FFmpeg-devel] [PATCH] lavf: add ffprobe demuxer

2016-12-10 Thread Stefano Sabatini
On date Sunday 2016-12-04 22:54:21 +0100, Andreas Cadhalpun encoded: > On 31.10.2016 09:51, Stefano Sabatini wrote: > > From 7f209e27aa33e8f43444e5cfc44c68f664b69e06 Mon Sep 17 00:00:00 2001 > > From: Nicolas George > > Date: Sat, 11 Jan 2014 19:42:41 +0100 > > Subject: [PATCH] lavf: add ffprobe d

Re: [FFmpeg-devel] [PATCH] opt: check image size when setting it

2016-12-10 Thread Hendrik Leppkes
On Sat, Dec 10, 2016 at 4:55 PM, Andreas Cadhalpun wrote: > On 10.12.2016 16:26, wm4 wrote: >> On Sat, 10 Dec 2016 16:11:15 +0100 >> Andreas Cadhalpun wrote: >> >>> Signed-off-by: Andreas Cadhalpun >>> --- >>> libavutil/opt.c | 10 +- >>> 1 file changed, 9 insertions(+), 1 deletion(-) >

Re: [FFmpeg-devel] [PATCH] opt: check image size when setting it

2016-12-10 Thread Carl Eugen Hoyos
2016-12-10 16:55 GMT+01:00 Andreas Cadhalpun : > On 10.12.2016 16:19, Carl Eugen Hoyos wrote: >> 2016-12-10 16:11 GMT+01:00 Andreas Cadhalpun >> : >>> Signed-off-by: Andreas Cadhalpun >>> --- >>> libavutil/opt.c | 10 +- >>> 1 file changed, 9 insertions(+), 1 deletion(-) >>> >>> diff --g

Re: [FFmpeg-devel] [PATCH] opt: check image size when setting it

2016-12-10 Thread Carl Eugen Hoyos
2016-12-10 16:54 GMT+01:00 Hendrik Leppkes : > Allocations would need to be checked anyway with or without this check Do you think this is related? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmp

Re: [FFmpeg-devel] [PATCH] opt: check image size when setting it

2016-12-10 Thread Andreas Cadhalpun
On 10.12.2016 16:26, wm4 wrote: > On Sat, 10 Dec 2016 16:11:15 +0100 > Andreas Cadhalpun wrote: > >> Signed-off-by: Andreas Cadhalpun >> --- >> libavutil/opt.c | 10 +- >> 1 file changed, 9 insertions(+), 1 deletion(-) >> >> diff --git a/libavutil/opt.c b/libavutil/opt.c >> index f855cc

Re: [FFmpeg-devel] [PATCH] opt: check image size when setting it

2016-12-10 Thread Andreas Cadhalpun
On 10.12.2016 16:19, Carl Eugen Hoyos wrote: > 2016-12-10 16:11 GMT+01:00 Andreas Cadhalpun > : >> Signed-off-by: Andreas Cadhalpun >> --- >> libavutil/opt.c | 10 +- >> 1 file changed, 9 insertions(+), 1 deletion(-) >> >> diff --git a/libavutil/opt.c b/libavutil/opt.c >> index f855ccb..

Re: [FFmpeg-devel] [PATCH] opt: check image size when setting it

2016-12-10 Thread Hendrik Leppkes
On Sat, Dec 10, 2016 at 4:26 PM, wm4 wrote: > On Sat, 10 Dec 2016 16:11:15 +0100 > Andreas Cadhalpun wrote: > >> Signed-off-by: Andreas Cadhalpun >> --- >> libavutil/opt.c | 10 +- >> 1 file changed, 9 insertions(+), 1 deletion(-) >> >> diff --git a/libavutil/opt.c b/libavutil/opt.c >>

[FFmpeg-devel] [PATCH]lavd/v4l2: Do not set frame_set to a negative value

2016-12-10 Thread Carl Eugen Hoyos
Hi! Attached patch fixes a minor bug, displaying a negative bitrate. Please comment, Carl Eugen From e2e4999c9e91fb2f6bcc782fdfe7a2f5d73d7600 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sat, 10 Dec 2016 16:43:00 +0100 Subject: [PATCH] lavd/v4l2: Avoid setting frame_size to a negative v

Re: [FFmpeg-devel] [PATCH] opt: check image size when setting it

2016-12-10 Thread Carl Eugen Hoyos
2016-12-10 16:11 GMT+01:00 Andreas Cadhalpun : > Signed-off-by: Andreas Cadhalpun > --- > libavutil/opt.c | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/libavutil/opt.c b/libavutil/opt.c > index f855ccb..f713d3f 100644 > --- a/libavutil/opt.c > +++ b/libavutil/

Re: [FFmpeg-devel] [PATCH] opt: check image size when setting it

2016-12-10 Thread wm4
On Sat, 10 Dec 2016 16:11:15 +0100 Andreas Cadhalpun wrote: > Signed-off-by: Andreas Cadhalpun > --- > libavutil/opt.c | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/libavutil/opt.c b/libavutil/opt.c > index f855ccb..f713d3f 100644 > --- a/libavutil/opt.c >

[FFmpeg-devel] [PATCH] opt: check image size when setting it

2016-12-10 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun --- libavutil/opt.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index f855ccb..f713d3f 100644 --- a/libavutil/opt.c +++ b/libavutil/opt.c @@ -32,6 +32,7 @@ #include "common.h" #include "dict.h"

Re: [FFmpeg-devel] [PATCH] Support limiting the number of pixels per image

2016-12-10 Thread Michael Niedermayer
On Sat, Dec 10, 2016 at 12:43:49PM +0100, Carl Eugen Hoyos wrote: > 2016-12-10 12:13 GMT+01:00 wm4 : > > On Sat, 10 Dec 2016 11:51:04 +0100 > > Carl Eugen Hoyos wrote: > > > >> 2016-12-09 19:45 GMT+01:00 wm4 : > >> > >> > But users switching from FFmpeg to other software because > >> > it fails at

Re: [FFmpeg-devel] [PATCH] movenc: Tag files generated with strict experimental with a warning

2016-12-10 Thread Carl Eugen Hoyos
2016-12-02 21:00 GMT+01:00 Vittorio Giovara : > This will simplify identifying files that were generated with > unfinished/incomplete/non-standard specifications. Doesn't the muxer version information already provide this information? Are random metadata tags valid? Carl Eugen ___

Re: [FFmpeg-devel] [PATCH] vaapi_vp9: Do not set bit_depth on old versions

2016-12-10 Thread Carl Eugen Hoyos
2016-12-10 14:57 GMT+01:00 Mark Thompson : > I've applied the second patch and closed the ticket. Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avutil/tests: run the cpu_init.c test conditionally on HAVE_THREADS

2016-12-10 Thread Carl Eugen Hoyos
2016-12-06 20:00 GMT+01:00 Wan-Teh Chang : > Also declare the main() function with void arguments because argc and > argv are unused. Sounds like an unrelated change that should be part of an independent patch. Carl Eugen ___ ffmpeg-devel mailing list f

Re: [FFmpeg-devel] [PATCH] vaapi_vp9: Do not set bit_depth on old versions

2016-12-10 Thread Mark Thompson
On 10/12/16 12:52, Carl Eugen Hoyos wrote: > 2016-12-10 13:50 GMT+01:00 Mark Thompson : >> Fixes ticket #6003. >> --- >> On 10/12/16 12:09, Carl Eugen Hoyos wrote: >>> 2016-12-08 16:51 GMT+01:00 Mark Thompson : Fixes ticket #6003. >>> > May I suggest to revert this? > >> +pp->b

Re: [FFmpeg-devel] [PATCH 2/3] avformat/udp: Use avutil compat pthread_cond_timedwait.

2016-12-10 Thread Carl Eugen Hoyos
2016-12-07 7:04 GMT+01:00 Matt Oliver : > -#if HAVE_PTHREAD_CANCEL > -#include > -#endif > - > #ifndef HAVE_PTHREAD_CANCEL > #define HAVE_PTHREAD_CANCEL 0 > #endif Do you know what this block is supposed to do? If you remove it first, the diff gets much smaller... Carl Eugen ___

Re: [FFmpeg-devel] [PATCH] avformat/options_table: Set the default maximum number of streams to 100

2016-12-10 Thread Ronald S. Bultje
Hi, On Sat, Dec 10, 2016 at 7:11 AM, Carl Eugen Hoyos wrote: > 2016-12-09 12:56 GMT+01:00 Ronald S. Bultje : > > > On IRC, we discussed at what values OOM start occurring, which seems to > be > > around 30k-60k > > This is not true, why do you think so? http://lists.ffmpeg.org/pipermail/ffmpeg

[FFmpeg-devel] [PATCH] avdevice/decklink_enc: do not reference this after freeing it

2016-12-10 Thread Marton Balint
Fixes Coverity CID 1396863. Signed-off-by: Marton Balint --- libavdevice/decklink_enc.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/decklink_enc.cpp b/libavdevice/decklink_enc.cpp index dc4a24b..ad00224 100644 --- a/libavdevice/decklink_enc.cpp +++ b/libavde

Re: [FFmpeg-devel] [PATCH] vaapi_vp9: Do not set bit_depth on old versions

2016-12-10 Thread Carl Eugen Hoyos
2016-12-10 13:50 GMT+01:00 Mark Thompson : > Fixes ticket #6003. > --- > On 10/12/16 12:09, Carl Eugen Hoyos wrote: >> 2016-12-08 16:51 GMT+01:00 Mark Thompson : >>> Fixes ticket #6003. >> May I suggest to revert this? > +pp->bit_depth = h->h.bpp; Google doesn't easily f

[FFmpeg-devel] [PATCH] vaapi_vp9: Do not set bit_depth on old versions

2016-12-10 Thread Mark Thompson
Fixes ticket #6003. --- On 10/12/16 12:09, Carl Eugen Hoyos wrote: > 2016-12-08 16:51 GMT+01:00 Mark Thompson : >> Fixes ticket #6003. > >>> May I suggest to revert this? >>> +pp->bit_depth = h->h.bpp; >>> >>> Google doesn't easily find a version of va_dec_vp9.h >>> with _VADecPicturePara

Re: [FFmpeg-devel] [PATCH 1/2] opus_parser: fix leaking channel_maps on error

2016-12-10 Thread Andreas Cadhalpun
On 10.12.2016 04:19, Michael Niedermayer wrote: > On Fri, Dec 09, 2016 at 11:42:59PM +0100, Andreas Cadhalpun wrote: >> opus.c|1 + >> opusdec.c |1 - >> 2 files changed, 1 insertion(+), 1 deletion(-) >> 3e534ddbb39e05f8c7a5cfeba4b65ed587c3a519 >> 0001-opus_parser-fix-leaking-channel

Re: [FFmpeg-devel] [PATCH] configure: Require bit_depth field for VAAPI VP9 decode hwaccel

2016-12-10 Thread Carl Eugen Hoyos
2016-12-08 17:26 GMT+01:00 Mark Thompson : > libva versions from 1.6.0 to 1.6.2 do not include it, and therefore > cannot work with VP9 profile >= 2. (I missed this, sorry.) As said, please commit any of these patches soon. Carl Eugen ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/2] opus_parser: replace ff_parse_close with opus_parse_close

2016-12-10 Thread Andreas Cadhalpun
On 10.12.2016 01:17, Hendrik Leppkes wrote: > On Fri, Dec 9, 2016 at 11:46 PM, Andreas Cadhalpun > wrote: >> On 09.12.2016 15:02, Hendrik Leppkes wrote: >>> On Fri, Dec 9, 2016 at 12:09 AM, Andreas Cadhalpun >>> wrote: The former expects priv_data to be the ParseContext directly, so using >>

Re: [FFmpeg-devel] [PATCH] avformat/options_table: Set the default maximum number of streams to 100

2016-12-10 Thread Carl Eugen Hoyos
2016-12-10 13:33 GMT+01:00 Marton Balint : > > On Sat, 10 Dec 2016, Carl Eugen Hoyos wrote: > >> 2016-12-09 20:33 GMT+01:00 Marton Balint : >>> >>> If we still want a default limit, that limit should be IMHO >>> _insanely_ high, tens of thousands, not hundreds. >> >> Do you have a file that has hun

Re: [FFmpeg-devel] [PATCH] Support limiting the number of pixels per image

2016-12-10 Thread Andreas Cadhalpun
On 09.12.2016 20:31, Michael Niedermayer wrote: > Adds av_image_check_size2() with max_pixels and pix_fmt parameters. > pix_fmt is unused and is added to avoid a 2nd API change later > > The old function uses AVOptions to obtain the max_pixels value to simplify > the transition. > > TODO: split i

Re: [FFmpeg-devel] [PATCH] avformat/options_table: Set the default maximum number of streams to 100

2016-12-10 Thread Marton Balint
On Sat, 10 Dec 2016, Carl Eugen Hoyos wrote: 2016-12-09 20:33 GMT+01:00 Marton Balint : If we still want a default limit, that limit should be IMHO _insanely_ high, tens of thousands, not hundreds. Do you have a file that has hundreds of streams? No I don't, but that does not mean that nob

[FFmpeg-devel] [PATCH] avdevice/decklink_dec: properly initialize no_video variable

2016-12-10 Thread Marton Balint
Fixes Coverity CID 1396859. Signed-off-by: Marton Balint --- libavdevice/decklink_dec.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp index c98c51f..7df841b 100644 --- a/libavdevice/decklink_dec.cpp +++ b/libavdevice/decklink_de

Re: [FFmpeg-devel] [PATCH] avformat/options_table: Set the default maximum number of streams to 100

2016-12-10 Thread Carl Eugen Hoyos
2016-12-09 20:33 GMT+01:00 Marton Balint : > If we still want a default limit, that limit should be IMHO > _insanely_ high, tens of thousands, not hundreds. Do you have a file that has hundreds of streams? Note that I suggested 1000 as limit. Carl Eugen ___

Re: [FFmpeg-devel] [PATCH] avformat/options_table: Set the default maximum number of streams to 100

2016-12-10 Thread Carl Eugen Hoyos
2016-12-09 12:56 GMT+01:00 Ronald S. Bultje : > On IRC, we discussed at what values OOM start occurring, which seems to be > around 30k-60k This is not true, why do you think so? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://f

Re: [FFmpeg-devel] [PATCH] vaapi_vp9: Do not set bit_depth on old versions

2016-12-10 Thread Carl Eugen Hoyos
2016-12-08 16:51 GMT+01:00 Mark Thompson : > Fixes ticket #6003. >> May I suggest to revert this? >> >>> +pp->bit_depth = h->h.bpp; >> >> Google doesn't easily find a version of va_dec_vp9.h >> with _VADecPictureParameterBufferVP9->bit_depth. > > Urgh: libva 1.6.0 to 1.6.2 don't have this fiel

[FFmpeg-devel] [PATCH] ffplay: fix sws_scale possible out of bounds array access

2016-12-10 Thread Marton Balint
As I used simple RGBA formats for subtitles and for the video texture if avfilter is disabled I kind of assumed that sws_scale won't access data pointers and strides above index 0, but apparently that is not the case. Fixes Coverity CID 1396737, 1396738, 1396739, 1396740. Signed-off-by: Marton Ba

Re: [FFmpeg-devel] [PATCH] Support limiting the number of pixels per image

2016-12-10 Thread Carl Eugen Hoyos
2016-12-10 12:13 GMT+01:00 wm4 : > On Sat, 10 Dec 2016 11:51:04 +0100 > Carl Eugen Hoyos wrote: > >> 2016-12-09 19:45 GMT+01:00 wm4 : >> >> > But users switching from FFmpeg to other software because >> > it fails at the limit does happen. >> >> Could you elaborate? >> Was there a bug report that

Re: [FFmpeg-devel] [PATCH] Support limiting the number of pixels per image

2016-12-10 Thread Reto Kromer
wm4 wrote: >Surely not really a worry for ffmpeg, since it's concerned >about video, and 16K video is still "a bit" in the future. If by "video" you mean "YUV", then may I disagree with you? We use daily FFmpeg, and mainly in a "film" ("RGB") context and often with a 5K or 6.6K horizontal resolut

Re: [FFmpeg-devel] [PATCH] Support limiting the number of pixels per image

2016-12-10 Thread wm4
On Fri, 9 Dec 2016 20:31:40 +0100 Michael Niedermayer wrote: > Adds av_image_check_size2() with max_pixels and pix_fmt parameters. > pix_fmt is unused and is added to avoid a 2nd API change later > > The old function uses AVOptions to obtain the max_pixels value to simplify > the transition. >

Re: [FFmpeg-devel] [PATCH] Support limiting the number of pixels per image

2016-12-10 Thread wm4
On Sat, 10 Dec 2016 11:51:04 +0100 Carl Eugen Hoyos wrote: > 2016-12-09 19:45 GMT+01:00 wm4 : > > > But users switching from FFmpeg to other software because > > it fails at the limit does happen. > > Could you elaborate? > Was there a bug report that we ignored? Reporting bugs to ffmpeg is

Re: [FFmpeg-devel] [PATCH 1/3] lavfi/af_atempo: add support for unknown channel layouts

2016-12-10 Thread Marton Balint
On Sun, 4 Dec 2016, Nicolas George wrote: Le quartidi 14 frimaire, an CCXXV, Marton Balint a écrit : Signed-off-by: Marton Balint --- libavfilter/af_atempo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) All three patches look good, thanks. Thanks, applied all three. Regards, M

Re: [FFmpeg-devel] [PATCHv2] avfilter/formats: allow unknown channel layouts by default

2016-12-10 Thread Marton Balint
On Fri, 9 Dec 2016, Nicolas George wrote: L'octidi 18 frimaire, an CCXXV, Marton Balint a écrit : Since the default in the libav fork is to only allow known layouts, making unknown layouts allowed by default here can be a security risk for filters directly merged from libav. However, usually i

Re: [FFmpeg-devel] [DECISION] Revoke the decision of dropping ffserver

2016-12-10 Thread wm4
On Sat, 10 Dec 2016 11:28:07 +0100 Carl Eugen Hoyos wrote: > 2016-12-08 15:53 GMT+01:00 wm4 : > > advanced hardware transcoding (I'm still waiting for related > > work to be merged from Libav). > > Didn't you tell the responsible developer not to send his patches > here implying you did not wa

Re: [FFmpeg-devel] [PATCH] Support limiting the number of pixels per image

2016-12-10 Thread Carl Eugen Hoyos
2016-12-09 19:45 GMT+01:00 wm4 : > But users switching from FFmpeg to other software because > it fails at the limit does happen. Could you elaborate? Was there a bug report that we ignored? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.

Re: [FFmpeg-devel] [DECISION] Revoke the decision of dropping ffserver

2016-12-10 Thread Carl Eugen Hoyos
2016-12-08 15:53 GMT+01:00 wm4 : > advanced hardware transcoding (I'm still waiting for related > work to be merged from Libav). Didn't you tell the responsible developer not to send his patches here implying you did not want them committed to FFmpeg? Carl Eugen __