Re: [FFmpeg-devel] [PATCH 2/2] aacenc: unmark the fast coder as experimental

2016-08-06 Thread Burt P.
"The ANMR coder requires -strict -2 and some may be removed in the future" should have "some" removed. On Sat, Aug 6, 2016 at 6:51 PM, Rostislav Pehlivanov wrote: > This version has had much testing so there's little point in keeping it > maked as experimental. > > Signed-off-by: Rostislav Pehliv

Re: [FFmpeg-devel] [PATCHv3 1/2] avformat: read id3v2 comment tags

2016-08-06 Thread Michael Niedermayer
On Fri, Aug 05, 2016 at 03:54:24PM -0700, kod...@gmail.com wrote: > From: Chris Moeller > > Let's try and get this right, one last time. No uninitialized variables, no > problems with unsynchronized or compressed frames, etc. > > --- > libavformat/id3v2.c | 42 +

Re: [FFmpeg-devel] [PATCH 1/2] aacenc: add a faster version of twoloop as the "fast" coder

2016-08-06 Thread Michael Niedermayer
On Sun, Aug 07, 2016 at 12:53:47AM +0100, Rostislav Pehlivanov wrote: > On 7 August 2016 at 00:51, Rostislav Pehlivanov wrote: > > > Does nothing fancy but still sounds very decent at 128kbps. > > Still room to improve by bringing in the low pass and PNS management > > from the main big twoloop w

Re: [FFmpeg-devel] libavcodec : add psd image file decoder

2016-08-06 Thread Michael Niedermayer
On Fri, Aug 05, 2016 at 01:05:38PM +0200, Martin Vignali wrote: [...] > > > > did you test this code with a fuzzer ? > > > > No i didn't know how to do that. there are many fuzzers, an older one is: zzuf -c -s0: -r0.01 ./ffmpeg -i someinputfile -f null - see the zzuf manual page for mor inform

Re: [FFmpeg-devel] [PATCH] [RFC] libavfilter HRTF/room acoustics filter [1/2]

2016-08-06 Thread Michael Niedermayer
On Tue, Aug 02, 2016 at 01:57:45PM -0700, Yue Shi Lai wrote: > On 08/02/2016 08:40 AM, Paul B Mahol wrote: > > On 8/2/16, Yue Shi Lai wrote: > >> - integrated matrix decoder (probably better suited as a separate filter) > > > > This one does what? > > This is an implementation of the steering or

[FFmpeg-devel] [PATCH 1/2] aacenc: add a faster version of twoloop as the "fast" coder

2016-08-06 Thread Rostislav Pehlivanov
Does nothing fancy but still sounds very decent at 128kbps. Still room to improve by bringing in the low pass and PNS management from the main big twoloop which should improve its quality but not sacrifice that much speed. Signed-off-by: Rostislav Pehlivanov --- libavcodec/aaccoder.c | 154 +

Re: [FFmpeg-devel] [PATCH 1/2] aacenc: add a faster version of twoloop as the "fast" coder

2016-08-06 Thread Rostislav Pehlivanov
On 7 August 2016 at 00:51, Rostislav Pehlivanov wrote: > Does nothing fancy but still sounds very decent at 128kbps. > Still room to improve by bringing in the low pass and PNS management > from the main big twoloop which should improve its quality but not > sacrifice that much speed. > > Signed-

[FFmpeg-devel] [PATCH 2/2] aacenc: unmark the fast coder as experimental

2016-08-06 Thread Rostislav Pehlivanov
This version has had much testing so there's little point in keeping it maked as experimental. Signed-off-by: Rostislav Pehlivanov --- libavcodec/aacenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/aacenc.c b/libavcodec/aacenc.c index 2653cef..1d80a67 1006

Re: [FFmpeg-devel] Change bitrate on-the-fly PoC (Patch)

2016-08-06 Thread Llorx
Hi Ronald, Well, this is a PoC. There are a lot of ways to implement this under a security context, so that's not a problem. For example, using ZeroMQ as Bodecs Bela says in the other thread, feature already implemented in ffmpeg as you can see here: https://www.ffmpeg.org/ffmpeg-all.html#zmq_002c

Re: [FFmpeg-devel] Change bitrate on-the-fly PoC (Patch)

2016-08-06 Thread Ronald S. Bultje
Hi, On Sat, Aug 6, 2016 at 9:00 AM, Llorx wrote: > Hi, > > Some days ago I started a thread here: > http://ffmpeg.org/pipermail/ffmpeg-devel/2016-August/197306.html > > Starting a new thread now because I lost my main thread mail and don't know > how to "reply" without having it in my inbox :-(

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: implement floating point decoding

2016-08-06 Thread Thilo Borgmann
Am 06.08.16 um 17:26 schrieb Umair Khan: > On Fri, Aug 5, 2016 at 9:27 PM, Carl Eugen Hoyos wrote: >> Hi! >> >> 2016-08-05 16:57 GMT+02:00 Umair Khan : >>> Updated patch attached. >> >> The Changelog hunk of your patch indicates that the patch should be split. >> (Or the change to Changelog could

Re: [FFmpeg-devel] [PATCH 1/2] af_hdcd: convert AVOptions from INT to BOOL

2016-08-06 Thread Burt P.
applied thx :) On Fri, Aug 5, 2016 at 4:54 PM, Burt P wrote: > As suggested by Timothy Gu. > > Signed-off-by: Burt P > --- > libavfilter/af_hdcd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavfilter/af_hdcd.c b/libavfilter/af_hdcd.c > index ef3c369..610dd

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: implement floating point decoding

2016-08-06 Thread Umair Khan
On Fri, Aug 5, 2016 at 9:27 PM, Carl Eugen Hoyos wrote: > Hi! > > 2016-08-05 16:57 GMT+02:00 Umair Khan : >> Updated patch attached. > > The Changelog hunk of your patch indicates that the patch should be split. > (Or the change to Changelog could be wrong.) I don't know. I can do it if the other

Re: [FFmpeg-devel] [PATCH] avfilter: add crystalizer filter.

2016-08-06 Thread Paul B Mahol
On 8/6/16, Остросаблин Виталий wrote: > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > Going to apply improved version of this soon. ___ ffmpeg-de

Re: [FFmpeg-devel] [PATCH 2/2] [RFC] avutil/version: Improve lib versioning sheme for release branches with the next major release

2016-08-06 Thread Moritz Barsnick
On Sat, Aug 06, 2016 at 12:52:54 +0200, Michael Niedermayer wrote: > + * Prior FFmpeg 3.2 point releases did not change any lib version number to ^ Prior to > + * a seperate MAJOR.MINOR that is not used on the master development branch ^ separate > + * that is if we branch a release

Re: [FFmpeg-devel] [PATCH] avfilter: add crystalizer filter.

2016-08-06 Thread Moritz Barsnick
On Sat, Aug 06, 2016 at 11:05:29 +0300, Остросаблин Виталий wrote: > +The filter accepts the following option: ^ options > +Sets the intensity of effect (default: 2.0). Must be in range between 0.0 ^ of the effect ^ ran

[FFmpeg-devel] Change bitrate on-the-fly PoC (Patch)

2016-08-06 Thread Llorx
Hi, Some days ago I started a thread here: http://ffmpeg.org/pipermail/ffmpeg-devel/2016-August/197306.html Starting a new thread now because I lost my main thread mail and don't know how to "reply" without having it in my inbox :-( ffmpeg has almost on-the-fly bitrate change control already bui

[FFmpeg-devel] [PATCHv3] af_hdcd: Add analyze mode (v3)

2016-08-06 Thread Burt P
A new mode, selected by filter option, to aid in analysis of HDCD encoded audio. In this mode the audio is replaced by a solid tone and the amplitude is adjusted to signal some specified aspect of the process. The output file can be loaded in an audio editor alongside the original, where the user c

Re: [FFmpeg-devel] [PATCH 1/2] af_hdcd: convert AVOptions from INT to BOOL

2016-08-06 Thread Michael Niedermayer
On Fri, Aug 05, 2016 at 04:54:43PM -0500, Burt P wrote: > As suggested by Timothy Gu. > > Signed-off-by: Burt P > --- > libavfilter/af_hdcd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Re: [FFmpeg-devel] [PATCHv2] af_hdcd: Add analyze mode

2016-08-06 Thread Michael Niedermayer
On Fri, Aug 05, 2016 at 05:23:04PM -0500, Burt P wrote: > A new mode, selected by filter option, to aid in analysis of HDCD > encoded audio. In this mode the audio is replaced by a solid tone and > the amplitude is adjusted to signal some specified aspect of the process. > The output file can be lo

[FFmpeg-devel] [PATCH 2/2] [RFC] avutil/version: Improve lib versioning sheme for release branches with the next major release

2016-08-06 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavutil/version.h | 9 + 1 file changed, 9 insertions(+) diff --git a/libavutil/version.h b/libavutil/version.h index 7692def..c846a4e 100644 --- a/libavutil/version.h +++ b/libavutil/version.h @@ -41,6 +41,15 @@ * and its value is reset to 100

[FFmpeg-devel] [PATCH 1/2] avutil/version: Mention similarities and differences to semver

2016-08-06 Thread Michael Niedermayer
QUESTION: is this the best place for this ? Signed-off-by: Michael Niedermayer --- libavutil/version.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavutil/version.h b/libavutil/version.h index b2dffb7..7692def 100644 --- a/libavutil/version.h +++ b/libavutil/version.h @@ -35,6 +3

Re: [FFmpeg-devel] [PATCH] lavf/mov: Add support for edit list parsing.

2016-08-06 Thread Michael Niedermayer
On Fri, Aug 05, 2016 at 05:18:40PM -0700, Sasi Inguva wrote: > Signed-off-by: Sasi Inguva > --- > libavcodec/avcodec.h | 6 + > libavcodec/utils.c | 6 + > libavformat/avformat.h | 3 + > libavformat/mov.c

Re: [FFmpeg-devel] [PATCH] lavf/mov: Add support for edit list parsing.

2016-08-06 Thread Michael Niedermayer
On Fri, Aug 05, 2016 at 05:18:40PM -0700, Sasi Inguva wrote: > Signed-off-by: Sasi Inguva > --- > libavcodec/avcodec.h | 6 + > libavcodec/utils.c | 6 + > libavformat/avformat.h | 3 + > libavformat/mov.c

[FFmpeg-devel] [PATCH] avfilter: add crystalizer filter.

2016-08-06 Thread Остросаблин Виталий
From 85ab9679dff777507b2b405af19dd930d6d1f75d Mon Sep 17 00:00:00 2001 From: Vitaly Ostrosablin Date: Sat, 6 Aug 2016 10:50:35 +0300 Subject: [PATCH] avfilter: add crystalizer filter. Signed-off-by: Vitaly Ostrosablin --- Changelog | 1 + doc/filters.texi