[FFmpeg-devel] [PATCH 10/10] libavcodec/ccaption_dec: extract ass time base into constant

From: Aman Gupta --- libavcodec/ccaption_dec.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 56b2b52..6dff761 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -30,6 +30,8 @@ #defin

[FFmpeg-devel] [PATCH 08/10] libavcodec/ccaption_dec.c: fix more whitespace

From: Aman Gupta --- libavcodec/ccaption_dec.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 423c576..3de16bf 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -220,7 +220,7 @@ st

[FFmpeg-devel] [PATCH 04/10] libavcodec/ccaption_dec: reap_screen after flipping on EOC

From: Aman Gupta --- libavcodec/ccaption_dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 9f17e77..5d4c568 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -399,9 +399,9 @@ static void h

[FFmpeg-devel] [PATCH 05/10] libavcodec/ccaption_dec: combine ROLLUP modes as they are identical

From: Aman Gupta --- libavcodec/ccaption_dec.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 5d4c568..424b434 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -37,9 +37,7

[FFmpeg-devel] [PATCH 03/10] libavcodec/ccaption_dec: add calculate_duration option

From: Aman Gupta new option defaults to true, to preserve existing behavior. by flipping the option to false, subtitle events are emitted as soon as they are received and have an infinite duration. this new mode is useful for realtime decoding of closed captions so they can be display along with

[FFmpeg-devel] [PATCH 06/10] libavcodec/ccaption_dec: flush screen buffer on seek

From: Aman Gupta --- libavcodec/ccaption_dec.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 424b434..423c576 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -196,6 +196,15 @@ static av_cold i

[FFmpeg-devel] [PATCH 09/10] libavcodec/ccaption_dec: default to simpler POPON mode

From: Aman Gupta the default value does not really have any effect in normal operation, as the mode command is repeated before every new caption. after seeking, it makes more sense to default to POPON since that is the more common mode. --- libavcodec/ccaption_dec.c | 5 ++--- 1 file changed, 2

[FFmpeg-devel] [PATCH 07/10] libavcodec/ass.c: increase hardcoded timestamp for infinite duration

From: Aman Gupta before this change, ffmpeg would sometimes generate invalid ASS events when dealing with mpegts streams that had a large start_time: Dialogue: 0,20:57:07.37,9:59:59.99,Default,,0,0,0,,(upbeat music playing) --- libavcodec/ass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[FFmpeg-devel] [PATCH 02/10] libavcodec/ccaption_dec: fix timestamps on generated subtitles by buffering after EOC/newline commands

From: Aman Gupta before: Dialogue: 0,0:00:00.03,0:00:00.67,Default,,0,0,0,,EVERYBODY, TONIGHT WE'LL COVER Dialogue: 0,0:00:00.67,0:00:02.30,Default,,0,0,0,,EVERYBODY, TONIGHT WE'LL COVER\NTHE NEWS WE MISSED OVER THE Dialogue: 0,0:00:02.30,0:00:03.57,Default,,0,0,0,,THE NEWS WE MISSED OVE

[FFmpeg-devel] [PATCH 01/10] libavcodec/ccaption_dec: fix whitespace

From: Aman Gupta --- libavcodec/ccaption_dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 34a7208..12e8f1d 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -159,7 +159,7 @@ typedef struc

Re: [FFmpeg-devel] [PATCH 2/3] libavcodec/ccaption_dec: clean up and standardize white space

On Tue, Jan 5, 2016 at 6:24 PM, Michael Niedermayer wrote: > On Tue, Jan 05, 2016 at 09:34:35PM +0100, Clément Bœsch wrote: > > On Mon, Jan 04, 2016 at 07:28:02PM -0800, Aman Gupta wrote: > > > From: Aman Gupta > > > > > > --- > > > libavcodec/ccaption_dec.c | 98 > ++---

Re: [FFmpeg-devel] [PATCH] libavcodec/ccaption_dec: remove unnecessary buffering of closed caption packets

On Tue, Jan 5, 2016 at 12:25 PM, Clément Bœsch wrote: > On Sun, Jan 03, 2016 at 01:07:15PM +0100, Clément Bœsch wrote: > [...] > > This indeed LGTM, but I'm not the maintainer. > > > > OK I finally understood why it's done that way: validate_cc_data_pair() > alters the pkt data, but the decoder i

Re: [FFmpeg-devel] [PATCHv2] avformat/mp3dec, rmdec: check return value of ffio_ensure_seekback

On Tue, Jan 5, 2016 at 4:57 PM, Michael Niedermayer wrote: > On Tue, Jan 05, 2016 at 01:57:09PM -0800, Ganesh Ajjanagadde wrote: >> On Tue, Jan 5, 2016 at 11:01 AM, wm4 wrote: >> > On Tue, 5 Jan 2016 08:32:02 -0800 >> > Ganesh Ajjanagadde wrote: >> > >> >> On Tue, Jan 5, 2016 at 5:29 AM, wm4 wr

Re: [FFmpeg-devel] [PATCHv2] lavc/cbrt_tablegen: speed up tablegen

On Tue, Jan 5, 2016 at 10:46 AM, Ganesh Ajjanagadde wrote: > On Tue, Jan 5, 2016 at 10:10 AM, Daniel Serpell wrote: >> Hi!, >> >> El Tue, Jan 05, 2016 at 08:08:35AM -0800, Ganesh Ajjanagadde escribio: >>> On Tue, Jan 5, 2016 at 7:44 AM, Daniel Serpell wrote: >>> > Hi!, >>> > >>> > El Mon, Jan 04

[FFmpeg-devel] [PATCH] lavf/matroskadec: SMI to SVQ3

At least in this case, MPlayer seems to look at the codec tag rather than the codec ID in order to determine the codec. Therefore, the 'fourcc' variable needs to be set to 'SVQ3' as well, which is later copied to st->codec->codec_tag in matroskadec.c. Mats -- Mats Peterson http://matsp888.no-ip.

[FFmpeg-devel] [PATCH v5] lavf/matroskadec: A_QUICKTIME and AV_CODEC_ID_NONE

In many older QuickTime files, the audio format, or "fourcc", is 0x (AV_CODEC_ID_NONE). The QuickTime File Format Specification states the following regarding this situation: "This format descriptor should not be used, but may be found in some files. Samples are assumed to be stored in ei

Re: [FFmpeg-devel] [PATCH] lavfi/af_compensationdelay: replace pow(x, 0.5) by sqrt(x)

On Tue, Jan 5, 2016 at 2:40 AM, Paul B Mahol wrote: > On 1/5/16, Ganesh Ajjanagadde wrote: >> sqrt is faster, and is sometimes more accurate depending on the libm. >> >> Signed-off-by: Ganesh Ajjanagadde >> --- >> libavfilter/af_compensationdelay.c | 2 +- >> 1 file changed, 1 insertion(+), 1 d

Re: [FFmpeg-devel] [PATCH] ffmpeg: check return value of avio_closep for progress report

On Tue, Jan 5, 2016 at 9:24 AM, James Almer wrote: > On 1/5/2016 12:39 AM, Ganesh Ajjanagadde wrote: >> avio_closep is not guaranteed to succeed, and its return value can >> contain information regarding failure of preceding writes and silent >> loss of data (man 2 close, man fclose). Users should

Re: [FFmpeg-devel] [PATCH] decklink: support all valid numbers of audio channels

On Tue, Jan 05, 2016 at 04:38:06PM +0100, Matthias Hunstock wrote: > Am 20.12.2015 um 12:57 schrieb Matthias Hunstock: > > As it is already written in the documentation, BMD DeckLink cards > > are capable of capturing 2, 8 or 16 audio channels (for SDI Inputs). > > Currently the value is hardcoded

Re: [FFmpeg-devel] [PATCH] ffmpeg: replace log2 by faster variant

On Tue, Jan 5, 2016 at 6:44 PM, Michael Niedermayer wrote: > On Mon, Jan 04, 2016 at 05:38:46PM -0800, Ganesh Ajjanagadde wrote: >> On Sat, Jan 2, 2016 at 7:59 AM, Ganesh Ajjanagadde wrote: >> > On Sat, Jan 2, 2016 at 6:24 AM, Michael Niedermayer >> > wrote: >> >> On Fri, Jan 01, 2016 at 05:55:3

Re: [FFmpeg-devel] [RFC] avcodec: Add native DCA decoder based on libdcadec.

On 1/5/2016 11:51 PM, Michael Niedermayer wrote: > On Tue, Jan 05, 2016 at 11:44:04PM -0300, James Almer wrote: >> On 1/5/2016 11:35 PM, Michael Niedermayer wrote: >>> On Tue, Jan 05, 2016 at 11:27:25PM -0300, James Almer wrote: On 1/5/2016 11:21 PM, Michael Niedermayer wrote: > [...] >>> >>>

Re: [FFmpeg-devel] [RFC] avcodec: Add native DCA decoder based on libdcadec.

On Tue, Jan 05, 2016 at 11:44:04PM -0300, James Almer wrote: > On 1/5/2016 11:35 PM, Michael Niedermayer wrote: > > On Tue, Jan 05, 2016 at 11:27:25PM -0300, James Almer wrote: > >> On 1/5/2016 11:21 PM, Michael Niedermayer wrote: [...] > > > > > >> > >> Ideally, once this decoder is committed re

Re: [FFmpeg-devel] [PATCH] ffmpeg: replace log2 by faster variant

On Mon, Jan 04, 2016 at 05:38:46PM -0800, Ganesh Ajjanagadde wrote: > On Sat, Jan 2, 2016 at 7:59 AM, Ganesh Ajjanagadde wrote: > > On Sat, Jan 2, 2016 at 6:24 AM, Michael Niedermayer > > wrote: > >> On Fri, Jan 01, 2016 at 05:55:31PM -0800, Ganesh Ajjanagadde wrote: > >>> On Wed, Dec 30, 2015 at

Re: [FFmpeg-devel] [RFC] avcodec: Add native DCA decoder based on libdcadec.

On 1/5/2016 11:35 PM, Michael Niedermayer wrote: > On Tue, Jan 05, 2016 at 11:27:25PM -0300, James Almer wrote: >> On 1/5/2016 11:21 PM, Michael Niedermayer wrote: >>> On Tue, Jan 05, 2016 at 11:38:00PM +0300, foo86 wrote: On Tue, Jan 05, 2016 at 08:45:22PM +0100, Andreas Cadhalpun wrote:

Re: [FFmpeg-devel] [RFC] avcodec: Add native DCA decoder based on libdcadec.

On Tue, Jan 05, 2016 at 11:27:25PM -0300, James Almer wrote: > On 1/5/2016 11:21 PM, Michael Niedermayer wrote: > > On Tue, Jan 05, 2016 at 11:38:00PM +0300, foo86 wrote: > >> On Tue, Jan 05, 2016 at 08:45:22PM +0100, Andreas Cadhalpun wrote: > >>> On 03.01.2016 18:49, foo86 wrote: > +// 5.3.1

Re: [FFmpeg-devel] [RFC] avcodec: Add native DCA decoder based on libdcadec.

On 1/5/2016 11:21 PM, Michael Niedermayer wrote: > On Tue, Jan 05, 2016 at 11:38:00PM +0300, foo86 wrote: >> On Tue, Jan 05, 2016 at 08:45:22PM +0100, Andreas Cadhalpun wrote: >>> On 03.01.2016 18:49, foo86 wrote: +// 5.3.1 - Bit stream header +static int parse_frame_header(DCA2CoreDecode

Re: [FFmpeg-devel] [PATCH 2/3] libavcodec/ccaption_dec: clean up and standardize white space

On Tue, Jan 05, 2016 at 09:34:35PM +0100, Clément Bœsch wrote: > On Mon, Jan 04, 2016 at 07:28:02PM -0800, Aman Gupta wrote: > > From: Aman Gupta > > > > --- > > libavcodec/ccaption_dec.c | 98 > > ++- > > 1 file changed, 45 insertions(+), 53 deletion

Re: [FFmpeg-devel] [RFC] avcodec: Add native DCA decoder based on libdcadec.

On Tue, Jan 05, 2016 at 11:38:00PM +0300, foo86 wrote: > On Tue, Jan 05, 2016 at 08:45:22PM +0100, Andreas Cadhalpun wrote: > > On 03.01.2016 18:49, foo86 wrote: > > > +// 5.3.1 - Bit stream header > > > +static int parse_frame_header(DCA2CoreDecoder *s) > > > +{ > > [...] > > > +// Source PCM

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/nvenc: Include NVENC SDK header

On 12/10/15, Philip Langdale wrote: > On 2015-12-09 21:34, wm4 wrote: >> On Mon, 7 Dec 2015 19:34:20 +0100 >> Timo Rothenpieler wrote: >> >>> > I don't remember if this was discussed when avisynth and other headers >>> > where included, but what's the advantage of directly including the >>> > hea

Re: [FFmpeg-devel] [PATCHv2] avformat/mp3dec, rmdec: check return value of ffio_ensure_seekback

On Tue, Jan 05, 2016 at 01:57:09PM -0800, Ganesh Ajjanagadde wrote: > On Tue, Jan 5, 2016 at 11:01 AM, wm4 wrote: > > On Tue, 5 Jan 2016 08:32:02 -0800 > > Ganesh Ajjanagadde wrote: > > > >> On Tue, Jan 5, 2016 at 5:29 AM, wm4 wrote: > >> > On Mon, 4 Jan 2016 17:50:01 -0800 > >> > Ganesh Ajjana

Re: [FFmpeg-devel] [PATCH] lavc/ccaption_dec: fix always true condition

On Tue, Jan 05, 2016 at 09:54:54PM +0100, Clément Bœsch wrote: > No idea why this wasn't ever detected by a static analyzer. > --- > libavcodec/ccaption_dec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c > index 4e4

Re: [FFmpeg-devel] [RFC] avcodec: Add native DCA decoder based on libdcadec.

On Tue, Jan 5, 2016 at 3:42 PM, Hendrik Leppkes wrote: > On Wed, Jan 6, 2016 at 12:40 AM, Ganesh Ajjanagadde wrote: [...] >> For now, I definitely think we should replace our decoder. >> Just a clarification: in the long run, isn't it a good idea to get >> this into the repo and not use an extern

Re: [FFmpeg-devel] [RFC] avcodec: Add native DCA decoder based on libdcadec.

On Wed, Jan 6, 2016 at 12:40 AM, Ganesh Ajjanagadde wrote: > On Tue, Jan 5, 2016 at 3:28 PM, Hendrik Leppkes wrote: >> On Tue, Jan 5, 2016 at 10:46 PM, Andreas Cadhalpun >> wrote: >>> On 05.01.2016 21:38, foo86 wrote: On Tue, Jan 05, 2016 at 08:45:22PM +0100, Andreas Cadhalpun wrote: >

Re: [FFmpeg-devel] [RFC] avcodec: Add native DCA decoder based on libdcadec.

On Tue, Jan 5, 2016 at 3:28 PM, Hendrik Leppkes wrote: > On Tue, Jan 5, 2016 at 10:46 PM, Andreas Cadhalpun > wrote: >> On 05.01.2016 21:38, foo86 wrote: >>> On Tue, Jan 05, 2016 at 08:45:22PM +0100, Andreas Cadhalpun wrote: On 03.01.2016 18:49, foo86 wrote: > +// 5.3.1 - Bit stream head

[FFmpeg-devel] [PATCH 6/6] libavcodec/ccaption_dec: prevent debug logging about tab offset commands

From: Aman Gupta this can be filled in if/when the decoder adds positioning support --- libavcodec/ccaption_dec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index fbf23d0..34a7208 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavc

[FFmpeg-devel] [PATCH 3/6] libavcodec/ccaption_dec: implement "erase non displayed memory"

From: Aman Gupta --- libavcodec/ccaption_dec.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index c5aace7..6f1e70d 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -395,12 +395,9

[FFmpeg-devel] [PATCH 4/6] libavcodec/ccaption_dec: reap_screen is not necessary when clearing screen or buffer

From: Aman Gupta --- libavcodec/ccaption_dec.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 6f1e70d..8373a0c 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -395,17 +395,15 @@

[FFmpeg-devel] [PATCH 5/6] libavcodec/ccaption_dec: clean up whitespace

From: Aman Gupta --- libavcodec/ccaption_dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 8373a0c..fbf23d0 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -506,7 +506,7 @@ static void p

[FFmpeg-devel] [PATCH 2/6] libavcodec/ccaption_dec: reap_screen() is responsible for clearing output buffer and signaling screen_changed

From: Aman Gupta --- libavcodec/ccaption_dec.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index bc26e4e..c5aace7 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -316,6 +316,7 @@ st

[FFmpeg-devel] [PATCH 1/6] libavcodec/ccaption_dec: remove unused return value from internal functions

From: Aman Gupta --- libavcodec/ccaption_dec.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 788e96a..bc26e4e 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -395,24 +

Re: [FFmpeg-devel] [RFC] avcodec: Add native DCA decoder based on libdcadec.

On Tue, Jan 5, 2016 at 10:46 PM, Andreas Cadhalpun wrote: > On 05.01.2016 21:38, foo86 wrote: >> On Tue, Jan 05, 2016 at 08:45:22PM +0100, Andreas Cadhalpun wrote: >>> On 03.01.2016 18:49, foo86 wrote: +// 5.3.1 - Bit stream header +static int parse_frame_header(DCA2CoreDecoder *s)

Re: [FFmpeg-devel] [RESEND][PATCH] Fix buffer allocation in pad filter

Sure; no-copy padding was broken for some scenarios (namely, left-padding when target height divides evenly by 32). Lets say I want to use following filter string: "scale=720x576, pad=880:576:80:0" (scale to 720x576 and add some black bands on the sides). Pad should be able to allocate buffer for s

Re: [FFmpeg-devel] [RESEND][PATCH] Fix buffer allocation in pad filter

On 1/5/16, Andrey Turkin wrote: > > One extra line must be allocated when adding left padding to make sure > that last line in every plane fits in the allocated buffer fully > --- > libavfilter/vf_pad.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Do you have example this patch fi

Re: [FFmpeg-devel] [PATCH] avfilter/formats: fix leak of formats on error

On Tue, Jan 5, 2016 at 1:54 PM, Paul B Mahol wrote: > On 1/5/16, Ganesh Ajjanagadde wrote: >> On Tue, Jan 5, 2016 at 12:11 PM, Paul B Mahol wrote: >>> Signed-off-by: Paul B Mahol >>> --- >>> libavfilter/formats.c | 4 >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/libavfilter/fo

Re: [FFmpeg-devel] [PATCHv2] avformat/mp3dec, rmdec: check return value of ffio_ensure_seekback

On Tue, Jan 5, 2016 at 11:01 AM, wm4 wrote: > On Tue, 5 Jan 2016 08:32:02 -0800 > Ganesh Ajjanagadde wrote: > >> On Tue, Jan 5, 2016 at 5:29 AM, wm4 wrote: >> > On Mon, 4 Jan 2016 17:50:01 -0800 >> > Ganesh Ajjanagadde wrote: >> > >> >> ffio_ensure_seekback can fail due to e.g ENOMEM. This ret

Re: [FFmpeg-devel] [PATCH] avfilter/formats: fix leak of formats on error

On 1/5/16, Ganesh Ajjanagadde wrote: > On Tue, Jan 5, 2016 at 12:11 PM, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> libavfilter/formats.c | 4 >> 1 file changed, 4 insertions(+) >> >> diff --git a/libavfilter/formats.c b/libavfilter/formats.c >> index a2b19e7..f12dcf4 1006

Re: [FFmpeg-devel] [RFC] avcodec: Add native DCA decoder based on libdcadec.

On 05.01.2016 21:38, foo86 wrote: > On Tue, Jan 05, 2016 at 08:45:22PM +0100, Andreas Cadhalpun wrote: >> On 03.01.2016 18:49, foo86 wrote: >>> +// 5.3.1 - Bit stream header >>> +static int parse_frame_header(DCA2CoreDecoder *s) >>> +{ >> [...] >>> +// Source PCM resolution >>> +s->source_p

Re: [FFmpeg-devel] [PATCH] parser: error out if the codec doesn't match

On 05.01.2016 21:40, Michael Niedermayer wrote: > On Tue, Jan 05, 2016 at 12:48:10PM +0100, Andreas Cadhalpun wrote: >> parser.c |7 +++ >> 1 file changed, 7 insertions(+) >> 1a29aebd63e39c82039cddb1239de415b1da43df >> 0001-parser-add-av_assert1-to-make-sure-the-codec-matches.patch >> Fr

Re: [FFmpeg-devel] [PATCH] avfilter/formats: fix leak of formats on error

On Tue, Jan 5, 2016 at 12:11 PM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/formats.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/libavfilter/formats.c b/libavfilter/formats.c > index a2b19e7..f12dcf4 100644 > --- a/libavfilter/formats.c > +++ b/libavf

Re: [FFmpeg-devel] [PATCH] avpacket: fix size check in packet_alloc

On 05.01.2016 21:39, Michael Niedermayer wrote: > On Tue, Jan 05, 2016 at 01:05:50PM +0100, Andreas Cadhalpun wrote: >> The previous check only caught sizes from -AV_INPUT_BUFFER_PADDING_SIZE >> to -1. >> >> This fixes ubsan runtime error: signed integer overflow: 2147483647 + 32 >> cannot be repre

Re: [FFmpeg-devel] [PATCH 3/3] libavcodec/ccaption_dec: rewrite packet handler as case statement; remove COR3 macro

On Tue, Jan 05, 2016 at 09:35:41PM +0100, Clément Bœsch wrote: > On Mon, Jan 04, 2016 at 07:28:03PM -0800, Aman Gupta wrote: > > From: Aman Gupta [...] > > } else if ( (hi == 0x10 && (lo >= 0x40 || lo <= 0x5f)) || > >( (hi >= 0x11 && hi <= 0x17) && (lo >= 0x40 && lo <= 0x7f) )

Re: [FFmpeg-devel] [WIP] SDL2 in ffplay

On Tue, Jan 05, 2016 at 21:49:58 +0100, wm4 wrote: > AFAIK SDL 1 is unmaintained now. I'm not sure why anyone would > explicitly want SDL 1 over 2. And trying to support both would be an > unholy mess. For the output device, sdl2 could be created as a copy of sdl (so that git can follow), then mod

[FFmpeg-devel] [RESEND][PATCH] Fix buffer allocation in pad filter

One extra line must be allocated when adding left padding to make sure that last line in every plane fits in the allocated buffer fully --- libavfilter/vf_pad.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_pad.c b/libavfilter/vf_pad.c index d94ced1..555b318 1

[FFmpeg-devel] [PATCH] lavc/ccaption_dec: fix always true condition

No idea why this wasn't ever detected by a static analyzer. --- libavcodec/ccaption_dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 4e478e0..94771d5 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaptio

Re: [FFmpeg-devel] [WIP] SDL2 in ffplay

On Tue, 5 Jan 2016 21:03:14 +0100 (CET) Marton Balint wrote: > On Tue, 5 Jan 2016, Roger Pack wrote: > > > On 1/2/16, Marton Balint wrote: > >> Hi, > >> > >> To anybody who is interested, I have pushed my experimental SDL2 branch of > >> ffplay to github. (https://github.com/cus/ffplay.git) >

Re: [FFmpeg-devel] [PATCH] parser: error out if the codec doesn't match

On Tue, Jan 05, 2016 at 12:48:10PM +0100, Andreas Cadhalpun wrote: > On 05.01.2016 12:18, Michael Niedermayer wrote: > > On Tue, Jan 05, 2016 at 12:02:29PM +0100, Andreas Cadhalpun wrote: > >> That wouldn't work, as the codec id wasn't changed in force_codec_ids, > >> but in the API using program.

Re: [FFmpeg-devel] [PATCH] avpacket: fix size check in packet_alloc

On Tue, Jan 05, 2016 at 01:05:50PM +0100, Andreas Cadhalpun wrote: > The previous check only caught sizes from -AV_INPUT_BUFFER_PADDING_SIZE > to -1. > > This fixes ubsan runtime error: signed integer overflow: 2147483647 + 32 > cannot be represented in type 'int' > > Signed-off-by: Andreas Cadha

Re: [FFmpeg-devel] [PATCH]lavc/opus: Use original sample rate for decoding

Hendrik Leppkes gmail.com> writes: > > Attached patch intends to match what opusdec does, > > sorry if I miss something. > I dont think its as simple as this. Only the SILK > parts of the audio are automatically resampled, the > CELT parts are always decoded to 48kHz. Just changing > the sam

Re: [FFmpeg-devel] [RFC] avcodec: Add native DCA decoder based on libdcadec.

On Tue, Jan 05, 2016 at 08:45:22PM +0100, Andreas Cadhalpun wrote: > On 03.01.2016 18:49, foo86 wrote: > > +// 5.3.1 - Bit stream header > > +static int parse_frame_header(DCA2CoreDecoder *s) > > +{ > [...] > > +// Source PCM resolution > > +s->source_pcm_res = ff_dca_bits_per_sample[pcmr_i

Re: [FFmpeg-devel] [RFC][PATCH]lavf/matroskaenc: Assume 48kHz sample rate for Opus initial padding.

Michael Niedermayer niedermayer.cc> writes: > > Attached patch may fix this issue reported for Firefox: > > https://bugzilla.mozilla.org/show_bug.cgi?id=1227153 > > Completely untested but I believe the patch matches a > > comment in libopusenc.c line 90. > please bump the libavformat version w

Re: [FFmpeg-devel] [PATCH] Add frame side data when SEI green metadata are detected

On Tue, Jan 05, 2016 at 10:19:28AM +, Nicolas Derouineau wrote: > >this should be in a seperate patch and libavutil/version.h should have > >its minor version bumped > > Ok, so I'm going to do two separate patch (commit ?) for libavformat and for > libavutil. yes, please do > Where should

Re: [FFmpeg-devel] [PATCH] avfilter: add ahistogram multimedia filter

On Tue, Jan 05, 2016 at 21:19:12 +0100, Paul B Mahol wrote: > +It accepts the following values: > +@table @samp > +@item replace > +logarithmic ^^^ This description is a copy/paste error. > +@item pheight > +Set histogram percentage of window height. [...] > +{ "pheight", "set histogram pe

Re: [FFmpeg-devel] [PATCH 3/3] libavcodec/ccaption_dec: rewrite packet handler as case statement; remove COR3 macro

On Mon, Jan 04, 2016 at 07:28:03PM -0800, Aman Gupta wrote: > From: Aman Gupta > > --- > libavcodec/ccaption_dec.c | 92 > +++ > 1 file changed, 53 insertions(+), 39 deletions(-) > > diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c

Re: [FFmpeg-devel] [WIP] SDL2 in ffplay

On 05.01.2016 21:03, Marton Balint wrote: > On Tue, 5 Jan 2016, Roger Pack wrote: >> Perhaps you could update the "sdl out" filter as well? :) > > I guess that shouldn't be too hard, but is there anybody who thinks that we > should > NOT drop SDL1 support? Because if there is, then I am less moti

Re: [FFmpeg-devel] [PATCH 2/3] libavcodec/ccaption_dec: clean up and standardize white space

On Mon, Jan 04, 2016 at 07:28:02PM -0800, Aman Gupta wrote: > From: Aman Gupta > > --- > libavcodec/ccaption_dec.c | 98 > ++- > 1 file changed, 45 insertions(+), 53 deletions(-) > There are much more garbage formatting in that file (typically at th

Re: [FFmpeg-devel] [PATCH] libavcodec/ccaption_dec: remove unnecessary buffering of closed caption packets

On Sun, Jan 03, 2016 at 01:07:15PM +0100, Clément Bœsch wrote: [...] > This indeed LGTM, but I'm not the maintainer. > OK I finally understood why it's done that way: validate_cc_data_pair() alters the pkt data, but the decoder isn't supposed to do that. So this patch is actually incorrect in th

[FFmpeg-devel] [PATCH] avfilter: add ahistogram multimedia filter

Signed-off-by: Paul B Mahol --- doc/filters.texi | 86 ++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/avf_ahistogram.c | 391 +++ 4 files changed, 479 insertions(+) create mode 100644 libavfi

[FFmpeg-devel] [PATCH] avfilter/formats: fix leak of formats on error

Signed-off-by: Paul B Mahol --- libavfilter/formats.c | 4 1 file changed, 4 insertions(+) diff --git a/libavfilter/formats.c b/libavfilter/formats.c index a2b19e7..f12dcf4 100644 --- a/libavfilter/formats.c +++ b/libavfilter/formats.c @@ -518,6 +518,8 @@ void ff_formats_changeref(AVFilterF

Re: [FFmpeg-devel] [WIP] SDL2 in ffplay

On Tue, 5 Jan 2016, Roger Pack wrote: On 1/2/16, Marton Balint wrote: Hi, To anybody who is interested, I have pushed my experimental SDL2 branch of ffplay to github. (https://github.com/cus/ffplay.git) SDL2 completely replaced SDL_Overlay with 3D textures, so with SDL2 it is possible to: -

Re: [FFmpeg-devel] [RFC] avcodec: Add native DCA decoder based on libdcadec.

On 03.01.2016 18:49, foo86 wrote: > +// 5.3.1 - Bit stream header > +static int parse_frame_header(DCA2CoreDecoder *s) > +{ [...] > +// Source PCM resolution > +s->source_pcm_res = ff_dca_bits_per_sample[pcmr_index = get_bits(&s->gb, > 3)]; This can cause an out-of-bounds read if get_bits

Re: [FFmpeg-devel] [PATCH] avfilter/formats: fix leak of channel_layouts on error

On Tue, Jan 5, 2016 at 11:16 AM, Paul B Mahol wrote: > On 1/5/16, Ganesh Ajjanagadde wrote: >> On Tue, Jan 5, 2016 at 11:06 AM, Paul B Mahol wrote: >>> On 1/2/16, Ganesh Ajjanagadde wrote: >>> [...] Thanks a lot for addressing this. But a client may not necessarily attempt initia

Re: [FFmpeg-devel] [PATCH] avfilter/formats: fix leak of channel_layouts on error

On 1/5/16, Ganesh Ajjanagadde wrote: > On Tue, Jan 5, 2016 at 11:06 AM, Paul B Mahol wrote: >> On 1/2/16, Ganesh Ajjanagadde wrote: >> [...] >>> >>> Thanks a lot for addressing this. But a client may not necessarily >>> attempt initialization of the channel layouts first, so instead of >>> do_no

Re: [FFmpeg-devel] [PATCH] avfilter/formats: fix leak of channel_layouts on error

On Tue, Jan 5, 2016 at 11:06 AM, Paul B Mahol wrote: > On 1/2/16, Ganesh Ajjanagadde wrote: > [...] >> >> Thanks a lot for addressing this. But a client may not necessarily >> attempt initialization of the channel layouts first, so instead of >> do_nothing calls, shouldn't there be an equivalent

Re: [FFmpeg-devel] [PATCH] avfilter/formats: fix leak of channel_layouts on error

On 1/2/16, Ganesh Ajjanagadde wrote: [...] > > Thanks a lot for addressing this. But a client may not necessarily > attempt initialization of the channel layouts first, so instead of > do_nothing calls, shouldn't there be an equivalent for > AVFilterFormats*? > > Of course, the commit message will

Re: [FFmpeg-devel] [PATCHv2] avformat/mp3dec, rmdec: check return value of ffio_ensure_seekback

On Tue, 5 Jan 2016 08:32:02 -0800 Ganesh Ajjanagadde wrote: > On Tue, Jan 5, 2016 at 5:29 AM, wm4 wrote: > > On Mon, 4 Jan 2016 17:50:01 -0800 > > Ganesh Ajjanagadde wrote: > > > >> ffio_ensure_seekback can fail due to e.g ENOMEM. This return value is > >> checked here and a diagnostic is lo

Re: [FFmpeg-devel] [PATCHv2] lavc/cbrt_tablegen: speed up tablegen

On Tue, Jan 5, 2016 at 10:10 AM, Daniel Serpell wrote: > Hi!, > > El Tue, Jan 05, 2016 at 08:08:35AM -0800, Ganesh Ajjanagadde escribio: >> On Tue, Jan 5, 2016 at 7:44 AM, Daniel Serpell wrote: >> > Hi!, >> > >> > El Mon, Jan 04, 2016 at 06:33:59PM -0800, Ganesh Ajjanagadde escribio: >> >> This e

Re: [FFmpeg-devel] [PATCHv2] lavc/cbrt_tablegen: speed up tablegen

Hi!, El Tue, Jan 05, 2016 at 08:08:35AM -0800, Ganesh Ajjanagadde escribio: > On Tue, Jan 5, 2016 at 7:44 AM, Daniel Serpell wrote: > > Hi!, > > > > El Mon, Jan 04, 2016 at 06:33:59PM -0800, Ganesh Ajjanagadde escribio: > >> This exploits an approach based on the sieve of Eratosthenes, a popular

Re: [FFmpeg-devel] [PATCH] ffmpeg: check return value of avio_closep for progress report

On 1/5/2016 12:39 AM, Ganesh Ajjanagadde wrote: > avio_closep is not guaranteed to succeed, and its return value can > contain information regarding failure of preceding writes and silent > loss of data (man 2 close, man fclose). Users should know when the > progress was not successfully logged, an

Re: [FFmpeg-devel] [PATCH] ffmpeg: check return value of avio_closep for progress report

On Mon, Jan 04, 2016 at 07:39:42PM -0800, Ganesh Ajjanagadde wrote: > avio_closep is not guaranteed to succeed, and its return value can > contain information regarding failure of preceding writes and silent > loss of data (man 2 close, man fclose). Users should know when the > progress was not suc

Re: [FFmpeg-devel] [PATCH 1/3] libavcodec/ccaption_dec: remove unnecessary include

On Mon, Jan 04, 2016 at 07:28:01PM -0800, Aman Gupta wrote: > From: Aman Gupta > > --- > libavcodec/ccaption_dec.c | 1 - > 1 file changed, 1 deletion(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB In a rich man's house there is no place t

Re: [FFmpeg-devel] [PATCHv2] avformat/mp3dec, rmdec: check return value of ffio_ensure_seekback

On Tue, Jan 5, 2016 at 5:29 AM, wm4 wrote: > On Mon, 4 Jan 2016 17:50:01 -0800 > Ganesh Ajjanagadde wrote: > >> ffio_ensure_seekback can fail due to e.g ENOMEM. This return value is >> checked here and a diagnostic is logged. >> >> All usage of ffio_ensure_seekback in the codebase now has the re

Re: [FFmpeg-devel] [PATCHv2] lavc/cbrt_tablegen: speed up tablegen

On Tue, Jan 5, 2016 at 8:08 AM, Ganesh Ajjanagadde wrote: > On Tue, Jan 5, 2016 at 7:44 AM, Daniel Serpell wrote: >> Hi!, >> >> El Mon, Jan 04, 2016 at 06:33:59PM -0800, Ganesh Ajjanagadde escribio: >>> This exploits an approach based on the sieve of Eratosthenes, a popular >>> method for generat

Re: [FFmpeg-devel] [PATCHv2] lavc/cbrt_tablegen: speed up tablegen

On Tue, Jan 5, 2016 at 7:44 AM, Daniel Serpell wrote: > Hi!, > > El Mon, Jan 04, 2016 at 06:33:59PM -0800, Ganesh Ajjanagadde escribio: >> This exploits an approach based on the sieve of Eratosthenes, a popular >> method for generating prime numbers. >> >> Tables are identical to previous ones. >>

Re: [FFmpeg-devel] [PATCH]lavc/opus: Use original sample rate for decoding

Am 05.01.2016 16:07 schrieb "Carl Eugen Hoyos" : > > Hi! > > Attached patch intends to match what opusdec does, sorry if I miss something. > > Please review, Carl Eugen I dont think its as simple as this. Only the SILK parts of the audio are automatically resampled, the CELT parts are always decod

Re: [FFmpeg-devel] [PATCH] decklink: support all valid numbers of audio channels

> On Jan 5, 2016, at 10:38 AM, Matthias Hunstock wrote: > > Am 20.12.2015 um 12:57 schrieb Matthias Hunstock: >> As it is already written in the documentation, BMD DeckLink cards >> are capable of capturing 2, 8 or 16 audio channels (for SDI Inputs). >> Currently the value is hardcoded to 2. Int

Re: [FFmpeg-devel] [PATCHv2] lavc/cbrt_tablegen: speed up tablegen

Hi!, El Mon, Jan 04, 2016 at 06:33:59PM -0800, Ganesh Ajjanagadde escribio: > This exploits an approach based on the sieve of Eratosthenes, a popular > method for generating prime numbers. > > Tables are identical to previous ones. > > Tested with FATE with/without --enable-hardcoded-tables. >

Re: [FFmpeg-devel] [PATCH] decklink: support all valid numbers of audio channels

Am 20.12.2015 um 12:57 schrieb Matthias Hunstock: > As it is already written in the documentation, BMD DeckLink cards > are capable of capturing 2, 8 or 16 audio channels (for SDI Inputs). > Currently the value is hardcoded to 2. Introduces new option. Any more opinions on this? I'd like to add s

[FFmpeg-devel] [PATCH]lavc/opus: Use original sample rate for decoding

Hi! Attached patch intends to match what opusdec does, sorry if I miss something. Please review, Carl Eugen diff --git a/libavcodec/opus.c b/libavcodec/opus.c index f2b8ecc..df04f05 100644 --- a/libavcodec/opus.c +++ b/libavcodec/opus.c @@ -332,6 +332,18 @@ av_cold int ff_opus_parse_extradata(AVC

Re: [FFmpeg-devel] [RFC][PATCH]lavf/matroskaenc: Assume 48kHz sample rate for Opus initial padding.

On Tue, Jan 05, 2016 at 01:23:54PM +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached patch may fix this issue reported for Firefox: > https://bugzilla.mozilla.org/show_bug.cgi?id=1227153 > Completely untested but I believe the patch matches a > comment in libopusenc.c line 90. > > Please comment

Re: [FFmpeg-devel] [WIP] SDL2 in ffplay

On 1/2/16, Marton Balint wrote: > Hi, > > To anybody who is interested, I have pushed my experimental SDL2 branch of > ffplay to github. (https://github.com/cus/ffplay.git) > > SDL2 completely replaced SDL_Overlay with 3D textures, so with SDL2 it is > possible to: > - Use textures with odd width/

Re: [FFmpeg-devel] [PATCH v4] lavf/matroskadec: A_QUICKTIME/AV_CODEC_ID_NONE + SMI->SVQ3

On 01/05/2016 03:13 PM, Carl Eugen Hoyos wrote: Mats Peterson ffmpeg.org> writes: Therefore, your patch from 2014 for SMI -> SVQ3 needs to set the 'fourcc' variable to 'SVQ3' as well, which is later copied to st->codec->codec_tag in matroskadec.c. This cannot be part of the same patch. Carl

Re: [FFmpeg-devel] [PATCH v4] lavf/matroskadec: A_QUICKTIME/AV_CODEC_ID_NONE + SMI->SVQ3

Mats Peterson ffmpeg.org> writes: > Therefore, your patch from 2014 for SMI -> SVQ3 needs to set the > 'fourcc' variable to 'SVQ3' as well, which is later copied to > st->codec->codec_tag in matroskadec.c. This cannot be part of the same patch. Carl Eugen __

[FFmpeg-devel] [PATCH v4] lavf/matroskadec: A_QUICKTIME/AV_CODEC_ID_NONE + SMI->SVQ3

Incorrectly used codec_movaudio_tags instead of codec_movvideo_tags. Description follows: In many older QuickTime files, the audio format, or "fourcc", is 0x (AV_CODEC_ID_NONE). The QuickTime File Format Specification states the following regarding this situation: "This format descriptor

Re: [FFmpeg-devel] [PATCHv2] avformat/mp3dec, rmdec: check return value of ffio_ensure_seekback

On Mon, 4 Jan 2016 17:50:01 -0800 Ganesh Ajjanagadde wrote: > ffio_ensure_seekback can fail due to e.g ENOMEM. This return value is > checked here and a diagnostic is logged. > > All usage of ffio_ensure_seekback in the codebase now has the return value > checked. > > Reviewed-by: wm4 > Revi

Re: [FFmpeg-devel] [RFC][PATCH]lavf/matroskaenc: Assume 48kHz sample rate for Opus initial padding.

On Tue, Jan 5, 2016 at 2:26 PM, wm4 wrote: > On Tue, 5 Jan 2016 13:23:54 +0100 > Carl Eugen Hoyos wrote: > >> Hi! >> >> Attached patch may fix this issue reported for Firefox: >> https://bugzilla.mozilla.org/show_bug.cgi?id=1227153 >> Completely untested but I believe the patch matches a >> comme

Re: [FFmpeg-devel] [PATCH] Enable dash output to work when the output isn't a local file

On Tue, Jan 5, 2016 at 1:50 PM, Raymond Hilseth wrote: > > > On 04/01/16 17:36, "ffmpeg-devel on behalf of Hendrik Leppkes" > wrote: > >>On Mon, Jan 4, 2016 at 3:58 PM, wrote: >>> From: Raymond Hilseth >>> >>> Signed-off-by: Raymond Hilseth >>> --- >>> libavformat/dashenc.c | 4 ++-- >>> 1 f

Re: [FFmpeg-devel] [RFC][PATCH]lavf/matroskaenc: Assume 48kHz sample rate for Opus initial padding.

On Tue, 5 Jan 2016 13:23:54 +0100 Carl Eugen Hoyos wrote: > Hi! > > Attached patch may fix this issue reported for Firefox: > https://bugzilla.mozilla.org/show_bug.cgi?id=1227153 > Completely untested but I believe the patch matches a > comment in libopusenc.c line 90. > > Please comment, Carl

Re: [FFmpeg-devel] [PATCH] avcodec/srtdec: Keep exact end times

Hi Rodger, Thank you for looking into this. > On 29 dec. 2015, at 03:41, Rodger Combs wrote: > >> On Dec 3, 2015, at 03:30, Eelco Lempsink wrote: >> >> When converting SRT to SRT (to normalize) or WebVTT the end timestamps were >> modified compared to the original. >> >> Fixes trac 4783. >>

Re: [FFmpeg-devel] [PATCH] Enable dash output to work when the output isn't a local file

On 04/01/16 17:36, "ffmpeg-devel on behalf of Hendrik Leppkes" wrote: >On Mon, Jan 4, 2016 at 3:58 PM, wrote: >> From: Raymond Hilseth >> >> Signed-off-by: Raymond Hilseth >> --- >> libavformat/dashenc.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/libavf

[FFmpeg-devel] [PATCH v3] lavf/matroskadec: A_QUICKTIME/AV_CODEC_ID_NONE + SMI->SVQ3

In many older QuickTime files, the audio format, or "fourcc", is 0x (AV_CODEC_ID_NONE). The QuickTime File Format Specification states the following regarding this situation: "This format descriptor should not be used, but may be found in some files. Samples are assumed to be stored in ei

  1   2   >