Re: [FFmpeg-devel] [PATCH 00/15] replace pow(10, x) by exp10(x) across FFmpeg

2015-12-24 Thread Ganesh Ajjanagadde
On Thu, Dec 24, 2015 at 6:18 PM, Michael Niedermayer wrote: > On Thu, Dec 24, 2015 at 06:07:17PM -0800, Ganesh Ajjanagadde wrote: >> On Thu, Dec 24, 2015 at 3:55 PM, Ganesh Ajjanagadde wrote: >> [...] >> > 2. accuracy - yes, I am the only one who seems to care about it enough >> > to bring it up

Re: [FFmpeg-devel] [PATCH 00/15] replace pow(10, x) by exp10(x) across FFmpeg

2015-12-24 Thread Michael Niedermayer
On Thu, Dec 24, 2015 at 06:07:17PM -0800, Ganesh Ajjanagadde wrote: > On Thu, Dec 24, 2015 at 3:55 PM, Ganesh Ajjanagadde wrote: > [...] > > 2. accuracy - yes, I am the only one who seems to care about it enough > > to bring it up everytime. On the other hand, I have documented the > > caveat and

Re: [FFmpeg-devel] [PATCH 00/15] replace pow(10, x) by exp10(x) across FFmpeg

2015-12-24 Thread Ganesh Ajjanagadde
On Thu, Dec 24, 2015 at 3:55 PM, Ganesh Ajjanagadde wrote: [...] > 2. accuracy - yes, I am the only one who seems to care about it enough > to bring it up everytime. On the other hand, I have documented the > caveat and will transfer relevant information to avpriv_exp10 if we go > that route, so I

Re: [FFmpeg-devel] [PATCH 00/15] replace pow(10, x) by exp10(x) across FFmpeg

2015-12-24 Thread Ganesh Ajjanagadde
On Thu, Dec 24, 2015 at 3:08 PM, Michael Niedermayer wrote: > On Thu, Dec 24, 2015 at 01:39:36AM +0100, Michael Niedermayer wrote: >> On Wed, Dec 23, 2015 at 03:52:50PM -0800, Ganesh Ajjanagadde wrote: >> > On Wed, Dec 23, 2015 at 3:38 PM, Michael Niedermayer >> > wrote: >> > > On Wed, Dec 23, 20

Re: [FFmpeg-devel] [PATCH 00/15] replace pow(10, x) by exp10(x) across FFmpeg

2015-12-24 Thread Michael Niedermayer
On Thu, Dec 24, 2015 at 01:39:36AM +0100, Michael Niedermayer wrote: > On Wed, Dec 23, 2015 at 03:52:50PM -0800, Ganesh Ajjanagadde wrote: > > On Wed, Dec 23, 2015 at 3:38 PM, Michael Niedermayer > > wrote: > > > On Wed, Dec 23, 2015 at 10:47:20AM -0800, Ganesh Ajjanagadde wrote: > > >> exp10(x) i

Re: [FFmpeg-devel] [PATCH 00/15] replace pow(10, x) by exp10(x) across FFmpeg

2015-12-24 Thread Hendrik Leppkes
Am 24.12.2015 23:01 schrieb "Ronald S. Bultje" : > > Hi, > > On Thu, Dec 24, 2015 at 4:57 PM, Ganesh Ajjanagadde > wrote: > > > Also, over time I would like to cleanup the avutil/libm header: there > > are macros in places where there should really be functions, though > > Hendrik points out that

Re: [FFmpeg-devel] [PATCH] avcodec: add OpenJPEG 2.x compatibility

2015-12-24 Thread Ronald S. Bultje
Hi, On Thu, Dec 24, 2015 at 5:09 PM, Michael Bradshaw wrote: > On Thu, Nov 19, 2015 at 6:31 PM, Michael Niedermayer > wrote: > > > On Wed, Nov 18, 2015 at 09:22:57PM -0800, Michael Bradshaw wrote: > > > On Wed, Nov 18, 2015 at 8:00 AM, Michael Niedermayer > > > > > wrote: > > > > > > > On Tue,

Re: [FFmpeg-devel] [PATCH] avcodec: add OpenJPEG 2.x compatibility

2015-12-24 Thread Michael Bradshaw
On Thu, Nov 19, 2015 at 6:31 PM, Michael Niedermayer wrote: > On Wed, Nov 18, 2015 at 09:22:57PM -0800, Michael Bradshaw wrote: > > On Wed, Nov 18, 2015 at 8:00 AM, Michael Niedermayer > > > wrote: > > > > > On Tue, Nov 17, 2015 at 07:27:55AM -0800, Michael Bradshaw wrote: > > > > Hi, > > > > >

Re: [FFmpeg-devel] [PATCH 00/15] replace pow(10, x) by exp10(x) across FFmpeg

2015-12-24 Thread Ronald S. Bultje
Hi, On Thu, Dec 24, 2015 at 4:57 PM, Ganesh Ajjanagadde wrote: > Also, over time I would like to cleanup the avutil/libm header: there > are macros in places where there should really be functions, though > Hendrik points out that in some cases there is no real alternative. At > the moment, most

Re: [FFmpeg-devel] [PATCH 00/15] replace pow(10, x) by exp10(x) across FFmpeg

2015-12-24 Thread Ganesh Ajjanagadde
On Thu, Dec 24, 2015 at 1:49 PM, Ronald S. Bultje wrote: > Hi, > > On Thu, Dec 24, 2015 at 11:47 AM, Ganesh Ajjanagadde > wrote: > >> On Thu, Dec 24, 2015 at 8:37 AM, Ronald S. Bultje >> wrote: >> > Hi, >> > >> > On Wed, Dec 23, 2015 at 7:49 PM, Ganesh Ajjanagadde >> > wrote: >> > >> >> What I

Re: [FFmpeg-devel] [PATCH 00/15] replace pow(10, x) by exp10(x) across FFmpeg

2015-12-24 Thread Ronald S. Bultje
Hi, On Thu, Dec 24, 2015 at 11:47 AM, Ganesh Ajjanagadde wrote: > On Thu, Dec 24, 2015 at 8:37 AM, Ronald S. Bultje > wrote: > > Hi, > > > > On Wed, Dec 23, 2015 at 7:49 PM, Ganesh Ajjanagadde > > wrote: > > > >> What I meant was the following (I casually labelled it as ifdef, I > >> meant som

Re: [FFmpeg-devel] [PATCH] swr/resample: use av_clip_int16 instead of av_clip

2015-12-24 Thread Ganesh Ajjanagadde
On Wed, Dec 23, 2015 at 5:23 PM, Michael Niedermayer wrote: > On Wed, Dec 23, 2015 at 02:50:33PM -0800, Ganesh Ajjanagadde wrote: >> Signed-off-by: Ganesh Ajjanagadde >> --- >> libswresample/resample.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) > > LGTM > > thx pushed, thanks

[FFmpeg-devel] [PATCHv2] configure: correct check_mathfunc

2015-12-24 Thread Ganesh Ajjanagadde
check_mathfunc should test the existence of a prototype, and not implementation. It also needs to be moved past the pkgconfig stage, in order to ensure that all cflags, cppflags have been defined. This fixes detection of exp10, exp10f. Reviewed-by: Nicolas George Signed-off-by: Ganesh Ajjanagadd

Re: [FFmpeg-devel] [PATCH] lavu/libm: change macros to functions

2015-12-24 Thread Ganesh Ajjanagadde
On Thu, Dec 24, 2015 at 11:05 AM, Hendrik Leppkes wrote: > Am 24.12.2015 20:01 schrieb "Ganesh Ajjanagadde" : >> >> On Thu, Dec 24, 2015 at 10:52 AM, Hendrik Leppkes > wrote: >> > Am 24.12.2015 19:34 schrieb "Ganesh Ajjanagadde" >: >> >> >> >> In the standard library, these are functions. We shou

Re: [FFmpeg-devel] [PATCH] lavu/libm: change macros to functions

2015-12-24 Thread Hendrik Leppkes
Am 24.12.2015 20:01 schrieb "Ganesh Ajjanagadde" : > > On Thu, Dec 24, 2015 at 10:52 AM, Hendrik Leppkes wrote: > > Am 24.12.2015 19:34 schrieb "Ganesh Ajjanagadde" : > >> > >> In the standard library, these are functions. We should match it; there > >> is no reason for these to be macros. > >> >

Re: [FFmpeg-devel] [PATCH] lavu/libm: change macros to functions

2015-12-24 Thread Ganesh Ajjanagadde
On Thu, Dec 24, 2015 at 10:52 AM, Hendrik Leppkes wrote: > Am 24.12.2015 19:34 schrieb "Ganesh Ajjanagadde" : >> >> In the standard library, these are functions. We should match it; there >> is no reason for these to be macros. >> >> While at it, add some trivial comments for readability and corre

Re: [FFmpeg-devel] [PATCH] lavu/libm: change macros to functions

2015-12-24 Thread Hendrik Leppkes
Am 24.12.2015 19:34 schrieb "Ganesh Ajjanagadde" : > > In the standard library, these are functions. We should match it; there > is no reason for these to be macros. > > While at it, add some trivial comments for readability and correct an > incorrect (at standard double precision) M_LN2 constant u

Re: [FFmpeg-devel] [PATCH] configure: add check_feature_test_macro for exp10, exp10f

2015-12-24 Thread Ganesh Ajjanagadde
On Thu, Dec 24, 2015 at 10:37 AM, Nicolas George wrote: > Le quartidi 4 nivôse, an CCXXIV, Ganesh Ajjanagadde a écrit : >> Before I rework, to make sure I understand, why don't other math >> functions merely test for a prototype as you suggest? > > Because it was never needed. There is rarely an i

Re: [FFmpeg-devel] [PATCH] configure: add check_feature_test_macro for exp10, exp10f

2015-12-24 Thread Nicolas George
Le quartidi 4 nivôse, an CCXXIV, Ganesh Ajjanagadde a écrit : > Before I rework, to make sure I understand, why don't other math > functions merely test for a prototype as you suggest? Because it was never needed. There is rarely an implementation without a prototype. Regards, -- Nicolas Geor

[FFmpeg-devel] [PATCH] lavu/libm: change macros to functions

2015-12-24 Thread Ganesh Ajjanagadde
In the standard library, these are functions. We should match it; there is no reason for these to be macros. While at it, add some trivial comments for readability and correct an incorrect (at standard double precision) M_LN2 constant used in the exp2 fallback. Signed-off-by: Ganesh Ajjanagadde

Re: [FFmpeg-devel] [PATCH] configure: add check_feature_test_macro for exp10, exp10f

2015-12-24 Thread Ganesh Ajjanagadde
On Thu, Dec 24, 2015 at 10:12 AM, Nicolas George wrote: > Le quartidi 4 nivôse, an CCXXIV, Ganesh Ajjanagadde a écrit : >> The prototype checking is already done above via check_mathfunc, which >> follows your idea. > > No, it is not done, and especially not the way I suggested. > >>

Re: [FFmpeg-devel] [PATCH] configure: add check_feature_test_macro for exp10, exp10f

2015-12-24 Thread Nicolas George
Le quartidi 4 nivôse, an CCXXIV, Ganesh Ajjanagadde a écrit : > The prototype checking is already done above via check_mathfunc, which > follows your idea. No, it is not done, and especially not the way I suggested. >The trouble is that check_ld succeeds with/without > GNU_SOU

Re: [FFmpeg-devel] [PATCH] configure: add check_feature_test_macro for exp10, exp10f

2015-12-24 Thread Ganesh Ajjanagadde
On Thu, Dec 24, 2015 at 9:55 AM, Nicolas George wrote: > Le quartidi 4 nivôse, an CCXXIV, Ganesh Ajjanagadde a écrit : >> exp10 and exp10f need _GNU_SOURCE. check_mathfunc only tests if the >> function is available, and not whether it is locked or unlocked via >> _GNU_SOURCE. >> >> This adds some

Re: [FFmpeg-devel] [PATCH] configure: add check_feature_test_macro for exp10, exp10f

2015-12-24 Thread Nicolas George
Le quartidi 4 nivôse, an CCXXIV, Ganesh Ajjanagadde a écrit : > exp10 and exp10f need _GNU_SOURCE. check_mathfunc only tests if the > function is available, and not whether it is locked or unlocked via > _GNU_SOURCE. > > This adds some support to configure to test for _GNU_SOURCE and > accordingly

[FFmpeg-devel] [PATCH] configure: add check_feature_test_macro for exp10, exp10f

2015-12-24 Thread Ganesh Ajjanagadde
exp10 and exp10f need _GNU_SOURCE. check_mathfunc only tests if the function is available, and not whether it is locked or unlocked via _GNU_SOURCE. This adds some support to configure to test for _GNU_SOURCE and accordingly report the existence of exp10, exp10f. Signed-off-by: Ganesh Ajjanagadde

Re: [FFmpeg-devel] [PATCH 00/15] replace pow(10, x) by exp10(x) across FFmpeg

2015-12-24 Thread Ganesh Ajjanagadde
On Thu, Dec 24, 2015 at 8:37 AM, Ronald S. Bultje wrote: > Hi, > > On Wed, Dec 23, 2015 at 7:49 PM, Ganesh Ajjanagadde > wrote: > >> What I meant was the following (I casually labelled it as ifdef, I >> meant some preprocessor stuff): >> #if !HAVE_EXP10 || !(defined(_GNU_SOURCE)) >> ... >> #endif

Re: [FFmpeg-devel] [PATCH 00/15] replace pow(10, x) by exp10(x) across FFmpeg

2015-12-24 Thread Ronald S. Bultje
Hi, On Wed, Dec 23, 2015 at 7:49 PM, Ganesh Ajjanagadde wrote: > What I meant was the following (I casually labelled it as ifdef, I > meant some preprocessor stuff): > #if !HAVE_EXP10 || !(defined(_GNU_SOURCE)) > ... > #endif > > I have reproduced your issues via a minimal configure line, and th

Re: [FFmpeg-devel] [PATCH 1/3] x86/vf_blend: simplify using macros

2015-12-24 Thread James Almer
On 12/24/2015 6:50 AM, Paul B Mahol wrote: > On 12/24/15, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavfilter/x86/vf_blend.asm| 276 >> +--- >> libavfilter/x86/vf_blend_init.c | 102 +++ >> 2 files changed, 53 insertions(+),

Re: [FFmpeg-devel] [PATCH] x86/vf_maskedmerge: make ff_maskedmerge8_sse2 work on x86_32

2015-12-24 Thread James Almer
On 12/24/2015 5:30 AM, Paul B Mahol wrote: > On 12/23/15, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavfilter/x86/vf_maskedmerge.asm| 29 ++--- >> libavfilter/x86/vf_maskedmerge_init.c | 2 +- >> 2 files changed, 19 insertions(+), 12 deletions(-) >

Re: [FFmpeg-devel] [PATCH] fate: replace custom md5 tests with those from RFC 1321

2015-12-24 Thread Michael Niedermayer
On Wed, Dec 23, 2015 at 11:35:57PM -0300, James Almer wrote: > On 11/3/2015 2:18 PM, James Almer wrote: > > On 11/3/2015 4:44 AM, Clément Bœsch wrote: > >> On Tue, Nov 03, 2015 at 04:09:43AM -0300, James Almer wrote: > >>> Signed-off-by: James Almer > >>> --- > >>> libavutil/md5.c| 23 +++

Re: [FFmpeg-devel] [PATCH] lavf/srtdec: rewrite parsing logic

2015-12-24 Thread Clément Bœsch
On Thu, Dec 24, 2015 at 01:11:49PM +0100, Clément Bœsch wrote: > Fixes Ticket #5032 OK I was a bit lazy in writing a longer description, so here are some more explanations: The samples in Ticket #5032 is basically composed of \r\r\n line breaks. So we already are handling \r, or \n, or \r\n as li

[FFmpeg-devel] [PATCH] lavf/srtdec: rewrite parsing logic

2015-12-24 Thread Clément Bœsch
Fixes Ticket #5032 --- libavformat/srtdec.c | 165 ++- tests/fate/subtitles.mak |6 + tests/ref/fate/sub-srt-madness-timeshift | 36 + tests/ref/fate/sub-srt-rrn-remux | 2113 ++ 4 files changed, 2270 insertions(+), 50

Re: [FFmpeg-devel] [PATCH] Adding frame side data about green metadata

2015-12-24 Thread Nicolas Derouineau
Please find here attached the updated patch with the suggested modifications. Best regards, Nicolas DEROUINEAU De : ffmpeg-devel de la part de Michael Niedermayer Envoyé : mercredi 23 décembre 2015 14:49 À : FFmpeg development discussions and patches O

Re: [FFmpeg-devel] [PATCH 1/3] x86/vf_blend: simplify using macros

2015-12-24 Thread Paul B Mahol
On 12/24/15, James Almer wrote: > Signed-off-by: James Almer > --- > libavfilter/x86/vf_blend.asm| 276 > +--- > libavfilter/x86/vf_blend_init.c | 102 +++ > 2 files changed, 53 insertions(+), 325 deletions(-) > ok

Re: [FFmpeg-devel] [PATCH 3/3] x86/vf_blend: add sse2 versions of blend_difference and blend_negation

2015-12-24 Thread Paul B Mahol
On 12/24/15, James Almer wrote: > Signed-off-by: James Almer > --- > libavfilter/x86/vf_blend.asm| 12 +--- > libavfilter/x86/vf_blend_init.c | 4 > 2 files changed, 13 insertions(+), 3 deletions(-) > ok ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 2/3] x86/vf_blend: make all functions work on x86_32

2015-12-24 Thread Paul B Mahol
On 12/24/15, James Almer wrote: > Signed-off-by: James Almer > --- > libavfilter/x86/vf_blend.asm| 103 > +++- > libavfilter/x86/vf_blend_init.c | 4 +- > 2 files changed, 52 insertions(+), 55 deletions(-) > ok if tested

Re: [FFmpeg-devel] [PATCH] x86/vf_maskedmerge: make ff_maskedmerge8_sse2 work on x86_32

2015-12-24 Thread Paul B Mahol
On 12/23/15, James Almer wrote: > Signed-off-by: James Almer > --- > libavfilter/x86/vf_maskedmerge.asm| 29 ++--- > libavfilter/x86/vf_maskedmerge_init.c | 2 +- > 2 files changed, 19 insertions(+), 12 deletions(-) > ok if tested ___