Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add sidechaingate filter

2015-12-04 Thread Paul B Mahol
On 12/4/15, Ganesh Ajjanagadde wrote: > On Fri, Dec 4, 2015 at 3:49 PM, Paul B Mahol wrote: >> On 12/4/15, Ganesh Ajjanagadde wrote: >>> On Fri, Dec 4, 2015 at 11:36 AM, Paul B Mahol wrote: On 12/4/15, Ganesh Ajjanagadde wrote: > On Wed, Dec 2, 2015 at 1:42 AM, Paul B Mahol wrote: >>

Re: [FFmpeg-devel] [PATCH] ffmpeg: When streamcopying, only add the input seek position when copying timestamps.

2015-12-04 Thread Michael Niedermayer
On Sun, Nov 22, 2015 at 03:03:17PM +0100, Simon Thelen wrote: > Using -ss as an input option shifts timestamps down by the seek, so it > doesn't have to be added to the recording time when checking whether to > stop. > > Fixes #977 > > Signed-off-by: Simon Thelen > --- > ffmpeg.c | 2 +- > 1 fi

Re: [FFmpeg-devel] [PATCH] libavformat/mov.c: allow QuickTime metadata to come after traks

2015-12-04 Thread Michael Niedermayer
On Thu, Dec 03, 2015 at 04:40:24PM -0800, Neil Birkbeck wrote: > QuickTime metadata can come after trak data. Add indicator for which trak is > being parsed (-1 if none) so that global metadata after the trak can be > parsed. > > Signed-off-by: Neil Birkbeck > --- > libavformat/isom.h | 1 + >

Re: [FFmpeg-devel] [PATCH] mjpegdec: consider chroma subsampling in size check

2015-12-04 Thread Michael Niedermayer
On Fri, Dec 04, 2015 at 03:14:21PM +0100, Andreas Cadhalpun wrote: > On 03.12.2015 15:48, Michael Niedermayer wrote: > > On Wed, Dec 02, 2015 at 10:00:13PM +0100, Andreas Cadhalpun wrote: > >> @@ -1293,14 +1296,16 @@ static int mjpeg_decode_scan(MJpegDecodeContext > >> *s, int nb_components, int A

[FFmpeg-devel] [PATCH] lavf: add automatic bitstream filtering; bump version

2015-12-04 Thread Rodger Combs
This solves the problem discussed in https://ffmpeg.org/pipermail/ffmpeg-devel/2015-September/179238.html by allowing AVCodec::write_header to be delayed until after packets have been run through required bitstream filters in order to generate global extradata. It also provides a mechanism by whi

Re: [FFmpeg-devel] [PATCH] avfilter/codecview/WIP: add QP support

2015-12-04 Thread Michael Niedermayer
On Fri, Dec 04, 2015 at 05:06:34PM +0100, Clément Bœsch wrote: > On Mon, Aug 31, 2015 at 04:43:15PM +0200, Michael Niedermayer wrote: > > On Mon, Aug 31, 2015 at 03:29:03PM +0200, Clément Bœsch wrote: > > > From: Clément Bœsch > > > > > > --- > > > I'm not sure I'm doing the correct thing here, b

Re: [FFmpeg-devel] [PATCH 8/8] avcodec/dvdsubdec: fix typo in dlog message

2015-12-04 Thread Michael Niedermayer
On Fri, Dec 04, 2015 at 09:39:43AM -0500, Ganesh Ajjanagadde wrote: > Likely accidental in 764900d6458a2f79166ff91df4f20ad39cd6acec. > > Fixes: CID 1341578. > > Signed-off-by: Ganesh Ajjanagadde > --- ok [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB What d

Re: [FFmpeg-devel] [PATCH 4/8] avformat/movenc-test: correct varargs usage

2015-12-04 Thread Michael Niedermayer
On Fri, Dec 04, 2015 at 09:39:39AM -0500, Ganesh Ajjanagadde wrote: > It is required to call va_end for each invocation of va_start within the > same function. > > Fixes: CID 1341583. > > Signed-off-by: Ganesh Ajjanagadde should be correct [...] -- Michael GnuPG fingerprint: 9FF2128B147EF

Re: [FFmpeg-devel] [PATCH 5/8] avformat/rtsp: free opts dictionary on failure of getnameinfo

2015-12-04 Thread Michael Niedermayer
On Fri, Dec 04, 2015 at 09:39:40AM -0500, Ganesh Ajjanagadde wrote: > Fixes: CID 1341579. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavformat/rtsp.c | 1 + > 1 file changed, 1 insertion(+) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I do n

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/pgssubdec: Fix left shift of 255 by 24 places cannot be represented in type int

2015-12-04 Thread Michael Niedermayer
On Sat, Dec 05, 2015 at 12:13:05AM +0100, Clément Bœsch wrote: > On Fri, Dec 04, 2015 at 10:30:23PM +0100, Michael Niedermayer wrote: > > ffmpeg | branch: master | Michael Niedermayer | > > Fri Dec 4 21:38:12 2015 +0100| [4f2419888ba49245761f4ab343679c38e7880cfe] > > | committer: Michael Nieder

Re: [FFmpeg-devel] [PATCH] avcodec/golomb: Mask shift amount before use in get_ue_golomb()

2015-12-04 Thread Michael Niedermayer
On Fri, Dec 04, 2015 at 10:28:35PM +0100, Andreas Cadhalpun wrote: > On 03.12.2015 23:09, Michael Niedermayer wrote: > > From: Michael Niedermayer > > > > Fixes undefined behavior > > Fixes: mozilla bug 1229208 > > Fixes: > > fbeb8b2c7c996e9b91c6b1af319d7ebc/asan_heap-oob_195450f_2743_e8856ece45

Re: [FFmpeg-devel] [PATCH] aaccoder: prevent crash of anmr coder

2015-12-04 Thread Claudio Freire
On Fri, Dec 4, 2015 at 9:52 PM, Andreas Cadhalpun wrote: > Pushed. > >> Do you have the problematic input at hand? If so, send it privately. > > Sure, I'll send you a sample. > >> If I find a better solution I may try to push that instead, or at >> least add the file to fate tests. > > Thanks for

Re: [FFmpeg-devel] [PATCH 6/7] lavf/matroskaenc: add automatic bitstream filtering

2015-12-04 Thread Michael Niedermayer
On Fri, Dec 04, 2015 at 05:31:32AM -0600, Rodger Combs wrote: > --- > libavformat/matroskaenc.c | 43 +++ > 1 file changed, 35 insertions(+), 8 deletions(-) this causes a segfault with ./ffmpeg -i 702121h264-TTA.mkvtest82.mkv out.mkv ==19693== Invalid rea

Re: [FFmpeg-devel] overlay filter option/alternative

2015-12-04 Thread James Darnley
On 2015-12-04 06:29, Ryan Williams wrote: > EDIT: Fixed errors in syntax. > > TLDR, Would you consider an 'underlay' filter or perhaps an option on the > 'overlay' filter that reverses the order of the input labels? > > Consider the following shorthand syntax "[input][a] overlay, [b] overlay, [c

Re: [FFmpeg-devel] support for reading / writing encrypted MP4 files

2015-12-04 Thread Eran Kornblau
> Hi, > > Please do not top post. > Sorry, I hope this one comes out fine, didn't find a reasonable way to do it with Outlook ;-( > > Please send the patches to the mailing list. See > https://github.com/FFmpeg/FFmpeg/pull/153 > Attached, note there are two files, the second commit is just a tiny

Re: [FFmpeg-devel] [PATCH] aaccoder: prevent crash of anmr coder

2015-12-04 Thread Andreas Cadhalpun
On 05.12.2015 01:32, Claudio Freire wrote: > On Fri, Dec 4, 2015 at 9:21 PM, Andreas Cadhalpun > wrote: >> On 04.12.2015 23:49, Claudio Freire wrote: >>> On Fri, Dec 4, 2015 at 2:23 PM, Andreas Cadhalpun >>> wrote: If minq is negative, the range of sf_idx can be larger than SCALE_MAX_DI

Re: [FFmpeg-devel] [PATCH] aaccoder: prevent crash of anmr coder

2015-12-04 Thread Claudio Freire
On Fri, Dec 4, 2015 at 9:21 PM, Andreas Cadhalpun wrote: > On 04.12.2015 23:49, Claudio Freire wrote: >> On Fri, Dec 4, 2015 at 2:23 PM, Andreas Cadhalpun >> wrote: >>> If minq is negative, the range of sf_idx can be larger than >>> SCALE_MAX_DIFF allows, causing assertion failures later in >>> e

Re: [FFmpeg-devel] [PATCH] aaccoder: prevent crash of anmr coder

2015-12-04 Thread Andreas Cadhalpun
On 04.12.2015 23:49, Claudio Freire wrote: > On Fri, Dec 4, 2015 at 2:23 PM, Andreas Cadhalpun > wrote: >> If minq is negative, the range of sf_idx can be larger than >> SCALE_MAX_DIFF allows, causing assertion failures later in >> encode_scale_factors. >> >> Signed-off-by: Andreas Cadhalpun >> -

Re: [FFmpeg-devel] Ideas to replace the options system

2015-12-04 Thread James Darnley
On 2015-12-04 15:33, Nicolas George wrote: > Why do we need a new options system? > > Most importantly: escaping hell OMG yes! I have seen several times the amount of backslashes Windows users are forced to use to provide a path to some of the filters. You raise a lot of good points that need

Re: [FFmpeg-devel] Broken compilation

2015-12-04 Thread Ganesh Ajjanagadde
On Fri, Dec 4, 2015 at 6:04 PM, Hendrik Leppkes wrote: > On Fri, Dec 4, 2015 at 11:53 PM, Gonzalo wrote: >> I just merged master and run into a broken compile: >> >> make: *** No rule to make target «libavcodec/pixblockdsp_template.c», needed >> by «libavcodec/pixblockdsp.o». >> >> Thanks for loo

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/pgssubdec: Fix left shift of 255 by 24 places cannot be represented in type int

2015-12-04 Thread Clément Bœsch
On Fri, Dec 04, 2015 at 10:30:23PM +0100, Michael Niedermayer wrote: > ffmpeg | branch: master | Michael Niedermayer | Fri > Dec 4 21:38:12 2015 +0100| [4f2419888ba49245761f4ab343679c38e7880cfe] | > committer: Michael Niedermayer > > avcodec/pgssubdec: Fix left shift of 255 by 24 places cannot

Re: [FFmpeg-devel] Broken compilation

2015-12-04 Thread Hendrik Leppkes
On Fri, Dec 4, 2015 at 11:53 PM, Gonzalo wrote: > I just merged master and run into a broken compile: > > make: *** No rule to make target «libavcodec/pixblockdsp_template.c», needed > by «libavcodec/pixblockdsp.o». > > Thanks for looking into it. "make clean" helps in such situations. - Hendrik

Re: [FFmpeg-devel] [PATCH 6/8] avfilter/show_palette: fix memory leak

2015-12-04 Thread Ganesh Ajjanagadde
On Fri, Dec 4, 2015 at 5:29 PM, Marton Balint wrote: if ((ret = ff_formats_ref(in , &ctx->inputs[0]->out_formats)) < 0 || (ret = ff_formats_ref(out, &ctx->outputs[0]->in_formats)) < 0) -return ret; +goto fail; return 0; +fail: >

[FFmpeg-devel] Broken compilation

2015-12-04 Thread Gonzalo
I just merged master and run into a broken compile: make: *** No rule to make target «libavcodec/pixblockdsp_template.c», needed by «libavcodec/pixblockdsp.o». Thanks for looking into it. -- Gonzalo Garramuño ggarr...@gmail.com ___ ffmpeg-devel mai

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add sidechaingate filter

2015-12-04 Thread Ganesh Ajjanagadde
On Fri, Dec 4, 2015 at 3:49 PM, Paul B Mahol wrote: > On 12/4/15, Ganesh Ajjanagadde wrote: >> On Fri, Dec 4, 2015 at 11:36 AM, Paul B Mahol wrote: >>> On 12/4/15, Ganesh Ajjanagadde wrote: On Wed, Dec 2, 2015 at 1:42 AM, Paul B Mahol wrote: > On 12/2/15, Paul B Mahol wrote: >> O

Re: [FFmpeg-devel] [PATCH] aaccoder: prevent crash of anmr coder

2015-12-04 Thread Claudio Freire
On Fri, Dec 4, 2015 at 2:23 PM, Andreas Cadhalpun wrote: > If minq is negative, the range of sf_idx can be larger than > SCALE_MAX_DIFF allows, causing assertion failures later in > encode_scale_factors. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/aaccoder.c | 2 +- > 1 file changed,

Re: [FFmpeg-devel] [PATCH 6/8] avfilter/show_palette: fix memory leak

2015-12-04 Thread Marton Balint
if ((ret = ff_formats_ref(in , &ctx->inputs[0]->out_formats)) < 0 || (ret = ff_formats_ref(out, &ctx->outputs[0]->in_formats)) < 0) -return ret; +goto fail; return 0; +fail: +av_freep(&in->formats); what if in==NULL? +av_freep(&in); +av_free

Re: [FFmpeg-devel] Memory leaks in libavformat/segment.c

2015-12-04 Thread Michael Niedermayer
On Fri, Dec 04, 2015 at 11:20:17AM +0800, Lvqier wrote: > Hi, > > I am using FFmpeg to generate mpegts segments. FFmpeg has memory > leaks, see the valgrind output in the attachment. > > Command line to reproduce: > > valgrind --tool=memcheck --leak-check=full ./ffmpeg_g -f decklink > -i 'DeckLin

Re: [FFmpeg-devel] [PATCH] avcodec/golomb: Mask shift amount before use in get_ue_golomb()

2015-12-04 Thread Andreas Cadhalpun
On 03.12.2015 23:09, Michael Niedermayer wrote: > From: Michael Niedermayer > > Fixes undefined behavior > Fixes: mozilla bug 1229208 > Fixes: > fbeb8b2c7c996e9b91c6b1af319d7ebc/asan_heap-oob_195450f_2743_e8856ece4579ea486670be2b236099a0.bit > > Found-by: Tyson Smith > Found-by: Mateusz "j00ru"

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add sidechaingate filter

2015-12-04 Thread Paul B Mahol
On 12/4/15, Ganesh Ajjanagadde wrote: > On Fri, Dec 4, 2015 at 11:36 AM, Paul B Mahol wrote: >> On 12/4/15, Ganesh Ajjanagadde wrote: >>> On Wed, Dec 2, 2015 at 1:42 AM, Paul B Mahol wrote: On 12/2/15, Paul B Mahol wrote: > On 12/2/15, Ganesh Ajjanagadde wrote: >> On Tue, Dec 1,

Re: [FFmpeg-devel] [PATCH v3 03/14] mips: add p5600 core optimizations

2015-12-04 Thread Michael Niedermayer
On Thu, Dec 03, 2015 at 01:22:18PM +, Vicente Olivert Riera wrote: > Signed-off-by: Vicente Olivert Riera > --- > Changes v2 -> v3: > - Nothing. > > Changes v1 -> v2: > - Nothing. > > configure | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) applied thanks [...] -- Michae

Re: [FFmpeg-devel] [PATCH v3 02/14] mips: remove --mips32r5 configure option

2015-12-04 Thread Michael Niedermayer
On Thu, Dec 03, 2015 at 01:22:17PM +, Vicente Olivert Riera wrote: > Having a configure option with the same name as a MIPS ISA is confusing, > so better to remove it. This option was being used to add some > optimizations to a specific core (p5600). We will add the optimizations > just when th

Re: [FFmpeg-devel] Ideas to replace the options system

2015-12-04 Thread Michael Niedermayer
On Fri, Dec 04, 2015 at 03:33:39PM +0100, Nicolas George wrote: [...] > Extra features > > This system allows a few new interesting features. Some of them just > thanks to no longer worrying about sizeof(AVOption). > > Special syntaxes > > Any component can define its own syn

Re: [FFmpeg-devel] [PATCH] ass_split: fix handling of streams with no [Events] or Format: line

2015-12-04 Thread Clément Bœsch
Wasn't at least the lack for "Format:" line handled by 3e86ead3 or did I forget something? -- Clément B. signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] nvenc set slice number to 1 to improve encoding quality

2015-12-04 Thread Timo Rothenpieler
> --- libavcodec/nvenc.c | 3 +++ 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index > 43b8e78..b8f7f91 100644 --- a/libavcodec/nvenc.c +++ > b/libavcodec/nvenc.c @@ -762,6 +762,9 @@ static av_cold int > nvenc_encode_init(AVCodecContext *avctx) } } > > +

Re: [FFmpeg-devel] Ideas to replace the options system

2015-12-04 Thread Michael Niedermayer
Hi On Fri, Dec 04, 2015 at 11:22:17AM -0500, Ganesh Ajjanagadde wrote: [...] > > Conclusion > > > > This has been a very lengthy exposition. Actually, I believe > > implementation would not be that long. Well, longer than text, of course, > > but not as gigantic as the explanation suggests.

Re: [FFmpeg-devel] support for reading / writing encrypted MP4 files

2015-12-04 Thread Timothy Gu
Hi, Please do not top post. On Fri, Dec 4, 2015 at 10:57 AM Eran Kornblau wrote: > Thank you ! > > Opened a pull request here: https://github.com/FFmpeg/FFmpeg/pull/162 > Please send the patches to the mailing list. See https://github.com/FFmpeg/FFmpeg/pull/153 > I used libavutil/aes as you

Re: [FFmpeg-devel] [PATCH 6/8] avfilter/show_palette: fix memory leak

2015-12-04 Thread Ganesh Ajjanagadde
On Fri, Dec 4, 2015 at 11:34 AM, Clément Bœsch wrote: > On Fri, Dec 04, 2015 at 09:39:41AM -0500, Ganesh Ajjanagadde wrote: >> Recent commits 6aaac24d72a7da631173209841a3944fcb4a3309 and >> 3835554bf8ed78539a3492c239f979c0ab03a15f made progress towards cleaning >> up usage of the formats API, and

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add sidechaingate filter

2015-12-04 Thread Ganesh Ajjanagadde
On Fri, Dec 4, 2015 at 11:36 AM, Paul B Mahol wrote: > On 12/4/15, Ganesh Ajjanagadde wrote: >> On Wed, Dec 2, 2015 at 1:42 AM, Paul B Mahol wrote: >>> On 12/2/15, Paul B Mahol wrote: On 12/2/15, Ganesh Ajjanagadde wrote: > On Tue, Dec 1, 2015 at 2:14 PM, Paul B Mahol wrote: >> O

Re: [FFmpeg-devel] Ideas to replace the options system

2015-12-04 Thread Nicolas George
Le quartidi 14 frimaire, an CCXXIV, Ganesh Ajjanagadde a écrit : > > And while we are at it, we should change them to accept strings as > > pointer+length or pointer+end instead of zero-terminated C strings. > Are you referring here to something like djb's netstrings: > http://cr.yp.to/

Re: [FFmpeg-devel] Ideas to replace the options system

2015-12-04 Thread Thilo Borgmann
Am 04.12.15 um 15:33 schrieb Nicolas George: > [...] > Personal note: if you skimmed through the whole thing and did not find it > completely uninteresting, I would appreciate even short quick feedback, > even "looks interesting, will read more carefully later". I've no idea of the internals behin

Re: [FFmpeg-devel] support for reading / writing encrypted MP4 files

2015-12-04 Thread Eran Kornblau
Thank you ! Opened a pull request here: https://github.com/FFmpeg/FFmpeg/pull/162 Currently containing only the encoding part, I will start working on the decoding part and submit another pull request once it's ready and this one gets merged (it will reuse code from this pull). I tried to match

Re: [FFmpeg-devel] [PATCH] aacenc: remove experimental flag

2015-12-04 Thread Andreas Cadhalpun
On 02.12.2015 20:27, Claudio Freire wrote: > On Wed, Dec 2, 2015 at 4:14 PM, Rostislav Pehlivanov > wrote: >> This commit removes the experimental flag from the native AAC Encoder >> and thus makes it the default. That looks good. :) > There Hendrik Leppkes had a good idea to shield us from poss

[FFmpeg-devel] [PATCH] aaccoder: prevent crash of anmr coder

2015-12-04 Thread Andreas Cadhalpun
If minq is negative, the range of sf_idx can be larger than SCALE_MAX_DIFF allows, causing assertion failures later in encode_scale_factors. Signed-off-by: Andreas Cadhalpun --- libavcodec/aaccoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aaccoder.c b/liba

Re: [FFmpeg-devel] Ideas to replace the options system

2015-12-04 Thread Ronald S. Bultje
Hi Nicolas, On Fri, Dec 4, 2015 at 9:33 AM, Nicolas George wrote: > Personal note: if you skimmed through the whole thing and did not find it > completely uninteresting, I would appreciate even short quick feedback, > even "looks interesting, will read more carefully later". I feel for you :).

Re: [FFmpeg-devel] [PATCH v4 14/14] mips: display a warning message when using an unknown CPU

2015-12-04 Thread Andreas Cadhalpun
On 04.12.2015 16:53, Vicente Olivert Riera wrote: > Signed-off-by: Vicente Olivert Riera > --- > Changes v3 -> v4: > - Use a more accurate warning message. > > Changes v2 -> v3: > - This patch has been added for v3. > > Changes v1 -> v2: > - This patch didn't exist at that point. > > config

Re: [FFmpeg-devel] [PATCH v4 11/14] mips: do not disable any feature for generic cores

2015-12-04 Thread Andreas Cadhalpun
On 04.12.2015 16:48, Vicente Olivert Riera wrote: > We don't know which features are available when the user selects a > generic core, so don't disable anything by default and let the user > decide. > > Signed-off-by: Vicente Olivert Riera > --- > Changes v3 -> v4: > - Minor change in the commit

Re: [FFmpeg-devel] Ideas to replace the options system

2015-12-04 Thread Ganesh Ajjanagadde
On Fri, Dec 4, 2015 at 9:33 AM, Nicolas George wrote: > Hi. [...] > > Substring parsers > > Parsers need to be able to operate on a substring, and stop when they > reach the delimiters for the surrounding syntax. This is, in fact, > rather easy to achieve. > > Think h

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add sidechaingate filter

2015-12-04 Thread Paul B Mahol
On 12/4/15, Ganesh Ajjanagadde wrote: > On Wed, Dec 2, 2015 at 1:42 AM, Paul B Mahol wrote: >> On 12/2/15, Paul B Mahol wrote: >>> On 12/2/15, Ganesh Ajjanagadde wrote: On Tue, Dec 1, 2015 at 2:14 PM, Paul B Mahol wrote: > On 12/1/15, Nicolas George wrote: >> Le primidi 11 frimai

Re: [FFmpeg-devel] [PATCH 6/8] avfilter/show_palette: fix memory leak

2015-12-04 Thread Clément Bœsch
On Fri, Dec 04, 2015 at 09:39:41AM -0500, Ganesh Ajjanagadde wrote: > Recent commits 6aaac24d72a7da631173209841a3944fcb4a3309 and > 3835554bf8ed78539a3492c239f979c0ab03a15f made progress towards cleaning > up usage of the formats API, and in particular fixed possible NULL pointer > dereferences. >

Re: [FFmpeg-devel] [PATCH] avfilter/codecview/WIP: add QP support

2015-12-04 Thread Clément Bœsch
On Mon, Aug 31, 2015 at 04:43:15PM +0200, Michael Niedermayer wrote: > On Mon, Aug 31, 2015 at 03:29:03PM +0200, Clément Bœsch wrote: > > From: Clément Bœsch > > > > --- > > I'm not sure I'm doing the correct thing here, but maybe that's just > > because my > > samples aren't relevant. > > i tr

[FFmpeg-devel] [PATCH v4 14/14] mips: display a warning message when using an unknown CPU

2015-12-04 Thread Vicente Olivert Riera
Signed-off-by: Vicente Olivert Riera --- Changes v3 -> v4: - Use a more accurate warning message. Changes v2 -> v3: - This patch has been added for v3. Changes v1 -> v2: - This patch didn't exist at that point. configure | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure b/conf

[FFmpeg-devel] [PATCH v4 11/14] mips: do not disable any feature for generic cores

2015-12-04 Thread Vicente Olivert Riera
We don't know which features are available when the user selects a generic core, so don't disable anything by default and let the user decide. Signed-off-by: Vicente Olivert Riera --- Changes v3 -> v4: - Minor change in the commit log: remove "let's". Changes v2 -> v3: - Change the logic of th

Re: [FFmpeg-devel] [PATCH v3 14/14] mips: display a warning message when using an unknown CPU

2015-12-04 Thread Andreas Cadhalpun
Hi Vicente, On 04.12.2015 16:12, Vicente Olivert Riera wrote: > On 04/12/15 14:32, Andreas Cadhalpun wrote: >> On 03.12.2015 14:22, Vicente Olivert Riera wrote: >>> --- a/configure >>> +++ b/configure >>> @@ -4163,6 +4163,8 @@ elif enabled mips; then >>> # the unwanted features. >>>

Re: [FFmpeg-devel] [PATCH v3 14/14] mips: display a warning message when using an unknown CPU

2015-12-04 Thread Vicente Olivert Riera
Hello Andreas, On 04/12/15 14:32, Andreas Cadhalpun wrote: > On 03.12.2015 14:22, Vicente Olivert Riera wrote: >> Signed-off-by: Vicente Olivert Riera >> --- >> Changes v2 -> v3: >> - This patch has been added for v3. >> >> Changes v1 -> v2: >> - This patch didn't exist at that point. >> >> co

[FFmpeg-devel] [PATCH 1/3] avutil/threadmessage: add av_thread_message_flush()

2015-12-04 Thread Clément Bœsch
From: Clément Bœsch --- libavutil/threadmessage.c | 31 +++ libavutil/threadmessage.h | 16 2 files changed, 47 insertions(+) diff --git a/libavutil/threadmessage.c b/libavutil/threadmessage.c index b7fcbe2..a5f1507 100644 --- a/libavutil/threadmessa

Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo: use constants for rc_strategy

2015-12-04 Thread Clément Bœsch
On Mon, Nov 23, 2015 at 01:37:00PM +0100, Michael Niedermayer wrote: > On Mon, Nov 23, 2015 at 11:06:14AM +0100, Clément Bœsch wrote: > > On Sat, Nov 21, 2015 at 10:26:17PM +0100, Michael Niedermayer wrote: > > > On Sat, Nov 21, 2015 at 09:28:31PM +0100, Clément Bœsch wrote: > > > > --- > > > > li

Re: [FFmpeg-devel] [PATCH] ffmpeg: enable echoing with command and debug modes

2015-12-04 Thread Clément Bœsch
On Fri, Nov 20, 2015 at 03:35:35AM +0100, Michael Niedermayer wrote: > On Thu, Nov 19, 2015 at 11:23:38PM +0100, Clément Bœsch wrote: > > On Thu, Nov 19, 2015 at 11:16:46PM +0100, Michael Niedermayer wrote: > > > On Thu, Nov 19, 2015 at 10:54:45PM +0100, Clément Bœsch wrote: > > > > Allow seeing te

Re: [FFmpeg-devel] use AV_OPT_TYPE_BOOL in most places

2015-12-04 Thread Clément Bœsch
On Sat, Nov 21, 2015 at 10:17:49PM +0100, Clément Bœsch wrote: [...] Patchset applied -- Clément B. signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/3] libavutil/tablegen: add missing math.h include

2015-12-04 Thread Ganesh Ajjanagadde
On Fri, Dec 4, 2015 at 8:56 AM, Hendrik Leppkes wrote: > On Wed, Dec 2, 2015 at 10:14 AM, Paul B Mahol wrote: >> On 12/2/15, Hendrik Leppkes wrote: >>> --- >>> libavutil/tablegen.h | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/libavutil/tablegen.h b/libavutil/tablegen.h >>> i

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add sidechaingate filter

2015-12-04 Thread Ganesh Ajjanagadde
On Wed, Dec 2, 2015 at 1:42 AM, Paul B Mahol wrote: > On 12/2/15, Paul B Mahol wrote: >> On 12/2/15, Ganesh Ajjanagadde wrote: >>> On Tue, Dec 1, 2015 at 2:14 PM, Paul B Mahol wrote: On 12/1/15, Nicolas George wrote: > Le primidi 11 frimaire, an CCXXIV, Paul B Mahol a ecrit : >> S

[FFmpeg-devel] [PATCH 8/8] avcodec/dvdsubdec: fix typo in dlog message

2015-12-04 Thread Ganesh Ajjanagadde
Likely accidental in 764900d6458a2f79166ff91df4f20ad39cd6acec. Fixes: CID 1341578. Signed-off-by: Ganesh Ajjanagadde --- libavcodec/dvdsubdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/dvdsubdec.c b/libavcodec/dvdsubdec.c index 77da00a..dccabe4 100644 --- a

Re: [FFmpeg-devel] [PATCH] avfilter: add audio emphasis filter

2015-12-04 Thread Ganesh Ajjanagadde
On Fri, Dec 4, 2015 at 4:00 AM, Paul B Mahol wrote: > On 12/4/15, Ganesh Ajjanagadde wrote: >> On Thu, Dec 3, 2015 at 5:52 PM, Paul B Mahol wrote: >>> Signed-off-by: Paul B Mahol >>> --- >>> Changelog | 1 + >>> configure | 26 >>> doc/filters.texi

[FFmpeg-devel] [PATCH 7/8] avfilter/af_amix: fix memory leak

2015-12-04 Thread Ganesh Ajjanagadde
Recent commits 6aaac24d72a7da631173209841a3944fcb4a3309 and 3835554bf8ed78539a3492c239f979c0ab03a15f made progress towards cleaning up usage of the formats API, and in particular fixed possible NULL pointer dereferences. This commit addresses the issue of possible resource leaks when some interme

Re: [FFmpeg-devel] [PATCH] avfilter/all: handle ff_formats_unref correctly

2015-12-04 Thread Ganesh Ajjanagadde
On Fri, Nov 20, 2015 at 3:56 PM, Michael Niedermayer wrote: > On Fri, Nov 20, 2015 at 03:07:36PM -0500, Ganesh Ajjanagadde wrote: >> On Fri, Nov 20, 2015 at 3:00 PM, Michael Niedermayer >> wrote: >> > On Sun, Nov 15, 2015 at 07:21:11PM -0500, Ganesh Ajjanagadde wrote: >> >> Recent commits 6aaac2

[FFmpeg-devel] [PATCH 6/8] avfilter/show_palette: fix memory leak

2015-12-04 Thread Ganesh Ajjanagadde
Recent commits 6aaac24d72a7da631173209841a3944fcb4a3309 and 3835554bf8ed78539a3492c239f979c0ab03a15f made progress towards cleaning up usage of the formats API, and in particular fixed possible NULL pointer dereferences. This commit addresses the issue of possible resource leaks when some interme

[FFmpeg-devel] [PATCH 5/8] avformat/rtsp: free opts dictionary on failure of getnameinfo

2015-12-04 Thread Ganesh Ajjanagadde
Fixes: CID 1341579. Signed-off-by: Ganesh Ajjanagadde --- libavformat/rtsp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index c2db27f..6c0f660 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -2300,6 +2300,7 @@ static int sdp_read_heade

[FFmpeg-devel] [PATCH 4/8] avformat/movenc-test: correct varargs usage

2015-12-04 Thread Ganesh Ajjanagadde
It is required to call va_end for each invocation of va_start within the same function. Fixes: CID 1341583. Signed-off-by: Ganesh Ajjanagadde --- libavformat/movenc-test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/movenc-test.c b/libavformat/movenc-test.c index d494e41..95

[FFmpeg-devel] [PATCH 3/8] avfilter/af_channelmap: fix memory leak

2015-12-04 Thread Ganesh Ajjanagadde
Recent commits 6aaac24d72a7da631173209841a3944fcb4a3309 and 3835554bf8ed78539a3492c239f979c0ab03a15f made progress towards cleaning up usage of the formats API, and in particular fixed possible NULL pointer dereferences. This commit addresses the issue of possible resource leaks when some interme

[FFmpeg-devel] [PATCH 2/8] avfilter/vf_alphamerge: fix memory leaks

2015-12-04 Thread Ganesh Ajjanagadde
Recent commits 6aaac24d72a7da631173209841a3944fcb4a3309 and 3835554bf8ed78539a3492c239f979c0ab03a15f made progress towards cleaning up usage of the formats API, and in particular fixed possible NULL pointer dereferences. This commit addresses the issue of possible resource leaks when some interme

[FFmpeg-devel] [PATCH 1/8] avfilter/vf_overlay: fix memory leaks

2015-12-04 Thread Ganesh Ajjanagadde
Recent commits 6aaac24d72a7da631173209841a3944fcb4a3309 and 3835554bf8ed78539a3492c239f979c0ab03a15f made progress towards cleaning up usage of the formats API, and in particular fixed possible NULL pointer dereferences. This commit addresses the issue of possible resource leaks when some interme

[FFmpeg-devel] [PATCH 0/8] Bunch of CID fixes

2015-12-04 Thread Ganesh Ajjanagadde
Most of these are not terribly important, but are nonetheless bugs that need to be fixed. Brief summary given below: 1,2,3,6,7 relate to filter formats memory leaks. This was the outcome of some more detailed investigation following a back and forth with Paul. Credit should also go to Michael here

[FFmpeg-devel] Ideas to replace the options system

2015-12-04 Thread Nicolas George
Hi. This is a rather long explanation on ideas I have to replace the options system with something better. I will not work on it before I have made significant progress on de-recursiving lavfi, but I can still think of it and mature its design while walking in the street or waiting for the subway.

Re: [FFmpeg-devel] [PATCH v3 14/14] mips: display a warning message when using an unknown CPU

2015-12-04 Thread Andreas Cadhalpun
On 03.12.2015 14:22, Vicente Olivert Riera wrote: > Signed-off-by: Vicente Olivert Riera > --- > Changes v2 -> v3: > - This patch has been added for v3. > > Changes v1 -> v2: > - This patch didn't exist at that point. > > configure | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/c

Re: [FFmpeg-devel] [PATCH v3 11/14] mips: do not disable any feature for generic cores

2015-12-04 Thread Andreas Cadhalpun
On 03.12.2015 14:22, Vicente Olivert Riera wrote: > We don't know which features are available when the user selects a > generic core, so let's don't disable anything by default and let the I think the "let's" doesn't belong there. > user decide. > > Signed-off-by: Vicente Olivert Riera > --- >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec: implement vp9 dxva2 hwaccel

2015-12-04 Thread Hendrik Leppkes
On Fri, Dec 4, 2015 at 2:55 PM, Ronald S. Bultje wrote: > Hi, > > On Thu, Dec 3, 2015 at 5:13 AM, Hendrik Leppkes wrote: > >> +/* Create an annex B bitstream buffer with only slice NAL and >> finalize slice */ >> > > What does this comment mean? I suppose it's copy-pasted from someplace else

Re: [FFmpeg-devel] [PATCH 2/2] ffmdec: reject zero-sized chunks

2015-12-04 Thread Andreas Cadhalpun
On 03.12.2015 14:45, Michael Niedermayer wrote: > On Wed, Dec 02, 2015 at 11:13:44PM +0100, Andreas Cadhalpun wrote: >> If size is zero, avio_get_str fails, leaving the buffer uninitialized. >> This causes invalid reads in av_set_options_string. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> li

Re: [FFmpeg-devel] [PATCH 1/2] ffmdec: only seek back at EOF if a server is attached

2015-12-04 Thread Andreas Cadhalpun
On 03.12.2015 14:55, Michael Niedermayer wrote: > On Wed, Dec 02, 2015 at 11:13:14PM +0100, Andreas Cadhalpun wrote: >> Otherwise the ffm demuxer can return the same packets endlessly, if >> there is no server attached. >> --- >> >> I haven't tested ffserver, but since it sets server_attached, it >

Re: [FFmpeg-devel] [PATCH] mjpegdec: consider chroma subsampling in size check

2015-12-04 Thread Andreas Cadhalpun
On 03.12.2015 15:48, Michael Niedermayer wrote: > On Wed, Dec 02, 2015 at 10:00:13PM +0100, Andreas Cadhalpun wrote: >> @@ -1293,14 +1296,16 @@ static int mjpeg_decode_scan(MJpegDecodeContext *s, >> int nb_components, int Ah, >> v = s->v_scount[i]; >> x = 0; >>

Re: [FFmpeg-devel] [PATCH 1/3] libavutil/tablegen: add missing math.h include

2015-12-04 Thread Hendrik Leppkes
On Wed, Dec 2, 2015 at 10:14 AM, Paul B Mahol wrote: > On 12/2/15, Hendrik Leppkes wrote: >> --- >> libavutil/tablegen.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/libavutil/tablegen.h b/libavutil/tablegen.h >> index f81b46b..02acdd6 100644 >> --- a/libavutil/tablegen.h >> +++

Re: [FFmpeg-devel] [PATCH 2/2] avcodec: implement vp9 dxva2 hwaccel

2015-12-04 Thread Ronald S. Bultje
Hi, On Thu, Dec 3, 2015 at 5:13 AM, Hendrik Leppkes wrote: > +/* Create an annex B bitstream buffer with only slice NAL and > finalize slice */ > What does this comment mean? I suppose it's copy-pasted from someplace else and doesn't really belong here? I can't really review the changes th

Re: [FFmpeg-devel] [PATCH] vp9: add hwaccel hooks

2015-12-04 Thread Ronald S. Bultje
Hi, On Thu, Dec 3, 2015 at 3:26 PM, Hendrik Leppkes wrote: > On Thu, Dec 3, 2015 at 6:17 PM, Ronald S. Bultje > wrote: > > Hi, > > > > On Thu, Dec 3, 2015 at 11:29 AM, Hendrik Leppkes > > wrote: > > > >> On Thu, Dec 3, 2015 at 5:21 PM, Ronald S. Bultje > >> wrote: > >> > Hi, > >> > > >> > On

[FFmpeg-devel] [PATCH] ass_split: fix handling of streams with no [Events] or Format: line

2015-12-04 Thread Rodger Combs
--- libavcodec/ass_split.c | 66 -- 1 file changed, 42 insertions(+), 24 deletions(-) diff --git a/libavcodec/ass_split.c b/libavcodec/ass_split.c index 9bc7b9d..493a8fd 100644 --- a/libavcodec/ass_split.c +++ b/libavcodec/ass_split.c @@ -229,7 +229

Re: [FFmpeg-devel] [PATCH 7/7] lavf/mpegtsenc: add automatic bitstream filtering

2015-12-04 Thread Hendrik Leppkes
On Fri, Dec 4, 2015 at 12:31 PM, Rodger Combs wrote: > --- > libavformat/mpegtsenc.c | 65 > ++--- > 1 file changed, 35 insertions(+), 30 deletions(-) > > diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c > index 468bad4..a8fb3a2 100644 >

[FFmpeg-devel] [PATCH 7/7] lavf/mpegtsenc: add automatic bitstream filtering

2015-12-04 Thread Rodger Combs
--- libavformat/mpegtsenc.c | 65 ++--- 1 file changed, 35 insertions(+), 30 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 468bad4..a8fb3a2 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat/mpegtsenc.c @@ -698,7

[FFmpeg-devel] [PATCH 6/7] lavf/matroskaenc: add automatic bitstream filtering

2015-12-04 Thread Rodger Combs
--- libavformat/matroskaenc.c | 43 +++ 1 file changed, 35 insertions(+), 8 deletions(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index 10cf0a0..85e5d82 100644 --- a/libavformat/matroskaenc.c +++ b/libavformat/matroskaenc.c @@ -845

[FFmpeg-devel] [PATCH 5/7] lavf: add internal API to append a bsf to a stream's list

2015-12-04 Thread Rodger Combs
--- libavformat/internal.h | 11 +++ libavformat/utils.c| 22 ++ 2 files changed, 33 insertions(+) diff --git a/libavformat/internal.h b/libavformat/internal.h index 5ed548e..dcd2971 100644 --- a/libavformat/internal.h +++ b/libavformat/internal.h @@ -467,6 +467,17

[FFmpeg-devel] [PATCH 4/7] lavf: add automatic bitstream filtering; bump version

2015-12-04 Thread Rodger Combs
This solves the problem discussed in https://ffmpeg.org/pipermail/ffmpeg-devel/2015-September/179238.html by allowing AVCodec::write_header to be delayed until after packets have been run through required bitstream filters in order to generate global extradata. It also provides a mechanism by whi

[FFmpeg-devel] [PATCH 3/7] lavf/tee: use lavf API for applying bitstream filters

2015-12-04 Thread Rodger Combs
--- libavformat/tee.c | 44 +++- 1 file changed, 3 insertions(+), 41 deletions(-) diff --git a/libavformat/tee.c b/libavformat/tee.c index af52a49..8c54d32 100644 --- a/libavformat/tee.c +++ b/libavformat/tee.c @@ -405,45 +405,6 @@ fail: return ret; }

[FFmpeg-devel] [PATCH 2/7] ffmpeg: use lavf API for applying bitstream filters

2015-12-04 Thread Rodger Combs
--- ffmpeg.c | 46 -- ffmpeg.h | 1 - ffmpeg_opt.c | 6 +- 3 files changed, 9 insertions(+), 44 deletions(-) diff --git a/ffmpeg.c b/ffmpeg.c index bf5e983..c24c8ed 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -683,47 +683,10 @@ static void wri

[FFmpeg-devel] [PATCH 1/7] lavf: add API to apply a list of bsfs to a packet

2015-12-04 Thread Rodger Combs
--- libavformat/avformat.h | 11 +++ libavformat/utils.c| 49 + 2 files changed, 60 insertions(+) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 36f9d02..d94191e 100644 --- a/libavformat/avformat.h +++ b/libavformat/a

Re: [FFmpeg-devel] [PATCH v3 01/14] mips: rename mipsdspr1 to mipsdsp

2015-12-04 Thread Vicente Olivert Riera
On 04/12/15 01:36, Michael Niedermayer wrote: > On Thu, Dec 03, 2015 at 01:22:16PM +, Vicente Olivert Riera wrote: >> Signed-off-by: Vicente Olivert Riera >> --- >> Changes v2 -> v3: >> - Document it in the Changelog >> >> Changes v1 -> v2: >> - Remove a block of code for mipsdspr2 which was

Re: [FFmpeg-devel] [PATCH] avfilter: add audio emphasis filter

2015-12-04 Thread Hendrik Leppkes
On Fri, Dec 4, 2015 at 1:47 AM, Ganesh Ajjanagadde wrote: > On Thu, Dec 3, 2015 at 5:52 PM, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> Changelog | 1 + >> configure | 26 >> doc/filters.texi | 46 ++ >> libavfilter/Makef

Re: [FFmpeg-devel] [PATCH] avfilter: add audio emphasis filter

2015-12-04 Thread Paul B Mahol
On 12/4/15, Ganesh Ajjanagadde wrote: > On Thu, Dec 3, 2015 at 5:52 PM, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> Changelog | 1 + >> configure | 26 >> doc/filters.texi | 46 ++ >> libavfilter/Makefile | 1 + >>