Re: [FFmpeg-devel] [PATCH] avcodec: add OpenJPEG 2.x compatibility

On Wed, Nov 18, 2015 at 8:00 AM, Michael Niedermayer wrote: > On Tue, Nov 17, 2015 at 07:27:55AM -0800, Michael Bradshaw wrote: > > Hi, > > > > Attached patch adds support for OpenJPEG 2.0/2.1. Please review. > > > > Thanks, > > > > Michael Bradshaw > > > configure |5 > >

Re: [FFmpeg-devel] UDP constant bitrate feature (cbr)

> A proper ts remuxer is quite a different beast to what FFmpeg is > designed to do. As much as people try it can't be hacked into the > FFmpeg paradigm which is largely based around converting static files > of fixed codecs/resolutions in a nonrealtime environment from A to B. Why is there a udp

Re: [FFmpeg-devel] UDP constant bitrate feature (cbr)

> Of course if the user copies a video stream that isn't complaint there will > be problems if the decoder requires that. The issue here is two fold. > First, the current udp transmission model can cause problems with > networking equipment because of it's bursty nature. Second, FFmpeg can > make

Re: [FFmpeg-devel] [PATCH] ffprobe: do not exit in case the demuxer returns AVERROR(EAGAIN)

On Thu, Nov 19, 2015 at 02:36:19AM +0100, Michael Niedermayer wrote: > On Thu, Nov 19, 2015 at 01:25:53AM +0100, Andreas Cadhalpun wrote: > > On 18.11.2015 15:07, Michael Niedermayer wrote: > > > On Tue, Nov 17, 2015 at 05:20:08PM +0100, Stefano Sabatini wrote: > > >> On date Tuesday 2015-11-17 17:

Re: [FFmpeg-devel] [PATCH 1/3] aacsbr_fixed: avoid division by zero in sbr_gain_calc

On Thu, Nov 19, 2015 at 01:31:19AM +0100, Michael Niedermayer wrote: > On Thu, Nov 19, 2015 at 12:31:17AM +0100, Andreas Cadhalpun wrote: > > On 16.11.2015 13:46, Michael Niedermayer wrote: > > > On Fri, Nov 13, 2015 at 11:19:44PM +0100, Andreas Cadhalpun wrote: > > >> Well, unfortunately just reje

Re: [FFmpeg-devel] [PATCH] ffprobe: do not exit in case the demuxer returns AVERROR(EAGAIN)

On Thu, Nov 19, 2015 at 01:25:53AM +0100, Andreas Cadhalpun wrote: > On 18.11.2015 15:07, Michael Niedermayer wrote: > > On Tue, Nov 17, 2015 at 05:20:08PM +0100, Stefano Sabatini wrote: > >> On date Tuesday 2015-11-17 17:12:46 +0100, wm4 encoded: > >>> On Tue, 17 Nov 2015 17:00:29 +0100 > >>> Stef

Re: [FFmpeg-devel] [PATCH 1/3] aacsbr_fixed: avoid division by zero in sbr_gain_calc

On Thu, Nov 19, 2015 at 12:31:17AM +0100, Andreas Cadhalpun wrote: > On 16.11.2015 13:46, Michael Niedermayer wrote: > > On Fri, Nov 13, 2015 at 11:19:44PM +0100, Andreas Cadhalpun wrote: > >> Well, unfortunately just rejecting 0 in sbr_dequant is no solution, > >> because, as you noticed, that onl

Re: [FFmpeg-devel] [PATCH] aac_fixed: fix overflow in sbr_sum_square_c

On Wed, Nov 18, 2015 at 7:01 PM, Andreas Cadhalpun wrote: > On 16.11.2015 15:39, Nedeljko Babic wrote: On 11.11.2015 13:46, Michael Niedermayer wrote: >>> Comments fro AAC and SBR experts very welcome! >> >> This code was developed a while ago, but based on informations that I have >> this pa

Re: [FFmpeg-devel] [PATCH] ffprobe: do not exit in case the demuxer returns AVERROR(EAGAIN)

On 18.11.2015 15:07, Michael Niedermayer wrote: > On Tue, Nov 17, 2015 at 05:20:08PM +0100, Stefano Sabatini wrote: >> On date Tuesday 2015-11-17 17:12:46 +0100, wm4 encoded: >>> On Tue, 17 Nov 2015 17:00:29 +0100 >>> Stefano Sabatini wrote: >> [...] No, just in case ret == AVERROR(EAGAIN), i

[FFmpeg-devel] [PATCH] sbr_qmf_analysis: sanitize input for 32-bit imdct

If the input contains too many too large values, the imdct can overflow. Even if it didn't, the output would be larger than the valid range of 29 bits. Note that this is a very delicate limit: Allowing values up to 1<<25 does not prevent input larger than 1<<29 from arriving at sbr_sum_square, whi

Re: [FFmpeg-devel] [PATCH] aac_fixed: fix overflow in sbr_sum_square_c

On 16.11.2015 15:39, Nedeljko Babic wrote: >>> On 11.11.2015 13:46, Michael Niedermayer wrote: >> Comments fro AAC and SBR experts very welcome! > > This code was developed a while ago, but based on informations that I have > this part of code was analysed regarding possibility of overflow and >

[FFmpeg-devel] [PATCH] avcodec/pthread_slice: Remove rets_count

From: Michael Niedermayer It appears rets_count is redundant Signed-off-by: Michael Niedermayer --- libavcodec/pthread_slice.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/libavcodec/pthread_slice.c b/libavcodec/pthread_slice.c index f2c05d8..e887428 100644 --- a/

Re: [FFmpeg-devel] UDP constant bitrate feature (cbr)

> Because FFmpeg again cannot know a priori whether the input signal is > fully VBV compliant for use within MPEGTS. > An RTMP feed is an example of a feed which certainly isn't and so > FFmpeg has to make some numbers up in order to make a valid TS. > Such guessing might work in the file world but

[FFmpeg-devel] [PATCH 6/6] lavf/matroska: add automatic bitstream filtering

--- libavformat/matroskaenc.c | 43 +++ 1 file changed, 35 insertions(+), 8 deletions(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index 10cf0a0..41aa8e0 100644 --- a/libavformat/matroskaenc.c +++ b/libavformat/matroskaenc.c @@ -845

Re: [FFmpeg-devel] [PATCH 1/3] aacsbr_fixed: avoid division by zero in sbr_gain_calc

On 16.11.2015 13:46, Michael Niedermayer wrote: > On Fri, Nov 13, 2015 at 11:19:44PM +0100, Andreas Cadhalpun wrote: >> Well, unfortunately just rejecting 0 in sbr_dequant is no solution, >> because, as you noticed, that only happens via underflow. > > a value that has underflowed should be 0, so

[FFmpeg-devel] [PATCH 5/6] lavf: add API to append a bsf to a stream's list

--- libavformat/avformat.h | 9 + libavformat/utils.c| 20 2 files changed, 29 insertions(+) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 6e9ffe2..cedcb8f 100644 --- a/libavformat/avformat.h +++ b/libavformat/avformat.h @@ -2776,6 +2776,15 @

[FFmpeg-devel] [PATCH 4/6] lavf: add automatic bitstream filtering

This solves the problem discussed in https://ffmpeg.org/pipermail/ffmpeg-devel/2015-September/179238.html by allowing AVCodec::write_header to be delayed until after packets have been run through required bitstream filters in order to generate global extradata. It also provides a mechanism by whi

[FFmpeg-devel] [PATCH 3/6] lavf/tee: use lavf API for applying bitstream filters

--- libavformat/tee.c | 43 ++- 1 file changed, 2 insertions(+), 41 deletions(-) diff --git a/libavformat/tee.c b/libavformat/tee.c index af52a49..c527854 100644 --- a/libavformat/tee.c +++ b/libavformat/tee.c @@ -405,45 +405,6 @@ fail: return ret; }

[FFmpeg-devel] [PATCH 2/6] ffmpeg: use lavf API for applying bitstream filters

--- ffmpeg.c | 46 -- ffmpeg.h | 1 - ffmpeg_opt.c | 6 +- 3 files changed, 9 insertions(+), 44 deletions(-) diff --git a/ffmpeg.c b/ffmpeg.c index c4e9280..cae680d 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -683,47 +683,10 @@ static void wri

[FFmpeg-devel] [PATCH 1/6] lavf: add API to apply a list of bsfs to a packet

--- libavformat/avformat.h | 8 libavformat/utils.c| 49 + 2 files changed, 57 insertions(+) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 5283085..96d3cfd 100644 --- a/libavformat/avformat.h +++ b/libavformat/avfo

Re: [FFmpeg-devel] [PATCH] mxfdec: check edit_rate also for physical_track

On 16.11.2015 09:02, tim nicholson wrote: > On 15/11/15 18:07, Andreas Cadhalpun wrote: >> Previously only the edit_rate of material_track was checked. >> If it's negative, it causes assertion failures in av_rescale_rnd. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> libavformat/mxfdec.c | 10 +

Re: [FFmpeg-devel] [PATCH] aac_fixed: fix overflow in sbr_sum_square_c

On 16.11.2015 02:59, Michael Niedermayer wrote: > On Fri, Nov 13, 2015 at 10:32:47PM +0100, Andreas Cadhalpun wrote: >> Because these samples aren't tested with the aac_fixed decoder: >> * aac/ct_faac-adts.aac is only used to test the aac demuxer. >> * aac/al07_96.mp4 is for some reason only test

Re: [FFmpeg-devel] UDP constant bitrate feature (cbr)

On 18 November 2015 at 19:28, Zach Swena wrote: > Are you referring to this seperate applciation? > > https://github.com/mmalecki/multicat/blob/master/trunk/README > > While using that makes sense for Pavel's application, why should FFmpeg > produce a problematic UDP stream in the first place? Fo

Re: [FFmpeg-devel] UDP constant bitrate feature (cbr)

Hi, On Wed, Nov 18, 2015 at 9:28 PM, Zach Swena wrote: > Are you referring to this seperate applciation? > > https://github.com/mmalecki/multicat/blob/master/trunk/README > Probably what was meant was http://www.videolan.org/projects/multicat.html , but that might be a git svn clone of it. > >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/h264_slice: Clear top_borders on allocation

On Wed, Nov 18, 2015 at 02:41:05PM +0100, Michael Niedermayer wrote: > From: Michael Niedermayer > > In case of bitstream errors the deblock filter and slices can access > uninitialized > top_borders from previous slices which did not fill them as they stoped > halfway due > to error or where e

Re: [FFmpeg-devel] [PATCHv2] avutil/libm: correct isnan, isinf compat hacks

On Wed, Nov 18, 2015 at 2:58 PM, Michael Niedermayer wrote: > On Tue, Nov 17, 2015 at 04:54:10PM -0500, Ganesh Ajjanagadde wrote: >> isnan and isinf are actually macros as per the standard. In particular, >> the existing implementation has incorrect signature. Furthermore, this >> results in undef

Re: [FFmpeg-devel] [PATCHv2] avutil/libm: correct isnan, isinf compat hacks

On Tue, Nov 17, 2015 at 04:54:10PM -0500, Ganesh Ajjanagadde wrote: > isnan and isinf are actually macros as per the standard. In particular, > the existing implementation has incorrect signature. Furthermore, this > results in undefined behavior for e.g double values outside float range > as per t

Re: [FFmpeg-devel] [PATCH] AAC sequence header data setup if stream copy

On 18.11.2015 19:37, Michael Niedermayer wrote: [...] the first field of the context must be a AVClass updated patch attached -- Maksym Veremeyenko From 665751883fd515c753ada7bbf4d24c89a24f3d30 Mon Sep 17 00:00:00 2001 From: Maksym Veremeyenko Date: Wed, 18 Nov 2015 23:44:08 +0200 Subject: [

Re: [FFmpeg-devel] UDP constant bitrate feature (cbr)

Are you referring to this seperate applciation? https://github.com/mmalecki/multicat/blob/master/trunk/README While using that makes sense for Pavel's application, why should FFmpeg produce a problematic UDP stream in the first place? For applications like I need that involve encoding the stream

Re: [FFmpeg-devel] Error in ATRAC1 decoder?

On Tue, Nov 17, 2015 at 04:08:29AM +0300, Даниил Чередник wrote: > Thank you for answer. > > If I understood available ATRAC1 docs, the purpose of this delay line is > just to compensate delay of 1st QMF because for 1st and 2nd band we have > two QMF but for 3rd band just one. > > About test, yes

Re: [FFmpeg-devel] UDP constant bitrate feature (cbr)

> Only for strict CBR streams which FFmpeg cannot know a priori. That's > why the only correct way is to index the stream as it's received and > play out at a smooth rate like multicat does. I am not sure what you are referencing with regards to multicat. Is this an output option? Smooth output

[FFmpeg-devel] [PATCH v2 10/10] vtenc: Fixed mixed declarations and code.

From: Rick Kern Moved all declarations to the top of their block. Signed-off-by: Rick Kern --- libavcodec/vtenc.c | 409 ++--- 1 file changed, 260 insertions(+), 149 deletions(-) diff --git a/libavcodec/vtenc.c b/libavcodec/vtenc.c index 78a918b

[FFmpeg-devel] [PATCH v2 09/10] vtenc: check for NULL CMSampleBufferRef in encoder callback.

From: Rick Kern The CMSampleBufferRef passed into the encoder can be NULL. Added check. Signed-off-by: Rick Kern --- libavcodec/vtenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/vtenc.c b/libavcodec/vtenc.c index 583244c..78a918b 100644 --- a/libavcodec

[FFmpeg-devel] [PATCH v2 06/10] Better VideoToolbox check in configure.

From: Rick Kern --- configure | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/configure b/configure index 718f285..f99fbd9 100755 --- a/configure +++ b/configure @@ -5474,17 +5474,7 @@ enabled openssl && { check_lib openssl/ssl.h SSL_library_init -lssl

[FFmpeg-devel] [PATCH v2 08/10] vtenc: better allocation failure checking.

From: Rick Kern Some memory allocations were unchecked. Signed-off-by: Rick Kern --- libavcodec/vtenc.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/libavcodec/vtenc.c b/libavcodec/vtenc.c index f0d8289..583244c 100644 --- a/libavcodec/vtenc.c +++ b/libavcode

[FFmpeg-devel] [PATCH v2 07/10] vtenc: check condition after conditional variable unblocks.

From: Rick Kern Condition was not being verified after conditional variable unblocked. Signed-off-by: Rick Kern --- libavcodec/vtenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vtenc.c b/libavcodec/vtenc.c index 7132411..f0d8289 100644 --- a/libavcodec/vten

[FFmpeg-devel] [PATCH v2 04/10] vtenc: Fixed iOS compilation.

From: Rick Kern Removed dictionary keys that aren't supported on iOS builds. Signed-off-by: Rick Kern --- libavcodec/vtenc.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/vtenc.c b/libavcodec/vtenc.c index b363492..7132411 100644 --- a/libavcodec/vtenc.c +++ b/libavcodec/v

[FFmpeg-devel] [PATCH v2 05/10] vtenc: Check for min iOS/OSX versions.

From: Rick Kern configure was checking for the SDK version being used to compile. Now it compares against the minimum deployment target. Signed-off-by: Rick Kern --- configure | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure b/configure index e465424..718f28

[FFmpeg-devel] [PATCH v2 03/10] vtenc: Removed trailing whitespace.

From: Rick Kern Signed-off-by: Rick Kern --- libavcodec/vtenc.c | 308 ++--- 1 file changed, 154 insertions(+), 154 deletions(-) diff --git a/libavcodec/vtenc.c b/libavcodec/vtenc.c index f497c38..b363492 100644 --- a/libavcodec/vtenc.c +++ b/lib

[FFmpeg-devel] [PATCH v2 02/10] vtenc: Enable hardware encoding on OSX.

From: Rick Kern Use correct dictionary key/value to enable hardware encoding on OSX. Signed-off-by: Rick Kern --- libavcodec/vtenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/vtenc.c b/libavcodec/vtenc.c index 06c5360..f497c38 100644 --- a/libavcodec/vtenc.c +++ b/libavcod

[FFmpeg-devel] [PATCH v2 01/10] Added VideoToolbox H.264 encoder.

From: Rick Kern Enable with configure --enable-vtenc and encode using -codec:v vtenc_h264. Signed-off-by: Rick Kern --- MAINTAINERS|1 + configure | 14 + libavcodec/Makefile|1 + libavcodec/allcodecs.c |1 + libavcodec/vtenc.c | 1089

[FFmpeg-devel] [PATCH v2 00/10] Added VideoToolbox H.264 Encoder.

From: Rick Kern Updated patch with requested changes. Rick Kern (10): Added VideoToolbox H.264 encoder. vtenc: Enable hardware encoding on OSX. vtenc: Removed trailing whitespace. vtenc: Fixed iOS compilation. vtenc: Check for min iOS/OSX versions. Better VideoToolbox check in config

Re: [FFmpeg-devel] UDP constant bitrate feature (cbr)

Yea, how it is supposed to happen isn't complicated. To be of any help, I have to wrap my mind around how FFmpeg currently times the output stream. That mechanism currently does not produce as stable of a transmission rate as multiplexer and decoder hardware requires. Since there is a bounty avai

Re: [FFmpeg-devel] [PATCH] AAC sequence header data setup if stream copy

On Wed, Nov 18, 2015 at 05:04:06PM +0200, Maksym Veremeyenko wrote: > Hi, > > FLV remuxed from MPEG-TS stream does not contains *AAC sequence > header* as result no audio with some RTMP servers like *crtmpserver* > and YouTube. > > I am not a first who faced with such problem: > http://lists.ffmp

Re: [FFmpeg-devel] UDP constant bitrate feature (cbr)

> i suggest you read the mpeg specs, they detail when things should be > sent down to each byte IIRC > also IIRC its not that complicated, more like timestamp + bytepos/rate Only for strict CBR streams which FFmpeg cannot know a priori. That's why the only correct way is to index the stream as it'

Re: [FFmpeg-devel] [PATCH v2 02/13] Remove --mips32r5 configure option

Dear Michael Niedermayer, On 11/18/2015 04:59 PM, Michael Niedermayer wrote: > On Wed, Nov 18, 2015 at 11:13:38AM +, Vicente Olivert Riera wrote: >> Having a configure option with the same name as a MIPS ISA is confusing, >> so better to remove it. This option was being used to add some >> opt

Re: [FFmpeg-devel] UDP constant bitrate feature (cbr)

On Tue, Nov 17, 2015 at 03:06:27PM -0800, Zach Swena wrote: > Hi Pavel, > > I can confirm that there is a problem with the UDP packet engine in > FFmpeg. FFmpeg has excessive jitter in it's UDP streaming output to the > point where hardware decoders can't handle it. My solution was to buffer > t

Re: [FFmpeg-devel] [PATCH v2 02/13] Remove --mips32r5 configure option

On Wed, Nov 18, 2015 at 11:13:38AM +, Vicente Olivert Riera wrote: > Having a configure option with the same name as a MIPS ISA is confusing, > so better to remove it. This option was being used to add some > optimizations to a specific core (p5600). We will add the optimizations > just when th

Re: [FFmpeg-devel] [PATCH v2 01/13] Rename mipsdspr1 to mipsdsp

On Wed, Nov 18, 2015 at 11:13:37AM +, Vicente Olivert Riera wrote: > Signed-off-by: Vicente Olivert Riera > --- > Changes v1 -> v2: > - Remove a block of code for mipsdspr2 which wasn't intended to be in >this patch and it was causing a syntax error in the configure script. >Highlight

Re: [FFmpeg-devel] [PATCH v2] movenc-test: Pad the packet data start with 0s

On Wed, Nov 18, 2015 at 03:51:16PM +, Derek Buitenhuis wrote: > This way, it never starts with 0xFFF0, and never trips the > ADTS "Detection" code in movenc.c. > > Signed-off-by: Derek Buitenhuis > --- > libavformat/movenc-test.c | 6 +++--- > tests/ref/fate/movenc | 40

Re: [FFmpeg-devel] [PATCH] avcodec: add OpenJPEG 2.x compatibility

On Tue, Nov 17, 2015 at 07:27:55AM -0800, Michael Bradshaw wrote: > Hi, > > Attached patch adds support for OpenJPEG 2.0/2.1. Please review. > > Thanks, > > Michael Bradshaw > configure |5 > libavcodec/libopenjpegdec.c | 173 > libavcodec/l

[FFmpeg-devel] [PATCH v2] movenc-test: Pad the packet data start with 0s

This way, it never starts with 0xFFF0, and never trips the ADTS "Detection" code in movenc.c. Signed-off-by: Derek Buitenhuis --- libavformat/movenc-test.c | 6 +++--- tests/ref/fate/movenc | 40 2 files changed, 23 insertions(+), 23 deletions(-) di

Re: [FFmpeg-devel] [PATCH] movenc-test: Pad the packet data start with 0s

On 11/18/2015 3:15 PM, Michael Niedermayer wrote: > this looks a bit strange > doesnt this write the PTS into bytes which are never used or read? Uh, yep. Need to update size too. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmp

Re: [FFmpeg-devel] [PATCH] avcodec: add OpenJPEG 2.x compatibility

On Wed, Nov 18, 2015 at 6:21 AM, Derek Buitenhuis < derek.buitenh...@gmail.com> wrote: > On 11/17/2015 3:27 PM, Michael Bradshaw wrote: > > Attached patch adds support for OpenJPEG 2.0/2.1. Please review. > > This seems like quite a large change. Does it perhaps warrant its own > file/decoder name

Re: [FFmpeg-devel] [PATCH] movenc-test: Pad the packet data start with 0s

On Tue, Nov 17, 2015 at 04:00:30PM +, Derek Buitenhuis wrote: > This way, it never starts with 0xFFF0, and never trips the > ADTS "Detection" code in movenc.c. > > Signed-off-by: Derek Buitenhuis > --- > libavformat/movenc-test.c | 4 ++-- > tests/ref/fate/movenc | 40 ++

[FFmpeg-devel] [PATCH] AAC sequence header data setup if stream copy

Hi, FLV remuxed from MPEG-TS stream does not contains *AAC sequence header* as result no audio with some RTMP servers like *crtmpserver* and YouTube. I am not a first who faced with such problem: http://lists.ffmpeg.org/pipermail/ffmpeg-devel/2014-May/157791.html http://lists.ffmpeg.org/piperm

Re: [FFmpeg-devel] [PATCH] avcodec/h264, videotoolbox: do not return invalid frames on failure

On Wed, 18 Nov 2015 15:09:48 +0100 Michael Niedermayer wrote: > On Tue, Nov 17, 2015 at 03:19:29PM +0100, wm4 wrote: > > If videotoolbox_common_end_frame failed, then the AVFrame was returned > > to the API user with the dummy buffer (in AVFrame.buf[0]) still set, and > > the decode call indicati

Re: [FFmpeg-devel] [PATCH] avcodec: add OpenJPEG 2.x compatibility

On 11/17/2015 3:27 PM, Michael Bradshaw wrote: > Attached patch adds support for OpenJPEG 2.0/2.1. Please review. This seems like quite a large change. Does it perhaps warrant its own file/decoder name? - Derek ___ ffmpeg-devel mailing list ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] ffprobe: do not exit in case the demuxer returns AVERROR(EAGAIN)

Le septidi 27 brumaire, an CCXXIV, Stefano Sabatini a écrit : > Fix demuxing of files for which the demuxer returns AVERROR(EAGAIN) at > some point. Also returns error code to the caller in case of different > non EOF error. > --- > ffprobe.c | 11 ++- > 1 file changed, 10 insertions(+), 1

Re: [FFmpeg-devel] [PATCH] movenc-test: Pad the packet data start with 0s

On 11/17/2015 4:00 PM, Derek Buitenhuis wrote: > This way, it never starts with 0xFFF0, and never trips the > ADTS "Detection" code in movenc.c. > > Signed-off-by: Derek Buitenhuis > --- > libavformat/movenc-test.c | 4 ++-- > tests/ref/fate/movenc | 40 -

Re: [FFmpeg-devel] [PATCH] avformat/dashenc: Add framerate to dash manifest

On Wed, Nov 18, 2015 at 01:13:14AM -0800, Bryan Huh wrote: > DASH manifest should have framerate specified as an attribute in the > AdaptationSet element and Representation elements. Though ISO/IEC > 23009-1:2014 doesn't seem to define frameRate as a required attribute, > it is at least optional, a

Re: [FFmpeg-devel] [PATCH] avcodec/h264, videotoolbox: do not return invalid frames on failure

On Tue, Nov 17, 2015 at 03:19:29PM +0100, wm4 wrote: > If videotoolbox_common_end_frame failed, then the AVFrame was returned > to the API user with the dummy buffer (in AVFrame.buf[0]) still set, and > the decode call indicating success. > > These "half-set" AVFrames with dummy buffer are a video

Re: [FFmpeg-devel] [PATCH] ffprobe: do not exit in case the demuxer returns AVERROR(EAGAIN)

On Tue, Nov 17, 2015 at 05:20:08PM +0100, Stefano Sabatini wrote: > On date Tuesday 2015-11-17 17:12:46 +0100, wm4 encoded: > > On Tue, 17 Nov 2015 17:00:29 +0100 > > Stefano Sabatini wrote: > [...] > > > No, just in case ret == AVERROR(EAGAIN), in all other failure cases it > > > will exit the lo

Re: [FFmpeg-devel] [PATCH] avformat/genh: Fix tools/probetest failure

On Tue, Nov 17, 2015 at 07:04:05PM +0100, Paul B Mahol wrote: > On 11/17/15, Michael Niedermayer wrote: > > From: Michael Niedermayer > > > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/genh.c |2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/libavformat/genh.c

[FFmpeg-devel] [PATCH 1/2] avutil/mem: Add av_fast_mallocz()

From: Michael Niedermayer Signed-off-by: Michael Niedermayer --- libavutil/mem.c |4 libavutil/mem.h | 15 +++ 2 files changed, 19 insertions(+) diff --git a/libavutil/mem.c b/libavutil/mem.c index 323b183..8dfaad8 100644 --- a/libavutil/mem.c +++ b/libavutil/mem.c @@ -5

[FFmpeg-devel] [PATCH 2/2] avcodec/h264_slice: Clear top_borders on allocation

From: Michael Niedermayer In case of bitstream errors the deblock filter and slices can access uninitialized top_borders from previous slices which did not fill them as they stoped halfway due to error or where entirely missing Found-by: Tyson Smith Signed-off-by: Michael Niedermayer --- lib

Re: [FFmpeg-devel] [PATCH] configure: Add option to use gmp

I previously had an option for gcrypt too but it seemed to not work (FFmpeg crashed, iirc), so I just gave up on it. On 18 November 2015 at 05:41, Matt Oliver wrote: > On 15 November 2015 at 01:09, Ricardo Constantino > wrote: > >> Enables RTMP(T)E support with SChannel >> >> (Not sure if this

Re: [FFmpeg-devel] [PATCHv2] avformat/mp3dec, rmdec: check return value of ffio_ensure_seekback

On Wed, Nov 18, 2015 at 7:31 AM, wm4 wrote: > On Tue, 17 Nov 2015 17:39:31 -0500 > Ganesh Ajjanagadde wrote: > >> ffio_ensure_seekback can fail due to e.g ENOMEM. This return value is >> checked here and a diagnostic is logged. >> >> All usage of ffio_ensure_seekback in the codebase now has the r

Re: [FFmpeg-devel] [PATCHv2] avformat/mp3dec, rmdec: check return value of ffio_ensure_seekback

On Tue, 17 Nov 2015 17:39:31 -0500 Ganesh Ajjanagadde wrote: > ffio_ensure_seekback can fail due to e.g ENOMEM. This return value is > checked here and a diagnostic is logged. > > All usage of ffio_ensure_seekback in the codebase now has the return value > checked. > > Signed-off-by: Ganesh Aj

[FFmpeg-devel] [PATCH v2 12/13] Improve detection of MIPS ISAs, FPU and ASEs (DSP, MSA)

Signed-off-by: Vicente Olivert Riera --- Changes v1 -> v2: - Add a block of code for mipsdspr2 which was previously placed in the first patch of this series causing a syntax error in the configure script. https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2015-November/183444.html configu

[FFmpeg-devel] [PATCH v2 13/13] Add support for MIPS R6

Understanding the mips32r6 and mips64r6 ISAs in the configure script is not enough. In order to have full support for MIPS R6 in FFmpeg we need to be able to build it, and for that we need to make sure we don't use incompatible assembler code which makes the build fail. Ifdefing the offending code

[FFmpeg-devel] [PATCH v2 11/13] Remove the MIPS "generic" core in favor of "*"

There is no point to have a "generic" core when we can catch all unsupported cores with the "*" option, so remove it. Signed-off-by: Vicente Olivert Riera --- Changes v1 -> v2: - Nothing. configure |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/configure b/configur

[FFmpeg-devel] [PATCH v2 10/13] Put "disable mipsfpu" in a better place for loongson

Let's disable the ISAs first, and then the core capabilities, as we do for the rest of the cores. This way the code is better organized. Signed-off-by: Vicente Olivert Riera --- Changes v1 -> v2: - Nothing. configure |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/con

[FFmpeg-devel] [PATCH v2 09/13] Add mips32r6 architecture variant

Signed-off-by: Vicente Olivert Riera --- Changes v1 -> v2: - Nothing. configure | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 761c4cb..b31567e 100755 --- a/configure +++ b/configure @@ -1624,6 +1624,7 @@ ARCH_EXT_LIST_MIPS="

[FFmpeg-devel] [PATCH v2 07/13] MIPS i6400 core is not mips32r2, so disable mips32r2

Signed-off-by: Vicente Olivert Riera --- Changes v1 -> v2: - Nothing. configure |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/configure b/configure index d14b02b..ca5c784 100755 --- a/configure +++ b/configure @@ -4098,6 +4098,7 @@ elif enabled mips; then

[FFmpeg-devel] [PATCH v2 08/13] Add mips64r2 architecture variant

Signed-off-by: Vicente Olivert Riera --- Changes v1 -> v2: - Nothing. configure | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/configure b/configure index ca5c784..761c4cb 100755 --- a/configure +++ b/configure @@ -1623,6 +1623,7 @@ ARCH_EXT_LIST_ARM=" ARC

[FFmpeg-devel] [PATCH v2 06/13] MIPS i6400 core does have an FPU, so not disable it

Signed-off-by: Vicente Olivert Riera --- Changes v1 -> v2: - Fix a grammar mistake in the commit log. Change "do has" by "does have". Thanks to Moritz Barsnick: https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2015-November/183437.html configure |1 - 1 files changed, 0 insertions(+),

[FFmpeg-devel] [PATCH v2 05/13] Add MIPS i6400 core optimizations

Signed-off-by: Vicente Olivert Riera --- Changes v1 -> v2: - Nothing. configure |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 8598fe1..d0685f3 100755 --- a/configure +++ b/configure @@ -4101,9 +4101,10 @@ elif enabled mips; then

[FFmpeg-devel] [PATCH v2 04/13] Remove --mips64r6 configure option

Having a configure option with the same name as a MIPS ISA is confusing, so better to remove it. This option was being used to add some optimizations to a specific core (i6400). We will add the optimizations just when the i6400 core has been detected, in a later patch. Signed-off-by: Vicente Olive

[FFmpeg-devel] [PATCH v2 03/13] Add MIPS p5600 core optimizations

Signed-off-by: Vicente Olivert Riera --- Changes v1 -> v2: - Nothing. configure |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 83b2a64..ea129be 100755 --- a/configure +++ b/configure @@ -4094,8 +4094,9 @@ elif enabled mips; then

[FFmpeg-devel] [PATCH v2 02/13] Remove --mips32r5 configure option

Having a configure option with the same name as a MIPS ISA is confusing, so better to remove it. This option was being used to add some optimizations to a specific core (p5600). We will add the optimizations just when the p5600 core has been detected, in a later patch. Signed-off-by: Vicente Olive

[FFmpeg-devel] [PATCH v2 01/13] Rename mipsdspr1 to mipsdsp

Signed-off-by: Vicente Olivert Riera --- Changes v1 -> v2: - Remove a block of code for mipsdspr2 which wasn't intended to be in this patch and it was causing a syntax error in the configure script. Highlighted by Michael Niedermayer: https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2015-

Re: [FFmpeg-devel] [PATCH 01/13] Rename mipsdspr1 to mipsdsp

Dear Michael Niedermayer, On 11/17/2015 09:17 PM, Michael Niedermayer wrote: > On Mon, Nov 16, 2015 at 02:57:07PM +, Vicente Olivert Riera wrote: > [...] >> index 9a736ce..0461a97 100755 >> --- a/configure >> +++ b/configure >> @@ -380,7 +380,7 @@ Optimization options (experts only): >>--d

Re: [FFmpeg-devel] [PATCH] avformat/dashenc: Add framerate to dash manifest

Second patchset addresses feedback after discussion with Martin. It is now accounting for the fact that avg_frame_rate may not always be set. On Wed, Nov 18, 2015 at 1:13 AM, Bryan Huh wrote: > DASH manifest should have framerate specified as an attribute in the > AdaptationSet element and Repre

[FFmpeg-devel] [PATCH] avformat/dashenc: Add framerate to dash manifest

DASH manifest should have framerate specified as an attribute in the AdaptationSet element and Representation elements. Though ISO/IEC 23009-1:2014 doesn't seem to define frameRate as a required attribute, it is at least optional, and DASH-IF IOP 3.0 seems to require it. See section 3.2.4 of http:/