Re: [FFmpeg-devel] [PATCH 3/4] concatdec: add option for adding segment start time and duration metadata

Le duodi 12 brumaire, an CCXXIV, Marton Balint a écrit : > Signed-off-by: Marton Balint > --- > doc/demuxers.texi | 8 > libavformat/concatdec.c | 12 > 2 files changed, 20 insertions(+) Looks ok, except for a tiny remark below, but please consider what I suggested i

Re: [FFmpeg-devel] [PATCH 2/4] concatdec: factorize duration calculating code to get_duration function

Le duodi 12 brumaire, an CCXXIV, Marton Balint a écrit : > Signed-off-by: Marton Balint > --- > libavformat/concatdec.c | 19 --- > 1 file changed, 12 insertions(+), 7 deletions(-) I do not object, but I find that this part of the code is starting to become quite convoluted. Are

[FFmpeg-devel] [PATCH] The fail safe label fail1 should return -1, not 0.

--- ffserver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ffserver.c b/ffserver.c index 1d4c8dc..bb89d53 100644 --- a/ffserver.c +++ b/ffserver.c @@ -2425,7 +2425,7 @@ static int http_send_data(HTTPContext *c) /* fail safe - should never happen */

[FFmpeg-devel] [PATCH] update nvenc default parameters

From: Agatha Hu --- libavcodec/nvenc.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 812b0b4..17d58fc 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -769,8 +769,11 @@ static av_cold int nven

[FFmpeg-devel] [PATCH] update nvenc default parameters

From: Agatha Hu --- libavcodec/nvenc.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 812b0b4..17d58fc 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -769,8 +769,11 @@ static av_cold int nvenc

Re: [FFmpeg-devel] [PATCHv4] swresample/resample: improve bessel function accuracy and speed

On Sat, Nov 7, 2015 at 8:38 PM, Ganesh Ajjanagadde wrote: > On Sat, Nov 7, 2015 at 8:19 PM, Michael Niedermayer > wrote: >> On Thu, Nov 05, 2015 at 08:18:36PM -0500, Ganesh Ajjanagadde wrote: >>> On Thu, Nov 5, 2015 at 8:15 PM, Ganesh Ajjanagadde >>> wrote: >>> > [...] >>> >>> Nothing new here,

Re: [FFmpeg-devel] [PATCH] swresample: allow double precision beta value for the Kaiser window

On Sun, Nov 8, 2015 at 12:45 PM, Michael Niedermayer wrote: > On Sun, Nov 08, 2015 at 10:53:21AM -0500, Ganesh Ajjanagadde wrote: >> On Sun, Nov 8, 2015 at 7:24 AM, Derek Buitenhuis >> wrote: >> > On 11/7/2015 10:42 PM, Ganesh Ajjanagadde wrote: >> >> This is what I felt - it is an internal struc

[FFmpeg-devel] [PATCH] avformat/cache: Avoid int-overflow in cache compare function

cache protocol indexes its cache using AVTreeNodes which require a cmp function for inserting and searching new cache-entries. This cmp function expects a 32-bit int return value (negative, zero, or positive) but the cache cmp function returns an int64_t which can overflow the int, giving negative

[FFmpeg-devel] Overlay documentation does not mention pixel aspect ratio.

Hi, I would like to propose a change to the documentation for the overlay filter. The overlay filter does not detect pixel aspect ratio. This causes improper display resolution when overlaying smaller images on a larger image. A common example of this would be overlaying an SD source on an HD o

[FFmpeg-devel] [PATCH 3/3] aacps: avoid division by zero in stereo_processing

This fixes a SIGFPE crash in the aac_fixed decoder. Signed-off-by: Andreas Cadhalpun --- libavcodec/aacps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aacps.c b/libavcodec/aacps.c index 1165d9b..ccc79ff 100644 --- a/libavcodec/aacps.c +++ b/libavcodec/aacps.c

[FFmpeg-devel] [PATCH 2/3] aacsbr: ensure strictly monotone time borders

This fixes a SIGFPE crash in the aac_fixed decoder. Signed-off-by: Andreas Cadhalpun --- libavcodec/aacsbr_template.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/aacsbr_template.c b/libavcodec/aacsbr_template.c index 66f4159..f69d2f8 100644 --- a/libavcodec

[FFmpeg-devel] [PATCH 1/3] aacsbr_fixed: avoid division by zero in sbr_gain_calc

This fixes a SIGFPE crash in the aac_fixed decoder. Signed-off-by: Andreas Cadhalpun --- libavcodec/aacsbr_fixed.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/aacsbr_fixed.c b/libavcodec/aacsbr_fixed.c index f942d74..efe40f2 100644 --- a/libavcodec/aacsbr_f

Re: [FFmpeg-devel] [PATCH] avutil/softfloat: Assert that the exponent did not overflow the legal range in av_normalize1_sf()

On 08.11.2015 13:41, Michael Niedermayer wrote: > From: Michael Niedermayer > > Signed-off-by: Michael Niedermayer > --- > libavutil/softfloat.h |1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavutil/softfloat.h b/libavutil/softfloat.h > index 023ccd0..ed1aab3 100644 > --- a/lib

Re: [FFmpeg-devel] [PATCH] aac_fixed: fix overflow in sbr_sum_square_c

On 08.11.2015 20:17, Michael Niedermayer wrote: > On Sun, Nov 08, 2015 at 05:14:10PM +0100, Andreas Cadhalpun wrote: >> If accu overflows, a negative value can be returned. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> libavcodec/sbrdsp_fixed.c | 28 ++-- >> 1 file chan

Re: [FFmpeg-devel] [PATCH 2/4] softfloat: use av_normalize1_sf in av_int2sf

On 08.11.2015 19:40, Michael Niedermayer wrote: > On Sun, Nov 08, 2015 at 05:23:32PM +0100, Andreas Cadhalpun wrote: >> Updated variant attached. >> >> Best regards, >> Andreas > >> softfloat.h |7 ++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> 1621ecf24466d8c1ad8cb394a079a59f39

Re: [FFmpeg-devel] [PATCH 4/4] softfloat: return one when the argument of av_sqrt_sf is negative

On 08.11.2015 18:22, Michael Niedermayer wrote: > On Sun, Nov 08, 2015 at 05:12:37PM +0100, Andreas Cadhalpun wrote: >> softfloat.h |2 ++ >> 1 file changed, 2 insertions(+) >> 743e46bfbb223cee2d34e8db896758d59dcc308a >> 0001-softfloat-assert-when-the-argument-of-av_sqrt_sf-is-.patch >> From

[FFmpeg-devel] FFmpeg 2.8.2

Hi I will probably make 2.8.2 soon (days/week), if you want somethig backported, please backport sooner thx -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB When the tyrant has disposed of foreign enemies by conquest or treaty, and there is nothing more to fear from t

Re: [FFmpeg-devel] [PATCH 1/4] lavc/internal: add FF_CODEC_CAP_SKIP_FRAME_FILL_PARAM

On Sun, Nov 08, 2015 at 06:17:49PM +0100, Matthieu Bouron wrote: > On Tue, Nov 3, 2015 at 9:02 PM, Michael Niedermayer > wrote: > > > On Mon, Nov 02, 2015 at 11:45:05AM +0100, Matthieu Bouron wrote: > > > From: Matthieu Bouron > > > > > > Codec supporting FF_CODEC_SKIP_FRAME_FILL must still extr

Re: [FFmpeg-devel] [PATCH] aac_fixed: fix overflow in sbr_sum_square_c

On Sun, Nov 08, 2015 at 05:14:10PM +0100, Andreas Cadhalpun wrote: > If accu overflows, a negative value can be returned. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/sbrdsp_fixed.c | 28 ++-- > 1 file changed, 22 insertions(+), 6 deletions(-) CCing the author

Re: [FFmpeg-devel] [PATCH 2/4] softfloat: use av_normalize1_sf in av_int2sf

On Sun, Nov 08, 2015 at 05:23:32PM +0100, Andreas Cadhalpun wrote: > Updated variant attached. > > Best regards, > Andreas > softfloat.h |7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > 1621ecf24466d8c1ad8cb394a079a59f39a98e4d > 0001-softfloat-handle-INT_MIN-correctly-in-av_i

Re: [FFmpeg-devel] [PATCH] swresample: allow double precision beta value for the Kaiser window

On Sun, Nov 08, 2015 at 10:53:21AM -0500, Ganesh Ajjanagadde wrote: > On Sun, Nov 8, 2015 at 7:24 AM, Derek Buitenhuis > wrote: > > On 11/7/2015 10:42 PM, Ganesh Ajjanagadde wrote: > >> This is what I felt - it is an internal struct, and there are explicit > >> comments in the header saying that t

Re: [FFmpeg-devel] [PATCH 1/2] aaccoder_twoloop: Mark sfdiff as av_unused

On Sun, Nov 8, 2015 at 2:01 AM, Timothy Gu wrote: > --- > libavcodec/aaccoder_twoloop.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/aaccoder_twoloop.h b/libavcodec/aaccoder_twoloop.h > index e53257f..328d7c8 100644 > --- a/libavcodec/aaccoder_twoloop.h > ++

Re: [FFmpeg-devel] [PATCH 4/4] softfloat: return one when the argument of av_sqrt_sf is negative

On Sun, Nov 08, 2015 at 05:12:37PM +0100, Andreas Cadhalpun wrote: > On 08.11.2015 01:02, Michael Niedermayer wrote: > > On Sun, Nov 08, 2015 at 12:09:02AM +0100, Andreas Cadhalpun wrote: > >> Mathematically this is bogus, but it is much better than the previous > >> behaviour: returning a random v

[FFmpeg-devel] [PATCH] avformat: add FSB demuxer

Signed-off-by: Paul B Mahol --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/fsb.c| 150 +++ 3 files changed, 152 insertions(+) create mode 100644 libavformat/fsb.c diff --git a/libavformat/Makefile b/libavfo

Re: [FFmpeg-devel] [PATCH 1/4] lavc/internal: add FF_CODEC_CAP_SKIP_FRAME_FILL_PARAM

On Tue, Nov 3, 2015 at 9:02 PM, Michael Niedermayer wrote: > On Mon, Nov 02, 2015 at 11:45:05AM +0100, Matthieu Bouron wrote: > > From: Matthieu Bouron > > > > Codec supporting FF_CODEC_SKIP_FRAME_FILL must still extract and fill > > their parameters into AVCodecContext while honoring the skip_f

Re: [FFmpeg-devel] [PATCH 2/4] softfloat: use av_normalize1_sf in av_int2sf

Updated variant attached. Best regards, Andreas >From 5b9a0ebd17d046d7a99f6388f7fb30ff66e6 Mon Sep 17 00:00:00 2001 From: Andreas Cadhalpun Date: Sun, 8 Nov 2015 17:19:10 +0100 Subject: [PATCH] softfloat: handle INT_MIN correctly in av_int2sf Otherwise v=INT_MIN doesn't get normalized and th

Re: [FFmpeg-devel] [PATCH 1/4] softfloat: handle INT32_MIN correctly in av_normalize1_sf

On 08.11.2015 01:06, Michael Niedermayer wrote: > On Sun, Nov 08, 2015 at 12:07:08AM +0100, Andreas Cadhalpun wrote: >> Otherwise a.mant=INT32_MIN triggers the av_assert2. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> libavutil/softfloat.h | 4 >> 1 file changed, 4 insertions(+) >> >> dif

[FFmpeg-devel] [PATCH] aac_fixed: fix overflow in sbr_sum_square_c

If accu overflows, a negative value can be returned. Signed-off-by: Andreas Cadhalpun --- libavcodec/sbrdsp_fixed.c | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/libavcodec/sbrdsp_fixed.c b/libavcodec/sbrdsp_fixed.c index 5b7b7a6..7ab6cc6 10064

Re: [FFmpeg-devel] [PATCH 4/4] softfloat: return one when the argument of av_sqrt_sf is negative

On 08.11.2015 01:02, Michael Niedermayer wrote: > On Sun, Nov 08, 2015 at 12:09:02AM +0100, Andreas Cadhalpun wrote: >> Mathematically this is bogus, but it is much better than the previous >> behaviour: returning a random value from an out of bounds read. >> >> Returning zero will just lead to div

Re: [FFmpeg-devel] [PATCH] swresample: allow double precision beta value for the Kaiser window

On Sun, Nov 8, 2015 at 7:24 AM, Derek Buitenhuis wrote: > On 11/7/2015 10:42 PM, Ganesh Ajjanagadde wrote: >> This is what I felt - it is an internal struct, and there are explicit >> comments in the header saying that the struct's fields are meant to be >> manipulated via the options API unlike e

Re: [FFmpeg-devel] [PATCH] avformat: Add v210 demuxer

On 8 November 2015 at 00:30, Timothy Gu wrote: > Allows one to do: > > ffmpeg -s 1920x1080 -i blah.v210 ... > ffmpeg -s 1920x1080 -f v210x -i blah.yuv10 ... > > Fixes #1869. Looks good - I wonder if it can be merged with rawvideo though. Kieran __

Re: [FFmpeg-devel] [PATCH 3/4] softfloat: fix av_add_sf if one argument is zero

On 08.11.2015 00:54, Michael Niedermayer wrote: > On Sun, Nov 08, 2015 at 12:08:54AM +0100, Andreas Cadhalpun wrote: >> Otherwise (0x2000, 1) + (0, 33) gives (0, 33), i.e. 1 + 0 = 0. >> >> This fixes a division by zero in the aac_fixed decoder. >> >> Signed-off-by: Andreas Cadhalpun >> --- >>

[FFmpeg-devel] [PATCH] avutil/softfloat: Assert that the exponent did not overflow the legal range in av_normalize1_sf()

From: Michael Niedermayer Signed-off-by: Michael Niedermayer --- libavutil/softfloat.h |1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/softfloat.h b/libavutil/softfloat.h index 023ccd0..ed1aab3 100644 --- a/libavutil/softfloat.h +++ b/libavutil/softfloat.h @@ -79,6 +79,7 @@ sta

Re: [FFmpeg-devel] [PATCH] swresample: allow double precision beta value for the Kaiser window

On 11/7/2015 10:42 PM, Ganesh Ajjanagadde wrote: > This is what I felt - it is an internal struct, and there are explicit > comments in the header saying that the struct's fields are meant to be > manipulated via the options API unlike e.g libavcodec. The types were > IMHO not part of the ABI/API s

[FFmpeg-devel] [PATCH] avformat/wavdec: allow data chunk to be before fmt/xma2 chunk

Signed-off-by: Paul B Mahol --- libavformat/wavdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c index 621d21f..144e1b7 100644 --- a/libavformat/wavdec.c +++ b/libavformat/wavdec.c @@ -379,7 +379,7 @@ static int wav_read_header(A

Re: [FFmpeg-devel] [PATCH] avformat/cache: Avoid int-overflow in cache compare function

On Sat, Nov 07, 2015 at 08:53:54PM -0800, Bryan Huh wrote: > cache protocol indexes its cache using AVTreeNodes which require a cmp > function for inserting and searching new cache-entries. This cmp > function expects a 32-bit int return value (negative, zero, or positive) > but the cache cmp funct