On Sun, Nov 8, 2015 at 12:45 PM, Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Sun, Nov 08, 2015 at 10:53:21AM -0500, Ganesh Ajjanagadde wrote: >> On Sun, Nov 8, 2015 at 7:24 AM, Derek Buitenhuis >> <derek.buitenh...@gmail.com> wrote: >> > On 11/7/2015 10:42 PM, Ganesh Ajjanagadde wrote: >> >> This is what I felt - it is an internal struct, and there are explicit >> >> comments in the header saying that the struct's fields are meant to be >> >> manipulated via the options API unlike e.g libavcodec. The types were >> >> IMHO not part of the ABI/API since the struct was marked opaque. >> >> Anyway, this was my reasoning while submitting the patch. >> > >> > I think the patch is OK, but needs a micro bump. >> >> Modulo the version bump, I will wait for an explicit ack from Michael >> as he is the maintainer for this. > > patch LGTM > > thanks
pushed, thanks all. > > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > No human being will ever know the Truth, for even if they happen to say it > by chance, they would not even known they had done so. -- Xenophanes > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
