Re: [FFmpeg-devel] [PATCH 2/2] genh: Removed unused variable coef_splitted

2015-11-07 Thread James Almer
On 11/8/2015 2:01 AM, Timothy Gu wrote: > --- > libavformat/genh.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/libavformat/genh.c b/libavformat/genh.c > index 260e320..44862b3 100644 > --- a/libavformat/genh.c > +++ b/libavformat/genh.c > @@ -40,7 +40,6 @@ static i

[FFmpeg-devel] [PATCH 2/2] genh: Removed unused variable coef_splitted

2015-11-07 Thread Timothy Gu
--- libavformat/genh.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavformat/genh.c b/libavformat/genh.c index 260e320..44862b3 100644 --- a/libavformat/genh.c +++ b/libavformat/genh.c @@ -40,7 +40,6 @@ static int genh_read_header(AVFormatContext *s) { unsigned s

[FFmpeg-devel] [PATCH 1/2] aaccoder_twoloop: Mark sfdiff as av_unused

2015-11-07 Thread Timothy Gu
--- libavcodec/aaccoder_twoloop.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aaccoder_twoloop.h b/libavcodec/aaccoder_twoloop.h index e53257f..328d7c8 100644 --- a/libavcodec/aaccoder_twoloop.h +++ b/libavcodec/aaccoder_twoloop.h @@ -691,7 +691,7 @@ static void

[FFmpeg-devel] [PATCH] avformat/cache: Avoid int-overflow in cache compare function

2015-11-07 Thread Bryan Huh
cache protocol indexes its cache using AVTreeNodes which require a cmp function for inserting and searching new cache-entries. This cmp function expects a 32-bit int return value (negative, zero, or positive) but the cache cmp function returns an int64_t which can overflow the int, giving negative

Re: [FFmpeg-devel] [PATCH] avformat: Add v210 demuxer

2015-11-07 Thread James Almer
On 11/7/2015 11:46 PM, Timothy Gu wrote: > On Sat, Nov 07, 2015 at 10:22:34PM -0300, James Almer wrote: >> On 11/7/2015 9:45 PM, Timothy Gu wrote: >>> +#define OFFSET(x) offsetof(V210DemuxerContext, x) >>> +#define DEC AV_OPT_FLAG_DECODING_PARAM >>> +static const AVOption v210_options[] = { >>> +

Re: [FFmpeg-devel] [PATCH] Add pixblockdsp checkasm tests

2015-11-07 Thread Timothy Gu
On Sun, Nov 08, 2015 at 03:04:21AM +0100, Michael Niedermayer wrote: > On Sat, Nov 07, 2015 at 03:58:28PM -0800, Timothy Gu wrote: > > --- > > > > Consolidates BUF_SIZE macros > > > > --- > > tests/checkasm/Makefile | 1 + > > tests/checkasm/checkasm.c| 3 ++ > > tests/checkasm/chec

Re: [FFmpeg-devel] [PATCH] avformat: Add v210 demuxer

2015-11-07 Thread Timothy Gu
On Sat, Nov 07, 2015 at 10:22:34PM -0300, James Almer wrote: > On 11/7/2015 9:45 PM, Timothy Gu wrote: > > +#define OFFSET(x) offsetof(V210DemuxerContext, x) > > +#define DEC AV_OPT_FLAG_DECODING_PARAM > > +static const AVOption v210_options[] = { > > +{ "video_size", "set frame size", OFFSET(w

Re: [FFmpeg-devel] [PATCH] Add pixblockdsp checkasm tests

2015-11-07 Thread Michael Niedermayer
On Sat, Nov 07, 2015 at 03:58:28PM -0800, Timothy Gu wrote: > --- > > Consolidates BUF_SIZE macros > > --- > tests/checkasm/Makefile | 1 + > tests/checkasm/checkasm.c| 3 ++ > tests/checkasm/checkasm.h| 1 + > tests/checkasm/pixblockdsp.c | 107 >

Re: [FFmpeg-devel] [PATCHv4] swresample/resample: improve bessel function accuracy and speed

2015-11-07 Thread Ganesh Ajjanagadde
On Sat, Nov 7, 2015 at 8:19 PM, Michael Niedermayer wrote: > On Thu, Nov 05, 2015 at 08:18:36PM -0500, Ganesh Ajjanagadde wrote: >> On Thu, Nov 5, 2015 at 8:15 PM, Ganesh Ajjanagadde >> wrote: >> > [...] >> >> Nothing new here, just moved the copyright to the top of the file to >> satisfy some le

Re: [FFmpeg-devel] [PATCH] avformat: Add v210 demuxer

2015-11-07 Thread James Almer
On 11/7/2015 9:45 PM, Timothy Gu wrote: > +#define OFFSET(x) offsetof(V210DemuxerContext, x) > +#define DEC AV_OPT_FLAG_DECODING_PARAM > +static const AVOption v210_options[] = { > +{ "video_size", "set frame size", OFFSET(width), AV_OPT_TYPE_IMAGE_SIZE, > {.str = NULL}, 0, 0, DEC }, Isn't th

Re: [FFmpeg-devel] [PATCHv4] swresample/resample: improve bessel function accuracy and speed

2015-11-07 Thread Michael Niedermayer
On Thu, Nov 05, 2015 at 08:18:36PM -0500, Ganesh Ajjanagadde wrote: > On Thu, Nov 5, 2015 at 8:15 PM, Ganesh Ajjanagadde > wrote: > > [...] > > Nothing new here, just moved the copyright to the top of the file to > satisfy some legal requirements I am completely unaware of, don't know > why an in

[FFmpeg-devel] [PATCH] avformat: Add v210 demuxer

2015-11-07 Thread Timothy Gu
Allows one to do: ffmpeg -s 1920x1080 -i blah.v210 ... ffmpeg -s 1920x1080 -f v210x -i blah.yuv10 ... Fixes #1869. --- Remove .yuv from the list of extensions. --- libavformat/Makefile | 2 + libavformat/allformats.c | 2 + libavformat/v210.c | 133 ++

[FFmpeg-devel] [PATCH] avformat: Add v210 demuxer

2015-11-07 Thread Timothy Gu
Allows one to do: ffmpeg -s 1920x1080 -i blah.v210 ... ffmpeg -s 1920x1080 -f v210x -i blah.yuv10 ... Fixes #1869. --- libavformat/Makefile | 2 + libavformat/allformats.c | 2 + libavformat/v210.c | 133 +++ 3 files chan

[FFmpeg-devel] [PATCH] avformat: Add v210 demuxer

2015-11-07 Thread Timothy Gu
Allows one to do: ffmpeg -s 1920x1080 -i blah.v210 ... ffmpeg -s 1920x1080 -f v210x -i blah.yuv10 ... Fixes #1869. --- libavformat/Makefile | 2 + libavformat/allformats.c | 2 + libavformat/v210.c | 133 +++ 3 files chan

Re: [FFmpeg-devel] [PATCH 1/4] softfloat: handle INT32_MIN correctly in av_normalize1_sf

2015-11-07 Thread Michael Niedermayer
On Sun, Nov 08, 2015 at 12:07:08AM +0100, Andreas Cadhalpun wrote: > Otherwise a.mant=INT32_MIN triggers the av_assert2. > > Signed-off-by: Andreas Cadhalpun > --- > libavutil/softfloat.h | 4 > 1 file changed, 4 insertions(+) > > diff --git a/libavutil/softfloat.h b/libavutil/softfloat.h

Re: [FFmpeg-devel] [PATCH 4/4] softfloat: return one when the argument of av_sqrt_sf is negative

2015-11-07 Thread Michael Niedermayer
On Sun, Nov 08, 2015 at 12:09:02AM +0100, Andreas Cadhalpun wrote: > Mathematically this is bogus, but it is much better than the previous > behaviour: returning a random value from an out of bounds read. > > Returning zero will just lead to division by zero problems. > > This fixes av_assert2 fa

[FFmpeg-devel] [PATCH] Add pixblockdsp checkasm tests

2015-11-07 Thread Timothy Gu
--- Consolidates BUF_SIZE macros --- tests/checkasm/Makefile | 1 + tests/checkasm/checkasm.c| 3 ++ tests/checkasm/checkasm.h| 1 + tests/checkasm/pixblockdsp.c | 107 +++ 4 files changed, 112 insertions(+) create mode 100644 tests/che

Re: [FFmpeg-devel] [PATCH 3/4] softfloat: fix av_add_sf if one argument is zero

2015-11-07 Thread Michael Niedermayer
On Sun, Nov 08, 2015 at 12:08:54AM +0100, Andreas Cadhalpun wrote: > Otherwise (0x2000, 1) + (0, 33) gives (0, 33), i.e. 1 + 0 = 0. > > This fixes a division by zero in the aac_fixed decoder. > > Signed-off-by: Andreas Cadhalpun > --- > libavutil/softfloat.h | 4 +++- > 1 file changed, 3 in

[FFmpeg-devel] [PATCH 3/4] softfloat: fix av_add_sf if one argument is zero

2015-11-07 Thread Andreas Cadhalpun
Otherwise (0x2000, 1) + (0, 33) gives (0, 33), i.e. 1 + 0 = 0. This fixes a division by zero in the aac_fixed decoder. Signed-off-by: Andreas Cadhalpun --- libavutil/softfloat.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavutil/softfloat.h b/libavutil/softfloa

[FFmpeg-devel] [PATCH 4/4] softfloat: return one when the argument of av_sqrt_sf is negative

2015-11-07 Thread Andreas Cadhalpun
Mathematically this is bogus, but it is much better than the previous behaviour: returning a random value from an out of bounds read. Returning zero will just lead to division by zero problems. This fixes av_assert2 failures in the aac_fixed decoder. Signed-off-by: Andreas Cadhalpun --- libavu

[FFmpeg-devel] [PATCH 2/4] softfloat: use av_normalize1_sf in av_int2sf

2015-11-07 Thread Andreas Cadhalpun
Otherwise the aac_fixed decoder triggers av_assert2 in av_mul_sf, when the input happens to be INT32_MIN. Signed-off-by: Andreas Cadhalpun --- libavutil/softfloat.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/softfloat.h b/libavutil/softfloat.h index 5fa5dc0..e8

[FFmpeg-devel] [PATCH 1/4] softfloat: handle INT32_MIN correctly in av_normalize1_sf

2015-11-07 Thread Andreas Cadhalpun
Otherwise a.mant=INT32_MIN triggers the av_assert2. Signed-off-by: Andreas Cadhalpun --- libavutil/softfloat.h | 4 1 file changed, 4 insertions(+) diff --git a/libavutil/softfloat.h b/libavutil/softfloat.h index 00ff4a1..5fa5dc0 100644 --- a/libavutil/softfloat.h +++ b/libavutil/softfloat

Re: [FFmpeg-devel] [PATCH] swresample: allow double precision beta value for the Kaiser window

2015-11-07 Thread Ganesh Ajjanagadde
On Sat, Nov 7, 2015 at 4:57 PM, Michael Niedermayer wrote: > On Sat, Nov 07, 2015 at 10:49:42PM +0100, wm4 wrote: >> On Sat, 7 Nov 2015 20:00:50 + >> Derek Buitenhuis wrote: >> >> > On 11/7/2015 7:35 PM, Paul B Mahol wrote: >> > > AFAIK changing option from int to double will break programs w

Re: [FFmpeg-devel] [PATCH] swresample: allow double precision beta value for the Kaiser window

2015-11-07 Thread Michael Niedermayer
On Sat, Nov 07, 2015 at 10:49:42PM +0100, wm4 wrote: > On Sat, 7 Nov 2015 20:00:50 + > Derek Buitenhuis wrote: > > > On 11/7/2015 7:35 PM, Paul B Mahol wrote: > > > AFAIK changing option from int to double will break programs which > > > assume opttions is int. > > > > Not really sure how

Re: [FFmpeg-devel] [PATCH] swresample: allow double precision beta value for the Kaiser window

2015-11-07 Thread wm4
On Sat, 7 Nov 2015 20:00:50 + Derek Buitenhuis wrote: > On 11/7/2015 7:35 PM, Paul B Mahol wrote: > > AFAIK changing option from int to double will break programs which > > assume opttions is int. > > Not really sure how it could. The original range allowed was [2,16], > and using any of t

Re: [FFmpeg-devel] [PATCH] swresample: allow double precision beta value for the Kaiser window

2015-11-07 Thread Derek Buitenhuis
On 11/7/2015 7:35 PM, Paul B Mahol wrote: > AFAIK changing option from int to double will break programs which > assume opttions is int. Not really sure how it could. The original range allowed was [2,16], and using any of the av_opt_set functions should still work with that, no? - Derek ___

Re: [FFmpeg-devel] [PATCH] swresample: allow double precision beta value for the Kaiser window

2015-11-07 Thread Paul B Mahol
On 11/7/15, Derek Buitenhuis wrote: > On 11/7/2015 4:47 PM, Paul B Mahol wrote: >> I'm afraid that this can't be done this way. > > Perhaps providing more detail than HAL 9000 could > help Ganesh here. AFAIK changing option from int to double will break programs which assume opttions is int.

Re: [FFmpeg-devel] [PATCH] swresample: allow double precision beta value for the Kaiser window

2015-11-07 Thread Derek Buitenhuis
On 11/7/2015 4:47 PM, Paul B Mahol wrote: > I'm afraid that this can't be done this way. Perhaps providing more detail than HAL 9000 could help Ganesh here. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo

Re: [FFmpeg-devel] [PATCH 1/2] mmaldec: add vc1 decoding support

2015-11-07 Thread wm4
On Sat, 7 Nov 2015 13:22:48 -0300 James Almer wrote: > On 11/7/2015 1:17 PM, wm4 wrote: > > On Fri, 6 Nov 2015 22:21:55 -0300 > > James Almer wrote: > > > >> On 11/6/2015 12:15 PM, wm4 wrote: > >>> --- > >>> configure | 3 +++ > >>> libavcodec/Makefile| 1 + > >>> libavc

Re: [FFmpeg-devel] [PATCH] swresample/options: change rematrix_maxval default to 1.0

2015-11-07 Thread wm4
On Sat, 7 Nov 2015 18:33:07 +0100 Michael Niedermayer wrote: > On Fri, Nov 06, 2015 at 01:48:59PM +0100, wm4 wrote: > > On Fri, 6 Nov 2015 12:58:23 +0100 > > Michael Niedermayer wrote: > > > > > On Fri, Nov 06, 2015 at 11:16:49AM +0100, wm4 wrote: > > > > On Fri, 6 Nov 2015 10:54:28 +0100 >

Re: [FFmpeg-devel] [PATCH 1/7] lavfi: remove astreamsync.

2015-11-07 Thread Nicolas George
Series pushed. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] swresample/options: change rematrix_maxval default to 1.0

2015-11-07 Thread Michael Niedermayer
On Fri, Nov 06, 2015 at 01:48:59PM +0100, wm4 wrote: > On Fri, 6 Nov 2015 12:58:23 +0100 > Michael Niedermayer wrote: > > > On Fri, Nov 06, 2015 at 11:16:49AM +0100, wm4 wrote: > > > On Fri, 6 Nov 2015 10:54:28 +0100 > > > Michael Niedermayer wrote: > > > > > > > On Fri, Nov 06, 2015 at 08:52

Re: [FFmpeg-devel] [PATCH] qsvenc: write a53 caption data to SEI

2015-11-07 Thread Ivan Uskov
Hello Will, Saturday, November 7, 2015, 5:29:15 PM, you wrote: WK> --- WK> libavcodec/qsvenc.c | 114 WK> +-- WK> libavcodec/qsvenc.h | 2 +- WK> libavcodec/qsvenc_h264.c | 2 +- WK> 3 files changed, 113 insertions(+), 5 deletions(-) WK>

Re: [FFmpeg-devel] [PATCH] hevc: extract SEI caption data

2015-11-07 Thread Michael Niedermayer
On Sat, Nov 07, 2015 at 02:17:12PM +, Will Kelleher wrote: > On 11/7/15, 5:10 AM, "ffmpeg-devel on behalf of Michael Niedermayer" > wrote: > > > > >On Fri, Nov 06, 2015 at 02:48:46PM -0600, Will Kelleher wrote: > >> Signed-off-by: Will Kelleher > >> --- > >> libavcodec/hevc.c | 10 ++

Re: [FFmpeg-devel] [PATCH] swresample: allow double precision beta value for the Kaiser window

2015-11-07 Thread Paul B Mahol
On 11/7/15, Ganesh Ajjanagadde wrote: > Kaiser windows inherently don't require beta to be an integer. This was > an arbitrary restriction. Moreover, soxr does not require it, and in > fact often estimates beta to a non-integral value. > > Thus, this patch allows greater flexibility for swresample

[FFmpeg-devel] [PATCH] avformat/wavdec: parse XMA2 tag

2015-11-07 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/wavdec.c | 56 ++-- 1 file changed, 54 insertions(+), 2 deletions(-) diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c index ef24e16..621d21f 100644 --- a/libavformat/wavdec.c +++ b/libavformat/wav

Re: [FFmpeg-devel] [PATCH 1/2] mmaldec: add vc1 decoding support

2015-11-07 Thread James Almer
On 11/7/2015 1:17 PM, wm4 wrote: > On Fri, 6 Nov 2015 22:21:55 -0300 > James Almer wrote: > >> On 11/6/2015 12:15 PM, wm4 wrote: >>> --- >>> configure | 3 +++ >>> libavcodec/Makefile| 1 + >>> libavcodec/allcodecs.c | 2 ++ >>> libavcodec/mmaldec.c | 12 >>> 4

Re: [FFmpeg-devel] [PATCH 1/2] mmaldec: add vc1 decoding support

2015-11-07 Thread wm4
On Fri, 6 Nov 2015 22:21:55 -0300 James Almer wrote: > On 11/6/2015 12:15 PM, wm4 wrote: > > --- > > configure | 3 +++ > > libavcodec/Makefile| 1 + > > libavcodec/allcodecs.c | 2 ++ > > libavcodec/mmaldec.c | 12 > > 4 files changed, 18 insertions(+) > > >

Re: [FFmpeg-devel] [PATCH] avcodec/gifdec: skip data lzw consumed

2015-11-07 Thread nihui
avcodec_decode_video2 should return the number of bytes used if frame decompressed correctly the current gif decoder just returns the number of bytes of header part of one frame, not including the lzw compressed image data bytes, which should be included too as one avpacket may contain multiple

[FFmpeg-devel] [PATCH] swresample: allow double precision beta value for the Kaiser window

2015-11-07 Thread Ganesh Ajjanagadde
Kaiser windows inherently don't require beta to be an integer. This was an arbitrary restriction. Moreover, soxr does not require it, and in fact often estimates beta to a non-integral value. Thus, this patch allows greater flexibility for swresample clients. Signed-off-by: Ganesh Ajjanagadde --

Re: [FFmpeg-devel] [PATCH] lavu/opt: enhance printing durations.

2015-11-07 Thread Nicolas George
Le quintidi 5 brumaire, an CCXXIV, Nicolas George a écrit : > Trim unneeded leading components and trailing zeros. > Move the formating code in a separate function. > Use the function also to format the default value, it was currently > printed as plain integer, inconsistent to the way it is parsed

Re: [FFmpeg-devel] [PATCH] lavfi: add realtime filter.

2015-11-07 Thread Nicolas George
Le quartidi 4 brumaire, an CCXXIV, Nicolas George a écrit : > Similar to the -re option in ffmpeg that only works for input files. > Can be used at any place in the filter graph. > > Signed-off-by: Nicolas George > --- > Changelog| 1 + > doc/filters.texi | 16 ++ >

Re: [FFmpeg-devel] [PATCH] fate: add mpdecimate test.

2015-11-07 Thread Nicolas George
Le sextidi 6 brumaire, an CCXXIV, Michael Niedermayer a écrit : > tested on linux32, 64, mingw32, 64 and mips > works fine, LGTM Pushed, thanks. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 2/2] lavfi: add testsrc2 test source.

2015-11-07 Thread Nicolas George
Le sextidi 16 brumaire, an CCXXIV, Paul B Mahol a écrit : > Should be fine. Pushed like that. Thanks for all the remarks. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCHv4] avfilter: add anoisesrc

2015-11-07 Thread Paul B Mahol
On 11/6/15, Kyle Swanson wrote: > Signed-off-by: Kyle Swanson > --- > Changelog| 1 + > doc/filters.texi | 36 > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/asrc_anoisesrc.c | 207 > ++

Re: [FFmpeg-devel] [PATCH] avcodec/gifdec: skip data lzw consumed

2015-11-07 Thread Paul B Mahol
On 11/7/15, Ni Hui wrote: > fix the return code value of avcodec_decode_video2 for gif decoding, which > should be the consumed data length. > > --- > libavcodec/gifdec.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/gifdec.c b/libavcodec/gifdec.c > index 9f2e6eb..5bcb176

[FFmpeg-devel] [PATCH] qsvenc: write a53 caption data to SEI

2015-11-07 Thread Will Kelleher
--- libavcodec/qsvenc.c | 114 +-- libavcodec/qsvenc.h | 2 +- libavcodec/qsvenc_h264.c | 2 +- 3 files changed, 113 insertions(+), 5 deletions(-) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index df1f777..0ee45f9 100644 --- a/l

[FFmpeg-devel] [PATCH] avcodec/gifdec: skip data lzw consumed

2015-11-07 Thread Ni Hui
fix the return code value of avcodec_decode_video2 for gif decoding, which should be the consumed data length. --- libavcodec/gifdec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/gifdec.c b/libavcodec/gifdec.c index 9f2e6eb..5bcb176 100644 --- a/libavcodec/gifdec.c +++ b/lib

Re: [FFmpeg-devel] [PATCH] hevc: extract SEI caption data

2015-11-07 Thread Will Kelleher
On 11/7/15, 5:10 AM, "ffmpeg-devel on behalf of Michael Niedermayer" wrote: >On Fri, Nov 06, 2015 at 02:48:46PM -0600, Will Kelleher wrote: >> Signed-off-by: Will Kelleher >> --- >> libavcodec/hevc.c | 10 +++ >> libavcodec/hevc.h | 4 +++ >> libavcodec/hevc_sei.c | 80 >> +

Re: [FFmpeg-devel] [PATCH] swresample/options: change rematrix_maxval default to 1.0

2015-11-07 Thread Ganesh Ajjanagadde
On Fri, Nov 6, 2015 at 2:52 AM, Nicolas George wrote: > Le sextidi 16 brumaire, an CCXXIV, Michael Niedermayer a écrit : >> iam with whatever default people prefer > > IIRC, the current default yields different results when rematrixing from > float to float and then converting from float to int th

Re: [FFmpeg-devel] [PATCH] web/download: point to the official Debian/Ubuntu packages

2015-11-07 Thread Andreas Cadhalpun
On 07.11.2015 03:39, Timothy Gu wrote: > On Fri, Nov 06, 2015 at 08:18:39PM +0100, Andreas Cadhalpun wrote: > [...] >> diff --git a/src/download b/src/download >> index 5691fbd..6d3517e 100644 >> --- a/src/download >> +++ b/src/download >> @@ -53,13 +53,22 @@ >> >> Linux Packages >>

[FFmpeg-devel] [PATCHv2] ffserver: fix incorrect strlcpy usage

2015-11-07 Thread Ganesh Ajjanagadde
Somewhat ironic that this "safe" interface is actually being used unsafely here. This fixes the usage preventing potential null pointer dereference, where the old code was doubly broken: ctime can return NULL, and ctime can return an arbitrarily long buffer. Signed-off-by: Ganesh Ajjanagadde ---

Re: [FFmpeg-devel] [PATCH] jvdec: avoid unsized overflow in comparison

2015-11-07 Thread Andreas Cadhalpun
On 07.11.2015 06:07, Paul B Mahol wrote: > On 11/6/15, Andreas Cadhalpun wrote: >> The return type of strlen is size_t, i.e. unsigned, so if pd->buf_size >> is 3, the right side overflows leading to a wrong result of the >> comparison and subsequently a heap buffer overflow. >> >> Signed-off-by: A

Re: [FFmpeg-devel] [PATCH] apng: use correct size for output buffer

2015-11-07 Thread Andreas Cadhalpun
On 07.11.2015 00:17, wm4 wrote: > On Fri, 6 Nov 2015 23:56:52 +0100 > Andreas Cadhalpun wrote: >> Attached is a patch increasing the buffer size to 10 and >> adding an assert that s->bpp is not larger. > > I'm find with this, though I'm not (A)PNG maintainer. On 07.11.2015 06:03, Paul B Mahol wr

Re: [FFmpeg-devel] [PATCH] hevc: extract SEI caption data

2015-11-07 Thread Michael Niedermayer
On Fri, Nov 06, 2015 at 02:48:46PM -0600, Will Kelleher wrote: > Signed-off-by: Will Kelleher > --- > libavcodec/hevc.c | 10 +++ > libavcodec/hevc.h | 4 +++ > libavcodec/hevc_sei.c | 80 > +++ > 3 files changed, 94 insertions(+) app