[FFmpeg-devel] [PATCH] fix nvenc potential profile error when encoding yuv444p

--- libavcodec/nvenc.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 0e6ef43..083e494 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -912,6 +912,11 @@ static av_cold int nvenc_encode_init(AVCodecContext *avctx

[FFmpeg-devel] [PATCH] fix nvenc potential profile error when encoding yuv444p

--- libavcodec/nvenc.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 0e6ef43..083e494 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -912,6 +912,11 @@ static av_cold int nvenc_encode_init(AVCodecContext *avctx)

Re: [FFmpeg-devel] [PATCH] avutil/avstring: add av_warn_unused_result

On Thu, Oct 15, 2015 at 6:05 PM, Ganesh Ajjanagadde wrote: > Signed-off-by: Ganesh Ajjanagadde > --- > libavutil/avstring.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavutil/avstring.h b/libavutil/avstring.h > index a306e89..a46d012 100644 > --- a/libavutil/avstring.h > +++ b/

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

On Tue, Oct 27, 2015 at 10:41 PM, Ronald S. Bultje wrote: > Hi, > > On Tue, Oct 27, 2015 at 8:53 PM, Ganesh Ajjanagadde > wrote: >> >> ISO C restricts enumerator values to the range of int. Thus (for instance) >> 0x8000 >> unfortunately does not work, and throws a warning with -Wpedantic on >

[FFmpeg-devel] [PATCH] avcodec/motion_est_template: replace qsort with AV_QSORT

This code is in a performance critical section. AV_QSORT is substantially faster due to the inlining of the comparison callback. Thus, the increase in performance is worth the increase in binary size. Signed-off-by: Ganesh Ajjanagadde --

[FFmpeg-devel] [PATCH 2/2] lavf/dump + lavfi/vf_showinfo: use av_stereo3d formatting functions

--- libavfilter/vf_showinfo.c | 18 ++ libavformat/dump.c| 34 ++ 2 files changed, 4 insertions(+), 48 deletions(-) diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c index 5125944..9a3708c 100644 --- a/libavfilter/vf_showinf

[FFmpeg-devel] [PATCH 1/2] lavu/stereo3d: add serialization and deserialization functions

--- doc/APIchanges | 3 + libavutil/Makefile | 1 + libavutil/stereo3d.c | 144 +++ libavutil/stereo3d.h | 70 +++ libavutil/version.h | 2 +- tests/fate/libavutil.mak | 4 ++ tests/ref/fate/stere

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

Hi, On Tue, Oct 27, 2015 at 8:53 PM, Ganesh Ajjanagadde wrote: > ISO C restricts enumerator values to the range of int. Thus (for instance) > 0x8000 > unfortunately does not work, and throws a warning with -Wpedantic on > clang 3.7. > > This fixes it by using alternative expressions that res

Re: [FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

On Tue, Oct 27, 2015 at 08:53:39PM -0400, Ganesh Ajjanagadde wrote: > ISO C restricts enumerator values to the range of int. Thus (for instance) > 0x8000 > unfortunately does not work, and throws a warning with -Wpedantic on > clang 3.7. > > This fixes it by using alternative expressions that

Re: [FFmpeg-devel] [PATCH 2/3] lavc/mjpegdec: honor skip_frame option

On Tue, Oct 27, 2015 at 11:15:29PM +0100, Matthieu Bouron wrote: > On Sun, Oct 18, 2015 at 11:06:50AM +0200, Matthieu Bouron wrote: > [...] > > > > Patch updated, the markers are now properly skipped (which also fixes a > > crash). > > Patch updated. It fixes an issue with mjpeg streams (and in p

[FFmpeg-devel] [PATCH][RFC] avcodec/aacsbr_template: replace qsort with AV_QSORT

When sbr->reset is set in encode_frame, a bunch of qsort calls might get made. Thus, there is the potential of calling qsort whenever the spectral contents change. AV_QSORT is substantially faster due to the inlining of the comparison callback. Thus, the increase in performance should be worth the

Re: [FFmpeg-devel] [PATCH] avfilter/avf_showcqt: rewrite showcqt and add features

On Mon, Oct 26, 2015 at 12:32:58AM +0700, Muhammad Faiz wrote: > On Sun, Oct 25, 2015 at 9:51 AM, Michael Niedermayer > wrote: > > On Sun, Oct 25, 2015 at 08:43:07AM +0700, Muhammad Faiz wrote: > >> doc/filters.texi | 181 +++-- > >> libavfilter/avf_showcqt.c | 1546 > >> ++

[FFmpeg-devel] [PATCHv2] all: fix enum definition for large values

ISO C restricts enumerator values to the range of int. Thus (for instance) 0x8000 unfortunately does not work, and throws a warning with -Wpedantic on clang 3.7. This fixes it by using alternative expressions that result in identical values but do not have this issue. Tested with FATE. Sign

[FFmpeg-devel] [PATCH] ffprobe: move abort() call to after the print statements

This fixes warning C4702 "unreachable code" reported in MSVC: http://fate.ffmpeg.org/log.cgi?time=20151026165907&log=compile&slot=x86_64-msvc12-windows-native, and also likely fixes the intended behavior. Signed-off-by: Ganesh Ajjanagadde --- ffprobe.c | 2 +- 1 file changed, 1 insertion(+), 1 d

[FFmpeg-devel] [PATCH] avutil/mathematics: correct documentation for av_gcd

av_gcd is now always defined regardless of input. This documents this change in the "documented API". Two benefits (closely related): 1. The function is robust, and there is no need to worry about INT64_MIN, etc. 2. Clients of av_gcd, like av_reduce, can now be made fully correct. Currently, av_re

[FFmpeg-devel] [PATCH] avdevice/dshow_enummediatypes: check return of av_malloc

Untested. Signed-off-by: Ganesh Ajjanagadde --- libavdevice/dshow_enummediatypes.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavdevice/dshow_enummediatypes.c b/libavdevice/dshow_enummediatypes.c index 5b69a5b..5a24870 100644 --- a/libavdevice/dshow_enummediatypes.c +++ b/libavdevi

Re: [FFmpeg-devel] [PATCH] Use ff_thread_once() to initialize sin/cos static tables.

On Tue, Oct 27, 2015 at 10:14:49AM +0100, wm4 wrote: > On Mon, 26 Oct 2015 13:15:39 -0700 > Dale Curtis wrote: > > > On Sun, Oct 25, 2015 at 4:56 AM, Ronald S. Bultje > > wrote: > > > > > > So this is likely because we init all tables instead of just these that we > > > need, right? So how about

[FFmpeg-devel] [PATCH] avutil/ripemd: make rol macro more robust by adding parentheses

This ensures that the macro remains correct in the sense of allowing expressions for value and bits, by placing the value and bits expressions within parentheses. Signed-off-by: Ganesh Ajjanagadde --- libavutil/ripemd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavuti

[FFmpeg-devel] [PATCH] avformat/rtpdec_mpa_robust: change assignment to equality test in conditional

In the spirit of commit 8199908fdf9b3797cceaea9d1e2fc09d02ef7309, likely typo originally. Found by enabling -Wparentheses on clang 3.7 and running a manual audit. To the best of my knowledge, no such instances remain. Signed-off-by: Ganesh Ajjanagadde --- libavformat/rtpdec_mpa_robust.c | 2 +-

Re: [FFmpeg-devel] [PATCH 3/3] swscale: rename sws_rgb2rgb_init to ff_sws_rgb2rgb_init

On Tue, Oct 27, 2015 at 11:11:09PM +0100, Andreas Cadhalpun wrote: > It is an internal swscale function and thus should not be exported. > > Signed-off-by: Andreas Cadhalpun > --- > libswscale/colorspace-test.c | 2 +- > libswscale/rgb2rgb.c | 2 +- > libswscale/rgb2rgb.h | 2 +-

Re: [FFmpeg-devel] [PATCH 2/3] swscale: rename sws_context_class to ff_sws_context_class

On Tue, Oct 27, 2015 at 11:10:58PM +0100, Andreas Cadhalpun wrote: > It is an internal swscale symbol and thus should not be exported. > > Signed-off-by: Andreas Cadhalpun > --- > libswscale/options.c | 4 ++-- > libswscale/swscale_internal.h | 2 +- > libswscale/utils.c| 2

[FFmpeg-devel] [PATCH] ff_getnameinfo: fix struct servent dependancy

Hi, This is a patch for ff_getnameinfo. On systems lacking getservbyport, struct servent might not be defined, causing a compilation error when trying to access its member s_name (ent->s_name). There is no point in keeping the if(ent) branch when getservbyport is not available. I am not really sur

Re: [FFmpeg-devel] [PATCH]lavc/cdg: Add transparency

On Mon, Oct 26, 2015 at 11:32:37AM +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached patch implements transparency for cdg files, reproducible with > our fate sample. > > Please comment, Carl Eugen > libavcodec/cdgraphics.c |8 > tests/fate/video.mak |2 > tests/ref/fate/cdgra

Re: [FFmpeg-devel] [PATCH 2/3] lavc/mjpegdec: honor skip_frame option

On Sun, Oct 18, 2015 at 11:06:50AM +0200, Matthieu Bouron wrote: [...] > > Patch updated, the markers are now properly skipped (which also fixes a > crash). Patch updated. It fixes an issue with mjpeg streams (and in particular with the fate sample ffmpeg-issue-897.avi) due to the EOI marker not

[FFmpeg-devel] [PATCH 3/3] swscale: rename sws_rgb2rgb_init to ff_sws_rgb2rgb_init

It is an internal swscale function and thus should not be exported. Signed-off-by: Andreas Cadhalpun --- libswscale/colorspace-test.c | 2 +- libswscale/rgb2rgb.c | 2 +- libswscale/rgb2rgb.h | 2 +- libswscale/utils.c | 2 +- 4 files changed, 4 insertions(+), 4 deletio

[FFmpeg-devel] [PATCH 2/3] swscale: rename sws_context_class to ff_sws_context_class

It is an internal swscale symbol and thus should not be exported. Signed-off-by: Andreas Cadhalpun --- libswscale/options.c | 4 ++-- libswscale/swscale_internal.h | 2 +- libswscale/utils.c| 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libswscale/opt

[FFmpeg-devel] [PATCH 1/3] swscale: rename sws_alloc_set_opts to ff_sws_alloc_set_opts

It is an internal swscale function and thus should not be exported. Signed-off-by: Andreas Cadhalpun --- libswscale/swscale_internal.h | 2 +- libswscale/utils.c| 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/libswscale/swscale_internal.h b/libswscale

Re: [FFmpeg-devel] [PATCH] avcodec: install avdct.h as public header

On 27.10.2015 22:18, Ronald S. Bultje wrote: > On Tue, Oct 27, 2015 at 4:24 PM, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com> wrote: > >> The commit 932ff70 introducing this header mentions it should be public. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> libavcodec/Makefile | 1 +

Re: [FFmpeg-devel] [PATCH] avformat: stop exporting ffurl_read_complete, ffurl_seek and ffurl_size

On 27.10.2015 22:04, Hendrik Leppkes wrote: > On Tue, Oct 27, 2015 at 9:58 PM, Andreas Cadhalpun > wrote: >> They are not in public headers and not used outside of libavformat. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> >> It's been a year since the last attempt to remove these [1]. >> Bad

Re: [FFmpeg-devel] [PATCH] avcodec: install avdct.h as public header

Hi, On Tue, Oct 27, 2015 at 4:24 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > The commit 932ff70 introducing this header mentions it should be public. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/

Re: [FFmpeg-devel] [PATCH] avformat: stop exporting ffurl_read_complete, ffurl_seek and ffurl_size

On Tue, Oct 27, 2015 at 9:58 PM, Andreas Cadhalpun wrote: > They are not in public headers and not used outside of libavformat. > > Signed-off-by: Andreas Cadhalpun > --- > > It's been a year since the last attempt to remove these [1]. > Bad enough that ffserver still uses private functions, but

[FFmpeg-devel] [PATCH] avformat: stop exporting ffurl_read_complete, ffurl_seek and ffurl_size

They are not in public headers and not used outside of libavformat. Signed-off-by: Andreas Cadhalpun --- It's been a year since the last attempt to remove these [1]. Bad enough that ffserver still uses private functions, but keeping even more in the ABI for some unnamed third party applications

[FFmpeg-devel] [PATCH] avcodec: install avdct.h as public header

The commit 932ff70 introducing this header mentions it should be public. Signed-off-by: Andreas Cadhalpun --- libavcodec/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index 38152f7..5f38ebb 100644 --- a/libavcodec/Makefile +++ b/libavcodec

Re: [FFmpeg-devel] [PATCH] lavu/stereo3d: add serialization and deserialization functions

On 10/27/2015 5:35 AM, Rodger Combs wrote: > >> On Oct 26, 2015, at 15:01, James Almer wrote: >> >> On 10/26/2015 4:45 PM, Rodger Combs wrote: >>> diff --git a/libavutil/stereo3d.h b/libavutil/stereo3d.h >>> index 1135dc9..8b8aced 100644 >>> --- a/libavutil/stereo3d.h >>> +++ b/libavutil/stereo3d

Re: [FFmpeg-devel] [PATCH] fate: add mpdecimate test.

On Sun, Oct 25, 2015 at 08:58:09PM +0100, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > tests/fate/filter-video.mak | 3 +++ > tests/ref/fate/filter-mpdecimate | 21 + > 2 files changed, 24 insertions(+) > create mode 100644 tests/ref/fate/filter-mpdecim

Re: [FFmpeg-devel] [PATCH 1/1] avcodec/png: read and write stereo3d frame side data information

On Thu, Oct 22, 2015 at 11:50 PM, Kirill Gavrilov wrote: > Use optional sTER chunk defining side-by-side stereo pair > within "Extensions to the PNG 1.2 Specification", version 1.3.0. > Please let me know if someone from maintainers has reviewed my patch. Regards, Kirill

Re: [FFmpeg-devel] [PATCH 05/12] lavu/aes: test CBC functionality

On Mon, Oct 26, 2015 at 03:25:47AM -0500, Rodger Combs wrote: > --- > libavutil/aes.c | 14 +- > 1 file changed, 9 insertions(+), 5 deletions(-) > > diff --git a/libavutil/aes.c b/libavutil/aes.c > index 4fa01ea..4b871a0 100644 > --- a/libavutil/aes.c > +++ b/libavutil/aes.c > @@ -280

Re: [FFmpeg-devel] [PATCH 06/12] lavu/aes: add x86 AESNI optimizations

On Mon, Oct 26, 2015 at 03:25:48AM -0500, Rodger Combs wrote: > crypto_bench comparison for AES-128-ECB: > > lavu_aesni AES-128-ECB size: 1048576 runs: 1024 time:0.596 +- 0.081 > lavu_c AES-128-ECB size: 1048576 runs: 1024 time: 17.007 +- 2.131 > crypto AES-128-ECB size: 1

Re: [FFmpeg-devel] [PATCH 03/12] lavu/aes: add runtime dispatch for crypt function

On Mon, Oct 26, 2015 at 03:25:45AM -0500, Rodger Combs wrote: > --- > libavutil/aes.c | 47 +++ > libavutil/aes_internal.h | 1 + > 2 files changed, 32 insertions(+), 16 deletions(-) > > diff --git a/libavutil/aes.c b/libavutil/aes.c > index 6

Re: [FFmpeg-devel] [PATCH 04/12] lavu/aes: align AVAES struct members

On Mon, Oct 26, 2015 at 03:25:46AM -0500, Rodger Combs wrote: > --- > libavutil/aes_internal.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) LGTM thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The greatest way to live with honor in this

Re: [FFmpeg-devel] [PATCH 02/12] lavu/aes: move AVAES to separate internal header

On Mon, Oct 26, 2015 at 03:25:44AM -0500, Rodger Combs wrote: > --- > libavutil/aes.c | 16 +--- > libavutil/aes_internal.h | 41 + > 2 files changed, 42 insertions(+), 15 deletions(-) > create mode 100644 libavutil/aes_internal.h LGTM

Re: [FFmpeg-devel] [PATCH 01/12] lavu: add AESNI CPU flag

On Mon, Oct 26, 2015 at 03:25:43AM -0500, Rodger Combs wrote: > --- > configure | 4 > doc/APIchanges| 3 +++ > libavutil/cpu.c | 4 > libavutil/cpu.h | 1 + > libavutil/version.h | 2 +- > libavutil/x86/cpu.c | 2 ++ > li

Re: [FFmpeg-devel] [PATCH] ffmpeg_filter: check encoder before using it to set frame size.

On Sun, Oct 25, 2015 at 07:50:58PM +0100, Nicolas George wrote: > Fix a segfault when no encoder is found for a default codec > with a complex filter graph. > > Signed-off-by: Nicolas George > --- > ffmpeg_filter.c | 7 +++ > 1 file changed, 7 insertions(+) LGTM thanks [...] -- Michael

Re: [FFmpeg-devel] [PATCH] Update Cookies on Setcookie playlist response

Here is the patch to backport it to release/2.8. To be fixed on 2.8.2. Anything else I should do? ps. Sorry, that's my first time on opensource project, I'm a little confused that I needed to add it to the release branch. b3f3eab029eb429660fc1651a33dafe097cbac0e.patch Description: Binary data __

Re: [FFmpeg-devel] [PATCH] fix: assigning instead of comparing

On Mon, Oct 26, 2015 at 08:21:07PM +0300, AppChecker wrote: > Signed-off-by: AppChecker > --- > libavformat/webmdashenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Freedom in capital

Re: [FFmpeg-devel] [PATCH] doc/filters.texi: ebur128 grammar fix

On Mon, Oct 26, 2015 at 09:40:46PM -0800, Lou Logan wrote: > On Mon, Oct 26, 2015, at 02:44 PM, Kyle Swanson wrote: > > --- > > doc/filters.texi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/doc/filters.texi b/doc/filters.texi > > index 1de6a2f..2914e40 100644 > >

Re: [FFmpeg-devel] [PATCH] avcodec: disallow hwaccel with frame threads

On Mon, Oct 26, 2015 at 1:49 AM, Ronald S. Bultje wrote: > Hi, > > On Sun, Oct 25, 2015 at 5:55 PM, Hendrik Leppkes > wrote: > >> On Fri, Oct 23, 2015 at 1:54 PM, Hendrik Leppkes >> wrote: >> > HWAccels with frame threads are fundamentally flawed in avcodecs current >> > design, and there are se

Re: [FFmpeg-devel] [PATCH] Use ff_thread_once() to initialize sin/cos static tables.

On Mon, 26 Oct 2015 13:15:39 -0700 Dale Curtis wrote: > On Sun, Oct 25, 2015 at 4:56 AM, Ronald S. Bultje > wrote: > > > > So this is likely because we init all tables instead of just these that we > > need, right? So how about having one ff_once per table? That should be > > trivial to implemen

Re: [FFmpeg-devel] [PATCH 2/2] lavfi: add testsrc2 test source.

On Mon, Oct 26, 2015 at 11:31:58PM +0100, Nicolas George wrote: > Le quintidi 5 brumaire, an CCXXIV, Clement Boesch a écrit : > > Same. I also think the noise could get some improvement with a wider > > color spectrum. > > I agree, but unfortunately, there is no drawutils API to blend a colored >

Re: [FFmpeg-devel] [PATCH] lavu/stereo3d: add serialization and deserialization functions

> On Oct 26, 2015, at 15:01, James Almer wrote: > > On 10/26/2015 4:45 PM, Rodger Combs wrote: >> diff --git a/libavutil/stereo3d.h b/libavutil/stereo3d.h >> index 1135dc9..8b8aced 100644 >> --- a/libavutil/stereo3d.h >> +++ b/libavutil/stereo3d.h >> @@ -149,4 +149,51 @@ AVStereo3D *av_stereo3d_