Re: [FFmpeg-devel] [PATCH] avcodec/mips: MSA (MIPS-SIMD-Arch) optimizations for VP8 functions

2015-08-03 Thread Shivraj Patil
Hi, On Mon, Jul 27, 2015 at 6:01 AM, mailto:shivraj.pa...@imgtec.com>> wrote: +++ b/libavcodec/mips/vp8dsp_init_mips.c Is there a reason the init code lives in a different file than the implementations? It seems to me all symbols could be static if the init code lived in the same file as the

Re: [FFmpeg-devel] [libav-devel] [PATCH 0/20] removal of deprecated features

2015-08-03 Thread Reimar Döffinger
On 31.07.2015, at 17:47, Nicolas George wrote: > I can propose the following middle term: I do have on more proposal, but the problem is it needs someone to do the work. For each removed feature, prepare documentation "a monkey could follow" on how to replace it (you could call it a transition g

[FFmpeg-devel] [PATCH 3/3] MAINTAINERS: Add myself to vdpau maintainers

2015-08-03 Thread Philip Langdale
Signed-off-by: Philip Langdale --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index da02165..b0d0dc7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -304,7 +304,7 @@ Hardware acceleration: libstagefright.cppMoha

[FFmpeg-devel] [PATCH 2/3] avcodec/vdpau_hevc: Properly signal the num_delta_pocs from the SPS RPS

2015-08-03 Thread Philip Langdale
This is the same fix that Hendrik made to dxva2_hevc. It should be equally required here, although I don't see any visual difference. Nevertheless, best to stay consistent. Signed-off-by: Philip Langdale --- libavcodec/vdpau_hevc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[FFmpeg-devel] [PATCH 1/3] avcodec/vdpau_hevc: Remove experimental flag

2015-08-03 Thread Philip Langdale
The latest nvidia 355.06 drivers fixes the interleaving bug when video surfaces are rendered. It still seems to be broken for read-back with getBits but that's sufficiently uninteresting that I don't think we need to wait for it to remove the flag. Signed-off-by: Philip Langdale --- libavcodec/v

[FFmpeg-devel] [PATCH 0/3] Some VDPAU HEVC stuff

2015-08-03 Thread Philip Langdale
With the latest nvidia driver update, HEVC decoding basically works now. Philip Langdale (3): avcodec/vdpau_hevc: Remove experimental flag avcodec/vdpau_hevc: Properly signal the num_delta_pocs from the SPS RPS MAINTAINERS: Add myself to vdpau maintainers MAINTAINERS | 3 ++

Re: [FFmpeg-devel] [PATCH] movtextdec.c: Add support for font names

2015-08-03 Thread Philip Langdale
On Fri, 31 Jul 2015 19:25:58 +0530 Niklesh Lalwani wrote: > From: Niklesh > > The font names are extracted from the font table, present in text > sample entry. More than one fonts can be present, which is taken care > of in the patch. > > Signed-off-by: Niklesh > --- > libavcodec/movtextdec.

Re: [FFmpeg-devel] QSV Decoding - Issues and Regressions

2015-08-03 Thread Ronald S. Bultje
Hi Ivan, On Mon, Aug 3, 2015 at 4:50 PM, Ivan Uskov wrote: > Hello Ronald, > > Monday, August 3, 2015, 11:37:22 PM, you wrote: > > RSB> On Mon, Aug 3, 2015 at 3:25 PM, Ivan Uskov > wrote: > > >> By the way, about old implementation which "worked fine". > >> It just did drop all buffered frames

Re: [FFmpeg-devel] [PATCH] libavformat/matroskadec.c: Parse stream durations set by mkvmerge and populate them in AVStream.

2015-08-03 Thread Sasi Inguva
Ok. i'll drop this patch . Does outputting stream DURATION values in matroskaenc.c as string tag's , (same as mkvmerge does ) seem ok? Atleast then, I can parse those string metadata in our own video pipeline which will solve my use case. On Sat, Aug 1, 2015 at 11:42 AM, wm4 wrote: > On Sat,

Re: [FFmpeg-devel] [PATCH] avfilter: add convolution filter

2015-08-03 Thread Lou Logan
On Sun, 2 Aug 2015 17:35:59 +0200, Paul B Mahol wrote: [...] > +@item 0rdiv > +@item 1rdiv > +@item 2rdiv > +@item 3rdiv > +Set multiplicator for calculated value for each plane. "Default is 1.0." Can you use the word "multiplier" instead? Mentioning range would be helpful, if possible. > +@

Re: [FFmpeg-devel] [PATCH] avcodec/internal: improve min_size documentation for ff_alloc_packet2()

2015-08-03 Thread Michael Niedermayer
On Tue, Aug 04, 2015 at 12:57:38AM +0200, wm4 wrote: > On Tue, 4 Aug 2015 00:51:17 +0200 > Michael Niedermayer wrote: > > > On Tue, Aug 04, 2015 at 12:12:24AM +0200, wm4 wrote: > > > > > As well as benchmark results in some commits like > > > > 4302a92835313000d4bf8030baae32c2b130d8a1 > > > > >

[FFmpeg-devel] [PATCH] ffplay: do not block audio thread on WIN32

2015-08-03 Thread Marton Balint
The windows SDL audio driver plays the old data in the buffer in a loop if it is not updated in time. So instead of waiting for data and blocking the the audio thread, return silence if no data is available. Should fix ticket #2289. Signed-off-by: Marton Balint --- ffplay.c | 7 +++ 1 file

Re: [FFmpeg-devel] [PATCH] avcodec/internal: improve min_size documentation for ff_alloc_packet2()

2015-08-03 Thread wm4
On Tue, 4 Aug 2015 00:51:17 +0200 Michael Niedermayer wrote: > On Tue, Aug 04, 2015 at 12:12:24AM +0200, wm4 wrote: > > > As well as benchmark results in some commits like > > > 4302a92835313000d4bf8030baae32c2b130d8a1 > > > > avcodec/pcm: Better min_size for ff_alloc_packet2() > > > >

Re: [FFmpeg-devel] [PATCH] avcodec/internal: improve min_size documentation for ff_alloc_packet2()

2015-08-03 Thread Michael Niedermayer
On Tue, Aug 04, 2015 at 12:12:24AM +0200, wm4 wrote: > On Mon, 3 Aug 2015 22:59:48 +0200 > Michael Niedermayer wrote: > > > On Mon, Aug 03, 2015 at 10:05:23PM +0200, wm4 wrote: > > > On Mon, 3 Aug 2015 19:17:16 +0200 > > > Michael Niedermayer wrote: > > > > > > > From: Michael Niedermayer > >

[FFmpeg-devel] [PATCH] x86/sbrdsp: remove an unnecessary mova in sbr_autocorrelate

2015-08-03 Thread James Almer
Signed-off-by: James Almer --- libavcodec/x86/sbrdsp.asm | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/libavcodec/x86/sbrdsp.asm b/libavcodec/x86/sbrdsp.asm index 083461a..a96451f 100644 --- a/libavcodec/x86/sbrdsp.asm +++ b/libavcodec/x8

Re: [FFmpeg-devel] [PATCH] avcodec/internal: improve min_size documentation for ff_alloc_packet2()

2015-08-03 Thread wm4
On Mon, 3 Aug 2015 22:59:48 +0200 Michael Niedermayer wrote: > On Mon, Aug 03, 2015 at 10:05:23PM +0200, wm4 wrote: > > On Mon, 3 Aug 2015 19:17:16 +0200 > > Michael Niedermayer wrote: > > > > > From: Michael Niedermayer > > > > > > Signed-off-by: Michael Niedermayer > > > --- > > > libavc

Re: [FFmpeg-devel] [PATCH] avcodec/internal: improve min_size documentation for ff_alloc_packet2()

2015-08-03 Thread Michael Niedermayer
On Mon, Aug 03, 2015 at 11:45:51PM +0200, Michael Niedermayer wrote: > On Mon, Aug 03, 2015 at 10:45:52PM +0200, wm4 wrote: > > On Mon, 3 Aug 2015 17:33:15 -0300 > > James Almer wrote: > > > > > On 03/08/15 5:05 PM, wm4 wrote: > > > > - we'll probably see a flood of commits changing random encode

Re: [FFmpeg-devel] [PATCH] avcodec/internal: improve min_size documentation for ff_alloc_packet2()

2015-08-03 Thread Michael Niedermayer
On Mon, Aug 03, 2015 at 10:45:52PM +0200, wm4 wrote: > On Mon, 3 Aug 2015 17:33:15 -0300 > James Almer wrote: > > > On 03/08/15 5:05 PM, wm4 wrote: > > > - we'll probably see a flood of commits changing random encoders to > > > this new function, for no reason (I'm looking forward to be proven

Re: [FFmpeg-devel] [PATCH]lavf/mov: Support alac extradata in wave atom

2015-08-03 Thread Carl Eugen Hoyos
Michael Niedermayer niedermayer.cc> writes: > > But this should not be necessary if somebody > > can confirm that it is ok to seek back x bytes > > in a demuxer. > > it is safe if ffio_ensure_seekback() is used with > appropriate arguments before these x bytes are read > (or the stream is see

Re: [FFmpeg-devel] [PATCH]lavf/mov: Support alac extradata in wave atom

2015-08-03 Thread Carl Eugen Hoyos
Carl Eugen Hoyos ag.or.at> writes: > Attached patch fixes ticket #4747 for me, I don't know how to > detect that the wave atom contains no frma / alac atom... New patch sent that detects and skips the frma atom or reads the extradata if no frma atom is present. Carl Eugen

[FFmpeg-devel] [PATCH]lavf/mov: Support alac extradata in wave atom v2

2015-08-03 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #4747 and should not introduce any theoretical regressions. Please review, Carl Eugendiff --git a/libavformat/mov.c b/libavformat/mov.c index 154d2f8..f3cb71f 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -1435,6 +1435,28 @@ static int mov_read_wave(MO

Re: [FFmpeg-devel] [PATCH] avcodec/internal: improve min_size documentation for ff_alloc_packet2()

2015-08-03 Thread Michael Niedermayer
On Mon, Aug 03, 2015 at 10:05:23PM +0200, wm4 wrote: > On Mon, 3 Aug 2015 19:17:16 +0200 > Michael Niedermayer wrote: > > > From: Michael Niedermayer > > > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/internal.h |9 +++-- > > 1 file changed, 7 insertions(+), 2 deletion

Re: [FFmpeg-devel] QSV Decoding - Issues and Regressions

2015-08-03 Thread Ivan Uskov
Hello Ronald, Monday, August 3, 2015, 11:37:22 PM, you wrote: RSB> On Mon, Aug 3, 2015 at 3:25 PM, Ivan Uskov wrote: >> By the way, about old implementation which "worked fine". >> It just did drop all buffered frames at decoder re-init on new >> sequence header, there is nice comment inside ol

Re: [FFmpeg-devel] [PATCH] avcodec/internal: improve min_size documentation for ff_alloc_packet2()

2015-08-03 Thread wm4
On Mon, 3 Aug 2015 17:33:15 -0300 James Almer wrote: > On 03/08/15 5:05 PM, wm4 wrote: > > - we'll probably see a flood of commits changing random encoders to > > this new function, for no reason (I'm looking forward to be proven > > wrong) > > ff_alloc_packet() is marked as deprecated. I wo

Re: [FFmpeg-devel] QSV Decoding - Issues and Regressions

2015-08-03 Thread Ronald S. Bultje
Hi, On Mon, Aug 3, 2015 at 3:25 PM, Ivan Uskov wrote: > By the way, about old implementation which "worked fine". > It just did drop all buffered frames at decoder re-init on new > sequence header, there is nice comment inside old qsvdec_h264.c: > /* TODO: flush delayed frames on reinit */ Eac

Re: [FFmpeg-devel] [PATCH] avcodec/internal: improve min_size documentation for ff_alloc_packet2()

2015-08-03 Thread James Almer
On 03/08/15 5:05 PM, wm4 wrote: > - we'll probably see a flood of commits changing random encoders to > this new function, for no reason (I'm looking forward to be proven > wrong) ff_alloc_packet() is marked as deprecated. I wouldn't find it odd at all if maintainers for different encoders mak

Re: [FFmpeg-devel] [PATCH] x86: move XOP emulation code back to x86inc

2015-08-03 Thread James Almer
On 03/08/15 7:27 AM, Ronald S. Bultje wrote: > Hi, > > On Mon, Aug 3, 2015 at 2:41 AM, James Almer wrote: > >> Only two functions that use xop multiply-accumulate instructions where the >> first operand is the same as the fourth actually took advantage of the >> macros. >> >> This further reduce

Re: [FFmpeg-devel] [PATCH] ffmpeg: avoid scanf in keyboard command parsing

2015-08-03 Thread Hendrik Leppkes
On Mon, Aug 3, 2015 at 10:12 PM, Nicolas George wrote: > Le sextidi 16 thermidor, an CCXXIII, Hendrik Leppkes a écrit : >> Mixing stdio and low-level IO on stdin is not safe. >> --- >> ffmpeg.c | 12 ++-- >> 1 file changed, 10 insertions(+), 2 deletions(-) >> >> diff --git a/ffmpeg.c b/ff

Re: [FFmpeg-devel] [PATCH] ffmpeg: avoid scanf in keyboard command parsing

2015-08-03 Thread Nicolas George
Le sextidi 16 thermidor, an CCXXIII, Hendrik Leppkes a écrit : > Mixing stdio and low-level IO on stdin is not safe. > --- > ffmpeg.c | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/ffmpeg.c b/ffmpeg.c > index 5575e2f..206b3dc 100644 > --- a/ffmpeg.c > +++ b

Re: [FFmpeg-devel] [PATCH 2/2] libavformat/dsfdec: Error dsf_read_header fixed.

2015-08-03 Thread Michael Niedermayer
On Sat, Aug 01, 2015 at 11:29:05AM +1000, Peter Ross wrote: > On Fri, Jul 31, 2015 at 08:56:49PM -0400, Ganesh Ajjanagadde wrote: > > On Fri, Jul 31, 2015 at 8:08 PM, Michael Niedermayer > > wrote: > > > On Fri, Jul 31, 2015 at 07:33:01PM -0400, Ganesh Ajjanagadde wrote: > > >> On Fri, Jul 31, 201

Re: [FFmpeg-devel] [PATCH] avcodec/internal: improve min_size documentation for ff_alloc_packet2()

2015-08-03 Thread wm4
On Mon, 3 Aug 2015 19:17:16 +0200 Michael Niedermayer wrote: > From: Michael Niedermayer > > Signed-off-by: Michael Niedermayer > --- > libavcodec/internal.h |9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/internal.h b/libavcodec/internal.h >

Re: [FFmpeg-devel] [PATCH][RFC] ffmpeg: remove access to private FILE struct members on Windows

2015-08-03 Thread Hendrik Leppkes
On Mon, Aug 3, 2015 at 9:30 PM, Nicolas George wrote: > Le sextidi 16 thermidor, an CCXXIII, Michael Niedermayer a écrit : >> i also found this comment in a patch in my inbox: >> >> + /* When using Standard C input functions, also check if there >> + is anything in the buffer. After a call to s

[FFmpeg-devel] [PATCH] ffmpeg: avoid scanf in keyboard command parsing

2015-08-03 Thread Hendrik Leppkes
Mixing stdio and low-level IO on stdin is not safe. --- ffmpeg.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/ffmpeg.c b/ffmpeg.c index 5575e2f..206b3dc 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -3428,9 +3428,17 @@ static int check_keyboard_interaction(int64_t cu

Re: [FFmpeg-devel] [PATCH]lavf/mov: Support alac extradata in wave atom

2015-08-03 Thread Michael Niedermayer
On Mon, Aug 03, 2015 at 10:32:02AM +, Carl Eugen Hoyos wrote: > Paul B Mahol gmail.com> writes: > > > > Attached patch fixes ticket #4747 for me, > > > > I don't know how to detect that the wave > > > atom contains no frma / alac atom... > > > > And that is mentioned because? > > The fil

Re: [FFmpeg-devel] [PATCH][RFC] ffmpeg: remove access to private FILE struct members on Windows

2015-08-03 Thread Michael Niedermayer
On Mon, Aug 03, 2015 at 09:30:33PM +0200, Nicolas George wrote: > Le sextidi 16 thermidor, an CCXXIII, Michael Niedermayer a écrit : > > i also found this comment in a patch in my inbox: > > > > + /* When using Standard C input functions, also check if there > > + is anything in the buffer. Aft

[FFmpeg-devel] [PATCH] api-h264-test: structure changes

2015-08-03 Thread Ludmila Glinskih
To avoid duplicate code --- tests/api/api-h264-test.c | 47 +++ 1 file changed, 15 insertions(+), 32 deletions(-) diff --git a/tests/api/api-h264-test.c b/tests/api/api-h264-test.c index 4d2a5b0..e4bc0b8 100644 --- a/tests/api/api-h264-test.c +++ b/test

Re: [FFmpeg-devel] QSV Decoding - Issues and Regressions

2015-08-03 Thread Ivan Uskov
Hello wm4, Monday, August 3, 2015, 10:33:30 PM, you wrote: w> I was under the impression that the original Libav code handled this w> correctly. Unfortunately not, you can still see this comment at line 371 https://git.libav.org/?p=libav.git;a=blob;f=libavcodec/qsvdec.c and there is no any flush

Re: [FFmpeg-devel] FFmpegs future and resigning as leader

2015-08-03 Thread Michael Niedermayer
On Mon, Aug 03, 2015 at 08:51:10AM +0100, tim nicholson wrote: > On 31/07/15 17:19, Michael Niedermayer wrote: > > On Fri, Jul 31, 2015 at 05:37:12PM +0200, Clément Bœsch wrote: > > [...] > >> So in order for the community to continue this, I'd say we probably need > >> to have some help for: > >>

Re: [FFmpeg-devel] QSV Decoding - Issues and Regressions

2015-08-03 Thread Hendrik Leppkes
On Mon, Aug 3, 2015 at 9:33 PM, wm4 wrote: > On Mon, 3 Aug 2015 22:25:20 +0300 > Ivan Uskov wrote: > >> Hello Michael, Hendrik, >> >> I would like to make sure about following moment regarding handling of >> sequence header changing. The decoder has buffering of decoded frames, >> so when new fra

Re: [FFmpeg-devel] QSV Decoding - Issues and Regressions

2015-08-03 Thread wm4
On Mon, 3 Aug 2015 22:25:20 +0300 Ivan Uskov wrote: > Hello Michael, Hendrik, > > I would like to make sure about following moment regarding handling of > sequence header changing. The decoder has buffering of decoded frames, > so when new frame dimensions are detected we can not just reset > de

Re: [FFmpeg-devel] [PATCH][RFC] ffmpeg: remove access to private FILE struct members on Windows

2015-08-03 Thread Nicolas George
Le sextidi 16 thermidor, an CCXXIII, Michael Niedermayer a écrit : > i also found this comment in a patch in my inbox: > > + /* When using Standard C input functions, also check if there > + is anything in the buffer. After a call to such functions, > + the input waiting in the pipe will be c

Re: [FFmpeg-devel] QSV Decoding - Issues and Regressions

2015-08-03 Thread Ivan Uskov
Hello Michael, Hendrik, I would like to make sure about following moment regarding handling of sequence header changing. The decoder has buffering of decoded frames, so when new frame dimensions are detected we can not just reset decoder, we should to deffer re-init and switch decoder to some "fl

Re: [FFmpeg-devel] [PATCH][RFC] ffmpeg: remove access to private FILE struct members on Windows

2015-08-03 Thread Michael Niedermayer
On Mon, Aug 03, 2015 at 07:26:30PM +0200, Michael Niedermayer wrote: > On Mon, Aug 03, 2015 at 05:21:58PM +0200, Nicolas George wrote: > > Le sextidi 16 thermidor, an CCXXIII, Hendrik Leppkes a écrit : > > > The FILE struct is opaque in MSVC 2015, and the members of this struct > > > were never mea

Re: [FFmpeg-devel] [PATCH] avcodec/mips: MSA (MIPS-SIMD-Arch) optimizations for VP8 functions

2015-08-03 Thread Ronald S. Bultje
Hi, On Mon, Jul 27, 2015 at 6:01 AM, wrote: > +++ b/libavcodec/mips/vp8dsp_init_mips.c > Is there a reason the init code lives in a different file than the implementations? It seems to me all symbols could be static if the init code lived in the same file as the implementation. This isn't a big

Re: [FFmpeg-devel] [PATCH 1/4] x86inc: Support arbitrary stack alignments

2015-08-03 Thread James Almer
On 03/08/15 3:25 PM, Hendrik Leppkes wrote: > On Mon, Aug 3, 2015 at 8:21 PM, James Almer wrote: >> On 03/08/15 3:12 PM, Hendrik Leppkes wrote: >>> Since I wasn't sure in which direction of packed/planar the problem >>> usually happened, I tried 8ch s32 -> 8ch s32p, 8ch s32 -> 2ch s32p, >>> 8ch s3

Re: [FFmpeg-devel] [PATCH][RFC] ffmpeg: remove access to private FILE struct members on Windows

2015-08-03 Thread Henrik Gramner
On Mon, Aug 3, 2015 at 5:08 PM, Hendrik Leppkes wrote: > The FILE struct is opaque in MSVC 2015, and the members of this struct > were never meant to be accessed in any case. > > No conditions are known where this check was needed to get characters > from stdin. I can confirm that this patch fixe

Re: [FFmpeg-devel] [PATCH 1/4] x86inc: Support arbitrary stack alignments

2015-08-03 Thread Hendrik Leppkes
On Mon, Aug 3, 2015 at 8:21 PM, James Almer wrote: > On 03/08/15 3:12 PM, Hendrik Leppkes wrote: >> Since I wasn't sure in which direction of packed/planar the problem >> usually happened, I tried 8ch s32 -> 8ch s32p, 8ch s32 -> 2ch s32p, >> 8ch s32p -> 8ch s32 and 8ch s32p -> 2ch s32, and all wor

Re: [FFmpeg-devel] [PATCH 1/4] x86inc: Support arbitrary stack alignments

2015-08-03 Thread James Almer
On 03/08/15 3:12 PM, Hendrik Leppkes wrote: > Since I wasn't sure in which direction of packed/planar the problem > usually happened, I tried 8ch s32 -> 8ch s32p, 8ch s32 -> 2ch s32p, > 8ch s32p -> 8ch s32 and 8ch s32p -> 2ch s32, and all work fine. > > - Hendrik If those tests were done with lib

Re: [FFmpeg-devel] [PATCH 1/4] x86inc: Support arbitrary stack alignments

2015-08-03 Thread Hendrik Leppkes
On Mon, Aug 3, 2015 at 5:26 PM, James Almer wrote: > On 03/08/15 9:50 AM, Hendrik Leppkes wrote: >> On Mon, Aug 3, 2015 at 10:31 AM, Henrik Gramner wrote: >>> On Mon, Aug 3, 2015 at 2:18 AM, Ronald S. Bultje wrote: So, I think the code changes themselves look mostly healthy. Is there a

Re: [FFmpeg-devel] [PATCH][RFC] ffmpeg: remove access to private FILE struct members on Windows

2015-08-03 Thread Hendrik Leppkes
On Mon, Aug 3, 2015 at 7:26 PM, Michael Niedermayer wrote: > On Mon, Aug 03, 2015 at 05:21:58PM +0200, Nicolas George wrote: >> Le sextidi 16 thermidor, an CCXXIII, Hendrik Leppkes a écrit : >> > The FILE struct is opaque in MSVC 2015, and the members of this struct >> > were never meant to be acc

Re: [FFmpeg-devel] [PATCH] doc/git-howto: Replace "git push" example by one with dry-run

2015-08-03 Thread Michael Niedermayer
On Mon, Aug 03, 2015 at 10:26:51AM +, Carl Eugen Hoyos wrote: > Michael Niedermayer gmx.at> writes: > > > -git push > > +git push origin master --dry-run > > Doesn't git push -n also work? yes, i intentionally used the long form as it should be easier to remember and harder to get wrong in

Re: [FFmpeg-devel] [PATCH][RFC] ffmpeg: remove access to private FILE struct members on Windows

2015-08-03 Thread Michael Niedermayer
On Mon, Aug 03, 2015 at 05:21:58PM +0200, Nicolas George wrote: > Le sextidi 16 thermidor, an CCXXIII, Hendrik Leppkes a écrit : > > The FILE struct is opaque in MSVC 2015, and the members of this struct > > were never meant to be accessed in any case. > > > > No conditions are known where this ch

[FFmpeg-devel] [PATCH] avcodec/internal: improve min_size documentation for ff_alloc_packet2()

2015-08-03 Thread Michael Niedermayer
From: Michael Niedermayer Signed-off-by: Michael Niedermayer --- libavcodec/internal.h |9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libavcodec/internal.h b/libavcodec/internal.h index 202f82d..17c86a3 100644 --- a/libavcodec/internal.h +++ b/libavcodec/interna

Re: [FFmpeg-devel] [PATCH 1/4] x86inc: Support arbitrary stack alignments

2015-08-03 Thread James Almer
On 03/08/15 9:50 AM, Hendrik Leppkes wrote: > On Mon, Aug 3, 2015 at 10:31 AM, Henrik Gramner wrote: >> On Mon, Aug 3, 2015 at 2:18 AM, Ronald S. Bultje wrote: >>> So, I think the code changes themselves look mostly healthy. Is there a >>> behavioural difference before/after this patch? (Like: we

Re: [FFmpeg-devel] [PATCH][RFC] ffmpeg: remove access to private FILE struct members on Windows

2015-08-03 Thread Nicolas George
Le sextidi 16 thermidor, an CCXXIII, Hendrik Leppkes a écrit : > The FILE struct is opaque in MSVC 2015, and the members of this struct > were never meant to be accessed in any case. > > No conditions are known where this check was needed to get characters > from stdin. > --- > > If someone does

[FFmpeg-devel] [PATCH][RFC] ffmpeg: remove access to private FILE struct members on Windows

2015-08-03 Thread Hendrik Leppkes
The FILE struct is opaque in MSVC 2015, and the members of this struct were never meant to be accessed in any case. No conditions are known where this check was needed to get characters from stdin. --- If someone does know which particular purpose this check serves, please do let me know, and I'l

Re: [FFmpeg-devel] [PATCH 1/4] x86inc: Support arbitrary stack alignments

2015-08-03 Thread Dewangan, Hitesh Kumar
Hi all, Can you please remove me from this group. Thanks, Hitesh On Aug 3, 2015 2:14 AM, "Henrik Gramner" wrote: > Change ALLOC_STACK to always align the stack before allocating stack space > for > consistency. Previously alignment would occur either before or after > allocating > stack space d

Re: [FFmpeg-devel] [PATCH 1/4] x86inc: Support arbitrary stack alignments

2015-08-03 Thread Ronald S. Bultje
Hi, On Mon, Aug 3, 2015 at 8:50 AM, Hendrik Leppkes wrote: > On Mon, Aug 3, 2015 at 10:31 AM, Henrik Gramner > wrote: > > On Mon, Aug 3, 2015 at 2:18 AM, Ronald S. Bultje > wrote: > >> So, I think the code changes themselves look mostly healthy. Is there a > >> behavioural difference before/af

Re: [FFmpeg-devel] [PATCH] ffmpeg: modify tty state when stderr is redirected

2015-08-03 Thread Nicolas George
Le sextidi 16 thermidor, an CCXXIII, Hendrik Leppkes a écrit : > Trashing the state even more often just because there is one example > where this can already happen is not a valid reasoning. The changes should be applied because they are the RIGHT behaviour, as I explained in this mail: http://f

Re: [FFmpeg-devel] [PATCH] ffmpeg: modify tty state when stderr is redirected

2015-08-03 Thread Ganesh Ajjanagadde
On Mon, Aug 3, 2015 at 10:40 AM, Hendrik Leppkes wrote: > On Mon, Aug 3, 2015 at 4:34 PM, Ganesh Ajjanagadde wrote: >> On Sat, Aug 1, 2015 at 6:54 AM, Nicolas George wrote: >>> Le quartidi 14 thermidor, an CCXXIII, Michael Niedermayer a écrit : > ffmpeg -lavfi testsrc -f framecrc | head >>>

Re: [FFmpeg-devel] [PATCH] ffmpeg: modify tty state when stderr is redirected

2015-08-03 Thread Hendrik Leppkes
On Mon, Aug 3, 2015 at 4:34 PM, Ganesh Ajjanagadde wrote: > On Sat, Aug 1, 2015 at 6:54 AM, Nicolas George wrote: >> Le quartidi 14 thermidor, an CCXXIII, Michael Niedermayer a écrit : >>> > ffmpeg -lavfi testsrc -f framecrc | head >>> Thats interresting, i tried this and it did not trash my term

Re: [FFmpeg-devel] [PATCH] ffmpeg: modify tty state when stderr is redirected

2015-08-03 Thread Ganesh Ajjanagadde
On Sat, Aug 1, 2015 at 6:54 AM, Nicolas George wrote: > Le quartidi 14 thermidor, an CCXXIII, Michael Niedermayer a écrit : >> > ffmpeg -lavfi testsrc -f framecrc | head >> Thats interresting, i tried this and it did not trash my terminal >> also ive almost never seen ffmpeg trash my terminal with

Re: [FFmpeg-devel] QSV Decoding - Issues and Regressions

2015-08-03 Thread Ivan Uskov
Hello Hendrik, Thank you very much for the bugreport, I believe I will able to fix all these issues quick. In general all these issues are known and in my todo list. Monday, August 3, 2015, 3:18:04 PM, you wrote: HL> Hey, HL> after a discussion on IRC about the declining quality of the QSV HL

Re: [FFmpeg-devel] [PATCH] QSV MJPEG video decoder has been added.

2015-08-03 Thread Ivan Uskov
Hello Michael, Monday, August 3, 2015, 12:14:39 PM, you wrote: MN> On Mon, Aug 03, 2015 at 11:36:09AM +0300, Ivan Uskov wrote: >> Hello Hendrik, >> >> Monday, August 3, 2015, 12:45:36 AM, you wrote: >> >> >> HL> The decoder should depend on the header in configure directly already, >> HL> so i

Re: [FFmpeg-devel] [PATCH] dxva2_hevc: fix ucNumDeltaPocsOfRefRpsIdx

2015-08-03 Thread Hendrik Leppkes
On Sun, Aug 2, 2015 at 2:10 PM, Ronald S. Bultje wrote: > Hi, > > On Sun, Aug 2, 2015 at 7:10 AM, Hendrik Leppkes wrote: > >> On Sun, Aug 2, 2015 at 1:07 PM, Hendrik Leppkes >> wrote: >> > It needs to point to the value from the sps rps, not the final computed >> one from the slice header. >> >

Re: [FFmpeg-devel] [PATCH]lavf/mov: Support alac extradata in wave atom

2015-08-03 Thread Yusuke Nakamura
2015-08-03 21:53 GMT+09:00 wm4 : > On Mon, 3 Aug 2015 10:32:02 + (UTC) > Carl Eugen Hoyos wrote: > > > Paul B Mahol gmail.com> writes: > > > > > > Attached patch fixes ticket #4747 for me, > > > > > > I don't know how to detect that the wave > > > > atom contains no frma / alac atom... > > >

Re: [FFmpeg-devel] [PATCH]lavf/mov: Support alac extradata in wave atom

2015-08-03 Thread wm4
On Mon, 3 Aug 2015 10:32:02 + (UTC) Carl Eugen Hoyos wrote: > Paul B Mahol gmail.com> writes: > > > > Attached patch fixes ticket #4747 for me, > > > > I don't know how to detect that the wave > > > atom contains no frma / alac atom... > > > > And that is mentioned because? > > The fil

Re: [FFmpeg-devel] [PATCH 1/4] x86inc: Support arbitrary stack alignments

2015-08-03 Thread Hendrik Leppkes
On Mon, Aug 3, 2015 at 10:31 AM, Henrik Gramner wrote: > On Mon, Aug 3, 2015 at 2:18 AM, Ronald S. Bultje wrote: >> So, I think the code changes themselves look mostly healthy. Is there a >> behavioural difference before/after this patch? (Like: were there bugs in >> the original code, or does th

Re: [FFmpeg-devel] QSV Decoding - Issues and Regressions

2015-08-03 Thread wm4
On Mon, 3 Aug 2015 14:18:04 +0200 Hendrik Leppkes wrote: > Hey, > > after a discussion on IRC about the declining quality of the QSV > decoders, I decided to do actual tests and document the results, so we > can get these fixed. > > A lot of these issues are regressions from recent changes, and

Re: [FFmpeg-devel] QSV Decoding - Issues and Regressions

2015-08-03 Thread Michael Niedermayer
On Mon, Aug 03, 2015 at 02:18:04PM +0200, Hendrik Leppkes wrote: > Hey, > > after a discussion on IRC about the declining quality of the QSV > decoders, I decided to do actual tests and document the results, so we > can get these fixed. > > A lot of these issues are regressions from recent change

[FFmpeg-devel] QSV Decoding - Issues and Regressions

2015-08-03 Thread Hendrik Leppkes
Hey, after a discussion on IRC about the declining quality of the QSV decoders, I decided to do actual tests and document the results, so we can get these fixed. A lot of these issues are regressions from recent changes, and work fine in the original qsv decoders merged from libav, so they should

Re: [FFmpeg-devel] Matroska and PCM variants, error in encoding?

2015-08-03 Thread compn
On Mon, 3 Aug 2015 13:27:48 +0200 "Romeyke, Andreas" wrote: > Dear FFMPEG-developer, > > in case of digital preservation I want to convert/normalize videos to > files with Matroska-Container, FFV1 video- and wave-PCM audiocodec. > > I am using this commandline: > > ffmpeg -i inputvideo.webm -c

Re: [FFmpeg-devel] Matroska and PCM variants, error in encoding?

2015-08-03 Thread Ronald S. Bultje
Hi, On Mon, Aug 3, 2015 at 7:27 AM, Romeyke, Andreas < andreas.rome...@slub-dresden.de> wrote: > And secondly, could you explain the difference between the various > PCM-encodings? My assumpation was, that > * the unsigned variant are "linear PCM", because there are only positive > quantization

Re: [FFmpeg-devel] [PATCH 3/4] x86inc: Drop SECTION_TEXT macro

2015-08-03 Thread Henrik Gramner
On Mon, Aug 3, 2015 at 1:37 AM, Ronald S. Bultje wrote: > Does silencing these warnings still work after this patch? Yes, undefining __SECT__ is no longer needed after this patch. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/m

Re: [FFmpeg-devel] Matroska and PCM variants, error in encoding?

2015-08-03 Thread Paul B Mahol
On 8/3/15, Romeyke, Andreas wrote: > Dear FFMPEG-developer, > > in case of digital preservation I want to convert/normalize videos to files > with Matroska-Container, FFV1 video- and wave-PCM audiocodec. > > I am using this commandline: > > ffmpeg -i inputvideo.webm -c:v ffv1 -level 3 -g 1 -coder

[FFmpeg-devel] Matroska and PCM variants, error in encoding?

2015-08-03 Thread Romeyke, Andreas
Dear FFMPEG-developer, in case of digital preservation I want to convert/normalize videos to files with Matroska-Container, FFV1 video- and wave-PCM audiocodec. I am using this commandline: ffmpeg -i inputvideo.webm -c:v ffv1 -level 3 -g 1 -coder 1 -context 1 -slices 16 -slicecrc 1 -report -c:

Re: [FFmpeg-devel] [PATCH] avcodec/mips: MSA (MIPS-SIMD-Arch) optimizations for VP8 functions

2015-08-03 Thread Ronald S. Bultje
Hi, On Mon, Aug 3, 2015 at 4:42 AM, Shivraj Patil wrote: > Hi, > May I request somebody from maintainers to review this patch please? Sorry, missed the original email - I'll review later today. Ronald ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpe

Re: [FFmpeg-devel] [PATCH]lavf/mov: Support alac extradata in wave atom

2015-08-03 Thread Carl Eugen Hoyos
Paul B Mahol gmail.com> writes: > > Attached patch fixes ticket #4747 for me, > > I don't know how to detect that the wave > > atom contains no frma / alac atom... > > And that is mentioned because? The file from ticket #4747 does not contain an alac atom which is required for alac decoding

Re: [FFmpeg-devel] [PATCH] doc/git-howto: Replace "git push" example by one with dry-run

2015-08-03 Thread Carl Eugen Hoyos
Michael Niedermayer gmx.at> writes: > -git push > +git push origin master --dry-run Doesn't git push -n also work? Anyway, lgtm. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] x86: move XOP emulation code back to x86inc

2015-08-03 Thread Ronald S. Bultje
Hi, On Mon, Aug 3, 2015 at 2:41 AM, James Almer wrote: > Only two functions that use xop multiply-accumulate instructions where the > first operand is the same as the fourth actually took advantage of the > macros. > > This further reduces differences with x264's x86inc. > > Signed-off-by: James

Re: [FFmpeg-devel] [PATCH] configure: Silence error messages when probing compiler.

2015-08-03 Thread Carl Eugen Hoyos
Shiz shiz.me> writes: > On Xcode's clang on OS X, $cc --version will output a 'Configured with:' > line to stderr, which clobbers the configure script output. As this line > serves no further purpose, it should be silenced. I cannot test atm, but the patch looks like a very good idea to me. Ca

[FFmpeg-devel] [PATCH] configure: Silence error messages when probing compiler.

2015-08-03 Thread Shiz
On Xcode's clang on OS X, $cc --version will output a 'Configured with:' line to stderr, which clobbers the configure script output. As this line serves no further purpose, it should be silenced. The same applies to apple-gcc 4.2.1, which complains that it can not understand the kernel version it

[FFmpeg-devel] [PATCH] doc/git-howto: Replace "git push" example by one with dry-run

2015-08-03 Thread Michael Niedermayer
From: Michael Niedermayer I do not think having "git push" as example is a good idea. The command has a very high chance of pushing things which are unwanted to be pushed Signed-off-by: Michael Niedermayer --- doc/git-howto.texi |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) d

Re: [FFmpeg-devel] [PATCH] QSV MJPEG video decoder has been added.

2015-08-03 Thread Michael Niedermayer
On Mon, Aug 03, 2015 at 11:36:09AM +0300, Ivan Uskov wrote: > Hello Hendrik, > > Monday, August 3, 2015, 12:45:36 AM, you wrote: > > > HL> The decoder should depend on the header in configure directly already, > HL> so its not built at all when the header is not available. > In general I do not

Re: [FFmpeg-devel] [PATCH] QSV MJPEG video decoder has been added.

2015-08-03 Thread Hendrik Leppkes
On Mon, Aug 3, 2015 at 10:36 AM, Ivan Uskov wrote: > Hello Hendrik, > > Monday, August 3, 2015, 12:45:36 AM, you wrote: > > > HL> The decoder should depend on the header in configure directly already, > HL> so its not built at all when the header is not available. > In general I do not understandi

Re: [FFmpeg-devel] [PATCH] QSV MJPEG video decoder has been added.

2015-08-03 Thread Ivan Uskov
Hello Hendrik, Monday, August 3, 2015, 12:58:28 AM, you wrote: >> Because if it's missing, ff_get_format() refuses to return the QSV >> opaque format. I think. So you need AVHWAccels for every codec/decoder >> combination. HL> But if you use the normal h264 decoder and select the QSV format in H

Re: [FFmpeg-devel] [PATCH] QSV MJPEG video decoder has been added.

2015-08-03 Thread Ivan Uskov
Hello Hendrik, Monday, August 3, 2015, 12:45:36 AM, you wrote: HL> The decoder should depend on the header in configure directly already, HL> so its not built at all when the header is not available. In general I do not understanding why it necessary at all. All necessary headers currently avail

Re: [FFmpeg-devel] [PATCH 1/4] x86inc: Support arbitrary stack alignments

2015-08-03 Thread Henrik Gramner
On Mon, Aug 3, 2015 at 2:18 AM, Ronald S. Bultje wrote: > So, I think the code changes themselves look mostly healthy. Is there a > behavioural difference before/after this patch? (Like: were there bugs in > the original code, or does this change behaviour of previous code in a > significant way?)

Re: [FFmpeg-devel] [PATCH] avcodec: add new Videotoolbox hwaccel.

2015-08-03 Thread Clément Bœsch
On Fri, Jul 31, 2015 at 08:57:49PM +0200, Clément Bœsch wrote: > On Thu, Jul 30, 2015 at 05:12:21PM +0800, Zhang Rui wrote: > [...] > > BTW: > > I think current patch is OK enough. > > I will push it soon (unless Sebastien has write access?) > Applied. > > Async-mode could be an experimental op

Re: [FFmpeg-devel] FFmpegs future and resigning as leader

2015-08-03 Thread tim nicholson
On 31/07/15 17:19, Michael Niedermayer wrote: > On Fri, Jul 31, 2015 at 05:37:12PM +0200, Clément Bœsch wrote: > [...] >> So in order for the community to continue this, I'd say we probably need >> to have some help for: >> >> - guidelines on the merge strategies >> - step-by-step on the release pr

Re: [FFmpeg-devel] [PATCH 3/4] x86inc: Drop SECTION_TEXT macro

2015-08-03 Thread Henrik Gramner
On Mon, Aug 3, 2015 at 9:02 AM, Dave Yeo wrote: > Here, if the 32 is left as the alignment, the build dies. That's why I removed the 32. It seems to run fine on Haswell (which has AVX2) without it, so I don't know the reason for why it was added in the first place. ___

Re: [FFmpeg-devel] [PATCH 3/4] x86inc: Drop SECTION_TEXT macro

2015-08-03 Thread Dave Yeo
On 08/02/15 11:04 PM, Clément Bœsch wrote: On Sun, Aug 02, 2015 at 10:40:02PM +0200, Henrik Gramner wrote: The .text section is already 16-byte aligned by default on all supported platforms so `SECTION_TEXT` isn't any different from `SECTION .text`. naive question, what about the few SECTION_T