[FFmpeg-devel] [PATCH] lavf/mpeg: vobsub add an option to specify the .sub's URI

2015-04-12 Thread Rodger Combs
--- libavformat/mpeg.c | 52 +--- 1 file changed, 37 insertions(+), 15 deletions(-) diff --git a/libavformat/mpeg.c b/libavformat/mpeg.c index c29291d..1c5bbed 100644 --- a/libavformat/mpeg.c +++ b/libavformat/mpeg.c @@ -26,6 +26,7 @@ #if CONFIG_VO

[FFmpeg-devel] [PATCH] lavf/http: handle case where the server returns a redirect during a seek

2015-04-12 Thread Rodger Combs
txoffer (e.g. http://tori.aoi-chan.com/ ) redirects to the same URI on your first request, and serves the actual file on the second. It's stupid, but AFAIK technically compliant. We'd previously see the server not handing back a Range header and return an error; now, instead, we see that there's a

Re: [FFmpeg-devel] [PATCH] avformat/rtsp: Fix dereference after null check

2015-04-12 Thread Himangi Saraogi
On 13 April 2015 at 01:27, Thomas Volkert wrote: > > Am 12.04.2015 um 21:35 schrieb Himangi Saraogi: > >> --- >> This fixes CID 732219. >> >> libavformat/rtsp.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c >> index 42db

Re: [FFmpeg-devel] [RFC][PATCH] avformat/flvdec: avoid reseting eof_reached to 0 silently

2015-04-12 Thread Zhang Rui
2015-04-12 22:45 GMT+08:00 Michael Niedermayer : > On Sun, Apr 12, 2015 at 12:00:18PM +0800, Zhang Rui wrote: >> 2015-04-10 22:04 GMT+08:00 wm4 : >> > On Fri, 10 Apr 2015 21:17:42 +0800 >> > Zhang Rui wrote: >> >> >> >> This kind of error handling need some more work in aviobuf.c, >> >> and more a

Re: [FFmpeg-devel] [PATCH 3/3] [GSoC] [AAC] aacdec: Use defined macros for constants

2015-04-12 Thread Claudio Freire
On Mon, Apr 13, 2015 at 12:02 AM, Claudio Freire wrote: > Looks good. > > Though it does depend on the first patch of the series. > > > On Sun, Apr 12, 2015 at 1:50 AM, Rostislav Pehlivanov > wrote: >> This commit changes the decoder to use the macro definitions for >> scalefactors and noise ene

Re: [FFmpeg-devel] [PATCH 1/3] [GSoC] [AAC] aacenc: Add support for Perceptual Noise Substitution energy values

2015-04-12 Thread Claudio Freire
On Sun, Apr 12, 2015 at 11:52 PM, Claudio Freire wrote: > On Sun, Apr 12, 2015 at 11:49 PM, Claudio Freire > wrote: >> On Sun, Apr 12, 2015 at 1:50 AM, Rostislav Pehlivanov >> wrote: >>> +int diff, off_sf = sce->sf_idx[0], off_pns = sce->sf_idx[0]; >> >> >> If you take a look at the decoder

Re: [FFmpeg-devel] [PATCH 3/3] [GSoC] [AAC] aacdec: Use defined macros for constants

2015-04-12 Thread Claudio Freire
Looks good. Though it does depend on the first patch of the series. On Sun, Apr 12, 2015 at 1:50 AM, Rostislav Pehlivanov wrote: > This commit changes the decoder to use the macro definitions for scalefactors > and noise energy values reading. This was done to reduce confusion when > looking a

Re: [FFmpeg-devel] [PATCH 2/3] [GSoC] [AAC] aaccoder: Implement Perceptual Noise Substitution

2015-04-12 Thread Claudio Freire
On Sun, Apr 12, 2015 at 1:50 AM, Rostislav Pehlivanov wrote: > @@ -245,6 +258,8 @@ static float (*const quantize_and_encode_band_cost_arr[])( > quantize_and_encode_band_cost_UPAIR, > quantize_and_encode_band_cost_UPAIR, > quantize_and_encode_band_cost_ESC, > +NULL, > +quanti

Re: [FFmpeg-devel] [PATCH 1/3] [GSoC] [AAC] aacenc: Add support for Perceptual Noise Substitution energy values

2015-04-12 Thread Claudio Freire
On Sun, Apr 12, 2015 at 11:49 PM, Claudio Freire wrote: > On Sun, Apr 12, 2015 at 1:50 AM, Rostislav Pehlivanov > wrote: >> +int diff, off_sf = sce->sf_idx[0], off_pns = sce->sf_idx[0]; > > > If you take a look at the decoder, off_pns has to be initialized as off_pns - > 90 Sorry, hit send

Re: [FFmpeg-devel] [PATCH 1/3] [GSoC] [AAC] aacenc: Add support for Perceptual Noise Substitution energy values

2015-04-12 Thread Claudio Freire
On Sun, Apr 12, 2015 at 1:50 AM, Rostislav Pehlivanov wrote: > +int diff, off_sf = sce->sf_idx[0], off_pns = sce->sf_idx[0]; If you take a look at the decoder, off_pns has to be initialized as off_pns - 90 ___ ffmpeg-devel mailing list ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/3] [GSoC] [AAC] aacenc: Add support for Perceptual Noise Substitution energy values

2015-04-12 Thread Michael Niedermayer
On Sun, Apr 12, 2015 at 05:50:34AM +0100, Rostislav Pehlivanov wrote: > This commit implements support for writing the noise energy values used in > PNS. The difference between regular scalefactors and noise energy values is > that the latter require a small preamble (NOISE_PRE + energy_value_dif

Re: [FFmpeg-devel] [PATCH] tests/fate: added mxf opatom audio regression tests

2015-04-12 Thread Michael Niedermayer
On Sun, Apr 12, 2015 at 04:39:01PM -0700, Mark Reid wrote: > --- > tests/fate/avformat.mak | 1 + > tests/fate/seek.mak | 2 ++ > tests/lavf-regression.sh | 4 +++ > tests/ref/lavf/mxf_opatom_audio | 3 ++ > tests/ref/seek/lavf-mxf_opatom_audio |

Re: [FFmpeg-devel] [PATCH 2/3] [GSoC] [AAC] aaccoder: Implement Perceptual Noise Substitution

2015-04-12 Thread Rostislav Pehlivanov
Here's an objective comparison of the difference the patch makes: Original spectrum: https://0x0.st/T7.png Encoded without the patchset: https://0x0.st/Th.png Encoded with the patchset: https://0x0.st/TF.png Difference: https://0x0.st/TR.png Made by: "$ composite Encoded

Re: [FFmpeg-devel] [PATCH] Fixed remuxing of HDMV PGS subtitles

2015-04-12 Thread Philip Langdale
On Sun, 12 Apr 2015 23:53:21 + Timothy Gu wrote: > On Sun, Apr 12, 2015 at 4:41 PM Philip Langdale > wrote: > > > > So, this change is not a complete fix, but it's one of the necessary > > steps. > > > > That was what I suspected. I simply forwarded the patch from GitHub. > > Also I didn't

Re: [FFmpeg-devel] [PATCH] Fixed remuxing of HDMV PGS subtitles

2015-04-12 Thread Timothy Gu
On Sun, Apr 12, 2015 at 4:41 PM Philip Langdale wrote: > > So, this change is not a complete fix, but it's one of the necessary > steps. > That was what I suspected. I simply forwarded the patch from GitHub. Also I didn't notice the patch had some trailing spaces… Timothy __

Re: [FFmpeg-devel] [PATCH] Fixed remuxing of HDMV PGS subtitles

2015-04-12 Thread Philip Langdale
On Sun, 12 Apr 2015 08:13:39 + (UTC) Carl Eugen Hoyos wrote: > > I tested with samples from the following directories: > http://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket598/ > http://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket1722/ > http://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket3820/ > >

[FFmpeg-devel] [PATCH] tests/fate: added mxf opatom audio regression tests

2015-04-12 Thread Mark Reid
--- tests/fate/avformat.mak | 1 + tests/fate/seek.mak | 2 ++ tests/lavf-regression.sh | 4 +++ tests/ref/lavf/mxf_opatom_audio | 3 ++ tests/ref/seek/lavf-mxf_opatom_audio | 53 5 files changed, 63 insertions

Re: [FFmpeg-devel] [PATCH 1/3] [GSoC] [AAC] aacenc: Add support for Perceptual Noise Substitution energy values

2015-04-12 Thread Michael Niedermayer
On Sun, Apr 12, 2015 at 05:50:34AM +0100, Rostislav Pehlivanov wrote: > This commit implements support for writing the noise energy values used in > PNS. The difference between regular scalefactors and noise energy values is > that the latter require a small preamble (NOISE_PRE + energy_value_dif

Re: [FFmpeg-devel] [PATCH] avformat/rtsp: Fix dereference after null check

2015-04-12 Thread Michael Niedermayer
On Sun, Apr 12, 2015 at 09:57:19PM +0200, Thomas Volkert wrote: > > Am 12.04.2015 um 21:35 schrieb Himangi Saraogi: > >--- > >This fixes CID 732219. > > > > libavformat/rtsp.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > >diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c

[FFmpeg-devel] [PATCH] Check for not synchronized packets (very small feed file, very slow client connection)

2015-04-12 Thread Milan Matejec
Hi, attached is patch for encoding/decoding .ffm format. When you set a maximum size of feed file to too small number (I tried 20k) and try to connect to ffserver from very slow connection (simulated by reading 8k chunks and then wait 3 seconds) .ffm decoder will after a few seconds (10 maybe more

Re: [FFmpeg-devel] [PATCH] fate: Include branch information in the payload header

2015-04-12 Thread Timothy Gu
On Sun, Apr 12, 2015 at 8:28 AM Timothy Gu wrote: > The server is properly equiped not to choke on that now. > --- > tests/fate.sh | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > This was applied by Michael earlier today. [...] Timothy __

Re: [FFmpeg-devel] [PATCH] avformat/rtsp: Fix dereference after null check

2015-04-12 Thread Thomas Volkert
Am 12.04.2015 um 21:35 schrieb Himangi Saraogi: --- This fixes CID 732219. libavformat/rtsp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 42dbe96..c186b99 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -80

[FFmpeg-devel] [PATCH] avformat/rtsp: Fix dereference after null check

2015-04-12 Thread Himangi Saraogi
--- This fixes CID 732219. libavformat/rtsp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 42dbe96..c186b99 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -802,7 +802,7 @@ int ff_rtsp_open_transport_ctx(AVFormat

[FFmpeg-devel] [PATCH] fate: Include branch information in the payload header

2015-04-12 Thread Timothy Gu
The server is properly equiped not to choke on that now. --- tests/fate.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/fate.sh b/tests/fate.sh index 81224b6..6ce8c48 100755 --- a/tests/fate.sh +++ b/tests/fate.sh @@ -84,8 +84,7 @@ clean(){ report(){ date=$(d

Re: [FFmpeg-devel] [RFC][PATCH] avformat/flvdec: avoid reseting eof_reached to 0 silently

2015-04-12 Thread Michael Niedermayer
On Sun, Apr 12, 2015 at 12:00:18PM +0800, Zhang Rui wrote: > 2015-04-10 22:04 GMT+08:00 wm4 : > > On Fri, 10 Apr 2015 21:17:42 +0800 > > Zhang Rui wrote: > >> > >> This kind of error handling need some more work in aviobuf.c, > >> and more advises from ffmpeg developers. > >> And i prefer this way

[FFmpeg-devel] [PATCH] tests/tiny_psnr: Make the search range extend both sides from the specified shift value

2015-04-12 Thread Michael Niedermayer
This is what one would expect from the help text Signed-off-by: Michael Niedermayer --- tests/tiny_psnr.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/tiny_psnr.c b/tests/tiny_psnr.c index b35ed81..e09f394 100644 --- a/tests/tiny_psnr.c +++ b/tests/tiny_psnr.c @@ -273,6 +273,9

[FFmpeg-devel] [PATCH 3/3] [GSoC] [AAC] aacdec: Use defined macros for constants

2015-04-12 Thread Rostislav Pehlivanov
This commit changes the decoder to use the macro definitions for scalefactors and noise energy values reading. This was done to reduce confusion when looking at the encoder and decoder and possibly as a first step in unifying some of the code in the two files. --- libavcodec/aacdec.c | 8 --

[FFmpeg-devel] [PATCH 2/3] [GSoC] [AAC] aaccoder: Implement Perceptual Noise Substitution

2015-04-12 Thread Rostislav Pehlivanov
This commit enables the use of the pseudo-codebook NOISE_BT for encoding noise values for the twoloop coder. It uses the energy values from the psychoacoustic model to determine whether it's acceptible to use noise for encoding and if so, determine the energy of the noise. The cost system was mo

[FFmpeg-devel] [PATCH 1/3] [GSoC] [AAC] aacenc: Add support for Perceptual Noise Substitution energy values

2015-04-12 Thread Rostislav Pehlivanov
This commit implements support for writing the noise energy values used in PNS. The difference between regular scalefactors and noise energy values is that the latter require a small preamble (NOISE_PRE + energy_value_diff) to be written as the first noise-containing band. Any following noise en

Re: [FFmpeg-devel] [PATCH] Fixed remuxing of HDMV PGS subtitles

2015-04-12 Thread Carl Eugen Hoyos
Philip Langdale overt.org> writes: > On Sun, 12 Apr 2015 00:16:45 + (UTC) > Carl Eugen Hoyos ag.or.at> wrote: > > > Timothy Gu gmail.com> writes: > > > > > From: Niklesh Lalwani gmail.com> > > > > > > Fixes #2622. > > > > Which sample did you use for testing? > > I don't think we have