Re: [FFmpeg-devel] [PATCH] libavfilter/thumbnail filter, copy buffers instead of reference

2015-02-25 Thread Chris Kennedy
I forgot the copy of the original buffer, oddly if I copy it then causes things to crash at the end when the codec is freed, only for certain .avi mpeg4 and in the mpeg4 codec where it frees some data there. I am digging in to that, but patch at least shows deeper into something odd going on. I c

Re: [FFmpeg-devel] [PATCH 3/3] avformat/dss: implement seeking

2015-02-25 Thread Michael Niedermayer
On Tue, Feb 24, 2015 at 03:22:39PM +0100, Michael Niedermayer wrote: > This assumes CBR (which is true for all samples i have) > > Signed-off-by: Michael Niedermayer > --- > libavformat/dss.c | 39 +++ > 1 file changed, 39 insertions(+) reviewed by Oleksij

Re: [FFmpeg-devel] [PATCH 2/3] avformat/dss: set bitrate

2015-02-25 Thread Michael Niedermayer
On Tue, Feb 24, 2015 at 03:22:38PM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavformat/dss.c |8 > 1 file changed, 8 insertions(+) applied [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Awnsering whenever a

Re: [FFmpeg-devel] [PATCH] avformat/adxdec: check avctx->channels for invalid values

2015-02-25 Thread Andreas Cadhalpun
On 26.02.2015 00:24, Michael Niedermayer wrote: On Wed, Feb 25, 2015 at 11:48:33PM +0100, Andreas Cadhalpun wrote: Hi, if avctx->channels is 0 in adx_read_packet, size gets set to 0, av_get_packet sets pkt->data to NULL and then AV_RB16(pkt->data) results in a null pointer dereference. Attache

Re: [FFmpeg-devel] [PATCH] avformat/dss: set packet duration

2015-02-25 Thread Michael Niedermayer
On Tue, Feb 24, 2015 at 04:01:22PM +0100, Michael Niedermayer wrote: > Value taken from the decoder implementation > > Signed-off-by: Michael Niedermayer applied [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB In a rich man's house there is no place to spit bu

Re: [FFmpeg-devel] [PATCH 1/3] avformat/dss: correct sample rate

2015-02-25 Thread Michael Niedermayer
On Tue, Feb 24, 2015 at 03:22:37PM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavformat/dss.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB When the tyra

Re: [FFmpeg-devel] [PATCH][RFC] Interpretation of duration field in AVI super index chunk

2015-02-25 Thread Michael Niedermayer
On Wed, Feb 25, 2015 at 05:35:33PM +0100, Tobias Rapp wrote: > On 24.02.2015 16:33, Tobias Rapp wrote: > >Hi, > > > >I am currently trying to interpret the index data of HuffYuv/PCM AVI > >files written by FFmpeg. If the file is larger than 2GiB an "AVIX" RIFF > >chunk is added for each 2GiB-block,

[FFmpeg-devel] [PATCH] libavfilter/thumbnail filter, copy buffers instead of reference

2015-02-25 Thread Chris Kennedy
This fixes the buffer handling in the thumbnail filter, it seems that the referencing buffers it does isn't safe (could be hundreds of them held in ref) and the main ffmpeg buffer handling can fail. It now just grabs the video buffers and copies them, frees the frame immediately, and works just th

Re: [FFmpeg-devel] [PATCH] Socket options for librtmp

2015-02-25 Thread Michael Niedermayer
On Mon, Feb 23, 2015 at 10:28:29PM -0600, Cary Tetrick wrote: > > > > please ping this thread when this happens > > > > about the patch itself > > > > IIUC a user using old rtmpdump with new ffmpeg would loose the > > rtmp_buffer_size option. > > Would it make sense to support the old setsockopt()

Re: [FFmpeg-devel] [PATCH] avformat/adxdec: check avctx->channels for invalid values

2015-02-25 Thread Michael Niedermayer
On Wed, Feb 25, 2015 at 11:48:33PM +0100, Andreas Cadhalpun wrote: > Hi, > > if avctx->channels is 0 in adx_read_packet, size gets set to 0, > av_get_packet sets pkt->data to NULL and then AV_RB16(pkt->data) > results in a null pointer dereference. > > Attached patch fixes this. > > Best regards

Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg: allow to set the thread message queue size.

2015-02-25 Thread Michael Niedermayer
On Wed, Feb 25, 2015 at 10:29:09PM +0100, wm4 wrote: > On Wed, 25 Feb 2015 22:24:39 +0100 > Michael Niedermayer wrote: > > > On Wed, Feb 25, 2015 at 08:00:03PM +0100, Nicolas George wrote: > > > Le septidi 7 ventôse, an CCXXIII, Michael Niedermayer a écrit : > > > > without pthreads, this seems t

Re: [FFmpeg-devel] [PATCH] libavutil: add x86 optimized av_popcount

2015-02-25 Thread James Almer
On 25/02/15 3:29 PM, Ronald S. Bultje wrote: >> Otherwise i think the second version with builtins i sent is good to >> > apply. Much >> > cleaner than the configure approach to be honest. > > OK. > > Ronald Pushed, thanks. ___ ffmpeg-devel mailing lis

Re: [FFmpeg-devel] [PATCH] avcodec/utils: Allocate dummy codec_frame for video encoders which do not allocate one

2015-02-25 Thread Michael Niedermayer
On Mon, Feb 23, 2015 at 07:51:30PM +0100, wm4 wrote: > On Mon, 23 Feb 2015 19:11:58 +0100 > Michael Niedermayer wrote: > > > On Mon, Feb 23, 2015 at 06:49:36PM +0100, Michael Niedermayer wrote: > > > On Mon, Feb 23, 2015 at 06:15:15PM +0100, wm4 wrote: > > > > On Mon, 23 Feb 2015 17:19:16 +0100 >

[FFmpeg-devel] [PATCH] avformat/adxdec: check avctx->channels for invalid values

2015-02-25 Thread Andreas Cadhalpun
Hi, if avctx->channels is 0 in adx_read_packet, size gets set to 0, av_get_packet sets pkt->data to NULL and then AV_RB16(pkt->data) results in a null pointer dereference. Attached patch fixes this. Best regards, Andreas >From 2578976a0a9eec03d168f393795119fd274ee81f Mon Sep 17 00:00:00 2001

Re: [FFmpeg-devel] [PATCH] libavutil: add x86 optimized av_popcount

2015-02-25 Thread Clément Bœsch
On Wed, Feb 25, 2015 at 02:29:11PM -0300, James Almer wrote: > On 25/02/15 12:43 PM, Clément Bœsch wrote: > > On Tue, Feb 24, 2015 at 10:05:24PM -0300, James Almer wrote: > >> Signed-off-by: James Almer > >> --- > >> I decided to go the configure route since other features (cmov, clz) also > >> d

Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg: allow to set the thread message queue size.

2015-02-25 Thread wm4
On Wed, 25 Feb 2015 22:24:39 +0100 Michael Niedermayer wrote: > On Wed, Feb 25, 2015 at 08:00:03PM +0100, Nicolas George wrote: > > Le septidi 7 ventôse, an CCXXIII, Michael Niedermayer a écrit : > > > without pthreads, this seems to fail to build > > > > Forgot to test that, sorry. Fixed. > >

Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg: allow to set the thread message queue size.

2015-02-25 Thread Michael Niedermayer
On Wed, Feb 25, 2015 at 08:00:03PM +0100, Nicolas George wrote: > Le septidi 7 ventôse, an CCXXIII, Michael Niedermayer a écrit : > > without pthreads, this seems to fail to build > > Forgot to test that, sorry. Fixed. > > By the way, what are the remaining supported cases where threads are not >

Re: [FFmpeg-devel] [PATCH] libavutil: add x86 optimized av_popcount

2015-02-25 Thread Reimar Döffinger
On 25.02.2015, at 19:29, "Ronald S. Bultje" wrote: > Hi, > > On Wed, Feb 25, 2015 at 1:21 PM, James Almer wrote: > >> On 25/02/15 2:58 PM, Ronald S. Bultje wrote: >>> Hi, >>> >>> On Wed, Feb 25, 2015 at 12:52 PM, James Almer wrote: >>> On 25/02/15 2:36 PM, Ronald S. Bultje wrote: >

Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg: allow to set the thread message queue size.

2015-02-25 Thread Nicolas George
Le septidi 7 ventôse, an CCXXIII, Michael Niedermayer a écrit : > without pthreads, this seems to fail to build Forgot to test that, sorry. Fixed. By the way, what are the remaining supported cases where threads are not available? Regards, -- Nicolas George From 16fc0adda7fa35b69053205abf9dd

Re: [FFmpeg-devel] [PATCH] libavutil: add x86 optimized av_popcount

2015-02-25 Thread Ronald S. Bultje
Hi, On Wed, Feb 25, 2015 at 1:21 PM, James Almer wrote: > On 25/02/15 2:58 PM, Ronald S. Bultje wrote: > > Hi, > > > > On Wed, Feb 25, 2015 at 12:52 PM, James Almer wrote: > > > >> On 25/02/15 2:36 PM, Ronald S. Bultje wrote: > >>> Hi James, > >>> > >>> On Wed, Feb 25, 2015 at 12:25 PM, James A

Re: [FFmpeg-devel] [PATCH] libavutil: add x86 optimized av_popcount

2015-02-25 Thread James Almer
On 25/02/15 2:58 PM, Ronald S. Bultje wrote: > Hi, > > On Wed, Feb 25, 2015 at 12:52 PM, James Almer wrote: > >> On 25/02/15 2:36 PM, Ronald S. Bultje wrote: >>> Hi James, >>> >>> On Wed, Feb 25, 2015 at 12:25 PM, James Almer wrote: >>> On 25/02/15 9:41 AM, Ronald S. Bultje wrote: > Hi

Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg: allow to set the thread message queue size.

2015-02-25 Thread Michael Niedermayer
On Wed, Feb 25, 2015 at 12:01:26PM +0100, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > doc/ffmpeg.texi | 6 ++ > ffmpeg.c| 2 +- > ffmpeg.h| 2 ++ > ffmpeg_opt.c| 4 > 4 files changed, 13 insertions(+), 1 deletion(-) without pthreads, this seems to f

Re: [FFmpeg-devel] [PATCH] libavutil: add x86 optimized av_popcount

2015-02-25 Thread Ronald S. Bultje
Hi, On Wed, Feb 25, 2015 at 12:52 PM, James Almer wrote: > On 25/02/15 2:36 PM, Ronald S. Bultje wrote: > > Hi James, > > > > On Wed, Feb 25, 2015 at 12:25 PM, James Almer wrote: > > > >> On 25/02/15 9:41 AM, Ronald S. Bultje wrote: > >>> Hi, > >>> > >>> On Tue, Feb 24, 2015 at 8:05 PM, James A

Re: [FFmpeg-devel] [PATCH] avfilter/palettegen: use AV_QSORT()

2015-02-25 Thread Michael Niedermayer
On Wed, Feb 25, 2015 at 04:10:44PM +0100, Clément Bœsch wrote: > From: Clément Bœsch > > This makes the sorting of the colors along an axis (r, g or b) > predictible, and thus testable under FATE. The performance is not really > an issue here since the function is called only once at the end and

Re: [FFmpeg-devel] [PATCH] libavutil: add x86 optimized av_popcount

2015-02-25 Thread James Almer
On 25/02/15 2:36 PM, Ronald S. Bultje wrote: > Hi James, > > On Wed, Feb 25, 2015 at 12:25 PM, James Almer wrote: > >> On 25/02/15 9:41 AM, Ronald S. Bultje wrote: >>> Hi, >>> >>> On Tue, Feb 24, 2015 at 8:05 PM, James Almer wrote: +#if HAVE_FAST_POPCNT +#if AV_GCC_VERSION_AT_LEA

Re: [FFmpeg-devel] [PATCH] libavutil: add x86 optimized av_popcount

2015-02-25 Thread Ronald S. Bultje
Hi James, On Wed, Feb 25, 2015 at 12:25 PM, James Almer wrote: > On 25/02/15 9:41 AM, Ronald S. Bultje wrote: > > Hi, > > > > On Tue, Feb 24, 2015 at 8:05 PM, James Almer wrote: > >> > >> +#if HAVE_FAST_POPCNT > >> +#if AV_GCC_VERSION_AT_LEAST(4,5) > >> +#ifndef av_popcount > >> +#define av

Re: [FFmpeg-devel] DSP function ARM NEON patches for hevc

2015-02-25 Thread Michael Niedermayer
On Wed, Feb 25, 2015 at 11:12:23AM +, Tomperi Seppo wrote: > 17/02/15 12:44, "Michael Niedermayer" : > > >On Tue, Feb 17, 2015 at 07:33:04AM +, Tomperi Seppo wrote: > >> > >> > On 16 Feb 2015, at 19:54, Michael Niedermayer > >> wrote: > >> > > >> > On Mon, Feb 16, 2015 at 12:47:36PM +000

Re: [FFmpeg-devel] [PATCH] libavutil: add x86 optimized av_popcount

2015-02-25 Thread James Almer
On 25/02/15 12:43 PM, Clément Bœsch wrote: > On Tue, Feb 24, 2015 at 10:05:24PM -0300, James Almer wrote: >> Signed-off-by: James Almer >> --- >> I decided to go the configure route since other features (cmov, clz) also do >> it , but if prefered this could instead be done with a new intmath.h hea

Re: [FFmpeg-devel] [PATCH] libavutil: add x86 optimized av_popcount

2015-02-25 Thread James Almer
On 25/02/15 9:41 AM, Ronald S. Bultje wrote: > Hi, > > On Tue, Feb 24, 2015 at 8:05 PM, James Almer wrote: >> >> +#if HAVE_FAST_POPCNT >> +#if AV_GCC_VERSION_AT_LEAST(4,5) >> +#ifndef av_popcount >> +#define av_popcount __builtin_popcount >> +#endif /* av_popcount */ >> +#if HAVE_FAST_64BIT

Re: [FFmpeg-devel] [PATCH] libavutil: add x86 optimized av_popcount

2015-02-25 Thread James Almer
On 25/02/15 12:43 PM, Clément Bœsch wrote: > On Tue, Feb 24, 2015 at 10:05:24PM -0300, James Almer wrote: >> Signed-off-by: James Almer >> --- >> I decided to go the configure route since other features (cmov, clz) also do >> it , but if prefered this could instead be done with a new intmath.h hea

Re: [FFmpeg-devel] Adding Webvtt in hls muxer

2015-02-25 Thread Deron
On 2/21/15 8:05 AM, Deron wrote: On 2/15/15 5:44 AM, Anshul wrote: attached another cleaned patch. -Anshul Not sure if I should be posting here, privately, or do the user list since it is an unaccepted patch... This patch applies cleanly to ffmpeg git of that day, and with minor adjustment

Re: [FFmpeg-devel] [PATCH][RFC] Interpretation of duration field in AVI super index chunk

2015-02-25 Thread Tobias Rapp
On 24.02.2015 16:33, Tobias Rapp wrote: Hi, I am currently trying to interpret the index data of HuffYuv/PCM AVI files written by FFmpeg. If the file is larger than 2GiB an "AVIX" RIFF chunk is added for each 2GiB-block, each of these blocks gets an OpenDML chunk index "ix00" and an OpenDML supe

Re: [FFmpeg-devel] [PATCH] libavutil: add x86 optimized av_popcount

2015-02-25 Thread Clément Bœsch
On Tue, Feb 24, 2015 at 10:05:24PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > I decided to go the configure route since other features (cmov, clz) also do > it , but if prefered this could instead be done with a new intmath.h header > in the x86/ folder containing something li

Re: [FFmpeg-devel] [PATCH] lavfi: add erosion & dilation filter

2015-02-25 Thread Paul B Mahol
On 2/25/15, Clement Boesch wrote: > On Wed, Feb 25, 2015 at 02:55:58PM +, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> doc/filters.texi | 34 ++ >> libavfilter/Makefile | 2 + >> libavfilter/allfilters.c | 2 + >> libavfilter/vf_neighbor.c | 289 >> +++

Re: [FFmpeg-devel] [PATCH] lavfi: add erosion & dilation filter

2015-02-25 Thread Clément Bœsch
On Wed, Feb 25, 2015 at 02:55:58PM +, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 34 ++ > libavfilter/Makefile | 2 + > libavfilter/allfilters.c | 2 + > libavfilter/vf_neighbor.c | 289 > ++

Re: [FFmpeg-devel] [PATCH] avfilter/palettegen: export color quantization ratio

2015-02-25 Thread Clément Bœsch
On Wed, Feb 25, 2015 at 03:43:23PM +0100, Nicolas George wrote: > Le septidi 7 ventôse, an CCXXIII, Clement Boesch a écrit : > > +float ratio = (float)nb_out / nb_in; > > +snprintf(buf, sizeof(buf), "%f", ratio); > > I wonder if both values could be useful instead individually. If so, eith

[FFmpeg-devel] [PATCH] avfilter/palettegen: use AV_QSORT()

2015-02-25 Thread Clément Bœsch
From: Clément Bœsch This makes the sorting of the colors along an axis (r, g or b) predictible, and thus testable under FATE. The performance is not really an issue here since the function is called only once at the end and will need to sort very small number of entries, so an alternative would b

[FFmpeg-devel] [PATCH] lavfi: add erosion & dilation filter

2015-02-25 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 34 ++ libavfilter/Makefile | 2 + libavfilter/allfilters.c | 2 + libavfilter/vf_neighbor.c | 289 ++ 4 files changed, 327 insertions(+) create mode 100644 libavfilter/vf_neigh

Re: [FFmpeg-devel] [PATCH] avfilter/palettegen: export color quantization ratio

2015-02-25 Thread Nicolas George
Le septidi 7 ventôse, an CCXXIII, Clement Boesch a écrit : > +float ratio = (float)nb_out / nb_in; > +snprintf(buf, sizeof(buf), "%f", ratio); I wonder if both values could be useful instead individually. If so, either set the string to %d/%d or set two metadata keys. If not, use double i

[FFmpeg-devel] [PATCH] avfilter/palettegen: export color quantization ratio

2015-02-25 Thread Clément Bœsch
From: Clément Bœsch --- doc/filters.texi| 5 + libavfilter/version.h | 2 +- libavfilter/vf_palettegen.c | 14 -- 3 files changed, 18 insertions(+), 3 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index baef346..0c72145 100644 --- a/doc/filter

Re: [FFmpeg-devel] [PATCH] libavutil: add x86 optimized av_popcount

2015-02-25 Thread Ronald S. Bultje
Hi, On Tue, Feb 24, 2015 at 8:05 PM, James Almer wrote: > > +#if HAVE_FAST_POPCNT > +#if AV_GCC_VERSION_AT_LEAST(4,5) > +#ifndef av_popcount > +#define av_popcount __builtin_popcount > +#endif /* av_popcount */ > +#if HAVE_FAST_64BIT > +#ifndef av_popcount64 > +#define av_popcount64 __b

Re: [FFmpeg-devel] DSP function ARM NEON patches for hevc

2015-02-25 Thread Tomperi Seppo
17/02/15 12:44, "Michael Niedermayer" : >On Tue, Feb 17, 2015 at 07:33:04AM +, Tomperi Seppo wrote: >> >> > On 16 Feb 2015, at 19:54, Michael Niedermayer >> wrote: >> > >> > On Mon, Feb 16, 2015 at 12:47:36PM +, Tomperi Seppo wrote: >> >> More NEON optimizations for testing. fate-hevc pa

[FFmpeg-devel] [PATCH 1/2] ffmpeg: allow to set the thread message queue size.

2015-02-25 Thread Nicolas George
Signed-off-by: Nicolas George --- doc/ffmpeg.texi | 6 ++ ffmpeg.c| 2 +- ffmpeg.h| 2 ++ ffmpeg_opt.c| 4 4 files changed, 13 insertions(+), 1 deletion(-) diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi index 6e51c44..6772f2f 100644 --- a/doc/ffmpeg.texi +++ b/doc/ff

[FFmpeg-devel] [PATCH 2/2] ffmpeg: notify when the thread message queue blocks.

2015-02-25 Thread Nicolas George
This can help finding the source of A-V desync with live input. Signed-off-by: Nicolas George --- ffmpeg.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) No functional change since the first version, but reworded to point to the relevant option and give the current value.

Re: [FFmpeg-devel] [PATCH] Port FFT domain filter.

2015-02-25 Thread Michael Niedermayer
On Wed, Feb 25, 2015 at 11:55:51AM +0530, arwa arif wrote: > On Tue, Feb 24, 2015 at 4:12 PM, Michael Niedermayer > wrote: > > > On Tue, Feb 24, 2015 at 02:27:01PM +0530, arwa arif wrote: > > > Hello, > > > > > > I have written a very primitive code for porting FFT domain filter. It > > > accepts