[FFmpeg-devel] [PATCH] avformat/rtsp: punch holes again after pause

2015-02-21 Thread Gilles Chanteperdrix
When a client behind a NAT issues a pause command, and stay paused for a long time, the router may stop the RTP/RTCP port redirection. Resend the hole punching packets after each PLAY command to cause the router to restart the port redirection in that case. Signed-off-by: Gilles Chanteperdrix ---

Re: [FFmpeg-devel] [PATCH 1/3] avformat/rtpdec_mpeg4: reassemble fragmented AAC frames

2015-02-21 Thread Michael Niedermayer
On Sat, Feb 21, 2015 at 11:51:19PM +0100, Thomas Volkert wrote: > > On 21.02.2015 22:35, Gilles Chanteperdrix wrote: > >On Sat, Feb 21, 2015 at 04:54:12PM +0100, Thomas Volkert wrote: > >>>+if (len < data->au_headers[0].size) { > >>>+av_log(ctx, AV_LOG_ERROR, "First AU larger than pack

Re: [FFmpeg-devel] [PATCH 1/3] avformat/rtpdec_mpeg4: reassemble fragmented AAC frames

2015-02-21 Thread Thomas Volkert
On 21.02.2015 22:35, Gilles Chanteperdrix wrote: On Sat, Feb 21, 2015 at 04:54:12PM +0100, Thomas Volkert wrote: +if (len < data->au_headers[0].size) { +av_log(ctx, AV_LOG_ERROR, "First AU larger than packet size\n"); Can this really happen? In the lines above you already check for

Re: [FFmpeg-devel] [PATCH] Add coverity model file

2015-02-21 Thread Michael Niedermayer
On Sat, Feb 21, 2015 at 11:52:21PM +0100, Michael Niedermayer wrote: > On Thu, Feb 19, 2015 at 03:41:35PM +, Timothy Gu wrote: > > On Thu Feb 19 2015 at 4:43:30 AM Michael Niedermayer > > wrote: > > > > > > tools/model.c | 42 ++ > > > 1 file changed,

Re: [FFmpeg-devel] [PATCH] Add coverity model file

2015-02-21 Thread Michael Niedermayer
On Thu, Feb 19, 2015 at 03:41:35PM +, Timothy Gu wrote: > On Thu Feb 19 2015 at 4:43:30 AM Michael Niedermayer > wrote: > > > > tools/model.c | 42 ++ > > 1 file changed, 42 insertions(+) > > create mode 100644 tools/model.c > > > > tools/coverity.c

Re: [FFmpeg-devel] [PATCH 1/3] avformat/rtpdec_mpeg4: reassemble fragmented AAC frames

2015-02-21 Thread Gilles Chanteperdrix
On Sat, Feb 21, 2015 at 04:54:12PM +0100, Thomas Volkert wrote: > >+if (len < data->au_headers[0].size) { > >+av_log(ctx, AV_LOG_ERROR, "First AU larger than packet size\n"); > > Can this really happen? > In the lines above you already check for the case that data is missing while > yo

[FFmpeg-devel] Development needed

2015-02-21 Thread Joe Marchese
Hello, I need a seasoned ffmpeg developer to perform the following functions and compile to an active X control or DLL. 1) Take files generated from recording IP video cameras in MJPEG mode. The files are stripped of all metadata and are simple JPEG files concatenated together. File si

Re: [FFmpeg-devel] [PATCH] avcodec/tak: reset filter buffers

2015-02-21 Thread James Almer
On 21/02/15 3:47 PM, Paul B Mahol wrote: > On 2/21/15, James Almer wrote: >> On 21/02/15 8:49 AM, Paul B Mahol wrote: >>> Have you measured performance drop before and after? >> >> filter_order 8 in decorrelate() >> >> Before >> 903 decicycles in scalarproduct, 8388364 runs, 244 skips >> After >>

Re: [FFmpeg-devel] [PATCH] avcodec/tak: reset filter buffers

2015-02-21 Thread Paul B Mahol
On 2/21/15, James Almer wrote: > On 21/02/15 8:49 AM, Paul B Mahol wrote: >> Have you measured performance drop before and after? > > filter_order 8 in decorrelate() > > Before > 903 decicycles in scalarproduct, 8388364 runs, 244 skips > After > 858 decicycles in scalarproduct, 8388215 runs, 393 s

[FFmpeg-devel] [PATCH] avformat/hlsenc: Warn if a non file protocol is used

2015-02-21 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavformat/hlsenc.c |4 1 file changed, 4 insertions(+) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index bf79109..7885351 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -247,6 +247,10 @@ static int hls_window(AVForma

Re: [FFmpeg-devel] Adding Webvtt in hls muxer

2015-02-21 Thread Deron
On 2/21/15 8:51 AM, Michael Niedermayer wrote: On Sat, Feb 21, 2015 at 08:05:40AM -0700, Deron wrote: On 2/15/15 5:44 AM, Anshul wrote: attached another cleaned patch. -Anshul Not sure if I should be posting here, privately, or do the user list since it is an unaccepted patch... This patch ap

Re: [FFmpeg-devel] [PATCH] avcodec/tak: reset filter buffers

2015-02-21 Thread James Almer
On 21/02/15 8:49 AM, Paul B Mahol wrote: > Have you measured performance drop before and after? filter_order 8 in decorrelate() Before 903 decicycles in scalarproduct, 8388364 runs, 244 skips After 858 decicycles in scalarproduct, 8388215 runs, 393 skips filter_order 24 in decode_subframe() Be

Re: [FFmpeg-devel] [PATCH 1/3] avformat/rtpdec_mpeg4: reassemble fragmented AAC frames

2015-02-21 Thread Thomas Volkert
On 02/13/2015 10:51 PM, Gilles Chanteperdrix wrote: Signed-off-by: Gilles Chanteperdrix --- libavformat/rtpdec_mpeg4.c | 84 +- 1 file changed, 76 insertions(+), 8 deletions(-) diff --git a/libavformat/rtpdec_mpeg4.c b/libavformat/rtpdec_mpeg4.c in

Re: [FFmpeg-devel] Adding Webvtt in hls muxer

2015-02-21 Thread Michael Niedermayer
On Sat, Feb 21, 2015 at 08:05:40AM -0700, Deron wrote: > On 2/15/15 5:44 AM, Anshul wrote: > > > >attached another cleaned patch. > > > >-Anshul > > Not sure if I should be posting here, privately, or do the user list > since it is an unaccepted patch... This patch applies cleanly to here is fine

Re: [FFmpeg-devel] [PATCH] avcodec/x86/mlpdsp_init: Simplify mlp_filter_channel_x86()

2015-02-21 Thread Michael Niedermayer
On Sat, Feb 21, 2015 at 02:14:27PM +0100, Michael Niedermayer wrote: > Based on patch by Francisco Blas Izquierdo Riera > Commit message partly taken from carl > > fixes a compilation > error in mlpdsp_init.c with -fstack-check and some gcc compilers (I > reproduced the issue with gcc 4.7.3) by si

Re: [FFmpeg-devel] Adding Webvtt in hls muxer

2015-02-21 Thread Deron
On 2/15/15 5:44 AM, Anshul wrote: attached another cleaned patch. -Anshul Not sure if I should be posting here, privately, or do the user list since it is an unaccepted patch... This patch applies cleanly to ffmpeg git of that day, and with minor adjustment to current git, but either crash

Re: [FFmpeg-devel] tools: crypto_bench: Added support for Twofish

2015-02-21 Thread Michael Niedermayer
On Sat, Feb 21, 2015 at 02:45:34PM +0100, Nicolas George wrote: > Le tridi 3 ventôse, an CCXXIII, supraja reddy a écrit : > > I have made the changes as suggested by Giorgio. Please let me know if any > > further changes required. > > > From 8a1f5216baa1a2ce741359ed4e83871b2ab790d8 Mon Sep 17 00:0

Re: [FFmpeg-devel] tools: crypto_bench: Added support for Twofish

2015-02-21 Thread Nicolas George
Le tridi 3 ventôse, an CCXXIII, supraja reddy a écrit : > I have made the changes as suggested by Giorgio. Please let me know if any > further changes required. > From 8a1f5216baa1a2ce741359ed4e83871b2ab790d8 Mon Sep 17 00:00:00 2001 > From: Supraja Meedinti > Date: Sat, 21 Feb 2015 19:05:39 +053

Re: [FFmpeg-devel] tools: crypto_bench: Added support for Twofish

2015-02-21 Thread supraja reddy
Hello, I have made the changes as suggested by Giorgio. Please let me know if any further changes required. Thanks, Supraja On Wed, Feb 18, 2015 at 10:52 PM, Giorgio Vazzana wrote: > Hi, > > 2015-02-14 11:12 GMT+01:00 Giorgio Vazzana : > > Hi, > > > > 2015-02-14 9:33 GMT+01:00 supraja reddy :

Re: [FFmpeg-devel] [PATCH] libavformat/rtpdec: fix issue with conversion from unsigned to signed

2015-02-21 Thread Michael Niedermayer
On Fri, Feb 20, 2015 at 07:14:53AM +0100, Gilles Chanteperdrix wrote: > When receiving an RTCP packet, the difference between the last RTCP > timestamp and the base timestamp may be negative. As these timestamps > are of the uint32_t type, the result becomes a large integer. Cast > the difference t

[FFmpeg-devel] [PATCH] avcodec/x86/mlpdsp_init: Simplify mlp_filter_channel_x86()

2015-02-21 Thread Michael Niedermayer
Based on patch by Francisco Blas Izquierdo Riera Commit message partly taken from carl fixes a compilation error in mlpdsp_init.c with -fstack-check and some gcc compilers (I reproduced the issue with gcc 4.7.3) by simplifying the code. See also https://bugs.gentoo.org/show_bug.cgi?id=471756 $ m

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/tak: clarify the size of residues buffer

2015-02-21 Thread Paul B Mahol
On 2/21/15, James Almer wrote: > Signed-off-by: James Almer > --- > At least this is what i interpreted 544 meant. This patch can be discarded > otherwise. > > libavcodec/takdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/takdec.c b/libavcodec/takdec.c >

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/tak: remove unnecessary calls to emms_c()

2015-02-21 Thread Paul B Mahol
On 2/21/15, James Almer wrote: > It's already called by scalarproduct_int16 if required. > > Signed-off-by: James Almer > --- > libavcodec/takdec.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/libavcodec/takdec.c b/libavcodec/takdec.c > index 0f808e0..77170b5 100644 > --- a/libavco

Re: [FFmpeg-devel] [PATCH] lavfi: add showvolume filter

2015-02-21 Thread Paul B Mahol
On 2/20/15, Clement Boesch wrote: > On Fri, Feb 20, 2015 at 02:28:21PM +, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> libavfilter/Makefile | 1 + >> libavfilter/allfilters.c | 1 + >> libavfilter/avf_showvolume.c | 197 >> +

Re: [FFmpeg-devel] [PATCH] avcodec/tak: reset filter buffers

2015-02-21 Thread Paul B Mahol
On 2/21/15, James Almer wrote: > Zeroing them allows us to use scalarproduct_int16 even if the length of > vectors is not multiple of 16. > > Signed-off-by: James Almer > --- > libavcodec/takdec.c | 28 +--- > 1 file changed, 5 insertions(+), 23 deletions(-) > > diff --gi

Re: [FFmpeg-devel] [PATCH] x86/doc/Makefile: DBG=1 to preprocess external asm

2015-02-21 Thread Michael Niedermayer
On Wed, Feb 18, 2015 at 10:57:20AM +0100, Christophe Gisquet wrote: > Hi, > > 2015-02-17 20:06 GMT+01:00 James Almer : > > $ make libavcodec/x86/dcadsp.o DBG=0 > > OK, it's mainly a matter of documentation then here, as just having > DBG defined is fine. I'm not sure of the makefile syntax if DBG