On Wed, Feb 18, 2015 at 10:57:20AM +0100, Christophe Gisquet wrote: > Hi, > > 2015-02-17 20:06 GMT+01:00 James Almer <jamr...@gmail.com>: > > $ make libavcodec/x86/dcadsp.o DBG=0 > > OK, it's mainly a matter of documentation then here, as just having > DBG defined is fine. I'm not sure of the makefile syntax if DBG=1 is > what is really wanted. > > > YASM libavcodec/x86/dcadsp.dbg.asm > > YASM libavcodec/x86/dcadsp.o > > STRIP libavcodec/x86/dcadsp.o > > rm libavcodec/x86/dcadsp.dbg.asm > > Huh, a rm command isn't issued in the rule... > > On the other hand, running make with debugging states: > Successfully remade target file `libavcodec/x86/dcadsp.o'. > Removing intermediate files... > rm libavcodec/x86/dcadsp.dbg.asm > > So, in a way, the above is quite ok: no need to keep > libavcodec/x86/dcadsp.dbg.asm around if compilation was ok. > > But if you run the command a 2nd time, it does keep it around :( > And it shouldn't even attempt this because compilation is succesful. > > I think this a dependency rule issue for the .dbg.asm file > > But even with the attached file, it still rebuilds it an additional > time. But third time is the charm, as it stops rebuilding it... > > > $ rm libavcodec/x86/dcadsp.o > > > > $ make libavcodec/x86/dcadsp.o > > YASM libavcodec/x86/dcadsp.dbg.asm > > This seems fixed with the attached patch. > > But I wonder if a dependency rule is really needed, as I can see it > causing issues... (does it depend on .asm or .dbg.asm etc) > > So I don't think we there yet. > > -- > Christophe
> common.mak | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > 2a0b33b095b7c6136bb69a6835b3c7a2966cc732 > 0001-Makefile-improve-DBG-option-for-asm.patch > From f3365ec79b096dad0ccd7246b78ea9b7074f3b49 Mon Sep 17 00:00:00 2001 > From: Christophe Gisquet <christophe.gisq...@gmail.com> > Date: Wed, 18 Feb 2015 10:51:17 +0100 > Subject: [PATCH] Makefile: improve DBG option for asm > > This improves the cleanup, dependency generation and DBG command issuing. applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Concerning the gods, I have no means of knowing whether they exist or not or of what sort they may be, because of the obscurity of the subject, and the brevity of human life -- Protagoras
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
