Hi,
2015-02-05 7:29 GMT+01:00 Christophe Gisquet :
> We were previously reference-counting the sao-buffer. Should we do
> that for sao_pixel_buffer_[hv], then?
Something like the attached patch.
Note: I'm probably overallocating compared to previously, but that
doesn't look to be a big deal.
On
Hi,
2015-02-04 2:05 GMT+01:00 Michael Niedermayer :
> applied the cherry picked code and the update
James mentioned this issue:
http://fate.ffmpeg.org/report.cgi?time=20150205015545&slot=x86_64-archlinux-gcc-valgrindundef
This looks like a missing free:
==15442==at 0x4C2C526: memalign (in
/u
On Wed, 4 Feb 2015 21:11:34 +0100, Clément Bœsch wrote:
> This reverts commit 23ec8db8a07467a1fbef0c79f16b33040ca63c24.
>
> There is no reason to enable libxcb by default. This is inconsistent
> with all the other libs (we don't do it for x11, opengl, ...) and drag
> many unwanted dependencies b
The stride_src parameter is always 2*MAX_PB_SIZE + FF_INPUT_BUFFER_PADDING_SIZE.
Signed-off-by: James Almer
---
libavcodec/hevc_filter.c | 5 ++---
libavcodec/hevcdsp.h | 6 +++---
libavcodec/hevcdsp_template.c | 5 ++---
3 files changed, 7 insertions(+), 9 deletions(-)
diff --git
Original x86 intrinsics code and initial yasm port by Pierre-Edouard Lepere.
Refactoring and optimizations by James Almer.
Benchmarks of BQTerrace_1920x1080_60_qp22.bin with an Intel Core i5-4200U
Width 32
158583 decicycles in edge, sao_edge_filter_8 runs, 0 skips
5205 decicycles in ff_hevc_sao_e
Original x86 intrinsics code by Pierre-Edouard Lepere.
Yasm port, refactoring and optimizations by James Almer.
Benchmarks of Main_422_10_B_RExt_Sony_1.bin with an Intel Core i5-4200U
Width 32
342694 decicycles in sao_edge_filter_10, 16384 runs, 0 skips
29476 decicycles in ff_hevc_sao_edge_filter
On Wed, 04 Feb 2015 21:13:57 +0100
Timo Rothenpieler wrote:
> > Could I get a proper review on this? I'd like to believe that we
> > have a consensus that, independent of whether we think there's
> > merit in this compensation logic, it shouldn't exist in a single
> > encoder, out of step with al
On 05.02.2015 03:04, Michael Niedermayer wrote:
On Thu, Feb 05, 2015 at 01:06:33AM +0100, Lukasz Marek wrote:
ff_avc_write_annexb_extradata() allocates extradata, but don't add
FF_INPUT_BUFFER_PADDING_SIZE value
Signed-off-by: Lukasz Marek
---
libavformat/avc.c | 2 +-
1 file changed, 1 ins
On Thu, Feb 05, 2015 at 01:06:33AM +0100, Lukasz Marek wrote:
> ff_avc_write_annexb_extradata() allocates extradata, but don't add
> FF_INPUT_BUFFER_PADDING_SIZE value
>
> Signed-off-by: Lukasz Marek
> ---
> libavformat/avc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
LGTM
[...]
-
On Wed, Feb 04, 2015 at 09:13:57PM +0100, Timo Rothenpieler wrote:
> > Could I get a proper review on this? I'd like to believe that we have a
> > consensus that, independent of whether we think there's merit in this
> > compensation logic, it shouldn't exist in a single encoder, out of
> > step wi
ff_avc_write_annexb_extradata() allocates extradata, but don't add
FF_INPUT_BUFFER_PADDING_SIZE value
Signed-off-by: Lukasz Marek
---
libavformat/avc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/avc.c b/libavformat/avc.c
index c927b47..9d843e0 100644
--- a/li
On 04.02.2015 21:39, Carl Eugen Hoyos wrote:
Clément Bœsch pkh.me> writes:
This reverts commit 23ec8db8a07467a1fbef0c79f16b33040ca63c24.
There is no reason to enable libxcb by
default. This is inconsistent with all the
other libs (we don't do it for x11, opengl, ...)
x11grab is not lgpl (th
Hi!
Attached patch implements reading uyvy, yuv444 and yuva444 dpx files.
yuva444 is untested.
Please comment, Carl Eugen
diff --git a/libavcodec/dpx.c b/libavcodec/dpx.c
index 3b78486..8eb0d22 100644
--- a/libavcodec/dpx.c
+++ b/libavcodec/dpx.c
@@ -173,9 +173,14 @@ static int decode_frame(AVCod
Hi!
Attached patch fixes the crash from ticket #4296 for me.
Please review, Carl Eugen
diff --git a/libavformat/mlvdec.c b/libavformat/mlvdec.c
index d0c51ae..9d821bb 100644
--- a/libavformat/mlvdec.c
+++ b/libavformat/mlvdec.c
@@ -242,6 +242,7 @@ static int read_header(AVFormatContext *avctx)
On Wed, Feb 04, 2015 at 09:30:15PM +, Carl Eugen Hoyos wrote:
> Clément Bœsch pkh.me> writes:
>
> > > > drag many unwanted dependencies by default.
> > >
> > > The only additional dependency I see here is
> > > libxcb itself: I cannot remove this library
> > > from my system (my package ma
Clément Bœsch pkh.me> writes:
> > > drag many unwanted dependencies by default.
> >
> > The only additional dependency I see here is
> > libxcb itself: I cannot remove this library
> > from my system (my package manager then wants
> > to remove another 450 packets) - does it work
> > for you
On Wed, Feb 04, 2015 at 08:51:00PM +, Carl Eugen Hoyos wrote:
> Clément Bœsch pkh.me> writes:
>
> > This reverts commit 23ec8db8a07467a1fbef0c79f16b33040ca63c24.
> >
> > There is no reason to enable libxcb by default.
> > This is inconsistent with all the other libs
> > (we don't do it for
On Tue, Feb 03, 2015 at 09:01:30AM -0800, Liviu Oniciuc wrote:
> at this time the drawtext box extends only for the width and height
> of the text. for a better visual appearance a new option was added
> (boxboderw) to set how much the box should extend outside of the
boxborderw
> text area
>
>
On 04/02/15 4:23 AM, Mickaël Raulet wrote:
> lgtm.
>
> Mickael
Applied. Thanks.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
On 04/02/15 4:23 AM, Mickaël Raulet wrote:
> ok.
>
> 2015-02-04 8:07 GMT+01:00 Christophe Gisquet :
>
>> Hi,
>>
>> 2015-02-04 4:55 GMT+01:00 James Almer :
>> [...]
>>
>> Ok, no need to resend a refreshed patch if patch 2/6 changes.
>>
>> --
>> Christophe
Applied. Thanks.
___
On 04/02/15 4:22 AM, Mickaël Raulet wrote:
> OK too.
>
> 2015-02-04 8:04 GMT+01:00 Christophe Gisquet :
>
>> Hi,
>>
>> 2015-02-04 4:55 GMT+01:00 James Almer :
>>> +int a_stride, b_stride;
>>> +int src_offset = 0;
>>> +int dst_offset = 0;
>>
>> Could maybe use ptrdiff_t type, like the
On 04/02/15 4:21 AM, Mickaël Raulet wrote:
> Ok too.
>
> 2015-02-04 8:09 GMT+01:00 Christophe Gisquet :
>
>> Hi,
>>
>> 2015-02-04 6:13 GMT+01:00 Michael Niedermayer :
>>> On Wed, Feb 04, 2015 at 12:55:48AM -0300, James Almer wrote:
From: Seppo Tomperi
---
libavcodec/hevc_fil
Clément Bœsch pkh.me> writes:
> This reverts commit 23ec8db8a07467a1fbef0c79f16b33040ca63c24.
>
> There is no reason to enable libxcb by default.
> This is inconsistent with all the other libs
> (we don't do it for x11, opengl, ...) and
> drag many unwanted dependencies by default.
The only
Clément Bœsch pkh.me> writes:
> This reverts commit 23ec8db8a07467a1fbef0c79f16b33040ca63c24.
>
> There is no reason to enable libxcb by
> default. This is inconsistent with all the
> other libs (we don't do it for x11, opengl, ...)
x11grab is not lgpl (that is what you meant
with x11, no?)
Hi,
2015-02-04 21:14 GMT+01:00 James Almer :
> On 04/02/15 9:39 AM, Christophe Gisquet wrote:
>> Are the first number for each case from before you split out the
>> restore part? Otherwise, that's gruesome.
>
> The benchmarks were done with every patch up to this one applied, so yes,
> after the
> Could I get a proper review on this? I'd like to believe that we have a
> consensus that, independent of whether we think there's merit in this
> compensation logic, it shouldn't exist in a single encoder, out of
> step with all the other encoders in ffmpeg.
>
> Thanks,
It looks good to merge f
On 04/02/15 9:39 AM, Christophe Gisquet wrote:
> Are the first number for each case from before you split out the
> restore part? Otherwise, that's gruesome.
The benchmarks were done with every patch up to this one applied, so yes, after
the
split. The file i used to bench went from ~36fps to ~4
On Wed, Feb 04, 2015 at 09:11:34PM +0100, Clément Bœsch wrote:
> This reverts commit 23ec8db8a07467a1fbef0c79f16b33040ca63c24.
>
> There is no reason to enable libxcb by default. This is inconsistent
> with all the other libs (we don't do it for x11, opengl, ...) and drag
> many unwanted dependenc
This reverts commit 23ec8db8a07467a1fbef0c79f16b33040ca63c24.
There is no reason to enable libxcb by default. This is inconsistent
with all the other libs (we don't do it for x11, opengl, ...) and drag
many unwanted dependencies by default. We'll get cursed by packagers
pretty soon because of this
LGTM.
Mickael
2015-02-04 13:51 GMT+01:00 Christophe Gisquet
:
> Hi,
>
> 2015-02-04 4:55 GMT+01:00 James Almer :
>
> > -DECLARE_ALIGNED(16, const xmm_reg, ff_pw_1)= {
> 0x0001000100010001ULL, 0x0001000100010001ULL };
> > -DECLARE_ALIGNED(16, const xmm_reg, ff_pw_2)= {
> 0x0002000200020
LGTM
Mickael
2015-02-04 13:39 GMT+01:00 Christophe Gisquet
:
> Hi,
>
> 2015-02-04 4:55 GMT+01:00 James Almer :
> > Original x86 intrinsics code and initial yasm port by Pierre-Edouard
> Lepere.
> > Refactoring and optimizations by James Almer.
>
> Add your own copyright to this file then.
>
> >
Am 04.02.15 um 14:45 schrieb Paul B Mahol:
> Signed-off-by: Paul B Mahol
> ---
> libavcodec/alsdec.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
ok
-Thilo
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/l
On Wed, Feb 04, 2015 at 01:53:20PM +0100, Thilo Borgmann wrote:
> Am 04.02.15 um 13:48 schrieb Thilo Borgmann:
> > [PATCH] configure: Check linking against CoreGraphics or
> > ApplicationServices framework for avfoundation input device.
> >
> > Fixes ticket #4238.
>
> Updated patch without blank
On Wed, Feb 04, 2015 at 02:01:16AM -0300, James Almer wrote:
> Signed-off-by: James Almer
> ---
> I made it abort only if AV_EF_EXPLODE is also set like we do when decoding
> audio frames, but maybe aborting if the header or seek table are damaged
> should be the default behaviour. Chances are a
On Tue, Feb 03, 2015 at 10:41:19PM +0100, Hendrik Leppkes wrote:
> The scaling list can be specified in either the SPS or PPS.
> Additionally, compensate for the diagonal scan permutation applied in the
> decoder.
> ---
> libavcodec/dxva2_hevc.c | 22 ++
> 1 file changed, 14 i
On Wed, Feb 04, 2015 at 12:52:05PM +0100, Stefano Sabatini wrote:
> On date Wednesday 2015-02-04 12:26:15 +0100, Stefano Sabatini encoded:
> > This requires the new sample file matrixbench_mpeg2.lq1.mpg.
> > ---
> > tests/fate/filter-video.mak | 3 +++
> > tests/ref/fate/filter-spp | 26 +++
On Wed, Feb 04, 2015 at 12:26:15PM +0100, Stefano Sabatini wrote:
> This requires the new sample file matrixbench_mpeg2.lq1.mpg.
> ---
> tests/fate/filter-video.mak | 3 +++
> tests/ref/fate/filter-spp | 26 ++
> 2 files changed, 29 insertions(+)
> create mode 100644 te
On Wed, Feb 04, 2015 at 03:23:59PM +0100, Michael Niedermayer wrote:
> On Wed, Feb 04, 2015 at 12:34:53PM +0100, Stefano Sabatini wrote:
> > On date Monday 2015-02-02 23:22:09 +0100, Michael Niedermayer encoded:
> > > Signed-off-by: Michael Niedermayer
> > > ---
> > > ffprobe.c |2 +-
> > > 1
On Wed, Feb 04, 2015 at 12:34:53PM +0100, Stefano Sabatini wrote:
> On date Monday 2015-02-02 23:22:09 +0100, Michael Niedermayer encoded:
> > Signed-off-by: Michael Niedermayer
> > ---
> > ffprobe.c |2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/ffprobe.c b/ff
On Wed, Feb 04, 2015 at 01:18:54PM +0100, wm4 wrote:
> On Wed, 4 Feb 2015 01:00:06 +0100
> Michael Niedermayer wrote:
>
> > On Tue, Feb 03, 2015 at 09:44:13PM +0100, Reimar Döffinger wrote:
> > > On Tue, Feb 03, 2015 at 07:04:11PM +0100, wm4 wrote:
> > > > This could overflow and crash at least o
On date Wednesday 2015-02-04 01:30:09 +0530, Eejya Singh encoded:
> Hi,
> I've implemented a force_style option in the subtitles filter. Kindly find
> the patch attached.
>
> --
> Eejya Singh,
> 3rd year undergraduate,
> Computer Science,
> BITS Pilani Goa Campus
> From 88014fde69b249d3b1cb8e6bd
Signed-off-by: Paul B Mahol
---
libavcodec/alsdec.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavcodec/alsdec.c b/libavcodec/alsdec.c
index cfece44..b3d3086 100644
--- a/libavcodec/alsdec.c
+++ b/libavcodec/alsdec.c
@@ -1478,7 +1478,8 @@ static int decode_frame(AVCod
Am 04.02.15 um 13:48 schrieb Thilo Borgmann:
> [PATCH] configure: Check linking against CoreGraphics or
> ApplicationServices framework for avfoundation input device.
>
> Fixes ticket #4238.
Updated patch without blank line.
-Thilo
>From 921f571d601fe51d21ec29320a157dc4e0ba72ed Mon Sep 17 00:00
Hi,
2015-02-04 4:55 GMT+01:00 James Almer :
> -DECLARE_ALIGNED(16, const xmm_reg, ff_pw_1)= { 0x0001000100010001ULL,
> 0x0001000100010001ULL };
> -DECLARE_ALIGNED(16, const xmm_reg, ff_pw_2)= { 0x0002000200020002ULL,
> 0x0002000200020002ULL };
> +DECLARE_ALIGNED(32, const ymm_reg, ff
Hi,
fixes Ticket #4238.
Testing for CGImageGetTypeID function is questionable (see trac discussion).
If someone has a better idea, please let me know.
-Thilo
From be77bd85b61a922b442235ef7a0c494137672890 Mon Sep 17 00:00:00 2001
From: Thilo Borgmann
Date: Wed, 4 Feb 2015 13:44:43 +0100
Subject:
Hi,
2015-02-04 4:55 GMT+01:00 James Almer :
> Original x86 intrinsics code and initial yasm port by Pierre-Edouard Lepere.
> Refactoring and optimizations by James Almer.
Add your own copyright to this file then.
> Width 32
> 158583 decicycles in edge, sao_edge_filter_8 runs, 0 skips
> 5205 deci
On Wed, 4 Feb 2015 01:00:06 +0100
Michael Niedermayer wrote:
> On Tue, Feb 03, 2015 at 09:44:13PM +0100, Reimar Döffinger wrote:
> > On Tue, Feb 03, 2015 at 07:04:11PM +0100, wm4 wrote:
> > > This could overflow and crash at least on 32 bit systems.
> > > ---
> > > libavformat/mpc8.c | 2 +-
> >
On date Tuesday 2015-02-03 11:26:13 -0800, Liviu Oniciuc encoded:
> ---
> doc/muxers.texi | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/doc/muxers.texi b/doc/muxers.texi
> index b0bed7e..a8225fc 100644
> --- a/doc/muxers.texi
> +++ b/doc/muxers.texi
> @@ -381,8 +381,7
Hi,
I've been looking at what the appropriate place and method to read in
the ACLR atom placed in the Avid codecs so that we can automatically
set the color_range.
>From my reading of the code the mov.c code the parse table shunts the
reading of the atom to mov_read_avid(), which in turn calls
mo
On date Monday 2015-02-02 23:22:09 +0100, Michael Niedermayer encoded:
> Signed-off-by: Michael Niedermayer
> ---
> ffprobe.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ffprobe.c b/ffprobe.c
> index d352bb6b..30f9cba 100644
> --- a/ffprobe.c
> +++ b/ffprobe.c
> @
This requires the new sample file matrixbench_mpeg2.lq1.mpg.
---
tests/fate/filter-video.mak | 3 +++
tests/ref/fate/filter-spp | 26 ++
2 files changed, 29 insertions(+)
create mode 100644 tests/ref/fate/filter-spp
diff --git a/tests/fate/filter-video.mak b/tests/fate
51 matches
Mail list logo
