[FFmpeg-devel] [PATCH] nvenc: Propagate desired number of reference frames.

2015-01-23 Thread Philip Langdale
Signed-off-by: Philip Langdale --- libavcodec/nvenc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index c52beb7..e68bbe9 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -614,6 +614,11 @@ static av_cold int nvenc_encode_init(AVCodecC

Re: [FFmpeg-devel] [PATCH] lavc/libopenjpegenc: move opj_setup_encoder to libopenjpeg_encode_frame

2015-01-23 Thread Michael Niedermayer
On Fri, Jan 23, 2015 at 11:57:26PM +0100, Jean First wrote: > On Fri Jan 23 2015 23:39:21 GMT+0100 (CET), Michael Niedermayer wrote: > >On Fri, Jan 23, 2015 at 11:34:35PM +0100, Michael Niedermayer wrote: > >>On Fri, Jan 23, 2015 at 09:58:41PM +0100, Jean First wrote: > >>>if the openjpeg parameter

Re: [FFmpeg-devel] dshow crossbar support PATCH es

2015-01-23 Thread Michael Niedermayer
On Fri, Jan 23, 2015 at 07:06:39AM -0700, Roger Pack wrote: > OK I have made modifications to the dshow source so that it adds the > ability to specify capture device by "more unique" name, capture pin > by name, crossbar device support [this is basically any capture source > with multiple inputs--

Re: [FFmpeg-devel] [PATCH] lavc/libopenjpegenc: move opj_setup_encoder to libopenjpeg_encode_frame

2015-01-23 Thread Jean First
On Fri Jan 23 2015 23:39:21 GMT+0100 (CET), Michael Niedermayer wrote: On Fri, Jan 23, 2015 at 11:34:35PM +0100, Michael Niedermayer wrote: On Fri, Jan 23, 2015 at 09:58:41PM +0100, Jean First wrote: if the openjpeg parameter tcp_rates is not 0 ( using the ffmpeg compression_level option ) eve

Re: [FFmpeg-devel] [PATCH] lavc/libopenjpegenc: move opj_setup_encoder to libopenjpeg_encode_frame

2015-01-23 Thread Michael Niedermayer
On Fri, Jan 23, 2015 at 11:34:35PM +0100, Michael Niedermayer wrote: > On Fri, Jan 23, 2015 at 09:58:41PM +0100, Jean First wrote: > > if the openjpeg parameter tcp_rates is not 0 ( using the ffmpeg > > compression_level option ) > > every 2nd image per thread is badly encoded. By moving the > >

Re: [FFmpeg-devel] [PATCH] lavc/libopenjpegenc: move opj_setup_encoder to libopenjpeg_encode_frame

2015-01-23 Thread Michael Niedermayer
On Fri, Jan 23, 2015 at 09:58:41PM +0100, Jean First wrote: > if the openjpeg parameter tcp_rates is not 0 ( using the ffmpeg > compression_level option ) > every 2nd image per thread is badly encoded. By moving the opj_setup_encoder > function from > libopenjpeg_encode_init to libopenjpeg_encod

[FFmpeg-devel] [PATCH] lavc/libopenjpegenc: move opj_setup_encoder to libopenjpeg_encode_frame

2015-01-23 Thread Jean First
if the openjpeg parameter tcp_rates is not 0 ( using the ffmpeg compression_level option ) every 2nd image per thread is badly encoded. By moving the opj_setup_encoder function from libopenjpeg_encode_init to libopenjpeg_encode_frame this can be prevented. This fixes ticket #3754. Signed-off-b

Re: [FFmpeg-devel] [PATCH] Decoder for CEA-608 and World System Teletext [WIP]

2015-01-23 Thread Anshul
On January 23, 2015 7:05:28 PM IST, Michael Niedermayer wrote: >On Fri, Jan 23, 2015 at 01:49:44PM +0100, wm4 wrote: >> On Fri, 23 Jan 2015 13:40:36 +0100 >> Hendrik Leppkes wrote: >> >> > On Fri, Jan 23, 2015 at 1:33 PM, wm4 wrote: >> > >> > > On Fri, 23 Jan 2015 04:42:22 +0100 >> > > Michae

Re: [FFmpeg-devel] [PATCH] nvenc: Propagate desired number of reference frames.

2015-01-23 Thread Philip Langdale
On 2015-01-23 01:54, Timo Rothenpieler wrote: +ctx->encode_config.encodeCodecConfig.h264Config.maxNumRefFrames = avctx->refs; avctx->refs should propably be checked for >= 0. I'm not sure if maxNumRefFrames means the exact same thing as avctx->refs, but the comment in the nvenc header isn'

Re: [FFmpeg-devel] Question about supported_fps in libavutil/timecode.c::check_fps

2015-01-23 Thread jon morley
Patch attached for consideration. On 1/23/15 8:03 AM, jon morley wrote: Currently check_fps has the following logic: static int check_fps(int fps) { int i; static const int supported_fps[] = {24, 25, 30, 48, 50, 60}; for (i = 0; i < FF_ARRAY_ELEMS(supported_fps); i++) i

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to FFmpeg

2015-01-23 Thread Stefano Sabatini
On date Friday 2015-01-23 20:44:01 +0530, Arwa Arif encoded: [...] > > Looks good otherwise, assuming it is bitexact with the mp=eq2. > > > > The default is bit-exact with mp=eq2, I can't check it with other values, > because the range of values in mp is different from the range of values in > thi

Re: [FFmpeg-devel] [PATCH] web/download: Change main snapshot url to point to github

2015-01-23 Thread Michael Niedermayer
On Fri, Jan 23, 2015 at 02:12:30PM +0100, Clément Bœsch wrote: > On Fri, Jan 23, 2015 at 03:31:28AM +0100, Michael Niedermayer wrote: > > The url did just end at a "403 - Snapshots not allowed" > > > > We also could point to ffmpeg.org, but the snapshots there are upto 24h old > > with the current

[FFmpeg-devel] Question about supported_fps in libavutil/timecode.c::check_fps

2015-01-23 Thread jon morley
Currently check_fps has the following logic: static int check_fps(int fps) { int i; static const int supported_fps[] = {24, 25, 30, 48, 50, 60}; for (i = 0; i < FF_ARRAY_ELEMS(supported_fps); i++) if (fps == supported_fps[i]) return 0; return -1; } I am start

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to FFmpeg

2015-01-23 Thread arwa arif
On Fri, Jan 23, 2015 at 8:05 PM, Stefano Sabatini wrote: > On date Thursday 2015-01-22 01:38:11 +0530, Arwa Arif encoded: > > On Thu, Jan 22, 2015 at 12:09 AM, Paul B Mahol wrote: > [...] > > From 703cc1887903c2868537e19e99b76927bec07884 Mon Sep 17 00:00:00 2001 > > From: Arwa Arif > > Date: Mo

Re: [FFmpeg-devel] [PATCH] Decoder for CEA-608 and World System Teletext [WIP]

2015-01-23 Thread compn
On Fri, 23 Jan 2015 04:42:22 +0100 Michael Niedermayer wrote: > From: Shan > > Patch fixed by Shan so it builds and passes fate > > version 2.5: > diff --git a/MAINTAINERS b/MAINTAINERS > index 13b211e..ae7610b 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -267,6 +267,7 @@ Codecs: >

Re: [FFmpeg-devel] Suggested Patch for timecode timebase calculation in mov.c

2015-01-23 Thread jon
Hi Michael, That is great! I see what you are referring to in mov_read_timecode_track(). However the text of that comment seems contradictory to me based on what I have read in the QuickTime reference I sited about the tmcd counter flag. It seemed like prior to the patch I submitted mov_pars

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to FFmpeg

2015-01-23 Thread Stefano Sabatini
On date Thursday 2015-01-22 01:38:11 +0530, Arwa Arif encoded: > On Thu, Jan 22, 2015 at 12:09 AM, Paul B Mahol wrote: [...] > From 703cc1887903c2868537e19e99b76927bec07884 Mon Sep 17 00:00:00 2001 > From: Arwa Arif > Date: Mon, 19 Jan 2015 03:56:48 +0530 > Subject: [PATCH] Port mp=eq/eq2 to FFmp

[FFmpeg-devel] dshow crossbar support PATCH es

2015-01-23 Thread Roger Pack
OK I have made modifications to the dshow source so that it adds the ability to specify capture device by "more unique" name, capture pin by name, crossbar device support [this is basically any capture source with multiple inputs--definitely the most requested feature to date] and ability to use "c

Re: [FFmpeg-devel] [PATCH] Decoder for CEA-608 and World System Teletext [WIP]

2015-01-23 Thread Michael Niedermayer
On Fri, Jan 23, 2015 at 01:49:44PM +0100, wm4 wrote: > On Fri, 23 Jan 2015 13:40:36 +0100 > Hendrik Leppkes wrote: > > > On Fri, Jan 23, 2015 at 1:33 PM, wm4 wrote: > > > > > On Fri, 23 Jan 2015 04:42:22 +0100 > > > Michael Niedermayer wrote: > > > > > > > diff --git a/libavcodec/avcodec.h b/l

Re: [FFmpeg-devel] Suggested Patch for timecode timebase calculation in mov.c

2015-01-23 Thread Michael Niedermayer
On Fri, Jan 23, 2015 at 04:26:59AM +0100, Michael Niedermayer wrote: > On Thu, Jan 22, 2015 at 09:09:53AM -0800, jon wrote: > > I never heard back about this and I think I have a new better > > are you subscribed to ffmpeg-devel ? > > > > solution now. I don't think the current mov.c timecode pr

Re: [FFmpeg-devel] [PATCH] web/download: Change main snapshot url to point to github

2015-01-23 Thread Clément Bœsch
On Fri, Jan 23, 2015 at 03:31:28AM +0100, Michael Niedermayer wrote: > The url did just end at a "403 - Snapshots not allowed" > > We also could point to ffmpeg.org, but the snapshots there are upto 24h old > with the current cronjob > --- > src/download |2 +- > 1 file changed, 1 insertion(+

Re: [FFmpeg-devel] [PATCH] Decoder for CEA-608 and World System Teletext [WIP]

2015-01-23 Thread wm4
On Fri, 23 Jan 2015 13:40:36 +0100 Hendrik Leppkes wrote: > On Fri, Jan 23, 2015 at 1:33 PM, wm4 wrote: > > > On Fri, 23 Jan 2015 04:42:22 +0100 > > Michael Niedermayer wrote: > > > > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > > > index 99467bb..6a0fb5b 100644 > > > --- a/lib

Re: [FFmpeg-devel] [PATCH] Decoder for CEA-608 and World System Teletext [WIP]

2015-01-23 Thread Hendrik Leppkes
On Fri, Jan 23, 2015 at 1:33 PM, wm4 wrote: > On Fri, 23 Jan 2015 04:42:22 +0100 > Michael Niedermayer wrote: > > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > > index 99467bb..6a0fb5b 100644 > > --- a/libavcodec/avcodec.h > > +++ b/libavcodec/avcodec.h > > @@ -503,11 +503,13 @@ e

Re: [FFmpeg-devel] [PATCH] Decoder for CEA-608 and World System Teletext [WIP]

2015-01-23 Thread wm4
On Fri, 23 Jan 2015 04:42:22 +0100 Michael Niedermayer wrote: > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > index 99467bb..6a0fb5b 100644 > --- a/libavcodec/avcodec.h > +++ b/libavcodec/avcodec.h > @@ -503,11 +503,13 @@ enum AVCodecID { > AV_CODEC_ID_SSA, > AV_CODEC_ID_MO

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to FFmpeg

2015-01-23 Thread Stefano Sabatini
On date Wednesday 2015-01-21 20:38:20 +0530, Arwa Arif encoded: > > > > I still expect that eq and eq2 should have the same performances, > > since the adjust callback is set depending on the parameter values. So > > we should have a single eq filter. > > > > Please investigate about why you get di

Re: [FFmpeg-devel] [PATCH] web/download: Change main snapshot url to point to github

2015-01-23 Thread Paul B Mahol
On 1/23/15, Michael Niedermayer wrote: > The url did just end at a "403 - Snapshots not allowed" > > We also could point to ffmpeg.org, but the snapshots there are upto 24h old > with the current cronjob > --- > src/download |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > lgtm _

Re: [FFmpeg-devel] [PATCH] nvenc: Propagate desired number of reference frames.

2015-01-23 Thread Christophe Gisquet
Hi, 2015-01-23 10:54 GMT+01:00 Timo Rothenpieler : > This would also forward the ffmpeg default, 1, to nvenc, instead of the > nvenc default, 0, which lets the driver decide what is best. I'm not sure if > this is desireable and how much it affects the quality. In that case, why not set ffmpeg's

Re: [FFmpeg-devel] [PATCH] nvenc: Propagate desired number of reference frames.

2015-01-23 Thread Timo Rothenpieler
+ctx->encode_config.encodeCodecConfig.h264Config.maxNumRefFrames = avctx->refs; avctx->refs should propably be checked for >= 0. I'm not sure if maxNumRefFrames means the exact same thing as avctx->refs, but the comment in the nvenc header isn't exactly clear about that. This would als