Re: [FFmpeg-devel] [PATCH 2/2] rtpenc_h263_rfc2190: avoid misleading error output

2014-09-21 Thread Michael Niedermayer
On Sun, Sep 21, 2014 at 05:43:16PM +0200, Thomas Volkert wrote: > From: Thomas Volkert > > --- > libavformat/rtpenc_h263_rfc2190.c | 15 +++ > 1 file changed, 7 insertions(+), 8 deletions(-) applied thanks -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Re: [FFmpeg-devel] [PATCH] Add input support for DeckLink devices.

2014-09-21 Thread Michael Niedermayer
On Tue, Sep 02, 2014 at 11:26:13AM +0200, Deti Fliegl wrote: > On 30.08.14 01:22, Michael Niedermayer wrote: > >moving code from (like from decklink_enc.cpp to decklink_common.cpp) > >should be in a seperate patch > Done. Both patches are attached to this mail. > > >If you want to maintain this co

Re: [FFmpeg-devel] [PATCH] avformat: Support merging side data before the muxer

2014-09-21 Thread Michael Niedermayer
On Sun, Sep 21, 2014 at 09:47:54PM +0200, wm4 wrote: > On Sun, 21 Sep 2014 21:37:14 +0200 > Michael Niedermayer wrote: > > > On Sun, Sep 21, 2014 at 09:23:18PM +0200, Nicolas George wrote: > > > Le jour de la Récompense, an CCXXII, Michael Niedermayer a écrit : > > > > This allows applications wh

Re: [FFmpeg-devel] [PATCH v3 1/1] configure: Refactor setting of feature test macro _XOPEN_SOURCE

2014-09-21 Thread Michael Niedermayer
On Sun, Sep 21, 2014 at 10:48:01PM +0200, Jörg Krause wrote: > Some C libraries, eg glibc, uclibc, and musl, uses feature test macros > to expose definitions conforming to the standards ISO C, POSIX and > extensions. According to which feature test macros are defined by the > user or the compile

[FFmpeg-devel] [PATCH v3 1/1] configure: Refactor setting of feature test macro _XOPEN_SOURCE

2014-09-21 Thread Jörg Krause
Some C libraries, eg glibc, uclibc, and musl, uses feature test macros to expose definitions conforming to the standards ISO C, POSIX and extensions. According to which feature test macros are defined by the user or the compiler, a header file, eg , used by these libraries internally defines va

Re: [FFmpeg-devel] [PATCH] avformat: Support merging side data before the muxer

2014-09-21 Thread Nicolas George
Le jour de la Récompense, an CCXXII, Michael Niedermayer a écrit : > user applications and libs which interface to FFmpeg or libavformat > through a URLProtocol or AVIOContext receive the AVPacket.data but > not AVPacket.side_data but the side data is often essential Yes, I know that. And this is

Re: [FFmpeg-devel] [PATCH] avformat: Support merging side data before the muxer

2014-09-21 Thread wm4
On Sun, 21 Sep 2014 21:37:14 +0200 Michael Niedermayer wrote: > On Sun, Sep 21, 2014 at 09:23:18PM +0200, Nicolas George wrote: > > Le jour de la Récompense, an CCXXII, Michael Niedermayer a écrit : > > > This allows applications which interface through AVIOContext or > > > URLProtocol > > > to

Re: [FFmpeg-devel] [PATCH] avformat: Support merging side data before the muxer

2014-09-21 Thread Michael Niedermayer
On Sun, Sep 21, 2014 at 09:23:18PM +0200, Nicolas George wrote: > Le jour de la Récompense, an CCXXII, Michael Niedermayer a écrit : > > This allows applications which interface through AVIOContext or URLProtocol > > to access side data. > > > > Based-on patch by: Thomas Volkert > > Signed-off-by

Re: [FFmpeg-devel] [PATCH] avformat: Support merging side data before the muxer

2014-09-21 Thread Michael Niedermayer
On Sun, Sep 21, 2014 at 09:20:23PM +0200, wm4 wrote: > On Sun, 21 Sep 2014 21:15:11 +0200 > Michael Niedermayer wrote: > > > This allows applications which interface through AVIOContext or URLProtocol > > to access side data. > > > > Based-on patch by: Thomas Volkert > > Signed-off-by: Michael

Re: [FFmpeg-devel] [PATCH] avformat: Support merging side data before the muxer

2014-09-21 Thread Nicolas George
Le jour de la Récompense, an CCXXII, Michael Niedermayer a écrit : > This allows applications which interface through AVIOContext or URLProtocol > to access side data. > > Based-on patch by: Thomas Volkert > Signed-off-by: Michael Niedermayer Can you point to the discussion about this patch and

Re: [FFmpeg-devel] [PATCH] avformat: Support merging side data before the muxer

2014-09-21 Thread wm4
On Sun, 21 Sep 2014 21:15:11 +0200 Michael Niedermayer wrote: > This allows applications which interface through AVIOContext or URLProtocol > to access side data. > > Based-on patch by: Thomas Volkert > Signed-off-by: Michael Niedermayer > --- > libavformat/avformat.h |1 + > libavformat/

Re: [FFmpeg-devel] [PATCH 10/17] avcodec/webvttdec: add some memory checks

2014-09-21 Thread Michael Niedermayer
On Sun, Sep 21, 2014 at 07:43:39PM +0200, Nicolas George wrote: > Le jour de la Récompense, an CCXXII, Clément Bœsch a écrit : > > One case that might break is when used as a callback. That's very unlikely > > to happen, but it's still a change in the public API. You might get some > > rainbow colo

[FFmpeg-devel] [PATCH] avformat: Support merging side data before the muxer

2014-09-21 Thread Michael Niedermayer
This allows applications which interface through AVIOContext or URLProtocol to access side data. Based-on patch by: Thomas Volkert Signed-off-by: Michael Niedermayer --- libavformat/avformat.h |1 + libavformat/mux.c |6 ++ libavformat/version.h |4 ++-- 3 files changed, 9

Re: [FFmpeg-devel] [PATCH 10/17] avcodec/webvttdec: add some memory checks

2014-09-21 Thread Nicolas George
Le jour de la Récompense, an CCXXII, Clément Bœsch a écrit : > One case that might break is when used as a callback. That's very unlikely > to happen, but it's still a change in the public API. You might get some > rainbow colors from http://upstream-tracker.org/ typically. All right, but only mic

Re: [FFmpeg-devel] [PATCH 10/17] avcodec/webvttdec: add some memory checks

2014-09-21 Thread Clément Bœsch
On Sun, Sep 21, 2014 at 07:36:19PM +0200, Nicolas George wrote: > Le jour de la Récompense, an CCXXII, Clément Bœsch a écrit : > > Doesn't this need at least a minor bump? > > I consider it a bug fix, not an API change. Can you imagine a case where > people would need to check for it? > One case

Re: [FFmpeg-devel] [PATCH 10/17] avcodec/webvttdec: add some memory checks

2014-09-21 Thread Nicolas George
Le jour de la Récompense, an CCXXII, Clément Bœsch a écrit : > Doesn't this need at least a minor bump? I consider it a bug fix, not an API change. Can you imagine a case where people would need to check for it? > Not really; in SAMI at least the buffer is allocated only once, and > finalized onl

Re: [FFmpeg-devel] [PATCH 10/17] avcodec/webvttdec: add some memory checks

2014-09-21 Thread Clément Bœsch
On Sun, Sep 21, 2014 at 07:19:43PM +0200, Nicolas George wrote: > Le jour de la Récompense, an CCXXII, Clément Bœsch a écrit : > > So I did that and pushed that part of the patchset, adjusted to use a > > bprint helper. > > > > Unfortunately, this raises a warning because av_bprint_is_complete() >

Re: [FFmpeg-devel] [PATCH 10/17] avcodec/webvttdec: add some memory checks

2014-09-21 Thread Nicolas George
Le jour de la Récompense, an CCXXII, Clément Bœsch a écrit : > So I did that and pushed that part of the patchset, adjusted to use a > bprint helper. > > Unfortunately, this raises a warning because av_bprint_is_complete() > doesn't take a const parameter. I was too lazy to actually fix the API, >

Re: [FFmpeg-devel] [PATCH 11/17] avformat/assenc: mux all extradata at once

2014-09-21 Thread Clément Bœsch
On Sun, Sep 21, 2014 at 08:32:15AM +0200, wm4 wrote: > On Sat, 20 Sep 2014 22:27:51 +0200 > Clément Bœsch wrote: > > > Before this commit, the code was muxing up to the 2nd line after > > "[Events]" (assuming it to be the "Format:" line). The remaining are > > generally "Comment:" directives whic

Re: [FFmpeg-devel] [PATCH 17/17] avformat/assenc: return correct error code

2014-09-21 Thread Clément Bœsch
On Sun, Sep 21, 2014 at 11:12:41AM +0200, Nicolas George wrote: > Le jour de la Raison, an CCXXII, Clément Bœsch a écrit : > > --- > > libavformat/assenc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > LGTM, of course. > Applied -- Clément B. pgpPlGTYrOkFV.pgp Description: P

Re: [FFmpeg-devel] [PATCH 10/17] avcodec/webvttdec: add some memory checks

2014-09-21 Thread Clément Bœsch
On Sun, Sep 21, 2014 at 11:20:26AM +0200, Nicolas George wrote: > Le jour de la Raison, an CCXXII, Clément Bœsch a écrit : > > --- > > libavcodec/webvttdec.c | 10 -- > > 1 file changed, 8 insertions(+), 2 deletions(-) > > Patches 5-10 look right, except most of them could benefit from th

Re: [FFmpeg-devel] in preparation of changing the internal form of decoded text subtitles

2014-09-21 Thread Clément Bœsch
On Sun, Sep 21, 2014 at 08:38:58AM +0200, wm4 wrote: > On Sat, 20 Sep 2014 22:27:40 +0200 > Clément Bœsch wrote: > > > Just a patchset to ease the transition to a sane internal form for the > > decoded > > text subtitles. > > > > [PATCH 01/17] avcodec/jacosubdec: add some memory checks > > [PAT

[FFmpeg-devel] [PATCH 1/2] mux: make sure that the AV_PKT_DATA_H263_MB_INFO side data is received by the H.263/RTP packetizer (rfc2190)

2014-09-21 Thread Thomas Volkert
From: Thomas Volkert --- libavformat/mux.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavformat/mux.c b/libavformat/mux.c index 55add43..ef90466 100644 --- a/libavformat/mux.c +++ b/libavformat/mux.c @@ -586,6 +586,16 @@ static int write_packet(AVFormatContext *s, AVPacket

[FFmpeg-devel] [PATCH 2/2] rtpenc_h263_rfc2190: avoid misleading error output

2014-09-21 Thread Thomas Volkert
From: Thomas Volkert --- libavformat/rtpenc_h263_rfc2190.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/libavformat/rtpenc_h263_rfc2190.c b/libavformat/rtpenc_h263_rfc2190.c index 0493008..34b3906 100644 --- a/libavformat/rtpenc_h263_rfc2190.c +++ b/libavf

[FFmpeg-devel] [PATCH v6] Add SUP/PGS subtitle demuxer

2014-09-21 Thread wm4
--- I hope I addressed all comments from the previous threads. DTS is now assumed to be unset if it's 0, otherwise it's kept. Still not sure about the probe score business. --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/supdec.c | 109

Re: [FFmpeg-devel] [PATCH] support for latest git of libilbc

2014-09-21 Thread Michael Niedermayer
On Sun, Sep 21, 2014 at 04:58:03PM +0200, Jan Ehrhardt wrote: > Michael Niedermayer in gmane.comp.video.ffmpeg.devel (Fri, 19 Sep 2014 > 09:52:19 +0200): > >On Thu, Sep 18, 2014 at 09:40:20PM -0700, Timothy Gu wrote: > >> On Thu, Sep 18, 2014 at 7:49 PM, Gianluigi Tiesi > >> wrote: > >> > Hi, > >

Re: [FFmpeg-devel] [PATCH] support for latest git of libilbc

2014-09-21 Thread Jan Ehrhardt
Michael Niedermayer in gmane.comp.video.ffmpeg.devel (Fri, 19 Sep 2014 09:52:19 +0200): >On Thu, Sep 18, 2014 at 09:40:20PM -0700, Timothy Gu wrote: >> On Thu, Sep 18, 2014 at 7:49 PM, Gianluigi Tiesi wrote: >> > Hi, >> > >> > in the latest git commits of libilbc developers removed WebRtc_xxx type

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: avoid early EOF with concatenated gapless mp3s

2014-09-21 Thread Michael Niedermayer
On Sun, Sep 21, 2014 at 04:26:37PM +0200, wm4 wrote: > On Sun, 21 Sep 2014 15:59:43 +0200 > James Darnley wrote: > > > On 2014-09-21 12:51, wm4 wrote: > > > it's easy to prevent at least early EOF. Playback will happen to work, > > > even if it's slightly broken. > > > > Do we want to print a wa

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: avoid early EOF with concatenated gapless mp3s

2014-09-21 Thread wm4
On Sun, 21 Sep 2014 15:59:43 +0200 James Darnley wrote: > On 2014-09-21 12:51, wm4 wrote: > > it's easy to prevent at least early EOF. Playback will happen to work, > > even if it's slightly broken. > > Do we want to print a warning in the "slightly broken" case? Does it > just mean that the mi

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: avoid early EOF with concatenated gapless mp3s

2014-09-21 Thread James Darnley
On 2014-09-21 12:51, wm4 wrote: > it's easy to prevent at least early EOF. Playback will happen to work, > even if it's slightly broken. Do we want to print a warning in the "slightly broken" case? Does it just mean that the middle cannot be gapless between file1 and file2? signature.asc Descr

Re: [FFmpeg-devel] [PATCH] rtpdec_hevc: do not print an error message if the received packet has a valid header but lacks additional bytes as payload

2014-09-21 Thread Michael Niedermayer
On Sun, Sep 21, 2014 at 01:50:12PM +0200, Thomas Volkert wrote: > From: Thomas Volkert > > --- > libavformat/rtpdec_hevc.c | 14 +- > 1 file changed, 9 insertions(+), 5 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB D

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: avoid early EOF with concatenated gapless mp3s

2014-09-21 Thread Michael Niedermayer
On Sun, Sep 21, 2014 at 12:51:41PM +0200, wm4 wrote: > Consider a file created with something like: > > cat file1.mp3 file2.mp3 > result.mp3 > > Then if file2.mp3 has gapless information, result.mp3 would stop playing > something in the middle. This happens because the gapless info directs >

Re: [FFmpeg-devel] [PATCH 1/3] configure: add noexecstack to linker options if supported.

2014-09-21 Thread Michael Niedermayer
On Sun, Sep 21, 2014 at 10:17:14AM +0100, Reimar Döffinger wrote: > Signed-off-by: Reimar Döffinger > --- > configure | 1 + > 1 file changed, 1 insertion(+) OK [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I am the wisest man alive, for I know one thing, an

Re: [FFmpeg-devel] [PATCH 0/2] Support for TrueHD streams with an Atmos substream

2014-09-21 Thread Michael Niedermayer
On Sat, Sep 20, 2014 at 11:07:53PM -0300, James Almer wrote: > On 20/09/14 10:59 PM, Michael Niedermayer wrote: > > On Sun, Sep 21, 2014 at 02:29:26AM +0200, Hendrik Leppkes wrote: > >> > >> Hey, > >> > >> this patchset adds support for playing TrueHD streams on new Blu-ray discs > >> which carry a

Re: [FFmpeg-devel] [PATCH 1/2] mlpdec: support major sync headers with optional extension blocks

2014-09-21 Thread Michael Niedermayer
On Sun, Sep 21, 2014 at 02:29:27AM +0200, Hendrik Leppkes wrote: > --- > libavcodec/mlp_parser.c | 29 - > libavcodec/mlp_parser.h | 1 + > libavcodec/mlpdec.c | 7 ++- > 3 files changed, 31 insertions(+), 6 deletions(-) applied thanks [...] -- Michael

[FFmpeg-devel] [PATCH] rtpdec_hevc: do not print an error message if the received packet has a valid header but lacks additional bytes as payload

2014-09-21 Thread Thomas Volkert
From: Thomas Volkert --- libavformat/rtpdec_hevc.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/libavformat/rtpdec_hevc.c b/libavformat/rtpdec_hevc.c index 60a97e4..4c393a9 100644 --- a/libavformat/rtpdec_hevc.c +++ b/libavformat/rtpdec_hevc.c @@ -300,6 +300

Re: [FFmpeg-devel] [PATCH 15/17] avformat/assdec: add myself to Copyright

2014-09-21 Thread Michael Niedermayer
On Sat, Sep 20, 2014 at 10:27:55PM +0200, Clément Bœsch wrote: > --- > libavformat/assdec.c | 1 + > 1 file changed, 1 insertion(+) ok [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The worst form of inequality is to try to make unequal things equal. -- Aristo

Re: [FFmpeg-devel] [PATCH] rtpenc: HEVC/H.265 support

2014-09-21 Thread Michael Niedermayer
On Sun, Sep 21, 2014 at 12:10:42PM +0200, Thomas Volkert wrote: > From: Thomas Volkert > > --- > Changelog | 1 + > libavformat/Makefile | 1 + > libavformat/rtpenc.c | 11 > libavformat/rtpenc.h | 1 + > libavformat/rtpenc_hevc.c | 146 > +

[FFmpeg-devel] [PATCH] avformat/mp3dec: avoid early EOF with concatenated gapless mp3s

2014-09-21 Thread wm4
Consider a file created with something like: cat file1.mp3 file2.mp3 > result.mp3 Then if file2.mp3 has gapless information, result.mp3 would stop playing something in the middle. This happens because the gapless info directs the decoder to discard all samples after a certain position. To mak

[FFmpeg-devel] [PATCH] rtpenc: HEVC/H.265 support

2014-09-21 Thread Thomas Volkert
From: Thomas Volkert --- Changelog | 1 + libavformat/Makefile | 1 + libavformat/rtpenc.c | 11 libavformat/rtpenc.h | 1 + libavformat/rtpenc_hevc.c | 146 ++ libavformat/version.h | 2 +- 6 files chan

Re: [FFmpeg-devel] [PATCH 2/3] configure: Set large address aware.

2014-09-21 Thread Reimar Döffinger
On 21 September 2014 10:46:33 GMT+01:00, wm4 wrote: >On Sun, 21 Sep 2014 10:17:15 +0100 >Reimar Döffinger wrote: > >> Allows 32 bit version of FFmpeg to use up to 4 GB of RAM >> instead of just 2 GB on Windows if the OS can provide it. >> >> Signed-off-by: Reimar Döffinger >> --- >> configure

Re: [FFmpeg-devel] [PATCH 2/3] configure: Set large address aware.

2014-09-21 Thread wm4
On Sun, 21 Sep 2014 10:17:15 +0100 Reimar Döffinger wrote: > Allows 32 bit version of FFmpeg to use up to 4 GB of RAM > instead of just 2 GB on Windows if the OS can provide it. > > Signed-off-by: Reimar Döffinger > --- > configure | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/conf

Re: [FFmpeg-devel] [PATCH 13/17] avformat/assdec: make sure "Comments:" events end up in the header

2014-09-21 Thread wm4
On Sun, 21 Sep 2014 11:16:49 +0200 Nicolas George wrote: > Le jour de la Récompense, an CCXXII, wm4 a écrit : > > A bit "regrettable" IMO (more work for a user if a user really wants to > > get timed comments), but surely more consistent in general (and I guess > > Comment events got lost of rein

Re: [FFmpeg-devel] [PATCH 10/17] avcodec/webvttdec: add some memory checks

2014-09-21 Thread Nicolas George
Le jour de la Raison, an CCXXII, Clément Bœsch a écrit : > --- > libavcodec/webvttdec.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) Patches 5-10 look right, except most of them could benefit from the factorization. Regards, -- Nicolas George ___

[FFmpeg-devel] [PATCH 2/3] configure: Set large address aware.

2014-09-21 Thread Reimar Döffinger
Allows 32 bit version of FFmpeg to use up to 4 GB of RAM instead of just 2 GB on Windows if the OS can provide it. Signed-off-by: Reimar Döffinger --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 2c6db81..dec1cfc 100755 --- a/configure +++ b/configure

[FFmpeg-devel] [PATCH 1/3] configure: add noexecstack to linker options if supported.

2014-09-21 Thread Reimar Döffinger
Signed-off-by: Reimar Döffinger --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index cabdbc2..2c6db81 100755 --- a/configure +++ b/configure @@ -4500,6 +4500,7 @@ EOF fi check_ldflags -Wl,--as-needed +check_ldflags -Wl,-z,noexecstack if check_func d

[FFmpeg-devel] [PATCH 3/3] [RFC] mpegts: Support seeking based on stream timestamps.

2014-09-21 Thread Reimar Döffinger
Should should fix seeking in some blurays in combination with e.g. MPlayer. Not yet tested due to no bluray at hand. Signed-off-by: Reimar Döffinger --- libavformat/mpegts.c | 8 1 file changed, 8 insertions(+) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 3434341..c04

Re: [FFmpeg-devel] [PATCH 13/17] avformat/assdec: make sure "Comments:" events end up in the header

2014-09-21 Thread Nicolas George
Le jour de la Récompense, an CCXXII, wm4 a écrit : > A bit "regrettable" IMO (more work for a user if a user really wants to > get timed comments), but surely more consistent in general (and I guess > Comment events got lost of reinterpreted as Dialogue events before > this?). For people who want

Re: [FFmpeg-devel] [PATCH 17/17] avformat/assenc: return correct error code

2014-09-21 Thread Nicolas George
Le jour de la Raison, an CCXXII, Clément Bœsch a écrit : > --- > libavformat/assenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM, of course. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://f

Re: [FFmpeg-devel] [PATCH 04/17] avcodec/mpl2dec: add some memory checks

2014-09-21 Thread Nicolas George
Le jour de la Raison, an CCXXII, Clément Bœsch a écrit : > --- > libavcodec/mpl2dec.c | 14 -- > 1 file changed, 8 insertions(+), 6 deletions(-) Looks correct. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg

Re: [FFmpeg-devel] [PATCH 03/17] avcodec/movtextdec: add some memory checks

2014-09-21 Thread Nicolas George
Le jour de la Raison, an CCXXII, Clément Bœsch a écrit : > --- > libavcodec/movtextdec.c | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c > index 05ff53a..deb7553 100644 > --- a/libavcodec/movtextdec.c > +++ b/

Re: [FFmpeg-devel] [PATCH 02/17] avcodec/microdvddec: add some memory checks

2014-09-21 Thread Nicolas George
Le jour de la Raison, an CCXXII, Clément Bœsch a écrit : > --- > libavcodec/microdvddec.c | 18 ++ > 1 file changed, 10 insertions(+), 8 deletions(-) The change looks right to me. Regards, -- Nicolas George ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH 01/17] avcodec/jacosubdec: add some memory checks

2014-09-21 Thread Nicolas George
Le jour de la Raison, an CCXXII, Clément Bœsch a écrit : > --- > libavcodec/jacosubdec.c | 12 > 1 file changed, 8 insertions(+), 4 deletions(-) Looks right. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.

Re: [FFmpeg-devel] [PATCH] avformat/assenc: mux all extradata at once

2014-09-21 Thread Nicolas George
Le jour de la Raison, an CCXXII, Clément Bœsch a écrit : > Before this commit, the code was muxing up to the 2nd line after > "[Event]" (assuming it to be the "Format:" line). The remaining are > generally "Comment:" directives which can stay in that place. mkvextract > behaves that way so it seems