[O] bug#11774: bug#11774: org-mode causes undo boundaries to be lost

2012-07-03 Thread Toby Cubitt
On Mon, Jul 02, 2012 at 08:51:48AM +0200, Martin Pohlack wrote: > > I'm still not entirely convinced that the boundary discarding logic in > > org-self-insert-command is correct. For example, if I do the following: > > > > 1. Type some text at some location in an org-mode buffer > > 2. Move to ano

[O] bug#11774: bug#11774: bug#11774: org-mode causes undo boundaries to be lost

2012-07-04 Thread Toby Cubitt
On Tue, Jul 03, 2012 at 05:18:50PM -0700, Samuel Wales wrote: > On 7/3/12, Stefan Monnier wrote: > >> self-insert-command. Even just turning that magic 20 number into a > >> variable would help. > > > > Providing it as a variable would be very easy, indeed. > > Therefore, IF we have that variable

[O] [PATCH] Fix bug in org-agenda-diary-sexp-prefix

2012-10-26 Thread Toby Cubitt
The commit message in the attached patch explains the problem, and the simple fix. Toby -- Dr T. S. Cubitt Mathematics and Quantum Information group Department of Mathematics Complutense University Madrid, Spain email: ts...@cantab.net web: www.dr-qubit.org >From b777c7ca29c74476893dd62599c344

[O] [PATCH] Separate clocksum format for durations >= 1 day

2012-10-27 Thread Toby Cubitt
Personally, I find the time duration "123:15" much harder to parse mentally than "5d 3:15". The attached patch adds a new customization option `org-time-clocksum-days-format'. When non-nil, this is used instead of `org-time-clocksum-format' for clocksum durations longer than 1 day. It gets passed

Re: [O] [PATCH] Separate clocksum format for durations >= 1 day

2012-11-05 Thread Toby Cubitt
On Mon, Nov 05, 2012 at 10:14:27AM +0100, Nicolas Goaziou wrote: > Toby Cubitt writes: > > > Personally, I find the time duration "123:15" much harder to parse > > mentally than "5d 3:15". > > > > The attached patch adds a new customization op

Re: [O] [PATCH] Separate clocksum format for durations >= 1 day

2012-11-05 Thread Toby Cubitt
On Mon, Nov 05, 2012 at 11:47:12AM +0100, Achim Gratz wrote: > Nicolas Goaziou writes: > > As you suggest, I think a better plan is to replace all of them with > > a single `org-time-clocksum-display-function'. Its expected value would > > be a function accepting 2 arguments: hours and minutes, as

Re: [O] [PATCH] Separate clocksum format for durations >= 1 day

2012-11-05 Thread Toby Cubitt
On Mon, Nov 05, 2012 at 12:13:25PM +0100, Achim Gratz wrote: > Toby Cubitt writes: > > A format string isn't sufficient. It requires the number of time > > components (days, hours, minutes, etc.) to be fixed in advance. Whereas a > > function can decide whether to displa

Re: [O] [PATCH] Separate clocksum format for durations >= 1 day

2012-11-05 Thread Toby Cubitt
On Mon, Nov 05, 2012 at 01:20:48PM +0100, Nicolas Goaziou wrote: > Toby Cubitt writes: [snip] > > [...] what about getting rid of every customization option except > > `org-time-clocksum-format', and parsing the format string itself to > > decide how many and wh

Re: [O] [PATCH] Separate clocksum format for durations >= 1 day

2012-11-05 Thread Toby Cubitt
On Mon, Nov 05, 2012 at 06:40:20PM +0100, Achim Gratz wrote: > Nicolas Goaziou writes: > > Then let's wait for Achim (Cc'ed) to illustrate what he has in mind, > > because his proposal is too vague yet to permit discussion about it. > > What I had in mind was to remove org-time-clocksum-format and

Re: [O] [PATCH] Separate clocksum format for durations >= 1 day

2012-11-06 Thread Toby Cubitt
On Mon, Nov 05, 2012 at 11:45:24PM +0100, Nicolas Goaziou wrote: > Toby Cubitt writes: > >> This is not far from your own suggestion to provide different functions > >> depending on which output is desired, I just happen to think that these > >> functions would all

Re: [O] [PATCH] Separate clocksum format for durations >= 1 day

2012-11-06 Thread Toby Cubitt
On Tue, Nov 06, 2012 at 11:57:25AM +0100, Nicolas Goaziou wrote: > Toby Cubitt writes: > > >> I still think functions are the way to go. Three options in the > >> defcustom: > >> > >> - One to provide regular time (i.e 14:40 or 3d 18:32) > >

[O] [PATCH] Make org-[beginning|end]-of-line respect visual-line-mode

2012-11-06 Thread Toby Cubitt
Subject line and commit message says it all. Toby -- Dr T. S. Cubitt Mathematics and Quantum Information group Department of Mathematics Complutense University Madrid, Spain email: ts...@cantab.net web: www.dr-qubit.org >From bca045ffd27d41630c52a67390767cd622544bb9 Mon Sep 17 00:00:00 2001 Fr

Re: [O] [PATCH] Make org-[beginning|end]-of-line respect visual-line-mode

2012-11-06 Thread Toby Cubitt
On Tue, Nov 06, 2012 at 01:31:41PM +0100, Nicolas Goaziou wrote: > Toby Cubitt writes: > > > Subject line and commit message says it all. > > `org-end-of-line' has been patched already. Is there a bug in > `org-beginning-of-line'? I forgot to pull and rebas

Re: [O] [PATCH] Separate clocksum format for durations >= 1 day

2012-11-06 Thread Toby Cubitt
On Tue, Nov 06, 2012 at 01:29:02PM +0100, Nicolas Goaziou wrote: > Toby Cubitt writes: > > > How do I produce the format "5 h 32 min" with your defcustom, without > > requiring the user to define their own function? (Assuming that 'regular > > pro

Re: [O] [PATCH] Make org-[beginning|end]-of-line respect visual-line-mode

2012-11-06 Thread Toby Cubitt
On Tue, Nov 06, 2012 at 06:02:40PM +0100, Nicolas Goaziou wrote: > Toby Cubitt writes: > > > org-beginning-of-line uses org-beginning-of-visual-line when > > line-move-visual is enabled. I'm not sure if line-mode-visual can be > > disabled when visual-line-mode is

Re: [O] [PATCH] Make org-[beginning|end]-of-line respect visual-line-mode

2012-11-06 Thread Toby Cubitt
On Tue, Nov 06, 2012 at 06:30:47PM +0100, Nicolas Goaziou wrote: > Toby Cubitt writes: > > > I'm confused. Which variable are you talking about here? > > `line-move-visual' > > > Anyway, I see that `visual-line-mode's sets `line-move-visual' to t

Re: [O] [PATCH] Make org-[beginning|end]-of-line respect visual-line-mode

2012-11-06 Thread Toby Cubitt
On Tue, Nov 06, 2012 at 06:46:27PM +0100, Nicolas Goaziou wrote: > Toby Cubitt writes: > > > Aha! You may well be right. In which case why is `org-beginning-of-line' > > doing this: > > > > (if (org-bound-and-true-p line-move-visual) > > (beginnin

Re: [O] [PATCH] Separate clocksum format for durations >= 1 day

2012-11-06 Thread Toby Cubitt
On Tue, Nov 06, 2012 at 06:41:06PM +0100, Nicolas Goaziou wrote: > Toby Cubitt writes: > > > 4. We replace the existing muddle with two defcustoms, one selecting > >regular or decimal (or user-defined function), and one specifying a > >list of standard format s

Re: [O] [PATCH] Separate clocksum format for durations >= 1 day

2012-11-06 Thread Toby Cubitt
On Tue, Nov 06, 2012 at 07:42:54PM +0100, Achim Gratz wrote: > Nicolas Goaziou writes: > > Again, these are strange and very limiting rules. What if I want to have > > "5 h 32 min"? And "5,3 days"? > > You provide a format string like you do now. That means if you want a format that's conditional

Re: [O] [PATCH] Separate clocksum format for durations >= 1 day

2012-11-06 Thread Toby Cubitt
On Tue, Nov 06, 2012 at 08:55:12PM +0100, Nicolas Goaziou wrote: > Toby Cubitt writes: > > > I doubt it can be done now, since we already allow user-defined format > > strings. > > I'm more focused on what we will be able to do. > > > Where are displ

Re: [O] end-of-line behaviour [was: (no subject)]

2012-11-07 Thread Toby Cubitt
This sounds like it might be related to recent end-of-line changes and an even more recent (not yet applied) patch I posted. On Wed, Nov 07, 2012 at 12:50:20PM -0600, Kevin Buchs wrote: > I would like to solve a problem I have: C-e (org-end-of-line) does not > move to the end of the line with long

Re: [O] [PATCH] Separate clocksum format for durations >= 1 day

2012-11-08 Thread Toby Cubitt
On Thu, Nov 08, 2012 at 01:26:48AM +0100, Nicolas Goaziou wrote: > Format string for clock lines is hard-coded (see line 1493 in > org-clock.el), which means we don't have to limit ourselves to > parse-able format. Back to point 1. Good. That's what I thought. > Then, I'm fine with format strings

Re: [O] [PATCH] Separate clocksum format for durations >= 1 day

2012-11-13 Thread Toby Cubitt
Attached is a new two-patch series implementing finer-grained control over the format of clocksum durations (only in overlays and the mode-line; the format of the CLOCK entries stored in org files remains unchanged and hard-coded, as before). The first patch: - defines a new org-minutes-to-clocksu

Re: [O] [PATCH] Separate clocksum format for durations >= 1 day

2012-11-14 Thread Toby Cubitt
On Wed, Nov 14, 2012 at 04:04:05PM +0100, Nicolas Goaziou wrote: > Toby Cubitt writes: > > Thanks for your work. Some comments below. > > > The second patch: > > - further extends org-time-clocksum-format to allow separate month and > > year components (where a m

Re: [O] [PATCH] Separate clocksum format for durations >= 1 day

2012-11-14 Thread Toby Cubitt
On Wed, Nov 14, 2012 at 05:09:38PM +0100, Nicolas Goaziou wrote: > Toby Cubitt writes: > > > I can easily allow org-time-clocksum-fractional-format to be a list of > > formats. But "1d 3.4h" doesn't seem very useful to me. Probably it should > > work

Re: [O] [PATCH] Separate clocksum format for durations >= 1 day

2012-11-16 Thread Toby Cubitt
On Wed, Nov 14, 2012 at 05:20:14PM +0100, Toby Cubitt wrote: > On Wed, Nov 14, 2012 at 05:09:38PM +0100, Nicolas Goaziou wrote: > > Toby Cubitt writes: > > > > > I can easily allow org-time-clocksum-fractional-format to be a list of > > > formats. But "1

Re: [O] [PATCH] Separate clocksum format for durations >= 1 day

2012-11-17 Thread Toby Cubitt
On Sat, Nov 17, 2012 at 09:48:09AM +0100, Nicolas Goaziou wrote: > Toby Cubitt writes: > > > Here's an updated patch. Now both org-time-clocksum-format and > > org-time-clocksum-fractional-format can be plists, as discussed. > > That was quick. Thank you. > >

Re: [O] [PATCH] Separate clocksum format for durations >= 1 day

2012-11-17 Thread Toby Cubitt
On Sat, Nov 17, 2012 at 03:42:24PM +0100, Nicolas Goaziou wrote: > Toby Cubitt writes: > > > I've replaced the cons cells with additional plist properties, as you > > suggested. The resulting customization ui still isn't wonderful in my > > opinion. But it does

Re: [O] [PATCH] Separate clocksum format for durations >= 1 day

2012-11-20 Thread Toby Cubitt
On Tue, Nov 20, 2012 at 11:12:10AM -0500, Mike McLean wrote: > On Sat, Nov 17, 2012 at 11:02 AM, Toby Cubitt wrote: > > > On Sat, Nov 17, 2012 at 03:42:24PM +0100, Nicolas Goaziou wrote: > > > Toby Cubitt writes: > > > > > > > I've replaced the

[O] Various org-mode patches

2012-01-31 Thread Toby Cubitt
I finally found time to gather various local patches to org-mode together in a public clone of the org-mode git repo, at: http://www.dr-qubit.org/git/org-mode.git Each unrelated set of changes is in a separate branch, rebased onto a recent checkout of org master. (All of the branches also merge

Re: [O] [PATCH] org-goto before headline

2012-02-10 Thread Toby Cubitt
On Fri, Feb 10, 2012 at 02:19:27PM +, Andrea Crotti wrote: > What is exactly the reason for org-goto to need to be at least in the > first headline to work? > > I always get this error when I just try to jump in the first line: > byte-code: Before first headline at position 1 in buffer .. Do

[O] [PATCH] Fix org-agenda-skip-if bug

2012-02-12 Thread Toby Cubitt
There appears to be a bug in how org-agenda-skip-if parses the list of CONDITIONS supplied to it. The combination '(nottodo todo) is a valid condition, matching todo items whose state isn't a todo-type keyword (according to the keyword types defined in `org-todo-keywords'). But `org-agenda-skip-if

[O] [PATCH] Add new '[not]todo-unblocked tests to org-agenda-skip-if

2012-02-12 Thread Toby Cubitt
This patch adds two new tests to `org-agenda-skip-if': 'todo-unblocked and 'nottodo-unblocked. These match like 'todo and 'nottodo, but only on unblocked todo items. This type of test is useful when compiling custom agenda views containing lists of currently actionable todo items. Whilst it's poss

Re: [O] [PATCH] org-goto before headline

2012-02-13 Thread Toby Cubitt
On Mon, Feb 13, 2012 at 12:08:48AM +, Andrea Crotti wrote: > On 02/10/2012 02:42 PM, Toby Cubitt wrote: > > On Fri, Feb 10, 2012 at 02:19:27PM +, Andrea Crotti wrote: > >> What is exactly the reason for org-goto to need to be at least in the > >> first headline

[O] [PATCH] Allow more control over inserted whitespace in capture templates

2012-02-13 Thread Toby Cubitt
When capturing an item as a subheading, the capture template :empty-lines property is not sufficient to ensure the correct document layout is maintained after capturing. This patch fixes the capture behaviour to insert new subheadings immediately after the previous heading (rather than immediately

Re: [O] [dev] Implement "ref" link types

2012-02-19 Thread Toby Cubitt
On Sun, Feb 19, 2012 at 08:41:45PM +0100, Nicolas Goaziou wrote: > > Suggestion: On export, how about enabling automatic element > > descriptions for references following the type:name convention, so > > that e.g. just > > > > : in [[ref:tab:numbers]] we can see... > > > > would expand to > > > >

Re: [O] bug#11249: 24.1.50; Overlay with face property causes calendar buffer to scroll

2012-04-15 Thread Toby Cubitt
On Sun, Apr 15, 2012 at 11:41:00PM +0300, Eli Zaretskii wrote: > > Date: Sun, 15 Apr 2012 21:24:39 +0200 > > From: Toby Cubitt > > > > Steps to reproduce: > > > > 1. emacs -Q > > 2. M-x calendar > > 3. M-: (setq o (make-overlay 1 2)) > &g

Re: [O] [PATCH] Allow more control over inserted whitespace in capture templates

2012-04-16 Thread Toby Cubitt
this behaviour. (Or am I missing some already-existing way of doing this? See below for a detailed description of the problem.) Toby On Mon, Feb 13, 2012 at 01:26:09PM +0100, Toby Cubitt wrote: > When capturing an item as a subheading, the capture template :empty-lines > property is not su

Re: [O] bug#11249: 24.1.50; Overlay with face property causes calendar buffer to scroll

2012-04-16 Thread Toby Cubitt
On Mon, Apr 16, 2012 at 05:50:50AM +0300, Eli Zaretskii wrote: > > Date: Sun, 15 Apr 2012 23:04:16 +0200 > > Cc: 11...@debbugs.gnu.org, emacs-orgmode@gnu.org > > From: Toby Cubitt > > > > The obvious solution is for org-mode to use a face that doesn't enlar

Re: [O] Various org-mode patches

2012-04-20 Thread Toby Cubitt
On Fri, Apr 20, 2012 at 01:59:42PM +0200, Bastien wrote: > Hi Toby, > > Toby Cubitt writes: > > > I finally found time to gather various local patches to org-mode together > > in a public clone of the org-mode git repo, at: > > > > http://www.dr-qubit.or

Re: [O] bug#11249: 24.1.50; Overlay with face property causes calendar buffer to scroll

2012-04-21 Thread Toby Cubitt
On Fri, Apr 20, 2012 at 01:57:55PM +0200, Bastien wrote: > Toby Cubitt writes: > > > On Mon, Apr 16, 2012 at 05:50:50AM +0300, Eli Zaretskii wrote: > >> > Date: Sun, 15 Apr 2012 23:04:16 +0200 > >> > Cc: 11...@debbugs.gnu.org, emacs-orgmode@gnu.org > >

Re: [O] bug#11249: 24.1.50; Overlay with face property causes calendar buffer to scroll

2012-04-22 Thread Toby Cubitt
On Sun, Apr 22, 2012 at 08:46:03AM +0200, Bastien wrote: > Toby Cubitt writes: > > Was there some reason to reject Eli's suggested fix of enlarging the > > calendar window by 1 line? As it stands, if anyone customizes the new > > org-date-selected face to be bold (t

[O] [PATCH] Extract prefix information from diary sexp entries for agenda display

2012-04-22 Thread Toby Cubitt
This patch adds a new org-agenda-diary-sexp-prefix customization option. It can be set to a regexp which is used to match the part of the text produced by a diary sexp entry that should be treated as deadlining/scheduling information (the "prefix"), and displayed as such in agenda views. For examp

[O] [PATCH] Add option to skip timestamp entries if already displayed as deadline entries in agenda

2012-04-22 Thread Toby Cubitt
This one's pretty self-explanatory. It adds an `org-agenda-skip-timestamp-if-deadline-is-shown' customization option, precisely analogous to the existing `org-agenda-skip-scheduled-if-deadline-is-shown' option. Toby -- Dr T. S. Cubitt Mathematics and Quantum Information group Department of Mathem

[O] [PATCH] Allow % escapes to capture templates, expanded to text entered in 'th prompt

2012-04-22 Thread Toby Cubitt
Currently, capture templates provide no way of prompting for some text, then inserting that text into multiple places in the template. This patch allow you to do this, by adding % escapes to the template syntax (where is a digit, 0 to 9), which expand to the text entered for the nth prompt in the

Re: [O] [PATCH] Allow % escapes to capture templates, expanded to text entered in 'th prompt

2012-04-23 Thread Toby Cubitt
On Mon, Apr 23, 2012 at 02:54:31PM +0200, Bastien wrote: > Toby Cubitt writes: > > > Currently, capture templates provide no way of prompting for some text, > > then inserting that text into multiple places in the template. > > Thanks for the patch, I applied it.

Re: [O] [PATCH] Allow % escapes to capture templates, expanded to text entered in 'th prompt

2012-04-23 Thread Toby Cubitt
On Mon, Apr 23, 2012 at 05:12:51PM +0200, Bastien wrote: > Hi Toby, > > Toby Cubitt writes: > > > Ah, I forgot about the texinfo docs. Sorry. I'll try to remember them > > next time. > > No problem. > > > - Change the regexp to "%\\([1-9][0-

Re: [O] make fails on current version

2012-04-23 Thread Toby Cubitt
On Mon, Apr 23, 2012 at 09:57:25AM -0700, Richard Stanton wrote: > I just updated org-mode and typed "make". Two problems: > > 1) The doc file seems to have trouble: > > org.texi:6703: Misplaced {. > org.texi:6703: Misplaced }. > makeinfo: Removing output file `org' due to errors; use --force to

Re: [O] [PATCH] Allow % escapes to capture templates, expanded to text entered in 'th prompt

2012-04-24 Thread Toby Cubitt
On Tue, Apr 24, 2012 at 11:57:02AM +0200, Bastien wrote: > I've pushed a change to this new feature: > http://orgmode.org/w/?p=org-mode.git;a=commit;h=1666b9 > > Using %n is not good, because it will match many escaped > strings that you don't want to match. Using %\n looks > good to me as it r

Re: [O] [PATCH] Allow % escapes to capture templates, expanded to text entered in 'th prompt

2012-04-24 Thread Toby Cubitt
On Tue, Apr 24, 2012 at 02:51:29PM +0200, Bastien wrote: > Toby Cubitt writes: > > > On Tue, Apr 24, 2012 at 11:57:02AM +0200, Bastien wrote: > >> I've pushed a change to this new feature: > >> http://orgmode.org/w/?p=org-mode.git;a=commit;h=1666b9 > >

Re: [O] Simplify repeated same section with different variable value

2012-04-24 Thread Toby Cubitt
On Tue, Apr 24, 2012 at 03:01:44PM +0200, Rainer M Krug wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 24/04/12 14:36, Myles English wrote: > >>> On Tue, 24 Apr 2012 14:22:48 +0200, Rainer M Krug said: > > > >> Hi I have a section which I want to repeat for different variable > >

Re: [O] bug#11249: 24.1.50; Overlay with face property causes calendar buffer to scroll

2012-04-26 Thread Toby Cubitt
On Thu, Apr 26, 2012 at 10:59:50AM +0200, Bastien wrote: > Hi Matt, > > Matt Lundin writes: > > > Note: It seems that adding the optional argument KEEPDATE is necessary > > for parsing to work. With the following line instead of the one above > > org-read-date works as expected: > > > > (o

Re: [O] Filter depending on item level

2012-04-30 Thread Toby Cubitt
On Sun, Apr 29, 2012 at 09:27:50PM -0500, Marcelo de Moraes Serpa wrote: > Is there a way to filter the agenda based on the level of the item. Try the special LEVEL search property, documented in the "Matching tags and properties" section of the manual. Toby -- Dr T. S. Cubitt Mathematics and Qu

[O] bug#11774: org-mode causes undo boundaries to be lost

2012-06-25 Thread Toby Cubitt
On Sun, Jun 24, 2012 at 11:52:41PM +0200, Toby Cubitt wrote: > On Sun, Jun 24, 2012 at 11:39:08PM +0200, Bastien wrote: > > Hi Toby, > > > > Toby Cubitt writes: > > > > > For some unknown reason, org-mode is causing the undo boundary between > > >

[O] Selectively archive by timestamp

2014-09-29 Thread Toby Cubitt
Sometimes I want to selectively archive all entries in a subtree with timestamps in the past, whilst keeping all entries with timestamps in the future. `org-archive-subtree' only lets you selectively archive entries depending on whether they have open TODO items. The attached patch adds a new `or

Re: [O] [PATCH] Selectively archive by timestamp

2014-12-12 Thread Toby Cubitt
troversial. (Unless someone doesn't like the choice of keybinding, in which case by all means change it!) Best, Toby On Mon, Sep 29, 2014 at 08:27:35PM +0100, Toby Cubitt wrote: > Sometimes I want to selectively archive all entries in a subtree with > timestamps in the past, whilst kee

Re: [O] [PATCH] Selectively archive by timestamp

2014-12-16 Thread Toby Cubitt
On Sat, Dec 13, 2014 at 03:23:34PM +0100, Nicolas Goaziou wrote: > > It's a fairly straightforward one, which simply adds a useful new > > archiving function without touching much else. > > > > Archiving by date seems such an obvious omission from the existing > > archiving commands, I wouldn't hav

Re: [O] [PATCH] Selectively archive by timestamp

2014-12-16 Thread Toby Cubitt
On Tue, Dec 16, 2014 at 10:52:09PM +0100, Nicolas Goaziou wrote: > Toby Cubitt writes: > > > Here it is again (attached). > > Thank you. However, could you provide an appropriate commit message > (functions modified, reason...)? > > Sorry for not catching that earl

[O] Bugs x2: fast tag selection broken, column view broken?

2013-03-28 Thread Toby Cubitt
I'm experiencing two unrelated new bugs in the latest git: 1. In agenda view, the list of fast-tag-selection keys in the `org-agenda-filter-by-tag' prompt is always empty, and fast tag selection no longer works. (I have fast-tag-selection keys configured in `org-tag-alist', and my `org-us

Re: [O] Bugs x2: fast tag selection broken, column view broken?

2013-03-28 Thread Toby Cubitt
On Thu, Mar 28, 2013 at 10:29:06PM +0100, Bastien wrote: > Hi Toby, > > Toby Cubitt writes: > > > I'm experiencing two unrelated new bugs in the latest git: > > > > 1. In agenda view, the list of fast-tag-selection keys in the > >`org-agenda-filter

Re: [O] Bugs x2: fast tag selection broken, column view broken?

2013-03-29 Thread Toby Cubitt
On Fri, Mar 29, 2013 at 12:10:10AM +, Toby Cubitt wrote: > On Thu, Mar 28, 2013 at 10:29:06PM +0100, Bastien wrote: > > > 2. Column view mode is completely broken for me. In old org files where > > >column view used to work fine, I now just get grey boxes obscuring