On Tue, Nov 06, 2012 at 06:02:40PM +0100, Nicolas Goaziou wrote: > Toby Cubitt <ts...@cantab.net> writes: > > > org-beginning-of-line uses org-beginning-of-visual-line when > > line-move-visual is enabled. I'm not sure if line-mode-visual can be > > disabled when visual-line-mode is enabled. If so, org-beginning-of-line > > should maybe test for either line-mode-visual *or* visual-line-mode. > > `beginning-of-visual-line' either set locally `line-move-visual' to t or > use `vertical-motion', which doesn't care about `lime-move-visual' > value. Thus, as one could expect, `line-move-visual' has no effect on > horizontal scrolling. > > IMO, checking this variable is a no-op.
I'm confused. Which variable are you talking about here? Anyway, I see that `visual-line-mode's sets `line-move-visual' to t buffer-locally. So checking only `line-move-visual' in `org-beginning-of-line' is fine... ...which strongly suggests that the recent fix to `org-end-of-line' is wrong. Shouldn't it also be checking `line-move-visual' and not `visual-line-mode', like `org-beginning-of-line'? > Btw, if you plan to patch this area, could you provided tests for it > (see test-org/end-of-line in test-org.el)? As I can testify, there is > a high risk of regression in that area. Thanks, I'll try to remember. Though I have no plans to patch anything else in this area. Cheers, Toby -- Dr T. S. Cubitt Mathematics and Quantum Information group Department of Mathematics Complutense University Madrid, Spain email: ts...@cantab.net web: www.dr-qubit.org
