Re: [PATCH] Re: ox-latex table tabbing support.

2022-06-26 Thread Daniel Fleischer
Kyle Meyer [2022-06-26 Sun 14:18] wrote: > Thanks for the follow-up patch. > This format doesn't quite align to the conventions. Here are two > examples: > > ,[ https://orgmode.org/worg/org-contribute.html#commit-messages ] > | * lisp/org-capture.el (org-capture-set-plist): Make sure txt is

Re: [PATCH] Re: ox-latex table tabbing support.

2022-06-26 Thread Kyle Meyer
Thanks for the follow-up patch. Daniel Fleischer writes: > Subject: [PATCH] lisp/ox-latex.el: tabbing code refactor > > * lisp/ox-latex.el: documentation, indentation, cleaning > (org-latex-table) > (org-latex--align-string-tabbing) > (org-table--org-tabbing) This format doesn't quite align to t

[PATCH] Re: ox-latex table tabbing support.

2022-06-26 Thread Daniel Fleischer
Kyle Meyer [2022-06-25 Sat 23:49] wrote: > Thanks for flagging this, Ihor. I was just glancing at this commit > (4a0d951c6) due to seeing this warning. It's doing > > (let ((align ...)) > (setq align ...)) > > where the align value is returned, so the align binding can be dropped > altoget

Re: ox-latex table tabbing support.

2022-06-26 Thread Robert Pluim
> On Sat, 25 Jun 2022 11:32:21 +0800, Ihor Radchenko > said: Ihor> em...@vergauwen.me writes: >> Hi Robert,  >> I used the instructions provide on  >> https://orgmode.org/worg/org-contribute.html#first-patch. >> For me, it was a first too, send a patch via email. Can

Re: ox-latex table tabbing support.

2022-06-25 Thread Kyle Meyer
Ihor Radchenko writes: > Daniel Fleischer writes: > >> Thank you very much for the patch. It was merged to master in 4a0d951c. >> Also, you were added to the orgmode contributes at >> https://orgmode.org/worg/contributors.html. >> >> Thanks for the contribution. > > This commit triggers > > In or

Re: ox-latex table tabbing support.

2022-06-25 Thread Ihor Radchenko
Daniel Fleischer writes: > Thank you very much for the patch. It was merged to master in 4a0d951c. > Also, you were added to the orgmode contributes at > https://orgmode.org/worg/contributors.html. > > Thanks for the contribution. This commit triggers In org-latex--align-string-tabbing: ox-late

Re: ox-latex table tabbing support.

2022-06-24 Thread Ihor Radchenko
em...@vergauwen.me writes: > Hi Robert,  > I used the instructions provide on  > https://orgmode.org/worg/org-contribute.html#first-patch. > For me, it was a first too, send a patch via email. Can I  > prevent these issues in the future or use a different method > to send my patches? I think we d

Re: ox-latex table tabbing support.

2022-06-24 Thread General discussions about Org-mode.
Hi Robert,  I used the instructions provide on  https://orgmode.org/worg/org-contribute.html#first-patch. For me, it was a first too, send a patch via email. Can I  prevent these issues in the future or use a different method to send my patches? Kind regardes, Bob  -- Sent with Tutanota, enjoy

Re: ox-latex table tabbing support.

2022-06-24 Thread Daniel Fleischer
Robert Pluim [2022-06-24 Fri 17:01] wrote: > git commit --author='Bob Vergauwen ' > > which would show you as the committer, and Bob as the author. Thanks for the tip; I wasn't aware one can use any identity to author a commit. Perhaps that's why there's an option to do GPG signing in git. Dani

Re: ox-latex table tabbing support.

2022-06-24 Thread Robert Pluim
> On Fri, 24 Jun 2022 17:20:37 +0300, Daniel Fleischer > said: Daniel> Robert Pluim [2022-06-24 Fri 15:37] wrote: >> Hi Daniel, I see this was committed with you as Author: and Bob as >> Created-by:, which is somewhat unusual. I canʼt find anything about >> Created-by in

Re: ox-latex table tabbing support.

2022-06-24 Thread Daniel Fleischer
Robert Pluim [2022-06-24 Fri 15:37] wrote: > Hi Daniel, I see this was committed with you as Author: and Bob as > Created-by:, which is somewhat unusual. I canʼt find anything about > Created-by in the descriptions of org-mode's processes (and this is > the only instance I can see in the commit l

Re: ox-latex table tabbing support.

2022-06-24 Thread Robert Pluim
> On Tue, 21 Jun 2022 07:43:12 +0300, Daniel Fleischer > said: Daniel> Hi Bob, Daniel> Thank you very much for the patch. It was merged to master in 4a0d951c. Daniel> Also, you were added to the orgmode contributes at Daniel> https://orgmode.org/worg/contributors.html.

Re: ox-latex table tabbing support.

2022-06-20 Thread Daniel Fleischer
Hi Bob, Thank you very much for the patch. It was merged to master in 4a0d951c. Also, you were added to the orgmode contributes at https://orgmode.org/worg/contributors.html. Thanks for the contribution. Best, -- Daniel Fleischer

Re: ox-latex table tabbing support.

2022-04-04 Thread General discussions about Org-mode.
Hi Ihor, Thanks for the response. I updated my patched and mailed the requested copyright form to ass...@gnu.org Kind regards, Bob  -- Sent with Tutanota, the secure & ad-free mailbox. Apr 4, 2022, 12:33 by yanta...@gmail.com: > emacs--- via "General discussions about Org-mode." > writes

Re: ox-latex table tabbing support.

2022-04-04 Thread Ihor Radchenko
emacs--- via "General discussions about Org-mode." writes: > I have implemented tabbing > (http://www.ctex.org/documents/latex/latex2e-html/ltx-58.html) support for > ox-latex. By setting #+ATTR_LATEX: :mode tabbingthe exporter will use the > tabbing environment.  > > The benefits of using tab